git.delta.rocks / unique-network / refs/commits / 0d218a2237c3

--- a/.github/workflows/ci-develop.yml
+++ b/.github/workflows/ci-develop.yml
@@ -12,25 +12,25 @@
 jobs:
 
   yarn-test-dev:
-    if: github.event.pull_request.draft == false
+    if: ${{ github.event.pull_request.draft == 'false' }}
     uses: ./.github/workflows/dev-build-tests_v2.yml
 
   unit-test:
-    if: github.event.pull_request.draft == false
+    if: ${{ github.event.pull_request.draft == 'false' }}
     uses: ./.github/workflows/unit-test_v2.yml
 
   forkless:
-    if: contains( github.event.pull_request.labels.*.name, 'forkless') 
+    if: ${{ contains( github.event.pull_request.labels.*.name, 'forkless') }}
     uses: ./.github/workflows/forkless.yml
 
   canary:
-    if: contains( github.event.pull_request.labels.*.name, 'canary')
+    if: ${{ contains( github.event.pull_request.labels.*.name, 'canary') }}
     uses: ./.github/workflows/canary.yml
     secrets: inherit # pass all secrets
 
 
   xcm:
-    if: contains( github.event.pull_request.labels.*.name, 'xcm')
+    if: ${{ contains( github.event.pull_request.labels.*.name, 'xcm') }}
     uses: ./.github/workflows/xcm.yml
     secrets: inherit # pass all secrets
 

--- a/.github/workflows/ci-master.yml
+++ b/.github/workflows/ci-master.yml
@@ -12,27 +12,27 @@
 jobs:
 
   unit-test:
-    if: github.event.pull_request.draft != true
+    if:  ${{ github.event.pull_request.draft != 'true' }}
     uses: ./.github/workflows/unit-test_v2.yml
 
   node-only-update:
-    if: github.event.pull_request.draft == false
+    if: ${{ github.event.pull_request.draft == 'false' }}
     uses: ./.github/workflows/node-only-update_v2.yml
 
   forkless:
-    if: contains( github.event.pull_request.labels.*.name, 'forkless')
+    if: ${{ contains( github.event.pull_request.labels.*.name, 'forkless') }}
     uses: ./.github/workflows/forkless.yml
 
   canary:
-    if: contains( github.event.pull_request.labels.*.name, 'canary')
+    if: ${{ contains( github.event.pull_request.labels.*.name, 'canary') }}
     uses: ./.github/workflows/canary.yml
     secrets: inherit # pass all secrets
 
   xcm:
-    if: contains( github.event.pull_request.labels.*.name, 'xcm')
+    if: ${{ contains( github.event.pull_request.labels.*.name, 'xcm') }}
     uses: ./.github/workflows/xcm.yml
     secrets: inherit # pass all secrets
 
   codestyle:
-    if: github.event.pull_request.draft == false
+    if: ${{ github.event.pull_request.draft == 'false' }}
     uses: ./.github/workflows/codestyle_v2.yml
\ No newline at end of file

8    runs-on: self-hosted-ci8    runs-on: self-hosted-ci
99
10    steps:10    steps:
11      - name: Skip if pull request is in Draft
12        # `if: github.event.pull_request.draft == true` should be kept here, at
13        # the step level, rather than at the job level. The latter is not
14        # recommended because when the PR is moved from "Draft" to "Ready to
15        # review" the workflow will immediately be passing (since it was skipped),
16        # even though it hasn't actually ran, since it takes a few seconds for
17        # the workflow to start. This is also disclosed in:
18        # https://github.community/t/dont-run-actions-on-draft-pull-requests/16817/17
19        # That scenario would open an opportunity for the check to be bypassed:
20        # 1. Get your PR approved
21        # 2. Move it to Draft
22        # 3. Push whatever commits you want
23        # 4. Move it to "Ready for review"; now the workflow is passing (it was
24        #    skipped) and "Check reviews" is also passing (it won't be updated
25        #    until the workflow is finished)
26        if: github.event.pull_request.draft == true
27        run: exit 1
28
29      - uses: actions/checkout@v311      - uses: actions/checkout@v3
30      - name: Install latest nightly12      - name: Install latest nightly
46    runs-on: self-hosted-ci28    runs-on: self-hosted-ci
47      29      
48    steps:30    steps:
49      - name: Skip if pull request is in Draft31         
50        # `if: github.event.pull_request.draft == true` should be kept here, at
51        # the step level, rather than at the job level. The latter is not
52        # recommended because when the PR is moved from "Draft" to "Ready to
53        # review" the workflow will immediately be passing (since it was skipped),
54        # even though it hasn't actually ran, since it takes a few seconds for
55        # the workflow to start. This is also disclosed in:
56        # https://github.community/t/dont-run-actions-on-draft-pull-requests/16817/17
57        # That scenario would open an opportunity for the check to be bypassed:
58        # 1. Get your PR approved
59        # 2. Move it to Draft
60        # 3. Push whatever commits you want
61        # 4. Move it to "Ready for review"; now the workflow is passing (it was
62        #    skipped) and "Check reviews" is also passing (it won't be updated
63        #    until the workflow is finished)
64        if: github.event.pull_request.draft == true
65        run: exit 1
66        
67      - uses: actions/checkout@v332      - uses: actions/checkout@v3
68      - name: Install substrate dependencies33      - name: Install substrate dependencies