git.delta.rocks / unique-network / refs/commits / 0d218a2237c3

difftreelog

fix as per documentation

Alexander Aksenov2022-09-02parent: #5ab2859.patch.diff
in: master

3 files changed

modified.github/workflows/ci-develop.ymldiffbeforeafterboth
--- a/.github/workflows/ci-develop.yml
+++ b/.github/workflows/ci-develop.yml
@@ -12,25 +12,25 @@
 jobs:
 
   yarn-test-dev:
-    if: github.event.pull_request.draft == false
+    if: ${{ github.event.pull_request.draft == 'false' }}
     uses: ./.github/workflows/dev-build-tests_v2.yml
 
   unit-test:
-    if: github.event.pull_request.draft == false
+    if: ${{ github.event.pull_request.draft == 'false' }}
     uses: ./.github/workflows/unit-test_v2.yml
 
   forkless:
-    if: contains( github.event.pull_request.labels.*.name, 'forkless') 
+    if: ${{ contains( github.event.pull_request.labels.*.name, 'forkless') }}
     uses: ./.github/workflows/forkless.yml
 
   canary:
-    if: contains( github.event.pull_request.labels.*.name, 'canary')
+    if: ${{ contains( github.event.pull_request.labels.*.name, 'canary') }}
     uses: ./.github/workflows/canary.yml
     secrets: inherit # pass all secrets
 
 
   xcm:
-    if: contains( github.event.pull_request.labels.*.name, 'xcm')
+    if: ${{ contains( github.event.pull_request.labels.*.name, 'xcm') }}
     uses: ./.github/workflows/xcm.yml
     secrets: inherit # pass all secrets
 
modified.github/workflows/ci-master.ymldiffbeforeafterboth
--- a/.github/workflows/ci-master.yml
+++ b/.github/workflows/ci-master.yml
@@ -12,27 +12,27 @@
 jobs:
 
   unit-test:
-    if: github.event.pull_request.draft != true
+    if:  ${{ github.event.pull_request.draft != 'true' }}
     uses: ./.github/workflows/unit-test_v2.yml
 
   node-only-update:
-    if: github.event.pull_request.draft == false
+    if: ${{ github.event.pull_request.draft == 'false' }}
     uses: ./.github/workflows/node-only-update_v2.yml
 
   forkless:
-    if: contains( github.event.pull_request.labels.*.name, 'forkless')
+    if: ${{ contains( github.event.pull_request.labels.*.name, 'forkless') }}
     uses: ./.github/workflows/forkless.yml
 
   canary:
-    if: contains( github.event.pull_request.labels.*.name, 'canary')
+    if: ${{ contains( github.event.pull_request.labels.*.name, 'canary') }}
     uses: ./.github/workflows/canary.yml
     secrets: inherit # pass all secrets
 
   xcm:
-    if: contains( github.event.pull_request.labels.*.name, 'xcm')
+    if: ${{ contains( github.event.pull_request.labels.*.name, 'xcm') }}
     uses: ./.github/workflows/xcm.yml
     secrets: inherit # pass all secrets
 
   codestyle:
-    if: github.event.pull_request.draft == false
+    if: ${{ github.event.pull_request.draft == 'false' }}
     uses: ./.github/workflows/codestyle_v2.yml
\ No newline at end of file
modified.github/workflows/codestyle_v2.ymldiffbeforeafterboth
before · .github/workflows/codestyle_v2.yml
1name: cargo fmt23on:4  workflow_call:56jobs:7  rustfmt:8    runs-on: self-hosted-ci910    steps:11      - name: Skip if pull request is in Draft12        # `if: github.event.pull_request.draft == true` should be kept here, at13        # the step level, rather than at the job level. The latter is not14        # recommended because when the PR is moved from "Draft" to "Ready to15        # review" the workflow will immediately be passing (since it was skipped),16        # even though it hasn't actually ran, since it takes a few seconds for17        # the workflow to start. This is also disclosed in:18        # https://github.community/t/dont-run-actions-on-draft-pull-requests/16817/1719        # That scenario would open an opportunity for the check to be bypassed:20        # 1. Get your PR approved21        # 2. Move it to Draft22        # 3. Push whatever commits you want23        # 4. Move it to "Ready for review"; now the workflow is passing (it was24        #    skipped) and "Check reviews" is also passing (it won't be updated25        #    until the workflow is finished)26        if: github.event.pull_request.draft == true27        run: exit 12829      - uses: actions/checkout@v330      - name: Install latest nightly31        uses: actions-rs/toolchain@v132        with:33            toolchain: nightly34            default: true35            target: wasm32-unknown-unknown36            components: rustfmt, clippy 37      - name: Run cargo fmt38        run: cargo fmt -- --check   # In that mode it returns only exit code.39      - name: Cargo fmt state40        if: success()41        run: echo "Nothing to do. Command 'cargo fmt -- --check' returned exit code 0."424344  clippy:45    if: ${{ false }}46    runs-on: self-hosted-ci47      48    steps:49      - name: Skip if pull request is in Draft50        # `if: github.event.pull_request.draft == true` should be kept here, at51        # the step level, rather than at the job level. The latter is not52        # recommended because when the PR is moved from "Draft" to "Ready to53        # review" the workflow will immediately be passing (since it was skipped),54        # even though it hasn't actually ran, since it takes a few seconds for55        # the workflow to start. This is also disclosed in:56        # https://github.community/t/dont-run-actions-on-draft-pull-requests/16817/1757        # That scenario would open an opportunity for the check to be bypassed:58        # 1. Get your PR approved59        # 2. Move it to Draft60        # 3. Push whatever commits you want61        # 4. Move it to "Ready for review"; now the workflow is passing (it was62        #    skipped) and "Check reviews" is also passing (it won't be updated63        #    until the workflow is finished)64        if: github.event.pull_request.draft == true65        run: exit 166        67      - uses: actions/checkout@v368      - name: Install substrate dependencies69        run: sudo apt-get install libssl-dev pkg-config libclang-dev clang70      - name: Install latest nightly71        uses: actions-rs/toolchain@v172        with:73            toolchain: nightly74            default: true75            target: wasm32-unknown-unknown76            components: rustfmt, clippy77      - name: Run cargo check78        run: cargo clippy -- -Dwarnings
after · .github/workflows/codestyle_v2.yml
1name: cargo fmt23on:4  workflow_call:56jobs:7  rustfmt:8    runs-on: self-hosted-ci910    steps:11      - uses: actions/checkout@v312      - name: Install latest nightly13        uses: actions-rs/toolchain@v114        with:15            toolchain: nightly16            default: true17            target: wasm32-unknown-unknown18            components: rustfmt, clippy 19      - name: Run cargo fmt20        run: cargo fmt -- --check   # In that mode it returns only exit code.21      - name: Cargo fmt state22        if: success()23        run: echo "Nothing to do. Command 'cargo fmt -- --check' returned exit code 0."242526  clippy:27    if: ${{ false }}28    runs-on: self-hosted-ci29      30    steps:31         32      - uses: actions/checkout@v333      - name: Install substrate dependencies34        run: sudo apt-get install libssl-dev pkg-config libclang-dev clang35      - name: Install latest nightly36        uses: actions-rs/toolchain@v137        with:38            toolchain: nightly39            default: true40            target: wasm32-unknown-unknown41            components: rustfmt, clippy42      - name: Run cargo check43        run: cargo clippy -- -Dwarnings