git.delta.rocks / unique-network / refs/commits / 0d218a2237c3

difftreelog

fix as per documentation

Alexander Aksenov2022-09-02parent: #5ab2859.patch.diff
in: master

3 files changed

modified.github/workflows/ci-develop.ymldiffbeforeafterboth
12jobs:12jobs:
1313
14 yarn-test-dev:14 yarn-test-dev:
15 if: github.event.pull_request.draft == false15 if: ${{ github.event.pull_request.draft == 'false' }}
16 uses: ./.github/workflows/dev-build-tests_v2.yml16 uses: ./.github/workflows/dev-build-tests_v2.yml
1717
18 unit-test:18 unit-test:
19 if: github.event.pull_request.draft == false19 if: ${{ github.event.pull_request.draft == 'false' }}
20 uses: ./.github/workflows/unit-test_v2.yml20 uses: ./.github/workflows/unit-test_v2.yml
2121
22 forkless:22 forkless:
23 if: contains( github.event.pull_request.labels.*.name, 'forkless') 23 if: ${{ contains( github.event.pull_request.labels.*.name, 'forkless') }}
24 uses: ./.github/workflows/forkless.yml24 uses: ./.github/workflows/forkless.yml
2525
26 canary:26 canary:
27 if: contains( github.event.pull_request.labels.*.name, 'canary')27 if: ${{ contains( github.event.pull_request.labels.*.name, 'canary') }}
28 uses: ./.github/workflows/canary.yml28 uses: ./.github/workflows/canary.yml
29 secrets: inherit # pass all secrets29 secrets: inherit # pass all secrets
3030
3131
32 xcm:32 xcm:
33 if: contains( github.event.pull_request.labels.*.name, 'xcm')33 if: ${{ contains( github.event.pull_request.labels.*.name, 'xcm') }}
34 uses: ./.github/workflows/xcm.yml34 uses: ./.github/workflows/xcm.yml
35 secrets: inherit # pass all secrets35 secrets: inherit # pass all secrets
3636
modified.github/workflows/ci-master.ymldiffbeforeafterboth
12jobs:12jobs:
1313
14 unit-test:14 unit-test:
15 if: github.event.pull_request.draft != true15 if: ${{ github.event.pull_request.draft != 'true' }}
16 uses: ./.github/workflows/unit-test_v2.yml16 uses: ./.github/workflows/unit-test_v2.yml
1717
18 node-only-update:18 node-only-update:
19 if: github.event.pull_request.draft == false19 if: ${{ github.event.pull_request.draft == 'false' }}
20 uses: ./.github/workflows/node-only-update_v2.yml20 uses: ./.github/workflows/node-only-update_v2.yml
2121
22 forkless:22 forkless:
23 if: contains( github.event.pull_request.labels.*.name, 'forkless')23 if: ${{ contains( github.event.pull_request.labels.*.name, 'forkless') }}
24 uses: ./.github/workflows/forkless.yml24 uses: ./.github/workflows/forkless.yml
2525
26 canary:26 canary:
27 if: contains( github.event.pull_request.labels.*.name, 'canary')27 if: ${{ contains( github.event.pull_request.labels.*.name, 'canary') }}
28 uses: ./.github/workflows/canary.yml28 uses: ./.github/workflows/canary.yml
29 secrets: inherit # pass all secrets29 secrets: inherit # pass all secrets
3030
31 xcm:31 xcm:
32 if: contains( github.event.pull_request.labels.*.name, 'xcm')32 if: ${{ contains( github.event.pull_request.labels.*.name, 'xcm') }}
33 uses: ./.github/workflows/xcm.yml33 uses: ./.github/workflows/xcm.yml
34 secrets: inherit # pass all secrets34 secrets: inherit # pass all secrets
3535
36 codestyle:36 codestyle:
37 if: github.event.pull_request.draft == false37 if: ${{ github.event.pull_request.draft == 'false' }}
38 uses: ./.github/workflows/codestyle_v2.yml38 uses: ./.github/workflows/codestyle_v2.yml
modified.github/workflows/codestyle_v2.ymldiffbeforeafterboth
8 runs-on: self-hosted-ci8 runs-on: self-hosted-ci
99
10 steps:10 steps:
11 - name: Skip if pull request is in Draft
12 # `if: github.event.pull_request.draft == true` should be kept here, at
13 # the step level, rather than at the job level. The latter is not
14 # recommended because when the PR is moved from "Draft" to "Ready to
15 # review" the workflow will immediately be passing (since it was skipped),
16 # even though it hasn't actually ran, since it takes a few seconds for
17 # the workflow to start. This is also disclosed in:
18 # https://github.community/t/dont-run-actions-on-draft-pull-requests/16817/17
19 # That scenario would open an opportunity for the check to be bypassed:
20 # 1. Get your PR approved
21 # 2. Move it to Draft
22 # 3. Push whatever commits you want
23 # 4. Move it to "Ready for review"; now the workflow is passing (it was
24 # skipped) and "Check reviews" is also passing (it won't be updated
25 # until the workflow is finished)
26 if: github.event.pull_request.draft == true
27 run: exit 1
28
29 - uses: actions/checkout@v311 - uses: actions/checkout@v3
30 - name: Install latest nightly12 - name: Install latest nightly
46 runs-on: self-hosted-ci28 runs-on: self-hosted-ci
47 29
48 steps:30 steps:
49 - name: Skip if pull request is in Draft31
50 # `if: github.event.pull_request.draft == true` should be kept here, at
51 # the step level, rather than at the job level. The latter is not
52 # recommended because when the PR is moved from "Draft" to "Ready to
53 # review" the workflow will immediately be passing (since it was skipped),
54 # even though it hasn't actually ran, since it takes a few seconds for
55 # the workflow to start. This is also disclosed in:
56 # https://github.community/t/dont-run-actions-on-draft-pull-requests/16817/17
57 # That scenario would open an opportunity for the check to be bypassed:
58 # 1. Get your PR approved
59 # 2. Move it to Draft
60 # 3. Push whatever commits you want
61 # 4. Move it to "Ready for review"; now the workflow is passing (it was
62 # skipped) and "Check reviews" is also passing (it won't be updated
63 # until the workflow is finished)
64 if: github.event.pull_request.draft == true
65 run: exit 1
66
67 - uses: actions/checkout@v332 - uses: actions/checkout@v3
68 - name: Install substrate dependencies33 - name: Install substrate dependencies