--- a/.github/workflows/ci-develop.yml +++ b/.github/workflows/ci-develop.yml @@ -12,25 +12,25 @@ jobs: yarn-test-dev: - if: github.event.pull_request.draft == false + if: ${{ github.event.pull_request.draft == 'false' }} uses: ./.github/workflows/dev-build-tests_v2.yml unit-test: - if: github.event.pull_request.draft == false + if: ${{ github.event.pull_request.draft == 'false' }} uses: ./.github/workflows/unit-test_v2.yml forkless: - if: contains( github.event.pull_request.labels.*.name, 'forkless') + if: ${{ contains( github.event.pull_request.labels.*.name, 'forkless') }} uses: ./.github/workflows/forkless.yml canary: - if: contains( github.event.pull_request.labels.*.name, 'canary') + if: ${{ contains( github.event.pull_request.labels.*.name, 'canary') }} uses: ./.github/workflows/canary.yml secrets: inherit # pass all secrets xcm: - if: contains( github.event.pull_request.labels.*.name, 'xcm') + if: ${{ contains( github.event.pull_request.labels.*.name, 'xcm') }} uses: ./.github/workflows/xcm.yml secrets: inherit # pass all secrets --- a/.github/workflows/ci-master.yml +++ b/.github/workflows/ci-master.yml @@ -12,27 +12,27 @@ jobs: unit-test: - if: github.event.pull_request.draft != true + if: ${{ github.event.pull_request.draft != 'true' }} uses: ./.github/workflows/unit-test_v2.yml node-only-update: - if: github.event.pull_request.draft == false + if: ${{ github.event.pull_request.draft == 'false' }} uses: ./.github/workflows/node-only-update_v2.yml forkless: - if: contains( github.event.pull_request.labels.*.name, 'forkless') + if: ${{ contains( github.event.pull_request.labels.*.name, 'forkless') }} uses: ./.github/workflows/forkless.yml canary: - if: contains( github.event.pull_request.labels.*.name, 'canary') + if: ${{ contains( github.event.pull_request.labels.*.name, 'canary') }} uses: ./.github/workflows/canary.yml secrets: inherit # pass all secrets xcm: - if: contains( github.event.pull_request.labels.*.name, 'xcm') + if: ${{ contains( github.event.pull_request.labels.*.name, 'xcm') }} uses: ./.github/workflows/xcm.yml secrets: inherit # pass all secrets codestyle: - if: github.event.pull_request.draft == false + if: ${{ github.event.pull_request.draft == 'false' }} uses: ./.github/workflows/codestyle_v2.yml \ No newline at end of file --- a/.github/workflows/codestyle_v2.yml +++ b/.github/workflows/codestyle_v2.yml @@ -8,24 +8,6 @@ runs-on: self-hosted-ci steps: - - name: Skip if pull request is in Draft - # `if: github.event.pull_request.draft == true` should be kept here, at - # the step level, rather than at the job level. The latter is not - # recommended because when the PR is moved from "Draft" to "Ready to - # review" the workflow will immediately be passing (since it was skipped), - # even though it hasn't actually ran, since it takes a few seconds for - # the workflow to start. This is also disclosed in: - # https://github.community/t/dont-run-actions-on-draft-pull-requests/16817/17 - # That scenario would open an opportunity for the check to be bypassed: - # 1. Get your PR approved - # 2. Move it to Draft - # 3. Push whatever commits you want - # 4. Move it to "Ready for review"; now the workflow is passing (it was - # skipped) and "Check reviews" is also passing (it won't be updated - # until the workflow is finished) - if: github.event.pull_request.draft == true - run: exit 1 - - uses: actions/checkout@v3 - name: Install latest nightly uses: actions-rs/toolchain@v1 @@ -46,24 +28,7 @@ runs-on: self-hosted-ci steps: - - name: Skip if pull request is in Draft - # `if: github.event.pull_request.draft == true` should be kept here, at - # the step level, rather than at the job level. The latter is not - # recommended because when the PR is moved from "Draft" to "Ready to - # review" the workflow will immediately be passing (since it was skipped), - # even though it hasn't actually ran, since it takes a few seconds for - # the workflow to start. This is also disclosed in: - # https://github.community/t/dont-run-actions-on-draft-pull-requests/16817/17 - # That scenario would open an opportunity for the check to be bypassed: - # 1. Get your PR approved - # 2. Move it to Draft - # 3. Push whatever commits you want - # 4. Move it to "Ready for review"; now the workflow is passing (it was - # skipped) and "Check reviews" is also passing (it won't be updated - # until the workflow is finished) - if: github.event.pull_request.draft == true - run: exit 1 - + - uses: actions/checkout@v3 - name: Install substrate dependencies run: sudo apt-get install libssl-dev pkg-config libclang-dev clang