git.delta.rocks / unique-network / refs/commits / 0d218a2237c3

--- a/.github/workflows/ci-develop.yml
+++ b/.github/workflows/ci-develop.yml
@@ -12,25 +12,25 @@
 jobs:
 
   yarn-test-dev:
-    if: github.event.pull_request.draft == false
+    if: ${{ github.event.pull_request.draft == 'false' }}
     uses: ./.github/workflows/dev-build-tests_v2.yml
 
   unit-test:
-    if: github.event.pull_request.draft == false
+    if: ${{ github.event.pull_request.draft == 'false' }}
     uses: ./.github/workflows/unit-test_v2.yml
 
   forkless:
-    if: contains( github.event.pull_request.labels.*.name, 'forkless') 
+    if: ${{ contains( github.event.pull_request.labels.*.name, 'forkless') }}
     uses: ./.github/workflows/forkless.yml
 
   canary:
-    if: contains( github.event.pull_request.labels.*.name, 'canary')
+    if: ${{ contains( github.event.pull_request.labels.*.name, 'canary') }}
     uses: ./.github/workflows/canary.yml
     secrets: inherit # pass all secrets
 
 
   xcm:
-    if: contains( github.event.pull_request.labels.*.name, 'xcm')
+    if: ${{ contains( github.event.pull_request.labels.*.name, 'xcm') }}
     uses: ./.github/workflows/xcm.yml
     secrets: inherit # pass all secrets
 

12jobs:12jobs:
1313
14  unit-test:14  unit-test:
15    if: github.event.pull_request.draft != true15    if:  ${{ github.event.pull_request.draft != 'true' }}
16    uses: ./.github/workflows/unit-test_v2.yml16    uses: ./.github/workflows/unit-test_v2.yml
1717
18  node-only-update:18  node-only-update:
19    if: github.event.pull_request.draft == false19    if: ${{ github.event.pull_request.draft == 'false' }}
20    uses: ./.github/workflows/node-only-update_v2.yml20    uses: ./.github/workflows/node-only-update_v2.yml
2121
22  forkless:22  forkless:
23    if: contains( github.event.pull_request.labels.*.name, 'forkless')23    if: ${{ contains( github.event.pull_request.labels.*.name, 'forkless') }}
24    uses: ./.github/workflows/forkless.yml24    uses: ./.github/workflows/forkless.yml
2525
26  canary:26  canary:
27    if: contains( github.event.pull_request.labels.*.name, 'canary')27    if: ${{ contains( github.event.pull_request.labels.*.name, 'canary') }}
28    uses: ./.github/workflows/canary.yml28    uses: ./.github/workflows/canary.yml
29    secrets: inherit # pass all secrets29    secrets: inherit # pass all secrets
3030
31  xcm:31  xcm:
32    if: contains( github.event.pull_request.labels.*.name, 'xcm')32    if: ${{ contains( github.event.pull_request.labels.*.name, 'xcm') }}
33    uses: ./.github/workflows/xcm.yml33    uses: ./.github/workflows/xcm.yml
34    secrets: inherit # pass all secrets34    secrets: inherit # pass all secrets
3535
36  codestyle:36  codestyle:
37    if: github.event.pull_request.draft == false37    if: ${{ github.event.pull_request.draft == 'false' }}
38    uses: ./.github/workflows/codestyle_v2.yml38    uses: ./.github/workflows/codestyle_v2.yml

--- a/.github/workflows/codestyle_v2.yml
+++ b/.github/workflows/codestyle_v2.yml
@@ -8,24 +8,6 @@
     runs-on: self-hosted-ci
 
     steps:
-      - name: Skip if pull request is in Draft
-        # `if: github.event.pull_request.draft == true` should be kept here, at
-        # the step level, rather than at the job level. The latter is not
-        # recommended because when the PR is moved from "Draft" to "Ready to
-        # review" the workflow will immediately be passing (since it was skipped),
-        # even though it hasn't actually ran, since it takes a few seconds for
-        # the workflow to start. This is also disclosed in:
-        # https://github.community/t/dont-run-actions-on-draft-pull-requests/16817/17
-        # That scenario would open an opportunity for the check to be bypassed:
-        # 1. Get your PR approved
-        # 2. Move it to Draft
-        # 3. Push whatever commits you want
-        # 4. Move it to "Ready for review"; now the workflow is passing (it was
-        #    skipped) and "Check reviews" is also passing (it won't be updated
-        #    until the workflow is finished)
-        if: github.event.pull_request.draft == true
-        run: exit 1
-
       - uses: actions/checkout@v3
       - name: Install latest nightly
         uses: actions-rs/toolchain@v1
@@ -46,24 +28,7 @@
     runs-on: self-hosted-ci
       
     steps:
-      - name: Skip if pull request is in Draft
-        # `if: github.event.pull_request.draft == true` should be kept here, at
-        # the step level, rather than at the job level. The latter is not
-        # recommended because when the PR is moved from "Draft" to "Ready to
-        # review" the workflow will immediately be passing (since it was skipped),
-        # even though it hasn't actually ran, since it takes a few seconds for
-        # the workflow to start. This is also disclosed in:
-        # https://github.community/t/dont-run-actions-on-draft-pull-requests/16817/17
-        # That scenario would open an opportunity for the check to be bypassed:
-        # 1. Get your PR approved
-        # 2. Move it to Draft
-        # 3. Push whatever commits you want
-        # 4. Move it to "Ready for review"; now the workflow is passing (it was
-        #    skipped) and "Check reviews" is also passing (it won't be updated
-        #    until the workflow is finished)
-        if: github.event.pull_request.draft == true
-        run: exit 1
-        
+         
       - uses: actions/checkout@v3
       - name: Install substrate dependencies
         run: sudo apt-get install libssl-dev pkg-config libclang-dev clang