difftreelog
Merge pull request #417 from UniqueNetwork/bugfix/remove_view
in: master
Remove 'view' from createNonfungibleCollection interface
5 files changed
pallets/unique/src/eth/mod.rsdiffbeforeafterboth--- a/pallets/unique/src/eth/mod.rs
+++ b/pallets/unique/src/eth/mod.rs
@@ -48,7 +48,7 @@
impl<T: Config + pallet_nonfungible::Config> EvmCollectionHelpers<T> {
#[weight(<SelfWeightOf<T>>::create_collection())]
fn create_nonfungible_collection(
- &self,
+ &mut self,
caller: caller,
name: string,
description: string,
pallets/unique/src/eth/stubs/CollectionHelpers.rawdiffbeforeafterbothbinary blob — no preview
pallets/unique/src/eth/stubs/CollectionHelpers.soldiffbeforeafterboth--- a/pallets/unique/src/eth/stubs/CollectionHelpers.sol
+++ b/pallets/unique/src/eth/stubs/CollectionHelpers.sol
@@ -36,12 +36,12 @@
string memory name,
string memory description,
string memory tokenPrefix
- ) public view returns (address) {
+ ) public returns (address) {
require(false, stub_error);
name;
description;
tokenPrefix;
- dummy;
+ dummy = 0;
return 0x0000000000000000000000000000000000000000;
}
tests/src/eth/api/CollectionHelpers.soldiffbeforeafterboth--- a/tests/src/eth/api/CollectionHelpers.sol
+++ b/tests/src/eth/api/CollectionHelpers.sol
@@ -27,7 +27,7 @@
string memory name,
string memory description,
string memory tokenPrefix
- ) external view returns (address);
+ ) external returns (address);
// Selector: isCollectionExist(address) c3de1494
function isCollectionExist(address collectionAddress)
tests/src/eth/collectionHelpersAbi.jsondiffbeforeafterboth1[2 {3 "anonymous": false,4 "inputs": [5 {6 "indexed": true,7 "internalType": "address",8 "name": "owner",9 "type": "address"10 },11 {12 "indexed": true,13 "internalType": "address",14 "name": "collectionId",15 "type": "address"16 }17 ],18 "name": "CollectionCreated",19 "type": "event"20 },21 {22 "inputs": [23 { "internalType": "string", "name": "name", "type": "string" },24 { "internalType": "string", "name": "description", "type": "string" },25 { "internalType": "string", "name": "tokenPrefix", "type": "string" }26 ],27 "name": "createNonfungibleCollection",28 "outputs": [{ "internalType": "address", "name": "", "type": "address" }],29 "stateMutability": "view",30 "type": "function"31 },32 {33 "inputs": [34 {35 "internalType": "address",36 "name": "collectionAddress",37 "type": "address"38 }39 ],40 "name": "isCollectionExist",41 "outputs": [{ "internalType": "bool", "name": "", "type": "bool" }],42 "stateMutability": "view",43 "type": "function"44 },45 {46 "inputs": [47 { "internalType": "bytes4", "name": "interfaceID", "type": "bytes4" }48 ],49 "name": "supportsInterface",50 "outputs": [{ "internalType": "bool", "name": "", "type": "bool" }],51 "stateMutability": "view",52 "type": "function"53 }54]