difftreelog
Merge pull request #417 from UniqueNetwork/bugfix/remove_view
in: master
Remove 'view' from createNonfungibleCollection interface
5 files changed
pallets/unique/src/eth/mod.rsdiffbeforeafterboth--- a/pallets/unique/src/eth/mod.rs
+++ b/pallets/unique/src/eth/mod.rs
@@ -48,7 +48,7 @@
impl<T: Config + pallet_nonfungible::Config> EvmCollectionHelpers<T> {
#[weight(<SelfWeightOf<T>>::create_collection())]
fn create_nonfungible_collection(
- &self,
+ &mut self,
caller: caller,
name: string,
description: string,
pallets/unique/src/eth/stubs/CollectionHelpers.rawdiffbeforeafterbothbinary blob — no preview
pallets/unique/src/eth/stubs/CollectionHelpers.soldiffbeforeafterboth--- a/pallets/unique/src/eth/stubs/CollectionHelpers.sol
+++ b/pallets/unique/src/eth/stubs/CollectionHelpers.sol
@@ -36,12 +36,12 @@
string memory name,
string memory description,
string memory tokenPrefix
- ) public view returns (address) {
+ ) public returns (address) {
require(false, stub_error);
name;
description;
tokenPrefix;
- dummy;
+ dummy = 0;
return 0x0000000000000000000000000000000000000000;
}
tests/src/eth/api/CollectionHelpers.soldiffbeforeafterboth27 string memory name,27 string memory name,28 string memory description,28 string memory description,29 string memory tokenPrefix29 string memory tokenPrefix30 ) external view returns (address);30 ) external returns (address);313132 // Selector: isCollectionExist(address) c3de149432 // Selector: isCollectionExist(address) c3de149433 function isCollectionExist(address collectionAddress)33 function isCollectionExist(address collectionAddress)tests/src/eth/collectionHelpersAbi.jsondiffbeforeafterboth--- a/tests/src/eth/collectionHelpersAbi.json
+++ b/tests/src/eth/collectionHelpersAbi.json
@@ -26,7 +26,7 @@
],
"name": "createNonfungibleCollection",
"outputs": [{ "internalType": "address", "name": "", "type": "address" }],
- "stateMutability": "view",
+ "stateMutability": "nonpayable",
"type": "function"
},
{