git.delta.rocks / unique-network / refs/commits / e82bbde54078

difftreelog

Merge pull request #417 from UniqueNetwork/bugfix/remove_view

kozyrevdev2022-07-05parents: #a7e0a81 #05906c7.patch.diff
in: master
Remove 'view' from createNonfungibleCollection interface

5 files changed

modifiedpallets/unique/src/eth/mod.rsdiffbeforeafterboth
--- a/pallets/unique/src/eth/mod.rs
+++ b/pallets/unique/src/eth/mod.rs
@@ -48,7 +48,7 @@
 impl<T: Config + pallet_nonfungible::Config> EvmCollectionHelpers<T> {
 	#[weight(<SelfWeightOf<T>>::create_collection())]
 	fn create_nonfungible_collection(
-		&self,
+		&mut self,
 		caller: caller,
 		name: string,
 		description: string,
modifiedpallets/unique/src/eth/stubs/CollectionHelpers.rawdiffbeforeafterboth

binary blob — no preview

modifiedpallets/unique/src/eth/stubs/CollectionHelpers.soldiffbeforeafterboth
36 string memory name,36 string memory name,
37 string memory description,37 string memory description,
38 string memory tokenPrefix38 string memory tokenPrefix
39 ) public view returns (address) {39 ) public returns (address) {
40 require(false, stub_error);40 require(false, stub_error);
41 name;41 name;
42 description;42 description;
43 tokenPrefix;43 tokenPrefix;
44 dummy;44 dummy = 0;
45 return 0x0000000000000000000000000000000000000000;45 return 0x0000000000000000000000000000000000000000;
46 }46 }
4747
modifiedtests/src/eth/api/CollectionHelpers.soldiffbeforeafterboth
--- a/tests/src/eth/api/CollectionHelpers.sol
+++ b/tests/src/eth/api/CollectionHelpers.sol
@@ -27,7 +27,7 @@
 		string memory name,
 		string memory description,
 		string memory tokenPrefix
-	) external view returns (address);
+	) external returns (address);
 
 	// Selector: isCollectionExist(address) c3de1494
 	function isCollectionExist(address collectionAddress)
modifiedtests/src/eth/collectionHelpersAbi.jsondiffbeforeafterboth
--- a/tests/src/eth/collectionHelpersAbi.json
+++ b/tests/src/eth/collectionHelpersAbi.json
@@ -26,7 +26,7 @@
     ],
     "name": "createNonfungibleCollection",
     "outputs": [{ "internalType": "address", "name": "", "type": "address" }],
-    "stateMutability": "view",
+    "stateMutability": "nonpayable",
     "type": "function"
   },
   {