git.delta.rocks / unique-network / refs/commits / e82bbde54078

difftreelog

Merge pull request #417 from UniqueNetwork/bugfix/remove_view

kozyrevdev2022-07-05parents: #a7e0a81 #05906c7.patch.diff
in: master
Remove 'view' from createNonfungibleCollection interface

5 files changed

modifiedpallets/unique/src/eth/mod.rsdiffbeforeafterboth
48impl<T: Config + pallet_nonfungible::Config> EvmCollectionHelpers<T> {48impl<T: Config + pallet_nonfungible::Config> EvmCollectionHelpers<T> {
49 #[weight(<SelfWeightOf<T>>::create_collection())]49 #[weight(<SelfWeightOf<T>>::create_collection())]
50 fn create_nonfungible_collection(50 fn create_nonfungible_collection(
51 &self,51 &mut self,
52 caller: caller,52 caller: caller,
53 name: string,53 name: string,
54 description: string,54 description: string,
modifiedpallets/unique/src/eth/stubs/CollectionHelpers.rawdiffbeforeafterboth

binary blob — no preview

modifiedpallets/unique/src/eth/stubs/CollectionHelpers.soldiffbeforeafterboth
--- a/pallets/unique/src/eth/stubs/CollectionHelpers.sol
+++ b/pallets/unique/src/eth/stubs/CollectionHelpers.sol
@@ -36,12 +36,12 @@
 		string memory name,
 		string memory description,
 		string memory tokenPrefix
-	) public view returns (address) {
+	) public returns (address) {
 		require(false, stub_error);
 		name;
 		description;
 		tokenPrefix;
-		dummy;
+		dummy = 0;
 		return 0x0000000000000000000000000000000000000000;
 	}
 
modifiedtests/src/eth/api/CollectionHelpers.soldiffbeforeafterboth
--- a/tests/src/eth/api/CollectionHelpers.sol
+++ b/tests/src/eth/api/CollectionHelpers.sol
@@ -27,7 +27,7 @@
 		string memory name,
 		string memory description,
 		string memory tokenPrefix
-	) external view returns (address);
+	) external returns (address);
 
 	// Selector: isCollectionExist(address) c3de1494
 	function isCollectionExist(address collectionAddress)
modifiedtests/src/eth/collectionHelpersAbi.jsondiffbeforeafterboth
--- a/tests/src/eth/collectionHelpersAbi.json
+++ b/tests/src/eth/collectionHelpersAbi.json
@@ -26,7 +26,7 @@
     ],
     "name": "createNonfungibleCollection",
     "outputs": [{ "internalType": "address", "name": "", "type": "address" }],
-    "stateMutability": "view",
+    "stateMutability": "nonpayable",
     "type": "function"
   },
   {