git.delta.rocks / unique-network / refs/commits / 33605551e558

difftreelog

fix(tests) resolve review comments

Maksandre2024-06-10parent: #5da2ac3.patch.diff
in: master

4 files changed

modifiedjs-packages/.vscode/settings.jsondiffbeforeafterboth
--- a/js-packages/.vscode/settings.json
+++ b/js-packages/.vscode/settings.json
@@ -4,7 +4,6 @@
 		"RUN_XCM_TESTS": "1"
 	},
 	"mochaExplorer.files": "tests/**/*.test.ts",
-	"mochaExplorer.require": "ts-node/register",
   "mochaExplorer.esmLoader": true,
   "mochaExplorer.nodeArgv": ["--loader", "ts-node/esm"],
 	"eslint.format.enable": true,
modifiedjs-packages/test-utils/util.tsdiffbeforeafterboth
--- a/js-packages/test-utils/util.ts
+++ b/js-packages/test-utils/util.ts
@@ -117,7 +117,6 @@
   Identity = 'identity',
   Democracy = 'democracy',
   Council = 'council',
-  FinancialCouncil = 'financialcouncil',
   //CouncilMembership = 'councilmembership',
   TechnicalCommittee = 'technicalcommittee',
   Fellowship = 'fellowshipcollective',
modifiedjs-packages/tests/sub/governance/financialCouncil.test.tsdiffbeforeafterboth
1import type {IKeyringPair} from '@polkadot/types/types';1import type {IKeyringPair} from '@polkadot/types/types';
2import {usingPlaygrounds, itSub, expect, Pallets, requirePalletsOrSkip, describeGov} from '@unique/test-utils/util.js';2import {usingPlaygrounds, itSub, expect, describeGov} from '@unique/test-utils/util.js';
3import {Event} from '@unique/test-utils';3import {Event} from '@unique/test-utils';
4import {democracyFastTrackVotingPeriod, IFinCounselors, clearTechComm, dummyProposalCall, initFinCouncil, clearFinCouncil, democracyLaunchPeriod, initFellowship, dummyProposal, fellowshipPropositionOrigin, defaultEnactmentMoment, initCouncil, clearCouncil, clearFellowship} from './util.js';4import {democracyFastTrackVotingPeriod, IFinCounselors, clearTechComm, dummyProposalCall, initFinCouncil, clearFinCouncil, democracyLaunchPeriod, initFellowship, dummyProposal, fellowshipPropositionOrigin, defaultEnactmentMoment, initCouncil, clearCouncil, clearFellowship} from './util.js';
55
1313
14 before(async function() {14 before(async function() {
15 await usingPlaygrounds(async (helper, privateKey) => {15 await usingPlaygrounds(async (helper, privateKey) => {
16 requirePalletsOrSkip(this, helper, [Pallets.FinancialCouncil]);
17 sudoer = await privateKey('//Alice');16 sudoer = await privateKey('//Alice');
18 donor = await privateKey({url: import.meta.url});17 donor = await privateKey({url: import.meta.url});
19 });18 });
227 )).to.be.rejectedWith('BadOrigin');226 )).to.be.rejectedWith('BadOrigin');
228 });227 });
228
229 itSub('[Negative] FinCouncil cannot add a Fellowship member', async ({helper}) => {
230 const newFellowshipMember = helper.arrange.createEmptyAccount();
231 const addMemberProposal = helper.fellowship.collective.addMemberCall(newFellowshipMember.address);
232
233 await expect(proposalFromAllFinCouncil(addMemberProposal)).to.be.rejectedWith('BadOrigin');
234 });
229235
230 itSub('[Negative] FinCouncil member can\'t add a Fellowship member', async ({helper}) => {236 itSub('[Negative] FinCouncil member cannot add a Fellowship member', async ({helper}) => {
231 const newFellowshipMember = helper.arrange.createEmptyAccount();237 const newFellowshipMember = helper.arrange.createEmptyAccount();
232 await expect(helper.finCouncil.collective.execute(238 await expect(helper.finCouncil.collective.execute(
233 finCounselors.andy,239 finCounselors.andy,
modifiedjs-packages/tests/sub/governance/technicalCommittee.test.tsdiffbeforeafterboth
--- a/js-packages/tests/sub/governance/technicalCommittee.test.ts
+++ b/js-packages/tests/sub/governance/technicalCommittee.test.ts
@@ -133,10 +133,10 @@
   itSub('[Negative] TechComm can\'t add FinCouncil member', async ({helper}) => {
     const newFinCouncilMember = helper.arrange.createEmptyAccount();
     const addMemberProposal = helper.finCouncil.membership.addMemberCall(newFinCouncilMember.address);
-    await proposalFromAllCommittee(addMemberProposal);
+    await expect(proposalFromAllCommittee(addMemberProposal)).rejectedWith('BadOrigin');
 
     const finCouncilMembers = await helper.finCouncil.membership.getMembers();
-    expect(finCouncilMembers).to.contains(newFinCouncilMember.address);
+    expect(finCouncilMembers).to.not.contains(newFinCouncilMember.address);
   });