difftreelog
fix(tests) resolve review comments
in: master
4 files changed
js-packages/.vscode/settings.jsondiffbeforeafterboth1{2 "mochaExplorer.env": {3 "RUN_GOV_TESTS": "1",4 "RUN_XCM_TESTS": "1"5 },6 "mochaExplorer.files": "tests/**/*.test.ts",7 "mochaExplorer.require": "ts-node/register",8 "mochaExplorer.esmLoader": true,9 "mochaExplorer.nodeArgv": ["--loader", "ts-node/esm"],10 "eslint.format.enable": true,11 "[javascript]": {12 "editor.defaultFormatter": "dbaeumer.vscode-eslint"13 },14 "[typescript]": {15 "editor.defaultFormatter": "dbaeumer.vscode-eslint"16 }17}js-packages/test-utils/util.tsdiffbeforeafterboth--- a/js-packages/test-utils/util.ts
+++ b/js-packages/test-utils/util.ts
@@ -117,7 +117,6 @@
Identity = 'identity',
Democracy = 'democracy',
Council = 'council',
- FinancialCouncil = 'financialcouncil',
//CouncilMembership = 'councilmembership',
TechnicalCommittee = 'technicalcommittee',
Fellowship = 'fellowshipcollective',
js-packages/tests/sub/governance/financialCouncil.test.tsdiffbeforeafterboth--- a/js-packages/tests/sub/governance/financialCouncil.test.ts
+++ b/js-packages/tests/sub/governance/financialCouncil.test.ts
@@ -1,5 +1,5 @@
import type {IKeyringPair} from '@polkadot/types/types';
-import {usingPlaygrounds, itSub, expect, Pallets, requirePalletsOrSkip, describeGov} from '@unique/test-utils/util.js';
+import {usingPlaygrounds, itSub, expect, describeGov} from '@unique/test-utils/util.js';
import {Event} from '@unique/test-utils';
import {democracyFastTrackVotingPeriod, IFinCounselors, clearTechComm, dummyProposalCall, initFinCouncil, clearFinCouncil, democracyLaunchPeriod, initFellowship, dummyProposal, fellowshipPropositionOrigin, defaultEnactmentMoment, initCouncil, clearCouncil, clearFellowship} from './util.js';
@@ -13,7 +13,6 @@
before(async function() {
await usingPlaygrounds(async (helper, privateKey) => {
- requirePalletsOrSkip(this, helper, [Pallets.FinancialCouncil]);
sudoer = await privateKey('//Alice');
donor = await privateKey({url: import.meta.url});
});
@@ -227,7 +226,14 @@
)).to.be.rejectedWith('BadOrigin');
});
- itSub('[Negative] FinCouncil member can\'t add a Fellowship member', async ({helper}) => {
+ itSub('[Negative] FinCouncil cannot add a Fellowship member', async ({helper}) => {
+ const newFellowshipMember = helper.arrange.createEmptyAccount();
+ const addMemberProposal = helper.fellowship.collective.addMemberCall(newFellowshipMember.address);
+
+ await expect(proposalFromAllFinCouncil(addMemberProposal)).to.be.rejectedWith('BadOrigin');
+ });
+
+ itSub('[Negative] FinCouncil member cannot add a Fellowship member', async ({helper}) => {
const newFellowshipMember = helper.arrange.createEmptyAccount();
await expect(helper.finCouncil.collective.execute(
finCounselors.andy,
js-packages/tests/sub/governance/technicalCommittee.test.tsdiffbeforeafterboth--- a/js-packages/tests/sub/governance/technicalCommittee.test.ts
+++ b/js-packages/tests/sub/governance/technicalCommittee.test.ts
@@ -133,10 +133,10 @@
itSub('[Negative] TechComm can\'t add FinCouncil member', async ({helper}) => {
const newFinCouncilMember = helper.arrange.createEmptyAccount();
const addMemberProposal = helper.finCouncil.membership.addMemberCall(newFinCouncilMember.address);
- await proposalFromAllCommittee(addMemberProposal);
+ await expect(proposalFromAllCommittee(addMemberProposal)).rejectedWith('BadOrigin');
const finCouncilMembers = await helper.finCouncil.membership.getMembers();
- expect(finCouncilMembers).to.contains(newFinCouncilMember.address);
+ expect(finCouncilMembers).to.not.contains(newFinCouncilMember.address);
});