difftreelog
fix(tests) resolve review comments
in: master
4 files changed
js-packages/.vscode/settings.jsondiffbeforeafterboth4 "RUN_XCM_TESTS": "1"4 "RUN_XCM_TESTS": "1"5 },5 },6 "mochaExplorer.files": "tests/**/*.test.ts",6 "mochaExplorer.files": "tests/**/*.test.ts",7 "mochaExplorer.require": "ts-node/register",8 "mochaExplorer.esmLoader": true,7 "mochaExplorer.esmLoader": true,9 "mochaExplorer.nodeArgv": ["--loader", "ts-node/esm"],8 "mochaExplorer.nodeArgv": ["--loader", "ts-node/esm"],10 "eslint.format.enable": true,9 "eslint.format.enable": true,js-packages/test-utils/util.tsdiffbeforeafterboth117 Identity = 'identity',117 Identity = 'identity',118 Democracy = 'democracy',118 Democracy = 'democracy',119 Council = 'council',119 Council = 'council',120 FinancialCouncil = 'financialcouncil',121 //CouncilMembership = 'councilmembership',120 //CouncilMembership = 'councilmembership',122 TechnicalCommittee = 'technicalcommittee',121 TechnicalCommittee = 'technicalcommittee',123 Fellowship = 'fellowshipcollective',122 Fellowship = 'fellowshipcollective',js-packages/tests/sub/governance/financialCouncil.test.tsdiffbeforeafterboth1import type {IKeyringPair} from '@polkadot/types/types';1import type {IKeyringPair} from '@polkadot/types/types';2import {usingPlaygrounds, itSub, expect, Pallets, requirePalletsOrSkip, describeGov} from '@unique/test-utils/util.js';2import {usingPlaygrounds, itSub, expect, describeGov} from '@unique/test-utils/util.js';3import {Event} from '@unique/test-utils';3import {Event} from '@unique/test-utils';4import {democracyFastTrackVotingPeriod, IFinCounselors, clearTechComm, dummyProposalCall, initFinCouncil, clearFinCouncil, democracyLaunchPeriod, initFellowship, dummyProposal, fellowshipPropositionOrigin, defaultEnactmentMoment, initCouncil, clearCouncil, clearFellowship} from './util.js';4import {democracyFastTrackVotingPeriod, IFinCounselors, clearTechComm, dummyProposalCall, initFinCouncil, clearFinCouncil, democracyLaunchPeriod, initFellowship, dummyProposal, fellowshipPropositionOrigin, defaultEnactmentMoment, initCouncil, clearCouncil, clearFellowship} from './util.js';55131314 before(async function() {14 before(async function() {15 await usingPlaygrounds(async (helper, privateKey) => {15 await usingPlaygrounds(async (helper, privateKey) => {16 requirePalletsOrSkip(this, helper, [Pallets.FinancialCouncil]);17 sudoer = await privateKey('//Alice');16 sudoer = await privateKey('//Alice');18 donor = await privateKey({url: import.meta.url});17 donor = await privateKey({url: import.meta.url});19 });18 });227 )).to.be.rejectedWith('BadOrigin');226 )).to.be.rejectedWith('BadOrigin');228 });227 });228229 itSub('[Negative] FinCouncil cannot add a Fellowship member', async ({helper}) => {230 const newFellowshipMember = helper.arrange.createEmptyAccount();231 const addMemberProposal = helper.fellowship.collective.addMemberCall(newFellowshipMember.address);232233 await expect(proposalFromAllFinCouncil(addMemberProposal)).to.be.rejectedWith('BadOrigin');234 });229235230 itSub('[Negative] FinCouncil member can\'t add a Fellowship member', async ({helper}) => {236 itSub('[Negative] FinCouncil member cannot add a Fellowship member', async ({helper}) => {231 const newFellowshipMember = helper.arrange.createEmptyAccount();237 const newFellowshipMember = helper.arrange.createEmptyAccount();232 await expect(helper.finCouncil.collective.execute(238 await expect(helper.finCouncil.collective.execute(233 finCounselors.andy,239 finCounselors.andy,js-packages/tests/sub/governance/technicalCommittee.test.tsdiffbeforeafterboth133 itSub('[Negative] TechComm can\'t add FinCouncil member', async ({helper}) => {133 itSub('[Negative] TechComm can\'t add FinCouncil member', async ({helper}) => {134 const newFinCouncilMember = helper.arrange.createEmptyAccount();134 const newFinCouncilMember = helper.arrange.createEmptyAccount();135 const addMemberProposal = helper.finCouncil.membership.addMemberCall(newFinCouncilMember.address);135 const addMemberProposal = helper.finCouncil.membership.addMemberCall(newFinCouncilMember.address);136 await proposalFromAllCommittee(addMemberProposal);136 await expect(proposalFromAllCommittee(addMemberProposal)).rejectedWith('BadOrigin');137137138 const finCouncilMembers = await helper.finCouncil.membership.getMembers();138 const finCouncilMembers = await helper.finCouncil.membership.getMembers();139 expect(finCouncilMembers).to.contains(newFinCouncilMember.address);139 expect(finCouncilMembers).to.not.contains(newFinCouncilMember.address);140 });140 });141141142142