git.delta.rocks / unique-network / refs/commits / 73817f448a72

difftreelog

test upgrade benchmarks for new substrate

Yaroslav Bolyukin2022-02-26parent: #c9e84df.patch.diff
in: master

12 files changed

modified.maintain/frame-weight-template.hbsdiffbeforeafterboth
--- a/.maintain/frame-weight-template.hbs
+++ b/.maintain/frame-weight-template.hbs
@@ -7,7 +7,7 @@
 //! EXECUTION: {{cmd.execution}}, WASM-EXECUTION: {{cmd.wasm_execution}}, CHAIN: {{cmd.chain}}, DB CACHE: {{cmd.db_cache}}
 
 // Executed Command:
-{{#each args as |arg|~}}
+{{#each args as |arg|}}
 // {{arg}}
 {{/each}}
 
@@ -21,76 +21,80 @@
 
 /// Weight functions needed for {{pallet}}.
 pub trait WeightInfo {
-	{{~#each benchmarks as |benchmark|}}
+	{{#each benchmarks as |benchmark|}}
 	fn {{benchmark.name~}}
 	(
 		{{~#each benchmark.components as |c| ~}}
 		{{c.name}}: u32, {{/each~}}
 	) -> Weight;
-	{{~/each}}
+	{{/each}}
 }
 
 /// Weights for {{pallet}} using the Substrate node and recommended hardware.
 pub struct SubstrateWeight<T>(PhantomData<T>);
+{{#if (eq pallet "frame_system")}}
+impl<T: crate::Config> WeightInfo for SubstrateWeight<T> {
+{{else}}
 impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
-	{{~#each benchmarks as |benchmark|}}
-	{{~#each benchmark.comments as |comment|}}
+{{/if}}
+	{{#each benchmarks as |benchmark|}}
+	{{#each benchmark.comments as |comment|}}
 	// {{comment}}
-	{{~/each}}
+	{{/each}}
 	fn {{benchmark.name~}}
 	(
 		{{~#each benchmark.components as |c| ~}}
 		{{~#if (not c.is_used)}}_{{/if}}{{c.name}}: u32, {{/each~}}
 	) -> Weight {
 		({{underscore benchmark.base_weight}} as Weight)
-			{{~#each benchmark.component_weight as |cw|}}
+			{{#each benchmark.component_weight as |cw|}}
 			// Standard Error: {{underscore cw.error}}
 			.saturating_add(({{underscore cw.slope}} as Weight).saturating_mul({{cw.name}} as Weight))
-			{{~/each}}
-			{{~#if (ne benchmark.base_reads "0")}}
+			{{/each}}
+			{{#if (ne benchmark.base_reads "0")}}
 			.saturating_add(T::DbWeight::get().reads({{benchmark.base_reads}} as Weight))
-			{{~/if}}
-			{{~#each benchmark.component_reads as |cr|}}
+			{{/if}}
+			{{#each benchmark.component_reads as |cr|}}
 			.saturating_add(T::DbWeight::get().reads(({{cr.slope}} as Weight).saturating_mul({{cr.name}} as Weight)))
-			{{~/each}}
-			{{~#if (ne benchmark.base_writes "0")}}
+			{{/each}}
+			{{#if (ne benchmark.base_writes "0")}}
 			.saturating_add(T::DbWeight::get().writes({{benchmark.base_writes}} as Weight))
-			{{~/if}}
-			{{~#each benchmark.component_writes as |cw|}}
+			{{/if}}
+			{{#each benchmark.component_writes as |cw|}}
 			.saturating_add(T::DbWeight::get().writes(({{cw.slope}} as Weight).saturating_mul({{cw.name}} as Weight)))
-			{{~/each}}
+			{{/each}}
 	}
-	{{~/each}}
+	{{/each}}
 }
 
 // For backwards compatibility and tests
 impl WeightInfo for () {
-	{{~#each benchmarks as |benchmark|}}
-	{{~#each benchmark.comments as |comment|}}
+	{{#each benchmarks as |benchmark|}}
+	{{#each benchmark.comments as |comment|}}
 	// {{comment}}
-	{{~/each}}
+	{{/each}}
 	fn {{benchmark.name~}}
 	(
 		{{~#each benchmark.components as |c| ~}}
 		{{~#if (not c.is_used)}}_{{/if}}{{c.name}}: u32, {{/each~}}
 	) -> Weight {
 		({{underscore benchmark.base_weight}} as Weight)
-			{{~#each benchmark.component_weight as |cw|}}
+			{{#each benchmark.component_weight as |cw|}}
 			// Standard Error: {{underscore cw.error}}
 			.saturating_add(({{underscore cw.slope}} as Weight).saturating_mul({{cw.name}} as Weight))
-			{{~/each}}
-			{{~#if (ne benchmark.base_reads "0")}}
+			{{/each}}
+			{{#if (ne benchmark.base_reads "0")}}
 			.saturating_add(RocksDbWeight::get().reads({{benchmark.base_reads}} as Weight))
-			{{~/if}}
-			{{~#each benchmark.component_reads as |cr|}}
+			{{/if}}
+			{{#each benchmark.component_reads as |cr|}}
 			.saturating_add(RocksDbWeight::get().reads(({{cr.slope}} as Weight).saturating_mul({{cr.name}} as Weight)))
-			{{~/each}}
-			{{~#if (ne benchmark.base_writes "0")}}
+			{{/each}}
+			{{#if (ne benchmark.base_writes "0")}}
 			.saturating_add(RocksDbWeight::get().writes({{benchmark.base_writes}} as Weight))
-			{{~/if}}
-			{{~#each benchmark.component_writes as |cw|}}
+			{{/if}}
+			{{#each benchmark.component_writes as |cw|}}
 			.saturating_add(RocksDbWeight::get().writes(({{cw.slope}} as Weight).saturating_mul({{cw.name}} as Weight)))
-			{{~/each}}
+			{{/each}}
 	}
-	{{~/each}}
+	{{/each}}
 }
modifiedpallets/common/src/benchmarking.rsdiffbeforeafterboth
--- a/pallets/common/src/benchmarking.rs
+++ b/pallets/common/src/benchmarking.rs
@@ -1,64 +1,87 @@
 use sp_std::vec::Vec;
 use crate::{Config, CollectionHandle};
 use up_data_structs::{
-	CollectionMode, Collection, CollectionId, MAX_COLLECTION_NAME_LENGTH,
+	CollectionMode, CreateCollectionData, CollectionId, MAX_COLLECTION_NAME_LENGTH,
 	MAX_COLLECTION_DESCRIPTION_LENGTH, MAX_TOKEN_PREFIX_LENGTH, OFFCHAIN_SCHEMA_LIMIT,
 	VARIABLE_ON_CHAIN_SCHEMA_LIMIT, CONST_ON_CHAIN_SCHEMA_LIMIT,
 };
-use frame_support::traits::{Currency, Get};
+use frame_support::{
+	traits::{Currency, Get},
+	pallet_prelude::ConstU32,
+	BoundedVec,
+};
 use core::convert::TryInto;
 use sp_runtime::DispatchError;
 
-pub fn create_data(size: usize) -> Vec<u8> {
-	(0..size).map(|v| (v & 0xff) as u8).collect()
+pub fn create_data<const S: u32>() -> BoundedVec<u8, ConstU32<S>> {
+	create_var_data::<S>(S)
 }
-pub fn create_u16_data(size: usize) -> Vec<u16> {
-	(0..size).map(|v| (v & 0xffff) as u16).collect()
+pub fn create_u16_data<const S: u32>() -> BoundedVec<u16, ConstU32<S>> {
+	(0..S)
+		.map(|v| (v & 0xffff) as u16)
+		.collect::<Vec<_>>()
+		.try_into()
+		.unwrap()
+}
+pub fn create_var_data<const S: u32>(size: u32) -> BoundedVec<u8, ConstU32<S>> {
+	assert!(
+		size <= S,
+		"size ({}) should be less within bound ({})",
+		size,
+		S
+	);
+	(0..size)
+		.map(|v| (v & 0xff) as u8)
+		.collect::<Vec<_>>()
+		.try_into()
+		.unwrap()
 }
 
 pub fn create_collection_raw<T: Config, R>(
 	owner: T::AccountId,
 	mode: CollectionMode,
-	handler: impl FnOnce(Collection<T::AccountId>) -> Result<CollectionId, DispatchError>,
+	handler: impl FnOnce(
+		T::AccountId,
+		CreateCollectionData<T::AccountId>,
+	) -> Result<CollectionId, DispatchError>,
 	cast: impl FnOnce(CollectionHandle<T>) -> R,
 ) -> Result<R, DispatchError> {
 	T::Currency::deposit_creating(&owner, T::CollectionCreationPrice::get());
-	let name = create_u16_data(MAX_COLLECTION_NAME_LENGTH)
-		.try_into()
-		.unwrap();
-	let description = create_u16_data(MAX_COLLECTION_DESCRIPTION_LENGTH)
-		.try_into()
-		.unwrap();
-	let token_prefix = create_data(MAX_TOKEN_PREFIX_LENGTH).try_into().unwrap();
-	let offchain_schema = create_data(OFFCHAIN_SCHEMA_LIMIT as usize)
-		.try_into()
-		.unwrap();
-	let variable_on_chain_schema = create_data(VARIABLE_ON_CHAIN_SCHEMA_LIMIT as usize)
-		.try_into()
-		.unwrap();
-	let const_on_chain_schema = create_data(CONST_ON_CHAIN_SCHEMA_LIMIT as usize)
-		.try_into()
-		.unwrap();
-	handler(Collection {
+	let name = create_u16_data::<MAX_COLLECTION_NAME_LENGTH>();
+	let description = create_u16_data::<MAX_COLLECTION_DESCRIPTION_LENGTH>();
+	let token_prefix = create_data::<MAX_TOKEN_PREFIX_LENGTH>();
+	let offchain_schema = create_data::<OFFCHAIN_SCHEMA_LIMIT>();
+	let variable_on_chain_schema = create_data::<VARIABLE_ON_CHAIN_SCHEMA_LIMIT>();
+	let const_on_chain_schema = create_data::<CONST_ON_CHAIN_SCHEMA_LIMIT>();
+	handler(
 		owner,
-		mode,
-		access: Default::default(),
-		name,
-		description,
-		token_prefix,
-		mint_mode: true,
-		offchain_schema,
-		schema_version: Default::default(),
-		sponsorship: Default::default(),
-		limits: Default::default(),
-		variable_on_chain_schema,
-		const_on_chain_schema,
-		meta_update_permission: Default::default(),
-	})
+		CreateCollectionData {
+			mode,
+			name,
+			description,
+			token_prefix,
+			offchain_schema,
+			variable_on_chain_schema,
+			const_on_chain_schema,
+			..Default::default()
+		},
+	)
 	.and_then(CollectionHandle::try_get)
 	.map(cast)
 }
 
+/// Helper macros, which handles all benchmarking preparation in semi-declarative way
+///
+/// `name` is a substrate account
+/// - name: sub[(id)]
+/// `name` is a collection with owner `owner`
+/// - name: collection(owner)
+/// `name` is a cross account based on substrate
+/// - name: cross_sub[(id)]
+/// `name` is a cross account, which maps to substrate account `name`
+/// - name: cross_from_sub
+/// `name` is a cross account, which maps to substrate account `other_name`
+/// - name: cross_from_sub(other_name)
 #[macro_export]
 macro_rules! bench_init {
 	($name:ident: sub $(($id:expr))?; $($rest:tt)*) => {
modifiedpallets/fungible/src/common.rsdiffbeforeafterboth
--- a/pallets/fungible/src/common.rs
+++ b/pallets/fungible/src/common.rs
@@ -12,7 +12,7 @@
 };
 
 pub struct CommonWeights<T: Config>(PhantomData<T>);
-impl<T: Config> CommonWeightInfo for CommonWeights<T> {
+impl<T: Config> CommonWeightInfo<T::CrossAccountId> for CommonWeights<T> {
 	fn create_item() -> Weight {
 		<SelfWeightOf<T>>::create_item()
 	}
modifiedpallets/fungible/src/lib.rsdiffbeforeafterboth
--- a/pallets/fungible/src/lib.rs
+++ b/pallets/fungible/src/lib.rs
@@ -9,7 +9,7 @@
 use pallet_evm_coder_substrate::WithRecorder;
 use sp_core::H160;
 use sp_runtime::{ArithmeticError, DispatchError, DispatchResult};
-use sp_std::{vec::Vec, vec, collections::btree_map::BTreeMap};
+use sp_std::collections::btree_map::BTreeMap;
 
 pub use pallet::*;
 
@@ -222,7 +222,7 @@
 	pub fn create_multiple_items(
 		collection: &FungibleHandle<T>,
 		sender: &T::CrossAccountId,
-		data: Vec<CreateItemData<T>>,
+		data: BTreeMap<T::CrossAccountId, u128>,
 	) -> DispatchResult {
 		if !collection.is_owner_or_admin(sender) {
 			ensure!(
@@ -236,22 +236,18 @@
 			}
 		}
 
-		let mut balances = BTreeMap::new();
-
 		let total_supply = data
 			.iter()
-			.map(|u| u.1)
+			.map(|(_, v)| *v)
 			.try_fold(<TotalSupply<T>>::get(collection.id), |acc, v| {
 				acc.checked_add(v)
 			})
 			.ok_or(ArithmeticError::Overflow)?;
 
-		for (user, amount) in data.into_iter() {
-			let balance = balances
-				.entry(user.clone())
-				.or_insert_with(|| <Balance<T>>::get((collection.id, user)));
-			*balance = (*balance)
-				.checked_add(amount)
+		let mut balances = data;
+		for (k, v) in balances.iter_mut() {
+			*v = <Balance<T>>::get((collection.id, &k))
+				.checked_add(*v)
 				.ok_or(ArithmeticError::Overflow)?;
 		}
 
modifiedpallets/inflation/src/benchmarking.rsdiffbeforeafterboth
--- a/pallets/inflation/src/benchmarking.rs
+++ b/pallets/inflation/src/benchmarking.rs
@@ -1,7 +1,7 @@
 #![cfg(feature = "runtime-benchmarks")]
 
 use super::*;
-use crate::Module as Inflation;
+use crate::Pallet as Inflation;
 
 use frame_benchmarking::{benchmarks};
 use frame_support::traits::OnInitialize;
modifiedpallets/nonfungible/src/benchmarking.rsdiffbeforeafterboth
--- a/pallets/nonfungible/src/benchmarking.rs
+++ b/pallets/nonfungible/src/benchmarking.rs
@@ -2,18 +2,18 @@
 use crate::{Pallet, Config, NonfungibleHandle};
 
 use sp_std::prelude::*;
-use pallet_common::benchmarking::{create_collection_raw, create_data};
+use pallet_common::benchmarking::{create_collection_raw, create_data, create_var_data};
 use frame_benchmarking::{benchmarks, account};
-use up_data_structs::{CollectionMode, MAX_ITEMS_PER_BATCH};
+use up_data_structs::{CollectionMode, MAX_ITEMS_PER_BATCH, CUSTOM_DATA_LIMIT};
 use pallet_common::bench_init;
 use core::convert::TryInto;
 
 const SEED: u32 = 1;
 
 fn create_max_item_data<T: Config>(owner: T::CrossAccountId) -> CreateItemData<T> {
-	let const_data = create_data(CUSTOM_DATA_LIMIT as usize).try_into().unwrap();
-	let variable_data = create_data(CUSTOM_DATA_LIMIT as usize).try_into().unwrap();
-	CreateItemData {
+	let const_data = create_data::<CUSTOM_DATA_LIMIT>();
+	let variable_data = create_data::<CUSTOM_DATA_LIMIT>();
+	CreateItemData::<T> {
 		const_data,
 		variable_data,
 		owner,
@@ -24,7 +24,7 @@
 	sender: &T::CrossAccountId,
 	owner: T::CrossAccountId,
 ) -> Result<TokenId, DispatchError> {
-	<Pallet<T>>::create_item(&collection, sender, create_max_item_data(owner))?;
+	<Pallet<T>>::create_item(&collection, sender, create_max_item_data::<T>(owner))?;
 	Ok(TokenId(<TokensMinted<T>>::get(&collection.id)))
 }
 
@@ -53,7 +53,9 @@
 			owner: sub; collection: collection(owner);
 			sender: cross_from_sub(owner); to: cross_sub;
 		};
-		let data = (0..b).map(|_| create_max_item_data(to.clone())).collect();
+		let data = (0..b).map(|_| create_max_item_data::<T>(to.clone())).collect();
+	}: {<Pallet<T>>::create_multiple_items(&collection, &sender, data)?}
+
 	}: {<Pallet<T>>::create_multiple_items(&collection, &sender, data)?}
 
 	burn_item {
@@ -105,6 +107,6 @@
 			owner: cross_from_sub; sender: cross_sub;
 		};
 		let item = create_max_item(&collection, &owner, sender.clone())?;
-		let data = create_data(b as usize);
+		let data = create_var_data(b).try_into().unwrap();
 	}: {<Pallet<T>>::set_variable_metadata(&collection, &sender, item, data)?}
 }
modifiedpallets/nonfungible/src/common.rsdiffbeforeafterboth
--- a/pallets/nonfungible/src/common.rs
+++ b/pallets/nonfungible/src/common.rs
@@ -12,7 +12,7 @@
 };
 
 pub struct CommonWeights<T: Config>(PhantomData<T>);
-impl<T: Config> CommonWeightInfo for CommonWeights<T> {
+impl<T: Config> CommonWeightInfo<T::CrossAccountId> for CommonWeights<T> {
 	fn create_item() -> Weight {
 		<SelfWeightOf<T>>::create_item()
 	}
@@ -51,7 +51,7 @@
 	to: &T::CrossAccountId,
 ) -> Result<CreateItemData<T>, DispatchError> {
 	match data {
-		up_data_structs::CreateItemData::NFT(data) => Ok(CreateItemData {
+		up_data_structs::CreateItemData::NFT(data) => Ok(CreateItemData::<T> {
 			const_data: data.const_data,
 			variable_data: data.variable_data,
 			owner: to.clone(),
@@ -68,7 +68,7 @@
 		data: up_data_structs::CreateItemData,
 	) -> DispatchResultWithPostInfo {
 		with_weight(
-			<Pallet<T>>::create_item(self, &sender, map_create_data(data, &to)?),
+			<Pallet<T>>::create_item(self, &sender, map_create_data::<T>(data, &to)?),
 			<CommonWeights<T>>::create_item(),
 		)
 	}
modifiedpallets/nonfungible/src/erc.rsdiffbeforeafterboth
--- a/pallets/nonfungible/src/erc.rs
+++ b/pallets/nonfungible/src/erc.rs
@@ -232,7 +232,7 @@
 		<Pallet<T>>::create_item(
 			self,
 			&caller,
-			CreateItemData {
+			CreateItemData::<T> {
 				const_data: BoundedVec::default(),
 				variable_data: BoundedVec::default(),
 				owner: to,
@@ -268,7 +268,7 @@
 		<Pallet<T>>::create_item(
 			self,
 			&caller,
-			CreateItemData {
+			CreateItemData::<T> {
 				const_data: Vec::<u8>::from(token_uri)
 					.try_into()
 					.map_err(|_| "token uri is too long")?,
@@ -376,7 +376,7 @@
 			expected_index = expected_index.checked_add(1).ok_or("item id overflow")?;
 		}
 		let data = (0..total_tokens)
-			.map(|_| CreateItemData {
+			.map(|_| CreateItemData::<T> {
 				const_data: BoundedVec::default(),
 				variable_data: BoundedVec::default(),
 				owner: to.clone(),
@@ -409,7 +409,7 @@
 			}
 			expected_index = expected_index.checked_add(1).ok_or("item id overflow")?;
 
-			data.push(CreateItemData {
+			data.push(CreateItemData::<T> {
 				const_data: Vec::<u8>::from(token_uri)
 					.try_into()
 					.map_err(|_| "token uri is too long")?,
modifiedpallets/refungible/src/benchmarking.rsdiffbeforeafterboth
--- a/pallets/refungible/src/benchmarking.rs
+++ b/pallets/refungible/src/benchmarking.rs
@@ -2,24 +2,28 @@
 use crate::{Pallet, Config, RefungibleHandle};
 
 use sp_std::prelude::*;
-use pallet_common::benchmarking::{create_collection_raw, create_data};
+use pallet_common::benchmarking::{create_collection_raw, create_data, create_var_data};
 use frame_benchmarking::{benchmarks, account};
-use up_data_structs::{CollectionMode, MAX_ITEMS_PER_BATCH};
+use up_data_structs::{CollectionMode, MAX_ITEMS_PER_BATCH, CUSTOM_DATA_LIMIT};
 use pallet_common::bench_init;
 use core::convert::TryInto;
 use core::iter::IntoIterator;
 
 const SEED: u32 = 1;
 
-fn create_max_item_data<T: Config>(
-	users: impl IntoIterator<Item = (T::CrossAccountId, u128)>,
-) -> CreateItemData<T> {
-	let const_data = create_data(CUSTOM_DATA_LIMIT as usize).try_into().unwrap();
-	let variable_data = create_data(CUSTOM_DATA_LIMIT as usize).try_into().unwrap();
-	CreateItemData {
+fn create_max_item_data<CrossAccountId: Ord>(
+	users: impl IntoIterator<Item = (CrossAccountId, u128)>,
+) -> CreateRefungibleExData<CrossAccountId> {
+	let const_data = create_data::<CUSTOM_DATA_LIMIT>();
+	let variable_data = create_data::<CUSTOM_DATA_LIMIT>();
+	CreateRefungibleExData {
 		const_data,
 		variable_data,
-		users: users.into_iter().collect(),
+		users: users
+			.into_iter()
+			.collect::<BTreeMap<_, _>>()
+			.try_into()
+			.unwrap(),
 	}
 }
 fn create_max_item<T: Config>(
modifiedpallets/refungible/src/common.rsdiffbeforeafterboth
before · pallets/refungible/src/common.rs
1use core::marker::PhantomData;23use sp_std::collections::btree_map::BTreeMap;4use frame_support::{dispatch::DispatchResultWithPostInfo, fail, weights::Weight, BoundedVec};5use up_data_structs::{TokenId, CustomDataLimit};6use pallet_common::{CommonCollectionOperations, CommonWeightInfo, with_weight};7use sp_runtime::DispatchError;8use sp_std::vec::Vec;910use crate::{11	AccountBalance, Allowance, Balance, Config, CreateItemData, Error, Owned, Pallet,12	RefungibleHandle, SelfWeightOf, TokenData, weights::WeightInfo, TokensMinted,13};1415macro_rules! max_weight_of {16	($($method:ident ($($args:tt)*)),*) => {17		018		$(19			.max(<SelfWeightOf<T>>::$method($($args)*))20		)*21	};22}2324pub struct CommonWeights<T: Config>(PhantomData<T>);25impl<T: Config> CommonWeightInfo for CommonWeights<T> {26	fn create_item() -> Weight {27		<SelfWeightOf<T>>::create_item()28	}2930	fn create_multiple_items(amount: u32) -> Weight {31		<SelfWeightOf<T>>::create_multiple_items(amount)32	}3334	fn burn_item() -> Weight {35		max_weight_of!(burn_item_partial(), burn_item_fully())36	}3738	fn transfer() -> Weight {39		max_weight_of!(40			transfer_normal(),41			transfer_creating(),42			transfer_removing(),43			transfer_creating_removing()44		)45	}4647	fn approve() -> Weight {48		<SelfWeightOf<T>>::approve()49	}5051	fn transfer_from() -> Weight {52		max_weight_of!(53			transfer_from_normal(),54			transfer_from_creating(),55			transfer_from_removing(),56			transfer_from_creating_removing()57		)58	}5960	fn burn_from() -> Weight {61		<SelfWeightOf<T>>::burn_from()62	}6364	fn set_variable_metadata(bytes: u32) -> Weight {65		<SelfWeightOf<T>>::set_variable_metadata(bytes)66	}67}6869fn map_create_data<T: Config>(70	data: up_data_structs::CreateItemData,71	to: &T::CrossAccountId,72) -> Result<CreateItemData<T>, DispatchError> {73	match data {74		up_data_structs::CreateItemData::ReFungible(data) => Ok(CreateItemData {75			const_data: data.const_data,76			variable_data: data.variable_data,77			users: {78				let mut out = BTreeMap::new();79				out.insert(to.clone(), data.pieces);80				out81			},82		}),83		_ => fail!(<Error<T>>::NotRefungibleDataUsedToMintFungibleCollectionToken),84	}85}8687impl<T: Config> CommonCollectionOperations<T> for RefungibleHandle<T> {88	fn create_item(89		&self,90		sender: T::CrossAccountId,91		to: T::CrossAccountId,92		data: up_data_structs::CreateItemData,93	) -> DispatchResultWithPostInfo {94		with_weight(95			<Pallet<T>>::create_item(self, &sender, map_create_data(data, &to)?),96			<CommonWeights<T>>::create_item(),97		)98	}99100	fn create_multiple_items(101		&self,102		sender: T::CrossAccountId,103		to: T::CrossAccountId,104		data: Vec<up_data_structs::CreateItemData>,105	) -> DispatchResultWithPostInfo {106		let data = data107			.into_iter()108			.map(|d| map_create_data::<T>(d, &to))109			.collect::<Result<Vec<_>, DispatchError>>()?;110111		let amount = data.len();112		with_weight(113			<Pallet<T>>::create_multiple_items(self, &sender, data),114			<CommonWeights<T>>::create_multiple_items(amount as u32),115		)116	}117118	fn burn_item(119		&self,120		sender: T::CrossAccountId,121		token: TokenId,122		amount: u128,123	) -> DispatchResultWithPostInfo {124		with_weight(125			<Pallet<T>>::burn(self, &sender, token, amount),126			<CommonWeights<T>>::burn_item(),127		)128	}129130	fn transfer(131		&self,132		from: T::CrossAccountId,133		to: T::CrossAccountId,134		token: TokenId,135		amount: u128,136	) -> DispatchResultWithPostInfo {137		with_weight(138			<Pallet<T>>::transfer(self, &from, &to, token, amount),139			<CommonWeights<T>>::transfer(),140		)141	}142143	fn approve(144		&self,145		sender: T::CrossAccountId,146		spender: T::CrossAccountId,147		token: TokenId,148		amount: u128,149	) -> DispatchResultWithPostInfo {150		with_weight(151			<Pallet<T>>::set_allowance(self, &sender, &spender, token, amount),152			<CommonWeights<T>>::approve(),153		)154	}155156	fn transfer_from(157		&self,158		sender: T::CrossAccountId,159		from: T::CrossAccountId,160		to: T::CrossAccountId,161		token: TokenId,162		amount: u128,163	) -> DispatchResultWithPostInfo {164		with_weight(165			<Pallet<T>>::transfer_from(self, &sender, &from, &to, token, amount),166			<CommonWeights<T>>::transfer_from(),167		)168	}169170	fn burn_from(171		&self,172		sender: T::CrossAccountId,173		from: T::CrossAccountId,174		token: TokenId,175		amount: u128,176	) -> DispatchResultWithPostInfo {177		with_weight(178			<Pallet<T>>::burn_from(self, &sender, &from, token, amount),179			<CommonWeights<T>>::burn_from(),180		)181	}182183	fn set_variable_metadata(184		&self,185		sender: T::CrossAccountId,186		token: TokenId,187		data: BoundedVec<u8, CustomDataLimit>,188	) -> DispatchResultWithPostInfo {189		let len = data.len();190		with_weight(191			<Pallet<T>>::set_variable_metadata(self, &sender, token, data),192			<CommonWeights<T>>::set_variable_metadata(len as u32),193		)194	}195196	fn account_tokens(&self, account: T::CrossAccountId) -> Vec<TokenId> {197		<Owned<T>>::iter_prefix((self.id, account))198			.map(|(id, _)| id)199			.collect()200	}201202	fn token_exists(&self, token: TokenId) -> bool {203		<Pallet<T>>::token_exists(self, token)204	}205206	fn last_token_id(&self) -> TokenId {207		TokenId(<TokensMinted<T>>::get(self.id))208	}209210	fn token_owner(&self, _token: TokenId) -> Option<T::CrossAccountId> {211		None212	}213	fn const_metadata(&self, token: TokenId) -> Vec<u8> {214		<TokenData<T>>::get((self.id, token))215			.const_data216			.into_inner()217	}218	fn variable_metadata(&self, token: TokenId) -> Vec<u8> {219		<TokenData<T>>::get((self.id, token))220			.variable_data221			.into_inner()222	}223224	fn collection_tokens(&self) -> u32 {225		<Pallet<T>>::total_supply(self)226	}227228	fn account_balance(&self, account: T::CrossAccountId) -> u32 {229		<AccountBalance<T>>::get((self.id, account))230	}231232	fn balance(&self, account: T::CrossAccountId, token: TokenId) -> u128 {233		<Balance<T>>::get((self.id, token, account))234	}235236	fn allowance(237		&self,238		sender: T::CrossAccountId,239		spender: T::CrossAccountId,240		token: TokenId,241	) -> u128 {242		<Allowance<T>>::get((self.id, token, sender, spender))243	}244}
after · pallets/refungible/src/common.rs
1use core::marker::PhantomData;23use sp_std::collections::btree_map::BTreeMap;4use frame_support::{dispatch::DispatchResultWithPostInfo, fail, weights::Weight, BoundedVec};5use up_data_structs::{TokenId, CustomDataLimit};6use pallet_common::{CommonCollectionOperations, CommonWeightInfo, with_weight};7use sp_runtime::DispatchError;8use sp_std::vec::Vec;910use crate::{11	AccountBalance, Allowance, Balance, Config, Error, Owned, Pallet, RefungibleHandle,12	SelfWeightOf, TokenData, weights::WeightInfo, TokensMinted,13};1415macro_rules! max_weight_of {16	($($method:ident ($($args:tt)*)),*) => {17		018		$(19			.max(<SelfWeightOf<T>>::$method($($args)*))20		)*21	};22}2324pub struct CommonWeights<T: Config>(PhantomData<T>);25impl<T: Config> CommonWeightInfo<T::CrossAccountId> for CommonWeights<T> {26	fn create_item() -> Weight {27		<SelfWeightOf<T>>::create_item()28	}2930	fn create_multiple_items(amount: u32) -> Weight {31		<SelfWeightOf<T>>::create_multiple_items(amount)32	}3334	fn burn_item() -> Weight {35		max_weight_of!(burn_item_partial(), burn_item_fully())36	}3738	fn transfer() -> Weight {39		max_weight_of!(40			transfer_normal(),41			transfer_creating(),42			transfer_removing(),43			transfer_creating_removing()44		)45	}4647	fn approve() -> Weight {48		<SelfWeightOf<T>>::approve()49	}5051	fn transfer_from() -> Weight {52		max_weight_of!(53			transfer_from_normal(),54			transfer_from_creating(),55			transfer_from_removing(),56			transfer_from_creating_removing()57		)58	}5960	fn burn_from() -> Weight {61		<SelfWeightOf<T>>::burn_from()62	}6364	fn set_variable_metadata(bytes: u32) -> Weight {65		<SelfWeightOf<T>>::set_variable_metadata(bytes)66	}67}6869fn map_create_data<T: Config>(70	data: up_data_structs::CreateItemData,71	to: &T::CrossAccountId,72) -> Result<CreateItemData<T>, DispatchError> {73	match data {74		up_data_structs::CreateItemData::ReFungible(data) => Ok(CreateItemData {75			const_data: data.const_data,76			variable_data: data.variable_data,77			users: {78				let mut out = BTreeMap::new();79				out.insert(to.clone(), data.pieces);80				out81			},82		}),83		_ => fail!(<Error<T>>::NotRefungibleDataUsedToMintFungibleCollectionToken),84	}85}8687impl<T: Config> CommonCollectionOperations<T> for RefungibleHandle<T> {88	fn create_item(89		&self,90		sender: T::CrossAccountId,91		to: T::CrossAccountId,92		data: up_data_structs::CreateItemData,93	) -> DispatchResultWithPostInfo {94		with_weight(95			<Pallet<T>>::create_item(self, &sender, map_create_data(data, &to)?),96			<CommonWeights<T>>::create_item(),97		)98	}99100	fn create_multiple_items(101		&self,102		sender: T::CrossAccountId,103		to: T::CrossAccountId,104		data: Vec<up_data_structs::CreateItemData>,105	) -> DispatchResultWithPostInfo {106		let data = data107			.into_iter()108			.map(|d| map_create_data::<T>(d, &to))109			.collect::<Result<Vec<_>, DispatchError>>()?;110111		let amount = data.len();112		with_weight(113			<Pallet<T>>::create_multiple_items(self, &sender, data),114			<CommonWeights<T>>::create_multiple_items(amount as u32),115		)116	}117118	fn burn_item(119		&self,120		sender: T::CrossAccountId,121		token: TokenId,122		amount: u128,123	) -> DispatchResultWithPostInfo {124		with_weight(125			<Pallet<T>>::burn(self, &sender, token, amount),126			<CommonWeights<T>>::burn_item(),127		)128	}129130	fn transfer(131		&self,132		from: T::CrossAccountId,133		to: T::CrossAccountId,134		token: TokenId,135		amount: u128,136	) -> DispatchResultWithPostInfo {137		with_weight(138			<Pallet<T>>::transfer(self, &from, &to, token, amount),139			<CommonWeights<T>>::transfer(),140		)141	}142143	fn approve(144		&self,145		sender: T::CrossAccountId,146		spender: T::CrossAccountId,147		token: TokenId,148		amount: u128,149	) -> DispatchResultWithPostInfo {150		with_weight(151			<Pallet<T>>::set_allowance(self, &sender, &spender, token, amount),152			<CommonWeights<T>>::approve(),153		)154	}155156	fn transfer_from(157		&self,158		sender: T::CrossAccountId,159		from: T::CrossAccountId,160		to: T::CrossAccountId,161		token: TokenId,162		amount: u128,163	) -> DispatchResultWithPostInfo {164		with_weight(165			<Pallet<T>>::transfer_from(self, &sender, &from, &to, token, amount),166			<CommonWeights<T>>::transfer_from(),167		)168	}169170	fn burn_from(171		&self,172		sender: T::CrossAccountId,173		from: T::CrossAccountId,174		token: TokenId,175		amount: u128,176	) -> DispatchResultWithPostInfo {177		with_weight(178			<Pallet<T>>::burn_from(self, &sender, &from, token, amount),179			<CommonWeights<T>>::burn_from(),180		)181	}182183	fn set_variable_metadata(184		&self,185		sender: T::CrossAccountId,186		token: TokenId,187		data: BoundedVec<u8, CustomDataLimit>,188	) -> DispatchResultWithPostInfo {189		let len = data.len();190		with_weight(191			<Pallet<T>>::set_variable_metadata(self, &sender, token, data),192			<CommonWeights<T>>::set_variable_metadata(len as u32),193		)194	}195196	fn account_tokens(&self, account: T::CrossAccountId) -> Vec<TokenId> {197		<Owned<T>>::iter_prefix((self.id, account))198			.map(|(id, _)| id)199			.collect()200	}201202	fn token_exists(&self, token: TokenId) -> bool {203		<Pallet<T>>::token_exists(self, token)204	}205206	fn last_token_id(&self) -> TokenId {207		TokenId(<TokensMinted<T>>::get(self.id))208	}209210	fn token_owner(&self, _token: TokenId) -> Option<T::CrossAccountId> {211		None212	}213	fn const_metadata(&self, token: TokenId) -> Vec<u8> {214		<TokenData<T>>::get((self.id, token))215			.const_data216			.into_inner()217	}218	fn variable_metadata(&self, token: TokenId) -> Vec<u8> {219		<TokenData<T>>::get((self.id, token))220			.variable_data221			.into_inner()222	}223224	fn collection_tokens(&self) -> u32 {225		<Pallet<T>>::total_supply(self)226	}227228	fn account_balance(&self, account: T::CrossAccountId) -> u32 {229		<AccountBalance<T>>::get((self.id, account))230	}231232	fn balance(&self, account: T::CrossAccountId, token: TokenId) -> u128 {233		<Balance<T>>::get((self.id, token, account))234	}235236	fn allowance(237		&self,238		sender: T::CrossAccountId,239		spender: T::CrossAccountId,240		token: TokenId,241	) -> u128 {242		<Allowance<T>>::get((self.id, token, sender, spender))243	}244}
modifiedpallets/unique/src/benchmarking.rsdiffbeforeafterboth
--- a/pallets/unique/src/benchmarking.rs
+++ b/pallets/unique/src/benchmarking.rs
@@ -5,9 +5,8 @@
 use frame_system::RawOrigin;
 use frame_benchmarking::{benchmarks, account};
 use up_data_structs::*;
-use core::convert::TryInto;
 use sp_runtime::DispatchError;
-use pallet_common::benchmarking::{create_data, create_u16_data};
+use pallet_common::benchmarking::{create_data, create_var_data, create_u16_data};
 
 const SEED: u32 = 1;
 
@@ -16,13 +15,9 @@
 	mode: CollectionMode,
 ) -> Result<CollectionId, DispatchError> {
 	T::Currency::deposit_creating(&owner, T::CollectionCreationPrice::get());
-	let col_name = create_u16_data(MAX_COLLECTION_NAME_LENGTH)
-		.try_into()
-		.unwrap();
-	let col_desc = create_u16_data(MAX_COLLECTION_DESCRIPTION_LENGTH)
-		.try_into()
-		.unwrap();
-	let token_prefix = create_data(MAX_TOKEN_PREFIX_LENGTH).try_into().unwrap();
+	let col_name = create_u16_data::<MAX_COLLECTION_NAME_LENGTH>();
+	let col_desc = create_u16_data::<MAX_COLLECTION_DESCRIPTION_LENGTH>();
+	let token_prefix = create_data::<MAX_TOKEN_PREFIX_LENGTH>();
 	<Pallet<T>>::create_collection(
 		RawOrigin::Signed(owner).into(),
 		col_name,
@@ -37,11 +32,10 @@
 }
 
 benchmarks! {
-
 	create_collection {
-		let col_name: Vec<u16> = create_u16_data(MAX_COLLECTION_NAME_LENGTH);
-		let col_desc: Vec<u16> = create_u16_data(MAX_COLLECTION_DESCRIPTION_LENGTH);
-		let token_prefix: Vec<u8> = create_data(MAX_TOKEN_PREFIX_LENGTH);
+		let col_name = create_u16_data::<MAX_COLLECTION_NAME_LENGTH>();
+		let col_desc = create_u16_data::<MAX_COLLECTION_DESCRIPTION_LENGTH>();
+		let token_prefix = create_data::<MAX_TOKEN_PREFIX_LENGTH>();
 		let mode: CollectionMode = CollectionMode::NFT;
 		let caller: T::AccountId = account("caller", 0, SEED);
 		T::Currency::deposit_creating(&caller, T::CollectionCreationPrice::get());
@@ -125,7 +119,7 @@
 
 		let caller: T::AccountId = account("caller", 0, SEED);
 		let collection = create_nft_collection::<T>(caller.clone())?;
-		let data = create_data(b as usize);
+		let data = create_var_data(b);
 	}: set_offchain_schema(RawOrigin::Signed(caller.clone()), collection, data)
 
 	set_const_on_chain_schema {
@@ -133,7 +127,7 @@
 
 		let caller: T::AccountId = account("caller", 0, SEED);
 		let collection = create_nft_collection::<T>(caller.clone())?;
-		let data = create_data(b as usize);
+		let data = create_var_data(b);
 	}: set_const_on_chain_schema(RawOrigin::Signed(caller.clone()), collection, data)
 
 	set_variable_on_chain_schema {
@@ -141,7 +135,7 @@
 
 		let caller: T::AccountId = account("caller", 0, SEED);
 		let collection = create_nft_collection::<T>(caller.clone())?;
-		let data = create_data(b as usize);
+		let data = create_var_data(b);
 	}: set_variable_on_chain_schema(RawOrigin::Signed(caller.clone()), collection, data)
 
 	set_schema_version {
modifiedprimitives/data-structs/src/lib.rsdiffbeforeafterboth
--- a/primitives/data-structs/src/lib.rs
+++ b/primitives/data-structs/src/lib.rs
@@ -76,9 +76,7 @@
 /// create_many call
 pub const MAX_ITEMS_PER_BATCH: u32 = 200;
 
-parameter_types! {
-	pub const CustomDataLimit: u32 = CUSTOM_DATA_LIMIT;
-}
+pub type CustomDataLimit = ConstU32<CUSTOM_DATA_LIMIT>;
 
 #[derive(
 	Encode,
@@ -417,15 +415,72 @@
 	}
 }
 
+fn bounded_debug<V, S>(v: &BoundedVec<V, S>, f: &mut fmt::Formatter) -> Result<(), fmt::Error>
+where
+	V: fmt::Debug,
+{
+	use core::fmt::Debug;
+	(&v as &Vec<V>).fmt(f)
+}
+
+#[cfg(feature = "serde1")]
+#[allow(dead_code)]
+mod bounded_map_serde {
+	use core::convert::TryFrom;
+	use sp_std::collections::btree_map::BTreeMap;
+	use frame_support::{traits::Get, storage::bounded_btree_map::BoundedBTreeMap};
+	use serde::{
+		ser::{self, Serialize},
+		de::{self, Deserialize, Error},
+	};
+	pub fn serialize<D, K, V, S>(
+		value: &BoundedBTreeMap<K, V, S>,
+		serializer: D,
+	) -> Result<D::Ok, D::Error>
+	where
+		D: ser::Serializer,
+		K: Serialize + Ord,
+		V: Serialize,
+	{
+		(value as &BTreeMap<_, _>).serialize(serializer)
+	}
+
+	pub fn deserialize<'de, D, K, V, S>(
+		deserializer: D,
+	) -> Result<BoundedBTreeMap<K, V, S>, D::Error>
+	where
+		D: de::Deserializer<'de>,
+		K: de::Deserialize<'de> + Ord,
+		V: de::Deserialize<'de>,
+		S: Get<u32>,
+	{
+		let map = <BTreeMap<K, V>>::deserialize(deserializer)?;
+		let len = map.len();
+		TryFrom::try_from(map).map_err(|_| D::Error::invalid_length(len, &"lesser size"))
+	}
+}
+
+fn bounded_map_debug<K, V, S>(
+	v: &BoundedBTreeMap<K, V, S>,
+	f: &mut fmt::Formatter,
+) -> Result<(), fmt::Error>
+where
+	K: fmt::Debug + Ord,
+	V: fmt::Debug,
+{
+	use core::fmt::Debug;
+	(&v as &BTreeMap<K, V>).fmt(f)
+}
+
 #[derive(Encode, Decode, MaxEncodedLen, Default, PartialEq, Clone, Derivative, TypeInfo)]
 #[cfg_attr(feature = "serde1", derive(Serialize, Deserialize))]
 #[derivative(Debug)]
 pub struct CreateNftData {
 	#[cfg_attr(feature = "serde1", serde(with = "bounded_serde"))]
-	#[derivative(Debug = "ignore")]
+	#[derivative(Debug(format_with = "bounded_debug"))]
 	pub const_data: BoundedVec<u8, CustomDataLimit>,
 	#[cfg_attr(feature = "serde1", serde(with = "bounded_serde"))]
-	#[derivative(Debug = "ignore")]
+	#[derivative(Debug(format_with = "bounded_debug"))]
 	pub variable_data: BoundedVec<u8, CustomDataLimit>,
 }
 
@@ -440,10 +495,10 @@
 #[derivative(Debug)]
 pub struct CreateReFungibleData {
 	#[cfg_attr(feature = "serde1", serde(with = "bounded_serde"))]
-	#[derivative(Debug = "ignore")]
+	#[derivative(Debug(format_with = "bounded_debug"))]
 	pub const_data: BoundedVec<u8, CustomDataLimit>,
 	#[cfg_attr(feature = "serde1", serde(with = "bounded_serde"))]
-	#[derivative(Debug = "ignore")]
+	#[derivative(Debug(format_with = "bounded_debug"))]
 	pub variable_data: BoundedVec<u8, CustomDataLimit>,
 	pub pieces: u128,
 }