difftreelog
test upgrade benchmarks for new substrate
in: master
12 files changed
.maintain/frame-weight-template.hbsdiffbeforeafterboth--- a/.maintain/frame-weight-template.hbs
+++ b/.maintain/frame-weight-template.hbs
@@ -7,7 +7,7 @@
//! EXECUTION: {{cmd.execution}}, WASM-EXECUTION: {{cmd.wasm_execution}}, CHAIN: {{cmd.chain}}, DB CACHE: {{cmd.db_cache}}
// Executed Command:
-{{#each args as |arg|~}}
+{{#each args as |arg|}}
// {{arg}}
{{/each}}
@@ -21,76 +21,80 @@
/// Weight functions needed for {{pallet}}.
pub trait WeightInfo {
- {{~#each benchmarks as |benchmark|}}
+ {{#each benchmarks as |benchmark|}}
fn {{benchmark.name~}}
(
{{~#each benchmark.components as |c| ~}}
{{c.name}}: u32, {{/each~}}
) -> Weight;
- {{~/each}}
+ {{/each}}
}
/// Weights for {{pallet}} using the Substrate node and recommended hardware.
pub struct SubstrateWeight<T>(PhantomData<T>);
+{{#if (eq pallet "frame_system")}}
+impl<T: crate::Config> WeightInfo for SubstrateWeight<T> {
+{{else}}
impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
- {{~#each benchmarks as |benchmark|}}
- {{~#each benchmark.comments as |comment|}}
+{{/if}}
+ {{#each benchmarks as |benchmark|}}
+ {{#each benchmark.comments as |comment|}}
// {{comment}}
- {{~/each}}
+ {{/each}}
fn {{benchmark.name~}}
(
{{~#each benchmark.components as |c| ~}}
{{~#if (not c.is_used)}}_{{/if}}{{c.name}}: u32, {{/each~}}
) -> Weight {
({{underscore benchmark.base_weight}} as Weight)
- {{~#each benchmark.component_weight as |cw|}}
+ {{#each benchmark.component_weight as |cw|}}
// Standard Error: {{underscore cw.error}}
.saturating_add(({{underscore cw.slope}} as Weight).saturating_mul({{cw.name}} as Weight))
- {{~/each}}
- {{~#if (ne benchmark.base_reads "0")}}
+ {{/each}}
+ {{#if (ne benchmark.base_reads "0")}}
.saturating_add(T::DbWeight::get().reads({{benchmark.base_reads}} as Weight))
- {{~/if}}
- {{~#each benchmark.component_reads as |cr|}}
+ {{/if}}
+ {{#each benchmark.component_reads as |cr|}}
.saturating_add(T::DbWeight::get().reads(({{cr.slope}} as Weight).saturating_mul({{cr.name}} as Weight)))
- {{~/each}}
- {{~#if (ne benchmark.base_writes "0")}}
+ {{/each}}
+ {{#if (ne benchmark.base_writes "0")}}
.saturating_add(T::DbWeight::get().writes({{benchmark.base_writes}} as Weight))
- {{~/if}}
- {{~#each benchmark.component_writes as |cw|}}
+ {{/if}}
+ {{#each benchmark.component_writes as |cw|}}
.saturating_add(T::DbWeight::get().writes(({{cw.slope}} as Weight).saturating_mul({{cw.name}} as Weight)))
- {{~/each}}
+ {{/each}}
}
- {{~/each}}
+ {{/each}}
}
// For backwards compatibility and tests
impl WeightInfo for () {
- {{~#each benchmarks as |benchmark|}}
- {{~#each benchmark.comments as |comment|}}
+ {{#each benchmarks as |benchmark|}}
+ {{#each benchmark.comments as |comment|}}
// {{comment}}
- {{~/each}}
+ {{/each}}
fn {{benchmark.name~}}
(
{{~#each benchmark.components as |c| ~}}
{{~#if (not c.is_used)}}_{{/if}}{{c.name}}: u32, {{/each~}}
) -> Weight {
({{underscore benchmark.base_weight}} as Weight)
- {{~#each benchmark.component_weight as |cw|}}
+ {{#each benchmark.component_weight as |cw|}}
// Standard Error: {{underscore cw.error}}
.saturating_add(({{underscore cw.slope}} as Weight).saturating_mul({{cw.name}} as Weight))
- {{~/each}}
- {{~#if (ne benchmark.base_reads "0")}}
+ {{/each}}
+ {{#if (ne benchmark.base_reads "0")}}
.saturating_add(RocksDbWeight::get().reads({{benchmark.base_reads}} as Weight))
- {{~/if}}
- {{~#each benchmark.component_reads as |cr|}}
+ {{/if}}
+ {{#each benchmark.component_reads as |cr|}}
.saturating_add(RocksDbWeight::get().reads(({{cr.slope}} as Weight).saturating_mul({{cr.name}} as Weight)))
- {{~/each}}
- {{~#if (ne benchmark.base_writes "0")}}
+ {{/each}}
+ {{#if (ne benchmark.base_writes "0")}}
.saturating_add(RocksDbWeight::get().writes({{benchmark.base_writes}} as Weight))
- {{~/if}}
- {{~#each benchmark.component_writes as |cw|}}
+ {{/if}}
+ {{#each benchmark.component_writes as |cw|}}
.saturating_add(RocksDbWeight::get().writes(({{cw.slope}} as Weight).saturating_mul({{cw.name}} as Weight)))
- {{~/each}}
+ {{/each}}
}
- {{~/each}}
+ {{/each}}
}
pallets/common/src/benchmarking.rsdiffbeforeafterboth--- a/pallets/common/src/benchmarking.rs
+++ b/pallets/common/src/benchmarking.rs
@@ -1,64 +1,87 @@
use sp_std::vec::Vec;
use crate::{Config, CollectionHandle};
use up_data_structs::{
- CollectionMode, Collection, CollectionId, MAX_COLLECTION_NAME_LENGTH,
+ CollectionMode, CreateCollectionData, CollectionId, MAX_COLLECTION_NAME_LENGTH,
MAX_COLLECTION_DESCRIPTION_LENGTH, MAX_TOKEN_PREFIX_LENGTH, OFFCHAIN_SCHEMA_LIMIT,
VARIABLE_ON_CHAIN_SCHEMA_LIMIT, CONST_ON_CHAIN_SCHEMA_LIMIT,
};
-use frame_support::traits::{Currency, Get};
+use frame_support::{
+ traits::{Currency, Get},
+ pallet_prelude::ConstU32,
+ BoundedVec,
+};
use core::convert::TryInto;
use sp_runtime::DispatchError;
-pub fn create_data(size: usize) -> Vec<u8> {
- (0..size).map(|v| (v & 0xff) as u8).collect()
+pub fn create_data<const S: u32>() -> BoundedVec<u8, ConstU32<S>> {
+ create_var_data::<S>(S)
}
-pub fn create_u16_data(size: usize) -> Vec<u16> {
- (0..size).map(|v| (v & 0xffff) as u16).collect()
+pub fn create_u16_data<const S: u32>() -> BoundedVec<u16, ConstU32<S>> {
+ (0..S)
+ .map(|v| (v & 0xffff) as u16)
+ .collect::<Vec<_>>()
+ .try_into()
+ .unwrap()
+}
+pub fn create_var_data<const S: u32>(size: u32) -> BoundedVec<u8, ConstU32<S>> {
+ assert!(
+ size <= S,
+ "size ({}) should be less within bound ({})",
+ size,
+ S
+ );
+ (0..size)
+ .map(|v| (v & 0xff) as u8)
+ .collect::<Vec<_>>()
+ .try_into()
+ .unwrap()
}
pub fn create_collection_raw<T: Config, R>(
owner: T::AccountId,
mode: CollectionMode,
- handler: impl FnOnce(Collection<T::AccountId>) -> Result<CollectionId, DispatchError>,
+ handler: impl FnOnce(
+ T::AccountId,
+ CreateCollectionData<T::AccountId>,
+ ) -> Result<CollectionId, DispatchError>,
cast: impl FnOnce(CollectionHandle<T>) -> R,
) -> Result<R, DispatchError> {
T::Currency::deposit_creating(&owner, T::CollectionCreationPrice::get());
- let name = create_u16_data(MAX_COLLECTION_NAME_LENGTH)
- .try_into()
- .unwrap();
- let description = create_u16_data(MAX_COLLECTION_DESCRIPTION_LENGTH)
- .try_into()
- .unwrap();
- let token_prefix = create_data(MAX_TOKEN_PREFIX_LENGTH).try_into().unwrap();
- let offchain_schema = create_data(OFFCHAIN_SCHEMA_LIMIT as usize)
- .try_into()
- .unwrap();
- let variable_on_chain_schema = create_data(VARIABLE_ON_CHAIN_SCHEMA_LIMIT as usize)
- .try_into()
- .unwrap();
- let const_on_chain_schema = create_data(CONST_ON_CHAIN_SCHEMA_LIMIT as usize)
- .try_into()
- .unwrap();
- handler(Collection {
+ let name = create_u16_data::<MAX_COLLECTION_NAME_LENGTH>();
+ let description = create_u16_data::<MAX_COLLECTION_DESCRIPTION_LENGTH>();
+ let token_prefix = create_data::<MAX_TOKEN_PREFIX_LENGTH>();
+ let offchain_schema = create_data::<OFFCHAIN_SCHEMA_LIMIT>();
+ let variable_on_chain_schema = create_data::<VARIABLE_ON_CHAIN_SCHEMA_LIMIT>();
+ let const_on_chain_schema = create_data::<CONST_ON_CHAIN_SCHEMA_LIMIT>();
+ handler(
owner,
- mode,
- access: Default::default(),
- name,
- description,
- token_prefix,
- mint_mode: true,
- offchain_schema,
- schema_version: Default::default(),
- sponsorship: Default::default(),
- limits: Default::default(),
- variable_on_chain_schema,
- const_on_chain_schema,
- meta_update_permission: Default::default(),
- })
+ CreateCollectionData {
+ mode,
+ name,
+ description,
+ token_prefix,
+ offchain_schema,
+ variable_on_chain_schema,
+ const_on_chain_schema,
+ ..Default::default()
+ },
+ )
.and_then(CollectionHandle::try_get)
.map(cast)
}
+/// Helper macros, which handles all benchmarking preparation in semi-declarative way
+///
+/// `name` is a substrate account
+/// - name: sub[(id)]
+/// `name` is a collection with owner `owner`
+/// - name: collection(owner)
+/// `name` is a cross account based on substrate
+/// - name: cross_sub[(id)]
+/// `name` is a cross account, which maps to substrate account `name`
+/// - name: cross_from_sub
+/// `name` is a cross account, which maps to substrate account `other_name`
+/// - name: cross_from_sub(other_name)
#[macro_export]
macro_rules! bench_init {
($name:ident: sub $(($id:expr))?; $($rest:tt)*) => {
pallets/fungible/src/common.rsdiffbeforeafterboth--- a/pallets/fungible/src/common.rs
+++ b/pallets/fungible/src/common.rs
@@ -12,7 +12,7 @@
};
pub struct CommonWeights<T: Config>(PhantomData<T>);
-impl<T: Config> CommonWeightInfo for CommonWeights<T> {
+impl<T: Config> CommonWeightInfo<T::CrossAccountId> for CommonWeights<T> {
fn create_item() -> Weight {
<SelfWeightOf<T>>::create_item()
}
pallets/fungible/src/lib.rsdiffbeforeafterboth--- a/pallets/fungible/src/lib.rs
+++ b/pallets/fungible/src/lib.rs
@@ -9,7 +9,7 @@
use pallet_evm_coder_substrate::WithRecorder;
use sp_core::H160;
use sp_runtime::{ArithmeticError, DispatchError, DispatchResult};
-use sp_std::{vec::Vec, vec, collections::btree_map::BTreeMap};
+use sp_std::collections::btree_map::BTreeMap;
pub use pallet::*;
@@ -222,7 +222,7 @@
pub fn create_multiple_items(
collection: &FungibleHandle<T>,
sender: &T::CrossAccountId,
- data: Vec<CreateItemData<T>>,
+ data: BTreeMap<T::CrossAccountId, u128>,
) -> DispatchResult {
if !collection.is_owner_or_admin(sender) {
ensure!(
@@ -236,22 +236,18 @@
}
}
- let mut balances = BTreeMap::new();
-
let total_supply = data
.iter()
- .map(|u| u.1)
+ .map(|(_, v)| *v)
.try_fold(<TotalSupply<T>>::get(collection.id), |acc, v| {
acc.checked_add(v)
})
.ok_or(ArithmeticError::Overflow)?;
- for (user, amount) in data.into_iter() {
- let balance = balances
- .entry(user.clone())
- .or_insert_with(|| <Balance<T>>::get((collection.id, user)));
- *balance = (*balance)
- .checked_add(amount)
+ let mut balances = data;
+ for (k, v) in balances.iter_mut() {
+ *v = <Balance<T>>::get((collection.id, &k))
+ .checked_add(*v)
.ok_or(ArithmeticError::Overflow)?;
}
pallets/inflation/src/benchmarking.rsdiffbeforeafterboth--- a/pallets/inflation/src/benchmarking.rs
+++ b/pallets/inflation/src/benchmarking.rs
@@ -1,7 +1,7 @@
#![cfg(feature = "runtime-benchmarks")]
use super::*;
-use crate::Module as Inflation;
+use crate::Pallet as Inflation;
use frame_benchmarking::{benchmarks};
use frame_support::traits::OnInitialize;
pallets/nonfungible/src/benchmarking.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/benchmarking.rs
+++ b/pallets/nonfungible/src/benchmarking.rs
@@ -2,18 +2,18 @@
use crate::{Pallet, Config, NonfungibleHandle};
use sp_std::prelude::*;
-use pallet_common::benchmarking::{create_collection_raw, create_data};
+use pallet_common::benchmarking::{create_collection_raw, create_data, create_var_data};
use frame_benchmarking::{benchmarks, account};
-use up_data_structs::{CollectionMode, MAX_ITEMS_PER_BATCH};
+use up_data_structs::{CollectionMode, MAX_ITEMS_PER_BATCH, CUSTOM_DATA_LIMIT};
use pallet_common::bench_init;
use core::convert::TryInto;
const SEED: u32 = 1;
fn create_max_item_data<T: Config>(owner: T::CrossAccountId) -> CreateItemData<T> {
- let const_data = create_data(CUSTOM_DATA_LIMIT as usize).try_into().unwrap();
- let variable_data = create_data(CUSTOM_DATA_LIMIT as usize).try_into().unwrap();
- CreateItemData {
+ let const_data = create_data::<CUSTOM_DATA_LIMIT>();
+ let variable_data = create_data::<CUSTOM_DATA_LIMIT>();
+ CreateItemData::<T> {
const_data,
variable_data,
owner,
@@ -24,7 +24,7 @@
sender: &T::CrossAccountId,
owner: T::CrossAccountId,
) -> Result<TokenId, DispatchError> {
- <Pallet<T>>::create_item(&collection, sender, create_max_item_data(owner))?;
+ <Pallet<T>>::create_item(&collection, sender, create_max_item_data::<T>(owner))?;
Ok(TokenId(<TokensMinted<T>>::get(&collection.id)))
}
@@ -53,7 +53,9 @@
owner: sub; collection: collection(owner);
sender: cross_from_sub(owner); to: cross_sub;
};
- let data = (0..b).map(|_| create_max_item_data(to.clone())).collect();
+ let data = (0..b).map(|_| create_max_item_data::<T>(to.clone())).collect();
+ }: {<Pallet<T>>::create_multiple_items(&collection, &sender, data)?}
+
}: {<Pallet<T>>::create_multiple_items(&collection, &sender, data)?}
burn_item {
@@ -105,6 +107,6 @@
owner: cross_from_sub; sender: cross_sub;
};
let item = create_max_item(&collection, &owner, sender.clone())?;
- let data = create_data(b as usize);
+ let data = create_var_data(b).try_into().unwrap();
}: {<Pallet<T>>::set_variable_metadata(&collection, &sender, item, data)?}
}
pallets/nonfungible/src/common.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/common.rs
+++ b/pallets/nonfungible/src/common.rs
@@ -12,7 +12,7 @@
};
pub struct CommonWeights<T: Config>(PhantomData<T>);
-impl<T: Config> CommonWeightInfo for CommonWeights<T> {
+impl<T: Config> CommonWeightInfo<T::CrossAccountId> for CommonWeights<T> {
fn create_item() -> Weight {
<SelfWeightOf<T>>::create_item()
}
@@ -51,7 +51,7 @@
to: &T::CrossAccountId,
) -> Result<CreateItemData<T>, DispatchError> {
match data {
- up_data_structs::CreateItemData::NFT(data) => Ok(CreateItemData {
+ up_data_structs::CreateItemData::NFT(data) => Ok(CreateItemData::<T> {
const_data: data.const_data,
variable_data: data.variable_data,
owner: to.clone(),
@@ -68,7 +68,7 @@
data: up_data_structs::CreateItemData,
) -> DispatchResultWithPostInfo {
with_weight(
- <Pallet<T>>::create_item(self, &sender, map_create_data(data, &to)?),
+ <Pallet<T>>::create_item(self, &sender, map_create_data::<T>(data, &to)?),
<CommonWeights<T>>::create_item(),
)
}
pallets/nonfungible/src/erc.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/erc.rs
+++ b/pallets/nonfungible/src/erc.rs
@@ -232,7 +232,7 @@
<Pallet<T>>::create_item(
self,
&caller,
- CreateItemData {
+ CreateItemData::<T> {
const_data: BoundedVec::default(),
variable_data: BoundedVec::default(),
owner: to,
@@ -268,7 +268,7 @@
<Pallet<T>>::create_item(
self,
&caller,
- CreateItemData {
+ CreateItemData::<T> {
const_data: Vec::<u8>::from(token_uri)
.try_into()
.map_err(|_| "token uri is too long")?,
@@ -376,7 +376,7 @@
expected_index = expected_index.checked_add(1).ok_or("item id overflow")?;
}
let data = (0..total_tokens)
- .map(|_| CreateItemData {
+ .map(|_| CreateItemData::<T> {
const_data: BoundedVec::default(),
variable_data: BoundedVec::default(),
owner: to.clone(),
@@ -409,7 +409,7 @@
}
expected_index = expected_index.checked_add(1).ok_or("item id overflow")?;
- data.push(CreateItemData {
+ data.push(CreateItemData::<T> {
const_data: Vec::<u8>::from(token_uri)
.try_into()
.map_err(|_| "token uri is too long")?,
pallets/refungible/src/benchmarking.rsdiffbeforeafterboth1use super::*;2use crate::{Pallet, Config, RefungibleHandle};34use sp_std::prelude::*;5use pallet_common::benchmarking::{create_collection_raw, create_data};6use frame_benchmarking::{benchmarks, account};7use up_data_structs::{CollectionMode, MAX_ITEMS_PER_BATCH};8use pallet_common::bench_init;9use core::convert::TryInto;10use core::iter::IntoIterator;1112const SEED: u32 = 1;1314fn create_max_item_data<T: Config>(15 users: impl IntoIterator<Item = (T::CrossAccountId, u128)>,16) -> CreateItemData<T> {17 let const_data = create_data(CUSTOM_DATA_LIMIT as usize).try_into().unwrap();18 let variable_data = create_data(CUSTOM_DATA_LIMIT as usize).try_into().unwrap();19 CreateItemData {20 const_data,21 variable_data,22 users: users.into_iter().collect(),23 }24}25fn create_max_item<T: Config>(26 collection: &RefungibleHandle<T>,27 sender: &T::CrossAccountId,28 users: impl IntoIterator<Item = (T::CrossAccountId, u128)>,29) -> Result<TokenId, DispatchError> {30 <Pallet<T>>::create_item(&collection, sender, create_max_item_data(users))?;31 Ok(TokenId(<TokensMinted<T>>::get(&collection.id)))32}3334fn create_collection<T: Config>(owner: T::AccountId) -> Result<RefungibleHandle<T>, DispatchError> {35 create_collection_raw(36 owner,37 CollectionMode::NFT,38 <Pallet<T>>::init_collection,39 RefungibleHandle::cast,40 )41}42benchmarks! {43 create_item {44 bench_init!{45 owner: sub; collection: collection(owner);46 sender: cross_from_sub(owner); to: cross_sub;47 };48 }: {create_max_item(&collection, &sender, [(to.clone(), 200)])?}4950 create_multiple_items {51 let b in 0..MAX_ITEMS_PER_BATCH;52 bench_init!{53 owner: sub; collection: collection(owner);54 sender: cross_from_sub(owner); to: cross_sub;55 };56 let data = (0..b).map(|_| create_max_item_data([(to.clone(), 200)])).collect();57 }: {<Pallet<T>>::create_multiple_items(&collection, &sender, data)?}5859 // Other user left, token data is kept60 burn_item_partial {61 bench_init!{62 owner: sub; collection: collection(owner);63 sender: cross_from_sub(owner); burner: cross_sub; another_owner: cross_sub;64 };65 let item = create_max_item(&collection, &sender, [(burner.clone(), 200), (another_owner, 200)])?;66 }: {<Pallet<T>>::burn(&collection, &burner, item, 200)?}67 // No users remaining, token is destroyed68 burn_item_fully {69 bench_init!{70 owner: sub; collection: collection(owner);71 sender: cross_from_sub(owner); burner: cross_sub; another_owner: cross_sub;72 };73 let item = create_max_item(&collection, &sender, [(burner.clone(), 200)])?;74 }: {<Pallet<T>>::burn(&collection, &burner, item, 200)?}7576 transfer_normal {77 bench_init!{78 owner: sub; collection: collection(owner);79 sender: cross_from_sub(owner); receiver: cross_sub;80 };81 let item = create_max_item(&collection, &sender, [(sender.clone(), 200), (receiver.clone(), 200)])?;82 }: {<Pallet<T>>::transfer(&collection, &sender, &receiver, item, 100)?}83 // Target account is created84 transfer_creating {85 bench_init!{86 owner: sub; collection: collection(owner);87 sender: cross_from_sub(owner); receiver: cross_sub;88 };89 let item = create_max_item(&collection, &sender, [(sender.clone(), 200)])?;90 }: {<Pallet<T>>::transfer(&collection, &sender, &receiver, item, 100)?}91 // Source account is destroyed92 transfer_removing {93 bench_init!{94 owner: sub; collection: collection(owner);95 sender: cross_from_sub(owner); receiver: cross_sub;96 };97 let item = create_max_item(&collection, &sender, [(sender.clone(), 200), (receiver.clone(), 200)])?;98 }: {<Pallet<T>>::transfer(&collection, &sender, &receiver, item, 200)?}99 // Source account destroyed, target created100 transfer_creating_removing {101 bench_init!{102 owner: sub; collection: collection(owner);103 sender: cross_from_sub(owner); receiver: cross_sub;104 };105 let item = create_max_item(&collection, &sender, [(sender.clone(), 200)])?;106 }: {<Pallet<T>>::transfer(&collection, &sender, &receiver, item, 200)?}107108 approve {109 bench_init!{110 owner: sub; collection: collection(owner);111 owner: cross_from_sub; sender: cross_sub; spender: cross_sub;112 };113 let item = create_max_item(&collection, &owner, [(sender.clone(), 200)])?;114 }: {<Pallet<T>>::set_allowance(&collection, &sender, &spender, item, 100)?}115116 transfer_from_normal {117 bench_init!{118 owner: sub; collection: collection(owner);119 owner: cross_from_sub; sender: cross_sub; spender: cross_sub; receiver: cross_sub;120 };121 let item = create_max_item(&collection, &owner, [(sender.clone(), 200), (receiver.clone(), 200)])?;122 <Pallet<T>>::set_allowance(&collection, &sender, &spender, item, 100)?;123 }: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item, 100)?}124 // Target account is created125 transfer_from_creating {126 bench_init!{127 owner: sub; collection: collection(owner);128 owner: cross_from_sub; sender: cross_sub; spender: cross_sub; receiver: cross_sub;129 };130 let item = create_max_item(&collection, &owner, [(sender.clone(), 200)])?;131 <Pallet<T>>::set_allowance(&collection, &sender, &spender, item, 100)?;132 }: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item, 100)?}133 // Source account is destroyed134 transfer_from_removing {135 bench_init!{136 owner: sub; collection: collection(owner);137 owner: cross_from_sub; sender: cross_sub; spender: cross_sub; receiver: cross_sub;138 };139 let item = create_max_item(&collection, &owner, [(sender.clone(), 200), (receiver.clone(), 200)])?;140 <Pallet<T>>::set_allowance(&collection, &sender, &spender, item, 200)?;141 }: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item, 200)?}142 // Source account destroyed, target created143 transfer_from_creating_removing {144 bench_init!{145 owner: sub; collection: collection(owner);146 owner: cross_from_sub; sender: cross_sub; spender: cross_sub; receiver: cross_sub;147 };148 let item = create_max_item(&collection, &owner, [(sender.clone(), 200)])?;149 <Pallet<T>>::set_allowance(&collection, &sender, &spender, item, 200)?;150 }: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item, 200)?}151152 // Both source account and token is destroyed153 burn_from {154 bench_init!{155 owner: sub; collection: collection(owner);156 owner: cross_from_sub; sender: cross_sub; burner: cross_sub;157 };158 let item = create_max_item(&collection, &owner, [(sender.clone(), 200)])?;159 <Pallet<T>>::set_allowance(&collection, &sender, &burner, item, 200)?;160 }: {<Pallet<T>>::burn_from(&collection, &burner, &sender, item, 200)?}161162 set_variable_metadata {163 let b in 0..CUSTOM_DATA_LIMIT;164 bench_init!{165 owner: sub; collection: collection(owner);166 sender: cross_from_sub(owner);167 };168 let item = create_max_item(&collection, &sender, [(sender.clone(), 200)])?;169 let data = create_data(b as usize);170 }: {<Pallet<T>>::set_variable_metadata(&collection, &sender, item, data)?}171}1use super::*;2use crate::{Pallet, Config, RefungibleHandle};34use sp_std::prelude::*;5use pallet_common::benchmarking::{create_collection_raw, create_data, create_var_data};6use frame_benchmarking::{benchmarks, account};7use up_data_structs::{CollectionMode, MAX_ITEMS_PER_BATCH, CUSTOM_DATA_LIMIT};8use pallet_common::bench_init;9use core::convert::TryInto;10use core::iter::IntoIterator;1112const SEED: u32 = 1;1314fn create_max_item_data<CrossAccountId: Ord>(15 users: impl IntoIterator<Item = (CrossAccountId, u128)>,16) -> CreateRefungibleExData<CrossAccountId> {17 let const_data = create_data::<CUSTOM_DATA_LIMIT>();18 let variable_data = create_data::<CUSTOM_DATA_LIMIT>();19 CreateRefungibleExData {20 const_data,21 variable_data,22 users: users23 .into_iter()24 .collect::<BTreeMap<_, _>>()25 .try_into()26 .unwrap(),27 }28}29fn create_max_item<T: Config>(30 collection: &RefungibleHandle<T>,31 sender: &T::CrossAccountId,32 users: impl IntoIterator<Item = (T::CrossAccountId, u128)>,33) -> Result<TokenId, DispatchError> {34 <Pallet<T>>::create_item(&collection, sender, create_max_item_data(users))?;35 Ok(TokenId(<TokensMinted<T>>::get(&collection.id)))36}3738fn create_collection<T: Config>(owner: T::AccountId) -> Result<RefungibleHandle<T>, DispatchError> {39 create_collection_raw(40 owner,41 CollectionMode::NFT,42 <Pallet<T>>::init_collection,43 RefungibleHandle::cast,44 )45}46benchmarks! {47 create_item {48 bench_init!{49 owner: sub; collection: collection(owner);50 sender: cross_from_sub(owner); to: cross_sub;51 };52 }: {create_max_item(&collection, &sender, [(to.clone(), 200)])?}5354 create_multiple_items {55 let b in 0..MAX_ITEMS_PER_BATCH;56 bench_init!{57 owner: sub; collection: collection(owner);58 sender: cross_from_sub(owner); to: cross_sub;59 };60 let data = (0..b).map(|_| create_max_item_data([(to.clone(), 200)])).collect();61 }: {<Pallet<T>>::create_multiple_items(&collection, &sender, data)?}6263 // Other user left, token data is kept64 burn_item_partial {65 bench_init!{66 owner: sub; collection: collection(owner);67 sender: cross_from_sub(owner); burner: cross_sub; another_owner: cross_sub;68 };69 let item = create_max_item(&collection, &sender, [(burner.clone(), 200), (another_owner, 200)])?;70 }: {<Pallet<T>>::burn(&collection, &burner, item, 200)?}71 // No users remaining, token is destroyed72 burn_item_fully {73 bench_init!{74 owner: sub; collection: collection(owner);75 sender: cross_from_sub(owner); burner: cross_sub; another_owner: cross_sub;76 };77 let item = create_max_item(&collection, &sender, [(burner.clone(), 200)])?;78 }: {<Pallet<T>>::burn(&collection, &burner, item, 200)?}7980 transfer_normal {81 bench_init!{82 owner: sub; collection: collection(owner);83 sender: cross_from_sub(owner); receiver: cross_sub;84 };85 let item = create_max_item(&collection, &sender, [(sender.clone(), 200), (receiver.clone(), 200)])?;86 }: {<Pallet<T>>::transfer(&collection, &sender, &receiver, item, 100)?}87 // Target account is created88 transfer_creating {89 bench_init!{90 owner: sub; collection: collection(owner);91 sender: cross_from_sub(owner); receiver: cross_sub;92 };93 let item = create_max_item(&collection, &sender, [(sender.clone(), 200)])?;94 }: {<Pallet<T>>::transfer(&collection, &sender, &receiver, item, 100)?}95 // Source account is destroyed96 transfer_removing {97 bench_init!{98 owner: sub; collection: collection(owner);99 sender: cross_from_sub(owner); receiver: cross_sub;100 };101 let item = create_max_item(&collection, &sender, [(sender.clone(), 200), (receiver.clone(), 200)])?;102 }: {<Pallet<T>>::transfer(&collection, &sender, &receiver, item, 200)?}103 // Source account destroyed, target created104 transfer_creating_removing {105 bench_init!{106 owner: sub; collection: collection(owner);107 sender: cross_from_sub(owner); receiver: cross_sub;108 };109 let item = create_max_item(&collection, &sender, [(sender.clone(), 200)])?;110 }: {<Pallet<T>>::transfer(&collection, &sender, &receiver, item, 200)?}111112 approve {113 bench_init!{114 owner: sub; collection: collection(owner);115 owner: cross_from_sub; sender: cross_sub; spender: cross_sub;116 };117 let item = create_max_item(&collection, &owner, [(sender.clone(), 200)])?;118 }: {<Pallet<T>>::set_allowance(&collection, &sender, &spender, item, 100)?}119120 transfer_from_normal {121 bench_init!{122 owner: sub; collection: collection(owner);123 owner: cross_from_sub; sender: cross_sub; spender: cross_sub; receiver: cross_sub;124 };125 let item = create_max_item(&collection, &owner, [(sender.clone(), 200), (receiver.clone(), 200)])?;126 <Pallet<T>>::set_allowance(&collection, &sender, &spender, item, 100)?;127 }: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item, 100)?}128 // Target account is created129 transfer_from_creating {130 bench_init!{131 owner: sub; collection: collection(owner);132 owner: cross_from_sub; sender: cross_sub; spender: cross_sub; receiver: cross_sub;133 };134 let item = create_max_item(&collection, &owner, [(sender.clone(), 200)])?;135 <Pallet<T>>::set_allowance(&collection, &sender, &spender, item, 100)?;136 }: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item, 100)?}137 // Source account is destroyed138 transfer_from_removing {139 bench_init!{140 owner: sub; collection: collection(owner);141 owner: cross_from_sub; sender: cross_sub; spender: cross_sub; receiver: cross_sub;142 };143 let item = create_max_item(&collection, &owner, [(sender.clone(), 200), (receiver.clone(), 200)])?;144 <Pallet<T>>::set_allowance(&collection, &sender, &spender, item, 200)?;145 }: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item, 200)?}146 // Source account destroyed, target created147 transfer_from_creating_removing {148 bench_init!{149 owner: sub; collection: collection(owner);150 owner: cross_from_sub; sender: cross_sub; spender: cross_sub; receiver: cross_sub;151 };152 let item = create_max_item(&collection, &owner, [(sender.clone(), 200)])?;153 <Pallet<T>>::set_allowance(&collection, &sender, &spender, item, 200)?;154 }: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item, 200)?}155156 // Both source account and token is destroyed157 burn_from {158 bench_init!{159 owner: sub; collection: collection(owner);160 owner: cross_from_sub; sender: cross_sub; burner: cross_sub;161 };162 let item = create_max_item(&collection, &owner, [(sender.clone(), 200)])?;163 <Pallet<T>>::set_allowance(&collection, &sender, &burner, item, 200)?;164 }: {<Pallet<T>>::burn_from(&collection, &burner, &sender, item, 200)?}165166 set_variable_metadata {167 let b in 0..CUSTOM_DATA_LIMIT;168 bench_init!{169 owner: sub; collection: collection(owner);170 sender: cross_from_sub(owner);171 };172 let item = create_max_item(&collection, &sender, [(sender.clone(), 200)])?;173 let data = create_data(b as usize);174 }: {<Pallet<T>>::set_variable_metadata(&collection, &sender, item, data)?}175}pallets/refungible/src/common.rsdiffbeforeafterboth--- a/pallets/refungible/src/common.rs
+++ b/pallets/refungible/src/common.rs
@@ -8,8 +8,8 @@
use sp_std::vec::Vec;
use crate::{
- AccountBalance, Allowance, Balance, Config, CreateItemData, Error, Owned, Pallet,
- RefungibleHandle, SelfWeightOf, TokenData, weights::WeightInfo, TokensMinted,
+ AccountBalance, Allowance, Balance, Config, Error, Owned, Pallet, RefungibleHandle,
+ SelfWeightOf, TokenData, weights::WeightInfo, TokensMinted,
};
macro_rules! max_weight_of {
@@ -22,7 +22,7 @@
}
pub struct CommonWeights<T: Config>(PhantomData<T>);
-impl<T: Config> CommonWeightInfo for CommonWeights<T> {
+impl<T: Config> CommonWeightInfo<T::CrossAccountId> for CommonWeights<T> {
fn create_item() -> Weight {
<SelfWeightOf<T>>::create_item()
}
pallets/unique/src/benchmarking.rsdiffbeforeafterboth--- a/pallets/unique/src/benchmarking.rs
+++ b/pallets/unique/src/benchmarking.rs
@@ -5,9 +5,8 @@
use frame_system::RawOrigin;
use frame_benchmarking::{benchmarks, account};
use up_data_structs::*;
-use core::convert::TryInto;
use sp_runtime::DispatchError;
-use pallet_common::benchmarking::{create_data, create_u16_data};
+use pallet_common::benchmarking::{create_data, create_var_data, create_u16_data};
const SEED: u32 = 1;
@@ -16,13 +15,9 @@
mode: CollectionMode,
) -> Result<CollectionId, DispatchError> {
T::Currency::deposit_creating(&owner, T::CollectionCreationPrice::get());
- let col_name = create_u16_data(MAX_COLLECTION_NAME_LENGTH)
- .try_into()
- .unwrap();
- let col_desc = create_u16_data(MAX_COLLECTION_DESCRIPTION_LENGTH)
- .try_into()
- .unwrap();
- let token_prefix = create_data(MAX_TOKEN_PREFIX_LENGTH).try_into().unwrap();
+ let col_name = create_u16_data::<MAX_COLLECTION_NAME_LENGTH>();
+ let col_desc = create_u16_data::<MAX_COLLECTION_DESCRIPTION_LENGTH>();
+ let token_prefix = create_data::<MAX_TOKEN_PREFIX_LENGTH>();
<Pallet<T>>::create_collection(
RawOrigin::Signed(owner).into(),
col_name,
@@ -37,11 +32,10 @@
}
benchmarks! {
-
create_collection {
- let col_name: Vec<u16> = create_u16_data(MAX_COLLECTION_NAME_LENGTH);
- let col_desc: Vec<u16> = create_u16_data(MAX_COLLECTION_DESCRIPTION_LENGTH);
- let token_prefix: Vec<u8> = create_data(MAX_TOKEN_PREFIX_LENGTH);
+ let col_name = create_u16_data::<MAX_COLLECTION_NAME_LENGTH>();
+ let col_desc = create_u16_data::<MAX_COLLECTION_DESCRIPTION_LENGTH>();
+ let token_prefix = create_data::<MAX_TOKEN_PREFIX_LENGTH>();
let mode: CollectionMode = CollectionMode::NFT;
let caller: T::AccountId = account("caller", 0, SEED);
T::Currency::deposit_creating(&caller, T::CollectionCreationPrice::get());
@@ -125,7 +119,7 @@
let caller: T::AccountId = account("caller", 0, SEED);
let collection = create_nft_collection::<T>(caller.clone())?;
- let data = create_data(b as usize);
+ let data = create_var_data(b);
}: set_offchain_schema(RawOrigin::Signed(caller.clone()), collection, data)
set_const_on_chain_schema {
@@ -133,7 +127,7 @@
let caller: T::AccountId = account("caller", 0, SEED);
let collection = create_nft_collection::<T>(caller.clone())?;
- let data = create_data(b as usize);
+ let data = create_var_data(b);
}: set_const_on_chain_schema(RawOrigin::Signed(caller.clone()), collection, data)
set_variable_on_chain_schema {
@@ -141,7 +135,7 @@
let caller: T::AccountId = account("caller", 0, SEED);
let collection = create_nft_collection::<T>(caller.clone())?;
- let data = create_data(b as usize);
+ let data = create_var_data(b);
}: set_variable_on_chain_schema(RawOrigin::Signed(caller.clone()), collection, data)
set_schema_version {
primitives/data-structs/src/lib.rsdiffbeforeafterboth--- a/primitives/data-structs/src/lib.rs
+++ b/primitives/data-structs/src/lib.rs
@@ -76,9 +76,7 @@
/// create_many call
pub const MAX_ITEMS_PER_BATCH: u32 = 200;
-parameter_types! {
- pub const CustomDataLimit: u32 = CUSTOM_DATA_LIMIT;
-}
+pub type CustomDataLimit = ConstU32<CUSTOM_DATA_LIMIT>;
#[derive(
Encode,
@@ -417,15 +415,72 @@
}
}
+fn bounded_debug<V, S>(v: &BoundedVec<V, S>, f: &mut fmt::Formatter) -> Result<(), fmt::Error>
+where
+ V: fmt::Debug,
+{
+ use core::fmt::Debug;
+ (&v as &Vec<V>).fmt(f)
+}
+
+#[cfg(feature = "serde1")]
+#[allow(dead_code)]
+mod bounded_map_serde {
+ use core::convert::TryFrom;
+ use sp_std::collections::btree_map::BTreeMap;
+ use frame_support::{traits::Get, storage::bounded_btree_map::BoundedBTreeMap};
+ use serde::{
+ ser::{self, Serialize},
+ de::{self, Deserialize, Error},
+ };
+ pub fn serialize<D, K, V, S>(
+ value: &BoundedBTreeMap<K, V, S>,
+ serializer: D,
+ ) -> Result<D::Ok, D::Error>
+ where
+ D: ser::Serializer,
+ K: Serialize + Ord,
+ V: Serialize,
+ {
+ (value as &BTreeMap<_, _>).serialize(serializer)
+ }
+
+ pub fn deserialize<'de, D, K, V, S>(
+ deserializer: D,
+ ) -> Result<BoundedBTreeMap<K, V, S>, D::Error>
+ where
+ D: de::Deserializer<'de>,
+ K: de::Deserialize<'de> + Ord,
+ V: de::Deserialize<'de>,
+ S: Get<u32>,
+ {
+ let map = <BTreeMap<K, V>>::deserialize(deserializer)?;
+ let len = map.len();
+ TryFrom::try_from(map).map_err(|_| D::Error::invalid_length(len, &"lesser size"))
+ }
+}
+
+fn bounded_map_debug<K, V, S>(
+ v: &BoundedBTreeMap<K, V, S>,
+ f: &mut fmt::Formatter,
+) -> Result<(), fmt::Error>
+where
+ K: fmt::Debug + Ord,
+ V: fmt::Debug,
+{
+ use core::fmt::Debug;
+ (&v as &BTreeMap<K, V>).fmt(f)
+}
+
#[derive(Encode, Decode, MaxEncodedLen, Default, PartialEq, Clone, Derivative, TypeInfo)]
#[cfg_attr(feature = "serde1", derive(Serialize, Deserialize))]
#[derivative(Debug)]
pub struct CreateNftData {
#[cfg_attr(feature = "serde1", serde(with = "bounded_serde"))]
- #[derivative(Debug = "ignore")]
+ #[derivative(Debug(format_with = "bounded_debug"))]
pub const_data: BoundedVec<u8, CustomDataLimit>,
#[cfg_attr(feature = "serde1", serde(with = "bounded_serde"))]
- #[derivative(Debug = "ignore")]
+ #[derivative(Debug(format_with = "bounded_debug"))]
pub variable_data: BoundedVec<u8, CustomDataLimit>,
}
@@ -440,10 +495,10 @@
#[derivative(Debug)]
pub struct CreateReFungibleData {
#[cfg_attr(feature = "serde1", serde(with = "bounded_serde"))]
- #[derivative(Debug = "ignore")]
+ #[derivative(Debug(format_with = "bounded_debug"))]
pub const_data: BoundedVec<u8, CustomDataLimit>,
#[cfg_attr(feature = "serde1", serde(with = "bounded_serde"))]
- #[derivative(Debug = "ignore")]
+ #[derivative(Debug(format_with = "bounded_debug"))]
pub variable_data: BoundedVec<u8, CustomDataLimit>,
pub pieces: u128,
}