difftreelog
refactor error helpers
in: master
38 files changed
bindings/jsonnet/src/import.rsdiffbeforeafterboth--- a/bindings/jsonnet/src/import.rs
+++ b/bindings/jsonnet/src/import.rs
@@ -13,8 +13,9 @@
};
use jrsonnet_evaluator::{
+ bail,
error::{ErrorKind::*, Result},
- throw, FileImportResolver, ImportResolver,
+ FileImportResolver, ImportResolver,
};
use jrsonnet_gcmodule::Trace;
use jrsonnet_parser::{SourceDirectory, SourceFile, SourcePath};
@@ -80,7 +81,7 @@
assert!(success == 0 || success == 1);
if success == 0 {
let result = String::from_utf8(buf_intern).expect("error should be valid string");
- throw!(ImportCallbackError(result));
+ bail!(ImportCallbackError(result));
}
let found_here_raw = unsafe { CStr::from_ptr(found_here) };
bindings/jsonnet/src/lib.rsdiffbeforeafterboth--- a/bindings/jsonnet/src/lib.rs
+++ b/bindings/jsonnet/src/lib.rs
@@ -19,12 +19,12 @@
};
use jrsonnet_evaluator::{
- apply_tla,
+ apply_tla, bail,
function::TlaArg,
gc::GcHashMap,
manifest::{JsonFormat, ManifestFormat, ToStringFormat},
stack::set_stack_depth_limit,
- tb, throw,
+ tb,
trace::{CompactFormat, PathResolver, TraceFormat},
FileImportResolver, IStr, Result, State, Val,
};
@@ -249,7 +249,7 @@
fn val_to_multi(val: Val, format: &dyn ManifestFormat) -> Result<Vec<(IStr, IStr)>> {
let Val::Obj(val) = val else {
- throw!("expected object as multi output")
+ bail!("expected object as multi output")
};
let mut out = Vec::new();
for (k, v) in val.iter(
@@ -336,7 +336,7 @@
fn val_to_stream(val: Val, format: &dyn ManifestFormat) -> Result<Vec<IStr>> {
let Val::Arr(val) = val else {
- throw!("expected array as stream output")
+ bail!("expected array as stream output")
};
let mut out = Vec::new();
for item in val.iter() {
cmds/jrsonnet/src/main.rsdiffbeforeafterboth--- a/cmds/jrsonnet/src/main.rs
+++ b/cmds/jrsonnet/src/main.rs
@@ -7,9 +7,9 @@
use clap_complete::Shell;
use jrsonnet_cli::{GcOpts, ManifestOpts, MiscOpts, OutputOpts, StdOpts, TlaOpts, TraceOpts};
use jrsonnet_evaluator::{
- apply_tla,
+ apply_tla, bail,
error::{Error as JrError, ErrorKind},
- throw, ResultExt, State, Val,
+ ResultExt, State, Val,
};
#[cfg(feature = "mimalloc")]
@@ -208,7 +208,7 @@
create_dir_all(dir)?;
}
let Val::Obj(obj) = val else {
- throw!(
+ bail!(
"value should be object for --multi manifest, got {}",
val.value_type()
)
crates/jrsonnet-evaluator/src/ctx.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/ctx.rs
+++ b/crates/jrsonnet-evaluator/src/ctx.rs
@@ -54,7 +54,7 @@
pub fn binding(&self, name: IStr) -> Result<Thunk<Val>> {
use std::cmp::Ordering;
- use crate::throw;
+ use crate::bail;
if let Some(val) = self.0.bindings.get(&name).cloned() {
return Ok(val);
@@ -70,7 +70,7 @@
});
heap.sort_by(|a, b| b.0.partial_cmp(&a.0).unwrap_or(Ordering::Equal));
- throw!(VariableIsNotDefined(
+ bail!(VariableIsNotDefined(
name,
heap.into_iter().map(|(_, k)| k).collect()
))
crates/jrsonnet-evaluator/src/dynamic.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/dynamic.rs
+++ b/crates/jrsonnet-evaluator/src/dynamic.rs
@@ -2,7 +2,7 @@
use jrsonnet_gcmodule::{Cc, Trace};
-use crate::{error::ErrorKind::InfiniteRecursionDetected, throw, val::ThunkValue, Result, Thunk};
+use crate::{bail, error::ErrorKind::InfiniteRecursionDetected, val::ThunkValue, Result};
// TODO: Replace with OnceCell once in std
#[derive(Clone, Trace)]
@@ -41,7 +41,7 @@
fn get(self: Box<Self>) -> Result<Self::Output> {
let Some(value) = self.0.get() else {
- throw!(InfiniteRecursionDetected);
+ bail!(InfiniteRecursionDetected);
};
Ok(value.clone())
}
crates/jrsonnet-evaluator/src/error.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/error.rs
+++ b/crates/jrsonnet-evaluator/src/error.rs
@@ -370,17 +370,21 @@
}
#[macro_export]
-macro_rules! throw {
+macro_rules! bail {
($w:ident$(::$i:ident)*$(($($tt:tt)*))?) => {
return Err($w$(::$i)*$(($($tt)*))?.into())
};
($w:ident$(::$i:ident)*$({$($tt:tt)*})?) => {
return Err($w$(::$i)*$({$($tt)*})?.into())
};
- ($l:literal) => {
- return Err($crate::error::ErrorKind::RuntimeError($l.into()).into())
+ ($l:literal$(, $($tt:tt)*)?) => {
+ return Err($crate::error::ErrorKind::RuntimeError(format!($l$(, $($tt)*)?).into()).into())
};
- ($l:literal, $($tt:tt)*) => {
- return Err($crate::error::ErrorKind::RuntimeError(format!($l, $($tt)*).into()).into())
+}
+
+#[macro_export]
+macro_rules! runtime_error {
+ ($l:literal$(, $($tt:tt)*)?) => {
+ $crate::error::Error::from($crate::error::ErrorKind::RuntimeError(format!($l$(, $($tt)*)?).into()))
};
}
crates/jrsonnet-evaluator/src/evaluate/destructure.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/evaluate/destructure.rs
+++ b/crates/jrsonnet-evaluator/src/evaluate/destructure.rs
@@ -3,10 +3,10 @@
use jrsonnet_parser::{BindSpec, Destruct, LocExpr, ParamsDesc};
use crate::{
+ bail,
error::{ErrorKind::*, Result},
evaluate, evaluate_method, evaluate_named,
gc::GcHashMap,
- throw,
val::ThunkValue,
Context, Pending, Thunk, Val,
};
@@ -23,7 +23,7 @@
Destruct::Full(v) => {
let old = new_bindings.insert(v.clone(), parent);
if old.is_some() {
- throw!(DuplicateLocalVar(v.clone()))
+ bail!(DuplicateLocalVar(v.clone()))
}
}
#[cfg(feature = "exp-destruct")]
@@ -46,14 +46,14 @@
fn get(self: Box<Self>) -> Result<Self::Output> {
let v = self.parent.evaluate()?;
let Val::Arr(arr) = v else {
- throw!("expected array");
+ bail!("expected array");
};
if !self.has_rest {
if arr.len() != self.min_len {
- throw!("expected {} elements, got {}", self.min_len, arr.len())
+ bail!("expected {} elements, got {}", self.min_len, arr.len())
}
} else if arr.len() < self.min_len {
- throw!(
+ bail!(
"expected at least {} elements, but array was only {}",
self.min_len,
arr.len()
@@ -178,17 +178,17 @@
fn get(self: Box<Self>) -> Result<Self::Output> {
let v = self.parent.evaluate()?;
let Val::Obj(obj) = v else {
- throw!("expected object");
+ bail!("expected object");
};
for field in &self.field_names {
if !obj.has_field_ex(field.clone(), true) {
- throw!("missing field: {}", field);
+ bail!("missing field: {field}");
}
}
if !self.has_rest {
let len = obj.len();
if len != self.field_names.len() {
- throw!("too many fields, and rest not found");
+ bail!("too many fields, and rest not found");
}
}
Ok(obj)
@@ -310,7 +310,7 @@
}),
);
if old.is_some() {
- throw!(DuplicateLocalVar(name.clone()))
+ bail!(DuplicateLocalVar(name.clone()))
}
}
}
crates/jrsonnet-evaluator/src/evaluate/mod.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/evaluate/mod.rs
+++ b/crates/jrsonnet-evaluator/src/evaluate/mod.rs
@@ -11,11 +11,11 @@
use self::destructure::destruct;
use crate::{
arr::ArrValue,
+ bail,
destructure::evaluate_dest,
error::{suggest_object_fields, ErrorKind::*},
evaluate::operator::{evaluate_add_op, evaluate_binary_op_special, evaluate_unary_op},
function::{CallLocation, FuncDesc, FuncVal},
- throw,
typed::Typed,
val::{CachedUnbound, IndexableVal, StrValue, Thunk, ThunkValue},
Context, GcHashMap, ObjValue, ObjValueBuilder, ObjectAssertion, Pending, Result, ResultExt,
@@ -150,7 +150,7 @@
evaluate_comp(ctx, &specs[1..], callback)?;
}
}
- _ => throw!(InComprehensionCanOnlyIterateOverArray),
+ _ => bail!(InComprehensionCanOnlyIterateOverArray),
},
}
Ok(())
@@ -375,7 +375,7 @@
State::push(loc, || format!("function <{}> call", f.name()), body)?
}
}
- v => throw!(OnlyFunctionsCanBeCalledGot(v.value_type())),
+ v => bail!(OnlyFunctionsCanBeCalledGot(v.value_type())),
})
}
@@ -393,9 +393,9 @@
|| "assertion failure".to_owned(),
|| {
if let Some(msg) = msg {
- throw!(AssertionFailed(evaluate(ctx, msg)?.to_string()?));
+ bail!(AssertionFailed(evaluate(ctx, msg)?.to_string()?));
}
- throw!(AssertionFailed(Val::Null.to_string()?));
+ bail!(AssertionFailed(Val::Null.to_string()?));
},
)?;
}
@@ -457,12 +457,12 @@
if part.null_coaelse {
return Ok(Val::Null);
}
- throw!(NoSuperFound)
+ bail!(NoSuperFound)
};
let name = evaluate(ctx.clone(), &part.value)?;
let Val::Str(name) = name else {
- throw!(ValueIndexMustBeTypeGot(
+ bail!(ValueIndexMustBeTypeGot(
ValType::Obj,
ValType::Str,
name.value_type(),
@@ -483,7 +483,7 @@
None => {
let suggestions = suggest_object_fields(super_obj, name.clone());
- throw!(NoSuchField(name, suggestions))
+ bail!(NoSuchField(name, suggestions))
}
}
}
@@ -502,25 +502,25 @@
None => {
let suggestions = suggest_object_fields(&v, key.clone().into_flat());
- throw!(NoSuchField(key.clone().into_flat(), suggestions))
+ bail!(NoSuchField(key.clone().into_flat(), suggestions))
}
},
- (Val::Obj(_), n) => throw!(ValueIndexMustBeTypeGot(
+ (Val::Obj(_), n) => bail!(ValueIndexMustBeTypeGot(
ValType::Obj,
ValType::Str,
n.value_type(),
)),
(Val::Arr(v), Val::Num(n)) => {
if n.fract() > f64::EPSILON {
- throw!(FractionalIndex)
+ bail!(FractionalIndex)
}
v.get(n as usize)?
.ok_or_else(|| ArrayBoundsError(n as usize, v.len()))?
}
(Val::Arr(_), Val::Str(n)) => {
- throw!(AttemptedIndexAnArrayWithString(n.into_flat()))
+ bail!(AttemptedIndexAnArrayWithString(n.into_flat()))
}
- (Val::Arr(_), n) => throw!(ValueIndexMustBeTypeGot(
+ (Val::Arr(_), n) => bail!(ValueIndexMustBeTypeGot(
ValType::Arr,
ValType::Num,
n.value_type(),
@@ -537,18 +537,18 @@
.into();
if v.is_empty() {
let size = s.into_flat().chars().count();
- throw!(StringBoundsError(n as usize, size))
+ bail!(StringBoundsError(n as usize, size))
}
StrValue::Flat(v)
}),
- (Val::Str(_), n) => throw!(ValueIndexMustBeTypeGot(
+ (Val::Str(_), n) => bail!(ValueIndexMustBeTypeGot(
ValType::Str,
ValType::Num,
n.value_type(),
)),
#[cfg(feature = "exp-null-coaelse")]
(Val::Null, _) if part.null_coaelse => return Ok(Val::Null),
- (v, _) => throw!(CantIndexInto(v.value_type())),
+ (v, _) => bail!(CantIndexInto(v.value_type())),
};
}
indexable
@@ -612,7 +612,7 @@
ErrorStmt(e) => State::push(
CallLocation::new(loc),
|| "error statement".to_owned(),
- || throw!(RuntimeError(evaluate(ctx, e)?.to_string()?,)),
+ || bail!(RuntimeError(evaluate(ctx, e)?.to_string()?,)),
)?,
IfElse {
cond,
@@ -661,7 +661,7 @@
}
i @ (Import(path) | ImportStr(path) | ImportBin(path)) => {
let Expr::Str(path) = &*path.0 else {
- throw!("computed imports are not supported")
+ bail!("computed imports are not supported")
};
let tmp = loc.clone().0;
let s = ctx.state();
crates/jrsonnet-evaluator/src/evaluate/operator.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/evaluate/operator.rs
+++ b/crates/jrsonnet-evaluator/src/evaluate/operator.rs
@@ -4,10 +4,10 @@
use crate::{
arr::ArrValue,
+ bail,
error::ErrorKind::*,
evaluate,
stdlib::std_format,
- throw,
typed::Typed,
val::{equals, StrValue},
Context, Result, Val,
@@ -21,7 +21,7 @@
(Minus, Num(n)) => Num(-*n),
(Not, Bool(v)) => Bool(!v),
(BitNot, Num(n)) => Num(!(*n as i64) as f64),
- (op, o) => throw!(UnaryOperatorDoesNotOperateOnType(op, o.value_type())),
+ (op, o) => bail!(UnaryOperatorDoesNotOperateOnType(op, o.value_type())),
})
}
@@ -49,7 +49,7 @@
(Num(v1), Num(v2)) => Val::new_checked_num(v1 + v2)?,
#[cfg(feature = "exp-bigint")]
(BigInt(a), BigInt(b)) => BigInt(Box::new((&**a).clone() + (&**b).clone())),
- _ => throw!(BinaryOperatorDoesNotOperateOnValues(
+ _ => bail!(BinaryOperatorDoesNotOperateOnValues(
BinaryOpType::Add,
a.value_type(),
b.value_type(),
@@ -62,14 +62,14 @@
match (a, b) {
(Num(a), Num(b)) => {
if *b == 0.0 {
- throw!(DivisionByZero)
+ bail!(DivisionByZero)
}
Ok(Num(a % b))
}
(Str(str), vals) => {
String::into_untyped(std_format(&str.clone().into_flat(), vals.clone())?)
}
- (a, b) => throw!(BinaryOperatorDoesNotOperateOnValues(
+ (a, b) => bail!(BinaryOperatorDoesNotOperateOnValues(
BinaryOpType::Mod,
a.value_type(),
b.value_type()
@@ -124,7 +124,7 @@
}
a.len().cmp(&b.len())
}
- (_, _) => throw!(BinaryOperatorDoesNotOperateOnValues(
+ (_, _) => bail!(BinaryOperatorDoesNotOperateOnValues(
op,
a.value_type(),
b.value_type()
@@ -159,7 +159,7 @@
(Num(v1), Mul, Num(v2)) => Val::new_checked_num(v1 * v2)?,
(Num(v1), Div, Num(v2)) => {
if *v2 == 0.0 {
- throw!(DivisionByZero)
+ bail!(DivisionByZero)
}
Val::new_checked_num(v1 / v2)?
}
@@ -171,14 +171,14 @@
(Num(v1), BitXor, Num(v2)) => Num((*v1 as i64 ^ *v2 as i64) as f64),
(Num(v1), Lhs, Num(v2)) => {
if *v2 < 0.0 {
- throw!("shift by negative exponent")
+ bail!("shift by negative exponent")
}
let exp = ((*v2 as i64) & 63) as u32;
Num((*v1 as i64).wrapping_shl(exp) as f64)
}
(Num(v1), Rhs, Num(v2)) => {
if *v2 < 0.0 {
- throw!("shift by negative exponent")
+ bail!("shift by negative exponent")
}
let exp = ((*v2 as i64) & 63) as u32;
Num((*v1 as i64).wrapping_shr(exp) as f64)
@@ -190,7 +190,7 @@
#[cfg(feature = "exp-bigint")]
(BigInt(a), Sub, BigInt(b)) => BigInt(Box::new((&**a).clone() - (&**b).clone())),
- _ => throw!(BinaryOperatorDoesNotOperateOnValues(
+ _ => bail!(BinaryOperatorDoesNotOperateOnValues(
op,
a.value_type(),
b.value_type(),
crates/jrsonnet-evaluator/src/function/arglike.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/function/arglike.rs
+++ b/crates/jrsonnet-evaluator/src/function/arglike.rs
@@ -3,14 +3,7 @@
use jrsonnet_interner::IStr;
use jrsonnet_parser::{ArgsDesc, LocExpr};
-use crate::{
- error::Result,
- evaluate,
- gc::GcHashMap,
- typed::Typed,
- val::{StrValue, ThunkValue},
- Context, Thunk, Val,
-};
+use crate::{evaluate, gc::GcHashMap, typed::Typed, val::ThunkValue, Context, Result, Thunk, Val};
/// Marker for arguments, which can be evaluated with context set to None
pub trait OptionalContext {}
crates/jrsonnet-evaluator/src/function/builtin.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/function/builtin.rs
+++ b/crates/jrsonnet-evaluator/src/function/builtin.rs
@@ -4,7 +4,7 @@
use jrsonnet_interner::IStr;
use super::{arglike::ArgsLike, parse::parse_builtin_call, CallLocation};
-use crate::{error::Result, gc::TraceBox, tb, Context, Val};
+use crate::{gc::TraceBox, tb, Context, Result, Val};
/// Can't have str | IStr, because constant BuiltinParam causes
/// E0492: constant functions cannot refer to interior mutable data
crates/jrsonnet-evaluator/src/function/parse.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/function/parse.rs
+++ b/crates/jrsonnet-evaluator/src/function/parse.rs
@@ -6,11 +6,11 @@
use super::{arglike::ArgsLike, builtin::BuiltinParam};
use crate::{
+ bail,
destructure::destruct,
error::{ErrorKind::*, Result},
evaluate_named,
gc::GcHashMap,
- throw,
val::ThunkValue,
Context, Pending, Thunk, Val,
};
@@ -47,7 +47,7 @@
let mut passed_args =
GcHashMap::with_capacity(params.iter().map(|p| p.0.capacity_hint()).sum());
if args.unnamed_len() > params.len() {
- throw!(TooManyArgsFunctionHas(
+ bail!(TooManyArgsFunctionHas(
params.len(),
params.iter().map(|p| (p.0.name(), p.1.is_some())).collect()
))
@@ -71,10 +71,10 @@
args.named_iter(ctx, tailstrict, &mut |name, value| {
// FIXME: O(n) for arg existence check
if !params.iter().any(|p| p.0.name().as_ref() == Some(name)) {
- throw!(UnknownFunctionParameter((name as &str).to_owned()));
+ bail!(UnknownFunctionParameter((name as &str).to_owned()));
}
if passed_args.insert(name.clone(), value).is_some() {
- throw!(BindingParameterASecondTime(name.clone()));
+ bail!(BindingParameterASecondTime(name.clone()));
}
filled_named += 1;
Ok(())
@@ -125,7 +125,7 @@
}
});
if !found {
- throw!(FunctionParameterNotBoundInCall(
+ bail!(FunctionParameterNotBoundInCall(
param.0.clone().name(),
params.iter().map(|p| (p.0.name(), p.1.is_some())).collect()
));
@@ -159,7 +159,7 @@
) -> Result<Vec<Option<Thunk<Val>>>> {
let mut passed_args: Vec<Option<Thunk<Val>>> = vec![None; params.len()];
if args.unnamed_len() > params.len() {
- throw!(TooManyArgsFunctionHas(
+ bail!(TooManyArgsFunctionHas(
params.len(),
params
.iter()
@@ -183,7 +183,7 @@
.position(|p| p.name() == name)
.ok_or_else(|| UnknownFunctionParameter((name as &str).to_owned()))?;
if replace(&mut passed_args[id], Some(arg)).is_some() {
- throw!(BindingParameterASecondTime(name.clone()));
+ bail!(BindingParameterASecondTime(name.clone()));
}
filled_args += 1;
Ok(())
@@ -207,7 +207,7 @@
}
});
if !found {
- throw!(FunctionParameterNotBoundInCall(
+ bail!(FunctionParameterNotBoundInCall(
param.name().as_str().map(IStr::from),
params
.iter()
crates/jrsonnet-evaluator/src/import.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/import.rs
+++ b/crates/jrsonnet-evaluator/src/import.rs
@@ -12,8 +12,8 @@
use jrsonnet_parser::{SourceDirectory, SourceFile, SourcePath};
use crate::{
+ bail,
error::{ErrorKind::*, Result},
- throw,
};
/// Implements file resolution logic for `import` and `importStr`
@@ -25,14 +25,14 @@
/// `from` should only be returned from [`ImportResolver::resolve`], or from other defined file, any other value
/// may result in panic
fn resolve_from(&self, from: &SourcePath, path: &str) -> Result<SourcePath> {
- throw!(ImportNotSupported(from.clone(), path.into()))
+ bail!(ImportNotSupported(from.clone(), path.into()))
}
fn resolve_from_default(&self, path: &str) -> Result<SourcePath> {
self.resolve_from(&SourcePath::default(), path)
}
/// Resolves absolute path, doesn't supports jpath and other fancy things
fn resolve(&self, path: &Path) -> Result<SourcePath> {
- throw!(AbsoluteImportNotSupported(path.to_owned()))
+ bail!(AbsoluteImportNotSupported(path.to_owned()))
}
/// Load resolved file
@@ -110,16 +110,16 @@
)));
}
}
- throw!(ImportFileNotFound(from.clone(), path.to_owned()))
+ bail!(ImportFileNotFound(from.clone(), path.to_owned()))
}
}
fn resolve(&self, path: &Path) -> Result<SourcePath> {
let meta = match fs::metadata(path) {
Ok(v) => v,
Err(e) if e.kind() == ErrorKind::NotFound => {
- throw!(AbsoluteImportFileNotFound(path.to_owned()))
+ bail!(AbsoluteImportFileNotFound(path.to_owned()))
}
- Err(e) => throw!(ImportIo(e.to_string())),
+ Err(e) => bail!(ImportIo(e.to_string())),
};
if meta.is_file() {
Ok(SourcePath::new(SourceFile::new(
@@ -138,7 +138,7 @@
let path = if let Some(f) = id.downcast_ref::<SourceFile>() {
f.path()
} else if id.downcast_ref::<SourceDirectory>().is_some() || id.is_default() {
- throw!(ImportIsADirectory(id.clone()))
+ bail!(ImportIsADirectory(id.clone()))
} else {
unreachable!("other types are not supported in resolve");
};
crates/jrsonnet-evaluator/src/integrations/serde.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/integrations/serde.rs
+++ b/crates/jrsonnet-evaluator/src/integrations/serde.rs
@@ -620,6 +620,6 @@
where
T: std::fmt::Display,
{
- JrError::new(ErrorKind::RuntimeError(format!("serde: {msg}").into()))
+ runtime_error!("serde: {msg}")
}
}
crates/jrsonnet-evaluator/src/lib.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/lib.rs
+++ b/crates/jrsonnet-evaluator/src/lib.rs
@@ -354,7 +354,7 @@
}
let parsed = file.parsed.as_ref().expect("just set").clone();
if file.evaluating {
- throw!(InfiniteRecursionDetected)
+ bail!(InfiniteRecursionDetected)
}
file.evaluating = true;
// Dropping file cache guard here, as evaluation may use this map too
crates/jrsonnet-evaluator/src/manifest.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/manifest.rs
+++ b/crates/jrsonnet-evaluator/src/manifest.rs
@@ -1,9 +1,6 @@
use std::{borrow::Cow, fmt::Write};
-use crate::{
- error::{ErrorKind::*, Result},
- throw, State, Val,
-};
+use crate::{bail, Result, State, Val};
pub trait ManifestFormat {
fn manifest_buf(&self, val: Val, buf: &mut String) -> Result<()>;
@@ -268,7 +265,7 @@
}
buf.push('}');
}
- Val::Func(_) => throw!(RuntimeError("tried to manifest function".into())),
+ Val::Func(_) => bail!("tried to manifest function"),
};
Ok(())
}
@@ -292,7 +289,7 @@
impl ManifestFormat for StringFormat {
fn manifest_buf(&self, val: Val, out: &mut String) -> Result<()> {
let Val::Str(s) = val else {
- throw!(
+ bail!(
"output should be string for string manifest format, got {}",
val.value_type()
)
@@ -309,7 +306,7 @@
impl<I: ManifestFormat> ManifestFormat for YamlStreamFormat<I> {
fn manifest_buf(&self, val: Val, out: &mut String) -> Result<()> {
let Val::Arr(arr) = val else {
- throw!(
+ bail!(
"output should be array for yaml stream format, got {}",
val.value_type()
)
crates/jrsonnet-evaluator/src/obj.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/obj.rs
+++ b/crates/jrsonnet-evaluator/src/obj.rs
@@ -13,11 +13,12 @@
use crate::{
arr::{PickObjectKeyValues, PickObjectValues},
+ bail,
error::{suggest_object_fields, Error, ErrorKind::*},
function::CallLocation,
gc::{GcHashMap, GcHashSet, TraceBox},
operator::evaluate_add_op,
- tb, throw,
+ tb,
val::{ArrValue, ThunkValue},
MaybeUnbound, Result, State, Thunk, Unbound, Val,
};
@@ -404,7 +405,7 @@
pub fn get_or_bail(&self, key: IStr) -> Result<Val> {
let Some(value) = self.get(key.clone())? else {
let suggestions = suggest_object_fields(self, key.clone());
- throw!(NoSuchField(key, suggestions))
+ bail!(NoSuchField(key, suggestions))
};
Ok(value)
}
@@ -723,7 +724,7 @@
return Ok(match v {
CacheValue::Cached(v) => Some(v.clone()),
CacheValue::NotFound => None,
- CacheValue::Pending => throw!(InfiniteRecursionDetected),
+ CacheValue::Pending => bail!(InfiniteRecursionDetected),
CacheValue::Errored(e) => return Err(e.clone()),
});
}
@@ -953,7 +954,7 @@
State::push(
CallLocation(location.as_ref()),
|| format!("field <{}> initializtion", name.clone()),
- || throw!(DuplicateFieldName(name.clone())),
+ || bail!(DuplicateFieldName(name.clone())),
)?;
}
Ok(())
crates/jrsonnet-evaluator/src/stdlib/format.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/stdlib/format.rs
+++ b/crates/jrsonnet-evaluator/src/stdlib/format.rs
@@ -7,8 +7,8 @@
use thiserror::Error;
use crate::{
+ bail,
error::{format_found, suggest_object_fields, ErrorKind::*},
- throw,
typed::Typed,
Error, ObjValue, Result, Val,
};
@@ -611,12 +611,12 @@
Val::Str(s) => {
let s = s.into_flat();
if s.chars().count() != 1 {
- throw!("%c expected 1 char string, got {}", s.chars().count(),);
+ bail!("%c expected 1 char string, got {}", s.chars().count());
}
tmp_out.push_str(&s);
}
_ => {
- throw!(TypeMismatch(
+ bail!(TypeMismatch(
"%c requires number/string",
vec![ValType::Num, ValType::Str],
value.value_type(),
@@ -657,7 +657,7 @@
let width = match c.width {
Width::Star => {
if values.is_empty() {
- throw!(NotEnoughValues);
+ bail!(NotEnoughValues);
}
let value = &values[0];
values = &values[1..];
@@ -668,7 +668,7 @@
let precision = match c.precision {
Some(Width::Star) => {
if values.is_empty() {
- throw!(NotEnoughValues);
+ bail!(NotEnoughValues);
}
let value = &values[0];
values = &values[1..];
@@ -683,7 +683,7 @@
&Val::Null
} else {
if values.is_empty() {
- throw!(NotEnoughValues);
+ bail!(NotEnoughValues);
}
let value = &values[0];
values = &values[1..];
@@ -696,7 +696,7 @@
}
if !values.is_empty() {
- throw!(
+ bail!(
"too many values to format, expected {value_count}, got {}",
value_count + values.len()
)
@@ -717,7 +717,7 @@
let current = &field[name_offset..end_offset];
let full = &field[..name_offset];
let found = Box::new(suggest_object_fields(&obj, current.into()));
- throw!(SubfieldNotFound {
+ bail!(SubfieldNotFound {
current: current.into(),
full: full.into(),
found,
@@ -726,7 +726,7 @@
} else {
// No underflow may happen, initially we always start with an object
let subfield = &field[..name_offset - 1];
- throw!(SubfieldDidntYieldAnObject(
+ bail!(SubfieldDidntYieldAnObject(
subfield.into(),
current.value_type()
));
@@ -750,13 +750,13 @@
let f: IStr = c.mkey.into();
let width = match c.width {
Width::Star => {
- throw!(CannotUseStarWidthWithObject);
+ bail!(CannotUseStarWidthWithObject);
}
Width::Fixed(n) => n,
};
let precision = match c.precision {
Some(Width::Star) => {
- throw!(CannotUseStarWidthWithObject);
+ bail!(CannotUseStarWidthWithObject);
}
Some(Width::Fixed(n)) => Some(n),
None => None,
@@ -766,7 +766,7 @@
Val::Null
} else {
if f.is_empty() {
- throw!(MappingKeysRequired);
+ bail!(MappingKeysRequired);
}
if let Some(v) = values.get(f.clone())? {
v
crates/jrsonnet-evaluator/src/stdlib/mod.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/stdlib/mod.rs
+++ b/crates/jrsonnet-evaluator/src/stdlib/mod.rs
@@ -3,7 +3,7 @@
use format::{format_arr, format_obj};
-use crate::{error::Result, function::CallLocation, State, Val};
+use crate::{function::CallLocation, Result, State, Val};
pub mod format;
crates/jrsonnet-evaluator/src/typed/conversions.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/typed/conversions.rs
+++ b/crates/jrsonnet-evaluator/src/typed/conversions.rs
@@ -7,12 +7,11 @@
use crate::{
arr::{ArrValue, BytesArray},
- error::Result,
+ bail,
function::{native::NativeDesc, FuncDesc, FuncVal},
- throw,
typed::CheckType,
- val::{IndexableVal, StrValue, ThunkMapper},
- ObjValue, ObjValueBuilder, Thunk, Val,
+ val::{IndexableVal, ThunkMapper},
+ ObjValue, ObjValueBuilder, Result, Thunk, Val,
};
#[derive(Trace)]
@@ -134,7 +133,7 @@
Val::Num(n) => {
#[allow(clippy::float_cmp)]
if n.trunc() != n {
- throw!(
+ bail!(
"cannot convert number with fractional part to {}",
stringify!($ty)
)
@@ -189,7 +188,7 @@
Val::Num(n) => {
#[allow(clippy::float_cmp)]
if n.trunc() != n {
- throw!(
+ bail!(
"cannot convert number with fractional part to {}",
stringify!($ty)
)
@@ -253,7 +252,7 @@
fn into_untyped(value: Self) -> Result<Val> {
if value > MAX_SAFE_INTEGER as Self {
- throw!("number is too large")
+ bail!("number is too large")
}
Ok(Val::Num(value as f64))
}
@@ -264,7 +263,7 @@
Val::Num(n) => {
#[allow(clippy::float_cmp)]
if n.trunc() != n {
- throw!("cannot convert number with fractional part to usize")
+ bail!("cannot convert number with fractional part to usize")
}
Ok(n as Self)
}
@@ -354,7 +353,7 @@
let mut out = ObjValueBuilder::with_capacity(typed.len());
for (k, v) in typed {
let Some(key) = K::into_untyped(k)?.as_str() else {
- throw!("map key should serialize to string");
+ bail!("map key should serialize to string");
};
let value = V::into_untyped(v)?;
out.member(key).value_unchecked(value);
@@ -567,7 +566,7 @@
<Self as Typed>::TYPE.check(&value)?;
match value {
Val::Func(FuncVal::Normal(desc)) => Ok(desc),
- Val::Func(_) => throw!("expected normal function, not builtin"),
+ Val::Func(_) => bail!("expected normal function, not builtin"),
_ => unreachable!(),
}
}
@@ -649,7 +648,7 @@
const TYPE: &'static ComplexValType = &ComplexValType::Simple(ValType::Func);
fn into_untyped(_typed: Self) -> Result<Val> {
- throw!("can only convert functions from jsonnet to native")
+ bail!("can only convert functions from jsonnet to native")
}
fn from_untyped(untyped: Val) -> Result<Self> {
crates/jrsonnet-evaluator/src/val.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/val.rs
+++ b/crates/jrsonnet-evaluator/src/val.rs
@@ -11,11 +11,12 @@
pub use crate::arr::{ArrValue, ArrayLike};
use crate::{
+ bail,
error::{Error, ErrorKind::*},
function::FuncVal,
gc::{GcHashMap, TraceBox},
manifest::{ManifestFormat, ToStringFormat},
- tb, throw,
+ tb,
typed::BoundedUsize,
ObjValue, Result, Unbound, WeakObjValue,
};
@@ -456,7 +457,7 @@
if num.is_finite() {
Ok(Self::Num(num))
} else {
- throw!("overflow")
+ bail!("overflow")
}
}
@@ -495,7 +496,7 @@
Ok(match self {
Val::Str(s) => IndexableVal::Str(s.into_flat()),
Val::Arr(arr) => IndexableVal::Arr(arr),
- _ => throw!(ValueIsNotIndexable(self.value_type())),
+ _ => bail!(ValueIsNotIndexable(self.value_type())),
})
}
}
@@ -514,13 +515,13 @@
#[cfg(feature = "exp-bigint")]
(Val::BigInt(a), Val::BigInt(b)) => a == b,
(Val::Arr(_), Val::Arr(_)) => {
- throw!("primitiveEquals operates on primitive types, got array")
+ bail!("primitiveEquals operates on primitive types, got array")
}
(Val::Obj(_), Val::Obj(_)) => {
- throw!("primitiveEquals operates on primitive types, got object")
+ bail!("primitiveEquals operates on primitive types, got object")
}
(a, b) if is_function_like(a) && is_function_like(b) => {
- throw!("cannot test equality of functions")
+ bail!("cannot test equality of functions")
}
(_, _) => false,
})
crates/jrsonnet-macros/src/lib.rsdiffbeforeafterboth1use proc_macro2::TokenStream;2use quote::quote;3use syn::{4 parenthesized,5 parse::{Parse, ParseStream},6 parse_macro_input,7 punctuated::Punctuated,8 spanned::Spanned,9 token::{self, Comma},10 Attribute, DeriveInput, Error, FnArg, GenericArgument, Ident, ItemFn, LitStr, Pat, Path,11 PathArguments, Result, ReturnType, Token, Type,12};1314fn parse_attr<A: Parse, I>(attrs: &[Attribute], ident: I) -> Result<Option<A>>15where16 Ident: PartialEq<I>,17{18 let attrs = attrs19 .iter()20 .filter(|a| a.path.is_ident(&ident))21 .collect::<Vec<_>>();22 if attrs.len() > 1 {23 return Err(Error::new(24 attrs[1].span(),25 "this attribute may be specified only once",26 ));27 } else if attrs.is_empty() {28 return Ok(None);29 }30 let attr = attrs[0];31 let attr = attr.parse_args::<A>()?;3233 Ok(Some(attr))34}3536fn path_is(path: &Path, needed: &str) -> bool {37 path.leading_colon.is_none()38 && !path.segments.is_empty()39 && path.segments.iter().last().unwrap().ident == needed40}4142fn type_is_path<'ty>(ty: &'ty Type, needed: &str) -> Option<&'ty PathArguments> {43 match ty {44 Type::Path(path) if path.qself.is_none() && path_is(&path.path, needed) => {45 let args = &path.path.segments.iter().last().unwrap().arguments;46 Some(args)47 }48 _ => None,49 }50}5152fn extract_type_from_option(ty: &Type) -> Result<Option<&Type>> {53 let Some(args) = type_is_path(ty, "Option") else {54 return Ok(None);55 };56 // It should have only on angle-bracketed param ("<String>"):57 let PathArguments::AngleBracketed(params) = args else {58 return Err(Error::new(args.span(), "missing option generic"));59 };60 let generic_arg = params.args.iter().next().unwrap();61 // This argument must be a type:62 let GenericArgument::Type(ty) = generic_arg else {63 return Err(Error::new(64 generic_arg.span(),65 "option generic should be a type",66 ));67 };68 Ok(Some(ty))69}7071struct Field {72 attrs: Vec<Attribute>,73 name: Ident,74 _colon: Token![:],75 ty: Type,76}77impl Parse for Field {78 fn parse(input: ParseStream) -> syn::Result<Self> {79 Ok(Self {80 attrs: input.call(Attribute::parse_outer)?,81 name: input.parse()?,82 _colon: input.parse()?,83 ty: input.parse()?,84 })85 }86}8788mod kw {89 syn::custom_keyword!(fields);90 syn::custom_keyword!(rename);91 syn::custom_keyword!(flatten);92 syn::custom_keyword!(add);93 syn::custom_keyword!(hide);94 syn::custom_keyword!(ok);95}9697struct EmptyAttr;98impl Parse for EmptyAttr {99 fn parse(_input: ParseStream) -> Result<Self> {100 Ok(Self)101 }102}103104struct BuiltinAttrs {105 fields: Vec<Field>,106}107impl Parse for BuiltinAttrs {108 fn parse(input: ParseStream) -> syn::Result<Self> {109 if input.is_empty() {110 return Ok(Self { fields: Vec::new() });111 }112 input.parse::<kw::fields>()?;113 let fields;114 parenthesized!(fields in input);115 let p = Punctuated::<Field, Comma>::parse_terminated(&fields)?;116 Ok(Self {117 fields: p.into_iter().collect(),118 })119 }120}121122enum ArgInfo {123 Normal {124 ty: Box<Type>,125 is_option: bool,126 name: Option<String>,127 cfg_attrs: Vec<Attribute>,128 },129 Lazy {130 is_option: bool,131 name: Option<String>,132 },133 Context,134 Location,135 This,136}137138impl ArgInfo {139 fn parse(name: &str, arg: &FnArg) -> Result<Self> {140 let FnArg::Typed(arg) = arg else {141 unreachable!()142 };143 let ident = match &arg.pat as &Pat {144 Pat::Ident(i) => Some(i.ident.clone()),145 _ => None,146 };147 let ty = &arg.ty;148 if type_is_path(ty, "Context").is_some() {149 return Ok(Self::Context);150 } else if type_is_path(ty, "CallLocation").is_some() {151 return Ok(Self::Location);152 } else if type_is_path(ty, "Thunk").is_some() {153 return Ok(Self::Lazy {154 is_option: false,155 name: ident.map(|v| v.to_string()),156 });157 }158159 match ty as &Type {160 Type::Reference(r) if type_is_path(&r.elem, name).is_some() => return Ok(Self::This),161 _ => {}162 }163164 let (is_option, ty) = if let Some(ty) = extract_type_from_option(ty)? {165 if type_is_path(ty, "Thunk").is_some() {166 return Ok(Self::Lazy {167 is_option: true,168 name: ident.map(|v| v.to_string()),169 });170 }171172 (true, Box::new(ty.clone()))173 } else {174 (false, ty.clone())175 };176177 let cfg_attrs = arg178 .attrs179 .iter()180 .filter(|a| a.path.is_ident("cfg"))181 .cloned()182 .collect();183184 Ok(Self::Normal {185 ty,186 is_option,187 name: ident.map(|v| v.to_string()),188 cfg_attrs,189 })190 }191}192193#[proc_macro_attribute]194pub fn builtin(195 attr: proc_macro::TokenStream,196 item: proc_macro::TokenStream,197) -> proc_macro::TokenStream {198 let attr = parse_macro_input!(attr as BuiltinAttrs);199 let item_fn = item.clone();200 let item_fn: ItemFn = parse_macro_input!(item_fn);201202 match builtin_inner(attr, item_fn, item.into()) {203 Ok(v) => v.into(),204 Err(e) => e.into_compile_error().into(),205 }206}207208fn builtin_inner(209 attr: BuiltinAttrs,210 fun: ItemFn,211 item: proc_macro2::TokenStream,212) -> syn::Result<TokenStream> {213 let ReturnType::Type(_, result) = &fun.sig.output else {214 return Err(Error::new(215 fun.sig.span(),216 "builtin should return something",217 ));218 };219220 let name = fun.sig.ident.to_string();221 let args = fun222 .sig223 .inputs224 .iter()225 .map(|arg| ArgInfo::parse(&name, arg))226 .collect::<Result<Vec<_>>>()?;227228 let params_desc = args.iter().flat_map(|a| match a {229 ArgInfo::Normal {230 is_option,231 name,232 cfg_attrs,233 ..234 } => {235 let name = name236 .as_ref()237 .map(|n| quote! {ParamName::new_static(#n)})238 .unwrap_or_else(|| quote! {None});239 Some(quote! {240 #(#cfg_attrs)*241 BuiltinParam::new(#name, #is_option),242 })243 }244 ArgInfo::Lazy { is_option, name } => {245 let name = name246 .as_ref()247 .map(|n| quote! {ParamName::new_static(#n)})248 .unwrap_or_else(|| quote! {None});249 Some(quote! {250 BuiltinParam::new(#name, #is_option),251 })252 }253 ArgInfo::Context => None,254 ArgInfo::Location => None,255 ArgInfo::This => None,256 });257258 let mut id = 0usize;259 let pass = args260 .iter()261 .map(|a| match a {262 ArgInfo::Normal { .. } | ArgInfo::Lazy { .. } => {263 let cid = id;264 id += 1;265 (quote! {#cid}, a)266 }267 ArgInfo::Context | ArgInfo::Location | ArgInfo::This => {268 (quote! {compile_error!("should not use id")}, a)269 }270 })271 .map(|(id, a)| match a {272 ArgInfo::Normal {273 ty,274 is_option,275 name,276 cfg_attrs,277 } => {278 let name = name.as_ref().map(|v| v.as_str()).unwrap_or("<unnamed>");279 let eval = quote! {jrsonnet_evaluator::State::push_description(280 || format!("argument <{}> evaluation", #name),281 || <#ty>::from_untyped(value.evaluate()?),282 )?};283 let value = if *is_option {284 quote! {if let Some(value) = &parsed[#id] {285 Some(#eval)286 } else {287 None288 },}289 } else {290 quote! {{291 let value = parsed[#id].as_ref().expect("args shape is checked");292 #eval293 },}294 };295 quote! {296 #(#cfg_attrs)*297 #value298 }299 }300 ArgInfo::Lazy { is_option, .. } => {301 if *is_option {302 quote! {if let Some(value) = &parsed[#id] {303 Some(value.clone())304 } else {305 None306 }}307 } else {308 quote! {309 parsed[#id].as_ref().expect("args shape is correct").clone(),310 }311 }312 }313 ArgInfo::Context => quote! {ctx.clone(),},314 ArgInfo::Location => quote! {location,},315 ArgInfo::This => quote! {self,},316 });317318 let fields = attr.fields.iter().map(|field| {319 let attrs = &field.attrs;320 let name = &field.name;321 let ty = &field.ty;322 quote! {323 #(#attrs)*324 pub #name: #ty,325 }326 });327328 let name = &fun.sig.ident;329 let vis = &fun.vis;330 let static_ext = if attr.fields.is_empty() {331 quote! {332 impl #name {333 pub const INST: &'static dyn StaticBuiltin = &#name {};334 }335 impl StaticBuiltin for #name {}336 }337 } else {338 quote! {}339 };340 let static_derive_copy = if attr.fields.is_empty() {341 quote! {, Copy}342 } else {343 quote! {}344 };345346 Ok(quote! {347 #item348349 #[doc(hidden)]350 #[allow(non_camel_case_types)]351 #[derive(Clone, jrsonnet_gcmodule::Trace #static_derive_copy)]352 #vis struct #name {353 #(#fields)*354 }355 const _: () = {356 use ::jrsonnet_evaluator::{357 State, Val,358 function::{builtin::{Builtin, StaticBuiltin, BuiltinParam, ParamName}, CallLocation, ArgsLike, parse::parse_builtin_call},359 error::Result, Context, typed::Typed,360 parser::ExprLocation,361 };362 const PARAMS: &'static [BuiltinParam] = &[363 #(#params_desc)*364 ];365366 #static_ext367 impl Builtin for #name368 where369 Self: 'static370 {371 fn name(&self) -> &str {372 stringify!(#name)373 }374 fn params(&self) -> &[BuiltinParam] {375 PARAMS376 }377 fn call(&self, ctx: Context, location: CallLocation, args: &dyn ArgsLike) -> Result<Val> {378 let parsed = parse_builtin_call(ctx.clone(), &PARAMS, args, false)?;379380 let result: #result = #name(#(#pass)*);381 <_ as Typed>::into_result(result)382 }383 fn as_any(&self) -> &dyn ::std::any::Any {384 self385 }386 }387 };388 })389}390391#[derive(Default)]392struct TypedAttr {393 rename: Option<String>,394 flatten: bool,395 /// flatten(ok) strategy for flattened optionals396 /// field would be None in case of any parsing error (as in serde)397 flatten_ok: bool,398 // Should it be `field+:` instead of `field:`399 add: bool,400 // Should it be `field::` instead of `field:`401 hide: bool,402}403impl Parse for TypedAttr {404 fn parse(input: ParseStream) -> syn::Result<Self> {405 let mut out = Self::default();406 loop {407 let lookahead = input.lookahead1();408 if lookahead.peek(kw::rename) {409 input.parse::<kw::rename>()?;410 input.parse::<Token![=]>()?;411 let name = input.parse::<LitStr>()?;412 if out.rename.is_some() {413 return Err(Error::new(414 name.span(),415 "rename attribute may only be specified once",416 ));417 }418 out.rename = Some(name.value());419 } else if lookahead.peek(kw::flatten) {420 input.parse::<kw::flatten>()?;421 out.flatten = true;422 if input.peek(token::Paren) {423 let content;424 parenthesized!(content in input);425 let lookahead = content.lookahead1();426 if lookahead.peek(kw::ok) {427 content.parse::<kw::ok>()?;428 out.flatten_ok = true;429 } else {430 return Err(lookahead.error());431 }432 }433 } else if lookahead.peek(kw::add) {434 input.parse::<kw::add>()?;435 out.add = true;436 } else if lookahead.peek(kw::hide) {437 input.parse::<kw::hide>()?;438 out.hide = true;439 } else if input.is_empty() {440 break;441 } else {442 return Err(lookahead.error());443 }444 if input.peek(Token![,]) {445 input.parse::<Token![,]>()?;446 } else {447 break;448 }449 }450 Ok(out)451 }452}453454struct TypedField {455 attr: TypedAttr,456 ident: Ident,457 ty: Type,458 is_option: bool,459}460impl TypedField {461 fn parse(field: &syn::Field) -> Result<Self> {462 let attr = parse_attr::<TypedAttr, _>(&field.attrs, "typed")?.unwrap_or_default();463 let Some(ident) = field.ident.clone() else {464 return Err(Error::new(465 field.span(),466 "this field should appear in output object, but it has no visible name",467 ));468 };469 let (is_option, ty) = if let Some(ty) = extract_type_from_option(&field.ty)? {470 (true, ty.clone())471 } else {472 (false, field.ty.clone())473 };474 if is_option && attr.flatten {475 if !attr.flatten_ok {476 return Err(Error::new(477 field.span(),478 "strategy should be set when flattening Option",479 ));480 }481 } else if attr.flatten_ok {482 return Err(Error::new(483 field.span(),484 "flatten(ok) is only useable on optional fields",485 ));486 }487488 Ok(Self {489 attr,490 ident,491 ty,492 is_option,493 })494 }495 /// None if this field is flattened in jsonnet output496 fn name(&self) -> Option<String> {497 if self.attr.flatten {498 return None;499 }500 Some(501 self.attr502 .rename503 .clone()504 .unwrap_or_else(|| self.ident.to_string()),505 )506 }507508 fn expand_field(&self) -> Option<TokenStream> {509 if self.is_option {510 return None;511 }512 let name = self.name()?;513 let ty = &self.ty;514 Some(quote! {515 (#name, <#ty as Typed>::TYPE)516 })517 }518 fn expand_parse(&self) -> TokenStream {519 let ident = &self.ident;520 let ty = &self.ty;521 if self.attr.flatten {522 // optional flatten is handled in same way as serde523 return if self.is_option {524 quote! {525 #ident: <#ty as TypedObj>::parse(&obj).ok(),526 }527 } else {528 quote! {529 #ident: <#ty as TypedObj>::parse(&obj)?,530 }531 };532 };533534 let name = self.name().unwrap();535 let value = if self.is_option {536 quote! {537 if let Some(value) = obj.get(#name.into())? {538 Some(<#ty as Typed>::from_untyped(value)?)539 } else {540 None541 }542 }543 } else {544 quote! {545 <#ty as Typed>::from_untyped(obj.get(#name.into())?.ok_or_else(|| ErrorKind::NoSuchField(#name.into(), vec![]))?)?546 }547 };548549 quote! {550 #ident: #value,551 }552 }553 fn expand_serialize(&self) -> Result<TokenStream> {554 let ident = &self.ident;555 let ty = &self.ty;556 Ok(if let Some(name) = self.name() {557 let hide = if self.attr.hide {558 quote! {.hide()}559 } else {560 quote! {}561 };562 let add = if self.attr.add {563 quote! {.add()}564 } else {565 quote! {}566 };567 if self.is_option {568 quote! {569 if let Some(value) = self.#ident {570 out.member(#name.into())571 #hide572 #add573 .value(<#ty as Typed>::into_untyped(value)?)?;574 }575 }576 } else {577 quote! {578 out.member(#name.into())579 #hide580 #add581 .value(<#ty as Typed>::into_untyped(self.#ident)?)?;582 }583 }584 } else if self.is_option {585 quote! {586 if let Some(value) = self.#ident {587 <#ty as TypedObj>::serialize(value, out)?;588 }589 }590 } else {591 quote! {592 <#ty as TypedObj>::serialize(self.#ident, out)?;593 }594 })595 }596}597598#[proc_macro_derive(Typed, attributes(typed))]599pub fn derive_typed(item: proc_macro::TokenStream) -> proc_macro::TokenStream {600 let input = parse_macro_input!(item as DeriveInput);601602 match derive_typed_inner(input) {603 Ok(v) => v.into(),604 Err(e) => e.to_compile_error().into(),605 }606}607608fn derive_typed_inner(input: DeriveInput) -> Result<TokenStream> {609 let syn::Data::Struct(data) = &input.data else {610 return Err(Error::new(input.span(), "only structs supported"));611 };612613 let ident = &input.ident;614 let fields = data615 .fields616 .iter()617 .map(TypedField::parse)618 .collect::<Result<Vec<_>>>()?;619620 let (impl_generics, ty_generics, where_clause) = input.generics.split_for_impl();621622 let typed = {623 let fields = fields624 .iter()625 .flat_map(TypedField::expand_field)626 .collect::<Vec<_>>();627 quote! {628 impl #impl_generics Typed for #ident #ty_generics #where_clause {629 const TYPE: &'static ComplexValType = &ComplexValType::ObjectRef(&[630 #(#fields,)*631 ]);632633 fn from_untyped(value: Val) -> JrResult<Self> {634 let obj = value.as_obj().expect("shape is correct");635 Self::parse(&obj)636 }637638 fn into_untyped(value: Self) -> JrResult<Val> {639 let mut out = ObjValueBuilder::new();640 value.serialize(&mut out)?;641 Ok(Val::Obj(out.build()))642 }643644 }645 }646 };647648 let fields_parse = fields.iter().map(TypedField::expand_parse);649 let fields_serialize = fields650 .iter()651 .map(TypedField::expand_serialize)652 .collect::<Result<Vec<_>>>()?;653654 Ok(quote! {655 const _: () = {656 use ::jrsonnet_evaluator::{657 typed::{ComplexValType, Typed, TypedObj, CheckType},658 Val, State,659 error::{ErrorKind, Result as JrResult},660 ObjValueBuilder, ObjValue,661 };662663 #typed664665 impl #impl_generics TypedObj for #ident #ty_generics #where_clause {666 fn serialize(self, out: &mut ObjValueBuilder) -> JrResult<()> {667 #(#fields_serialize)*668669 Ok(())670 }671 fn parse(obj: &ObjValue) -> JrResult<Self> {672 Ok(Self {673 #(#fields_parse)*674 })675 }676 }677 };678 })679}crates/jrsonnet-stdlib/src/arrays.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/arrays.rs
+++ b/crates/jrsonnet-stdlib/src/arrays.rs
@@ -1,19 +1,19 @@
#![allow(non_snake_case)]
use jrsonnet_evaluator::{
- error::{ErrorKind::RuntimeError, Result},
+ bail,
function::{builtin, FuncVal},
- throw,
+ runtime_error,
typed::{BoundedI32, BoundedUsize, Either2, NativeFn, Typed},
- val::{equals, ArrValue, IndexableVal, StrValue},
- Either, IStr, Thunk, Val,
+ val::{equals, ArrValue, IndexableVal},
+ Either, IStr, Result, Thunk, Val,
};
pub(crate) fn eval_on_empty(on_empty: Option<Thunk<Val>>) -> Result<Val> {
if let Some(on_empty) = on_empty {
on_empty.evaluate()
} else {
- throw!("expected non-empty array")
+ bail!("expected non-empty array")
}
}
@@ -39,7 +39,7 @@
Either2::A(s) => Val::Str(StrValue::Flat(s.repeat(count).into())),
Either2::B(arr) => Val::Arr(
ArrValue::repeated(arr, count)
- .ok_or_else(|| RuntimeError("repeated length overflow".into()))?,
+ .ok_or_else(|| runtime_error!("repeated length overflow"))?,
),
})
}
@@ -73,7 +73,7 @@
match func(Either2::A(c.to_string()))? {
Val::Str(o) => write!(out, "{o}").unwrap(),
Val::Null => continue,
- _ => throw!("in std.join all items should be strings"),
+ _ => bail!("in std.join all items should be strings"),
};
}
Ok(IndexableVal::Str(out.into()))
@@ -89,7 +89,7 @@
}
}
Val::Null => continue,
- _ => throw!("in std.join all items should be arrays"),
+ _ => bail!("in std.join all items should be arrays"),
};
}
Ok(IndexableVal::Arr(out.into()))
@@ -154,7 +154,7 @@
} else if matches!(item, Val::Null) {
continue;
} else {
- throw!("in std.join all items should be arrays");
+ bail!("in std.join all items should be arrays");
}
}
@@ -175,7 +175,7 @@
} else if matches!(item, Val::Null) {
continue;
} else {
- throw!("in std.join all items should be strings");
+ bail!("in std.join all items should be strings");
}
}
crates/jrsonnet-stdlib/src/compat.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/compat.rs
+++ b/crates/jrsonnet-stdlib/src/compat.rs
@@ -1,6 +1,6 @@
use std::cmp::Ordering;
-use jrsonnet_evaluator::{error::Result, function::builtin, operator::evaluate_compare_op, Val};
+use jrsonnet_evaluator::{function::builtin, operator::evaluate_compare_op, Result, Val};
#[builtin]
#[allow(non_snake_case)]
crates/jrsonnet-stdlib/src/encoding.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/encoding.rs
+++ b/crates/jrsonnet-stdlib/src/encoding.rs
@@ -1,9 +1,9 @@
use base64::{engine::general_purpose::STANDARD, Engine};
use jrsonnet_evaluator::{
- error::{ErrorKind::RuntimeError, Result},
function::builtin,
+ runtime_error,
typed::{Either, Either2},
- IBytes, IStr,
+ IBytes, IStr, Result,
};
#[builtin]
@@ -13,9 +13,7 @@
#[builtin]
pub fn builtin_decode_utf8(arr: IBytes) -> Result<IStr> {
- Ok(arr
- .cast_str()
- .ok_or_else(|| RuntimeError("bad utf8".into()))?)
+ arr.cast_str().ok_or_else(|| runtime_error!("bad utf8"))
}
#[builtin]
@@ -31,7 +29,7 @@
pub fn builtin_base64_decode_bytes(str: IStr) -> Result<IBytes> {
Ok(STANDARD
.decode(str.as_bytes())
- .map_err(|e| RuntimeError(format!("invalid base64: {e}").into()))?
+ .map_err(|e| runtime_error!("invalid base64: {e}"))?
.as_slice()
.into())
}
@@ -40,6 +38,6 @@
pub fn builtin_base64_decode(str: IStr) -> Result<String> {
let bytes = STANDARD
.decode(str.as_bytes())
- .map_err(|e| RuntimeError(format!("invalid base64: {e}").into()))?;
- Ok(String::from_utf8(bytes).map_err(|_| RuntimeError("bad utf8".into()))?)
+ .map_err(|e| runtime_error!("invalid base64: {e}"))?;
+ Ok(String::from_utf8(bytes).map_err(|_| runtime_error!("bad utf8"))?)
}
crates/jrsonnet-stdlib/src/manifest/mod.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/manifest/mod.rs
+++ b/crates/jrsonnet-stdlib/src/manifest/mod.rs
@@ -2,10 +2,9 @@
mod yaml;
use jrsonnet_evaluator::{
- error::Result,
function::builtin,
manifest::{escape_string_json, JsonFormat},
- IStr, ObjValue, Val,
+ IStr, ObjValue, Result, Val,
};
pub use toml::TomlFormat;
pub use yaml::YamlFormat;
crates/jrsonnet-stdlib/src/manifest/toml.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/manifest/toml.rs
+++ b/crates/jrsonnet-stdlib/src/manifest/toml.rs
@@ -1,8 +1,8 @@
use std::borrow::Cow;
use jrsonnet_evaluator::{
+ bail,
manifest::{escape_string_json_buf, ManifestFormat},
- throw,
val::ArrValue,
IStr, ObjValue, Result, Val,
};
@@ -157,10 +157,10 @@
buf.push_str(" }");
}
Val::Null => {
- throw!("tried to manifest null")
+ bail!("tried to manifest null")
}
Val::Func(_) => {
- throw!("tried to manifest function")
+ bail!("tried to manifest function")
}
}
Ok(())
@@ -290,7 +290,7 @@
Val::Obj(obj) => {
manifest_table_internal(&obj, &mut Vec::new(), buf, &mut String::new(), self)
}
- _ => throw!("toml body should be object"),
+ _ => bail!("toml body should be object"),
}
}
}
crates/jrsonnet-stdlib/src/manifest/yaml.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/manifest/yaml.rs
+++ b/crates/jrsonnet-stdlib/src/manifest/yaml.rs
@@ -1,8 +1,9 @@
use std::{borrow::Cow, fmt::Write};
use jrsonnet_evaluator::{
+ bail,
manifest::{escape_string_json_buf, ManifestFormat},
- throw, Result, Val,
+ Result, Val,
};
pub struct YamlFormat<'s> {
@@ -219,7 +220,7 @@
}
}
}
- Val::Func(_) => throw!("tried to manifest function"),
+ Val::Func(_) => bail!("tried to manifest function"),
}
Ok(())
}
crates/jrsonnet-stdlib/src/misc.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/misc.rs
+++ b/crates/jrsonnet-stdlib/src/misc.rs
@@ -1,10 +1,10 @@
use std::{cell::RefCell, rc::Rc};
use jrsonnet_evaluator::{
+ bail,
error::{ErrorKind::*, Result},
function::{builtin, ArgLike, CallLocation, FuncVal},
manifest::JsonFormat,
- throw,
typed::{Either2, Either4},
val::{equals, ArrValue},
Context, Either, IStr, ObjValue, Thunk, Val,
@@ -103,7 +103,7 @@
true
}
}
- _ => throw!("both arguments should be of the same type"),
+ _ => bail!("both arguments should be of the same type"),
})
}
@@ -129,6 +129,6 @@
true
}
}
- _ => throw!("both arguments should be of the same type"),
+ _ => bail!("both arguments should be of the same type"),
})
}
crates/jrsonnet-stdlib/src/operator.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/operator.rs
+++ b/crates/jrsonnet-stdlib/src/operator.rs
@@ -2,13 +2,12 @@
//! However, in our case we instead implement them in native, and implement native functions on top of core for backwards compatibility
use jrsonnet_evaluator::{
- error::Result,
function::builtin,
operator::evaluate_mod_op,
stdlib::std_format,
typed::{Either, Either2},
- val::{equals, primitive_equals, StrValue},
- IStr, Val,
+ val::{equals, primitive_equals},
+ IStr, Result, Val,
};
#[builtin]
crates/jrsonnet-stdlib/src/parse.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/parse.rs
+++ b/crates/jrsonnet-stdlib/src/parse.rs
@@ -1,14 +1,10 @@
-use jrsonnet_evaluator::{
- error::{ErrorKind::RuntimeError, Result},
- function::builtin,
- IStr, Val,
-};
+use jrsonnet_evaluator::{function::builtin, runtime_error, IStr, Result, Val};
use serde::Deserialize;
#[builtin]
pub fn builtin_parse_json(str: IStr) -> Result<Val> {
- let value: Val = serde_json::from_str(&str)
- .map_err(|e| RuntimeError(format!("failed to parse json: {e}").into()))?;
+ let value: Val =
+ serde_json::from_str(&str).map_err(|e| runtime_error!("failed to parse json: {e}"))?;
Ok(value)
}
@@ -21,8 +17,8 @@
);
let mut out = vec![];
for item in value {
- let val = Val::deserialize(item)
- .map_err(|e| RuntimeError(format!("failed to parse yaml: {e}").into()))?;
+ let val =
+ Val::deserialize(item).map_err(|e| runtime_error!("failed to parse yaml: {e}"))?;
out.push(val);
}
Ok(if out.is_empty() {
crates/jrsonnet-stdlib/src/sort.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/sort.rs
+++ b/crates/jrsonnet-stdlib/src/sort.rs
@@ -3,12 +3,11 @@
use std::cmp::Ordering;
use jrsonnet_evaluator::{
- error::Result,
+ bail,
function::{builtin, FuncVal},
operator::evaluate_compare_op,
- throw,
val::{equals, ArrValue},
- Thunk, Val,
+ Result, Thunk, Val,
};
use jrsonnet_parser::BinaryOpType;
@@ -44,7 +43,7 @@
(Val::Num(_), SortKeyType::Unknown) => sort_type = SortKeyType::Number,
(Val::Str(_), SortKeyType::String) | (Val::Num(_), SortKeyType::Number) => {}
(Val::Str(_) | Val::Num(_), _) => {
- throw!("sort elements should have the same types")
+ bail!("sort elements should have the same types")
}
_ => {}
}
crates/jrsonnet-stdlib/src/strings.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/strings.rs
+++ b/crates/jrsonnet-stdlib/src/strings.rs
@@ -1,7 +1,7 @@
use jrsonnet_evaluator::{
+ bail,
error::{ErrorKind::*, Result},
function::builtin,
- throw,
typed::{Either2, M1},
val::{ArrValue, StrValue},
Either, IStr, Val,
@@ -91,13 +91,13 @@
pub fn builtin_parse_int(str: IStr) -> Result<f64> {
if let Some(raw) = str.strip_prefix('-') {
if raw.is_empty() {
- throw!("integer only consists of a minus")
+ bail!("integer only consists of a minus")
}
parse_nat::<10>(raw).map(|value| -value)
} else {
if str.is_empty() {
- throw!("empty integer")
+ bail!("empty integer")
}
parse_nat::<10>(str.as_str())
@@ -107,7 +107,7 @@
#[builtin]
pub fn builtin_parse_octal(str: IStr) -> Result<f64> {
if str.is_empty() {
- throw!("empty octal integer");
+ bail!("empty octal integer");
}
parse_nat::<8>(str.as_str())
@@ -116,7 +116,7 @@
#[builtin]
pub fn builtin_parse_hex(str: IStr) -> Result<f64> {
if str.is_empty() {
- throw!("empty hexadecimal integer");
+ bail!("empty hexadecimal integer");
}
parse_nat::<16>(str.as_str())
@@ -156,7 +156,7 @@
if digit < BASE {
Ok(base * aggregate + digit as f64)
} else {
- throw!("{raw:?} is not a base {BASE} integer",);
+ bail!("{raw:?} is not a base {BASE} integer");
}
})
}
@@ -164,13 +164,14 @@
#[cfg(feature = "exp-bigint")]
#[builtin]
pub fn builtin_bigint(v: Either![f64, IStr]) -> Result<Val> {
+ use jrsonnet_evaluator::runtime_error;
use Either2::*;
Ok(match v {
A(a) => Val::BigInt(Box::new((a as i64).into())),
B(b) => Val::BigInt(Box::new(
b.as_str()
.parse()
- .map_err(|e| RuntimeError(format!("bad bigint: {e}").into()))?,
+ .map_err(|e| runtime_error!("bad bigint: {e}"))?,
)),
})
}
tests/tests/as_native.rsdiffbeforeafterboth--- a/tests/tests/as_native.rs
+++ b/tests/tests/as_native.rs
@@ -1,4 +1,4 @@
-use jrsonnet_evaluator::{error::Result, State};
+use jrsonnet_evaluator::{Result, State};
use jrsonnet_stdlib::StateExt;
mod common;
tests/tests/builtin.rsdiffbeforeafterboth--- a/tests/tests/builtin.rs
+++ b/tests/tests/builtin.rs
@@ -1,10 +1,9 @@
mod common;
use jrsonnet_evaluator::{
- error::Result,
function::{builtin, builtin::Builtin, CallLocation, FuncVal},
typed::Typed,
- ContextBuilder, State, Thunk, Val,
+ ContextBuilder, Result, State, Thunk, Val,
};
use jrsonnet_stdlib::StateExt;
tests/tests/common.rsdiffbeforeafterboth--- a/tests/tests/common.rs
+++ b/tests/tests/common.rs
@@ -1,7 +1,7 @@
use jrsonnet_evaluator::{
- error::Result,
+ bail,
function::{builtin, FuncVal},
- throw, ObjValueBuilder, State, Thunk, Val,
+ ObjValueBuilder, Result, State, Thunk, Val,
};
#[macro_export]
@@ -10,7 +10,7 @@
let a = &$a;
let b = &$b;
if a != b {
- ::jrsonnet_evaluator::throw!("assertion failed: a != b\na={:#?}\nb={:#?}", a, b)
+ ::jrsonnet_evaluator::bail!("assertion failed: a != b\na={a:#?}\nb={b:#?}")
}
}};
}
@@ -19,7 +19,7 @@
macro_rules! ensure {
($v:expr $(,)?) => {
if !$v {
- ::jrsonnet_evaluator::throw!("assertion failed: {}", stringify!($v))
+ ::jrsonnet_evaluator::bail!("assertion failed: {}", stringify!($v))
}
};
}
@@ -29,7 +29,7 @@
($a:expr, $b:expr) => {{
if !::jrsonnet_evaluator::val::equals(&$a.clone(), &$b.clone())? {
use ::jrsonnet_evaluator::manifest::JsonFormat;
- ::jrsonnet_evaluator::throw!(
+ ::jrsonnet_evaluator::bail!(
"assertion failed: a != b\na={:#?}\nb={:#?}",
$a.manifest(JsonFormat::default())?,
$b.manifest(JsonFormat::default())?,
@@ -42,7 +42,7 @@
fn assert_throw(lazy: Thunk<Val>, message: String) -> Result<bool> {
match lazy.evaluate() {
Ok(_) => {
- throw!("expected argument to throw on evaluation, but it returned instead")
+ bail!("expected argument to throw on evaluation, but it returned instead")
}
Err(e) => {
let error = format!("{}", e.error());
tests/tests/sanity.rsdiffbeforeafterboth--- a/tests/tests/sanity.rs
+++ b/tests/tests/sanity.rs
@@ -1,8 +1,7 @@
use jrsonnet_evaluator::{
- error::Result,
- throw,
+ bail,
trace::{CompactFormat, TraceFormat},
- State, Val,
+ Result, State, Val,
};
use jrsonnet_stdlib::StateExt;
@@ -29,14 +28,14 @@
{
let Err(e) = s.evaluate_snippet("snip".to_owned(), "assert 1 == 2: 'fail'; null") else {
- throw!("assertion should fail");
+ bail!("assertion should fail");
};
let e = trace_format.format(&e).unwrap();
ensure!(e.starts_with("assert failed: fail\n"));
}
{
let Err(e) = s.evaluate_snippet("snip".to_owned(), "std.assertEqual(1, 2)") else {
- throw!("assertion should fail")
+ bail!("assertion should fail")
};
let e = trace_format.format(&e).unwrap();
ensure!(e.starts_with("runtime error: Assertion failed. 1 != 2"))
tests/tests/typed_obj.rsdiffbeforeafterboth--- a/tests/tests/typed_obj.rs
+++ b/tests/tests/typed_obj.rs
@@ -2,7 +2,7 @@
use std::fmt::Debug;
-use jrsonnet_evaluator::{error::Result, typed::Typed, State};
+use jrsonnet_evaluator::{typed::Typed, Result, State};
use jrsonnet_stdlib::StateExt;
#[derive(Clone, Typed, PartialEq, Debug)]