difftreelog
refactor error helpers
in: master
38 files changed
bindings/jsonnet/src/import.rsdiffbeforeafterboth--- a/bindings/jsonnet/src/import.rs
+++ b/bindings/jsonnet/src/import.rs
@@ -13,8 +13,9 @@
};
use jrsonnet_evaluator::{
+ bail,
error::{ErrorKind::*, Result},
- throw, FileImportResolver, ImportResolver,
+ FileImportResolver, ImportResolver,
};
use jrsonnet_gcmodule::Trace;
use jrsonnet_parser::{SourceDirectory, SourceFile, SourcePath};
@@ -80,7 +81,7 @@
assert!(success == 0 || success == 1);
if success == 0 {
let result = String::from_utf8(buf_intern).expect("error should be valid string");
- throw!(ImportCallbackError(result));
+ bail!(ImportCallbackError(result));
}
let found_here_raw = unsafe { CStr::from_ptr(found_here) };
bindings/jsonnet/src/lib.rsdiffbeforeafterboth--- a/bindings/jsonnet/src/lib.rs
+++ b/bindings/jsonnet/src/lib.rs
@@ -19,12 +19,12 @@
};
use jrsonnet_evaluator::{
- apply_tla,
+ apply_tla, bail,
function::TlaArg,
gc::GcHashMap,
manifest::{JsonFormat, ManifestFormat, ToStringFormat},
stack::set_stack_depth_limit,
- tb, throw,
+ tb,
trace::{CompactFormat, PathResolver, TraceFormat},
FileImportResolver, IStr, Result, State, Val,
};
@@ -249,7 +249,7 @@
fn val_to_multi(val: Val, format: &dyn ManifestFormat) -> Result<Vec<(IStr, IStr)>> {
let Val::Obj(val) = val else {
- throw!("expected object as multi output")
+ bail!("expected object as multi output")
};
let mut out = Vec::new();
for (k, v) in val.iter(
@@ -336,7 +336,7 @@
fn val_to_stream(val: Val, format: &dyn ManifestFormat) -> Result<Vec<IStr>> {
let Val::Arr(val) = val else {
- throw!("expected array as stream output")
+ bail!("expected array as stream output")
};
let mut out = Vec::new();
for item in val.iter() {
cmds/jrsonnet/src/main.rsdiffbeforeafterboth--- a/cmds/jrsonnet/src/main.rs
+++ b/cmds/jrsonnet/src/main.rs
@@ -7,9 +7,9 @@
use clap_complete::Shell;
use jrsonnet_cli::{GcOpts, ManifestOpts, MiscOpts, OutputOpts, StdOpts, TlaOpts, TraceOpts};
use jrsonnet_evaluator::{
- apply_tla,
+ apply_tla, bail,
error::{Error as JrError, ErrorKind},
- throw, ResultExt, State, Val,
+ ResultExt, State, Val,
};
#[cfg(feature = "mimalloc")]
@@ -208,7 +208,7 @@
create_dir_all(dir)?;
}
let Val::Obj(obj) = val else {
- throw!(
+ bail!(
"value should be object for --multi manifest, got {}",
val.value_type()
)
crates/jrsonnet-evaluator/src/ctx.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/ctx.rs
+++ b/crates/jrsonnet-evaluator/src/ctx.rs
@@ -54,7 +54,7 @@
pub fn binding(&self, name: IStr) -> Result<Thunk<Val>> {
use std::cmp::Ordering;
- use crate::throw;
+ use crate::bail;
if let Some(val) = self.0.bindings.get(&name).cloned() {
return Ok(val);
@@ -70,7 +70,7 @@
});
heap.sort_by(|a, b| b.0.partial_cmp(&a.0).unwrap_or(Ordering::Equal));
- throw!(VariableIsNotDefined(
+ bail!(VariableIsNotDefined(
name,
heap.into_iter().map(|(_, k)| k).collect()
))
crates/jrsonnet-evaluator/src/dynamic.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/dynamic.rs
+++ b/crates/jrsonnet-evaluator/src/dynamic.rs
@@ -2,7 +2,7 @@
use jrsonnet_gcmodule::{Cc, Trace};
-use crate::{error::ErrorKind::InfiniteRecursionDetected, throw, val::ThunkValue, Result, Thunk};
+use crate::{bail, error::ErrorKind::InfiniteRecursionDetected, val::ThunkValue, Result};
// TODO: Replace with OnceCell once in std
#[derive(Clone, Trace)]
@@ -41,7 +41,7 @@
fn get(self: Box<Self>) -> Result<Self::Output> {
let Some(value) = self.0.get() else {
- throw!(InfiniteRecursionDetected);
+ bail!(InfiniteRecursionDetected);
};
Ok(value.clone())
}
crates/jrsonnet-evaluator/src/error.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/error.rs
+++ b/crates/jrsonnet-evaluator/src/error.rs
@@ -370,17 +370,21 @@
}
#[macro_export]
-macro_rules! throw {
+macro_rules! bail {
($w:ident$(::$i:ident)*$(($($tt:tt)*))?) => {
return Err($w$(::$i)*$(($($tt)*))?.into())
};
($w:ident$(::$i:ident)*$({$($tt:tt)*})?) => {
return Err($w$(::$i)*$({$($tt)*})?.into())
};
- ($l:literal) => {
- return Err($crate::error::ErrorKind::RuntimeError($l.into()).into())
+ ($l:literal$(, $($tt:tt)*)?) => {
+ return Err($crate::error::ErrorKind::RuntimeError(format!($l$(, $($tt)*)?).into()).into())
};
- ($l:literal, $($tt:tt)*) => {
- return Err($crate::error::ErrorKind::RuntimeError(format!($l, $($tt)*).into()).into())
+}
+
+#[macro_export]
+macro_rules! runtime_error {
+ ($l:literal$(, $($tt:tt)*)?) => {
+ $crate::error::Error::from($crate::error::ErrorKind::RuntimeError(format!($l$(, $($tt)*)?).into()))
};
}
crates/jrsonnet-evaluator/src/evaluate/destructure.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/evaluate/destructure.rs
+++ b/crates/jrsonnet-evaluator/src/evaluate/destructure.rs
@@ -3,10 +3,10 @@
use jrsonnet_parser::{BindSpec, Destruct, LocExpr, ParamsDesc};
use crate::{
+ bail,
error::{ErrorKind::*, Result},
evaluate, evaluate_method, evaluate_named,
gc::GcHashMap,
- throw,
val::ThunkValue,
Context, Pending, Thunk, Val,
};
@@ -23,7 +23,7 @@
Destruct::Full(v) => {
let old = new_bindings.insert(v.clone(), parent);
if old.is_some() {
- throw!(DuplicateLocalVar(v.clone()))
+ bail!(DuplicateLocalVar(v.clone()))
}
}
#[cfg(feature = "exp-destruct")]
@@ -46,14 +46,14 @@
fn get(self: Box<Self>) -> Result<Self::Output> {
let v = self.parent.evaluate()?;
let Val::Arr(arr) = v else {
- throw!("expected array");
+ bail!("expected array");
};
if !self.has_rest {
if arr.len() != self.min_len {
- throw!("expected {} elements, got {}", self.min_len, arr.len())
+ bail!("expected {} elements, got {}", self.min_len, arr.len())
}
} else if arr.len() < self.min_len {
- throw!(
+ bail!(
"expected at least {} elements, but array was only {}",
self.min_len,
arr.len()
@@ -178,17 +178,17 @@
fn get(self: Box<Self>) -> Result<Self::Output> {
let v = self.parent.evaluate()?;
let Val::Obj(obj) = v else {
- throw!("expected object");
+ bail!("expected object");
};
for field in &self.field_names {
if !obj.has_field_ex(field.clone(), true) {
- throw!("missing field: {}", field);
+ bail!("missing field: {field}");
}
}
if !self.has_rest {
let len = obj.len();
if len != self.field_names.len() {
- throw!("too many fields, and rest not found");
+ bail!("too many fields, and rest not found");
}
}
Ok(obj)
@@ -310,7 +310,7 @@
}),
);
if old.is_some() {
- throw!(DuplicateLocalVar(name.clone()))
+ bail!(DuplicateLocalVar(name.clone()))
}
}
}
crates/jrsonnet-evaluator/src/evaluate/mod.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/evaluate/mod.rs
+++ b/crates/jrsonnet-evaluator/src/evaluate/mod.rs
@@ -11,11 +11,11 @@
use self::destructure::destruct;
use crate::{
arr::ArrValue,
+ bail,
destructure::evaluate_dest,
error::{suggest_object_fields, ErrorKind::*},
evaluate::operator::{evaluate_add_op, evaluate_binary_op_special, evaluate_unary_op},
function::{CallLocation, FuncDesc, FuncVal},
- throw,
typed::Typed,
val::{CachedUnbound, IndexableVal, StrValue, Thunk, ThunkValue},
Context, GcHashMap, ObjValue, ObjValueBuilder, ObjectAssertion, Pending, Result, ResultExt,
@@ -150,7 +150,7 @@
evaluate_comp(ctx, &specs[1..], callback)?;
}
}
- _ => throw!(InComprehensionCanOnlyIterateOverArray),
+ _ => bail!(InComprehensionCanOnlyIterateOverArray),
},
}
Ok(())
@@ -375,7 +375,7 @@
State::push(loc, || format!("function <{}> call", f.name()), body)?
}
}
- v => throw!(OnlyFunctionsCanBeCalledGot(v.value_type())),
+ v => bail!(OnlyFunctionsCanBeCalledGot(v.value_type())),
})
}
@@ -393,9 +393,9 @@
|| "assertion failure".to_owned(),
|| {
if let Some(msg) = msg {
- throw!(AssertionFailed(evaluate(ctx, msg)?.to_string()?));
+ bail!(AssertionFailed(evaluate(ctx, msg)?.to_string()?));
}
- throw!(AssertionFailed(Val::Null.to_string()?));
+ bail!(AssertionFailed(Val::Null.to_string()?));
},
)?;
}
@@ -457,12 +457,12 @@
if part.null_coaelse {
return Ok(Val::Null);
}
- throw!(NoSuperFound)
+ bail!(NoSuperFound)
};
let name = evaluate(ctx.clone(), &part.value)?;
let Val::Str(name) = name else {
- throw!(ValueIndexMustBeTypeGot(
+ bail!(ValueIndexMustBeTypeGot(
ValType::Obj,
ValType::Str,
name.value_type(),
@@ -483,7 +483,7 @@
None => {
let suggestions = suggest_object_fields(super_obj, name.clone());
- throw!(NoSuchField(name, suggestions))
+ bail!(NoSuchField(name, suggestions))
}
}
}
@@ -502,25 +502,25 @@
None => {
let suggestions = suggest_object_fields(&v, key.clone().into_flat());
- throw!(NoSuchField(key.clone().into_flat(), suggestions))
+ bail!(NoSuchField(key.clone().into_flat(), suggestions))
}
},
- (Val::Obj(_), n) => throw!(ValueIndexMustBeTypeGot(
+ (Val::Obj(_), n) => bail!(ValueIndexMustBeTypeGot(
ValType::Obj,
ValType::Str,
n.value_type(),
)),
(Val::Arr(v), Val::Num(n)) => {
if n.fract() > f64::EPSILON {
- throw!(FractionalIndex)
+ bail!(FractionalIndex)
}
v.get(n as usize)?
.ok_or_else(|| ArrayBoundsError(n as usize, v.len()))?
}
(Val::Arr(_), Val::Str(n)) => {
- throw!(AttemptedIndexAnArrayWithString(n.into_flat()))
+ bail!(AttemptedIndexAnArrayWithString(n.into_flat()))
}
- (Val::Arr(_), n) => throw!(ValueIndexMustBeTypeGot(
+ (Val::Arr(_), n) => bail!(ValueIndexMustBeTypeGot(
ValType::Arr,
ValType::Num,
n.value_type(),
@@ -537,18 +537,18 @@
.into();
if v.is_empty() {
let size = s.into_flat().chars().count();
- throw!(StringBoundsError(n as usize, size))
+ bail!(StringBoundsError(n as usize, size))
}
StrValue::Flat(v)
}),
- (Val::Str(_), n) => throw!(ValueIndexMustBeTypeGot(
+ (Val::Str(_), n) => bail!(ValueIndexMustBeTypeGot(
ValType::Str,
ValType::Num,
n.value_type(),
)),
#[cfg(feature = "exp-null-coaelse")]
(Val::Null, _) if part.null_coaelse => return Ok(Val::Null),
- (v, _) => throw!(CantIndexInto(v.value_type())),
+ (v, _) => bail!(CantIndexInto(v.value_type())),
};
}
indexable
@@ -612,7 +612,7 @@
ErrorStmt(e) => State::push(
CallLocation::new(loc),
|| "error statement".to_owned(),
- || throw!(RuntimeError(evaluate(ctx, e)?.to_string()?,)),
+ || bail!(RuntimeError(evaluate(ctx, e)?.to_string()?,)),
)?,
IfElse {
cond,
@@ -661,7 +661,7 @@
}
i @ (Import(path) | ImportStr(path) | ImportBin(path)) => {
let Expr::Str(path) = &*path.0 else {
- throw!("computed imports are not supported")
+ bail!("computed imports are not supported")
};
let tmp = loc.clone().0;
let s = ctx.state();
crates/jrsonnet-evaluator/src/evaluate/operator.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/evaluate/operator.rs
+++ b/crates/jrsonnet-evaluator/src/evaluate/operator.rs
@@ -4,10 +4,10 @@
use crate::{
arr::ArrValue,
+ bail,
error::ErrorKind::*,
evaluate,
stdlib::std_format,
- throw,
typed::Typed,
val::{equals, StrValue},
Context, Result, Val,
@@ -21,7 +21,7 @@
(Minus, Num(n)) => Num(-*n),
(Not, Bool(v)) => Bool(!v),
(BitNot, Num(n)) => Num(!(*n as i64) as f64),
- (op, o) => throw!(UnaryOperatorDoesNotOperateOnType(op, o.value_type())),
+ (op, o) => bail!(UnaryOperatorDoesNotOperateOnType(op, o.value_type())),
})
}
@@ -49,7 +49,7 @@
(Num(v1), Num(v2)) => Val::new_checked_num(v1 + v2)?,
#[cfg(feature = "exp-bigint")]
(BigInt(a), BigInt(b)) => BigInt(Box::new((&**a).clone() + (&**b).clone())),
- _ => throw!(BinaryOperatorDoesNotOperateOnValues(
+ _ => bail!(BinaryOperatorDoesNotOperateOnValues(
BinaryOpType::Add,
a.value_type(),
b.value_type(),
@@ -62,14 +62,14 @@
match (a, b) {
(Num(a), Num(b)) => {
if *b == 0.0 {
- throw!(DivisionByZero)
+ bail!(DivisionByZero)
}
Ok(Num(a % b))
}
(Str(str), vals) => {
String::into_untyped(std_format(&str.clone().into_flat(), vals.clone())?)
}
- (a, b) => throw!(BinaryOperatorDoesNotOperateOnValues(
+ (a, b) => bail!(BinaryOperatorDoesNotOperateOnValues(
BinaryOpType::Mod,
a.value_type(),
b.value_type()
@@ -124,7 +124,7 @@
}
a.len().cmp(&b.len())
}
- (_, _) => throw!(BinaryOperatorDoesNotOperateOnValues(
+ (_, _) => bail!(BinaryOperatorDoesNotOperateOnValues(
op,
a.value_type(),
b.value_type()
@@ -159,7 +159,7 @@
(Num(v1), Mul, Num(v2)) => Val::new_checked_num(v1 * v2)?,
(Num(v1), Div, Num(v2)) => {
if *v2 == 0.0 {
- throw!(DivisionByZero)
+ bail!(DivisionByZero)
}
Val::new_checked_num(v1 / v2)?
}
@@ -171,14 +171,14 @@
(Num(v1), BitXor, Num(v2)) => Num((*v1 as i64 ^ *v2 as i64) as f64),
(Num(v1), Lhs, Num(v2)) => {
if *v2 < 0.0 {
- throw!("shift by negative exponent")
+ bail!("shift by negative exponent")
}
let exp = ((*v2 as i64) & 63) as u32;
Num((*v1 as i64).wrapping_shl(exp) as f64)
}
(Num(v1), Rhs, Num(v2)) => {
if *v2 < 0.0 {
- throw!("shift by negative exponent")
+ bail!("shift by negative exponent")
}
let exp = ((*v2 as i64) & 63) as u32;
Num((*v1 as i64).wrapping_shr(exp) as f64)
@@ -190,7 +190,7 @@
#[cfg(feature = "exp-bigint")]
(BigInt(a), Sub, BigInt(b)) => BigInt(Box::new((&**a).clone() - (&**b).clone())),
- _ => throw!(BinaryOperatorDoesNotOperateOnValues(
+ _ => bail!(BinaryOperatorDoesNotOperateOnValues(
op,
a.value_type(),
b.value_type(),
crates/jrsonnet-evaluator/src/function/arglike.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/function/arglike.rs
+++ b/crates/jrsonnet-evaluator/src/function/arglike.rs
@@ -3,14 +3,7 @@
use jrsonnet_interner::IStr;
use jrsonnet_parser::{ArgsDesc, LocExpr};
-use crate::{
- error::Result,
- evaluate,
- gc::GcHashMap,
- typed::Typed,
- val::{StrValue, ThunkValue},
- Context, Thunk, Val,
-};
+use crate::{evaluate, gc::GcHashMap, typed::Typed, val::ThunkValue, Context, Result, Thunk, Val};
/// Marker for arguments, which can be evaluated with context set to None
pub trait OptionalContext {}
crates/jrsonnet-evaluator/src/function/builtin.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/function/builtin.rs
+++ b/crates/jrsonnet-evaluator/src/function/builtin.rs
@@ -4,7 +4,7 @@
use jrsonnet_interner::IStr;
use super::{arglike::ArgsLike, parse::parse_builtin_call, CallLocation};
-use crate::{error::Result, gc::TraceBox, tb, Context, Val};
+use crate::{gc::TraceBox, tb, Context, Result, Val};
/// Can't have str | IStr, because constant BuiltinParam causes
/// E0492: constant functions cannot refer to interior mutable data
crates/jrsonnet-evaluator/src/function/parse.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/function/parse.rs
+++ b/crates/jrsonnet-evaluator/src/function/parse.rs
@@ -6,11 +6,11 @@
use super::{arglike::ArgsLike, builtin::BuiltinParam};
use crate::{
+ bail,
destructure::destruct,
error::{ErrorKind::*, Result},
evaluate_named,
gc::GcHashMap,
- throw,
val::ThunkValue,
Context, Pending, Thunk, Val,
};
@@ -47,7 +47,7 @@
let mut passed_args =
GcHashMap::with_capacity(params.iter().map(|p| p.0.capacity_hint()).sum());
if args.unnamed_len() > params.len() {
- throw!(TooManyArgsFunctionHas(
+ bail!(TooManyArgsFunctionHas(
params.len(),
params.iter().map(|p| (p.0.name(), p.1.is_some())).collect()
))
@@ -71,10 +71,10 @@
args.named_iter(ctx, tailstrict, &mut |name, value| {
// FIXME: O(n) for arg existence check
if !params.iter().any(|p| p.0.name().as_ref() == Some(name)) {
- throw!(UnknownFunctionParameter((name as &str).to_owned()));
+ bail!(UnknownFunctionParameter((name as &str).to_owned()));
}
if passed_args.insert(name.clone(), value).is_some() {
- throw!(BindingParameterASecondTime(name.clone()));
+ bail!(BindingParameterASecondTime(name.clone()));
}
filled_named += 1;
Ok(())
@@ -125,7 +125,7 @@
}
});
if !found {
- throw!(FunctionParameterNotBoundInCall(
+ bail!(FunctionParameterNotBoundInCall(
param.0.clone().name(),
params.iter().map(|p| (p.0.name(), p.1.is_some())).collect()
));
@@ -159,7 +159,7 @@
) -> Result<Vec<Option<Thunk<Val>>>> {
let mut passed_args: Vec<Option<Thunk<Val>>> = vec![None; params.len()];
if args.unnamed_len() > params.len() {
- throw!(TooManyArgsFunctionHas(
+ bail!(TooManyArgsFunctionHas(
params.len(),
params
.iter()
@@ -183,7 +183,7 @@
.position(|p| p.name() == name)
.ok_or_else(|| UnknownFunctionParameter((name as &str).to_owned()))?;
if replace(&mut passed_args[id], Some(arg)).is_some() {
- throw!(BindingParameterASecondTime(name.clone()));
+ bail!(BindingParameterASecondTime(name.clone()));
}
filled_args += 1;
Ok(())
@@ -207,7 +207,7 @@
}
});
if !found {
- throw!(FunctionParameterNotBoundInCall(
+ bail!(FunctionParameterNotBoundInCall(
param.name().as_str().map(IStr::from),
params
.iter()
crates/jrsonnet-evaluator/src/import.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/import.rs
+++ b/crates/jrsonnet-evaluator/src/import.rs
@@ -12,8 +12,8 @@
use jrsonnet_parser::{SourceDirectory, SourceFile, SourcePath};
use crate::{
+ bail,
error::{ErrorKind::*, Result},
- throw,
};
/// Implements file resolution logic for `import` and `importStr`
@@ -25,14 +25,14 @@
/// `from` should only be returned from [`ImportResolver::resolve`], or from other defined file, any other value
/// may result in panic
fn resolve_from(&self, from: &SourcePath, path: &str) -> Result<SourcePath> {
- throw!(ImportNotSupported(from.clone(), path.into()))
+ bail!(ImportNotSupported(from.clone(), path.into()))
}
fn resolve_from_default(&self, path: &str) -> Result<SourcePath> {
self.resolve_from(&SourcePath::default(), path)
}
/// Resolves absolute path, doesn't supports jpath and other fancy things
fn resolve(&self, path: &Path) -> Result<SourcePath> {
- throw!(AbsoluteImportNotSupported(path.to_owned()))
+ bail!(AbsoluteImportNotSupported(path.to_owned()))
}
/// Load resolved file
@@ -110,16 +110,16 @@
)));
}
}
- throw!(ImportFileNotFound(from.clone(), path.to_owned()))
+ bail!(ImportFileNotFound(from.clone(), path.to_owned()))
}
}
fn resolve(&self, path: &Path) -> Result<SourcePath> {
let meta = match fs::metadata(path) {
Ok(v) => v,
Err(e) if e.kind() == ErrorKind::NotFound => {
- throw!(AbsoluteImportFileNotFound(path.to_owned()))
+ bail!(AbsoluteImportFileNotFound(path.to_owned()))
}
- Err(e) => throw!(ImportIo(e.to_string())),
+ Err(e) => bail!(ImportIo(e.to_string())),
};
if meta.is_file() {
Ok(SourcePath::new(SourceFile::new(
@@ -138,7 +138,7 @@
let path = if let Some(f) = id.downcast_ref::<SourceFile>() {
f.path()
} else if id.downcast_ref::<SourceDirectory>().is_some() || id.is_default() {
- throw!(ImportIsADirectory(id.clone()))
+ bail!(ImportIsADirectory(id.clone()))
} else {
unreachable!("other types are not supported in resolve");
};
crates/jrsonnet-evaluator/src/integrations/serde.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/integrations/serde.rs
+++ b/crates/jrsonnet-evaluator/src/integrations/serde.rs
@@ -620,6 +620,6 @@
where
T: std::fmt::Display,
{
- JrError::new(ErrorKind::RuntimeError(format!("serde: {msg}").into()))
+ runtime_error!("serde: {msg}")
}
}
crates/jrsonnet-evaluator/src/lib.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/lib.rs
+++ b/crates/jrsonnet-evaluator/src/lib.rs
@@ -354,7 +354,7 @@
}
let parsed = file.parsed.as_ref().expect("just set").clone();
if file.evaluating {
- throw!(InfiniteRecursionDetected)
+ bail!(InfiniteRecursionDetected)
}
file.evaluating = true;
// Dropping file cache guard here, as evaluation may use this map too
crates/jrsonnet-evaluator/src/manifest.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/manifest.rs
+++ b/crates/jrsonnet-evaluator/src/manifest.rs
@@ -1,9 +1,6 @@
use std::{borrow::Cow, fmt::Write};
-use crate::{
- error::{ErrorKind::*, Result},
- throw, State, Val,
-};
+use crate::{bail, Result, State, Val};
pub trait ManifestFormat {
fn manifest_buf(&self, val: Val, buf: &mut String) -> Result<()>;
@@ -268,7 +265,7 @@
}
buf.push('}');
}
- Val::Func(_) => throw!(RuntimeError("tried to manifest function".into())),
+ Val::Func(_) => bail!("tried to manifest function"),
};
Ok(())
}
@@ -292,7 +289,7 @@
impl ManifestFormat for StringFormat {
fn manifest_buf(&self, val: Val, out: &mut String) -> Result<()> {
let Val::Str(s) = val else {
- throw!(
+ bail!(
"output should be string for string manifest format, got {}",
val.value_type()
)
@@ -309,7 +306,7 @@
impl<I: ManifestFormat> ManifestFormat for YamlStreamFormat<I> {
fn manifest_buf(&self, val: Val, out: &mut String) -> Result<()> {
let Val::Arr(arr) = val else {
- throw!(
+ bail!(
"output should be array for yaml stream format, got {}",
val.value_type()
)
crates/jrsonnet-evaluator/src/obj.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/obj.rs
+++ b/crates/jrsonnet-evaluator/src/obj.rs
@@ -13,11 +13,12 @@
use crate::{
arr::{PickObjectKeyValues, PickObjectValues},
+ bail,
error::{suggest_object_fields, Error, ErrorKind::*},
function::CallLocation,
gc::{GcHashMap, GcHashSet, TraceBox},
operator::evaluate_add_op,
- tb, throw,
+ tb,
val::{ArrValue, ThunkValue},
MaybeUnbound, Result, State, Thunk, Unbound, Val,
};
@@ -404,7 +405,7 @@
pub fn get_or_bail(&self, key: IStr) -> Result<Val> {
let Some(value) = self.get(key.clone())? else {
let suggestions = suggest_object_fields(self, key.clone());
- throw!(NoSuchField(key, suggestions))
+ bail!(NoSuchField(key, suggestions))
};
Ok(value)
}
@@ -723,7 +724,7 @@
return Ok(match v {
CacheValue::Cached(v) => Some(v.clone()),
CacheValue::NotFound => None,
- CacheValue::Pending => throw!(InfiniteRecursionDetected),
+ CacheValue::Pending => bail!(InfiniteRecursionDetected),
CacheValue::Errored(e) => return Err(e.clone()),
});
}
@@ -953,7 +954,7 @@
State::push(
CallLocation(location.as_ref()),
|| format!("field <{}> initializtion", name.clone()),
- || throw!(DuplicateFieldName(name.clone())),
+ || bail!(DuplicateFieldName(name.clone())),
)?;
}
Ok(())
crates/jrsonnet-evaluator/src/stdlib/format.rsdiffbeforeafterboth1//! faster std.format impl2#![allow(clippy::too_many_arguments)]34use jrsonnet_gcmodule::Trace;5use jrsonnet_interner::IStr;6use jrsonnet_types::ValType;7use thiserror::Error;89use crate::{10 error::{format_found, suggest_object_fields, ErrorKind::*},11 throw,12 typed::Typed,13 Error, ObjValue, Result, Val,14};1516#[derive(Debug, Clone, Error, Trace)]17pub enum FormatError {18 #[error("truncated format code")]19 TruncatedFormatCode,20 #[error("unrecognized conversion type: {0}")]21 UnrecognizedConversionType(char),2223 #[error("not enough values")]24 NotEnoughValues,2526 #[error("cannot use * width with object")]27 CannotUseStarWidthWithObject,28 #[error("mapping keys required")]29 MappingKeysRequired,30 #[error("no such format field: {0}")]31 NoSuchFormatField(IStr),3233 #[error("expected subfield <{0}> to be an object, got {1} instead")]34 SubfieldDidntYieldAnObject(IStr, ValType),35 #[error("subfield not found: <[{full}]{current}>{}", format_found(.found, "subfield"))]36 SubfieldNotFound {37 current: IStr,38 full: IStr,39 found: Box<Vec<IStr>>,40 },41}4243impl From<FormatError> for Error {44 fn from(e: FormatError) -> Self {45 Self::new(Format(e))46 }47}4849use FormatError::*;5051type ParseResult<'t, T> = std::result::Result<(T, &'t str), FormatError>;5253pub fn try_parse_mapping_key(str: &str) -> ParseResult<'_, &str> {54 if str.is_empty() {55 return Err(TruncatedFormatCode);56 }57 let bytes = str.as_bytes();58 if bytes[0] == b'(' {59 let mut i = 1;60 while i < bytes.len() {61 if bytes[i] == b')' {62 return Ok((&str[1..i], &str[i + 1..]));63 }64 i += 1;65 }66 Err(TruncatedFormatCode)67 } else {68 Ok(("", str))69 }70}7172#[cfg(test)]73pub mod tests_key {74 use super::*;7576 #[test]77 fn parse_key() {78 assert_eq!(79 try_parse_mapping_key("(hello ) world").unwrap(),80 ("hello ", " world")81 );82 assert_eq!(try_parse_mapping_key("() world").unwrap(), ("", " world"));83 assert_eq!(try_parse_mapping_key(" world").unwrap(), ("", " world"));84 assert_eq!(85 try_parse_mapping_key(" () world").unwrap(),86 ("", " () world")87 );88 }8990 #[test]91 #[should_panic]92 fn parse_key_missing_start() {93 try_parse_mapping_key("").unwrap();94 }9596 #[test]97 #[should_panic]98 fn parse_key_missing_end() {99 try_parse_mapping_key("( ").unwrap();100 }101}102103#[allow(clippy::struct_excessive_bools)]104#[derive(Default, Debug)]105pub struct CFlags {106 pub alt: bool,107 pub zero: bool,108 pub left: bool,109 pub blank: bool,110 pub sign: bool,111}112113pub fn try_parse_cflags(str: &str) -> ParseResult<'_, CFlags> {114 if str.is_empty() {115 return Err(TruncatedFormatCode);116 }117 let bytes = str.as_bytes();118 let mut i = 0;119 let mut out = CFlags::default();120 loop {121 if bytes.len() == i {122 return Err(TruncatedFormatCode);123 }124 match bytes[i] {125 b'#' => out.alt = true,126 b'0' => out.zero = true,127 b'-' => out.left = true,128 b' ' => out.blank = true,129 b'+' => out.sign = true,130 _ => break,131 }132 i += 1;133 }134 Ok((out, &str[i..]))135}136137#[derive(Debug, PartialEq, Eq)]138pub enum Width {139 Star,140 Fixed(usize),141}142pub fn try_parse_field_width(str: &str) -> ParseResult<'_, Width> {143 if str.is_empty() {144 return Err(TruncatedFormatCode);145 }146 let bytes = str.as_bytes();147 if bytes[0] == b'*' {148 return Ok((Width::Star, &str[1..]));149 }150 let mut out: usize = 0;151 let mut digits = 0;152 while let Some(digit) = (bytes[digits] as char).to_digit(10) {153 out *= 10;154 out += digit as usize;155 digits += 1;156 if digits == bytes.len() {157 return Err(TruncatedFormatCode);158 }159 }160 Ok((Width::Fixed(out), &str[digits..]))161}162163pub fn try_parse_precision(str: &str) -> ParseResult<'_, Option<Width>> {164 if str.is_empty() {165 return Err(TruncatedFormatCode);166 }167 let bytes = str.as_bytes();168 if bytes[0] == b'.' {169 try_parse_field_width(&str[1..]).map(|(r, s)| (Some(r), s))170 } else {171 Ok((None, str))172 }173}174175// Only skips176pub fn try_parse_length_modifier(str: &str) -> ParseResult<'_, ()> {177 if str.is_empty() {178 return Err(TruncatedFormatCode);179 }180 let bytes = str.as_bytes();181 let mut idx = 0;182 while bytes[idx] == b'h' || bytes[idx] == b'l' || bytes[idx] == b'L' {183 idx += 1;184 if bytes.len() == idx {185 return Err(TruncatedFormatCode);186 }187 }188 Ok(((), &str[idx..]))189}190191#[derive(Debug, PartialEq, Eq)]192pub enum ConvTypeV {193 Decimal,194 Octal,195 Hexadecimal,196 Scientific,197 Float,198 Shorter,199 Char,200 String,201 Percent,202}203pub struct ConvType {204 v: ConvTypeV,205 caps: bool,206}207208pub fn parse_conversion_type(str: &str) -> ParseResult<'_, ConvType> {209 if str.is_empty() {210 return Err(TruncatedFormatCode);211 }212213 let code = str.as_bytes()[0];214 let v: (ConvTypeV, bool) = match code {215 b'd' | b'i' | b'u' => (ConvTypeV::Decimal, false),216 b'o' => (ConvTypeV::Octal, false),217 b'x' => (ConvTypeV::Hexadecimal, false),218 b'X' => (ConvTypeV::Hexadecimal, true),219 b'e' => (ConvTypeV::Scientific, false),220 b'E' => (ConvTypeV::Scientific, true),221 b'f' => (ConvTypeV::Float, false),222 b'F' => (ConvTypeV::Float, true),223 b'g' => (ConvTypeV::Shorter, false),224 b'G' => (ConvTypeV::Shorter, true),225 b'c' => (ConvTypeV::Char, false),226 b's' => (ConvTypeV::String, false),227 b'%' => (ConvTypeV::Percent, false),228 c => return Err(UnrecognizedConversionType(c as char)),229 };230231 Ok((ConvType { v: v.0, caps: v.1 }, &str[1..]))232}233234#[derive(Debug)]235pub struct Code<'s> {236 mkey: &'s str,237 cflags: CFlags,238 width: Width,239 precision: Option<Width>,240 convtype: ConvTypeV,241 caps: bool,242}243pub fn parse_code(str: &str) -> ParseResult<'_, Code<'_>> {244 if str.is_empty() {245 return Err(TruncatedFormatCode);246 }247 let (mkey, str) = try_parse_mapping_key(str)?;248 let (cflags, str) = try_parse_cflags(str)?;249 let (width, str) = try_parse_field_width(str)?;250 let (precision, str) = try_parse_precision(str)?;251 let (_, str) = try_parse_length_modifier(str)?;252 let (convtype, str) = parse_conversion_type(str)?;253254 Ok((255 Code {256 mkey,257 cflags,258 width,259 precision,260 convtype: convtype.v,261 caps: convtype.caps,262 },263 str,264 ))265}266267#[derive(Debug)]268pub enum Element<'s> {269 String(&'s str),270 Code(Code<'s>),271}272pub fn parse_codes(mut str: &str) -> Result<Vec<Element<'_>>> {273 let mut bytes = str.as_bytes();274 let mut out = vec![];275 let mut offset = 0;276277 loop {278 while offset != bytes.len() && bytes[offset] != b'%' {279 offset += 1;280 }281 if offset != 0 {282 out.push(Element::String(&str[0..offset]));283 }284 if offset == bytes.len() {285 return Ok(out);286 }287 str = &str[offset + 1..];288 let code;289 (code, str) = parse_code(str)?;290 bytes = str.as_bytes();291 offset = 0;292293 out.push(Element::Code(code));294 }295}296297const NUMBERS: &[u8] = b"0123456789abcdefghijklmnopqrstuvwxyz";298299#[inline]300pub fn render_integer(301 out: &mut String,302 iv: f64,303 padding: usize,304 precision: usize,305 blank: bool,306 sign: bool,307 radix: i64,308 prefix: &str,309 caps: bool,310) {311 let radix = radix as f64;312 let iv = iv.floor();313 // Digit char indexes in reverse order, i.e314 // for radix = 16 and n = 12f: [15, 2, 1]315 let digits = if iv == 0.0 {316 vec![0u8]317 } else {318 let mut v = iv.abs();319 let mut nums = Vec::with_capacity(1);320 while v != 0.0 {321 nums.push((v % radix) as u8);322 v = (v / radix).floor();323 }324 nums325 };326 let neg = iv < 0.0;327 #[allow(clippy::bool_to_int_with_if)]328 let zp = padding.saturating_sub(if neg || blank || sign { 1 } else { 0 });329 let zp2 = zp330 .max(precision)331 .saturating_sub(prefix.len() + digits.len());332333 if neg {334 out.push('-');335 } else if sign {336 out.push('+');337 } else if blank {338 out.push(' ');339 }340341 out.reserve(zp2);342 for _ in 0..zp2 {343 out.push('0');344 }345 out.push_str(prefix);346347 for digit in digits.into_iter().rev() {348 let ch = NUMBERS[digit as usize] as char;349 out.push(if caps { ch.to_ascii_uppercase() } else { ch });350 }351}352353pub fn render_decimal(354 out: &mut String,355 iv: f64,356 padding: usize,357 precision: usize,358 blank: bool,359 sign: bool,360) {361 render_integer(out, iv, padding, precision, blank, sign, 10, "", false);362}363pub fn render_octal(364 out: &mut String,365 iv: f64,366 padding: usize,367 precision: usize,368 alt: bool,369 blank: bool,370 sign: bool,371) {372 render_integer(373 out,374 iv,375 padding,376 precision,377 blank,378 sign,379 8,380 if alt && iv != 0.0 { "0" } else { "" },381 false,382 );383}384385#[allow(clippy::fn_params_excessive_bools)]386pub fn render_hexadecimal(387 out: &mut String,388 iv: f64,389 padding: usize,390 precision: usize,391 alt: bool,392 blank: bool,393 sign: bool,394 caps: bool,395) {396 render_integer(397 out,398 iv,399 padding,400 precision,401 blank,402 sign,403 16,404 match (alt, caps) {405 (true, true) => "0X",406 (true, false) => "0x",407 (false, _) => "",408 },409 caps,410 );411}412413#[allow(clippy::fn_params_excessive_bools)]414pub fn render_float(415 out: &mut String,416 n: f64,417 mut padding: usize,418 precision: usize,419 blank: bool,420 sign: bool,421 ensure_pt: bool,422 trailing: bool,423) {424 #[allow(clippy::bool_to_int_with_if)]425 let dot_size = if precision == 0 && !ensure_pt { 0 } else { 1 };426 padding = padding.saturating_sub(dot_size + precision);427 render_decimal(out, n.floor(), padding, 0, blank, sign);428 if precision == 0 {429 if ensure_pt {430 out.push('.');431 }432 return;433 }434 let frac = n435 .fract()436 .mul_add(10.0_f64.powf(precision as f64), 0.5)437 .floor();438 if trailing || frac > 0.0 {439 out.push('.');440 let mut frac_str = String::new();441 render_decimal(&mut frac_str, frac, precision, 0, false, false);442 let mut trim = frac_str.len();443 if !trailing {444 for b in frac_str.as_bytes().iter().rev() {445 if *b == b'0' {446 trim -= 1;447 } else {448 break;449 }450 }451 }452 out.push_str(&frac_str[..trim]);453 } else if ensure_pt {454 out.push('.');455 }456}457458#[allow(clippy::fn_params_excessive_bools)]459pub fn render_float_sci(460 out: &mut String,461 n: f64,462 mut padding: usize,463 precision: usize,464 blank: bool,465 sign: bool,466 ensure_pt: bool,467 trailing: bool,468 caps: bool,469) {470 let exponent = n.log10().floor();471 let mantissa = if exponent as i16 == -324 {472 n * 10.0 / 10.0_f64.powf(exponent + 1.0)473 } else {474 n / 10.0_f64.powf(exponent)475 };476 let mut exponent_str = String::new();477 render_decimal(&mut exponent_str, exponent, 3, 0, false, true);478479 // +1 for e480 padding = padding.saturating_sub(exponent_str.len() + 1);481482 render_float(483 out, mantissa, padding, precision, blank, sign, ensure_pt, trailing,484 );485 out.push(if caps { 'E' } else { 'e' });486 out.push_str(&exponent_str);487}488489#[allow(clippy::too_many_lines)]490pub fn format_code(491 out: &mut String,492 value: &Val,493 code: &Code<'_>,494 width: usize,495 precision: Option<usize>,496) -> Result<()> {497 let clfags = &code.cflags;498 let (fpprec, iprec) = precision.map_or((6, 0), |v| (v, v));499 let padding = if clfags.zero && !clfags.left {500 width501 } else {502 0503 };504505 // TODO: If left padded, can optimize by writing directly to out506 let mut tmp_out = String::new();507508 match code.convtype {509 ConvTypeV::String => tmp_out.push_str(&value.clone().to_string()?),510 ConvTypeV::Decimal => {511 let value = f64::from_untyped(value.clone())?;512 render_decimal(513 &mut tmp_out,514 value,515 padding,516 iprec,517 clfags.blank,518 clfags.sign,519 );520 }521 ConvTypeV::Octal => {522 let value = f64::from_untyped(value.clone())?;523 render_octal(524 &mut tmp_out,525 value,526 padding,527 iprec,528 clfags.alt,529 clfags.blank,530 clfags.sign,531 );532 }533 ConvTypeV::Hexadecimal => {534 let value = f64::from_untyped(value.clone())?;535 render_hexadecimal(536 &mut tmp_out,537 value,538 padding,539 iprec,540 clfags.alt,541 clfags.blank,542 clfags.sign,543 code.caps,544 );545 }546 ConvTypeV::Scientific => {547 let value = f64::from_untyped(value.clone())?;548 render_float_sci(549 &mut tmp_out,550 value,551 padding,552 fpprec,553 clfags.blank,554 clfags.sign,555 clfags.alt,556 true,557 code.caps,558 );559 }560 ConvTypeV::Float => {561 let value = f64::from_untyped(value.clone())?;562 render_float(563 &mut tmp_out,564 value,565 padding,566 fpprec,567 clfags.blank,568 clfags.sign,569 clfags.alt,570 true,571 );572 }573 ConvTypeV::Shorter => {574 let value = f64::from_untyped(value.clone())?;575 let exponent = if value == 0.0 {576 0.0577 } else {578 value.abs().log10().floor()579 };580 if exponent < -4.0 || exponent >= fpprec as f64 {581 render_float_sci(582 &mut tmp_out,583 value,584 padding,585 fpprec - 1,586 clfags.blank,587 clfags.sign,588 clfags.alt,589 clfags.alt,590 code.caps,591 );592 } else {593 let digits_before_pt = 1.max(exponent as usize + 1);594 render_float(595 &mut tmp_out,596 value,597 padding,598 fpprec - digits_before_pt,599 clfags.blank,600 clfags.sign,601 clfags.alt,602 clfags.alt,603 );604 }605 }606 ConvTypeV::Char => match value.clone() {607 Val::Num(n) => tmp_out.push(608 std::char::from_u32(n as u32)609 .ok_or_else(|| InvalidUnicodeCodepointGot(n as u32))?,610 ),611 Val::Str(s) => {612 let s = s.into_flat();613 if s.chars().count() != 1 {614 throw!("%c expected 1 char string, got {}", s.chars().count(),);615 }616 tmp_out.push_str(&s);617 }618 _ => {619 throw!(TypeMismatch(620 "%c requires number/string",621 vec![ValType::Num, ValType::Str],622 value.value_type(),623 ));624 }625 },626 ConvTypeV::Percent => tmp_out.push('%'),627 };628629 let padding = width.saturating_sub(tmp_out.len());630631 if !clfags.left {632 for _ in 0..padding {633 out.push(' ');634 }635 }636 out.push_str(&tmp_out);637 if clfags.left {638 for _ in 0..padding {639 out.push(' ');640 }641 }642643 Ok(())644}645646pub fn format_arr(str: &str, mut values: &[Val]) -> Result<String> {647 let codes = parse_codes(str)?;648 let mut out = String::new();649 let value_count = values.len();650651 for code in codes {652 match code {653 Element::String(s) => {654 out.push_str(s);655 }656 Element::Code(c) => {657 let width = match c.width {658 Width::Star => {659 if values.is_empty() {660 throw!(NotEnoughValues);661 }662 let value = &values[0];663 values = &values[1..];664 usize::from_untyped(value.clone())?665 }666 Width::Fixed(n) => n,667 };668 let precision = match c.precision {669 Some(Width::Star) => {670 if values.is_empty() {671 throw!(NotEnoughValues);672 }673 let value = &values[0];674 values = &values[1..];675 Some(usize::from_untyped(value.clone())?)676 }677 Some(Width::Fixed(n)) => Some(n),678 None => None,679 };680681 // %% should not consume a value682 let value = if c.convtype == ConvTypeV::Percent {683 &Val::Null684 } else {685 if values.is_empty() {686 throw!(NotEnoughValues);687 }688 let value = &values[0];689 values = &values[1..];690 value691 };692693 format_code(&mut out, value, &c, width, precision)?;694 }695 }696 }697698 if !values.is_empty() {699 throw!(700 "too many values to format, expected {value_count}, got {}",701 value_count + values.len()702 )703 }704705 Ok(out)706}707708fn get_dotted_field(obj: ObjValue, field: &str) -> Result<Val> {709 let mut current = Val::Obj(obj);710 let mut name_offset = 0;711 for component in field.split('.') {712 let end_offset = name_offset + component.len();713 current = if let Val::Obj(obj) = current {714 if let Some(value) = obj.get(component.into())? {715 value716 } else {717 let current = &field[name_offset..end_offset];718 let full = &field[..name_offset];719 let found = Box::new(suggest_object_fields(&obj, current.into()));720 throw!(SubfieldNotFound {721 current: current.into(),722 full: full.into(),723 found,724 })725 }726 } else {727 // No underflow may happen, initially we always start with an object728 let subfield = &field[..name_offset - 1];729 throw!(SubfieldDidntYieldAnObject(730 subfield.into(),731 current.value_type()732 ));733 };734 name_offset = end_offset + 1;735 }736 Ok(current)737}738739pub fn format_obj(str: &str, values: &ObjValue) -> Result<String> {740 let codes = parse_codes(str)?;741 let mut out = String::new();742743 for code in codes {744 match code {745 Element::String(s) => {746 out.push_str(s);747 }748 Element::Code(c) => {749 // TODO: Operate on ref750 let f: IStr = c.mkey.into();751 let width = match c.width {752 Width::Star => {753 throw!(CannotUseStarWidthWithObject);754 }755 Width::Fixed(n) => n,756 };757 let precision = match c.precision {758 Some(Width::Star) => {759 throw!(CannotUseStarWidthWithObject);760 }761 Some(Width::Fixed(n)) => Some(n),762 None => None,763 };764765 let value = if c.convtype == ConvTypeV::Percent {766 Val::Null767 } else {768 if f.is_empty() {769 throw!(MappingKeysRequired);770 }771 if let Some(v) = values.get(f.clone())? {772 v773 } else {774 get_dotted_field(values.clone(), &f)?775 }776 };777778 format_code(&mut out, &value, &c, width, precision)?;779 }780 }781 }782783 Ok(out)784}785786#[cfg(test)]787pub mod test_format {788 use super::*;789790 #[test]791 fn parse() {792 assert_eq!(793 parse_codes(794 "How much error budget is left looking at our %.3f%% availability gurantees?"795 )796 .unwrap()797 .len(),798 4799 );800 }801802 #[test]803 fn octals() {804 assert_eq!(format_arr("%#o", &[Val::Num(8.0)]).unwrap(), "010");805 assert_eq!(format_arr("%#4o", &[Val::Num(8.0)]).unwrap(), " 010");806 assert_eq!(format_arr("%4o", &[Val::Num(8.0)]).unwrap(), " 10");807 assert_eq!(format_arr("%04o", &[Val::Num(8.0)]).unwrap(), "0010");808 assert_eq!(format_arr("%+4o", &[Val::Num(8.0)]).unwrap(), " +10");809 assert_eq!(format_arr("%+04o", &[Val::Num(8.0)]).unwrap(), "+010");810 assert_eq!(format_arr("%-4o", &[Val::Num(8.0)]).unwrap(), "10 ");811 assert_eq!(format_arr("%+-4o", &[Val::Num(8.0)]).unwrap(), "+10 ");812 assert_eq!(format_arr("%+-04o", &[Val::Num(8.0)]).unwrap(), "+10 ");813 }814815 #[test]816 fn percent_doesnt_consumes_values() {817 assert_eq!(818 format_arr(819 "How much error budget is left looking at our %.3f%% availability gurantees?",820 &[Val::Num(4.0)]821 )822 .unwrap(),823 "How much error budget is left looking at our 4.000% availability gurantees?"824 );825 }826}1//! faster std.format impl2#![allow(clippy::too_many_arguments)]34use jrsonnet_gcmodule::Trace;5use jrsonnet_interner::IStr;6use jrsonnet_types::ValType;7use thiserror::Error;89use crate::{10 bail,11 error::{format_found, suggest_object_fields, ErrorKind::*},12 typed::Typed,13 Error, ObjValue, Result, Val,14};1516#[derive(Debug, Clone, Error, Trace)]17pub enum FormatError {18 #[error("truncated format code")]19 TruncatedFormatCode,20 #[error("unrecognized conversion type: {0}")]21 UnrecognizedConversionType(char),2223 #[error("not enough values")]24 NotEnoughValues,2526 #[error("cannot use * width with object")]27 CannotUseStarWidthWithObject,28 #[error("mapping keys required")]29 MappingKeysRequired,30 #[error("no such format field: {0}")]31 NoSuchFormatField(IStr),3233 #[error("expected subfield <{0}> to be an object, got {1} instead")]34 SubfieldDidntYieldAnObject(IStr, ValType),35 #[error("subfield not found: <[{full}]{current}>{}", format_found(.found, "subfield"))]36 SubfieldNotFound {37 current: IStr,38 full: IStr,39 found: Box<Vec<IStr>>,40 },41}4243impl From<FormatError> for Error {44 fn from(e: FormatError) -> Self {45 Self::new(Format(e))46 }47}4849use FormatError::*;5051type ParseResult<'t, T> = std::result::Result<(T, &'t str), FormatError>;5253pub fn try_parse_mapping_key(str: &str) -> ParseResult<'_, &str> {54 if str.is_empty() {55 return Err(TruncatedFormatCode);56 }57 let bytes = str.as_bytes();58 if bytes[0] == b'(' {59 let mut i = 1;60 while i < bytes.len() {61 if bytes[i] == b')' {62 return Ok((&str[1..i], &str[i + 1..]));63 }64 i += 1;65 }66 Err(TruncatedFormatCode)67 } else {68 Ok(("", str))69 }70}7172#[cfg(test)]73pub mod tests_key {74 use super::*;7576 #[test]77 fn parse_key() {78 assert_eq!(79 try_parse_mapping_key("(hello ) world").unwrap(),80 ("hello ", " world")81 );82 assert_eq!(try_parse_mapping_key("() world").unwrap(), ("", " world"));83 assert_eq!(try_parse_mapping_key(" world").unwrap(), ("", " world"));84 assert_eq!(85 try_parse_mapping_key(" () world").unwrap(),86 ("", " () world")87 );88 }8990 #[test]91 #[should_panic]92 fn parse_key_missing_start() {93 try_parse_mapping_key("").unwrap();94 }9596 #[test]97 #[should_panic]98 fn parse_key_missing_end() {99 try_parse_mapping_key("( ").unwrap();100 }101}102103#[allow(clippy::struct_excessive_bools)]104#[derive(Default, Debug)]105pub struct CFlags {106 pub alt: bool,107 pub zero: bool,108 pub left: bool,109 pub blank: bool,110 pub sign: bool,111}112113pub fn try_parse_cflags(str: &str) -> ParseResult<'_, CFlags> {114 if str.is_empty() {115 return Err(TruncatedFormatCode);116 }117 let bytes = str.as_bytes();118 let mut i = 0;119 let mut out = CFlags::default();120 loop {121 if bytes.len() == i {122 return Err(TruncatedFormatCode);123 }124 match bytes[i] {125 b'#' => out.alt = true,126 b'0' => out.zero = true,127 b'-' => out.left = true,128 b' ' => out.blank = true,129 b'+' => out.sign = true,130 _ => break,131 }132 i += 1;133 }134 Ok((out, &str[i..]))135}136137#[derive(Debug, PartialEq, Eq)]138pub enum Width {139 Star,140 Fixed(usize),141}142pub fn try_parse_field_width(str: &str) -> ParseResult<'_, Width> {143 if str.is_empty() {144 return Err(TruncatedFormatCode);145 }146 let bytes = str.as_bytes();147 if bytes[0] == b'*' {148 return Ok((Width::Star, &str[1..]));149 }150 let mut out: usize = 0;151 let mut digits = 0;152 while let Some(digit) = (bytes[digits] as char).to_digit(10) {153 out *= 10;154 out += digit as usize;155 digits += 1;156 if digits == bytes.len() {157 return Err(TruncatedFormatCode);158 }159 }160 Ok((Width::Fixed(out), &str[digits..]))161}162163pub fn try_parse_precision(str: &str) -> ParseResult<'_, Option<Width>> {164 if str.is_empty() {165 return Err(TruncatedFormatCode);166 }167 let bytes = str.as_bytes();168 if bytes[0] == b'.' {169 try_parse_field_width(&str[1..]).map(|(r, s)| (Some(r), s))170 } else {171 Ok((None, str))172 }173}174175// Only skips176pub fn try_parse_length_modifier(str: &str) -> ParseResult<'_, ()> {177 if str.is_empty() {178 return Err(TruncatedFormatCode);179 }180 let bytes = str.as_bytes();181 let mut idx = 0;182 while bytes[idx] == b'h' || bytes[idx] == b'l' || bytes[idx] == b'L' {183 idx += 1;184 if bytes.len() == idx {185 return Err(TruncatedFormatCode);186 }187 }188 Ok(((), &str[idx..]))189}190191#[derive(Debug, PartialEq, Eq)]192pub enum ConvTypeV {193 Decimal,194 Octal,195 Hexadecimal,196 Scientific,197 Float,198 Shorter,199 Char,200 String,201 Percent,202}203pub struct ConvType {204 v: ConvTypeV,205 caps: bool,206}207208pub fn parse_conversion_type(str: &str) -> ParseResult<'_, ConvType> {209 if str.is_empty() {210 return Err(TruncatedFormatCode);211 }212213 let code = str.as_bytes()[0];214 let v: (ConvTypeV, bool) = match code {215 b'd' | b'i' | b'u' => (ConvTypeV::Decimal, false),216 b'o' => (ConvTypeV::Octal, false),217 b'x' => (ConvTypeV::Hexadecimal, false),218 b'X' => (ConvTypeV::Hexadecimal, true),219 b'e' => (ConvTypeV::Scientific, false),220 b'E' => (ConvTypeV::Scientific, true),221 b'f' => (ConvTypeV::Float, false),222 b'F' => (ConvTypeV::Float, true),223 b'g' => (ConvTypeV::Shorter, false),224 b'G' => (ConvTypeV::Shorter, true),225 b'c' => (ConvTypeV::Char, false),226 b's' => (ConvTypeV::String, false),227 b'%' => (ConvTypeV::Percent, false),228 c => return Err(UnrecognizedConversionType(c as char)),229 };230231 Ok((ConvType { v: v.0, caps: v.1 }, &str[1..]))232}233234#[derive(Debug)]235pub struct Code<'s> {236 mkey: &'s str,237 cflags: CFlags,238 width: Width,239 precision: Option<Width>,240 convtype: ConvTypeV,241 caps: bool,242}243pub fn parse_code(str: &str) -> ParseResult<'_, Code<'_>> {244 if str.is_empty() {245 return Err(TruncatedFormatCode);246 }247 let (mkey, str) = try_parse_mapping_key(str)?;248 let (cflags, str) = try_parse_cflags(str)?;249 let (width, str) = try_parse_field_width(str)?;250 let (precision, str) = try_parse_precision(str)?;251 let (_, str) = try_parse_length_modifier(str)?;252 let (convtype, str) = parse_conversion_type(str)?;253254 Ok((255 Code {256 mkey,257 cflags,258 width,259 precision,260 convtype: convtype.v,261 caps: convtype.caps,262 },263 str,264 ))265}266267#[derive(Debug)]268pub enum Element<'s> {269 String(&'s str),270 Code(Code<'s>),271}272pub fn parse_codes(mut str: &str) -> Result<Vec<Element<'_>>> {273 let mut bytes = str.as_bytes();274 let mut out = vec![];275 let mut offset = 0;276277 loop {278 while offset != bytes.len() && bytes[offset] != b'%' {279 offset += 1;280 }281 if offset != 0 {282 out.push(Element::String(&str[0..offset]));283 }284 if offset == bytes.len() {285 return Ok(out);286 }287 str = &str[offset + 1..];288 let code;289 (code, str) = parse_code(str)?;290 bytes = str.as_bytes();291 offset = 0;292293 out.push(Element::Code(code));294 }295}296297const NUMBERS: &[u8] = b"0123456789abcdefghijklmnopqrstuvwxyz";298299#[inline]300pub fn render_integer(301 out: &mut String,302 iv: f64,303 padding: usize,304 precision: usize,305 blank: bool,306 sign: bool,307 radix: i64,308 prefix: &str,309 caps: bool,310) {311 let radix = radix as f64;312 let iv = iv.floor();313 // Digit char indexes in reverse order, i.e314 // for radix = 16 and n = 12f: [15, 2, 1]315 let digits = if iv == 0.0 {316 vec![0u8]317 } else {318 let mut v = iv.abs();319 let mut nums = Vec::with_capacity(1);320 while v != 0.0 {321 nums.push((v % radix) as u8);322 v = (v / radix).floor();323 }324 nums325 };326 let neg = iv < 0.0;327 #[allow(clippy::bool_to_int_with_if)]328 let zp = padding.saturating_sub(if neg || blank || sign { 1 } else { 0 });329 let zp2 = zp330 .max(precision)331 .saturating_sub(prefix.len() + digits.len());332333 if neg {334 out.push('-');335 } else if sign {336 out.push('+');337 } else if blank {338 out.push(' ');339 }340341 out.reserve(zp2);342 for _ in 0..zp2 {343 out.push('0');344 }345 out.push_str(prefix);346347 for digit in digits.into_iter().rev() {348 let ch = NUMBERS[digit as usize] as char;349 out.push(if caps { ch.to_ascii_uppercase() } else { ch });350 }351}352353pub fn render_decimal(354 out: &mut String,355 iv: f64,356 padding: usize,357 precision: usize,358 blank: bool,359 sign: bool,360) {361 render_integer(out, iv, padding, precision, blank, sign, 10, "", false);362}363pub fn render_octal(364 out: &mut String,365 iv: f64,366 padding: usize,367 precision: usize,368 alt: bool,369 blank: bool,370 sign: bool,371) {372 render_integer(373 out,374 iv,375 padding,376 precision,377 blank,378 sign,379 8,380 if alt && iv != 0.0 { "0" } else { "" },381 false,382 );383}384385#[allow(clippy::fn_params_excessive_bools)]386pub fn render_hexadecimal(387 out: &mut String,388 iv: f64,389 padding: usize,390 precision: usize,391 alt: bool,392 blank: bool,393 sign: bool,394 caps: bool,395) {396 render_integer(397 out,398 iv,399 padding,400 precision,401 blank,402 sign,403 16,404 match (alt, caps) {405 (true, true) => "0X",406 (true, false) => "0x",407 (false, _) => "",408 },409 caps,410 );411}412413#[allow(clippy::fn_params_excessive_bools)]414pub fn render_float(415 out: &mut String,416 n: f64,417 mut padding: usize,418 precision: usize,419 blank: bool,420 sign: bool,421 ensure_pt: bool,422 trailing: bool,423) {424 #[allow(clippy::bool_to_int_with_if)]425 let dot_size = if precision == 0 && !ensure_pt { 0 } else { 1 };426 padding = padding.saturating_sub(dot_size + precision);427 render_decimal(out, n.floor(), padding, 0, blank, sign);428 if precision == 0 {429 if ensure_pt {430 out.push('.');431 }432 return;433 }434 let frac = n435 .fract()436 .mul_add(10.0_f64.powf(precision as f64), 0.5)437 .floor();438 if trailing || frac > 0.0 {439 out.push('.');440 let mut frac_str = String::new();441 render_decimal(&mut frac_str, frac, precision, 0, false, false);442 let mut trim = frac_str.len();443 if !trailing {444 for b in frac_str.as_bytes().iter().rev() {445 if *b == b'0' {446 trim -= 1;447 } else {448 break;449 }450 }451 }452 out.push_str(&frac_str[..trim]);453 } else if ensure_pt {454 out.push('.');455 }456}457458#[allow(clippy::fn_params_excessive_bools)]459pub fn render_float_sci(460 out: &mut String,461 n: f64,462 mut padding: usize,463 precision: usize,464 blank: bool,465 sign: bool,466 ensure_pt: bool,467 trailing: bool,468 caps: bool,469) {470 let exponent = n.log10().floor();471 let mantissa = if exponent as i16 == -324 {472 n * 10.0 / 10.0_f64.powf(exponent + 1.0)473 } else {474 n / 10.0_f64.powf(exponent)475 };476 let mut exponent_str = String::new();477 render_decimal(&mut exponent_str, exponent, 3, 0, false, true);478479 // +1 for e480 padding = padding.saturating_sub(exponent_str.len() + 1);481482 render_float(483 out, mantissa, padding, precision, blank, sign, ensure_pt, trailing,484 );485 out.push(if caps { 'E' } else { 'e' });486 out.push_str(&exponent_str);487}488489#[allow(clippy::too_many_lines)]490pub fn format_code(491 out: &mut String,492 value: &Val,493 code: &Code<'_>,494 width: usize,495 precision: Option<usize>,496) -> Result<()> {497 let clfags = &code.cflags;498 let (fpprec, iprec) = precision.map_or((6, 0), |v| (v, v));499 let padding = if clfags.zero && !clfags.left {500 width501 } else {502 0503 };504505 // TODO: If left padded, can optimize by writing directly to out506 let mut tmp_out = String::new();507508 match code.convtype {509 ConvTypeV::String => tmp_out.push_str(&value.clone().to_string()?),510 ConvTypeV::Decimal => {511 let value = f64::from_untyped(value.clone())?;512 render_decimal(513 &mut tmp_out,514 value,515 padding,516 iprec,517 clfags.blank,518 clfags.sign,519 );520 }521 ConvTypeV::Octal => {522 let value = f64::from_untyped(value.clone())?;523 render_octal(524 &mut tmp_out,525 value,526 padding,527 iprec,528 clfags.alt,529 clfags.blank,530 clfags.sign,531 );532 }533 ConvTypeV::Hexadecimal => {534 let value = f64::from_untyped(value.clone())?;535 render_hexadecimal(536 &mut tmp_out,537 value,538 padding,539 iprec,540 clfags.alt,541 clfags.blank,542 clfags.sign,543 code.caps,544 );545 }546 ConvTypeV::Scientific => {547 let value = f64::from_untyped(value.clone())?;548 render_float_sci(549 &mut tmp_out,550 value,551 padding,552 fpprec,553 clfags.blank,554 clfags.sign,555 clfags.alt,556 true,557 code.caps,558 );559 }560 ConvTypeV::Float => {561 let value = f64::from_untyped(value.clone())?;562 render_float(563 &mut tmp_out,564 value,565 padding,566 fpprec,567 clfags.blank,568 clfags.sign,569 clfags.alt,570 true,571 );572 }573 ConvTypeV::Shorter => {574 let value = f64::from_untyped(value.clone())?;575 let exponent = if value == 0.0 {576 0.0577 } else {578 value.abs().log10().floor()579 };580 if exponent < -4.0 || exponent >= fpprec as f64 {581 render_float_sci(582 &mut tmp_out,583 value,584 padding,585 fpprec - 1,586 clfags.blank,587 clfags.sign,588 clfags.alt,589 clfags.alt,590 code.caps,591 );592 } else {593 let digits_before_pt = 1.max(exponent as usize + 1);594 render_float(595 &mut tmp_out,596 value,597 padding,598 fpprec - digits_before_pt,599 clfags.blank,600 clfags.sign,601 clfags.alt,602 clfags.alt,603 );604 }605 }606 ConvTypeV::Char => match value.clone() {607 Val::Num(n) => tmp_out.push(608 std::char::from_u32(n as u32)609 .ok_or_else(|| InvalidUnicodeCodepointGot(n as u32))?,610 ),611 Val::Str(s) => {612 let s = s.into_flat();613 if s.chars().count() != 1 {614 bail!("%c expected 1 char string, got {}", s.chars().count());615 }616 tmp_out.push_str(&s);617 }618 _ => {619 bail!(TypeMismatch(620 "%c requires number/string",621 vec![ValType::Num, ValType::Str],622 value.value_type(),623 ));624 }625 },626 ConvTypeV::Percent => tmp_out.push('%'),627 };628629 let padding = width.saturating_sub(tmp_out.len());630631 if !clfags.left {632 for _ in 0..padding {633 out.push(' ');634 }635 }636 out.push_str(&tmp_out);637 if clfags.left {638 for _ in 0..padding {639 out.push(' ');640 }641 }642643 Ok(())644}645646pub fn format_arr(str: &str, mut values: &[Val]) -> Result<String> {647 let codes = parse_codes(str)?;648 let mut out = String::new();649 let value_count = values.len();650651 for code in codes {652 match code {653 Element::String(s) => {654 out.push_str(s);655 }656 Element::Code(c) => {657 let width = match c.width {658 Width::Star => {659 if values.is_empty() {660 bail!(NotEnoughValues);661 }662 let value = &values[0];663 values = &values[1..];664 usize::from_untyped(value.clone())?665 }666 Width::Fixed(n) => n,667 };668 let precision = match c.precision {669 Some(Width::Star) => {670 if values.is_empty() {671 bail!(NotEnoughValues);672 }673 let value = &values[0];674 values = &values[1..];675 Some(usize::from_untyped(value.clone())?)676 }677 Some(Width::Fixed(n)) => Some(n),678 None => None,679 };680681 // %% should not consume a value682 let value = if c.convtype == ConvTypeV::Percent {683 &Val::Null684 } else {685 if values.is_empty() {686 bail!(NotEnoughValues);687 }688 let value = &values[0];689 values = &values[1..];690 value691 };692693 format_code(&mut out, value, &c, width, precision)?;694 }695 }696 }697698 if !values.is_empty() {699 bail!(700 "too many values to format, expected {value_count}, got {}",701 value_count + values.len()702 )703 }704705 Ok(out)706}707708fn get_dotted_field(obj: ObjValue, field: &str) -> Result<Val> {709 let mut current = Val::Obj(obj);710 let mut name_offset = 0;711 for component in field.split('.') {712 let end_offset = name_offset + component.len();713 current = if let Val::Obj(obj) = current {714 if let Some(value) = obj.get(component.into())? {715 value716 } else {717 let current = &field[name_offset..end_offset];718 let full = &field[..name_offset];719 let found = Box::new(suggest_object_fields(&obj, current.into()));720 bail!(SubfieldNotFound {721 current: current.into(),722 full: full.into(),723 found,724 })725 }726 } else {727 // No underflow may happen, initially we always start with an object728 let subfield = &field[..name_offset - 1];729 bail!(SubfieldDidntYieldAnObject(730 subfield.into(),731 current.value_type()732 ));733 };734 name_offset = end_offset + 1;735 }736 Ok(current)737}738739pub fn format_obj(str: &str, values: &ObjValue) -> Result<String> {740 let codes = parse_codes(str)?;741 let mut out = String::new();742743 for code in codes {744 match code {745 Element::String(s) => {746 out.push_str(s);747 }748 Element::Code(c) => {749 // TODO: Operate on ref750 let f: IStr = c.mkey.into();751 let width = match c.width {752 Width::Star => {753 bail!(CannotUseStarWidthWithObject);754 }755 Width::Fixed(n) => n,756 };757 let precision = match c.precision {758 Some(Width::Star) => {759 bail!(CannotUseStarWidthWithObject);760 }761 Some(Width::Fixed(n)) => Some(n),762 None => None,763 };764765 let value = if c.convtype == ConvTypeV::Percent {766 Val::Null767 } else {768 if f.is_empty() {769 bail!(MappingKeysRequired);770 }771 if let Some(v) = values.get(f.clone())? {772 v773 } else {774 get_dotted_field(values.clone(), &f)?775 }776 };777778 format_code(&mut out, &value, &c, width, precision)?;779 }780 }781 }782783 Ok(out)784}785786#[cfg(test)]787pub mod test_format {788 use super::*;789790 #[test]791 fn parse() {792 assert_eq!(793 parse_codes(794 "How much error budget is left looking at our %.3f%% availability gurantees?"795 )796 .unwrap()797 .len(),798 4799 );800 }801802 #[test]803 fn octals() {804 assert_eq!(format_arr("%#o", &[Val::Num(8.0)]).unwrap(), "010");805 assert_eq!(format_arr("%#4o", &[Val::Num(8.0)]).unwrap(), " 010");806 assert_eq!(format_arr("%4o", &[Val::Num(8.0)]).unwrap(), " 10");807 assert_eq!(format_arr("%04o", &[Val::Num(8.0)]).unwrap(), "0010");808 assert_eq!(format_arr("%+4o", &[Val::Num(8.0)]).unwrap(), " +10");809 assert_eq!(format_arr("%+04o", &[Val::Num(8.0)]).unwrap(), "+010");810 assert_eq!(format_arr("%-4o", &[Val::Num(8.0)]).unwrap(), "10 ");811 assert_eq!(format_arr("%+-4o", &[Val::Num(8.0)]).unwrap(), "+10 ");812 assert_eq!(format_arr("%+-04o", &[Val::Num(8.0)]).unwrap(), "+10 ");813 }814815 #[test]816 fn percent_doesnt_consumes_values() {817 assert_eq!(818 format_arr(819 "How much error budget is left looking at our %.3f%% availability gurantees?",820 &[Val::Num(4.0)]821 )822 .unwrap(),823 "How much error budget is left looking at our 4.000% availability gurantees?"824 );825 }826}crates/jrsonnet-evaluator/src/stdlib/mod.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/stdlib/mod.rs
+++ b/crates/jrsonnet-evaluator/src/stdlib/mod.rs
@@ -3,7 +3,7 @@
use format::{format_arr, format_obj};
-use crate::{error::Result, function::CallLocation, State, Val};
+use crate::{function::CallLocation, Result, State, Val};
pub mod format;
crates/jrsonnet-evaluator/src/typed/conversions.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/typed/conversions.rs
+++ b/crates/jrsonnet-evaluator/src/typed/conversions.rs
@@ -7,12 +7,11 @@
use crate::{
arr::{ArrValue, BytesArray},
- error::Result,
+ bail,
function::{native::NativeDesc, FuncDesc, FuncVal},
- throw,
typed::CheckType,
- val::{IndexableVal, StrValue, ThunkMapper},
- ObjValue, ObjValueBuilder, Thunk, Val,
+ val::{IndexableVal, ThunkMapper},
+ ObjValue, ObjValueBuilder, Result, Thunk, Val,
};
#[derive(Trace)]
@@ -134,7 +133,7 @@
Val::Num(n) => {
#[allow(clippy::float_cmp)]
if n.trunc() != n {
- throw!(
+ bail!(
"cannot convert number with fractional part to {}",
stringify!($ty)
)
@@ -189,7 +188,7 @@
Val::Num(n) => {
#[allow(clippy::float_cmp)]
if n.trunc() != n {
- throw!(
+ bail!(
"cannot convert number with fractional part to {}",
stringify!($ty)
)
@@ -253,7 +252,7 @@
fn into_untyped(value: Self) -> Result<Val> {
if value > MAX_SAFE_INTEGER as Self {
- throw!("number is too large")
+ bail!("number is too large")
}
Ok(Val::Num(value as f64))
}
@@ -264,7 +263,7 @@
Val::Num(n) => {
#[allow(clippy::float_cmp)]
if n.trunc() != n {
- throw!("cannot convert number with fractional part to usize")
+ bail!("cannot convert number with fractional part to usize")
}
Ok(n as Self)
}
@@ -354,7 +353,7 @@
let mut out = ObjValueBuilder::with_capacity(typed.len());
for (k, v) in typed {
let Some(key) = K::into_untyped(k)?.as_str() else {
- throw!("map key should serialize to string");
+ bail!("map key should serialize to string");
};
let value = V::into_untyped(v)?;
out.member(key).value_unchecked(value);
@@ -567,7 +566,7 @@
<Self as Typed>::TYPE.check(&value)?;
match value {
Val::Func(FuncVal::Normal(desc)) => Ok(desc),
- Val::Func(_) => throw!("expected normal function, not builtin"),
+ Val::Func(_) => bail!("expected normal function, not builtin"),
_ => unreachable!(),
}
}
@@ -649,7 +648,7 @@
const TYPE: &'static ComplexValType = &ComplexValType::Simple(ValType::Func);
fn into_untyped(_typed: Self) -> Result<Val> {
- throw!("can only convert functions from jsonnet to native")
+ bail!("can only convert functions from jsonnet to native")
}
fn from_untyped(untyped: Val) -> Result<Self> {
crates/jrsonnet-evaluator/src/val.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/val.rs
+++ b/crates/jrsonnet-evaluator/src/val.rs
@@ -11,11 +11,12 @@
pub use crate::arr::{ArrValue, ArrayLike};
use crate::{
+ bail,
error::{Error, ErrorKind::*},
function::FuncVal,
gc::{GcHashMap, TraceBox},
manifest::{ManifestFormat, ToStringFormat},
- tb, throw,
+ tb,
typed::BoundedUsize,
ObjValue, Result, Unbound, WeakObjValue,
};
@@ -456,7 +457,7 @@
if num.is_finite() {
Ok(Self::Num(num))
} else {
- throw!("overflow")
+ bail!("overflow")
}
}
@@ -495,7 +496,7 @@
Ok(match self {
Val::Str(s) => IndexableVal::Str(s.into_flat()),
Val::Arr(arr) => IndexableVal::Arr(arr),
- _ => throw!(ValueIsNotIndexable(self.value_type())),
+ _ => bail!(ValueIsNotIndexable(self.value_type())),
})
}
}
@@ -514,13 +515,13 @@
#[cfg(feature = "exp-bigint")]
(Val::BigInt(a), Val::BigInt(b)) => a == b,
(Val::Arr(_), Val::Arr(_)) => {
- throw!("primitiveEquals operates on primitive types, got array")
+ bail!("primitiveEquals operates on primitive types, got array")
}
(Val::Obj(_), Val::Obj(_)) => {
- throw!("primitiveEquals operates on primitive types, got object")
+ bail!("primitiveEquals operates on primitive types, got object")
}
(a, b) if is_function_like(a) && is_function_like(b) => {
- throw!("cannot test equality of functions")
+ bail!("cannot test equality of functions")
}
(_, _) => false,
})
crates/jrsonnet-macros/src/lib.rsdiffbeforeafterboth--- a/crates/jrsonnet-macros/src/lib.rs
+++ b/crates/jrsonnet-macros/src/lib.rs
@@ -356,7 +356,7 @@
use ::jrsonnet_evaluator::{
State, Val,
function::{builtin::{Builtin, StaticBuiltin, BuiltinParam, ParamName}, CallLocation, ArgsLike, parse::parse_builtin_call},
- error::Result, Context, typed::Typed,
+ Result, Context, typed::Typed,
parser::ExprLocation,
};
const PARAMS: &'static [BuiltinParam] = &[
crates/jrsonnet-stdlib/src/arrays.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/arrays.rs
+++ b/crates/jrsonnet-stdlib/src/arrays.rs
@@ -1,19 +1,19 @@
#![allow(non_snake_case)]
use jrsonnet_evaluator::{
- error::{ErrorKind::RuntimeError, Result},
+ bail,
function::{builtin, FuncVal},
- throw,
+ runtime_error,
typed::{BoundedI32, BoundedUsize, Either2, NativeFn, Typed},
- val::{equals, ArrValue, IndexableVal, StrValue},
- Either, IStr, Thunk, Val,
+ val::{equals, ArrValue, IndexableVal},
+ Either, IStr, Result, Thunk, Val,
};
pub(crate) fn eval_on_empty(on_empty: Option<Thunk<Val>>) -> Result<Val> {
if let Some(on_empty) = on_empty {
on_empty.evaluate()
} else {
- throw!("expected non-empty array")
+ bail!("expected non-empty array")
}
}
@@ -39,7 +39,7 @@
Either2::A(s) => Val::Str(StrValue::Flat(s.repeat(count).into())),
Either2::B(arr) => Val::Arr(
ArrValue::repeated(arr, count)
- .ok_or_else(|| RuntimeError("repeated length overflow".into()))?,
+ .ok_or_else(|| runtime_error!("repeated length overflow"))?,
),
})
}
@@ -73,7 +73,7 @@
match func(Either2::A(c.to_string()))? {
Val::Str(o) => write!(out, "{o}").unwrap(),
Val::Null => continue,
- _ => throw!("in std.join all items should be strings"),
+ _ => bail!("in std.join all items should be strings"),
};
}
Ok(IndexableVal::Str(out.into()))
@@ -89,7 +89,7 @@
}
}
Val::Null => continue,
- _ => throw!("in std.join all items should be arrays"),
+ _ => bail!("in std.join all items should be arrays"),
};
}
Ok(IndexableVal::Arr(out.into()))
@@ -154,7 +154,7 @@
} else if matches!(item, Val::Null) {
continue;
} else {
- throw!("in std.join all items should be arrays");
+ bail!("in std.join all items should be arrays");
}
}
@@ -175,7 +175,7 @@
} else if matches!(item, Val::Null) {
continue;
} else {
- throw!("in std.join all items should be strings");
+ bail!("in std.join all items should be strings");
}
}
crates/jrsonnet-stdlib/src/compat.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/compat.rs
+++ b/crates/jrsonnet-stdlib/src/compat.rs
@@ -1,6 +1,6 @@
use std::cmp::Ordering;
-use jrsonnet_evaluator::{error::Result, function::builtin, operator::evaluate_compare_op, Val};
+use jrsonnet_evaluator::{function::builtin, operator::evaluate_compare_op, Result, Val};
#[builtin]
#[allow(non_snake_case)]
crates/jrsonnet-stdlib/src/encoding.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/encoding.rs
+++ b/crates/jrsonnet-stdlib/src/encoding.rs
@@ -1,9 +1,9 @@
use base64::{engine::general_purpose::STANDARD, Engine};
use jrsonnet_evaluator::{
- error::{ErrorKind::RuntimeError, Result},
function::builtin,
+ runtime_error,
typed::{Either, Either2},
- IBytes, IStr,
+ IBytes, IStr, Result,
};
#[builtin]
@@ -13,9 +13,7 @@
#[builtin]
pub fn builtin_decode_utf8(arr: IBytes) -> Result<IStr> {
- Ok(arr
- .cast_str()
- .ok_or_else(|| RuntimeError("bad utf8".into()))?)
+ arr.cast_str().ok_or_else(|| runtime_error!("bad utf8"))
}
#[builtin]
@@ -31,7 +29,7 @@
pub fn builtin_base64_decode_bytes(str: IStr) -> Result<IBytes> {
Ok(STANDARD
.decode(str.as_bytes())
- .map_err(|e| RuntimeError(format!("invalid base64: {e}").into()))?
+ .map_err(|e| runtime_error!("invalid base64: {e}"))?
.as_slice()
.into())
}
@@ -40,6 +38,6 @@
pub fn builtin_base64_decode(str: IStr) -> Result<String> {
let bytes = STANDARD
.decode(str.as_bytes())
- .map_err(|e| RuntimeError(format!("invalid base64: {e}").into()))?;
- Ok(String::from_utf8(bytes).map_err(|_| RuntimeError("bad utf8".into()))?)
+ .map_err(|e| runtime_error!("invalid base64: {e}"))?;
+ Ok(String::from_utf8(bytes).map_err(|_| runtime_error!("bad utf8"))?)
}
crates/jrsonnet-stdlib/src/manifest/mod.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/manifest/mod.rs
+++ b/crates/jrsonnet-stdlib/src/manifest/mod.rs
@@ -2,10 +2,9 @@
mod yaml;
use jrsonnet_evaluator::{
- error::Result,
function::builtin,
manifest::{escape_string_json, JsonFormat},
- IStr, ObjValue, Val,
+ IStr, ObjValue, Result, Val,
};
pub use toml::TomlFormat;
pub use yaml::YamlFormat;
crates/jrsonnet-stdlib/src/manifest/toml.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/manifest/toml.rs
+++ b/crates/jrsonnet-stdlib/src/manifest/toml.rs
@@ -1,8 +1,8 @@
use std::borrow::Cow;
use jrsonnet_evaluator::{
+ bail,
manifest::{escape_string_json_buf, ManifestFormat},
- throw,
val::ArrValue,
IStr, ObjValue, Result, Val,
};
@@ -157,10 +157,10 @@
buf.push_str(" }");
}
Val::Null => {
- throw!("tried to manifest null")
+ bail!("tried to manifest null")
}
Val::Func(_) => {
- throw!("tried to manifest function")
+ bail!("tried to manifest function")
}
}
Ok(())
@@ -290,7 +290,7 @@
Val::Obj(obj) => {
manifest_table_internal(&obj, &mut Vec::new(), buf, &mut String::new(), self)
}
- _ => throw!("toml body should be object"),
+ _ => bail!("toml body should be object"),
}
}
}
crates/jrsonnet-stdlib/src/manifest/yaml.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/manifest/yaml.rs
+++ b/crates/jrsonnet-stdlib/src/manifest/yaml.rs
@@ -1,8 +1,9 @@
use std::{borrow::Cow, fmt::Write};
use jrsonnet_evaluator::{
+ bail,
manifest::{escape_string_json_buf, ManifestFormat},
- throw, Result, Val,
+ Result, Val,
};
pub struct YamlFormat<'s> {
@@ -219,7 +220,7 @@
}
}
}
- Val::Func(_) => throw!("tried to manifest function"),
+ Val::Func(_) => bail!("tried to manifest function"),
}
Ok(())
}
crates/jrsonnet-stdlib/src/misc.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/misc.rs
+++ b/crates/jrsonnet-stdlib/src/misc.rs
@@ -1,10 +1,10 @@
use std::{cell::RefCell, rc::Rc};
use jrsonnet_evaluator::{
+ bail,
error::{ErrorKind::*, Result},
function::{builtin, ArgLike, CallLocation, FuncVal},
manifest::JsonFormat,
- throw,
typed::{Either2, Either4},
val::{equals, ArrValue},
Context, Either, IStr, ObjValue, Thunk, Val,
@@ -103,7 +103,7 @@
true
}
}
- _ => throw!("both arguments should be of the same type"),
+ _ => bail!("both arguments should be of the same type"),
})
}
@@ -129,6 +129,6 @@
true
}
}
- _ => throw!("both arguments should be of the same type"),
+ _ => bail!("both arguments should be of the same type"),
})
}
crates/jrsonnet-stdlib/src/operator.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/operator.rs
+++ b/crates/jrsonnet-stdlib/src/operator.rs
@@ -2,13 +2,12 @@
//! However, in our case we instead implement them in native, and implement native functions on top of core for backwards compatibility
use jrsonnet_evaluator::{
- error::Result,
function::builtin,
operator::evaluate_mod_op,
stdlib::std_format,
typed::{Either, Either2},
- val::{equals, primitive_equals, StrValue},
- IStr, Val,
+ val::{equals, primitive_equals},
+ IStr, Result, Val,
};
#[builtin]
crates/jrsonnet-stdlib/src/parse.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/parse.rs
+++ b/crates/jrsonnet-stdlib/src/parse.rs
@@ -1,14 +1,10 @@
-use jrsonnet_evaluator::{
- error::{ErrorKind::RuntimeError, Result},
- function::builtin,
- IStr, Val,
-};
+use jrsonnet_evaluator::{function::builtin, runtime_error, IStr, Result, Val};
use serde::Deserialize;
#[builtin]
pub fn builtin_parse_json(str: IStr) -> Result<Val> {
- let value: Val = serde_json::from_str(&str)
- .map_err(|e| RuntimeError(format!("failed to parse json: {e}").into()))?;
+ let value: Val =
+ serde_json::from_str(&str).map_err(|e| runtime_error!("failed to parse json: {e}"))?;
Ok(value)
}
@@ -21,8 +17,8 @@
);
let mut out = vec![];
for item in value {
- let val = Val::deserialize(item)
- .map_err(|e| RuntimeError(format!("failed to parse yaml: {e}").into()))?;
+ let val =
+ Val::deserialize(item).map_err(|e| runtime_error!("failed to parse yaml: {e}"))?;
out.push(val);
}
Ok(if out.is_empty() {
crates/jrsonnet-stdlib/src/sort.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/sort.rs
+++ b/crates/jrsonnet-stdlib/src/sort.rs
@@ -3,12 +3,11 @@
use std::cmp::Ordering;
use jrsonnet_evaluator::{
- error::Result,
+ bail,
function::{builtin, FuncVal},
operator::evaluate_compare_op,
- throw,
val::{equals, ArrValue},
- Thunk, Val,
+ Result, Thunk, Val,
};
use jrsonnet_parser::BinaryOpType;
@@ -44,7 +43,7 @@
(Val::Num(_), SortKeyType::Unknown) => sort_type = SortKeyType::Number,
(Val::Str(_), SortKeyType::String) | (Val::Num(_), SortKeyType::Number) => {}
(Val::Str(_) | Val::Num(_), _) => {
- throw!("sort elements should have the same types")
+ bail!("sort elements should have the same types")
}
_ => {}
}
crates/jrsonnet-stdlib/src/strings.rsdiffbeforeafterboth--- a/crates/jrsonnet-stdlib/src/strings.rs
+++ b/crates/jrsonnet-stdlib/src/strings.rs
@@ -1,7 +1,7 @@
use jrsonnet_evaluator::{
+ bail,
error::{ErrorKind::*, Result},
function::builtin,
- throw,
typed::{Either2, M1},
val::{ArrValue, StrValue},
Either, IStr, Val,
@@ -91,13 +91,13 @@
pub fn builtin_parse_int(str: IStr) -> Result<f64> {
if let Some(raw) = str.strip_prefix('-') {
if raw.is_empty() {
- throw!("integer only consists of a minus")
+ bail!("integer only consists of a minus")
}
parse_nat::<10>(raw).map(|value| -value)
} else {
if str.is_empty() {
- throw!("empty integer")
+ bail!("empty integer")
}
parse_nat::<10>(str.as_str())
@@ -107,7 +107,7 @@
#[builtin]
pub fn builtin_parse_octal(str: IStr) -> Result<f64> {
if str.is_empty() {
- throw!("empty octal integer");
+ bail!("empty octal integer");
}
parse_nat::<8>(str.as_str())
@@ -116,7 +116,7 @@
#[builtin]
pub fn builtin_parse_hex(str: IStr) -> Result<f64> {
if str.is_empty() {
- throw!("empty hexadecimal integer");
+ bail!("empty hexadecimal integer");
}
parse_nat::<16>(str.as_str())
@@ -156,7 +156,7 @@
if digit < BASE {
Ok(base * aggregate + digit as f64)
} else {
- throw!("{raw:?} is not a base {BASE} integer",);
+ bail!("{raw:?} is not a base {BASE} integer");
}
})
}
@@ -164,13 +164,14 @@
#[cfg(feature = "exp-bigint")]
#[builtin]
pub fn builtin_bigint(v: Either![f64, IStr]) -> Result<Val> {
+ use jrsonnet_evaluator::runtime_error;
use Either2::*;
Ok(match v {
A(a) => Val::BigInt(Box::new((a as i64).into())),
B(b) => Val::BigInt(Box::new(
b.as_str()
.parse()
- .map_err(|e| RuntimeError(format!("bad bigint: {e}").into()))?,
+ .map_err(|e| runtime_error!("bad bigint: {e}"))?,
)),
})
}
tests/tests/as_native.rsdiffbeforeafterboth--- a/tests/tests/as_native.rs
+++ b/tests/tests/as_native.rs
@@ -1,4 +1,4 @@
-use jrsonnet_evaluator::{error::Result, State};
+use jrsonnet_evaluator::{Result, State};
use jrsonnet_stdlib::StateExt;
mod common;
tests/tests/builtin.rsdiffbeforeafterboth--- a/tests/tests/builtin.rs
+++ b/tests/tests/builtin.rs
@@ -1,10 +1,9 @@
mod common;
use jrsonnet_evaluator::{
- error::Result,
function::{builtin, builtin::Builtin, CallLocation, FuncVal},
typed::Typed,
- ContextBuilder, State, Thunk, Val,
+ ContextBuilder, Result, State, Thunk, Val,
};
use jrsonnet_stdlib::StateExt;
tests/tests/common.rsdiffbeforeafterboth--- a/tests/tests/common.rs
+++ b/tests/tests/common.rs
@@ -1,7 +1,7 @@
use jrsonnet_evaluator::{
- error::Result,
+ bail,
function::{builtin, FuncVal},
- throw, ObjValueBuilder, State, Thunk, Val,
+ ObjValueBuilder, Result, State, Thunk, Val,
};
#[macro_export]
@@ -10,7 +10,7 @@
let a = &$a;
let b = &$b;
if a != b {
- ::jrsonnet_evaluator::throw!("assertion failed: a != b\na={:#?}\nb={:#?}", a, b)
+ ::jrsonnet_evaluator::bail!("assertion failed: a != b\na={a:#?}\nb={b:#?}")
}
}};
}
@@ -19,7 +19,7 @@
macro_rules! ensure {
($v:expr $(,)?) => {
if !$v {
- ::jrsonnet_evaluator::throw!("assertion failed: {}", stringify!($v))
+ ::jrsonnet_evaluator::bail!("assertion failed: {}", stringify!($v))
}
};
}
@@ -29,7 +29,7 @@
($a:expr, $b:expr) => {{
if !::jrsonnet_evaluator::val::equals(&$a.clone(), &$b.clone())? {
use ::jrsonnet_evaluator::manifest::JsonFormat;
- ::jrsonnet_evaluator::throw!(
+ ::jrsonnet_evaluator::bail!(
"assertion failed: a != b\na={:#?}\nb={:#?}",
$a.manifest(JsonFormat::default())?,
$b.manifest(JsonFormat::default())?,
@@ -42,7 +42,7 @@
fn assert_throw(lazy: Thunk<Val>, message: String) -> Result<bool> {
match lazy.evaluate() {
Ok(_) => {
- throw!("expected argument to throw on evaluation, but it returned instead")
+ bail!("expected argument to throw on evaluation, but it returned instead")
}
Err(e) => {
let error = format!("{}", e.error());
tests/tests/sanity.rsdiffbeforeafterboth--- a/tests/tests/sanity.rs
+++ b/tests/tests/sanity.rs
@@ -1,8 +1,7 @@
use jrsonnet_evaluator::{
- error::Result,
- throw,
+ bail,
trace::{CompactFormat, TraceFormat},
- State, Val,
+ Result, State, Val,
};
use jrsonnet_stdlib::StateExt;
@@ -29,14 +28,14 @@
{
let Err(e) = s.evaluate_snippet("snip".to_owned(), "assert 1 == 2: 'fail'; null") else {
- throw!("assertion should fail");
+ bail!("assertion should fail");
};
let e = trace_format.format(&e).unwrap();
ensure!(e.starts_with("assert failed: fail\n"));
}
{
let Err(e) = s.evaluate_snippet("snip".to_owned(), "std.assertEqual(1, 2)") else {
- throw!("assertion should fail")
+ bail!("assertion should fail")
};
let e = trace_format.format(&e).unwrap();
ensure!(e.starts_with("runtime error: Assertion failed. 1 != 2"))
tests/tests/typed_obj.rsdiffbeforeafterboth--- a/tests/tests/typed_obj.rs
+++ b/tests/tests/typed_obj.rs
@@ -2,7 +2,7 @@
use std::fmt::Debug;
-use jrsonnet_evaluator::{error::Result, typed::Typed, State};
+use jrsonnet_evaluator::{typed::Typed, Result, State};
use jrsonnet_stdlib::StateExt;
#[derive(Clone, Typed, PartialEq, Debug)]