difftreelog
Merge pull request #45 from CertainLach/gc-v2
in: master
Implement tracing Gc with rust-gc
35 files changed
Cargo.lockdiffbeforeafterboth--- a/Cargo.lock
+++ b/Cargo.lock
@@ -100,12 +100,6 @@
]
[[package]]
-name = "closure"
-version = "0.3.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "d6173fd61b610d15a7566dd7b7620775627441c4ab9dac8906e17cb93a24b782"
-
-[[package]]
name = "hashbrown"
version = "0.9.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
@@ -164,6 +158,7 @@
dependencies = [
"clap",
"jrsonnet-evaluator",
+ "jrsonnet-gc",
"jrsonnet-parser",
]
@@ -175,7 +170,7 @@
"anyhow",
"base64",
"bincode",
- "closure",
+ "jrsonnet-gc",
"jrsonnet-interner",
"jrsonnet-parser",
"jrsonnet-stdlib",
@@ -189,9 +184,31 @@
]
[[package]]
+name = "jrsonnet-gc"
+version = "0.4.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "68da8bc2f00117b1373bb8877af03b1d391e4c4800e6585d7279e5b99c919dde"
+dependencies = [
+ "jrsonnet-gc-derive",
+]
+
+[[package]]
+name = "jrsonnet-gc-derive"
+version = "0.4.1"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "adcba9c387b64b054f06cc4d724905296e21edeeb7506847f3299117a2d92d12"
+dependencies = [
+ "proc-macro2",
+ "quote",
+ "syn",
+ "synstructure",
+]
+
+[[package]]
name = "jrsonnet-interner"
version = "0.3.8"
dependencies = [
+ "jrsonnet-gc",
"rustc-hash",
"serde",
]
@@ -200,6 +217,7 @@
name = "jrsonnet-parser"
version = "0.3.8"
dependencies = [
+ "jrsonnet-gc",
"jrsonnet-interner",
"jrsonnet-stdlib",
"peg",
@@ -215,6 +233,7 @@
name = "jrsonnet-types"
version = "0.3.8"
dependencies = [
+ "jrsonnet-gc",
"peg",
]
@@ -223,6 +242,7 @@
version = "0.3.8"
dependencies = [
"jrsonnet-evaluator",
+ "jrsonnet-gc",
"jrsonnet-parser",
]
@@ -405,6 +425,18 @@
]
[[package]]
+name = "synstructure"
+version = "0.12.4"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "b834f2d66f734cb897113e34aaff2f1ab4719ca946f9a7358dba8f8064148701"
+dependencies = [
+ "proc-macro2",
+ "quote",
+ "syn",
+ "unicode-xid",
+]
+
+[[package]]
name = "termcolor"
version = "1.1.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
bindings/jsonnet/Cargo.tomldiffbeforeafterboth--- a/bindings/jsonnet/Cargo.toml
+++ b/bindings/jsonnet/Cargo.toml
@@ -10,6 +10,7 @@
[dependencies]
jrsonnet-evaluator = { path = "../../crates/jrsonnet-evaluator", version = "0.3.8" }
jrsonnet-parser = { path = "../../crates/jrsonnet-parser", version = "0.3.8" }
+jrsonnet-gc = { version = "0.4.2", features = ["derive"] }
[lib]
crate-type = ["cdylib"]
bindings/jsonnet/src/native.rsdiffbeforeafterboth--- a/bindings/jsonnet/src/native.rs
+++ b/bindings/jsonnet/src/native.rs
@@ -1,8 +1,14 @@
-use jrsonnet_evaluator::{error::Error, native::NativeCallback, EvaluationState, Val};
+use jrsonnet_evaluator::{
+ error::{Error, LocError},
+ native::{NativeCallback, NativeCallbackHandler},
+ EvaluationState, Val,
+};
+use jrsonnet_gc::{unsafe_empty_trace, Finalize, Gc, Trace};
use jrsonnet_parser::{Param, ParamsDesc};
use std::{
ffi::{c_void, CStr},
os::raw::{c_char, c_int},
+ path::Path,
rc::Rc,
};
@@ -12,6 +18,39 @@
success: *mut c_int,
) -> *mut Val;
+struct JsonnetNativeCallbackHandler {
+ ctx: *const c_void,
+ cb: JsonnetNativeCallback,
+}
+impl Finalize for JsonnetNativeCallbackHandler {}
+unsafe impl Trace for JsonnetNativeCallbackHandler {
+ unsafe_empty_trace!();
+}
+impl NativeCallbackHandler for JsonnetNativeCallbackHandler {
+ fn call(&self, _from: Option<Rc<Path>>, args: &[Val]) -> Result<Val, LocError> {
+ let mut n_args = Vec::new();
+ for a in args {
+ n_args.push(Some(Box::new(a.clone())));
+ }
+ n_args.push(None);
+ let mut success = 1;
+ let v = unsafe {
+ (self.cb)(
+ self.ctx,
+ &n_args as *const _ as *const *const Val,
+ &mut success,
+ )
+ };
+ let v = unsafe { *Box::from_raw(v) };
+ if success == 1 {
+ Ok(v)
+ } else {
+ let e = v.try_cast_str("native error").expect("error msg");
+ Err(Error::RuntimeError(e).into())
+ }
+ }
+}
+
/// # Safety
#[no_mangle]
pub unsafe extern "C" fn jsonnet_native_callback(
@@ -35,21 +74,9 @@
vm.add_native(
name,
- Rc::new(NativeCallback::new(params, move |_caller, args| {
- let mut n_args = Vec::new();
- for a in args {
- n_args.push(Some(Box::new(a.clone())));
- }
- n_args.push(None);
- let mut success = 1;
- let v = cb(ctx, &n_args as *const _ as *const *const Val, &mut success);
- let v = *Box::from_raw(v);
- if success == 1 {
- Ok(v)
- } else {
- let e = v.try_cast_str("native error").expect("error msg");
- Err(Error::RuntimeError(e).into())
- }
- })),
+ Gc::new(NativeCallback::new(
+ params,
+ Box::new(JsonnetNativeCallbackHandler { ctx, cb }),
+ )),
)
}
bindings/jsonnet/src/val_make.rsdiffbeforeafterboth--- a/bindings/jsonnet/src/val_make.rs
+++ b/bindings/jsonnet/src/val_make.rs
@@ -1,10 +1,10 @@
//! Create values in VM
use jrsonnet_evaluator::{ArrValue, EvaluationState, ObjValue, Val};
+use jrsonnet_gc::Gc;
use std::{
ffi::CStr,
os::raw::{c_char, c_double, c_int},
- rc::Rc,
};
/// # Safety
@@ -38,7 +38,7 @@
#[no_mangle]
pub extern "C" fn jsonnet_json_make_array(_vm: &EvaluationState) -> *mut Val {
- Box::into_raw(Box::new(Val::Arr(ArrValue::Eager(Rc::new(Vec::new())))))
+ Box::into_raw(Box::new(Val::Arr(ArrValue::Eager(Gc::new(Vec::new())))))
}
#[no_mangle]
bindings/jsonnet/src/val_modify.rsdiffbeforeafterboth--- a/bindings/jsonnet/src/val_modify.rs
+++ b/bindings/jsonnet/src/val_modify.rs
@@ -3,8 +3,9 @@
//! In jrsonnet every value is immutable, and this code is probally broken
use jrsonnet_evaluator::{ArrValue, EvaluationState, LazyBinding, LazyVal, ObjMember, Val};
+use jrsonnet_gc::Gc;
use jrsonnet_parser::Visibility;
-use std::{ffi::CStr, os::raw::c_char, rc::Rc};
+use std::{ffi::CStr, os::raw::c_char};
/// # Safety
///
@@ -22,7 +23,7 @@
new.push(item);
}
new.push(LazyVal::new_resolved(val.clone()));
- *arr = Val::Arr(ArrValue::Lazy(Rc::new(new)));
+ *arr = Val::Arr(ArrValue::Lazy(Gc::new(new)));
}
_ => panic!("should receive array"),
}
cmds/jrsonnet/Cargo.tomldiffbeforeafterboth--- a/cmds/jrsonnet/Cargo.toml
+++ b/cmds/jrsonnet/Cargo.toml
@@ -8,15 +8,14 @@
publish = false
[features]
-default = []
+default = ["mimalloc"]
# Use mimalloc as allocator
-mimalloc = []
+mimalloc = ["mimallocator"]
[dependencies]
jrsonnet-evaluator = { path = "../../crates/jrsonnet-evaluator", version = "0.3.8" }
jrsonnet-parser = { path = "../../crates/jrsonnet-parser", version = "0.3.8" }
jrsonnet-cli = { path = "../../crates/jrsonnet-cli", version = "0.3.8" }
-# TODO: Fix mimalloc compile errors, and use them
mimallocator = { version = "0.1.3", optional = true }
thiserror = "1.0"
cmds/jrsonnet/src/main.rsdiffbeforeafterboth--- a/cmds/jrsonnet/src/main.rs
+++ b/cmds/jrsonnet/src/main.rs
@@ -1,5 +1,5 @@
use clap::{AppSettings, Clap, IntoApp};
-use jrsonnet_cli::{ConfigureState, GeneralOpts, InputOpts, ManifestOpts, OutputOpts};
+use jrsonnet_cli::{ConfigureState, GcOpts, GeneralOpts, InputOpts, ManifestOpts, OutputOpts};
use jrsonnet_evaluator::{error::LocError, EvaluationState, ManifestFormat};
use std::{
fs::{create_dir_all, File},
@@ -61,6 +61,8 @@
output: OutputOpts,
#[clap(flatten)]
debug: DebugOpts,
+ #[clap(flatten)]
+ gc: GcOpts,
}
fn main() {
@@ -114,6 +116,7 @@
}
fn main_catch(opts: Opts) -> bool {
+ let _printer = opts.gc.stats_printer();
let state = EvaluationState::default();
if let Err(e) = main_real(&state, opts) {
if let Error::Evaluation(e) = e {
@@ -127,6 +130,7 @@
}
fn main_real(state: &EvaluationState, opts: Opts) -> Result<(), Error> {
+ opts.gc.configure_global();
opts.general.configure(&state)?;
opts.manifest.configure(&state)?;
crates/jrsonnet-cli/Cargo.tomldiffbeforeafterboth--- a/crates/jrsonnet-cli/Cargo.toml
+++ b/crates/jrsonnet-cli/Cargo.toml
@@ -10,6 +10,7 @@
[dependencies]
jrsonnet-evaluator = { path = "../../crates/jrsonnet-evaluator", version = "0.3.6", features = ["explaining-traces"] }
jrsonnet-parser = { path = "../../crates/jrsonnet-parser", version = "0.3.6" }
+jrsonnet-gc = { version = "0.4.2", features = ["derive", "unstable-config", "unstable-stats"] }
[dependencies.clap]
git = "https://github.com/clap-rs/clap"
crates/jrsonnet-cli/src/lib.rsdiffbeforeafterboth--- a/crates/jrsonnet-cli/src/lib.rs
+++ b/crates/jrsonnet-cli/src/lib.rs
@@ -95,3 +95,55 @@
Ok(())
}
}
+
+#[derive(Clap)]
+#[clap(help_heading = "GARBAGE COLLECTION")]
+pub struct GcOpts {
+ /// Min bytes allocated to start garbage collection
+ #[clap(long, default_value = "20000000")]
+ gc_initial_threshold: usize,
+ /// How much heap should grow after unsuccessful garbage collection
+ #[clap(long)]
+ gc_used_space_ratio: Option<f64>,
+ /// Do not skip gc on exit
+ #[clap(long)]
+ gc_collect_on_exit: bool,
+ /// Print gc stats before exit
+ #[clap(long)]
+ gc_print_stats: bool,
+ /// Force garbage collection before printing stats
+ /// Useful for checking for memory leaks
+ /// Does nothing useless --gc-print-stats is specified
+ #[clap(long)]
+ gc_collect_before_printing_stats: bool,
+}
+impl GcOpts {
+ pub fn stats_printer(&self) -> Option<GcStatsPrinter> {
+ self.gc_print_stats
+ .then(|| GcStatsPrinter(self.gc_collect_before_printing_stats))
+ }
+ pub fn configure_global(&self) {
+ jrsonnet_gc::configure(|config| {
+ config.leak_on_drop = !self.gc_collect_on_exit;
+ config.threshold = self.gc_initial_threshold;
+ if let Some(used_space_ratio) = self.gc_used_space_ratio {
+ config.used_space_ratio = used_space_ratio;
+ }
+ });
+ }
+}
+pub struct GcStatsPrinter(bool);
+impl Drop for GcStatsPrinter {
+ fn drop(&mut self) {
+ if self.0 {
+ jrsonnet_gc::force_collect()
+ }
+ eprintln!("=== GC STATS ===");
+ jrsonnet_gc::configure(|c| {
+ eprintln!("Final threshold: {:?}", c.threshold);
+ });
+ let stats = jrsonnet_gc::stats();
+ eprintln!("Collections performed: {}", stats.collections_performed);
+ eprintln!("Bytes still allocated: {}", stats.bytes_allocated);
+ }
+}
crates/jrsonnet-evaluator/Cargo.tomldiffbeforeafterboth--- a/crates/jrsonnet-evaluator/Cargo.toml
+++ b/crates/jrsonnet-evaluator/Cargo.toml
@@ -30,13 +30,12 @@
jrsonnet-types = { path = "../jrsonnet-types", version = "0.3.8" }
pathdiff = "0.2.0"
-closure = "0.3.0"
-
md5 = "0.7.0"
base64 = "0.13.0"
rustc-hash = "1.1.0"
thiserror = "1.0"
+jrsonnet-gc = { version = "0.4.2", features = ["derive"] }
[dependencies.anyhow]
version = "1.0"
crates/jrsonnet-evaluator/README.mddiffbeforeafterboth--- a/crates/jrsonnet-evaluator/README.md
+++ b/crates/jrsonnet-evaluator/README.md
@@ -6,9 +6,6 @@
jsonnet stdlib is embedded into evaluator, but there is different modes for this:
-- `codegenerated-stdlib`
- - generates source code for reproducing stdlib AST ([Example](https://gist.githubusercontent.com/CertainLach/7b3149df556f3406f5e9368aaa9f32ec/raw/0c80d8ab9aa7b9288c6219a2779cb2ab37287669/a.rs))
- - fastest on interpretation, slowest on compilation (it takes more than 5 minutes to optimize them by llvm)
- `serialized-stdlib`
- serializes standard library AST using serde
- slower than `codegenerated-stdlib` at runtime, but have no compilation speed penality
@@ -23,8 +20,6 @@
Can also be run via `cargo bench`
```markdown
-# codegenerated-stdlib
-test tests::bench_codegen ... bench: 401,696 ns/iter (+/- 38,521)
# serialized-stdlib
test tests::bench_serialize ... bench: 1,763,999 ns/iter (+/- 76,211)
# none
@@ -34,7 +29,3 @@
## Intrinsics
Some functions from stdlib are implemented as intrinsics
-
-### Intrinsic handling
-
-If indexed jsonnet object has field '__intrinsic_namespace__' of type 'string', then any not found field/method is resolved as `Val::Intrinsic(__intrinsic_namespace__, name)`
crates/jrsonnet-evaluator/src/builtin/format.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/builtin/format.rs
+++ b/crates/jrsonnet-evaluator/src/builtin/format.rs
@@ -2,11 +2,13 @@
#![allow(clippy::too_many_arguments)]
use crate::{error::Error::*, throw, LocError, ObjValue, Result, Val};
+use jrsonnet_gc::Trace;
use jrsonnet_interner::IStr;
use jrsonnet_types::ValType;
use thiserror::Error;
-#[derive(Debug, Clone, Error)]
+#[derive(Debug, Clone, Error, Trace)]
+#[trivially_drop]
pub enum FormatError {
#[error("truncated format code")]
TruncatedFormatCode,
crates/jrsonnet-evaluator/src/builtin/manifest.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/builtin/manifest.rs
+++ b/crates/jrsonnet-evaluator/src/builtin/manifest.rs
@@ -126,6 +126,7 @@
buf.push('}');
}
Val::Func(_) => throw!(RuntimeError("tried to manifest function".into())),
+ Val::DebugGcTraceValue(v) => manifest_json_ex_buf(&v.value, buf, cur_padding, options)?,
};
Ok(())
}
crates/jrsonnet-evaluator/src/builtin/mod.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/builtin/mod.rs
+++ b/crates/jrsonnet-evaluator/src/builtin/mod.rs
@@ -1,10 +1,11 @@
use crate::{
equals,
error::{Error::*, Result},
- parse_args, primitive_equals, push, throw, with_state, ArrValue, Context, EvaluationState,
- FuncVal, LazyVal, Val,
+ parse_args, primitive_equals, push, throw, with_state, ArrValue, Context, DebugGcTraceValue,
+ EvaluationState, FuncVal, LazyVal, Val,
};
use format::{format_arr, format_obj};
+use jrsonnet_gc::Gc;
use jrsonnet_interner::IStr;
use jrsonnet_parser::{ArgsDesc, BinaryOpType, ExprLocation};
use jrsonnet_types::ty;
@@ -68,6 +69,8 @@
("md5".into(), builtin_md5),
("base64".into(), builtin_base64),
("trace".into(), builtin_trace),
+ ("gc".into(), builtin_gc),
+ ("gcTrace".into(), builtin_gc_trace),
("join".into(), builtin_join),
("escapeStringJson".into(), builtin_escape_string_json),
("manifestJsonEx".into(), builtin_manifest_json_ex),
@@ -301,7 +304,7 @@
parse_args!(context, "native", args, 1, [
0, x: ty!(string) => Val::Str;
], {
- Ok(with_state(|s| s.settings().ext_natives.get(&x).cloned()).map(|v| Val::Func(Rc::new(FuncVal::NativeExt(x.clone(), v)))).ok_or(UndefinedExternalFunction(x))?)
+ Ok(with_state(|s| s.settings().ext_natives.get(&x).cloned()).map(|v| Val::Func(Gc::new(FuncVal::NativeExt(x.clone(), v)))).ok_or(UndefinedExternalFunction(x))?)
})
}
@@ -446,6 +449,27 @@
})
}
+fn builtin_gc(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {
+ parse_args!(context, "gc", args, 1, [
+ 0, rest: ty!(any);
+ ], {
+ println!("GC start");
+ jrsonnet_gc::force_collect();
+ println!("GC done");
+
+ Ok(rest)
+ })
+}
+
+fn builtin_gc_trace(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {
+ parse_args!(context, "gcTrace", args, 2, [
+ 0, name: ty!(string) => Val::Str;
+ 1, rest: ty!(any);
+ ], {
+ Ok(DebugGcTraceValue::create(name, rest))
+ })
+}
+
fn builtin_base64(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {
parse_args!(context, "base64", args, 1, [
0, input: ty!((string | (Array<number>)));
crates/jrsonnet-evaluator/src/builtin/sort.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/builtin/sort.rs
+++ b/crates/jrsonnet-evaluator/src/builtin/sort.rs
@@ -2,9 +2,9 @@
error::{Error, LocError, Result},
throw, Context, FuncVal, Val,
};
-use std::rc::Rc;
+use jrsonnet_gc::{Finalize, Gc, Trace};
-#[derive(Debug, Clone, thiserror::Error)]
+#[derive(Debug, Clone, thiserror::Error, Trace, Finalize)]
pub enum SortError {
#[error("sort key should be string or number")]
SortKeyShouldBeStringOrNumber,
@@ -59,13 +59,13 @@
Ok(sort_type)
}
-pub fn sort(ctx: Context, mut values: Rc<Vec<Val>>, key_getter: &FuncVal) -> Result<Rc<Vec<Val>>> {
+pub fn sort(ctx: Context, values: Gc<Vec<Val>>, key_getter: &FuncVal) -> Result<Gc<Vec<Val>>> {
if values.len() <= 1 {
return Ok(values);
}
if key_getter.is_ident() {
- let mvalues = Rc::make_mut(&mut values);
- let sort_type = get_sort_type(mvalues, |k| k)?;
+ let mut mvalues = (*values).clone();
+ let sort_type = get_sort_type(&mut mvalues, |k| k)?;
match sort_type {
SortKeyType::Number => mvalues.sort_by_key(|v| match v {
Val::Num(n) => NonNaNf64(*n),
@@ -77,7 +77,7 @@
}),
SortKeyType::Unknown => unreachable!(),
};
- Ok(values)
+ Ok(Gc::new(mvalues))
} else {
let mut vk = Vec::with_capacity(values.len());
for value in values.iter() {
@@ -98,6 +98,6 @@
}),
SortKeyType::Unknown => unreachable!(),
};
- Ok(Rc::new(vk.into_iter().map(|v| v.0).collect()))
+ Ok(Gc::new(vk.into_iter().map(|v| v.0).collect()))
}
}
crates/jrsonnet-evaluator/src/ctx.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/ctx.rs
+++ b/crates/jrsonnet-evaluator/src/ctx.rs
@@ -1,13 +1,15 @@
use crate::{
- error::Error::*, map::LayeredHashMap, resolved_lazy_val, FutureWrapper, LazyBinding, LazyVal,
- ObjValue, Result, Val,
+ error::Error::*, map::LayeredHashMap, FutureWrapper, LazyBinding, LazyVal, ObjValue, Result,
+ Val,
};
+use jrsonnet_gc::{Gc, Trace};
use jrsonnet_interner::IStr;
use rustc_hash::FxHashMap;
+use std::fmt::Debug;
use std::hash::BuildHasherDefault;
-use std::{fmt::Debug, rc::Rc};
-#[derive(Clone)]
+#[derive(Clone, Trace)]
+#[trivially_drop]
pub struct ContextCreator(pub Context, pub FutureWrapper<FxHashMap<IStr, LazyBinding>>);
impl ContextCreator {
pub fn create(&self, this: Option<ObjValue>, super_obj: Option<ObjValue>) -> Result<Context> {
@@ -20,23 +22,23 @@
}
}
+#[derive(Trace)]
+#[trivially_drop]
struct ContextInternals {
dollar: Option<ObjValue>,
this: Option<ObjValue>,
super_obj: Option<ObjValue>,
- bindings: LayeredHashMap<LazyVal>,
+ bindings: LayeredHashMap,
}
impl Debug for ContextInternals {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
- f.debug_struct("Context")
- .field("this", &self.this.as_ref().map(|e| Rc::as_ptr(&e.0)))
- .field("bindings", &self.bindings)
- .finish()
+ f.debug_struct("Context").finish()
}
}
-#[derive(Debug, Clone)]
-pub struct Context(Rc<ContextInternals>);
+#[derive(Debug, Clone, Trace)]
+#[trivially_drop]
+pub struct Context(Gc<ContextInternals>);
impl Context {
pub fn new_future() -> FutureWrapper<Self> {
FutureWrapper::new()
@@ -55,7 +57,7 @@
}
pub fn new() -> Self {
- Self(Rc::new(ContextInternals {
+ Self(Gc::new(ContextInternals {
dollar: None,
this: None,
super_obj: None,
@@ -81,7 +83,7 @@
pub fn with_var(self, name: IStr, value: Val) -> Self {
let mut new_bindings =
FxHashMap::with_capacity_and_hasher(1, BuildHasherDefault::default());
- new_bindings.insert(name, resolved_lazy_val!(value));
+ new_bindings.insert(name, LazyVal::new_resolved(value));
self.extend(new_bindings, None, None, None)
}
@@ -96,40 +98,21 @@
new_this: Option<ObjValue>,
new_super_obj: Option<ObjValue>,
) -> Self {
- match Rc::try_unwrap(self.0) {
- Ok(mut ctx) => {
- // Extended context aren't used by anything else, we can freely mutate it without cloning
- if let Some(dollar) = new_dollar {
- ctx.dollar = Some(dollar);
- }
- if let Some(this) = new_this {
- ctx.this = Some(this);
- }
- if let Some(super_obj) = new_super_obj {
- ctx.super_obj = Some(super_obj);
- }
- if !new_bindings.is_empty() {
- ctx.bindings = ctx.bindings.extend(new_bindings);
- }
- Self(Rc::new(ctx))
- }
- Err(ctx) => {
- let dollar = new_dollar.or_else(|| ctx.dollar.clone());
- let this = new_this.or_else(|| ctx.this.clone());
- let super_obj = new_super_obj.or_else(|| ctx.super_obj.clone());
- let bindings = if new_bindings.is_empty() {
- ctx.bindings.clone()
- } else {
- ctx.bindings.clone().extend(new_bindings)
- };
- Self(Rc::new(ContextInternals {
- dollar,
- this,
- super_obj,
- bindings,
- }))
- }
- }
+ let ctx = &self.0;
+ let dollar = new_dollar.or_else(|| ctx.dollar.clone());
+ let this = new_this.or_else(|| ctx.this.clone());
+ let super_obj = new_super_obj.or_else(|| ctx.super_obj.clone());
+ let bindings = if new_bindings.is_empty() {
+ ctx.bindings.clone()
+ } else {
+ ctx.bindings.clone().extend(new_bindings)
+ };
+ Self(Gc::new(ContextInternals {
+ dollar,
+ this,
+ super_obj,
+ bindings,
+ }))
}
pub fn extend_bound(self, new_bindings: FxHashMap<IStr, LazyVal>) -> Self {
let new_this = self.0.this.clone();
@@ -166,22 +149,6 @@
impl PartialEq for Context {
fn eq(&self, other: &Self) -> bool {
- Rc::ptr_eq(&self.0, &other.0)
- }
-}
-
-#[cfg(feature = "unstable")]
-#[derive(Debug, Clone)]
-pub struct WeakContext(std::rc::Weak<ContextInternals>);
-#[cfg(feature = "unstable")]
-impl WeakContext {
- pub fn upgrade(&self) -> Context {
- Context(self.0.upgrade().expect("context is removed"))
- }
-}
-#[cfg(feature = "unstable")]
-impl PartialEq for WeakContext {
- fn eq(&self, other: &Self) -> bool {
- self.0.ptr_eq(&other.0)
+ Gc::ptr_eq(&self.0, &other.0)
}
}
crates/jrsonnet-evaluator/src/dynamic.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/dynamic.rs
+++ b/crates/jrsonnet-evaluator/src/dynamic.rs
@@ -1,23 +1,24 @@
-use std::{cell::RefCell, rc::Rc};
+use jrsonnet_gc::{Gc, GcCell, Trace};
-#[derive(Clone)]
-pub struct FutureWrapper<V>(pub Rc<RefCell<Option<V>>>);
-impl<T> FutureWrapper<T> {
+#[derive(Clone, Trace)]
+#[trivially_drop]
+pub struct FutureWrapper<V: Trace + 'static>(pub Gc<GcCell<Option<V>>>);
+impl<T: Trace + 'static> FutureWrapper<T> {
pub fn new() -> Self {
- Self(Rc::new(RefCell::new(None)))
+ Self(Gc::new(GcCell::new(None)))
}
pub fn fill(self, value: T) {
assert!(self.0.borrow().is_none(), "wrapper is filled already");
self.0.borrow_mut().replace(value);
}
}
-impl<T: Clone> FutureWrapper<T> {
+impl<T: Clone + Trace + 'static> FutureWrapper<T> {
pub fn unwrap(&self) -> T {
self.0.borrow().as_ref().cloned().unwrap()
}
}
-impl<T> Default for FutureWrapper<T> {
+impl<T: Trace + 'static> Default for FutureWrapper<T> {
fn default() -> Self {
Self::new()
}
crates/jrsonnet-evaluator/src/error.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/error.rs
+++ b/crates/jrsonnet-evaluator/src/error.rs
@@ -2,6 +2,7 @@
builtin::{format::FormatError, sort::SortError},
typed::TypeLocError,
};
+use jrsonnet_gc::Trace;
use jrsonnet_interner::IStr;
use jrsonnet_parser::{BinaryOpType, ExprLocation, UnaryOpType};
use jrsonnet_types::ValType;
@@ -11,7 +12,8 @@
};
use thiserror::Error;
-#[derive(Error, Debug, Clone)]
+#[derive(Error, Debug, Clone, Trace)]
+#[trivially_drop]
pub enum Error {
#[error("intrinsic not found: {0}")]
IntrinsicNotFound(IStr),
@@ -91,6 +93,7 @@
ImportSyntaxError {
path: Rc<Path>,
source_code: IStr,
+ #[unsafe_ignore_trace]
error: Box<jrsonnet_parser::ParseError>,
},
@@ -98,6 +101,8 @@
RuntimeError(IStr),
#[error("stack overflow, try to reduce recursion, or set --max-stack to bigger value")]
StackOverflow,
+ #[error("infinite recursion detected")]
+ RecursiveLazyValueEvaluation,
#[error("tried to index by fractional value")]
FractionalIndex,
#[error("attempted to divide by zero")]
@@ -145,15 +150,18 @@
}
}
-#[derive(Clone, Debug)]
+#[derive(Clone, Debug, Trace)]
+#[trivially_drop]
pub struct StackTraceElement {
pub location: Option<ExprLocation>,
pub desc: String,
}
-#[derive(Debug, Clone)]
+#[derive(Debug, Clone, Trace)]
+#[trivially_drop]
pub struct StackTrace(pub Vec<StackTraceElement>);
-#[derive(Debug, Clone)]
+#[derive(Debug, Clone, Trace)]
+#[trivially_drop]
pub struct LocError(Box<(Error, StackTrace)>);
impl LocError {
pub fn new(e: Error) -> Self {
crates/jrsonnet-evaluator/src/evaluate.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/evaluate.rs
+++ b/crates/jrsonnet-evaluator/src/evaluate.rs
@@ -1,8 +1,9 @@
use crate::{
- equals, error::Error::*, lazy_val, push, throw, with_state, ArrValue, Context, ContextCreator,
- FuncDesc, FuncVal, FutureWrapper, LazyBinding, LazyVal, ObjMember, ObjValue, Result, Val,
+ equals, error::Error::*, push, throw, with_state, ArrValue, Bindable, Context, ContextCreator,
+ FuncDesc, FuncVal, FutureWrapper, LazyBinding, LazyVal, LazyValValue, ObjMember, ObjValue,
+ ObjectAssertion, Result, Val,
};
-use closure::closure;
+use jrsonnet_gc::{Gc, Trace};
use jrsonnet_interner::IStr;
use jrsonnet_parser::{
ArgsDesc, AssertStmt, BinaryOpType, BindSpec, CompSpec, Expr, ExprLocation, FieldMember,
@@ -11,7 +12,7 @@
};
use jrsonnet_types::ValType;
use rustc_hash::{FxHashMap, FxHasher};
-use std::{collections::HashMap, hash::BuildHasherDefault, rc::Rc};
+use std::{collections::HashMap, hash::BuildHasherDefault};
pub fn evaluate_binding_in_future(
b: &BindSpec,
@@ -20,17 +21,49 @@
let b = b.clone();
if let Some(params) = &b.params {
let params = params.clone();
- LazyVal::new(Box::new(move || {
- Ok(evaluate_method(
- context_creator.unwrap(),
- b.name.clone(),
- params.clone(),
- b.value.clone(),
- ))
+
+ #[derive(Trace)]
+ #[trivially_drop]
+ struct LazyMethodBinding {
+ context_creator: FutureWrapper<Context>,
+ name: IStr,
+ params: ParamsDesc,
+ value: LocExpr,
+ }
+ impl LazyValValue for LazyMethodBinding {
+ fn get(self: Box<Self>) -> Result<Val> {
+ Ok(evaluate_method(
+ self.context_creator.unwrap(),
+ self.name,
+ self.params,
+ self.value,
+ ))
+ }
+ }
+
+ LazyVal::new(Box::new(LazyMethodBinding {
+ context_creator,
+ name: b.name.clone(),
+ params,
+ value: b.value.clone(),
}))
} else {
- LazyVal::new(Box::new(move || {
- evaluate_named(context_creator.unwrap(), &b.value, b.name.clone())
+ #[derive(Trace)]
+ #[trivially_drop]
+ struct LazyNamedBinding {
+ context_creator: FutureWrapper<Context>,
+ name: IStr,
+ value: LocExpr,
+ }
+ impl LazyValValue for LazyNamedBinding {
+ fn get(self: Box<Self>) -> Result<Val> {
+ evaluate_named(self.context_creator.unwrap(), &self.value, self.name)
+ }
+ }
+ LazyVal::new(Box::new(LazyNamedBinding {
+ context_creator,
+ name: b.name.clone(),
+ value: b.value,
}))
}
}
@@ -39,37 +72,114 @@
let b = b.clone();
if let Some(params) = &b.params {
let params = params.clone();
+
+ #[derive(Trace)]
+ #[trivially_drop]
+ struct BindableMethodLazyVal {
+ this: Option<ObjValue>,
+ super_obj: Option<ObjValue>,
+
+ context_creator: ContextCreator,
+ name: IStr,
+ params: ParamsDesc,
+ value: LocExpr,
+ }
+ impl LazyValValue for BindableMethodLazyVal {
+ fn get(self: Box<Self>) -> Result<Val> {
+ Ok(evaluate_method(
+ self.context_creator.create(self.this, self.super_obj)?,
+ self.name,
+ self.params,
+ self.value,
+ ))
+ }
+ }
+
+ #[derive(Trace)]
+ #[trivially_drop]
+ struct BindableMethod {
+ context_creator: ContextCreator,
+ name: IStr,
+ params: ParamsDesc,
+ value: LocExpr,
+ }
+ impl Bindable for BindableMethod {
+ fn bind(&self, this: Option<ObjValue>, super_obj: Option<ObjValue>) -> Result<LazyVal> {
+ Ok(LazyVal::new(Box::new(BindableMethodLazyVal {
+ this,
+ super_obj,
+
+ context_creator: self.context_creator.clone(),
+ name: self.name.clone(),
+ params: self.params.clone(),
+ value: self.value.clone(),
+ })))
+ }
+ }
+
(
b.name.clone(),
- LazyBinding::Bindable(Rc::new(move |this, super_obj| {
- Ok(lazy_val!(
- closure!(clone b, clone params, clone context_creator, || Ok(evaluate_method(
- context_creator.create(this.clone(), super_obj.clone())?,
- b.name.clone(),
- params.clone(),
- b.value.clone(),
- )))
- ))
- })),
+ LazyBinding::Bindable(Gc::new(Box::new(BindableMethod {
+ context_creator,
+ name: b.name.clone(),
+ params,
+ value: b.value.clone(),
+ }))),
)
} else {
+ #[derive(Trace)]
+ #[trivially_drop]
+ struct BindableNamedLazyVal {
+ this: Option<ObjValue>,
+ super_obj: Option<ObjValue>,
+
+ context_creator: ContextCreator,
+ name: IStr,
+ value: LocExpr,
+ }
+ impl LazyValValue for BindableNamedLazyVal {
+ fn get(self: Box<Self>) -> Result<Val> {
+ evaluate_named(
+ self.context_creator.create(self.this, self.super_obj)?,
+ &self.value,
+ self.name,
+ )
+ }
+ }
+
+ #[derive(Trace)]
+ #[trivially_drop]
+ struct BindableNamed {
+ context_creator: ContextCreator,
+ name: IStr,
+ value: LocExpr,
+ }
+ impl Bindable for BindableNamed {
+ fn bind(&self, this: Option<ObjValue>, super_obj: Option<ObjValue>) -> Result<LazyVal> {
+ Ok(LazyVal::new(Box::new(BindableNamedLazyVal {
+ this,
+ super_obj,
+
+ context_creator: self.context_creator.clone(),
+ name: self.name.clone(),
+ value: self.value.clone(),
+ })))
+ }
+ }
+
(
b.name.clone(),
- LazyBinding::Bindable(Rc::new(move |this, super_obj| {
- Ok(lazy_val!(closure!(clone context_creator, clone b, ||
- evaluate_named(
- context_creator.create(this.clone(), super_obj.clone())?,
- &b.value,
- b.name.clone()
- )
- )))
- })),
+ LazyBinding::Bindable(Gc::new(Box::new(BindableNamed {
+ context_creator,
+ name: b.name.clone(),
+ value: b.value.clone(),
+ }))),
)
}
}
pub fn evaluate_method(ctx: Context, name: IStr, params: ParamsDesc, body: LocExpr) -> Val {
- Val::Func(Rc::new(FuncVal::Normal(FuncDesc {
+ Val::Func(Gc::new(FuncVal::Normal(FuncDesc {
name,
ctx,
params,
@@ -105,6 +215,9 @@
pub fn evaluate_add_op(a: &Val, b: &Val) -> Result<Val> {
Ok(match (a, b) {
+ (Val::DebugGcTraceValue(v1), Val::DebugGcTraceValue(v2)) => {
+ evaluate_add_op(&v1.value, &v2.value)?
+ }
(Val::Str(v1), Val::Str(v2)) => Val::Str(((**v1).to_owned() + v2).into()),
// Can't use generic json serialization way, because it depends on number to string concatenation (std.jsonnet:890)
@@ -257,7 +370,7 @@
}
let mut new_members = FxHashMap::default();
- let mut assertions = Vec::new();
+ let mut assertions: Vec<Box<dyn ObjectAssertion>> = Vec::new();
for member in members.iter() {
match member {
Member::Field(FieldMember {
@@ -272,20 +385,37 @@
continue;
}
let name = name.unwrap();
+
+ #[derive(Trace)]
+ #[trivially_drop]
+ struct ObjMemberBinding {
+ context_creator: ContextCreator,
+ value: LocExpr,
+ name: IStr,
+ }
+ impl Bindable for ObjMemberBinding {
+ fn bind(
+ &self,
+ this: Option<ObjValue>,
+ super_obj: Option<ObjValue>,
+ ) -> Result<LazyVal> {
+ Ok(LazyVal::new_resolved(evaluate_named(
+ self.context_creator.create(this, super_obj)?,
+ &self.value,
+ self.name.clone(),
+ )?))
+ }
+ }
new_members.insert(
name.clone(),
ObjMember {
add: *plus,
visibility: *visibility,
- invoke: LazyBinding::Bindable(Rc::new(
- closure!(clone name, clone value, clone context_creator, |this, super_obj| {
- Ok(LazyVal::new_resolved(evaluate_named(
- context_creator.create(this, super_obj)?,
- &value,
- name.clone(),
- )?))
- }),
- )),
+ invoke: LazyBinding::Bindable(Gc::new(Box::new(ObjMemberBinding {
+ context_creator: context_creator.clone(),
+ value: value.clone(),
+ name,
+ }))),
location: value.1.clone(),
},
);
@@ -301,33 +431,69 @@
continue;
}
let name = name.unwrap();
+ #[derive(Trace)]
+ #[trivially_drop]
+ struct ObjMemberBinding {
+ context_creator: ContextCreator,
+ value: LocExpr,
+ params: ParamsDesc,
+ name: IStr,
+ }
+ impl Bindable for ObjMemberBinding {
+ fn bind(
+ &self,
+ this: Option<ObjValue>,
+ super_obj: Option<ObjValue>,
+ ) -> Result<LazyVal> {
+ Ok(LazyVal::new_resolved(evaluate_method(
+ self.context_creator.create(this, super_obj)?,
+ self.name.clone(),
+ self.params.clone(),
+ self.value.clone(),
+ )))
+ }
+ }
new_members.insert(
name.clone(),
ObjMember {
add: false,
visibility: Visibility::Hidden,
- invoke: LazyBinding::Bindable(Rc::new(
- closure!(clone value, clone context_creator, clone params, clone name, |this, super_obj| {
- // TODO: Assert
- Ok(LazyVal::new_resolved(evaluate_method(
- context_creator.create(this, super_obj)?,
- name.clone(),
- params.clone(),
- value.clone(),
- )))
- }),
- )),
+ invoke: LazyBinding::Bindable(Gc::new(Box::new(ObjMemberBinding {
+ context_creator: context_creator.clone(),
+ value: value.clone(),
+ params: params.clone(),
+ name,
+ }))),
location: value.1.clone(),
},
);
}
Member::BindStmt(_) => {}
Member::AssertStmt(stmt) => {
- assertions.push(stmt.clone());
+ #[derive(Trace)]
+ #[trivially_drop]
+ struct ObjectAssert {
+ context_creator: ContextCreator,
+ assert: AssertStmt,
+ }
+ impl ObjectAssertion for ObjectAssert {
+ fn run(
+ &self,
+ this: Option<ObjValue>,
+ super_obj: Option<ObjValue>,
+ ) -> Result<()> {
+ let ctx = self.context_creator.create(this, super_obj)?;
+ evaluate_assert(ctx, &self.assert)
+ }
+ }
+ assertions.push(Box::new(ObjectAssert {
+ context_creator: context_creator.clone(),
+ assert: stmt.clone(),
+ }));
}
}
}
- let this = ObjValue::new(context, None, Rc::new(new_members), Rc::new(assertions));
+ let this = ObjValue::new(None, Gc::new(new_members), Gc::new(assertions));
future_this.fill(this.clone());
Ok(this)
}
@@ -361,16 +527,38 @@
match key {
Val::Null => {}
Val::Str(n) => {
+ #[derive(Trace)]
+ #[trivially_drop]
+ struct ObjCompBinding {
+ context: Context,
+ value: LocExpr,
+ }
+ impl Bindable for ObjCompBinding {
+ fn bind(
+ &self,
+ this: Option<ObjValue>,
+ _super_obj: Option<ObjValue>,
+ ) -> Result<LazyVal> {
+ Ok(LazyVal::new_resolved(evaluate(
+ self.context.clone().extend(
+ FxHashMap::default(),
+ None,
+ this,
+ None,
+ ),
+ &self.value,
+ )?))
+ }
+ }
new_members.insert(
n,
ObjMember {
add: false,
visibility: Visibility::Normal,
- invoke: LazyBinding::Bindable(Rc::new(
- closure!(clone ctx, clone obj.value, |this, _super_obj| {
- Ok(LazyVal::new_resolved(evaluate(ctx.clone().extend(FxHashMap::default(), None, this, None), &value)?))
- }),
- )),
+ invoke: LazyBinding::Bindable(Gc::new(Box::new(ObjCompBinding {
+ context: ctx,
+ value: obj.value.clone(),
+ }))),
location: obj.value.1.clone(),
},
);
@@ -381,7 +569,7 @@
Ok(())
})?;
- let this = ObjValue::new(context, None, Rc::new(new_members), Rc::new(Vec::new()));
+ let this = ObjValue::new(None, Gc::new(new_members), Gc::new(Vec::new()));
future_this.fill(this.clone());
this
}
@@ -486,7 +674,7 @@
if let Some(v) = v.get(s.clone())? {
Ok(v)
} else if v.get("__intrinsic_namespace__".into())?.is_some() {
- Ok(Val::Func(Rc::new(FuncVal::Intrinsic(s))))
+ Ok(Val::Func(Gc::new(FuncVal::Intrinsic(s))))
} else {
throw!(NoSuchField(s))
}
@@ -549,11 +737,22 @@
Arr(items) => {
let mut out = Vec::with_capacity(items.len());
for item in items {
- out.push(LazyVal::new(Box::new(
- closure!(clone context, clone item, || {
- evaluate(context.clone(), &item)
- }),
- )));
+ // TODO: Implement ArrValue::Lazy with same context for every element?
+ #[derive(Trace)]
+ #[trivially_drop]
+ struct ArrayElement {
+ context: Context,
+ item: LocExpr,
+ }
+ impl LazyValValue for ArrayElement {
+ fn get(self: Box<Self>) -> Result<Val> {
+ evaluate(self.context, &self.item)
+ }
+ }
+ out.push(LazyVal::new(Box::new(ArrayElement {
+ context: context.clone(),
+ item: item.clone(),
+ })));
}
Val::Arr(out.into())
}
@@ -563,7 +762,7 @@
out.push(evaluate(ctx, expr)?);
Ok(())
})?;
- Val::Arr(ArrValue::Eager(Rc::new(out)))
+ Val::Arr(ArrValue::Eager(Gc::new(out)))
}
Obj(body) => Val::Obj(evaluate_object(context, body)?),
ObjExtend(s, t) => evaluate_add_op(
@@ -576,7 +775,7 @@
Function(params, body) => {
evaluate_method(context, "anonymous".into(), params.clone(), body.clone())
}
- Intrinsic(name) => Val::Func(Rc::new(FuncVal::Intrinsic(name.clone()))),
+ Intrinsic(name) => Val::Func(Gc::new(FuncVal::Intrinsic(name.clone()))),
AssertExpr(assert, returned) => {
evaluate_assert(context.clone(), assert)?;
evaluate(context, returned)?
crates/jrsonnet-evaluator/src/function.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/function.rs
+++ b/crates/jrsonnet-evaluator/src/function.rs
@@ -1,7 +1,7 @@
-use crate::{error::Error::*, evaluate, lazy_val, resolved_lazy_val, throw, Context, Result, Val};
-use closure::closure;
+use crate::{error::Error::*, evaluate, throw, Context, LazyVal, LazyValValue, Result, Val};
+use jrsonnet_gc::Trace;
use jrsonnet_interner::IStr;
-use jrsonnet_parser::{ArgsDesc, ParamsDesc};
+use jrsonnet_parser::{ArgsDesc, LocExpr, ParamsDesc};
use rustc_hash::FxHashMap;
use std::{collections::HashMap, hash::BuildHasherDefault};
@@ -53,9 +53,24 @@
throw!(FunctionParameterNotBoundInCall(p.0.clone()));
};
let val = if tailstrict {
- resolved_lazy_val!(evaluate(ctx, expr)?)
+ LazyVal::new_resolved(evaluate(ctx, expr)?)
} else {
- lazy_val!(closure!(clone ctx, clone expr, ||evaluate(ctx.clone(), &expr)))
+ #[derive(Trace)]
+ #[trivially_drop]
+ struct EvaluateLazyVal {
+ context: Context,
+ expr: LocExpr,
+ }
+ impl LazyValValue for EvaluateLazyVal {
+ fn get(self: Box<Self>) -> Result<Val> {
+ evaluate(self.context, &self.expr)
+ }
+ }
+
+ LazyVal::new(Box::new(EvaluateLazyVal {
+ context: ctx.clone(),
+ expr: expr.clone(),
+ }))
};
out.insert(p.0.clone(), val);
}
@@ -89,19 +104,31 @@
// Fill defaults
for (id, p) in params.iter().enumerate() {
let val = if let Some(arg) = positioned_args[id].take() {
- resolved_lazy_val!(arg)
+ LazyVal::new_resolved(arg)
} else if let Some(default) = &p.1 {
if tailstrict {
- resolved_lazy_val!(evaluate(
+ LazyVal::new_resolved(evaluate(
body_ctx.clone().expect(NO_DEFAULT_CONTEXT),
- default
+ default,
)?)
} else {
let body_ctx = body_ctx.clone();
let default = default.clone();
- lazy_val!(move || {
- evaluate(body_ctx.clone().expect(NO_DEFAULT_CONTEXT), &default)
- })
+ #[derive(Trace)]
+ #[trivially_drop]
+ struct EvaluateLazyVal {
+ body_ctx: Option<Context>,
+ default: LocExpr,
+ }
+ impl LazyValValue for EvaluateLazyVal {
+ fn get(self: Box<Self>) -> Result<Val> {
+ evaluate(
+ self.body_ctx.clone().expect(NO_DEFAULT_CONTEXT),
+ &self.default,
+ )
+ }
+ }
+ LazyVal::new(Box::new(EvaluateLazyVal { body_ctx, default }))
}
} else {
throw!(FunctionParameterNotBoundInCall(p.0.clone()));
@@ -135,7 +162,7 @@
} else {
throw!(FunctionParameterNotBoundInCall(p.0.clone()));
};
- out.insert(p.0.clone(), resolved_lazy_val!(val));
+ out.insert(p.0.clone(), LazyVal::new_resolved(val));
}
Ok(body_ctx.unwrap_or(ctx).extend(out, None, None, None))
crates/jrsonnet-evaluator/src/integrations/serde.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/integrations/serde.rs
+++ b/crates/jrsonnet-evaluator/src/integrations/serde.rs
@@ -1,7 +1,8 @@
use crate::{
error::{Error::*, LocError, Result},
- throw, Context, LazyBinding, LazyVal, ObjMember, ObjValue, Val,
+ throw, LazyBinding, LazyVal, ObjMember, ObjValue, Val,
};
+use jrsonnet_gc::Gc;
use jrsonnet_parser::Visibility;
use rustc_hash::FxHasher;
use serde_json::{Map, Number, Value};
@@ -9,7 +10,6 @@
collections::HashMap,
convert::{TryFrom, TryInto},
hash::BuildHasherDefault,
- rc::Rc,
};
impl TryFrom<&Val> for Value {
@@ -42,6 +42,7 @@
Self::Object(out)
}
Val::Func(_) => throw!(RuntimeError("tried to manifest function".into())),
+ Val::DebugGcTraceValue(v) => Self::try_from(&*v.value as &Val)?,
})
}
}
@@ -76,12 +77,7 @@
},
);
}
- Self::Obj(ObjValue::new(
- Context::new(),
- None,
- Rc::new(entries),
- Rc::new(Vec::new()),
- ))
+ Self::Obj(ObjValue::new(None, Gc::new(entries), Gc::new(Vec::new())))
}
}
}
crates/jrsonnet-evaluator/src/lib.rsdiffbeforeafterboth1#![cfg_attr(feature = "unstable", feature(stmt_expr_attributes))]2#![warn(clippy::all, clippy::nursery)]3#![allow(4 macro_expanded_macro_exports_accessed_by_absolute_paths,5 clippy::ptr_arg6)]78mod builtin;9mod ctx;10mod dynamic;11pub mod error;12mod evaluate;13mod function;14mod import;15mod integrations;16mod map;17pub mod native;18mod obj;19pub mod trace;20pub mod typed;21mod val;2223pub use ctx::*;24pub use dynamic::*;25use error::{Error::*, LocError, Result, StackTraceElement};26pub use evaluate::*;27pub use function::parse_function_call;28pub use import::*;29use jrsonnet_parser::*;30use native::NativeCallback;31pub use obj::*;32use rustc_hash::FxHashMap;33use std::{34 cell::{Ref, RefCell, RefMut},35 collections::HashMap,36 fmt::Debug,37 hash::BuildHasherDefault,38 path::{Path, PathBuf},39 rc::Rc,40};41use trace::{offset_to_location, CodeLocation, CompactFormat, TraceFormat};42pub use val::*;4344// Re-exports45pub use jrsonnet_interner::IStr;4647type BindableFn = dyn Fn(Option<ObjValue>, Option<ObjValue>) -> Result<LazyVal>;48#[derive(Clone)]49pub enum LazyBinding {50 Bindable(Rc<BindableFn>),51 Bound(LazyVal),52}5354impl Debug for LazyBinding {55 fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {56 write!(f, "LazyBinding")57 }58}59impl LazyBinding {60 pub fn evaluate(&self, this: Option<ObjValue>, super_obj: Option<ObjValue>) -> Result<LazyVal> {61 match self {62 Self::Bindable(v) => v(this, super_obj),63 Self::Bound(v) => Ok(v.clone()),64 }65 }66}6768pub struct EvaluationSettings {69 /// Limits recursion by limiting the number of stack frames70 pub max_stack: usize,71 /// Limits amount of stack trace items preserved72 pub max_trace: usize,73 /// Used for s`td.extVar`74 pub ext_vars: HashMap<IStr, Val>,75 /// Used for ext.native76 pub ext_natives: HashMap<IStr, Rc<NativeCallback>>,77 /// TLA vars78 pub tla_vars: HashMap<IStr, Val>,79 /// Global variables are inserted in default context80 pub globals: HashMap<IStr, Val>,81 /// Used to resolve file locations/contents82 pub import_resolver: Box<dyn ImportResolver>,83 /// Used in manifestification functions84 pub manifest_format: ManifestFormat,85 /// Used for bindings86 pub trace_format: Box<dyn TraceFormat>,87}88impl Default for EvaluationSettings {89 fn default() -> Self {90 Self {91 max_stack: 200,92 max_trace: 20,93 globals: Default::default(),94 ext_vars: Default::default(),95 ext_natives: Default::default(),96 tla_vars: Default::default(),97 import_resolver: Box::new(DummyImportResolver),98 manifest_format: ManifestFormat::Json(4),99 trace_format: Box::new(CompactFormat {100 padding: 4,101 resolver: trace::PathResolver::Absolute,102 }),103 }104 }105}106107#[derive(Default)]108struct EvaluationData {109 /// Used for stack overflow detection, stacktrace is populated on unwind110 stack_depth: usize,111 /// Contains file source codes and evaluation results for imports and pretty-printed stacktraces112 files: HashMap<Rc<Path>, FileData>,113 str_files: HashMap<Rc<Path>, IStr>,114}115116pub struct FileData {117 source_code: IStr,118 parsed: LocExpr,119 evaluated: Option<Val>,120}121#[derive(Default)]122pub struct EvaluationStateInternals {123 /// Internal state124 data: RefCell<EvaluationData>,125 /// Settings, safe to change at runtime126 settings: RefCell<EvaluationSettings>,127}128129thread_local! {130 /// Contains the state for a currently executed file.131 /// Global state is fine here.132 pub(crate) static EVAL_STATE: RefCell<Option<EvaluationState>> = RefCell::new(None)133}134pub(crate) fn with_state<T>(f: impl FnOnce(&EvaluationState) -> T) -> T {135 EVAL_STATE.with(|s| f(s.borrow().as_ref().unwrap()))136}137pub(crate) fn push<T>(138 e: Option<&ExprLocation>,139 frame_desc: impl FnOnce() -> String,140 f: impl FnOnce() -> Result<T>,141) -> Result<T> {142 with_state(|s| s.push(e, frame_desc, f))143}144145pub fn push_stack_frame<T>(146 e: Option<&ExprLocation>,147 frame_desc: impl FnOnce() -> String,148 f: impl FnOnce() -> Result<T>,149) -> Result<T> {150 push(e, frame_desc, f)151}152153/// Maintains stack trace and import resolution154#[derive(Default, Clone)]155pub struct EvaluationState(Rc<EvaluationStateInternals>);156157impl EvaluationState {158 /// Parses and adds file as loaded159 pub fn add_file(&self, path: Rc<Path>, source_code: IStr) -> Result<()> {160 self.add_parsed_file(161 path.clone(),162 source_code.clone(),163 parse(164 &source_code,165 &ParserSettings {166 file_name: path.clone(),167 loc_data: true,168 },169 )170 .map_err(|error| ImportSyntaxError {171 error: Box::new(error),172 path: path.to_owned(),173 source_code,174 })?,175 )?;176177 Ok(())178 }179180 /// Adds file by source code and parsed expr181 pub fn add_parsed_file(182 &self,183 name: Rc<Path>,184 source_code: IStr,185 parsed: LocExpr,186 ) -> Result<()> {187 self.data_mut().files.insert(188 name,189 FileData {190 source_code,191 parsed,192 evaluated: None,193 },194 );195196 Ok(())197 }198 pub fn get_source(&self, name: &Path) -> Option<IStr> {199 let ro_map = &self.data().files;200 ro_map.get(name).map(|value| value.source_code.clone())201 }202 pub fn map_source_locations(&self, file: &Path, locs: &[usize]) -> Vec<CodeLocation> {203 offset_to_location(&self.get_source(file).unwrap(), locs)204 }205206 pub(crate) fn import_file(&self, from: &Path, path: &Path) -> Result<Val> {207 let file_path = self.resolve_file(from, path)?;208 {209 let data = self.data();210 let files = &data.files;211 if files.contains_key(&file_path as &Path) {212 drop(data);213 return self.evaluate_loaded_file_raw(&file_path);214 }215 }216 let contents = self.load_file_contents(&file_path)?;217 self.add_file(file_path.clone(), contents)?;218 self.evaluate_loaded_file_raw(&file_path)219 }220 pub(crate) fn import_file_str(&self, from: &Path, path: &Path) -> Result<IStr> {221 let path = self.resolve_file(from, path)?;222 if !self.data().str_files.contains_key(&path) {223 let file_str = self.load_file_contents(&path)?;224 self.data_mut().str_files.insert(path.clone(), file_str);225 }226 Ok(self.data().str_files.get(&path).cloned().unwrap())227 }228229 fn evaluate_loaded_file_raw(&self, name: &Path) -> Result<Val> {230 let expr: LocExpr = {231 let ro_map = &self.data().files;232 let value = ro_map233 .get(name)234 .unwrap_or_else(|| panic!("file not added: {:?}", name));235 if let Some(ref evaluated) = value.evaluated {236 return Ok(evaluated.clone());237 }238 value.parsed.clone()239 };240 let value = evaluate(self.create_default_context(), &expr)?;241 {242 self.data_mut()243 .files244 .get_mut(name)245 .unwrap()246 .evaluated247 .replace(value.clone());248 }249 Ok(value)250 }251252 /// Adds standard library global variable (std) to this evaluator253 pub fn with_stdlib(&self) -> &Self {254 use jrsonnet_stdlib::STDLIB_STR;255 let std_path: Rc<Path> = PathBuf::from("std.jsonnet").into();256 self.run_in_state(|| {257 self.add_parsed_file(258 std_path.clone(),259 STDLIB_STR.to_owned().into(),260 builtin::get_parsed_stdlib(),261 )262 .unwrap();263 let val = self.evaluate_loaded_file_raw(&std_path).unwrap();264 self.settings_mut().globals.insert("std".into(), val);265 });266 self267 }268269 /// Creates context with all passed global variables270 pub fn create_default_context(&self) -> Context {271 let globals = &self.settings().globals;272 let mut new_bindings: FxHashMap<IStr, LazyVal> =273 FxHashMap::with_capacity_and_hasher(globals.len(), BuildHasherDefault::default());274 for (name, value) in globals.iter() {275 new_bindings.insert(name.clone(), resolved_lazy_val!(value.clone()));276 }277 Context::new().extend_bound(new_bindings)278 }279280 /// Executes code creating a new stack frame281 pub fn push<T>(282 &self,283 e: Option<&ExprLocation>,284 frame_desc: impl FnOnce() -> String,285 f: impl FnOnce() -> Result<T>,286 ) -> Result<T> {287 {288 let mut data = self.data_mut();289 let stack_depth = &mut data.stack_depth;290 if *stack_depth > self.max_stack() {291 // Error creation uses data, so i drop guard here292 drop(data);293 throw!(StackOverflow);294 } else {295 *stack_depth += 1;296 }297 }298 let result = f();299 self.data_mut().stack_depth -= 1;300 if let Err(mut err) = result {301 err.trace_mut().0.push(StackTraceElement {302 location: e.cloned(),303 desc: frame_desc(),304 });305 return Err(err);306 }307 result308 }309310 /// Runs passed function in state (required if function needs to modify stack trace)311 pub fn run_in_state<T>(&self, f: impl FnOnce() -> T) -> T {312 EVAL_STATE.with(|v| {313 let has_state = v.borrow().is_some();314 if !has_state {315 v.borrow_mut().replace(self.clone());316 }317 let result = f();318 if !has_state {319 v.borrow_mut().take();320 }321 result322 })323 }324325 pub fn stringify_err(&self, e: &LocError) -> String {326 let mut out = String::new();327 self.settings()328 .trace_format329 .write_trace(&mut out, self, e)330 .unwrap();331 out332 }333334 pub fn manifest(&self, val: Val) -> Result<IStr> {335 self.run_in_state(|| val.manifest(&self.manifest_format()))336 }337 pub fn manifest_multi(&self, val: Val) -> Result<Vec<(IStr, IStr)>> {338 self.run_in_state(|| val.manifest_multi(&self.manifest_format()))339 }340 pub fn manifest_stream(&self, val: Val) -> Result<Vec<IStr>> {341 self.run_in_state(|| val.manifest_stream(&self.manifest_format()))342 }343344 /// If passed value is function then call with set TLA345 pub fn with_tla(&self, val: Val) -> Result<Val> {346 self.run_in_state(|| {347 Ok(match val {348 Val::Func(func) => push(349 None,350 || "during TLA call".to_owned(),351 || {352 func.evaluate_map(353 self.create_default_context(),354 &self.settings().tla_vars,355 true,356 )357 },358 )?,359 v => v,360 })361 })362 }363}364365/// Internals366impl EvaluationState {367 fn data(&self) -> Ref<EvaluationData> {368 self.0.data.borrow()369 }370 fn data_mut(&self) -> RefMut<EvaluationData> {371 self.0.data.borrow_mut()372 }373 pub fn settings(&self) -> Ref<EvaluationSettings> {374 self.0.settings.borrow()375 }376 pub fn settings_mut(&self) -> RefMut<EvaluationSettings> {377 self.0.settings.borrow_mut()378 }379}380381/// Raw methods evaluate passed values but don't perform TLA execution382impl EvaluationState {383 pub fn evaluate_file_raw(&self, name: &Path) -> Result<Val> {384 self.run_in_state(|| self.import_file(&std::env::current_dir().expect("cwd"), name))385 }386 pub fn evaluate_file_raw_nocwd(&self, name: &Path) -> Result<Val> {387 self.run_in_state(|| self.import_file(&PathBuf::from("."), name))388 }389 /// Parses and evaluates the given snippet390 pub fn evaluate_snippet_raw(&self, source: Rc<Path>, code: IStr) -> Result<Val> {391 let parsed = parse(392 &code,393 &ParserSettings {394 file_name: source.clone(),395 loc_data: true,396 },397 )398 .map_err(|e| ImportSyntaxError {399 path: source.clone(),400 source_code: code.clone(),401 error: Box::new(e),402 })?;403 self.add_parsed_file(source, code, parsed.clone())?;404 self.evaluate_expr_raw(parsed)405 }406 /// Evaluates the parsed expression407 pub fn evaluate_expr_raw(&self, code: LocExpr) -> Result<Val> {408 self.run_in_state(|| evaluate(self.create_default_context(), &code))409 }410}411412/// Settings utilities413impl EvaluationState {414 pub fn add_ext_var(&self, name: IStr, value: Val) {415 self.settings_mut().ext_vars.insert(name, value);416 }417 pub fn add_ext_str(&self, name: IStr, value: IStr) {418 self.add_ext_var(name, Val::Str(value));419 }420 pub fn add_ext_code(&self, name: IStr, code: IStr) -> Result<()> {421 let value =422 self.evaluate_snippet_raw(PathBuf::from(format!("ext_code {}", name)).into(), code)?;423 self.add_ext_var(name, value);424 Ok(())425 }426427 pub fn add_tla(&self, name: IStr, value: Val) {428 self.settings_mut().tla_vars.insert(name, value);429 }430 pub fn add_tla_str(&self, name: IStr, value: IStr) {431 self.add_tla(name, Val::Str(value));432 }433 pub fn add_tla_code(&self, name: IStr, code: IStr) -> Result<()> {434 let value =435 self.evaluate_snippet_raw(PathBuf::from(format!("tla_code {}", name)).into(), code)?;436 self.add_tla(name, value);437 Ok(())438 }439440 pub fn resolve_file(&self, from: &Path, path: &Path) -> Result<Rc<Path>> {441 self.settings().import_resolver.resolve_file(from, path)442 }443 pub fn load_file_contents(&self, path: &Path) -> Result<IStr> {444 self.settings().import_resolver.load_file_contents(path)445 }446447 pub fn import_resolver(&self) -> Ref<dyn ImportResolver> {448 Ref::map(self.settings(), |s| &*s.import_resolver)449 }450 pub fn set_import_resolver(&self, resolver: Box<dyn ImportResolver>) {451 self.settings_mut().import_resolver = resolver;452 }453454 pub fn add_native(&self, name: IStr, cb: Rc<NativeCallback>) {455 self.settings_mut().ext_natives.insert(name, cb);456 }457458 pub fn manifest_format(&self) -> ManifestFormat {459 self.settings().manifest_format.clone()460 }461 pub fn set_manifest_format(&self, format: ManifestFormat) {462 self.settings_mut().manifest_format = format;463 }464465 pub fn trace_format(&self) -> Ref<dyn TraceFormat> {466 Ref::map(self.settings(), |s| &*s.trace_format)467 }468 pub fn set_trace_format(&self, format: Box<dyn TraceFormat>) {469 self.settings_mut().trace_format = format;470 }471472 pub fn max_trace(&self) -> usize {473 self.settings().max_trace474 }475 pub fn set_max_trace(&self, trace: usize) {476 self.settings_mut().max_trace = trace;477 }478479 pub fn max_stack(&self) -> usize {480 self.settings().max_stack481 }482 pub fn set_max_stack(&self, trace: usize) {483 self.settings_mut().max_stack = trace;484 }485}486487#[cfg(test)]488pub mod tests {489 use super::Val;490 use crate::{error::Error::*, primitive_equals, EvaluationState};491 use jrsonnet_interner::IStr;492 use jrsonnet_parser::*;493 use std::{494 path::{Path, PathBuf},495 rc::Rc,496 };497498 #[test]499 #[should_panic]500 fn eval_state_stacktrace() {501 let state = EvaluationState::default();502 state.run_in_state(|| {503 state504 .push(505 Some(&ExprLocation(PathBuf::from("test1.jsonnet").into(), 10, 20)),506 || "outer".to_owned(),507 || {508 state.push(509 Some(&ExprLocation(PathBuf::from("test2.jsonnet").into(), 30, 40)),510 || "inner".to_owned(),511 || Err(RuntimeError("".into()).into()),512 )?;513 Ok(())514 },515 )516 .unwrap();517 });518 }519520 #[test]521 fn eval_state_standard() {522 let state = EvaluationState::default();523 state.with_stdlib();524 assert!(primitive_equals(525 &state526 .evaluate_snippet_raw(527 PathBuf::from("raw.jsonnet").into(),528 r#"std.assertEqual(std.base64("test"), "dGVzdA==")"#.into()529 )530 .unwrap(),531 &Val::Bool(true),532 )533 .unwrap());534 }535536 macro_rules! eval {537 ($str: expr) => {538 EvaluationState::default()539 .with_stdlib()540 .evaluate_snippet_raw(PathBuf::from("raw.jsonnet").into(), $str.into())541 .unwrap()542 };543 }544 macro_rules! eval_json {545 ($str: expr) => {{546 let evaluator = EvaluationState::default();547 evaluator.with_stdlib();548 evaluator.run_in_state(|| {549 evaluator550 .evaluate_snippet_raw(PathBuf::from("raw.jsonnet").into(), $str.into())551 .unwrap()552 .to_json(0)553 .unwrap()554 .replace("\n", "")555 })556 }};557 }558559 /// Asserts given code returns `true`560 macro_rules! assert_eval {561 ($str: expr) => {562 assert!(primitive_equals(&eval!($str), &Val::Bool(true)).unwrap())563 };564 }565566 /// Asserts given code returns `false`567 macro_rules! assert_eval_neg {568 ($str: expr) => {569 assert!(primitive_equals(&eval!($str), &Val::Bool(false)).unwrap())570 };571 }572 macro_rules! assert_json {573 ($str: expr, $out: expr) => {574 assert_eq!(eval_json!($str), $out.replace("\t", ""))575 };576 }577578 /// Sanity checking, before trusting to another tests579 #[test]580 fn equality_operator() {581 assert_eval!("2 == 2");582 assert_eval_neg!("2 != 2");583 assert_eval!("2 != 3");584 assert_eval_neg!("2 == 3");585 assert_eval!("'Hello' == 'Hello'");586 assert_eval_neg!("'Hello' != 'Hello'");587 assert_eval!("'Hello' != 'World'");588 assert_eval_neg!("'Hello' == 'World'");589 }590591 #[test]592 fn math_evaluation() {593 assert_eval!("2 + 2 * 2 == 6");594 assert_eval!("3 + (2 + 2 * 2) == 9");595 }596597 #[test]598 fn string_concat() {599 assert_eval!("'Hello' + 'World' == 'HelloWorld'");600 assert_eval!("'Hello' * 3 == 'HelloHelloHello'");601 assert_eval!("'Hello' + 'World' * 3 == 'HelloWorldWorldWorld'");602 }603604 #[test]605 fn faster_join() {606 assert_eval!("std.join([0,0], [[1,2],[3,4],[5,6]]) == [1,2,0,0,3,4,0,0,5,6]");607 assert_eval!("std.join(',', ['1','2','3','4']) == '1,2,3,4'");608 }609610 #[test]611 fn function_contexts() {612 assert_eval!(613 r#"614 local k = {615 t(name = self.h): [self.h, name],616 h: 3,617 };618 local f = {619 t: k.t(),620 h: 4,621 };622 f.t[0] == f.t[1]623 "#624 );625 }626627 #[test]628 fn local() {629 assert_eval!("local a = 2; local b = 3; a + b == 5");630 assert_eval!("local a = 1, b = a + 1; a + b == 3");631 assert_eval!("local a = 1; local a = 2; a == 2");632 }633634 #[test]635 fn object_lazyness() {636 assert_json!("local a = {a:error 'test'}; {}", r#"{}"#);637 }638639 #[test]640 fn object_inheritance() {641 assert_json!("{a: self.b} + {b:3}", r#"{"a": 3,"b": 3}"#);642 }643644 #[test]645 fn object_assertion_success() {646 eval!("{assert \"a\" in self} + {a:2}");647 }648649 #[test]650 fn object_assertion_error() {651 eval!("{assert \"a\" in self}");652 }653654 #[test]655 fn lazy_args() {656 eval!("local test(a) = 2; test(error '3')");657 }658659 #[test]660 #[should_panic]661 fn tailstrict_args() {662 eval!("local test(a) = 2; test(error '3') tailstrict");663 }664665 #[test]666 #[should_panic]667 fn no_binding_error() {668 eval!("a");669 }670671 #[test]672 fn test_object() {673 assert_json!("{a:2}", r#"{"a": 2}"#);674 assert_json!("{a:2+2}", r#"{"a": 4}"#);675 assert_json!("{a:2}+{b:2}", r#"{"a": 2,"b": 2}"#);676 assert_json!("{b:3}+{b:2}", r#"{"b": 2}"#);677 assert_json!("{b:3}+{b+:2}", r#"{"b": 5}"#);678 assert_json!("local test='a'; {[test]:2}", r#"{"a": 2}"#);679 assert_json!(680 r#"681 {682 name: "Alice",683 welcome: "Hello " + self.name + "!",684 }685 "#,686 r#"{"name": "Alice","welcome": "Hello Alice!"}"#687 );688 assert_json!(689 r#"690 {691 name: "Alice",692 welcome: "Hello " + self.name + "!",693 } + {694 name: "Bob"695 }696 "#,697 r#"{"name": "Bob","welcome": "Hello Bob!"}"#698 );699 }700701 #[test]702 fn functions() {703 assert_json!(r#"local a = function(b, c = 2) b + c; a(2)"#, "4");704 assert_json!(705 r#"local a = function(b, c = "Dear") b + c + d, d = "World"; a("Hello")"#,706 r#""HelloDearWorld""#707 );708 }709710 #[test]711 fn local_methods() {712 assert_json!(r#"local a(b, c = 2) = b + c; a(2)"#, "4");713 assert_json!(714 r#"local a(b, c = "Dear") = b + c + d, d = "World"; a("Hello")"#,715 r#""HelloDearWorld""#716 );717 }718719 #[test]720 fn object_locals() {721 assert_json!(r#"{local a = 3, b: a}"#, r#"{"b": 3}"#);722 assert_json!(r#"{local a = 3, local c = a, b: c}"#, r#"{"b": 3}"#);723 assert_json!(724 r#"{local a = function (b) {[b]:4}, test: a("test")}"#,725 r#"{"test": {"test": 4}}"#726 );727 }728729 #[test]730 fn object_comp() {731 assert_json!(732 r#"{local t = "a", ["h"+i+"_"+z]: if "h"+(i-1)+"_"+z in self then t+1 else 0+t for i in [1,2,3] for z in [2,3,4] if z != i}"#,733 "{\"h1_2\": \"0a\",\"h1_3\": \"0a\",\"h1_4\": \"0a\",\"h2_3\": \"a1\",\"h2_4\": \"a1\",\"h3_2\": \"0a\",\"h3_4\": \"a1\"}"734 )735 }736737 #[test]738 fn direct_self() {739 println!(740 "{:#?}",741 eval!(742 r#"743 {744 local me = self,745 a: 3,746 b(): me.a,747 }748 "#749 )750 );751 }752753 #[test]754 fn indirect_self() {755 // `self` assigned to `me` was lost when being756 // referenced from field757 eval!(758 r#"{759 local me = self,760 a: 3,761 b: me.a,762 }.b"#763 );764 }765766 // We can't trust other tests (And official jsonnet testsuite), if assert is not working correctly767 #[test]768 fn std_assert_ok() {769 eval!("std.assertEqual(4.5 << 2, 16)");770 }771772 #[test]773 #[should_panic]774 fn std_assert_failure() {775 eval!("std.assertEqual(4.5 << 2, 15)");776 }777778 #[test]779 fn string_is_string() {780 assert!(primitive_equals(781 &eval!("local arr = 'hello'; (!std.isArray(arr)) && (!std.isString(arr))"),782 &Val::Bool(false),783 )784 .unwrap());785 }786787 #[test]788 fn base64_works() {789 assert_json!(r#"std.base64("test")"#, r#""dGVzdA==""#);790 }791792 #[test]793 fn utf8_chars() {794 assert_json!(795 r#"local c="😎";{c:std.codepoint(c),l:std.length(c)}"#,796 r#"{"c": 128526,"l": 1}"#797 )798 }799800 #[test]801 fn json() {802 assert_json!(803 r#"std.manifestJsonEx({a:3, b:4, c:6},"")"#,804 r#""{\n\"a\": 3,\n\"b\": 4,\n\"c\": 6\n}""#805 );806 }807808 #[test]809 fn parse_json() {810 assert_json!(811 r#"std.parseJson('{"a": -1,"b": 1,"c": 3.141,"d": []}')"#,812 r#"{"a": -1,"b": 1,"c": 3.141,"d": []}"#813 );814 // TODO: this should in fact fail as is no proper JSON syntax815 assert_json!(816 r#"std.parseJson("{a:-1, b:1, c:3.141, d:[]}")"#,817 r#"{"a": -1,"b": 1,"c": 3.141,"d": []}"#818 );819 // TODO: this is also no valid JSON820 assert_json!(r#"std.parseJson('local x = 2; x * x')"#, r#"4"#);821 }822823 #[test]824 fn test() {825 assert_json!(826 r#"[[a, b] for a in [1,2,3] for b in [4,5,6]]"#,827 "[[1,4],[1,5],[1,6],[2,4],[2,5],[2,6],[3,4],[3,5],[3,6]]"828 );829 }830831 #[test]832 fn sjsonnet() {833 eval!(834 r#"835 local x0 = {k: 1};836 local x1 = {k: x0.k + x0.k};837 local x2 = {k: x1.k + x1.k};838 local x3 = {k: x2.k + x2.k};839 local x4 = {k: x3.k + x3.k};840 local x5 = {k: x4.k + x4.k};841 local x6 = {k: x5.k + x5.k};842 local x7 = {k: x6.k + x6.k};843 local x8 = {k: x7.k + x7.k};844 local x9 = {k: x8.k + x8.k};845 local x10 = {k: x9.k + x9.k};846 local x11 = {k: x10.k + x10.k};847 local x12 = {k: x11.k + x11.k};848 local x13 = {k: x12.k + x12.k};849 local x14 = {k: x13.k + x13.k};850 local x15 = {k: x14.k + x14.k};851 local x16 = {k: x15.k + x15.k};852 local x17 = {k: x16.k + x16.k};853 local x18 = {k: x17.k + x17.k};854 local x19 = {k: x18.k + x18.k};855 local x20 = {k: x19.k + x19.k};856 local x21 = {k: x20.k + x20.k};857 x21.k858 "#859 );860 }861862 // This test is commented out by default, because of huge compilation slowdown863 // #[bench]864 // fn bench_codegen(b: &mut Bencher) {865 // b.iter(|| {866 // #[allow(clippy::all)]867 // let stdlib = {868 // use jrsonnet_parser::*;869 // include!(concat!(env!("OUT_DIR"), "/stdlib.rs"))870 // };871 // stdlib872 // })873 // }874875 /*876 #[bench]877 fn bench_serialize(b: &mut Bencher) {878 b.iter(|| {879 bincode::deserialize::<jrsonnet_parser::LocExpr>(include_bytes!(concat!(880 env!("OUT_DIR"),881 "/stdlib.bincode"882 )))883 .expect("deserialize stdlib")884 })885 }886887 #[bench]888 fn bench_parse(b: &mut Bencher) {889 b.iter(|| {890 jrsonnet_parser::parse(891 jrsonnet_stdlib::STDLIB_STR,892 &jrsonnet_parser::ParserSettings {893 loc_data: true,894 file_name: Rc::new(PathBuf::from("std.jsonnet")),895 },896 )897 })898 }899 */900901 #[test]902 fn equality() {903 println!(904 "{:?}",905 jrsonnet_parser::parse(906 "{ x: 1, y: 2 } == { x: 1, y: 2 }",907 &ParserSettings {908 file_name: PathBuf::from("equality").into(),909 loc_data: true,910 }911 )912 );913 assert_eval!("{ x: 1, y: 2 } == { x: 1, y: 2 }")914 }915916 #[test]917 fn native_ext() -> crate::error::Result<()> {918 use super::native::NativeCallback;919 let evaluator = EvaluationState::default();920921 evaluator.with_stdlib();922 evaluator.settings_mut().ext_natives.insert(923 "native_add".into(),924 Rc::new(NativeCallback::new(925 ParamsDesc(Rc::new(vec![926 Param("a".into(), None),927 Param("b".into(), None),928 ])),929 |caller, args| {930 assert_eq!(931 &caller.unwrap() as &Path,932 &PathBuf::from("native_caller.jsonnet")933 );934 match (&args[0], &args[1]) {935 (Val::Num(a), Val::Num(b)) => Ok(Val::Num(a + b)),936 (_, _) => unreachable!(),937 }938 },939 )),940 );941 evaluator.evaluate_snippet_raw(942 PathBuf::from("native_caller.jsonnet").into(),943 "std.assertEqual(std.native(\"native_add\")(1, 2), 3)".into(),944 )?;945 Ok(())946 }947948 #[test]949 fn constant_intrinsic() -> crate::error::Result<()> {950 assert_eval!(951 "local std2 = std; local std = std2 { primitiveEquals(a, b):: false }; 1 == 1"952 );953 Ok(())954 }955956 #[test]957 fn standalone_super() -> crate::error::Result<()> {958 assert_eval!(959 r#"960 local obj = {961 a: 1,962 b: 2,963 c: 3,964 };965 local test = obj + {966 fields: std.objectFields(super),967 d: 5,968 };969 test.fields == ['a', 'b', 'c']970 "#971 );972 Ok(())973 }974975 #[test]976 fn comp_self() -> crate::error::Result<()> {977 assert_eval!(978 r#"979 std.objectFields({980 a:{981 [name]: name for name in std.objectFields(self)982 },983 b: 2,984 c: 3,985 }.a) == ['a', 'b', 'c']986 "#987 );988989 Ok(())990 }991992 struct TestImportResolver(IStr);993 impl crate::import::ImportResolver for TestImportResolver {994 fn resolve_file(&self, _: &Path, _: &Path) -> crate::error::Result<Rc<Path>> {995 Ok(PathBuf::from("/test").into())996 }997998 fn load_file_contents(&self, _: &Path) -> crate::error::Result<IStr> {999 Ok(self.0.clone())1000 }10011002 unsafe fn as_any(&self) -> &dyn std::any::Any {1003 panic!()1004 }1005 }10061007 #[test]1008 fn issue_23() {1009 let state = EvaluationState::default();1010 state.set_import_resolver(Box::new(TestImportResolver(r#"import "/test""#.into())));1011 let _ = state.evaluate_file_raw(&PathBuf::from("/test"));1012 }10131014 #[test]1015 fn issue_40() {1016 let state = EvaluationState::default();1017 state.with_stdlib();10181019 let error = state1020 .evaluate_snippet_raw(1021 PathBuf::from("issue40.jsonnet").into(),1022 r#"1023 local conf = {1024 n: ""1025 };1026 1027 local result = conf + {1028 assert std.isNumber(self.n): "is number"1029 };10301031 std.manifestJsonEx(result, "")1032 "#1033 .into(),1034 )1035 .unwrap_err();1036 assert_eq!(error.error().to_string(), "assert failed: is number");1037 }1038}crates/jrsonnet-evaluator/src/map.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/map.rs
+++ b/crates/jrsonnet-evaluator/src/map.rs
@@ -1,31 +1,29 @@
+use jrsonnet_gc::{Gc, Trace};
use jrsonnet_interner::IStr;
use rustc_hash::FxHashMap;
-use std::rc::Rc;
-#[derive(Default, Debug)]
-struct LayeredHashMapInternals<V> {
- parent: Option<LayeredHashMap<V>>,
- current: FxHashMap<IStr, V>,
+use crate::LazyVal;
+
+#[derive(Trace)]
+#[trivially_drop]
+pub struct LayeredHashMapInternals {
+ parent: Option<LayeredHashMap>,
+ current: FxHashMap<IStr, LazyVal>,
}
-#[derive(Debug)]
-pub struct LayeredHashMap<V>(Rc<LayeredHashMapInternals<V>>);
+#[derive(Trace)]
+#[trivially_drop]
+pub struct LayeredHashMap(Gc<LayeredHashMapInternals>);
-impl<V> LayeredHashMap<V> {
- pub fn extend(self, new_layer: FxHashMap<IStr, V>) -> Self {
- match Rc::try_unwrap(self.0) {
- Ok(mut map) => {
- map.current.extend(new_layer);
- Self(Rc::new(map))
- }
- Err(this) => Self(Rc::new(LayeredHashMapInternals {
- parent: Some(Self(this)),
- current: new_layer,
- })),
- }
+impl LayeredHashMap {
+ pub fn extend(self, new_layer: FxHashMap<IStr, LazyVal>) -> Self {
+ Self(Gc::new(LayeredHashMapInternals {
+ parent: Some(self),
+ current: new_layer,
+ }))
}
- pub fn get(&self, key: &IStr) -> Option<&V> {
+ pub fn get(&self, key: &IStr) -> Option<&LazyVal> {
(self.0)
.current
.get(key)
@@ -33,15 +31,15 @@
}
}
-impl<V> Clone for LayeredHashMap<V> {
+impl Clone for LayeredHashMap {
fn clone(&self) -> Self {
Self(self.0.clone())
}
}
-impl<V> Default for LayeredHashMap<V> {
+impl Default for LayeredHashMap {
fn default() -> Self {
- Self(Rc::new(LayeredHashMapInternals {
+ Self(Gc::new(LayeredHashMapInternals {
parent: None,
current: FxHashMap::default(),
}))
crates/jrsonnet-evaluator/src/native.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/native.rs
+++ b/crates/jrsonnet-evaluator/src/native.rs
@@ -1,27 +1,28 @@
#![allow(clippy::type_complexity)]
use crate::{error::Result, Val};
+use jrsonnet_gc::Trace;
use jrsonnet_parser::ParamsDesc;
use std::fmt::Debug;
use std::path::Path;
use std::rc::Rc;
+pub trait NativeCallbackHandler: Trace {
+ fn call(&self, from: Option<Rc<Path>>, args: &[Val]) -> Result<Val>;
+}
+
+#[derive(Trace)]
+#[trivially_drop]
pub struct NativeCallback {
pub params: ParamsDesc,
- handler: Box<dyn Fn(Option<Rc<Path>>, &[Val]) -> Result<Val>>,
+ handler: Box<dyn NativeCallbackHandler>,
}
impl NativeCallback {
- pub fn new(
- params: ParamsDesc,
- handler: impl Fn(Option<Rc<Path>>, &[Val]) -> Result<Val> + 'static,
- ) -> Self {
- Self {
- params,
- handler: Box::new(handler),
- }
+ pub fn new(params: ParamsDesc, handler: Box<dyn NativeCallbackHandler>) -> Self {
+ Self { params, handler }
}
pub fn call(&self, caller: Option<Rc<Path>>, args: &[Val]) -> Result<Val> {
- (self.handler)(caller, args)
+ self.handler.call(caller, args)
}
}
impl Debug for NativeCallback {
crates/jrsonnet-evaluator/src/obj.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/obj.rs
+++ b/crates/jrsonnet-evaluator/src/obj.rs
@@ -1,11 +1,13 @@
-use crate::{evaluate_add_op, evaluate_assert, Context, LazyBinding, Result, Val};
+use crate::{evaluate_add_op, LazyBinding, Result, Val};
+use jrsonnet_gc::{Gc, GcCell, Trace};
use jrsonnet_interner::IStr;
-use jrsonnet_parser::{AssertStmt, ExprLocation, Visibility};
+use jrsonnet_parser::{ExprLocation, Visibility};
use rustc_hash::{FxHashMap, FxHashSet};
use std::hash::{Hash, Hasher};
-use std::{cell::RefCell, fmt::Debug, hash::BuildHasherDefault, rc::Rc};
+use std::{fmt::Debug, hash::BuildHasherDefault};
-#[derive(Debug)]
+#[derive(Debug, Trace)]
+#[trivially_drop]
pub struct ObjMember {
pub add: bool,
pub visibility: Visibility,
@@ -13,21 +15,26 @@
pub location: Option<ExprLocation>,
}
+pub trait ObjectAssertion: Trace {
+ fn run(&self, this: Option<ObjValue>, super_obj: Option<ObjValue>) -> Result<()>;
+}
+
// Field => This
type CacheKey = (IStr, ObjValue);
-#[derive(Debug)]
+#[derive(Trace)]
+#[trivially_drop]
pub struct ObjValueInternals {
- context: Context,
super_obj: Option<ObjValue>,
- assertions: Rc<Vec<AssertStmt>>,
- assertions_ran: RefCell<FxHashSet<ObjValue>>,
+ assertions: Gc<Vec<Box<dyn ObjectAssertion>>>,
+ assertions_ran: GcCell<FxHashSet<ObjValue>>,
this_obj: Option<ObjValue>,
- this_entries: Rc<FxHashMap<IStr, ObjMember>>,
- value_cache: RefCell<FxHashMap<CacheKey, Option<Val>>>,
+ this_entries: Gc<FxHashMap<IStr, ObjMember>>,
+ value_cache: GcCell<FxHashMap<CacheKey, Option<Val>>>,
}
-#[derive(Clone)]
-pub struct ObjValue(pub(crate) Rc<ObjValueInternals>);
+#[derive(Clone, Trace)]
+#[trivially_drop]
+pub struct ObjValue(pub(crate) Gc<ObjValueInternals>);
impl Debug for ObjValue {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
if let Some(super_obj) = self.0.super_obj.as_ref() {
@@ -55,39 +62,30 @@
impl ObjValue {
pub fn new(
- context: Context,
super_obj: Option<Self>,
- this_entries: Rc<FxHashMap<IStr, ObjMember>>,
- assertions: Rc<Vec<AssertStmt>>,
+ this_entries: Gc<FxHashMap<IStr, ObjMember>>,
+ assertions: Gc<Vec<Box<dyn ObjectAssertion>>>,
) -> Self {
- Self(Rc::new(ObjValueInternals {
- context,
+ Self(Gc::new(ObjValueInternals {
super_obj,
assertions,
- assertions_ran: RefCell::new(FxHashSet::default()),
+ assertions_ran: GcCell::new(FxHashSet::default()),
this_obj: None,
this_entries,
- value_cache: RefCell::new(FxHashMap::default()),
+ value_cache: GcCell::new(FxHashMap::default()),
}))
}
pub fn new_empty() -> Self {
- Self::new(
- Context::new(),
- None,
- Rc::new(FxHashMap::default()),
- Rc::new(Vec::new()),
- )
+ Self::new(None, Gc::new(FxHashMap::default()), Gc::new(Vec::new()))
}
pub fn extend_from(&self, super_obj: Self) -> Self {
match &self.0.super_obj {
None => Self::new(
- self.0.context.clone(),
Some(super_obj),
self.0.this_entries.clone(),
self.0.assertions.clone(),
),
Some(v) => Self::new(
- self.0.context.clone(),
Some(v.extend_from(super_obj)),
self.0.this_entries.clone(),
self.0.assertions.clone(),
@@ -95,14 +93,13 @@
}
}
pub fn with_this(&self, this_obj: Self) -> Self {
- Self(Rc::new(ObjValueInternals {
- context: self.0.context.clone(),
+ Self(Gc::new(ObjValueInternals {
super_obj: self.0.super_obj.clone(),
assertions: self.0.assertions.clone(),
- assertions_ran: RefCell::new(FxHashSet::default()),
+ assertions_ran: GcCell::new(FxHashSet::default()),
this_obj: Some(this_obj),
this_entries: self.0.this_entries.clone(),
- value_cache: RefCell::new(FxHashMap::default()),
+ value_cache: GcCell::new(FxHashMap::default()),
}))
}
@@ -203,12 +200,7 @@
pub fn extend_with_field(self, key: IStr, value: ObjMember) -> Self {
let mut new = FxHashMap::with_capacity_and_hasher(1, BuildHasherDefault::default());
new.insert(key, value);
- Self::new(
- Context::new(),
- Some(self),
- Rc::new(new),
- Rc::new(Vec::new()),
- )
+ Self::new(Some(self), Gc::new(new), Gc::new(Vec::new()))
}
fn get_raw(&self, key: IStr, real_this: Option<&Self>) -> Result<Option<Val>> {
@@ -249,13 +241,7 @@
fn run_assertions_raw(&self, real_this: &Self) -> Result<()> {
if self.0.assertions_ran.borrow_mut().insert(real_this.clone()) {
for assertion in self.0.assertions.iter() {
- if let Err(e) = evaluate_assert(
- self.0
- .context
- .clone()
- .with_this_super(real_this.clone(), self.0.super_obj.clone()),
- assertion,
- ) {
+ if let Err(e) = assertion.run(Some(real_this.clone()), self.0.super_obj.clone()) {
self.0.assertions_ran.borrow_mut().remove(real_this);
return Err(e);
}
@@ -271,19 +257,19 @@
}
pub fn ptr_eq(a: &Self, b: &Self) -> bool {
- Rc::ptr_eq(&a.0, &b.0)
+ Gc::ptr_eq(&a.0, &b.0)
}
}
impl PartialEq for ObjValue {
fn eq(&self, other: &Self) -> bool {
- Rc::ptr_eq(&self.0, &other.0)
+ Gc::ptr_eq(&self.0, &other.0)
}
}
impl Eq for ObjValue {}
impl Hash for ObjValue {
- fn hash<H: Hasher>(&self, state: &mut H) {
- state.write_usize(Rc::as_ptr(&self.0) as usize)
+ fn hash<H: Hasher>(&self, hasher: &mut H) {
+ hasher.write_usize(&*self.0 as *const _ as usize)
}
}
crates/jrsonnet-evaluator/src/typed.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/typed.rs
+++ b/crates/jrsonnet-evaluator/src/typed.rs
@@ -4,6 +4,7 @@
error::{Error, LocError, Result},
push, Val,
};
+use jrsonnet_gc::Trace;
use jrsonnet_parser::ExprLocation;
use jrsonnet_types::{ComplexValType, ValType};
use thiserror::Error;
@@ -20,7 +21,8 @@
}};
}
-#[derive(Debug, Error, Clone)]
+#[derive(Debug, Error, Clone, Trace)]
+#[trivially_drop]
pub enum TypeError {
#[error("expected {0}, got {1}")]
ExpectedGot(ComplexValType, ValType),
@@ -37,7 +39,8 @@
}
}
-#[derive(Debug, Clone)]
+#[derive(Debug, Clone, Trace)]
+#[trivially_drop]
pub struct TypeLocError(Box<TypeError>, ValuePathStack);
impl From<TypeError> for TypeLocError {
fn from(e: TypeError) -> Self {
@@ -59,7 +62,8 @@
}
}
-#[derive(Debug, Clone)]
+#[derive(Debug, Clone, Trace)]
+#[trivially_drop]
pub struct TypeLocErrorList(Vec<TypeLocError>);
impl Display for TypeLocErrorList {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
@@ -122,7 +126,8 @@
}
}
-#[derive(Clone, Debug)]
+#[derive(Clone, Debug, Trace)]
+#[trivially_drop]
enum ValuePathItem {
Field(Rc<str>),
Index(u64),
@@ -137,7 +142,8 @@
}
}
-#[derive(Clone, Debug)]
+#[derive(Clone, Debug, Trace)]
+#[trivially_drop]
struct ValuePathStack(Vec<ValuePathItem>);
impl Display for ValuePathStack {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
crates/jrsonnet-evaluator/src/val.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/val.rs
+++ b/crates/jrsonnet-evaluator/src/val.rs
@@ -3,52 +3,67 @@
call_builtin,
manifest::{manifest_json_ex, ManifestJsonOptions, ManifestType},
},
- error::Error::*,
+ error::{Error::*, LocError},
evaluate,
function::{parse_function_call, parse_function_call_map, place_args},
native::NativeCallback,
throw, with_state, Context, ObjValue, Result,
};
+use jrsonnet_gc::{Finalize, Gc, GcCell, Trace};
use jrsonnet_interner::IStr;
use jrsonnet_parser::{el, Arg, ArgsDesc, Expr, ExprLocation, LiteralType, LocExpr, ParamsDesc};
use jrsonnet_types::ValType;
-use std::{cell::RefCell, collections::HashMap, fmt::Debug, rc::Rc};
+use std::{collections::HashMap, fmt::Debug, rc::Rc};
+pub trait LazyValValue: Trace {
+ fn get(self: Box<Self>) -> Result<Val>;
+}
+
+#[derive(Trace)]
+#[trivially_drop]
enum LazyValInternals {
Computed(Val),
- Waiting(Box<dyn Fn() -> Result<Val>>),
+ Errored(LocError),
+ Waiting(Box<dyn LazyValValue>),
+ Pending,
}
-#[derive(Clone)]
-pub struct LazyVal(Rc<RefCell<LazyValInternals>>);
+
+#[derive(Clone, Trace)]
+#[trivially_drop]
+pub struct LazyVal(Gc<GcCell<LazyValInternals>>);
impl LazyVal {
- pub fn new(f: Box<dyn Fn() -> Result<Val>>) -> Self {
- Self(Rc::new(RefCell::new(LazyValInternals::Waiting(f))))
+ pub fn new(f: Box<dyn LazyValValue>) -> Self {
+ Self(Gc::new(GcCell::new(LazyValInternals::Waiting(f))))
}
pub fn new_resolved(val: Val) -> Self {
- Self(Rc::new(RefCell::new(LazyValInternals::Computed(val))))
+ Self(Gc::new(GcCell::new(LazyValInternals::Computed(val))))
}
pub fn evaluate(&self) -> Result<Val> {
- let new_value = match &*self.0.borrow() {
+ match &*self.0.borrow() {
LazyValInternals::Computed(v) => return Ok(v.clone()),
- LazyValInternals::Waiting(f) => f()?,
+ LazyValInternals::Errored(e) => return Err(e.clone()),
+ LazyValInternals::Pending => return Err(RecursiveLazyValueEvaluation.into()),
+ _ => (),
+ };
+ let value = if let LazyValInternals::Waiting(value) =
+ std::mem::replace(&mut *self.0.borrow_mut(), LazyValInternals::Pending)
+ {
+ value
+ } else {
+ unreachable!()
+ };
+ let new_value = match value.get() {
+ Ok(v) => v,
+ Err(e) => {
+ *self.0.borrow_mut() = LazyValInternals::Errored(e.clone());
+ return Err(e);
+ }
};
*self.0.borrow_mut() = LazyValInternals::Computed(new_value.clone());
Ok(new_value)
}
}
-#[macro_export]
-macro_rules! lazy_val {
- ($f: expr) => {
- $crate::LazyVal::new(Box::new($f))
- };
-}
-#[macro_export]
-macro_rules! resolved_lazy_val {
- ($f: expr) => {
- $crate::LazyVal::new_resolved($f)
- };
-}
impl Debug for LazyVal {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
write!(f, "Lazy")
@@ -56,11 +71,12 @@
}
impl PartialEq for LazyVal {
fn eq(&self, other: &Self) -> bool {
- Rc::ptr_eq(&self.0, &other.0)
+ Gc::ptr_eq(&self.0, &other.0)
}
}
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Trace)]
+#[trivially_drop]
pub struct FuncDesc {
pub name: IStr,
pub ctx: Context,
@@ -68,14 +84,15 @@
pub body: LocExpr,
}
-#[derive(Debug)]
+#[derive(Debug, Trace)]
+#[trivially_drop]
pub enum FuncVal {
/// Plain function implemented in jsonnet
Normal(FuncDesc),
/// Standard library function
Intrinsic(IStr),
/// Library functions implemented in native
- NativeExt(IStr, Rc<NativeCallback>),
+ NativeExt(IStr, Gc<NativeCallback>),
}
impl PartialEq for FuncVal {
@@ -172,15 +189,16 @@
String,
}
-#[derive(Debug, Clone)]
+#[derive(Debug, Clone, Trace)]
+#[trivially_drop]
pub enum ArrValue {
- Lazy(Rc<Vec<LazyVal>>),
- Eager(Rc<Vec<Val>>),
+ Lazy(Gc<Vec<LazyVal>>),
+ Eager(Gc<Vec<Val>>),
Extended(Box<(Self, Self)>),
}
impl ArrValue {
pub fn new_eager() -> Self {
- Self::Eager(Rc::new(Vec::new()))
+ Self::Eager(Gc::new(Vec::new()))
}
pub fn len(&self) -> usize {
@@ -231,14 +249,14 @@
}
}
- pub fn evaluated(&self) -> Result<Rc<Vec<Val>>> {
+ pub fn evaluated(&self) -> Result<Gc<Vec<Val>>> {
Ok(match self {
Self::Lazy(vec) => {
let mut out = Vec::with_capacity(vec.len());
for item in vec.iter() {
out.push(item.evaluate()?);
}
- Rc::new(out)
+ Gc::new(out)
}
Self::Eager(vec) => vec.clone(),
Self::Extended(_v) => {
@@ -246,7 +264,7 @@
for item in self.iter() {
out.push(item?);
}
- Rc::new(out)
+ Gc::new(out)
}
})
}
@@ -272,12 +290,12 @@
Self::Lazy(vec) => {
let mut out = (&vec as &Vec<_>).clone();
out.reverse();
- Self::Lazy(Rc::new(out))
+ Self::Lazy(Gc::new(out))
}
Self::Eager(vec) => {
let mut out = (&vec as &Vec<_>).clone();
out.reverse();
- Self::Eager(Rc::new(out))
+ Self::Eager(Gc::new(out))
}
Self::Extended(b) => Self::Extended(Box::new((b.1.reversed(), b.0.reversed()))),
}
@@ -290,7 +308,7 @@
out.push(mapper(value?)?);
}
- Ok(Self::Eager(Rc::new(out)))
+ Ok(Self::Eager(Gc::new(out)))
}
pub fn filter(self, filter: impl Fn(&Val) -> Result<bool>) -> Result<Self> {
@@ -303,13 +321,13 @@
}
}
- Ok(Self::Eager(Rc::new(out)))
+ Ok(Self::Eager(Gc::new(out)))
}
pub fn ptr_eq(a: &Self, b: &Self) -> bool {
match (a, b) {
- (Self::Lazy(a), Self::Lazy(b)) => Rc::ptr_eq(a, b),
- (Self::Eager(a), Self::Eager(b)) => Rc::ptr_eq(a, b),
+ (Self::Lazy(a), Self::Lazy(b)) => Gc::ptr_eq(a, b),
+ (Self::Eager(a), Self::Eager(b)) => Gc::ptr_eq(a, b),
_ => false,
}
}
@@ -317,17 +335,77 @@
impl From<Vec<LazyVal>> for ArrValue {
fn from(v: Vec<LazyVal>) -> Self {
- Self::Lazy(Rc::new(v))
+ Self::Lazy(Gc::new(v))
}
}
impl From<Vec<Val>> for ArrValue {
fn from(v: Vec<Val>) -> Self {
- Self::Eager(Rc::new(v))
+ Self::Eager(Gc::new(v))
+ }
+}
+
+#[derive(Debug)]
+pub struct DebugGcTraceValue {
+ name: IStr,
+ pub value: Box<Val>,
+}
+impl DebugGcTraceValue {
+ fn print(&self, action: &str) {
+ println!("{} {}#{:?}", action, self.name, &*self.value as *const _)
+ }
+}
+impl Finalize for DebugGcTraceValue {
+ fn finalize(&self) {
+ self.print("Garbage-collecting")
+ }
+}
+impl Drop for DebugGcTraceValue {
+ fn drop(&mut self) {
+ self.print("Garbage-collected")
+ }
+}
+unsafe impl Trace for DebugGcTraceValue {
+ unsafe fn trace(&self) {
+ self.print("Traced");
+ self.value.trace()
+ }
+ unsafe fn root(&self) {
+ self.print("Rooted");
+ self.value.root()
+ }
+ unsafe fn unroot(&self) {
+ self.print("Unrooted");
+ self.value.unroot()
+ }
+ fn finalize_glue(&self) {
+ Finalize::finalize(self)
+ }
+}
+impl Clone for DebugGcTraceValue {
+ fn clone(&self) -> Self {
+ self.print("Cloned");
+ let value = Self {
+ name: self.name.clone(),
+ value: self.value.clone(),
+ };
+ value.print("I'm clone");
+ value
}
}
+impl DebugGcTraceValue {
+ pub fn create(name: IStr, value: Val) -> Val {
+ let value = Self {
+ name,
+ value: Box::new(value),
+ };
+ value.print("Constructed");
+ Val::DebugGcTraceValue(value)
+ }
+}
-#[derive(Debug, Clone)]
+#[derive(Debug, Clone, Trace)]
+#[trivially_drop]
pub enum Val {
Bool(bool),
Null,
@@ -335,7 +413,8 @@
Num(f64),
Arr(ArrValue),
Obj(ObjValue),
- Func(Rc<FuncVal>),
+ Func(Gc<FuncVal>),
+ DebugGcTraceValue(DebugGcTraceValue),
}
macro_rules! matches_unwrap {
@@ -368,7 +447,7 @@
pub fn unwrap_num(self) -> Result<f64> {
Ok(matches_unwrap!(self, Self::Num(v), v))
}
- pub fn unwrap_func(self) -> Result<Rc<FuncVal>> {
+ pub fn unwrap_func(self) -> Result<Gc<FuncVal>> {
Ok(matches_unwrap!(self, Self::Func(v), v))
}
pub fn try_cast_bool(self, context: &'static str) -> Result<bool> {
@@ -392,6 +471,7 @@
Self::Bool(_) => ValType::Bool,
Self::Null => ValType::Null,
Self::Func(..) => ValType::Func,
+ Self::DebugGcTraceValue(v) => v.value.value_type(),
}
}
crates/jrsonnet-interner/Cargo.tomldiffbeforeafterboth--- a/crates/jrsonnet-interner/Cargo.toml
+++ b/crates/jrsonnet-interner/Cargo.toml
@@ -9,3 +9,4 @@
[dependencies]
serde = { version = "1.0" }
rustc-hash = "1.1.0"
+jrsonnet-gc = { version = "0.4.2", features = ["derive"] }
crates/jrsonnet-interner/src/lib.rsdiffbeforeafterboth--- a/crates/jrsonnet-interner/src/lib.rs
+++ b/crates/jrsonnet-interner/src/lib.rs
@@ -1,3 +1,4 @@
+use jrsonnet_gc::{unsafe_empty_trace, Finalize, Trace};
use rustc_hash::FxHashMap;
use serde::{Deserialize, Serialize};
use std::{
@@ -10,6 +11,10 @@
#[derive(Clone, PartialOrd, Ord, Eq)]
pub struct IStr(Rc<str>);
+impl Finalize for IStr {}
+unsafe impl Trace for IStr {
+ unsafe_empty_trace!();
+}
impl Deref for IStr {
type Target = str;
crates/jrsonnet-parser/Cargo.tomldiffbeforeafterboth--- a/crates/jrsonnet-parser/Cargo.toml
+++ b/crates/jrsonnet-parser/Cargo.toml
@@ -18,6 +18,7 @@
unescape = "0.1.0"
serde = { version = "1.0", features = ["derive", "rc"], optional = true }
+jrsonnet-gc = { version = "0.4.2", features = ["derive"] }
[dev-dependencies]
jrsonnet-stdlib = { path = "../jrsonnet-stdlib", version = "0.3.8" }
crates/jrsonnet-parser/src/expr.rsdiffbeforeafterboth--- a/crates/jrsonnet-parser/src/expr.rs
+++ b/crates/jrsonnet-parser/src/expr.rs
@@ -1,3 +1,4 @@
+use jrsonnet_gc::{unsafe_empty_trace, Finalize, Trace};
use jrsonnet_interner::IStr;
#[cfg(feature = "deserialize")]
use serde::Deserialize;
@@ -12,7 +13,8 @@
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Trace)]
+#[trivially_drop]
pub enum FieldName {
/// {fixed: 2}
Fixed(IStr),
@@ -22,7 +24,8 @@
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Debug, Clone, Copy, PartialEq)]
+#[derive(Debug, Clone, Copy, PartialEq, Trace)]
+#[trivially_drop]
pub enum Visibility {
/// :
Normal,
@@ -40,12 +43,14 @@
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Clone, Debug, PartialEq)]
+#[derive(Clone, Debug, PartialEq, Trace)]
+#[trivially_drop]
pub struct AssertStmt(pub LocExpr, pub Option<LocExpr>);
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Trace)]
+#[trivially_drop]
pub struct FieldMember {
pub name: FieldName,
pub plus: bool,
@@ -56,7 +61,8 @@
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Trace)]
+#[trivially_drop]
pub enum Member {
Field(FieldMember),
BindStmt(BindSpec),
@@ -65,13 +71,15 @@
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Debug, Clone, Copy, PartialEq)]
+#[derive(Debug, Clone, Copy, PartialEq, Trace)]
+#[trivially_drop]
pub enum UnaryOpType {
Plus,
Minus,
BitNot,
Not,
}
+
impl Display for UnaryOpType {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
use UnaryOpType::*;
@@ -90,7 +98,8 @@
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Debug, Clone, Copy, PartialEq)]
+#[derive(Debug, Clone, Copy, PartialEq, Trace)]
+#[trivially_drop]
pub enum BinaryOpType {
Mul,
Div,
@@ -119,6 +128,7 @@
And,
Or,
}
+
impl Display for BinaryOpType {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
use BinaryOpType::*;
@@ -152,7 +162,8 @@
/// name, default value
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Trace)]
+#[trivially_drop]
pub struct Param(pub IStr, pub Option<LocExpr>);
/// Defined function parameters
@@ -160,6 +171,14 @@
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
#[derive(Debug, Clone, PartialEq)]
pub struct ParamsDesc(pub Rc<Vec<Param>>);
+
+/// Safety:
+/// AST is acyclic, and there should be no gc pointers
+unsafe impl Trace for ParamsDesc {
+ unsafe_empty_trace!();
+}
+impl Finalize for ParamsDesc {}
+
impl Deref for ParamsDesc {
type Target = Vec<Param>;
fn deref(&self) -> &Self::Target {
@@ -169,13 +188,16 @@
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Trace)]
+#[trivially_drop]
pub struct Arg(pub Option<String>, pub LocExpr);
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Trace)]
+#[trivially_drop]
pub struct ArgsDesc(pub Vec<Arg>);
+
impl Deref for ArgsDesc {
type Target = Vec<Arg>;
fn deref(&self) -> &Self::Target {
@@ -185,7 +207,8 @@
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Trace)]
+#[trivially_drop]
pub struct BindSpec {
pub name: IStr,
pub params: Option<ParamsDesc>,
@@ -194,17 +217,20 @@
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Trace)]
+#[trivially_drop]
pub struct IfSpecData(pub LocExpr);
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Trace)]
+#[trivially_drop]
pub struct ForSpecData(pub IStr, pub LocExpr);
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Trace)]
+#[trivially_drop]
pub enum CompSpec {
IfSpec(IfSpecData),
ForSpec(ForSpecData),
@@ -212,7 +238,8 @@
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Trace)]
+#[trivially_drop]
pub struct ObjComp {
pub pre_locals: Vec<BindSpec>,
pub key: LocExpr,
@@ -223,7 +250,8 @@
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Trace)]
+#[trivially_drop]
pub enum ObjBody {
MemberList(Vec<Member>),
ObjComp(ObjComp),
@@ -231,7 +259,8 @@
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Debug, PartialEq, Clone, Copy)]
+#[derive(Debug, PartialEq, Clone, Copy, Trace)]
+#[trivially_drop]
pub enum LiteralType {
This,
Super,
@@ -241,7 +270,8 @@
False,
}
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Trace)]
+#[trivially_drop]
pub struct SliceDesc {
pub start: Option<LocExpr>,
pub end: Option<LocExpr>,
@@ -251,7 +281,8 @@
/// Syntax base
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Trace)]
+#[trivially_drop]
pub enum Expr {
Literal(LiteralType),
@@ -319,8 +350,10 @@
/// file, begin offset, end offset
#[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
-#[derive(Clone, PartialEq)]
+#[derive(Clone, PartialEq, Trace)]
+#[trivially_drop]
pub struct ExprLocation(pub Rc<Path>, pub usize, pub usize);
+
impl Debug for ExprLocation {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
write!(f, "{:?}:{:?}-{:?}", self.0, self.1, self.2)
@@ -332,6 +365,13 @@
#[cfg_attr(feature = "deserialize", derive(Deserialize))]
#[derive(Clone, PartialEq)]
pub struct LocExpr(pub Rc<Expr>, pub Option<ExprLocation>);
+/// Safety:
+/// AST is acyclic, and there should be no gc pointers
+unsafe impl Trace for LocExpr {
+ unsafe_empty_trace!();
+}
+impl Finalize for LocExpr {}
+
impl Debug for LocExpr {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
if f.alternate() {
crates/jrsonnet-types/Cargo.tomldiffbeforeafterboth--- a/crates/jrsonnet-types/Cargo.toml
+++ b/crates/jrsonnet-types/Cargo.toml
@@ -8,3 +8,4 @@
[dependencies]
peg = "0.7.0"
+jrsonnet-gc = { version = "0.4.2", features = ["derive"] }
crates/jrsonnet-types/src/lib.rsdiffbeforeafterboth--- a/crates/jrsonnet-types/src/lib.rs
+++ b/crates/jrsonnet-types/src/lib.rs
@@ -1,5 +1,6 @@
#![allow(clippy::redundant_closure_call)]
+use jrsonnet_gc::Trace;
use std::fmt::Display;
#[macro_export]
@@ -77,7 +78,8 @@
);
}
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Trace)]
+#[trivially_drop]
pub enum ValType {
Bool,
Null,
@@ -109,7 +111,8 @@
}
}
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Trace)]
+#[trivially_drop]
pub enum ComplexValType {
Any,
Char,
@@ -123,6 +126,7 @@
Sum(Vec<ComplexValType>),
SumRef(&'static [ComplexValType]),
}
+
impl From<ValType> for ComplexValType {
fn from(s: ValType) -> Self {
Self::Simple(s)
flake.lockdiffbeforeafterboth--- a/flake.lock
+++ b/flake.lock
@@ -2,11 +2,11 @@
"nodes": {
"flake-utils": {
"locked": {
- "lastModified": 1614513358,
- "narHash": "sha256-LakhOx3S1dRjnh0b5Dg3mbZyH0ToC9I8Y2wKSkBaTzU=",
+ "lastModified": 1623875721,
+ "narHash": "sha256-A8BU7bjS5GirpAUv4QA+QnJ4CceLHkcXdRp4xITDB0s=",
"owner": "numtide",
"repo": "flake-utils",
- "rev": "5466c5bbece17adaab2d82fae80b46e807611bf3",
+ "rev": "f7e004a55b120c02ecb6219596820fcd32ca8772",
"type": "github"
},
"original": {
@@ -17,11 +17,11 @@
},
"nixpkgs": {
"locked": {
- "lastModified": 1615532953,
- "narHash": "sha256-SWpaGjrp/INzorEqMz3HLi6Uuk9I0KAn4YS8B4n3q5g=",
+ "lastModified": 1625281901,
+ "narHash": "sha256-DkZDtTIPzhXATqIps2ifNFpnI+PTcfMYdcrx/oFm00Q=",
"owner": "NixOS",
"repo": "nixpkgs",
- "rev": "916ee862e87ac5ee2439f2fb7856386b4dc906ae",
+ "rev": "09c38c29f2c719cd76ca17a596c2fdac9e186ceb",
"type": "github"
},
"original": {
flake.nixdiffbeforeafterboth--- a/flake.nix
+++ b/flake.nix
@@ -12,7 +12,7 @@
pname = "jrsonnet";
version = "0.1.0";
src = self;
- cargoSha256 = "sha256-6VhaQi3L2LWzR0cq7oRG81MDbrKJbzSNPcvYSoQ5ISo=";
+ cargoSha256 = "sha256-cez8pJ/uwj+PHAPQwpSB4CKaxcP8Uvv8xguOrVXR2xE=";
};
in {
defaultPackage = jrsonnet;