git.delta.rocks / unique-network / refs/commits / f921c0198e51

difftreelog

tests: remove scheduler from required pallets + fix some lint warnings

Fahrrader2022-10-19parent: #3896cd1.patch.diff
in: master

4 files changed

modifiedtests/src/eth/base.test.tsdiffbeforeafterboth
--- a/tests/src/eth/base.test.ts
+++ b/tests/src/eth/base.test.ts
@@ -14,8 +14,6 @@
 // You should have received a copy of the GNU General Public License
 // along with Unique Network. If not, see <http://www.gnu.org/licenses/>.
 
-import {Contract} from 'web3-eth-contract';
-
 import {IKeyringPair} from '@polkadot/types/types';
 import {EthUniqueHelper, itEth, usingEthPlaygrounds, expect} from './util';
 
@@ -93,7 +91,7 @@
       const donor = await privateKey({filename: __filename});
       const [alice] = await helper.arrange.createAccounts([10n], donor);
       ({collectionId: simpleNftCollectionId} = await helper.nft.mintCollection(alice, {name: 'test', description: 'test', tokenPrefix: 'test'}));
-      minter = helper.eth.createAccount();
+      minter = await helper.eth.createAccountWithBalance(donor);
       ({collectionId: erc721MetadataCompatibleNftCollectionId} = await helper.eth.createERC721MetadataCompatibleNFTCollection(minter, 'n', 'd', 'p', BASE_URI));
     });
   });
modifiedtests/src/eth/collectionProperties.test.tsdiffbeforeafterboth
--- a/tests/src/eth/collectionProperties.test.ts
+++ b/tests/src/eth/collectionProperties.test.ts
@@ -18,7 +18,6 @@
 import {Pallets} from '../util';
 import {IProperty, ITokenPropertyPermission} from '../util/playgrounds/types';
 import {IKeyringPair} from '@polkadot/types/types';
-import {Contract} from 'web3-eth-contract';
 
 describe('EVM collection properties', () => {
   let donor: IKeyringPair;
@@ -99,7 +98,7 @@
     const contract = helper.ethNativeContract.collectionById(collectionId, mode, caller);
     await contract.methods.addCollectionAdmin(bruh).send(); // to check that admin will work too
 
-    const collection1 = await helper.nft.getCollectionObject(collectionId);
+    const collection1 = helper.nft.getCollectionObject(collectionId);
     const data1 = await collection1.getData();
     expect(data1?.raw.flags.erc721metadata).to.be.false;
     expect(await contract.methods.supportsInterface('0x5b5e139f').call()).to.be.false;
@@ -109,18 +108,18 @@
 
     expect(await contract.methods.supportsInterface('0x5b5e139f').call()).to.be.true;
 
-    const collection2 = await helper.nft.getCollectionObject(collectionId);
+    const collection2 = helper.nft.getCollectionObject(collectionId);
     const data2 = await collection2.getData();
     expect(data2?.raw.flags.erc721metadata).to.be.true;
 
-    const TPPs = data2?.raw.tokenPropertyPermissions;
-    expect(TPPs?.length).to.equal(2);
+    const propertyPermissions = data2?.raw.tokenPropertyPermissions;
+    expect(propertyPermissions?.length).to.equal(2);
 
-    expect(TPPs.find((tpp: ITokenPropertyPermission) => {
+    expect(propertyPermissions.find((tpp: ITokenPropertyPermission) => {
       return tpp.key === 'URI' && tpp.permission.mutable && tpp.permission.collectionAdmin && !tpp.permission.tokenOwner;
     })).to.be.not.null;
 
-    expect(TPPs.find((tpp: ITokenPropertyPermission) => {
+    expect(propertyPermissions.find((tpp: ITokenPropertyPermission) => {
       return tpp.key === 'URISuffix' && tpp.permission.mutable && tpp.permission.collectionAdmin && !tpp.permission.tokenOwner;
     })).to.be.not.null;
 
modifiedtests/src/eth/util/index.tsdiffbeforeafterboth
--- a/tests/src/eth/util/index.ts
+++ b/tests/src/eth/util/index.ts
@@ -14,7 +14,7 @@
 import chai from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 import chaiLike from 'chai-like';
-import {getTestSeed, requirePalletsOrSkip} from '../../util';
+import {getTestSeed, MINIMUM_DONOR_FUND, requirePalletsOrSkip} from '../../util';
 
 chai.use(chaiAsPromised);
 chai.use(chaiLike);
@@ -43,7 +43,7 @@
       else {
         const actualSeed = getTestSeed(seed.filename);
         let account = helper.util.fromSeed(actualSeed, ss58Format);
-        if (await helper.balance.getSubstrate(account.address) == 0n) {
+        if (await helper.balance.getSubstrate(account.address) < MINIMUM_DONOR_FUND) {
           console.warn(`${path.basename(seed.filename)}: Not enough funds present on the filename account. Using the default one as the donor instead.`);
           account = helper.util.fromSeed('//Alice', ss58Format);
         }
modifiedtests/src/pallet-presence.test.tsdiffbeforeafterboth
before · tests/src/pallet-presence.test.ts
1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617import {itSub, usingPlaygrounds, expect} from './util';1819// Pallets that must always be present20const requiredPallets = [21  'balances',22  'common',23  'randomnesscollectiveflip',24  'timestamp',25  'transactionpayment',26  'treasury',27  'structure',28  'system',29  'vesting',30  'parachainsystem',31  'parachaininfo',32  'evm',33  'evmcodersubstrate',34  'evmcontracthelpers',35  'evmmigration',36  'evmtransactionpayment',37  'ethereum',38  'fungible',39  'xcmpqueue',40  'polkadotxcm',41  'cumulusxcm',42  'dmpqueue',43  'inflation',44  'unique',45  'nonfungible',46  'charging',47  'configuration',48  'tokens',49  'xtokens',50];5152// Pallets that depend on consensus and governance configuration53const consensusPallets = [54  'sudo',55  'aura',56  'auraext',57];5859describe('Pallet presence', () => {60  before(async () => {61    await usingPlaygrounds(async helper => {62      const chain = await helper.callRpc('api.rpc.system.chain', []);6364      const refungible = 'refungible';65      const scheduler = 'scheduler';66      const foreignAssets = 'foreignassets';67      const rmrkPallets = ['rmrkcore', 'rmrkequip'];68      const appPromotion = 'apppromotion';6970      if (chain.eq('OPAL by UNIQUE')) {71        requiredPallets.push(72          refungible,73          scheduler,74          foreignAssets,75          appPromotion,76          ...rmrkPallets,77        );78      } else if (chain.eq('QUARTZ by UNIQUE')) {79        requiredPallets.push(refungible);80      } else if (chain.eq('UNIQUE')) {81        // Insert Unique additional pallets here82      }83    });84  });8586  itSub('Required pallets are present', async ({helper}) => {87    expect(helper.fetchAllPalletNames()).to.contain.members([...requiredPallets]);88  });8990  itSub('Governance and consensus pallets are present', async ({helper}) => {91    expect(helper.fetchAllPalletNames()).to.contain.members([...consensusPallets]);92  });9394  itSub('No extra pallets are included', async ({helper}) => {95    expect(helper.fetchAllPalletNames().sort()).to.be.deep.equal([...requiredPallets, ...consensusPallets].sort());96  });97});
after · tests/src/pallet-presence.test.ts
1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617import {itSub, usingPlaygrounds, expect} from './util';1819// Pallets that must always be present20const requiredPallets = [21  'balances',22  'common',23  'randomnesscollectiveflip',24  'timestamp',25  'transactionpayment',26  'treasury',27  'structure',28  'system',29  'vesting',30  'parachainsystem',31  'parachaininfo',32  'evm',33  'evmcodersubstrate',34  'evmcontracthelpers',35  'evmmigration',36  'evmtransactionpayment',37  'ethereum',38  'fungible',39  'xcmpqueue',40  'polkadotxcm',41  'cumulusxcm',42  'dmpqueue',43  'inflation',44  'unique',45  'nonfungible',46  'charging',47  'configuration',48  'tokens',49  'xtokens',50];5152// Pallets that depend on consensus and governance configuration53const consensusPallets = [54  'sudo',55  'aura',56  'auraext',57];5859describe('Pallet presence', () => {60  before(async () => {61    await usingPlaygrounds(async helper => {62      const chain = await helper.callRpc('api.rpc.system.chain', []);6364      const refungible = 'refungible';65      // const scheduler = 'scheduler';66      const foreignAssets = 'foreignassets';67      const rmrkPallets = ['rmrkcore', 'rmrkequip'];68      const appPromotion = 'apppromotion';6970      if (chain.eq('OPAL by UNIQUE')) {71        requiredPallets.push(72          refungible,73          // scheduler,74          foreignAssets,75          appPromotion,76          ...rmrkPallets,77        );78      } else if (chain.eq('QUARTZ by UNIQUE')) {79        requiredPallets.push(refungible);80      } else if (chain.eq('UNIQUE')) {81        // Insert Unique additional pallets here82      }83    });84  });8586  itSub('Required pallets are present', async ({helper}) => {87    expect(helper.fetchAllPalletNames()).to.contain.members([...requiredPallets]);88  });8990  itSub('Governance and consensus pallets are present', async ({helper}) => {91    expect(helper.fetchAllPalletNames()).to.contain.members([...consensusPallets]);92  });9394  itSub('No extra pallets are included', async ({helper}) => {95    expect(helper.fetchAllPalletNames().sort()).to.be.deep.equal([...requiredPallets, ...consensusPallets].sort());96  });97});