git.delta.rocks / unique-network / refs/commits / f66a1ba0392c

--- a/tests/src/eth/fungible.test.ts
+++ b/tests/src/eth/fungible.test.ts
@@ -277,7 +277,7 @@
     }
   });
 
-  itEth('Cannot transferCross() more than have', async ({helper}) => {
+  ['transfer', 'transferCross'].map(testCase => itEth(`Cannot ${testCase} incorrect amount`, async ({helper}) => {
     const sender = await helper.eth.createAccountWithBalance(donor);
     const receiverEth = await helper.eth.createAccountWithBalance(donor);
     const receiverCrossEth = helper.ethCrossAccount.fromAddress(receiverEth);
@@ -289,8 +289,13 @@
     const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);
     const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'ft', sender);
 
-    await expect(collectionEvm.methods.transferCross(receiverCrossEth, BALANCE_TO_TRANSFER).send({from: sender})).to.be.rejected;
-  });
+    // 1. Cannot transfer more than have
+    const receiver = testCase === 'transfer' ? receiverEth : receiverCrossEth;
+    await expect(collectionEvm.methods[testCase](receiver, BALANCE_TO_TRANSFER).send({from: sender})).to.be.rejected;
+    // 2. Zero transfer not allowed
+    await expect(collectionEvm.methods[testCase](receiver, 0n).send({from: sender})).to.be.rejected;
+  }));
+  
   
   itEth('Can perform transfer()', async ({helper}) => {
     const owner = await helper.eth.createAccountWithBalance(donor);

--- a/tests/src/eth/nonFungible.test.ts
+++ b/tests/src/eth/nonFungible.test.ts
@@ -517,6 +517,26 @@
       expect(receiverBalance).to.contain(tokenId);
     }
   });
+
+  ['transfer', 'transferCross'].map(testCase => itEth(`Cannot ${testCase} non-owned token`, async ({helper}) => {
+    const sender = await helper.eth.createAccountWithBalance(donor);
+    const tokenOwner = await helper.eth.createAccountWithBalance(donor);
+    const receiverSub = minter;
+    const receiverCrossSub = helper.ethCrossAccount.fromKeyringPair(minter);
+
+    const collection = await helper.nft.mintCollection(minter, {});
+    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);
+    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', sender);
+
+    await collection.mintToken(minter, {Ethereum: sender});
+    const nonSendersToken = await collection.mintToken(minter, {Ethereum: tokenOwner});
+
+    // Cannot transferCross someone else's token:
+    const receiver = testCase === 'transfer' ? helper.address.substrateToEth(receiverSub.address) : receiverCrossSub;
+    await expect(collectionEvm.methods[testCase](receiver, nonSendersToken.tokenId).send({from: sender})).to.be.rejected;
+    // Cannot transfer token if it does not exist:
+    await expect(collectionEvm.methods[testCase](receiver, 999999).send({from: sender})).to.be.rejected;
+  }));
 });
 
 describe('NFT: Fees', () => {

413    }413    }
414  });414  });
415415
416  itEth.skip('Cannot transferCross with invalid params', async ({helper}) => {416  ['transfer', 'transferCross'].map(testCase => itEth(`Cannot ${testCase} non-owned token`, async ({helper}) => {
417    const sender = await helper.eth.createAccountWithBalance(donor);417    const sender = await helper.eth.createAccountWithBalance(donor);
418    const tokenOwner = await helper.eth.createAccountWithBalance(donor);418    const tokenOwner = await helper.eth.createAccountWithBalance(donor);
419    const receiverSub = minter;
419    const receiverCrossSub = helper.ethCrossAccount.fromKeyringPair(minter);420    const receiverCrossSub = helper.ethCrossAccount.fromKeyringPair(minter);
420421
421    const collection = await helper.rft.mintCollection(minter, {});422    const collection = await helper.rft.mintCollection(minter, {});
422    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);423    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);
423    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'rft', sender);424    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'rft', sender);
424425
425    await collection.mintToken(minter, 50n, {Ethereum: sender});426    await collection.mintToken(minter, 50n, {Ethereum: sender});
426    const notSendersToken = await collection.mintToken(minter, 50n, {Ethereum: tokenOwner});427    const nonSendersToken = await collection.mintToken(minter, 50n, {Ethereum: tokenOwner});
428
427    // Cannot transferCross someone else's token:429    // Cannot transferCross someone else's token:
430    const receiver = testCase === 'transfer' ? helper.address.substrateToEth(receiverSub.address) : receiverCrossSub;
428    await expect(collectionEvm.methods.transferCross(receiverCrossSub, notSendersToken.tokenId).send({from: sender})).to.be.rejected;431    await expect(collectionEvm.methods[testCase](receiver, nonSendersToken.tokenId).send({from: sender})).to.be.rejected;
429    // FIXME: (transaction successful): Cannot transfer token if it does not exist:432    // Cannot transfer token if it does not exist:
430    await expect(collectionEvm.methods.transferCross(receiverCrossSub, 999999).send({from: sender})).to.be.rejected;433    await expect(collectionEvm.methods[testCase](receiver, 999999).send({from: sender})).to.be.rejected;
431  });434  }));
432435
433  itEth('transfer event on transfer from partial ownership to full ownership', async ({helper}) => {436  itEth('transfer event on transfer from partial ownership to full ownership', async ({helper}) => {
434    const caller = await helper.eth.createAccountWithBalance(donor);437    const caller = await helper.eth.createAccountWithBalance(donor);