git.delta.rocks / unique-network / refs/commits / f4c26435aee6

difftreelog

SBP M2 review: comments on inflation pallet's tests

Steve Degosserie2021-06-04parent: #c803bd5.patch.diff
in: master

1 file changed

modifiedpallets/inflation/src/tests.rsdiffbeforeafterboth
100 // first inflation deposit should be equal to BlockInflation100 // first inflation deposit should be equal to BlockInflation
101 Inflation::on_initialize(1);101 Inflation::on_initialize(1);
102
103 // SBP M2 review: Verify expected block inflation for year 1
102 assert!(Inflation::block_inflation() > 0);104 assert_eq!(Inflation::block_inflation(), 1901);
103 assert_eq!(Balances::free_balance(1234) - initial_issuance, Inflation::block_inflation());105 assert_eq!(Balances::free_balance(1234) - initial_issuance, Inflation::block_inflation());
104 });106 });
105 }107 }
140 Inflation::on_initialize(1);142 Inflation::on_initialize(1);
141 let block_inflation_year_0 = Inflation::block_inflation();143 let block_inflation_year_0 = Inflation::block_inflation();
144
145 // SBP M2 review: go through all the block inflations for year 1,
146 // total issuance will be updated accordingly
147 for block in (100..YEAR).step_by(100) {
148 Inflation::on_initialize(block);
149 }
150 assert_eq!(
151 initial_issuance + (1901 * (YEAR / 100)),
152 <Balances as Currency<_>>::total_issuance()
153 );
142154
143 Inflation::on_initialize(YEAR);155 Inflation::on_initialize(YEAR);
144 let block_inflation_year_1 = Inflation::block_inflation();156 let block_inflation_year_1 = Inflation::block_inflation();
145157 // SBP M2 review: Verify expected block inflation for year 2
146 // Assert that year 1 inflation is less than year 0
147 assert!(block_inflation_year_0 > block_inflation_year_1);158 assert_eq!(block_inflation_year_1, 1952);
159
160 // SBP M2 review: this is actually not true
161 // Assert that year 1 inflation is less than year 0
162 // assert!(block_inflation_year_0 > block_inflation_year_1);
148 });163 });
149 }164 }
150165
162 Inflation::on_initialize(YEAR * year);177 Inflation::on_initialize(YEAR * year);
163 let block_inflation_year_after = Inflation::block_inflation();178 let block_inflation_year_after = Inflation::block_inflation();
164179
180 // SBP M2 review: this is actually not true (not for the first few years)
165 // Assert that next year inflation is less than previous year inflation181 // Assert that next year inflation is less than previous year inflation
166 assert!(block_inflation_year_before > block_inflation_year_after);182 assert!(block_inflation_year_before > block_inflation_year_after);
167 }183 }