difftreelog
feat impl transfer, transer_from, transfer_cross, transfer_from_cross,
in: master
6 files changed
pallets/balances-adapter/src/erc.rsdiffbeforeafterboth--- a/pallets/balances-adapter/src/erc.rs
+++ b/pallets/balances-adapter/src/erc.rs
@@ -1,7 +1,10 @@
use crate::Config;
use evm_coder::{abi::AbiType, AbiCoder, ToLog, generate_stubgen, solidity_interface, types::*};
-use frame_support::traits::Currency;
-use pallet_common::erc::{CommonEvmHandler, CrossAccountId, PrecompileHandle, PrecompileResult};
+use frame_support::traits::{Currency, ExistenceRequirement};
+use pallet_common::{
+ erc::{CommonEvmHandler, CrossAccountId, PrecompileHandle, PrecompileResult},
+ eth::CrossAddress,
+};
use pallet_evm_coder_substrate::{
call, dispatch_to_evm,
execution::{PreDispatch, Result},
@@ -82,16 +85,22 @@
// #[weight(<SelfWeightOf<T>>::transfer())]
fn transfer(&mut self, caller: Caller, to: Address, amount: U256) -> Result<bool> {
- // let caller = T::CrossAccountId::from_eth(caller);
- // let to = T::CrossAccountId::from_eth(to);
- // let amount = amount.try_into().map_err(|_| "amount overflow")?;
+ let caller = T::CrossAccountId::from_eth(caller);
+ let to = T::CrossAccountId::from_eth(to);
+ let amount = amount.try_into().map_err(|_| "amount overflow")?;
// let budget = self
// .recorder
// .weight_calls_budget(<StructureWeight<T>>::find_parent());
// <Pallet<T>>::transfer(self, &caller, &to, amount, &budget).map_err(|_| "transfer error")?;
- // Ok(true)
- todo!()
+ <T as Config>::Currency::transfer(
+ caller.as_sub(),
+ to.as_sub(),
+ amount,
+ ExistenceRequirement::KeepAlive,
+ )
+ .map_err(dispatch_to_evm::<T>);
+ Ok(true)
}
// #[weight(<SelfWeightOf<T>>::transfer_from())]
@@ -102,24 +111,93 @@
to: Address,
amount: U256,
) -> Result<bool> {
- // let caller = T::CrossAccountId::from_eth(caller);
- // let from = T::CrossAccountId::from_eth(from);
- // let to = T::CrossAccountId::from_eth(to);
- // let amount = amount.try_into().map_err(|_| "amount overflow")?;
+ let caller = T::CrossAccountId::from_eth(caller);
+ let from = T::CrossAccountId::from_eth(from);
+ let to = T::CrossAccountId::from_eth(to);
+ let amount = amount.try_into().map_err(|_| "amount overflow")?;
+
+ if (from != to) {
+ return Err("no permission".into());
+ }
+ // let budget = self
+ // .recorder
+ // .weight_calls_budget(<StructureWeight<T>>::find_parent());
+
+ // <Pallet<T>>::transfer_from(self, &caller, &from, &to, amount, &budget)
+ // .map_err(dispatch_to_evm::<T>)?;
+ <T as Config>::Currency::transfer(
+ caller.as_sub(),
+ to.as_sub(),
+ amount,
+ ExistenceRequirement::KeepAlive,
+ )
+ .map_err(dispatch_to_evm::<T>);
+ Ok(true)
+ }
+}
+
+#[solidity_interface(name = ERC20UniqueExtensions, enum(derive(PreDispatch)), enum_attr(weight))]
+impl<T: Config> NativeFungibleHandle<T>
+where
+ T::AccountId: From<[u8; 32]>,
+{
+ // #[weight(<SelfWeightOf<T>>::transfer())]
+ fn transfer_cross(&mut self, caller: Caller, to: CrossAddress, amount: U256) -> Result<bool> {
+ let caller = T::CrossAccountId::from_eth(caller);
+ let to = to.into_sub_cross_account::<T>()?;
+ let amount = amount.try_into().map_err(|_| "amount overflow")?;
+ // let budget = self
+ // .recorder
+ // .weight_calls_budget(<StructureWeight<T>>::find_parent());
+
+ // <Pallet<T>>::transfer(self, &caller, &to, amount, &budget).map_err(|_| "transfer error")?;
+ <T as Config>::Currency::transfer(
+ caller.as_sub(),
+ to.as_sub(),
+ amount,
+ ExistenceRequirement::KeepAlive,
+ )
+ .map_err(dispatch_to_evm::<T>);
+ Ok(true)
+ }
+
+ // #[weight(<SelfWeightOf<T>>::transfer_from())]
+ fn transfer_from_cross(
+ &mut self,
+ caller: Caller,
+ from: CrossAddress,
+ to: CrossAddress,
+ amount: U256,
+ ) -> Result<bool> {
+ let caller = T::CrossAccountId::from_eth(caller);
+ let from = from.into_sub_cross_account::<T>()?;
+ let to = to.into_sub_cross_account::<T>()?;
+ let amount = amount.try_into().map_err(|_| "amount overflow")?;
+
+ if (from != to) {
+ return Err("no permission".into());
+ }
+
// let budget = self
// .recorder
// .weight_calls_budget(<StructureWeight<T>>::find_parent());
// <Pallet<T>>::transfer_from(self, &caller, &from, &to, amount, &budget)
// .map_err(dispatch_to_evm::<T>)?;
- // Ok(true)
- todo!()
+ <T as Config>::Currency::transfer(
+ caller.as_sub(),
+ to.as_sub(),
+ amount,
+ ExistenceRequirement::KeepAlive,
+ )
+ .map_err(dispatch_to_evm::<T>);
+ Ok(true)
}
}
#[solidity_interface(
name = UniqueNativeFungible,
- is(ERC20),
+ is(ERC20, ERC20UniqueExtensions),
enum(derive(PreDispatch))
)]
impl<T: Config> NativeFungibleHandle<T> where T::AccountId: From<[u8; 32]> + AsRef<[u8; 32]> {}
pallets/balances-adapter/src/lib.rsdiffbeforeafterboth--- a/pallets/balances-adapter/src/lib.rs
+++ b/pallets/balances-adapter/src/lib.rs
@@ -17,7 +17,7 @@
Self::AccountId,
Balance = Self::CurrencyBalance,
>;
- type CurrencyBalance: Into<U256>;
+ type CurrencyBalance: Into<U256> + TryFrom<U256>;
type Decimals: Get<u8>;
type Name: Get<String>;
pallets/balances-adapter/src/stubs/UniqueNativeFungible.rawdiffbeforeafterbothbinary blob — no preview
pallets/balances-adapter/src/stubs/UniqueNativeFungible.soldiffbeforeafterboth--- a/pallets/balances-adapter/src/stubs/UniqueNativeFungible.sol
+++ b/pallets/balances-adapter/src/stubs/UniqueNativeFungible.sol
@@ -17,6 +17,40 @@
}
}
+/// @dev the ERC-165 identifier for this interface is 0xff15c6f4
+contract ERC20UniqueExtensions is Dummy, ERC165 {
+ /// @dev EVM selector for this function is: 0x2ada85ff,
+ /// or in textual repr: transferCross((address,uint256),uint256)
+ function transferCross(CrossAddress memory to, uint256 amount) public returns (bool) {
+ require(false, stub_error);
+ to;
+ amount;
+ dummy = 0;
+ return false;
+ }
+
+ /// @dev EVM selector for this function is: 0xd5cf430b,
+ /// or in textual repr: transferFromCross((address,uint256),(address,uint256),uint256)
+ function transferFromCross(
+ CrossAddress memory from,
+ CrossAddress memory to,
+ uint256 amount
+ ) public returns (bool) {
+ require(false, stub_error);
+ from;
+ to;
+ amount;
+ dummy = 0;
+ return false;
+ }
+}
+
+/// Cross account struct
+struct CrossAddress {
+ address eth;
+ uint256 sub;
+}
+
/// @dev inlined interface
contract ERC20Events {
event Transfer(address indexed from, address indexed to, uint256 value);
@@ -25,26 +59,31 @@
/// @dev the ERC-165 identifier for this interface is 0x942e8b22
contract ERC20 is Dummy, ERC165, ERC20Events {
- /// @dev EVM selector for this function is: 0x06fdde03,
- /// or in textual repr: name()
- function name() public view returns (string memory) {
+ /// @dev EVM selector for this function is: 0xdd62ed3e,
+ /// or in textual repr: allowance(address,address)
+ function allowance(address owner, address spender) public view returns (uint256) {
require(false, stub_error);
+ owner;
+ spender;
dummy;
- return "";
+ return 0;
}
- /// @dev EVM selector for this function is: 0x95d89b41,
- /// or in textual repr: symbol()
- function symbol() public view returns (string memory) {
+ /// @dev EVM selector for this function is: 0x095ea7b3,
+ /// or in textual repr: approve(address,uint256)
+ function approve(address spender, uint256 amount) public returns (bool) {
require(false, stub_error);
- dummy;
- return "";
+ spender;
+ amount;
+ dummy = 0;
+ return false;
}
- /// @dev EVM selector for this function is: 0x18160ddd,
- /// or in textual repr: totalSupply()
- function totalSupply() public view returns (uint256) {
+ /// @dev EVM selector for this function is: 0x70a08231,
+ /// or in textual repr: balanceOf(address)
+ function balanceOf(address owner) public view returns (uint256) {
require(false, stub_error);
+ owner;
dummy;
return 0;
}
@@ -57,11 +96,26 @@
return 0;
}
- /// @dev EVM selector for this function is: 0x70a08231,
- /// or in textual repr: balanceOf(address)
- function balanceOf(address owner) public view returns (uint256) {
+ /// @dev EVM selector for this function is: 0x06fdde03,
+ /// or in textual repr: name()
+ function name() public view returns (string memory) {
+ require(false, stub_error);
+ dummy;
+ return "";
+ }
+
+ /// @dev EVM selector for this function is: 0x95d89b41,
+ /// or in textual repr: symbol()
+ function symbol() public view returns (string memory) {
+ require(false, stub_error);
+ dummy;
+ return "";
+ }
+
+ /// @dev EVM selector for this function is: 0x18160ddd,
+ /// or in textual repr: totalSupply()
+ function totalSupply() public view returns (uint256) {
require(false, stub_error);
- owner;
dummy;
return 0;
}
@@ -90,26 +144,6 @@
dummy = 0;
return false;
}
-
- /// @dev EVM selector for this function is: 0x095ea7b3,
- /// or in textual repr: approve(address,uint256)
- function approve(address spender, uint256 amount) public returns (bool) {
- require(false, stub_error);
- spender;
- amount;
- dummy = 0;
- return false;
- }
-
- /// @dev EVM selector for this function is: 0xdd62ed3e,
- /// or in textual repr: allowance(address,address)
- function allowance(address owner, address spender) public view returns (uint256) {
- require(false, stub_error);
- owner;
- spender;
- dummy;
- return 0;
- }
}
-contract UniqueNativeFungible is Dummy, ERC165, ERC20 {}
+contract UniqueNativeFungible is Dummy, ERC165, ERC20, ERC20UniqueExtensions {}
tests/src/eth/abi/nativeFungible.jsondiffbeforeafterboth--- a/tests/src/eth/abi/nativeFungible.json
+++ b/tests/src/eth/abi/nativeFungible.json
@@ -127,6 +127,24 @@
},
{
"inputs": [
+ {
+ "components": [
+ { "internalType": "address", "name": "eth", "type": "address" },
+ { "internalType": "uint256", "name": "sub", "type": "uint256" }
+ ],
+ "internalType": "struct CrossAddress",
+ "name": "to",
+ "type": "tuple"
+ },
+ { "internalType": "uint256", "name": "amount", "type": "uint256" }
+ ],
+ "name": "transferCross",
+ "outputs": [{ "internalType": "bool", "name": "", "type": "bool" }],
+ "stateMutability": "nonpayable",
+ "type": "function"
+ },
+ {
+ "inputs": [
{ "internalType": "address", "name": "from", "type": "address" },
{ "internalType": "address", "name": "to", "type": "address" },
{ "internalType": "uint256", "name": "amount", "type": "uint256" }
@@ -135,5 +153,32 @@
"outputs": [{ "internalType": "bool", "name": "", "type": "bool" }],
"stateMutability": "nonpayable",
"type": "function"
+ },
+ {
+ "inputs": [
+ {
+ "components": [
+ { "internalType": "address", "name": "eth", "type": "address" },
+ { "internalType": "uint256", "name": "sub", "type": "uint256" }
+ ],
+ "internalType": "struct CrossAddress",
+ "name": "from",
+ "type": "tuple"
+ },
+ {
+ "components": [
+ { "internalType": "address", "name": "eth", "type": "address" },
+ { "internalType": "uint256", "name": "sub", "type": "uint256" }
+ ],
+ "internalType": "struct CrossAddress",
+ "name": "to",
+ "type": "tuple"
+ },
+ { "internalType": "uint256", "name": "amount", "type": "uint256" }
+ ],
+ "name": "transferFromCross",
+ "outputs": [{ "internalType": "bool", "name": "", "type": "bool" }],
+ "stateMutability": "nonpayable",
+ "type": "function"
}
]
tests/src/eth/api/UniqueNativeFungible.soldiffbeforeafterboth12 function supportsInterface(bytes4 interfaceID) external view returns (bool);12 function supportsInterface(bytes4 interfaceID) external view returns (bool);13}13}1415/// @dev the ERC-165 identifier for this interface is 0xff15c6f416interface ERC20UniqueExtensions is Dummy, ERC165 {17 /// @dev EVM selector for this function is: 0x2ada85ff,18 /// or in textual repr: transferCross((address,uint256),uint256)19 function transferCross(CrossAddress memory to, uint256 amount) external returns (bool);2021 /// @dev EVM selector for this function is: 0xd5cf430b,22 /// or in textual repr: transferFromCross((address,uint256),(address,uint256),uint256)23 function transferFromCross(24 CrossAddress memory from,25 CrossAddress memory to,26 uint256 amount27 ) external returns (bool);28}2930/// Cross account struct31struct CrossAddress {32 address eth;33 uint256 sub;34}143515/// @dev inlined interface36/// @dev inlined interface16interface ERC20Events {37interface ERC20Events {204121/// @dev the ERC-165 identifier for this interface is 0x942e8b2242/// @dev the ERC-165 identifier for this interface is 0x942e8b2222interface ERC20 is Dummy, ERC165, ERC20Events {43interface ERC20 is Dummy, ERC165, ERC20Events {23 /// @dev EVM selector for this function is: 0x06fdde03,44 /// @dev EVM selector for this function is: 0xdd62ed3e,24 /// or in textual repr: name()45 /// or in textual repr: allowance(address,address)25 function name() external view returns (string memory);46 function allowance(address owner, address spender) external view returns (uint256);264727 /// @dev EVM selector for this function is: 0x95d89b41,48 /// @dev EVM selector for this function is: 0x095ea7b3,28 /// or in textual repr: symbol()49 /// or in textual repr: approve(address,uint256)29 function symbol() external view returns (string memory);50 function approve(address spender, uint256 amount) external returns (bool);305131 /// @dev EVM selector for this function is: 0x18160ddd,52 /// @dev EVM selector for this function is: 0x70a08231,32 /// or in textual repr: totalSupply()53 /// or in textual repr: balanceOf(address)33 function totalSupply() external view returns (uint256);54 function balanceOf(address owner) external view returns (uint256);345535 /// @dev EVM selector for this function is: 0x313ce567,56 /// @dev EVM selector for this function is: 0x313ce567,36 /// or in textual repr: decimals()57 /// or in textual repr: decimals()37 function decimals() external view returns (uint8);58 function decimals() external view returns (uint8);385939 /// @dev EVM selector for this function is: 0x70a08231,60 /// @dev EVM selector for this function is: 0x06fdde03,40 /// or in textual repr: balanceOf(address)61 /// or in textual repr: name()62 function name() external view returns (string memory);6364 /// @dev EVM selector for this function is: 0x95d89b41,65 /// or in textual repr: symbol()66 function symbol() external view returns (string memory);6768 /// @dev EVM selector for this function is: 0x18160ddd,69 /// or in textual repr: totalSupply()41 function balanceOf(address owner) external view returns (uint256);70 function totalSupply() external view returns (uint256);427143 /// @dev EVM selector for this function is: 0xa9059cbb,72 /// @dev EVM selector for this function is: 0xa9059cbb,44 /// or in textual repr: transfer(address,uint256)73 /// or in textual repr: transfer(address,uint256)52 uint256 amount81 uint256 amount53 ) external returns (bool);82 ) external returns (bool);5455 /// @dev EVM selector for this function is: 0x095ea7b3,56 /// or in textual repr: approve(address,uint256)57 function approve(address spender, uint256 amount) external returns (bool);5859 /// @dev EVM selector for this function is: 0xdd62ed3e,60 /// or in textual repr: allowance(address,address)61 function allowance(address owner, address spender) external view returns (uint256);62}83}638464interface UniqueNativeFungible is Dummy, ERC165, ERC20 {}85interface UniqueNativeFungible is Dummy, ERC165, ERC20, ERC20UniqueExtensions {}6586