git.delta.rocks / unique-network / refs/commits / ec332a0b04f6

difftreelog

refactor(pallet-refungible) disallow invalid bulk mints

Yaroslav Bolyukin2022-08-04parent: #b7c1009.patch.diff
in: master
`create_multiple_items_ex` was allowing invalid (that will be always
rejected at runtime level) refungible mint extrinsics, by passing
multiple users into `RefungibleMultipleItems` call.

5 files changed

modifiedpallets/refungible/Cargo.tomldiffbeforeafterboth
--- a/pallets/refungible/Cargo.toml
+++ b/pallets/refungible/Cargo.toml
@@ -28,6 +28,7 @@
 sp-core = { default-features = false, git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.24" }
 sp-runtime = { default-features = false, git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.24" }
 sp-std = { default-features = false, git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.24" }
+derivative = { version = "2.2.0", features = ["use_core"] }
 
 [features]
 default = ["std"]
modifiedpallets/refungible/src/common.rsdiffbeforeafterboth
--- a/pallets/refungible/src/common.rs
+++ b/pallets/refungible/src/common.rs
@@ -19,8 +19,9 @@
 use sp_std::collections::btree_map::BTreeMap;
 use frame_support::{dispatch::DispatchResultWithPostInfo, ensure, fail, weights::Weight, traits::Get};
 use up_data_structs::{
-	CollectionId, TokenId, CreateItemExData, CreateRefungibleExData, budget::Budget, Property,
-	PropertyKey, PropertyValue, PropertyKeyPermission, CreateItemData, CollectionPropertiesVec,
+	CollectionId, TokenId, CreateItemExData, budget::Budget, Property, PropertyKey, PropertyValue,
+	PropertyKeyPermission, CollectionPropertiesVec, CreateRefungibleExMultipleOwners,
+	CreateRefungibleExSingleOwner,
 };
 use pallet_common::{
 	CommonCollectionOperations, CommonWeightInfo, RefungibleExtensions, with_weight,
@@ -32,7 +33,7 @@
 
 use crate::{
 	AccountBalance, Allowance, Balance, Config, Error, Owned, Pallet, RefungibleHandle,
-	SelfWeightOf, TokenData, weights::WeightInfo, TokensMinted, TotalSupply,
+	SelfWeightOf, TokenData, weights::WeightInfo, TokensMinted, TotalSupply, CreateItemData,
 };
 
 macro_rules! max_weight_of {
@@ -58,11 +59,11 @@
 		<SelfWeightOf<T>>::create_item()
 	}
 
-	fn create_multiple_items(data: &[CreateItemData]) -> Weight {
+	fn create_multiple_items(data: &[up_data_structs::CreateItemData]) -> Weight {
 		<SelfWeightOf<T>>::create_multiple_items(data.len() as u32).saturating_add(
 			data.iter()
 				.map(|data| match data {
-					CreateItemData::ReFungible(rft_data) => {
+					up_data_structs::CreateItemData::ReFungible(rft_data) => {
 						properties_weight::<T>(&rft_data.properties)
 					}
 					_ => 0,
@@ -152,9 +153,9 @@
 fn map_create_data<T: Config>(
 	data: up_data_structs::CreateItemData,
 	to: &T::CrossAccountId,
-) -> Result<CreateRefungibleExData<T::CrossAccountId>, DispatchError> {
+) -> Result<CreateItemData<T::CrossAccountId>, DispatchError> {
 	match data {
-		up_data_structs::CreateItemData::ReFungible(data) => Ok(CreateRefungibleExData {
+		up_data_structs::CreateItemData::ReFungible(data) => Ok(CreateItemData {
 			users: {
 				let mut out = BTreeMap::new();
 				out.insert(to.clone(), data.pieces);
@@ -214,12 +215,26 @@
 	) -> DispatchResultWithPostInfo {
 		let weight = <CommonWeights<T>>::create_multiple_items_ex(&data);
 		let data = match data {
-			CreateItemExData::RefungibleMultipleOwners(r) => vec![r],
-			CreateItemExData::RefungibleMultipleItems(r)
-				if r.iter().all(|i| i.users.len() == 1) =>
-			{
-				r.into_inner()
-			}
+			CreateItemExData::RefungibleMultipleOwners(CreateRefungibleExMultipleOwners {
+				users,
+				properties,
+			}) => vec![CreateItemData { users, properties }],
+			CreateItemExData::RefungibleMultipleItems(r) => r
+				.into_inner()
+				.into_iter()
+				.map(
+					|CreateRefungibleExSingleOwner {
+					     user,
+					     pieces,
+					     properties,
+					 }| CreateItemData {
+						users: BTreeMap::from([(user, pieces)])
+							.try_into()
+							.expect("limit >= 1"),
+						properties,
+					},
+				)
+				.collect(),
 			_ => fail!(<Error<T>>::NotRefungibleDataUsedToMintFungibleCollectionToken),
 		};
 
modifiedpallets/refungible/src/erc.rsdiffbeforeafterboth
--- a/pallets/refungible/src/erc.rs
+++ b/pallets/refungible/src/erc.rs
@@ -494,7 +494,7 @@
 		<Pallet<T>>::create_item(
 			self,
 			&caller,
-			CreateItemData::<T> {
+			CreateItemData::<T::CrossAccountId> {
 				users,
 				properties: CollectionPropertiesVec::default(),
 			},
@@ -560,7 +560,7 @@
 		<Pallet<T>>::create_item(
 			self,
 			&caller,
-			CreateItemData::<T> { users, properties },
+			CreateItemData::<T::CrossAccountId> { users, properties },
 			&budget,
 		)
 		.map_err(dispatch_to_evm::<T>)?;
@@ -717,7 +717,7 @@
 			.collect::<BTreeMap<_, _>>()
 			.try_into()
 			.unwrap();
-		let create_item_data = CreateItemData::<T> {
+		let create_item_data = CreateItemData::<T::CrossAccountId> {
 			users,
 			properties: CollectionPropertiesVec::default(),
 		};
@@ -777,7 +777,7 @@
 				})
 				.map_err(|e| Error::Revert(alloc::format!("Can't add property: {:?}", e)))?;
 
-			let create_item_data = CreateItemData::<T> {
+			let create_item_data = CreateItemData::<T::CrossAccountId> {
 				users: users.clone(),
 				properties,
 			};
modifiedpallets/refungible/src/lib.rsdiffbeforeafterboth
before · pallets/refungible/src/lib.rs
1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617//! # Refungible Pallet18//!19//! The Refungible pallet provides functionality for handling refungible collections and tokens.20//!21//! - [`Config`]22//! - [`RefungibleHandle`]23//! - [`Pallet`]24//! - [`CommonWeights`](common::CommonWeights)25//!26//! ## Overview27//!28//! The Refungible pallet provides functions for:29//!30//! - RFT collection creation and removal31//! - Minting and burning of RFT tokens32//! - Partition and repartition of RFT tokens33//! - Retrieving number of pieces of RFT token34//! - Retrieving account balances35//! - Transfering RFT token pieces36//! - Burning RFT token pieces37//! - Setting and checking allowance for RFT tokens38//!39//! ### Terminology40//!41//! - **RFT token:** Non fungible token that was partitioned to pieces. If an account owns all42//!   of the RFT token pieces than it owns the RFT token and can repartition it.43//!44//! - **RFT Collection:** A collection of RFT tokens. All RFT tokens are part of a collection.45//!   Each collection has its own settings and set of permissions.46//!47//! - **RFT token piece:** A fungible part of an RFT token.48//!49//! - **Balance:** RFT token pieces owned by an account50//!51//! - **Allowance:** Maximum number of RFT token pieces that one account is allowed to52//!   transfer from the balance of another account53//!54//! - **Burning:** The process of “deleting” a token from a collection or removing token pieces from55//!   an account balance.56//!57//! ### Implementations58//!59//! The Refungible pallet provides implementations for the following traits. If these traits provide60//! the functionality that you need, then you can avoid coupling with the Refungible pallet.61//!62//! - [`CommonWeightInfo`](pallet_common::CommonWeightInfo): Functions for retrieval of transaction weight63//! - [`CommonCollectionOperations`](pallet_common::CommonCollectionOperations): Functions for dealing64//!   with collections65//! - [`RefungibleExtensions`](pallet_common::RefungibleExtensions): Functions specific for refungible66//!   collection67//!68//! ## Interface69//!70//! ### Dispatchable Functions71//!72//! - `init_collection` - Create RFT collection. RFT collection can be configured to allow or deny access for73//!   some accounts.74//! - `destroy_collection` - Destroy exising RFT collection. There should be no tokens in the collection.75//! - `burn` - Burn some amount of RFT token pieces owned by account. Burns the RFT token if no pieces left.76//! - `transfer` - Transfer some amount of RFT token pieces. Transfers should be enabled for RFT collection.77//!   Nests the RFT token if RFT token pieces are sent to another token.78//! - `create_item` - Mint RFT token in collection. Sender should have permission to mint tokens.79//! - `set_allowance` - Set allowance for another account to transfer balance from sender's account.80//! - `repartition` - Repartition token to selected number of pieces. Sender should own all existing pieces.81//!82//! ## Assumptions83//!84//! * Total number of pieces for one token shouldn't exceed `up_data_structs::MAX_REFUNGIBLE_PIECES`.85//! * Total number of tokens of all types shouldn't be greater than `up_data_structs::MAX_TOKEN_PREFIX_LENGTH`.86//! * Sender should be in collection's allow list to perform operations on tokens.8788#![cfg_attr(not(feature = "std"), no_std)]8990use crate::erc_token::ERC20Events;91use crate::erc::ERC721Events;9293use codec::{Encode, Decode, MaxEncodedLen};94use core::ops::Deref;95use evm_coder::ToLog;96use frame_support::{BoundedVec, ensure, fail, storage::with_transaction, transactional};97use pallet_evm::{account::CrossAccountId, Pallet as PalletEvm};98use pallet_evm_coder_substrate::WithRecorder;99use pallet_common::{100	CommonCollectionOperations, Error as CommonError, Event as CommonEvent,101	eth::collection_id_to_address, Pallet as PalletCommon,102};103use pallet_structure::Pallet as PalletStructure;104use scale_info::TypeInfo;105use sp_core::H160;106use sp_runtime::{ArithmeticError, DispatchError, DispatchResult, TransactionOutcome};107use sp_std::{vec::Vec, vec, collections::btree_map::BTreeMap};108use up_data_structs::{109	AccessMode, budget::Budget, CollectionId, CreateCollectionData, CreateRefungibleExData,110	CustomDataLimit, mapping::TokenAddressMapping, MAX_REFUNGIBLE_PIECES, TokenId, Property,111	PropertyKey, PropertyKeyPermission, PropertyPermission, PropertyScope, PropertyValue,112	TrySetProperty,113};114115pub use pallet::*;116#[cfg(feature = "runtime-benchmarks")]117pub mod benchmarking;118pub mod common;119pub mod erc;120pub mod erc_token;121pub mod weights;122123pub type CreateItemData<T> =124	CreateRefungibleExData<<T as pallet_evm::account::Config>::CrossAccountId>;125pub(crate) type SelfWeightOf<T> = <T as Config>::WeightInfo;126127/// Token data, stored independently from other data used to describe it128/// for the convenience of database access. Notably contains the token metadata.129#[struct_versioning::versioned(version = 2, upper)]130#[derive(Encode, Decode, Default, TypeInfo, MaxEncodedLen)]131#[deprecated(since = "0.2.0", note = "ItemData is no more contains usefull data")]132pub struct ItemData {133	pub const_data: BoundedVec<u8, CustomDataLimit>,134135	#[version(..2)]136	pub variable_data: BoundedVec<u8, CustomDataLimit>,137}138139#[frame_support::pallet]140pub mod pallet {141	use super::*;142	use frame_support::{143		Blake2_128, Blake2_128Concat, Twox64Concat, pallet_prelude::*, storage::Key,144		traits::StorageVersion,145	};146	use frame_system::pallet_prelude::*;147	use up_data_structs::{CollectionId, TokenId};148	use super::weights::WeightInfo;149150	#[pallet::error]151	pub enum Error<T> {152		/// Not Refungible item data used to mint in Refungible collection.153		NotRefungibleDataUsedToMintFungibleCollectionToken,154		/// Maximum refungibility exceeded.155		WrongRefungiblePieces,156		/// Refungible token can't be repartitioned by user who isn't owns all pieces.157		RepartitionWhileNotOwningAllPieces,158		/// Refungible token can't nest other tokens.159		RefungibleDisallowsNesting,160		/// Setting item properties is not allowed.161		SettingPropertiesNotAllowed,162	}163164	#[pallet::config]165	pub trait Config:166		frame_system::Config + pallet_common::Config + pallet_structure::Config167	{168		type WeightInfo: WeightInfo;169	}170171	const STORAGE_VERSION: StorageVersion = StorageVersion::new(2);172173	#[pallet::pallet]174	#[pallet::storage_version(STORAGE_VERSION)]175	#[pallet::generate_store(pub(super) trait Store)]176	pub struct Pallet<T>(_);177178	/// Total amount of minted tokens in a collection.179	#[pallet::storage]180	pub type TokensMinted<T: Config> =181		StorageMap<Hasher = Twox64Concat, Key = CollectionId, Value = u32, QueryKind = ValueQuery>;182183	/// Amount of tokens burnt in a collection.184	#[pallet::storage]185	pub type TokensBurnt<T: Config> =186		StorageMap<Hasher = Twox64Concat, Key = CollectionId, Value = u32, QueryKind = ValueQuery>;187188	/// Token data, used to partially describe a token.189	// TODO: remove190	#[pallet::storage]191	#[deprecated(since = "0.2.0", note = "ItemData is no more contains usefull data")]192	pub type TokenData<T: Config> = StorageNMap<193		Key = (Key<Twox64Concat, CollectionId>, Key<Twox64Concat, TokenId>),194		Value = ItemData,195		QueryKind = ValueQuery,196	>;197198	/// Amount of pieces a refungible token is split into.199	#[pallet::storage]200	#[pallet::getter(fn token_properties)]201	pub type TokenProperties<T: Config> = StorageNMap<202		Key = (Key<Twox64Concat, CollectionId>, Key<Twox64Concat, TokenId>),203		Value = up_data_structs::Properties,204		QueryKind = ValueQuery,205		OnEmpty = up_data_structs::TokenProperties,206	>;207208	/// Total amount of pieces for token209	#[pallet::storage]210	pub type TotalSupply<T: Config> = StorageNMap<211		Key = (Key<Twox64Concat, CollectionId>, Key<Twox64Concat, TokenId>),212		Value = u128,213		QueryKind = ValueQuery,214	>;215216	/// Used to enumerate tokens owned by account.217	#[pallet::storage]218	pub type Owned<T: Config> = StorageNMap<219		Key = (220			Key<Twox64Concat, CollectionId>,221			Key<Blake2_128Concat, T::CrossAccountId>,222			Key<Twox64Concat, TokenId>,223		),224		Value = bool,225		QueryKind = ValueQuery,226	>;227228	/// Amount of tokens (not pieces) partially owned by an account within a collection.229	#[pallet::storage]230	pub type AccountBalance<T: Config> = StorageNMap<231		Key = (232			Key<Twox64Concat, CollectionId>,233			// Owner234			Key<Blake2_128Concat, T::CrossAccountId>,235		),236		Value = u32,237		QueryKind = ValueQuery,238	>;239240	/// Amount of token pieces owned by account.241	#[pallet::storage]242	pub type Balance<T: Config> = StorageNMap<243		Key = (244			Key<Twox64Concat, CollectionId>,245			Key<Twox64Concat, TokenId>,246			// Owner247			Key<Blake2_128Concat, T::CrossAccountId>,248		),249		Value = u128,250		QueryKind = ValueQuery,251	>;252253	/// Allowance set by a token owner for another user to perform one of certain transactions on a number of pieces of a token.254	#[pallet::storage]255	pub type Allowance<T: Config> = StorageNMap<256		Key = (257			Key<Twox64Concat, CollectionId>,258			Key<Twox64Concat, TokenId>,259			// Owner260			Key<Blake2_128, T::CrossAccountId>,261			// Spender262			Key<Blake2_128Concat, T::CrossAccountId>,263		),264		Value = u128,265		QueryKind = ValueQuery,266	>;267268	#[pallet::hooks]269	impl<T: Config> Hooks<BlockNumberFor<T>> for Pallet<T> {270		fn on_runtime_upgrade() -> Weight {271			let storage_version = StorageVersion::get::<Pallet<T>>();272			if storage_version < StorageVersion::new(2) {273				<TokenData<T>>::remove_all(None);274			}275			StorageVersion::new(2).put::<Pallet<T>>();276277			0278		}279	}280}281282pub struct RefungibleHandle<T: Config>(pallet_common::CollectionHandle<T>);283impl<T: Config> RefungibleHandle<T> {284	pub fn cast(inner: pallet_common::CollectionHandle<T>) -> Self {285		Self(inner)286	}287	pub fn into_inner(self) -> pallet_common::CollectionHandle<T> {288		self.0289	}290	pub fn common_mut(&mut self) -> &mut pallet_common::CollectionHandle<T> {291		&mut self.0292	}293}294295impl<T: Config> Deref for RefungibleHandle<T> {296	type Target = pallet_common::CollectionHandle<T>;297298	fn deref(&self) -> &Self::Target {299		&self.0300	}301}302303impl<T: Config> WithRecorder<T> for RefungibleHandle<T> {304	fn recorder(&self) -> &pallet_evm_coder_substrate::SubstrateRecorder<T> {305		self.0.recorder()306	}307	fn into_recorder(self) -> pallet_evm_coder_substrate::SubstrateRecorder<T> {308		self.0.into_recorder()309	}310}311312impl<T: Config> Pallet<T> {313	/// Get number of RFT tokens in collection314	pub fn total_supply(collection: &RefungibleHandle<T>) -> u32 {315		<TokensMinted<T>>::get(collection.id) - <TokensBurnt<T>>::get(collection.id)316	}317318	/// Check that RFT token exists319	///320	/// - `token`: Token ID.321	pub fn token_exists(collection: &RefungibleHandle<T>, token: TokenId) -> bool {322		<TotalSupply<T>>::contains_key((collection.id, token))323	}324325	pub fn set_scoped_token_property(326		collection_id: CollectionId,327		token_id: TokenId,328		scope: PropertyScope,329		property: Property,330	) -> DispatchResult {331		TokenProperties::<T>::try_mutate((collection_id, token_id), |properties| {332			properties.try_scoped_set(scope, property.key, property.value)333		})334		.map_err(<CommonError<T>>::from)?;335336		Ok(())337	}338339	pub fn set_scoped_token_properties(340		collection_id: CollectionId,341		token_id: TokenId,342		scope: PropertyScope,343		properties: impl Iterator<Item = Property>,344	) -> DispatchResult {345		TokenProperties::<T>::try_mutate((collection_id, token_id), |stored_properties| {346			stored_properties.try_scoped_set_from_iter(scope, properties)347		})348		.map_err(<CommonError<T>>::from)?;349350		Ok(())351	}352}353354// unchecked calls skips any permission checks355impl<T: Config> Pallet<T> {356	/// Create RFT collection357	///358	/// `init_collection` will take non-refundable deposit for collection creation.359	///360	/// - `data`: Contains settings for collection limits and permissions.361	pub fn init_collection(362		owner: T::CrossAccountId,363		data: CreateCollectionData<T::AccountId>,364	) -> Result<CollectionId, DispatchError> {365		<PalletCommon<T>>::init_collection(owner, data, false)366	}367368	/// Destroy RFT collection369	///370	/// `destroy_collection` will throw error if collection contains any tokens.371	/// Only owner can destroy collection.372	pub fn destroy_collection(373		collection: RefungibleHandle<T>,374		sender: &T::CrossAccountId,375	) -> DispatchResult {376		let id = collection.id;377378		if Self::collection_has_tokens(id) {379			return Err(<CommonError<T>>::CantDestroyNotEmptyCollection.into());380		}381382		// =========383384		PalletCommon::destroy_collection(collection.0, sender)?;385386		<TokensMinted<T>>::remove(id);387		<TokensBurnt<T>>::remove(id);388		<TotalSupply<T>>::remove_prefix((id,), None);389		<Balance<T>>::remove_prefix((id,), None);390		<Allowance<T>>::remove_prefix((id,), None);391		<Owned<T>>::remove_prefix((id,), None);392		<AccountBalance<T>>::remove_prefix((id,), None);393		Ok(())394	}395396	fn collection_has_tokens(collection_id: CollectionId) -> bool {397		<TotalSupply<T>>::iter_prefix((collection_id,))398			.next()399			.is_some()400	}401402	pub fn burn_token_unchecked(403		collection: &RefungibleHandle<T>,404		owner: &T::CrossAccountId,405		token_id: TokenId,406	) -> DispatchResult {407		let burnt = <TokensBurnt<T>>::get(collection.id)408			.checked_add(1)409			.ok_or(ArithmeticError::Overflow)?;410411		<TokensBurnt<T>>::insert(collection.id, burnt);412		<TokenProperties<T>>::remove((collection.id, token_id));413		<TotalSupply<T>>::remove((collection.id, token_id));414		<Balance<T>>::remove_prefix((collection.id, token_id), None);415		<Allowance<T>>::remove_prefix((collection.id, token_id), None);416417		<PalletEvm<T>>::deposit_log(418			ERC721Events::Transfer {419				from: *owner.as_eth(),420				to: H160::default(),421				token_id: token_id.into(),422			}423			.to_log(collection_id_to_address(collection.id)),424		);425		Ok(())426	}427428	/// Burn RFT token pieces429	///430	/// `burn` will decrease total amount of token pieces and amount owned by sender.431	/// `burn` can be called even if there are multiple owners of the RFT token.432	/// If sender wouldn't have any pieces left after `burn` than she will stop being433	/// one of the owners of the token. If there is no account that owns any pieces of434	/// the token than token will be burned too.435	///436	/// - `amount`: Amount of token pieces to burn.437	/// - `token`: Token who's pieces should be burned438	/// - `collection`: Collection that contains the token439	pub fn burn(440		collection: &RefungibleHandle<T>,441		owner: &T::CrossAccountId,442		token: TokenId,443		amount: u128,444	) -> DispatchResult {445		let total_supply = <TotalSupply<T>>::get((collection.id, token))446			.checked_sub(amount)447			.ok_or(<CommonError<T>>::TokenValueTooLow)?;448449		// This was probally last owner of this token?450		if total_supply == 0 {451			// Ensure user actually owns this amount452			ensure!(453				<Balance<T>>::get((collection.id, token, owner)) == amount,454				<CommonError<T>>::TokenValueTooLow455			);456			let account_balance = <AccountBalance<T>>::get((collection.id, owner))457				.checked_sub(1)458				// Should not occur459				.ok_or(ArithmeticError::Underflow)?;460461			// =========462463			<Owned<T>>::remove((collection.id, owner, token));464			<PalletStructure<T>>::unnest_if_nested(owner, collection.id, token);465			<AccountBalance<T>>::insert((collection.id, owner), account_balance);466			Self::burn_token_unchecked(collection, owner, token)?;467			<PalletEvm<T>>::deposit_log(468				ERC20Events::Transfer {469					from: *owner.as_eth(),470					to: H160::default(),471					value: amount.into(),472				}473				.to_log(collection_id_to_address(collection.id)),474			);475			<PalletCommon<T>>::deposit_event(CommonEvent::ItemDestroyed(476				collection.id,477				token,478				owner.clone(),479				amount,480			));481			return Ok(());482		}483484		let balance = <Balance<T>>::get((collection.id, token, owner))485			.checked_sub(amount)486			.ok_or(<CommonError<T>>::TokenValueTooLow)?;487		let account_balance = if balance == 0 {488			<AccountBalance<T>>::get((collection.id, owner))489				.checked_sub(1)490				// Should not occur491				.ok_or(ArithmeticError::Underflow)?492		} else {493			0494		};495496		// =========497498		if balance == 0 {499			<Owned<T>>::remove((collection.id, owner, token));500			<PalletStructure<T>>::unnest_if_nested(owner, collection.id, token);501			<Balance<T>>::remove((collection.id, token, owner));502			<AccountBalance<T>>::insert((collection.id, owner), account_balance);503504			if let Some(user) = Self::token_owner(collection.id, token) {505				<PalletEvm<T>>::deposit_log(506					ERC721Events::Transfer {507						from: erc::ADDRESS_FOR_PARTIALLY_OWNED_TOKENS,508						to: *user.as_eth(),509						token_id: token.into(),510					}511					.to_log(collection_id_to_address(collection.id)),512				);513			}514		} else {515			<Balance<T>>::insert((collection.id, token, owner), balance);516		}517		<TotalSupply<T>>::insert((collection.id, token), total_supply);518519		<PalletEvm<T>>::deposit_log(520			ERC20Events::Transfer {521				from: *owner.as_eth(),522				to: H160::default(),523				value: amount.into(),524			}525			.to_log(T::EvmTokenAddressMapping::token_to_address(526				collection.id,527				token,528			)),529		);530		<PalletCommon<T>>::deposit_event(CommonEvent::ItemDestroyed(531			collection.id,532			token,533			owner.clone(),534			amount,535		));536		Ok(())537	}538539	#[transactional]540	fn modify_token_properties(541		collection: &RefungibleHandle<T>,542		sender: &T::CrossAccountId,543		token_id: TokenId,544		properties: impl Iterator<Item = (PropertyKey, Option<PropertyValue>)>,545		is_token_create: bool,546		nesting_budget: &dyn Budget,547	) -> DispatchResult {548		let is_collection_admin = || collection.is_owner_or_admin(sender);549		let is_token_owner = || -> Result<bool, DispatchError> {550			let balance = collection.balance(sender.clone(), token_id);551			let total_pieces: u128 =552				Self::total_pieces(collection.id, token_id).unwrap_or(u128::MAX);553			if balance != total_pieces {554				return Ok(false);555			}556557			let is_bundle_owner = <PalletStructure<T>>::check_indirectly_owned(558				sender.clone(),559				collection.id,560				token_id,561				None,562				nesting_budget,563			)?;564565			Ok(is_bundle_owner)566		};567568		for (key, value) in properties {569			let permission = <PalletCommon<T>>::property_permissions(collection.id)570				.get(&key)571				.cloned()572				.unwrap_or_else(PropertyPermission::none);573574			let is_property_exists = TokenProperties::<T>::get((collection.id, token_id))575				.get(&key)576				.is_some();577578			match permission {579				PropertyPermission { mutable: false, .. } if is_property_exists => {580					return Err(<CommonError<T>>::NoPermission.into());581				}582583				PropertyPermission {584					collection_admin,585					token_owner,586					..587				} => {588					//TODO: investigate threats during public minting.589					let is_token_create =590						is_token_create && (collection_admin || token_owner) && value.is_some();591					if !(is_token_create592						|| (collection_admin && is_collection_admin())593						|| (token_owner && is_token_owner()?))594					{595						fail!(<CommonError<T>>::NoPermission);596					}597				}598			}599600			match value {601				Some(value) => {602					<TokenProperties<T>>::try_mutate((collection.id, token_id), |properties| {603						properties.try_set(key.clone(), value)604					})605					.map_err(<CommonError<T>>::from)?;606607					<PalletCommon<T>>::deposit_event(CommonEvent::TokenPropertySet(608						collection.id,609						token_id,610						key,611					));612				}613				None => {614					<TokenProperties<T>>::try_mutate((collection.id, token_id), |properties| {615						properties.remove(&key)616					})617					.map_err(<CommonError<T>>::from)?;618619					<PalletCommon<T>>::deposit_event(CommonEvent::TokenPropertyDeleted(620						collection.id,621						token_id,622						key,623					));624				}625			}626		}627628		Ok(())629	}630631	pub fn set_token_properties(632		collection: &RefungibleHandle<T>,633		sender: &T::CrossAccountId,634		token_id: TokenId,635		properties: impl Iterator<Item = Property>,636		is_token_create: bool,637		nesting_budget: &dyn Budget,638	) -> DispatchResult {639		Self::modify_token_properties(640			collection,641			sender,642			token_id,643			properties.map(|p| (p.key, Some(p.value))),644			is_token_create,645			nesting_budget,646		)647	}648649	pub fn set_token_property(650		collection: &RefungibleHandle<T>,651		sender: &T::CrossAccountId,652		token_id: TokenId,653		property: Property,654		nesting_budget: &dyn Budget,655	) -> DispatchResult {656		let is_token_create = false;657658		Self::set_token_properties(659			collection,660			sender,661			token_id,662			[property].into_iter(),663			is_token_create,664			nesting_budget,665		)666	}667668	pub fn delete_token_properties(669		collection: &RefungibleHandle<T>,670		sender: &T::CrossAccountId,671		token_id: TokenId,672		property_keys: impl Iterator<Item = PropertyKey>,673		nesting_budget: &dyn Budget,674	) -> DispatchResult {675		let is_token_create = false;676677		Self::modify_token_properties(678			collection,679			sender,680			token_id,681			property_keys.into_iter().map(|key| (key, None)),682			is_token_create,683			nesting_budget,684		)685	}686687	pub fn delete_token_property(688		collection: &RefungibleHandle<T>,689		sender: &T::CrossAccountId,690		token_id: TokenId,691		property_key: PropertyKey,692		nesting_budget: &dyn Budget,693	) -> DispatchResult {694		Self::delete_token_properties(695			collection,696			sender,697			token_id,698			[property_key].into_iter(),699			nesting_budget,700		)701	}702703	/// Transfer RFT token pieces from one account to another.704	///705	/// If the sender is no longer owns any pieces after the `transfer` than she stops being an owner of the token.706	///707	/// - `from`: Owner of token pieces to transfer.708	/// - `to`: Recepient of transfered token pieces.709	/// - `amount`: Amount of token pieces to transfer.710	/// - `token`: Token whos pieces should be transfered711	/// - `collection`: Collection that contains the token712	pub fn transfer(713		collection: &RefungibleHandle<T>,714		from: &T::CrossAccountId,715		to: &T::CrossAccountId,716		token: TokenId,717		amount: u128,718		nesting_budget: &dyn Budget,719	) -> DispatchResult {720		ensure!(721			collection.limits.transfers_enabled(),722			<CommonError<T>>::TransferNotAllowed723		);724725		if collection.permissions.access() == AccessMode::AllowList {726			collection.check_allowlist(from)?;727			collection.check_allowlist(to)?;728		}729		<PalletCommon<T>>::ensure_correct_receiver(to)?;730731		let initial_balance_from = <Balance<T>>::get((collection.id, token, from));732		let updated_balance_from = initial_balance_from733			.checked_sub(amount)734			.ok_or(<CommonError<T>>::TokenValueTooLow)?;735		let mut create_target = false;736		let from_to_differ = from != to;737		let updated_balance_to = if from != to {738			let old_balance = <Balance<T>>::get((collection.id, token, to));739			if old_balance == 0 {740				create_target = true;741			}742			Some(743				old_balance744					.checked_add(amount)745					.ok_or(ArithmeticError::Overflow)?,746			)747		} else {748			None749		};750751		let account_balance_from = if updated_balance_from == 0 {752			Some(753				<AccountBalance<T>>::get((collection.id, from))754					.checked_sub(1)755					// Should not occur756					.ok_or(ArithmeticError::Underflow)?,757			)758		} else {759			None760		};761		// Account data is created in token, AccountBalance should be increased762		// But only if from != to as we shouldn't check overflow in this case763		let account_balance_to = if create_target && from_to_differ {764			let account_balance_to = <AccountBalance<T>>::get((collection.id, to))765				.checked_add(1)766				.ok_or(ArithmeticError::Overflow)?;767			ensure!(768				account_balance_to < collection.limits.account_token_ownership_limit(),769				<CommonError<T>>::AccountTokenLimitExceeded,770			);771772			Some(account_balance_to)773		} else {774			None775		};776777		// =========778779		<PalletStructure<T>>::nest_if_sent_to_token(780			from.clone(),781			to,782			collection.id,783			token,784			nesting_budget,785		)?;786787		if let Some(updated_balance_to) = updated_balance_to {788			// from != to789			if updated_balance_from == 0 {790				<Balance<T>>::remove((collection.id, token, from));791				<PalletStructure<T>>::unnest_if_nested(from, collection.id, token);792			} else {793				<Balance<T>>::insert((collection.id, token, from), updated_balance_from);794			}795			<Balance<T>>::insert((collection.id, token, to), updated_balance_to);796			if let Some(account_balance_from) = account_balance_from {797				<AccountBalance<T>>::insert((collection.id, from), account_balance_from);798				<Owned<T>>::remove((collection.id, from, token));799			}800			if let Some(account_balance_to) = account_balance_to {801				<AccountBalance<T>>::insert((collection.id, to), account_balance_to);802				<Owned<T>>::insert((collection.id, to, token), true);803			}804		}805806		<PalletEvm<T>>::deposit_log(807			ERC20Events::Transfer {808				from: *from.as_eth(),809				to: *to.as_eth(),810				value: amount.into(),811			}812			.to_log(T::EvmTokenAddressMapping::token_to_address(813				collection.id,814				token,815			)),816		);817818		<PalletCommon<T>>::deposit_event(CommonEvent::Transfer(819			collection.id,820			token,821			from.clone(),822			to.clone(),823			amount,824		));825826		let total_supply = <TotalSupply<T>>::get((collection.id, token));827828		if amount == total_supply {829			// if token was fully owned by `from` and will be fully owned by `to` after transfer830			<PalletEvm<T>>::deposit_log(831				ERC721Events::Transfer {832					from: *from.as_eth(),833					to: *to.as_eth(),834					token_id: token.into(),835				}836				.to_log(collection_id_to_address(collection.id)),837			);838		} else if let Some(updated_balance_to) = updated_balance_to {839			// if `from` not equals `to`. This condition is needed to avoid sending event840			// when `from` fully owns token and sends part of token pieces to itself.841			if initial_balance_from == total_supply {842				// if token was fully owned by `from` and will be only partially owned by `to`843				// and `from` after transfer844				<PalletEvm<T>>::deposit_log(845					ERC721Events::Transfer {846						from: *from.as_eth(),847						to: erc::ADDRESS_FOR_PARTIALLY_OWNED_TOKENS,848						token_id: token.into(),849					}850					.to_log(collection_id_to_address(collection.id)),851				);852			} else if updated_balance_to == total_supply {853				// if token was partially owned by `from` and will be fully owned by `to` after transfer854				<PalletEvm<T>>::deposit_log(855					ERC721Events::Transfer {856						from: erc::ADDRESS_FOR_PARTIALLY_OWNED_TOKENS,857						to: *to.as_eth(),858						token_id: token.into(),859					}860					.to_log(collection_id_to_address(collection.id)),861				);862			}863		}864865		Ok(())866	}867868	/// Batched operation to create multiple RFT tokens.869	///870	/// Same as `create_item` but creates multiple tokens.871	///872	/// - `data`: Same as 'data` in `create_item` but contains data for multiple tokens.873	pub fn create_multiple_items(874		collection: &RefungibleHandle<T>,875		sender: &T::CrossAccountId,876		data: Vec<CreateItemData<T>>,877		nesting_budget: &dyn Budget,878	) -> DispatchResult {879		if !collection.is_owner_or_admin(sender) {880			ensure!(881				collection.permissions.mint_mode(),882				<CommonError<T>>::PublicMintingNotAllowed883			);884			collection.check_allowlist(sender)?;885886			for item in data.iter() {887				for user in item.users.keys() {888					collection.check_allowlist(user)?;889				}890			}891		}892893		for item in data.iter() {894			for (owner, _) in item.users.iter() {895				<PalletCommon<T>>::ensure_correct_receiver(owner)?;896			}897		}898899		// Total pieces per tokens900		let totals = data901			.iter()902			.map(|data| {903				Ok(data904					.users905					.iter()906					.map(|u| u.1)907					.try_fold(0u128, |acc, v| acc.checked_add(*v))908					.ok_or(ArithmeticError::Overflow)?)909			})910			.collect::<Result<Vec<_>, DispatchError>>()?;911		for total in &totals {912			ensure!(913				*total <= MAX_REFUNGIBLE_PIECES,914				<Error<T>>::WrongRefungiblePieces915			);916		}917918		let first_token_id = <TokensMinted<T>>::get(collection.id);919		let tokens_minted = first_token_id920			.checked_add(data.len() as u32)921			.ok_or(ArithmeticError::Overflow)?;922		ensure!(923			tokens_minted < collection.limits.token_limit(),924			<CommonError<T>>::CollectionTokenLimitExceeded925		);926927		let mut balances = BTreeMap::new();928		for data in &data {929			for owner in data.users.keys() {930				let balance = balances931					.entry(owner)932					.or_insert_with(|| <AccountBalance<T>>::get((collection.id, owner)));933				*balance = balance.checked_add(1).ok_or(ArithmeticError::Overflow)?;934935				ensure!(936					*balance <= collection.limits.account_token_ownership_limit(),937					<CommonError<T>>::AccountTokenLimitExceeded,938				);939			}940		}941942		for (i, token) in data.iter().enumerate() {943			let token_id = TokenId(first_token_id + i as u32 + 1);944			for (to, _) in token.users.iter() {945				<PalletStructure<T>>::check_nesting(946					sender.clone(),947					to,948					collection.id,949					token_id,950					nesting_budget,951				)?;952			}953		}954955		// =========956957		with_transaction(|| {958			for (i, data) in data.iter().enumerate() {959				let token_id = first_token_id + i as u32 + 1;960				<TotalSupply<T>>::insert((collection.id, token_id), totals[i]);961962				for (user, amount) in data.users.iter() {963					if *amount == 0 {964						continue;965					}966					<Balance<T>>::insert((collection.id, token_id, &user), amount);967					<Owned<T>>::insert((collection.id, &user, TokenId(token_id)), true);968					<PalletStructure<T>>::nest_if_sent_to_token_unchecked(969						user,970						collection.id,971						TokenId(token_id),972					);973				}974975				if let Err(e) = Self::set_token_properties(976					collection,977					sender,978					TokenId(token_id),979					data.properties.clone().into_iter(),980					true,981					nesting_budget,982				) {983					return TransactionOutcome::Rollback(Err(e));984				}985			}986			TransactionOutcome::Commit(Ok(()))987		})?;988989		<TokensMinted<T>>::insert(collection.id, tokens_minted);990991		for (account, balance) in balances {992			<AccountBalance<T>>::insert((collection.id, account), balance);993		}994995		for (i, token) in data.into_iter().enumerate() {996			let token_id = first_token_id + i as u32 + 1;997998			let receivers = token999				.users1000				.into_iter()1001				.filter(|(_, amount)| *amount > 0)1002				.collect::<Vec<_>>();10031004			if let [(user, _)] = receivers.as_slice() {1005				// if there is exactly one receiver1006				<PalletEvm<T>>::deposit_log(1007					ERC721Events::Transfer {1008						from: H160::default(),1009						to: *user.as_eth(),1010						token_id: token_id.into(),1011					}1012					.to_log(collection_id_to_address(collection.id)),1013				);1014			} else if let [_, ..] = receivers.as_slice() {1015				// if there is more than one receiver1016				<PalletEvm<T>>::deposit_log(1017					ERC721Events::Transfer {1018						from: H160::default(),1019						to: erc::ADDRESS_FOR_PARTIALLY_OWNED_TOKENS,1020						token_id: token_id.into(),1021					}1022					.to_log(collection_id_to_address(collection.id)),1023				);1024			}10251026			for (user, amount) in receivers.into_iter() {1027				<PalletEvm<T>>::deposit_log(1028					ERC20Events::Transfer {1029						from: H160::default(),1030						to: *user.as_eth(),1031						value: amount.into(),1032					}1033					.to_log(T::EvmTokenAddressMapping::token_to_address(1034						collection.id,1035						TokenId(token_id),1036					)),1037				);1038				<PalletCommon<T>>::deposit_event(CommonEvent::ItemCreated(1039					collection.id,1040					TokenId(token_id),1041					user,1042					amount,1043				));1044			}1045		}1046		Ok(())1047	}10481049	pub fn set_allowance_unchecked(1050		collection: &RefungibleHandle<T>,1051		sender: &T::CrossAccountId,1052		spender: &T::CrossAccountId,1053		token: TokenId,1054		amount: u128,1055	) {1056		if amount == 0 {1057			<Allowance<T>>::remove((collection.id, token, sender, spender));1058		} else {1059			<Allowance<T>>::insert((collection.id, token, sender, spender), amount);1060		}10611062		<PalletEvm<T>>::deposit_log(1063			ERC20Events::Approval {1064				owner: *sender.as_eth(),1065				spender: *spender.as_eth(),1066				value: amount.into(),1067			}1068			.to_log(T::EvmTokenAddressMapping::token_to_address(1069				collection.id,1070				token,1071			)),1072		);1073		<PalletCommon<T>>::deposit_event(CommonEvent::Approved(1074			collection.id,1075			token,1076			sender.clone(),1077			spender.clone(),1078			amount,1079		))1080	}10811082	/// Set allowance for the spender to `transfer` or `burn` sender's token pieces.1083	///1084	/// - `amount`: Amount of token pieces the spender is allowed to `transfer` or `burn.1085	pub fn set_allowance(1086		collection: &RefungibleHandle<T>,1087		sender: &T::CrossAccountId,1088		spender: &T::CrossAccountId,1089		token: TokenId,1090		amount: u128,1091	) -> DispatchResult {1092		if collection.permissions.access() == AccessMode::AllowList {1093			collection.check_allowlist(sender)?;1094			collection.check_allowlist(spender)?;1095		}10961097		<PalletCommon<T>>::ensure_correct_receiver(spender)?;10981099		if <Balance<T>>::get((collection.id, token, sender)) < amount {1100			ensure!(1101				collection.ignores_owned_amount(sender) && Self::token_exists(collection, token),1102				<CommonError<T>>::CantApproveMoreThanOwned1103			);1104		}11051106		// =========11071108		Self::set_allowance_unchecked(collection, sender, spender, token, amount);1109		Ok(())1110	}11111112	/// Returns allowance, which should be set after transaction1113	fn check_allowed(1114		collection: &RefungibleHandle<T>,1115		spender: &T::CrossAccountId,1116		from: &T::CrossAccountId,1117		token: TokenId,1118		amount: u128,1119		nesting_budget: &dyn Budget,1120	) -> Result<Option<u128>, DispatchError> {1121		if spender.conv_eq(from) {1122			return Ok(None);1123		}1124		if collection.permissions.access() == AccessMode::AllowList {1125			// `from`, `to` checked in [`transfer`]1126			collection.check_allowlist(spender)?;1127		}1128		if let Some(source) = T::CrossTokenAddressMapping::address_to_token(from) {1129			// TODO: should collection owner be allowed to perform this transfer?1130			ensure!(1131				<PalletStructure<T>>::check_indirectly_owned(1132					spender.clone(),1133					source.0,1134					source.1,1135					None,1136					nesting_budget1137				)?,1138				<CommonError<T>>::ApprovedValueTooLow,1139			);1140			return Ok(None);1141		}1142		let allowance =1143			<Allowance<T>>::get((collection.id, token, from, &spender)).checked_sub(amount);1144		if allowance.is_none() {1145			ensure!(1146				collection.ignores_allowance(spender),1147				<CommonError<T>>::ApprovedValueTooLow1148			);1149		}1150		Ok(allowance)1151	}11521153	/// Transfer RFT token pieces from one account to another.1154	///1155	/// Same as the [`transfer`] but spender doesn't needs to be an owner of the token pieces.1156	/// The owner should set allowance for the spender to transfer pieces.1157	///1158	/// [`transfer`]: struct.Pallet.html#method.transfer1159	pub fn transfer_from(1160		collection: &RefungibleHandle<T>,1161		spender: &T::CrossAccountId,1162		from: &T::CrossAccountId,1163		to: &T::CrossAccountId,1164		token: TokenId,1165		amount: u128,1166		nesting_budget: &dyn Budget,1167	) -> DispatchResult {1168		let allowance =1169			Self::check_allowed(collection, spender, from, token, amount, nesting_budget)?;11701171		// =========11721173		Self::transfer(collection, from, to, token, amount, nesting_budget)?;1174		if let Some(allowance) = allowance {1175			Self::set_allowance_unchecked(collection, from, spender, token, allowance);1176		}1177		Ok(())1178	}11791180	/// Burn RFT token pieces from the account.1181	///1182	/// Same as the [`burn`] but spender doesn't need to be an owner of the token pieces. The owner should1183	/// set allowance for the spender to burn pieces1184	///1185	/// [`burn`]: struct.Pallet.html#method.burn1186	pub fn burn_from(1187		collection: &RefungibleHandle<T>,1188		spender: &T::CrossAccountId,1189		from: &T::CrossAccountId,1190		token: TokenId,1191		amount: u128,1192		nesting_budget: &dyn Budget,1193	) -> DispatchResult {1194		let allowance =1195			Self::check_allowed(collection, spender, from, token, amount, nesting_budget)?;11961197		// =========11981199		Self::burn(collection, from, token, amount)?;1200		if let Some(allowance) = allowance {1201			Self::set_allowance_unchecked(collection, from, spender, token, allowance);1202		}1203		Ok(())1204	}12051206	/// Create RFT token.1207	///1208	/// The sender should be the owner/admin of the collection or collection should be configured1209	/// to allow public minting.1210	///1211	/// - `data`: Contains list of users who will become the owners of the token pieces and amount1212	///   of token pieces they will receive.1213	pub fn create_item(1214		collection: &RefungibleHandle<T>,1215		sender: &T::CrossAccountId,1216		data: CreateItemData<T>,1217		nesting_budget: &dyn Budget,1218	) -> DispatchResult {1219		Self::create_multiple_items(collection, sender, vec![data], nesting_budget)1220	}12211222	/// Repartition RFT token.1223	///1224	/// `repartition` will set token balance of the sender and total amount of token pieces.1225	/// Sender should own all of the token pieces. `repartition' could be done even if some1226	/// token pieces were burned before.1227	///1228	/// - `amount`: Total amount of token pieces that the token will have after `repartition`.1229	pub fn repartition(1230		collection: &RefungibleHandle<T>,1231		owner: &T::CrossAccountId,1232		token: TokenId,1233		amount: u128,1234	) -> DispatchResult {1235		ensure!(1236			amount <= MAX_REFUNGIBLE_PIECES,1237			<Error<T>>::WrongRefungiblePieces1238		);1239		ensure!(amount > 0, <CommonError<T>>::TokenValueTooLow);1240		// Ensure user owns all pieces1241		let total_pieces = Self::total_pieces(collection.id, token).unwrap_or(u128::MAX);1242		let balance = <Balance<T>>::get((collection.id, token, owner));1243		ensure!(1244			total_pieces == balance,1245			<Error<T>>::RepartitionWhileNotOwningAllPieces1246		);12471248		<Balance<T>>::insert((collection.id, token, owner), amount);1249		<TotalSupply<T>>::insert((collection.id, token), amount);12501251		if amount > total_pieces {1252			let mint_amount = amount - total_pieces;1253			<PalletEvm<T>>::deposit_log(1254				ERC20Events::Transfer {1255					from: H160::default(),1256					to: *owner.as_eth(),1257					value: mint_amount.into(),1258				}1259				.to_log(T::EvmTokenAddressMapping::token_to_address(1260					collection.id,1261					token,1262				)),1263			);1264			<PalletCommon<T>>::deposit_event(CommonEvent::ItemCreated(1265				collection.id,1266				token,1267				owner.clone(),1268				mint_amount,1269			));1270		} else if total_pieces > amount {1271			let burn_amount = total_pieces - amount;1272			<PalletEvm<T>>::deposit_log(1273				ERC20Events::Transfer {1274					from: *owner.as_eth(),1275					to: H160::default(),1276					value: burn_amount.into(),1277				}1278				.to_log(T::EvmTokenAddressMapping::token_to_address(1279					collection.id,1280					token,1281				)),1282			);1283			<PalletCommon<T>>::deposit_event(CommonEvent::ItemDestroyed(1284				collection.id,1285				token,1286				owner.clone(),1287				burn_amount,1288			));1289		}12901291		Ok(())1292	}12931294	fn token_owner(collection_id: CollectionId, token_id: TokenId) -> Option<T::CrossAccountId> {1295		let mut owner = None;1296		let mut count = 0;1297		for key in Balance::<T>::iter_key_prefix((collection_id, token_id)) {1298			count += 1;1299			if count > 1 {1300				return None;1301			}1302			owner = Some(key);1303		}1304		owner1305	}13061307	fn total_pieces(collection_id: CollectionId, token_id: TokenId) -> Option<u128> {1308		<TotalSupply<T>>::try_get((collection_id, token_id)).ok()1309	}13101311	pub fn set_collection_properties(1312		collection: &RefungibleHandle<T>,1313		sender: &T::CrossAccountId,1314		properties: Vec<Property>,1315	) -> DispatchResult {1316		<PalletCommon<T>>::set_collection_properties(collection, sender, properties)1317	}13181319	pub fn delete_collection_properties(1320		collection: &RefungibleHandle<T>,1321		sender: &T::CrossAccountId,1322		property_keys: Vec<PropertyKey>,1323	) -> DispatchResult {1324		<PalletCommon<T>>::delete_collection_properties(collection, sender, property_keys)1325	}13261327	pub fn set_token_property_permissions(1328		collection: &RefungibleHandle<T>,1329		sender: &T::CrossAccountId,1330		property_permissions: Vec<PropertyKeyPermission>,1331	) -> DispatchResult {1332		<PalletCommon<T>>::set_token_property_permissions(collection, sender, property_permissions)1333	}13341335	/// Returns 10 token in no particular order.1336	///1337	/// There is no direct way to get token holders in ascending order,1338	/// since `iter_prefix` returns values in no particular order.1339	/// Therefore, getting the 10 largest holders with a large value of holders1340	/// can lead to impact memory allocation + sorting with  `n * log (n)`.1341	pub fn token_owners(1342		collection_id: CollectionId,1343		token: TokenId,1344	) -> Option<Vec<T::CrossAccountId>> {1345		let res: Vec<T::CrossAccountId> = <Balance<T>>::iter_prefix((collection_id, token))1346			.map(|(owner, _amount)| owner)1347			.take(10)1348			.collect();13491350		if res.is_empty() {1351			None1352		} else {1353			Some(res)1354		}1355	}1356}
after · pallets/refungible/src/lib.rs
1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617//! # Refungible Pallet18//!19//! The Refungible pallet provides functionality for handling refungible collections and tokens.20//!21//! - [`Config`]22//! - [`RefungibleHandle`]23//! - [`Pallet`]24//! - [`CommonWeights`](common::CommonWeights)25//!26//! ## Overview27//!28//! The Refungible pallet provides functions for:29//!30//! - RFT collection creation and removal31//! - Minting and burning of RFT tokens32//! - Partition and repartition of RFT tokens33//! - Retrieving number of pieces of RFT token34//! - Retrieving account balances35//! - Transfering RFT token pieces36//! - Burning RFT token pieces37//! - Setting and checking allowance for RFT tokens38//!39//! ### Terminology40//!41//! - **RFT token:** Non fungible token that was partitioned to pieces. If an account owns all42//!   of the RFT token pieces than it owns the RFT token and can repartition it.43//!44//! - **RFT Collection:** A collection of RFT tokens. All RFT tokens are part of a collection.45//!   Each collection has its own settings and set of permissions.46//!47//! - **RFT token piece:** A fungible part of an RFT token.48//!49//! - **Balance:** RFT token pieces owned by an account50//!51//! - **Allowance:** Maximum number of RFT token pieces that one account is allowed to52//!   transfer from the balance of another account53//!54//! - **Burning:** The process of “deleting” a token from a collection or removing token pieces from55//!   an account balance.56//!57//! ### Implementations58//!59//! The Refungible pallet provides implementations for the following traits. If these traits provide60//! the functionality that you need, then you can avoid coupling with the Refungible pallet.61//!62//! - [`CommonWeightInfo`](pallet_common::CommonWeightInfo): Functions for retrieval of transaction weight63//! - [`CommonCollectionOperations`](pallet_common::CommonCollectionOperations): Functions for dealing64//!   with collections65//! - [`RefungibleExtensions`](pallet_common::RefungibleExtensions): Functions specific for refungible66//!   collection67//!68//! ## Interface69//!70//! ### Dispatchable Functions71//!72//! - `init_collection` - Create RFT collection. RFT collection can be configured to allow or deny access for73//!   some accounts.74//! - `destroy_collection` - Destroy exising RFT collection. There should be no tokens in the collection.75//! - `burn` - Burn some amount of RFT token pieces owned by account. Burns the RFT token if no pieces left.76//! - `transfer` - Transfer some amount of RFT token pieces. Transfers should be enabled for RFT collection.77//!   Nests the RFT token if RFT token pieces are sent to another token.78//! - `create_item` - Mint RFT token in collection. Sender should have permission to mint tokens.79//! - `set_allowance` - Set allowance for another account to transfer balance from sender's account.80//! - `repartition` - Repartition token to selected number of pieces. Sender should own all existing pieces.81//!82//! ## Assumptions83//!84//! * Total number of pieces for one token shouldn't exceed `up_data_structs::MAX_REFUNGIBLE_PIECES`.85//! * Total number of tokens of all types shouldn't be greater than `up_data_structs::MAX_TOKEN_PREFIX_LENGTH`.86//! * Sender should be in collection's allow list to perform operations on tokens.8788#![cfg_attr(not(feature = "std"), no_std)]8990use crate::erc_token::ERC20Events;91use crate::erc::ERC721Events;9293use codec::{Encode, Decode, MaxEncodedLen};94use core::ops::Deref;95use evm_coder::ToLog;96use frame_support::{97	BoundedVec, ensure, fail, storage::with_transaction, transactional, pallet_prelude::ConstU32,98};99use pallet_evm::{account::CrossAccountId, Pallet as PalletEvm};100use pallet_evm_coder_substrate::WithRecorder;101use pallet_common::{102	CommonCollectionOperations, Error as CommonError, Event as CommonEvent,103	eth::collection_id_to_address, Pallet as PalletCommon,104};105use pallet_structure::Pallet as PalletStructure;106use scale_info::TypeInfo;107use sp_core::H160;108use sp_runtime::{ArithmeticError, DispatchError, DispatchResult, TransactionOutcome};109use sp_std::{vec::Vec, vec, collections::btree_map::BTreeMap};110use up_data_structs::{111	AccessMode, budget::Budget, CollectionId, CreateCollectionData, CustomDataLimit,112	mapping::TokenAddressMapping, MAX_REFUNGIBLE_PIECES, MAX_ITEMS_PER_BATCH, TokenId, Property,113	PropertyKey, PropertyKeyPermission, PropertyPermission, PropertyScope, PropertyValue,114	TrySetProperty, CollectionPropertiesVec,115};116use frame_support::BoundedBTreeMap;117use derivative::Derivative;118119pub use pallet::*;120#[cfg(feature = "runtime-benchmarks")]121pub mod benchmarking;122pub mod common;123pub mod erc;124pub mod erc_token;125pub mod weights;126127#[derive(Derivative, Clone)]128pub struct CreateItemData<CrossAccountId> {129	#[derivative(Debug(format_with = "bounded::map_debug"))]130	pub users: BoundedBTreeMap<CrossAccountId, u128, ConstU32<MAX_ITEMS_PER_BATCH>>,131	#[derivative(Debug(format_with = "bounded::vec_debug"))]132	pub properties: CollectionPropertiesVec,133}134pub(crate) type SelfWeightOf<T> = <T as Config>::WeightInfo;135136/// Token data, stored independently from other data used to describe it137/// for the convenience of database access. Notably contains the token metadata.138#[struct_versioning::versioned(version = 2, upper)]139#[derive(Encode, Decode, Default, TypeInfo, MaxEncodedLen)]140#[deprecated(since = "0.2.0", note = "ItemData is no more contains usefull data")]141pub struct ItemData {142	pub const_data: BoundedVec<u8, CustomDataLimit>,143144	#[version(..2)]145	pub variable_data: BoundedVec<u8, CustomDataLimit>,146}147148#[frame_support::pallet]149pub mod pallet {150	use super::*;151	use frame_support::{152		Blake2_128, Blake2_128Concat, Twox64Concat, pallet_prelude::*, storage::Key,153		traits::StorageVersion,154	};155	use frame_system::pallet_prelude::*;156	use up_data_structs::{CollectionId, TokenId};157	use super::weights::WeightInfo;158159	#[pallet::error]160	pub enum Error<T> {161		/// Not Refungible item data used to mint in Refungible collection.162		NotRefungibleDataUsedToMintFungibleCollectionToken,163		/// Maximum refungibility exceeded.164		WrongRefungiblePieces,165		/// Refungible token can't be repartitioned by user who isn't owns all pieces.166		RepartitionWhileNotOwningAllPieces,167		/// Refungible token can't nest other tokens.168		RefungibleDisallowsNesting,169		/// Setting item properties is not allowed.170		SettingPropertiesNotAllowed,171	}172173	#[pallet::config]174	pub trait Config:175		frame_system::Config + pallet_common::Config + pallet_structure::Config176	{177		type WeightInfo: WeightInfo;178	}179180	const STORAGE_VERSION: StorageVersion = StorageVersion::new(2);181182	#[pallet::pallet]183	#[pallet::storage_version(STORAGE_VERSION)]184	#[pallet::generate_store(pub(super) trait Store)]185	pub struct Pallet<T>(_);186187	/// Total amount of minted tokens in a collection.188	#[pallet::storage]189	pub type TokensMinted<T: Config> =190		StorageMap<Hasher = Twox64Concat, Key = CollectionId, Value = u32, QueryKind = ValueQuery>;191192	/// Amount of tokens burnt in a collection.193	#[pallet::storage]194	pub type TokensBurnt<T: Config> =195		StorageMap<Hasher = Twox64Concat, Key = CollectionId, Value = u32, QueryKind = ValueQuery>;196197	/// Token data, used to partially describe a token.198	// TODO: remove199	#[pallet::storage]200	#[deprecated(since = "0.2.0", note = "ItemData is no more contains usefull data")]201	pub type TokenData<T: Config> = StorageNMap<202		Key = (Key<Twox64Concat, CollectionId>, Key<Twox64Concat, TokenId>),203		Value = ItemData,204		QueryKind = ValueQuery,205	>;206207	/// Amount of pieces a refungible token is split into.208	#[pallet::storage]209	#[pallet::getter(fn token_properties)]210	pub type TokenProperties<T: Config> = StorageNMap<211		Key = (Key<Twox64Concat, CollectionId>, Key<Twox64Concat, TokenId>),212		Value = up_data_structs::Properties,213		QueryKind = ValueQuery,214		OnEmpty = up_data_structs::TokenProperties,215	>;216217	/// Total amount of pieces for token218	#[pallet::storage]219	pub type TotalSupply<T: Config> = StorageNMap<220		Key = (Key<Twox64Concat, CollectionId>, Key<Twox64Concat, TokenId>),221		Value = u128,222		QueryKind = ValueQuery,223	>;224225	/// Used to enumerate tokens owned by account.226	#[pallet::storage]227	pub type Owned<T: Config> = StorageNMap<228		Key = (229			Key<Twox64Concat, CollectionId>,230			Key<Blake2_128Concat, T::CrossAccountId>,231			Key<Twox64Concat, TokenId>,232		),233		Value = bool,234		QueryKind = ValueQuery,235	>;236237	/// Amount of tokens (not pieces) partially owned by an account within a collection.238	#[pallet::storage]239	pub type AccountBalance<T: Config> = StorageNMap<240		Key = (241			Key<Twox64Concat, CollectionId>,242			// Owner243			Key<Blake2_128Concat, T::CrossAccountId>,244		),245		Value = u32,246		QueryKind = ValueQuery,247	>;248249	/// Amount of token pieces owned by account.250	#[pallet::storage]251	pub type Balance<T: Config> = StorageNMap<252		Key = (253			Key<Twox64Concat, CollectionId>,254			Key<Twox64Concat, TokenId>,255			// Owner256			Key<Blake2_128Concat, T::CrossAccountId>,257		),258		Value = u128,259		QueryKind = ValueQuery,260	>;261262	/// Allowance set by a token owner for another user to perform one of certain transactions on a number of pieces of a token.263	#[pallet::storage]264	pub type Allowance<T: Config> = StorageNMap<265		Key = (266			Key<Twox64Concat, CollectionId>,267			Key<Twox64Concat, TokenId>,268			// Owner269			Key<Blake2_128, T::CrossAccountId>,270			// Spender271			Key<Blake2_128Concat, T::CrossAccountId>,272		),273		Value = u128,274		QueryKind = ValueQuery,275	>;276277	#[pallet::hooks]278	impl<T: Config> Hooks<BlockNumberFor<T>> for Pallet<T> {279		fn on_runtime_upgrade() -> Weight {280			let storage_version = StorageVersion::get::<Pallet<T>>();281			if storage_version < StorageVersion::new(2) {282				<TokenData<T>>::remove_all(None);283			}284			StorageVersion::new(2).put::<Pallet<T>>();285286			0287		}288	}289}290291pub struct RefungibleHandle<T: Config>(pallet_common::CollectionHandle<T>);292impl<T: Config> RefungibleHandle<T> {293	pub fn cast(inner: pallet_common::CollectionHandle<T>) -> Self {294		Self(inner)295	}296	pub fn into_inner(self) -> pallet_common::CollectionHandle<T> {297		self.0298	}299	pub fn common_mut(&mut self) -> &mut pallet_common::CollectionHandle<T> {300		&mut self.0301	}302}303304impl<T: Config> Deref for RefungibleHandle<T> {305	type Target = pallet_common::CollectionHandle<T>;306307	fn deref(&self) -> &Self::Target {308		&self.0309	}310}311312impl<T: Config> WithRecorder<T> for RefungibleHandle<T> {313	fn recorder(&self) -> &pallet_evm_coder_substrate::SubstrateRecorder<T> {314		self.0.recorder()315	}316	fn into_recorder(self) -> pallet_evm_coder_substrate::SubstrateRecorder<T> {317		self.0.into_recorder()318	}319}320321impl<T: Config> Pallet<T> {322	/// Get number of RFT tokens in collection323	pub fn total_supply(collection: &RefungibleHandle<T>) -> u32 {324		<TokensMinted<T>>::get(collection.id) - <TokensBurnt<T>>::get(collection.id)325	}326327	/// Check that RFT token exists328	///329	/// - `token`: Token ID.330	pub fn token_exists(collection: &RefungibleHandle<T>, token: TokenId) -> bool {331		<TotalSupply<T>>::contains_key((collection.id, token))332	}333334	pub fn set_scoped_token_property(335		collection_id: CollectionId,336		token_id: TokenId,337		scope: PropertyScope,338		property: Property,339	) -> DispatchResult {340		TokenProperties::<T>::try_mutate((collection_id, token_id), |properties| {341			properties.try_scoped_set(scope, property.key, property.value)342		})343		.map_err(<CommonError<T>>::from)?;344345		Ok(())346	}347348	pub fn set_scoped_token_properties(349		collection_id: CollectionId,350		token_id: TokenId,351		scope: PropertyScope,352		properties: impl Iterator<Item = Property>,353	) -> DispatchResult {354		TokenProperties::<T>::try_mutate((collection_id, token_id), |stored_properties| {355			stored_properties.try_scoped_set_from_iter(scope, properties)356		})357		.map_err(<CommonError<T>>::from)?;358359		Ok(())360	}361}362363// unchecked calls skips any permission checks364impl<T: Config> Pallet<T> {365	/// Create RFT collection366	///367	/// `init_collection` will take non-refundable deposit for collection creation.368	///369	/// - `data`: Contains settings for collection limits and permissions.370	pub fn init_collection(371		owner: T::CrossAccountId,372		data: CreateCollectionData<T::AccountId>,373	) -> Result<CollectionId, DispatchError> {374		<PalletCommon<T>>::init_collection(owner, data, false)375	}376377	/// Destroy RFT collection378	///379	/// `destroy_collection` will throw error if collection contains any tokens.380	/// Only owner can destroy collection.381	pub fn destroy_collection(382		collection: RefungibleHandle<T>,383		sender: &T::CrossAccountId,384	) -> DispatchResult {385		let id = collection.id;386387		if Self::collection_has_tokens(id) {388			return Err(<CommonError<T>>::CantDestroyNotEmptyCollection.into());389		}390391		// =========392393		PalletCommon::destroy_collection(collection.0, sender)?;394395		<TokensMinted<T>>::remove(id);396		<TokensBurnt<T>>::remove(id);397		<TotalSupply<T>>::remove_prefix((id,), None);398		<Balance<T>>::remove_prefix((id,), None);399		<Allowance<T>>::remove_prefix((id,), None);400		<Owned<T>>::remove_prefix((id,), None);401		<AccountBalance<T>>::remove_prefix((id,), None);402		Ok(())403	}404405	fn collection_has_tokens(collection_id: CollectionId) -> bool {406		<TotalSupply<T>>::iter_prefix((collection_id,))407			.next()408			.is_some()409	}410411	pub fn burn_token_unchecked(412		collection: &RefungibleHandle<T>,413		owner: &T::CrossAccountId,414		token_id: TokenId,415	) -> DispatchResult {416		let burnt = <TokensBurnt<T>>::get(collection.id)417			.checked_add(1)418			.ok_or(ArithmeticError::Overflow)?;419420		<TokensBurnt<T>>::insert(collection.id, burnt);421		<TokenProperties<T>>::remove((collection.id, token_id));422		<TotalSupply<T>>::remove((collection.id, token_id));423		<Balance<T>>::remove_prefix((collection.id, token_id), None);424		<Allowance<T>>::remove_prefix((collection.id, token_id), None);425426		<PalletEvm<T>>::deposit_log(427			ERC721Events::Transfer {428				from: *owner.as_eth(),429				to: H160::default(),430				token_id: token_id.into(),431			}432			.to_log(collection_id_to_address(collection.id)),433		);434		Ok(())435	}436437	/// Burn RFT token pieces438	///439	/// `burn` will decrease total amount of token pieces and amount owned by sender.440	/// `burn` can be called even if there are multiple owners of the RFT token.441	/// If sender wouldn't have any pieces left after `burn` than she will stop being442	/// one of the owners of the token. If there is no account that owns any pieces of443	/// the token than token will be burned too.444	///445	/// - `amount`: Amount of token pieces to burn.446	/// - `token`: Token who's pieces should be burned447	/// - `collection`: Collection that contains the token448	pub fn burn(449		collection: &RefungibleHandle<T>,450		owner: &T::CrossAccountId,451		token: TokenId,452		amount: u128,453	) -> DispatchResult {454		let total_supply = <TotalSupply<T>>::get((collection.id, token))455			.checked_sub(amount)456			.ok_or(<CommonError<T>>::TokenValueTooLow)?;457458		// This was probally last owner of this token?459		if total_supply == 0 {460			// Ensure user actually owns this amount461			ensure!(462				<Balance<T>>::get((collection.id, token, owner)) == amount,463				<CommonError<T>>::TokenValueTooLow464			);465			let account_balance = <AccountBalance<T>>::get((collection.id, owner))466				.checked_sub(1)467				// Should not occur468				.ok_or(ArithmeticError::Underflow)?;469470			// =========471472			<Owned<T>>::remove((collection.id, owner, token));473			<PalletStructure<T>>::unnest_if_nested(owner, collection.id, token);474			<AccountBalance<T>>::insert((collection.id, owner), account_balance);475			Self::burn_token_unchecked(collection, owner, token)?;476			<PalletEvm<T>>::deposit_log(477				ERC20Events::Transfer {478					from: *owner.as_eth(),479					to: H160::default(),480					value: amount.into(),481				}482				.to_log(collection_id_to_address(collection.id)),483			);484			<PalletCommon<T>>::deposit_event(CommonEvent::ItemDestroyed(485				collection.id,486				token,487				owner.clone(),488				amount,489			));490			return Ok(());491		}492493		let balance = <Balance<T>>::get((collection.id, token, owner))494			.checked_sub(amount)495			.ok_or(<CommonError<T>>::TokenValueTooLow)?;496		let account_balance = if balance == 0 {497			<AccountBalance<T>>::get((collection.id, owner))498				.checked_sub(1)499				// Should not occur500				.ok_or(ArithmeticError::Underflow)?501		} else {502			0503		};504505		// =========506507		if balance == 0 {508			<Owned<T>>::remove((collection.id, owner, token));509			<PalletStructure<T>>::unnest_if_nested(owner, collection.id, token);510			<Balance<T>>::remove((collection.id, token, owner));511			<AccountBalance<T>>::insert((collection.id, owner), account_balance);512513			if let Some(user) = Self::token_owner(collection.id, token) {514				<PalletEvm<T>>::deposit_log(515					ERC721Events::Transfer {516						from: erc::ADDRESS_FOR_PARTIALLY_OWNED_TOKENS,517						to: *user.as_eth(),518						token_id: token.into(),519					}520					.to_log(collection_id_to_address(collection.id)),521				);522			}523		} else {524			<Balance<T>>::insert((collection.id, token, owner), balance);525		}526		<TotalSupply<T>>::insert((collection.id, token), total_supply);527528		<PalletEvm<T>>::deposit_log(529			ERC20Events::Transfer {530				from: *owner.as_eth(),531				to: H160::default(),532				value: amount.into(),533			}534			.to_log(T::EvmTokenAddressMapping::token_to_address(535				collection.id,536				token,537			)),538		);539		<PalletCommon<T>>::deposit_event(CommonEvent::ItemDestroyed(540			collection.id,541			token,542			owner.clone(),543			amount,544		));545		Ok(())546	}547548	#[transactional]549	fn modify_token_properties(550		collection: &RefungibleHandle<T>,551		sender: &T::CrossAccountId,552		token_id: TokenId,553		properties: impl Iterator<Item = (PropertyKey, Option<PropertyValue>)>,554		is_token_create: bool,555		nesting_budget: &dyn Budget,556	) -> DispatchResult {557		let is_collection_admin = || collection.is_owner_or_admin(sender);558		let is_token_owner = || -> Result<bool, DispatchError> {559			let balance = collection.balance(sender.clone(), token_id);560			let total_pieces: u128 =561				Self::total_pieces(collection.id, token_id).unwrap_or(u128::MAX);562			if balance != total_pieces {563				return Ok(false);564			}565566			let is_bundle_owner = <PalletStructure<T>>::check_indirectly_owned(567				sender.clone(),568				collection.id,569				token_id,570				None,571				nesting_budget,572			)?;573574			Ok(is_bundle_owner)575		};576577		for (key, value) in properties {578			let permission = <PalletCommon<T>>::property_permissions(collection.id)579				.get(&key)580				.cloned()581				.unwrap_or_else(PropertyPermission::none);582583			let is_property_exists = TokenProperties::<T>::get((collection.id, token_id))584				.get(&key)585				.is_some();586587			match permission {588				PropertyPermission { mutable: false, .. } if is_property_exists => {589					return Err(<CommonError<T>>::NoPermission.into());590				}591592				PropertyPermission {593					collection_admin,594					token_owner,595					..596				} => {597					//TODO: investigate threats during public minting.598					let is_token_create =599						is_token_create && (collection_admin || token_owner) && value.is_some();600					if !(is_token_create601						|| (collection_admin && is_collection_admin())602						|| (token_owner && is_token_owner()?))603					{604						fail!(<CommonError<T>>::NoPermission);605					}606				}607			}608609			match value {610				Some(value) => {611					<TokenProperties<T>>::try_mutate((collection.id, token_id), |properties| {612						properties.try_set(key.clone(), value)613					})614					.map_err(<CommonError<T>>::from)?;615616					<PalletCommon<T>>::deposit_event(CommonEvent::TokenPropertySet(617						collection.id,618						token_id,619						key,620					));621				}622				None => {623					<TokenProperties<T>>::try_mutate((collection.id, token_id), |properties| {624						properties.remove(&key)625					})626					.map_err(<CommonError<T>>::from)?;627628					<PalletCommon<T>>::deposit_event(CommonEvent::TokenPropertyDeleted(629						collection.id,630						token_id,631						key,632					));633				}634			}635		}636637		Ok(())638	}639640	pub fn set_token_properties(641		collection: &RefungibleHandle<T>,642		sender: &T::CrossAccountId,643		token_id: TokenId,644		properties: impl Iterator<Item = Property>,645		is_token_create: bool,646		nesting_budget: &dyn Budget,647	) -> DispatchResult {648		Self::modify_token_properties(649			collection,650			sender,651			token_id,652			properties.map(|p| (p.key, Some(p.value))),653			is_token_create,654			nesting_budget,655		)656	}657658	pub fn set_token_property(659		collection: &RefungibleHandle<T>,660		sender: &T::CrossAccountId,661		token_id: TokenId,662		property: Property,663		nesting_budget: &dyn Budget,664	) -> DispatchResult {665		let is_token_create = false;666667		Self::set_token_properties(668			collection,669			sender,670			token_id,671			[property].into_iter(),672			is_token_create,673			nesting_budget,674		)675	}676677	pub fn delete_token_properties(678		collection: &RefungibleHandle<T>,679		sender: &T::CrossAccountId,680		token_id: TokenId,681		property_keys: impl Iterator<Item = PropertyKey>,682		nesting_budget: &dyn Budget,683	) -> DispatchResult {684		let is_token_create = false;685686		Self::modify_token_properties(687			collection,688			sender,689			token_id,690			property_keys.into_iter().map(|key| (key, None)),691			is_token_create,692			nesting_budget,693		)694	}695696	pub fn delete_token_property(697		collection: &RefungibleHandle<T>,698		sender: &T::CrossAccountId,699		token_id: TokenId,700		property_key: PropertyKey,701		nesting_budget: &dyn Budget,702	) -> DispatchResult {703		Self::delete_token_properties(704			collection,705			sender,706			token_id,707			[property_key].into_iter(),708			nesting_budget,709		)710	}711712	/// Transfer RFT token pieces from one account to another.713	///714	/// If the sender is no longer owns any pieces after the `transfer` than she stops being an owner of the token.715	///716	/// - `from`: Owner of token pieces to transfer.717	/// - `to`: Recepient of transfered token pieces.718	/// - `amount`: Amount of token pieces to transfer.719	/// - `token`: Token whos pieces should be transfered720	/// - `collection`: Collection that contains the token721	pub fn transfer(722		collection: &RefungibleHandle<T>,723		from: &T::CrossAccountId,724		to: &T::CrossAccountId,725		token: TokenId,726		amount: u128,727		nesting_budget: &dyn Budget,728	) -> DispatchResult {729		ensure!(730			collection.limits.transfers_enabled(),731			<CommonError<T>>::TransferNotAllowed732		);733734		if collection.permissions.access() == AccessMode::AllowList {735			collection.check_allowlist(from)?;736			collection.check_allowlist(to)?;737		}738		<PalletCommon<T>>::ensure_correct_receiver(to)?;739740		let initial_balance_from = <Balance<T>>::get((collection.id, token, from));741		let updated_balance_from = initial_balance_from742			.checked_sub(amount)743			.ok_or(<CommonError<T>>::TokenValueTooLow)?;744		let mut create_target = false;745		let from_to_differ = from != to;746		let updated_balance_to = if from != to {747			let old_balance = <Balance<T>>::get((collection.id, token, to));748			if old_balance == 0 {749				create_target = true;750			}751			Some(752				old_balance753					.checked_add(amount)754					.ok_or(ArithmeticError::Overflow)?,755			)756		} else {757			None758		};759760		let account_balance_from = if updated_balance_from == 0 {761			Some(762				<AccountBalance<T>>::get((collection.id, from))763					.checked_sub(1)764					// Should not occur765					.ok_or(ArithmeticError::Underflow)?,766			)767		} else {768			None769		};770		// Account data is created in token, AccountBalance should be increased771		// But only if from != to as we shouldn't check overflow in this case772		let account_balance_to = if create_target && from_to_differ {773			let account_balance_to = <AccountBalance<T>>::get((collection.id, to))774				.checked_add(1)775				.ok_or(ArithmeticError::Overflow)?;776			ensure!(777				account_balance_to < collection.limits.account_token_ownership_limit(),778				<CommonError<T>>::AccountTokenLimitExceeded,779			);780781			Some(account_balance_to)782		} else {783			None784		};785786		// =========787788		<PalletStructure<T>>::nest_if_sent_to_token(789			from.clone(),790			to,791			collection.id,792			token,793			nesting_budget,794		)?;795796		if let Some(updated_balance_to) = updated_balance_to {797			// from != to798			if updated_balance_from == 0 {799				<Balance<T>>::remove((collection.id, token, from));800				<PalletStructure<T>>::unnest_if_nested(from, collection.id, token);801			} else {802				<Balance<T>>::insert((collection.id, token, from), updated_balance_from);803			}804			<Balance<T>>::insert((collection.id, token, to), updated_balance_to);805			if let Some(account_balance_from) = account_balance_from {806				<AccountBalance<T>>::insert((collection.id, from), account_balance_from);807				<Owned<T>>::remove((collection.id, from, token));808			}809			if let Some(account_balance_to) = account_balance_to {810				<AccountBalance<T>>::insert((collection.id, to), account_balance_to);811				<Owned<T>>::insert((collection.id, to, token), true);812			}813		}814815		<PalletEvm<T>>::deposit_log(816			ERC20Events::Transfer {817				from: *from.as_eth(),818				to: *to.as_eth(),819				value: amount.into(),820			}821			.to_log(T::EvmTokenAddressMapping::token_to_address(822				collection.id,823				token,824			)),825		);826827		<PalletCommon<T>>::deposit_event(CommonEvent::Transfer(828			collection.id,829			token,830			from.clone(),831			to.clone(),832			amount,833		));834835		let total_supply = <TotalSupply<T>>::get((collection.id, token));836837		if amount == total_supply {838			// if token was fully owned by `from` and will be fully owned by `to` after transfer839			<PalletEvm<T>>::deposit_log(840				ERC721Events::Transfer {841					from: *from.as_eth(),842					to: *to.as_eth(),843					token_id: token.into(),844				}845				.to_log(collection_id_to_address(collection.id)),846			);847		} else if let Some(updated_balance_to) = updated_balance_to {848			// if `from` not equals `to`. This condition is needed to avoid sending event849			// when `from` fully owns token and sends part of token pieces to itself.850			if initial_balance_from == total_supply {851				// if token was fully owned by `from` and will be only partially owned by `to`852				// and `from` after transfer853				<PalletEvm<T>>::deposit_log(854					ERC721Events::Transfer {855						from: *from.as_eth(),856						to: erc::ADDRESS_FOR_PARTIALLY_OWNED_TOKENS,857						token_id: token.into(),858					}859					.to_log(collection_id_to_address(collection.id)),860				);861			} else if updated_balance_to == total_supply {862				// if token was partially owned by `from` and will be fully owned by `to` after transfer863				<PalletEvm<T>>::deposit_log(864					ERC721Events::Transfer {865						from: erc::ADDRESS_FOR_PARTIALLY_OWNED_TOKENS,866						to: *to.as_eth(),867						token_id: token.into(),868					}869					.to_log(collection_id_to_address(collection.id)),870				);871			}872		}873874		Ok(())875	}876877	/// Batched operation to create multiple RFT tokens.878	///879	/// Same as `create_item` but creates multiple tokens.880	///881	/// - `data`: Same as 'data` in `create_item` but contains data for multiple tokens.882	pub fn create_multiple_items(883		collection: &RefungibleHandle<T>,884		sender: &T::CrossAccountId,885		data: Vec<CreateItemData<T::CrossAccountId>>,886		nesting_budget: &dyn Budget,887	) -> DispatchResult {888		if !collection.is_owner_or_admin(sender) {889			ensure!(890				collection.permissions.mint_mode(),891				<CommonError<T>>::PublicMintingNotAllowed892			);893			collection.check_allowlist(sender)?;894895			for item in data.iter() {896				for user in item.users.keys() {897					collection.check_allowlist(user)?;898				}899			}900		}901902		for item in data.iter() {903			for (owner, _) in item.users.iter() {904				<PalletCommon<T>>::ensure_correct_receiver(owner)?;905			}906		}907908		// Total pieces per tokens909		let totals = data910			.iter()911			.map(|data| {912				Ok(data913					.users914					.iter()915					.map(|u| u.1)916					.try_fold(0u128, |acc, v| acc.checked_add(*v))917					.ok_or(ArithmeticError::Overflow)?)918			})919			.collect::<Result<Vec<_>, DispatchError>>()?;920		for total in &totals {921			ensure!(922				*total <= MAX_REFUNGIBLE_PIECES,923				<Error<T>>::WrongRefungiblePieces924			);925		}926927		let first_token_id = <TokensMinted<T>>::get(collection.id);928		let tokens_minted = first_token_id929			.checked_add(data.len() as u32)930			.ok_or(ArithmeticError::Overflow)?;931		ensure!(932			tokens_minted < collection.limits.token_limit(),933			<CommonError<T>>::CollectionTokenLimitExceeded934		);935936		let mut balances = BTreeMap::new();937		for data in &data {938			for owner in data.users.keys() {939				let balance = balances940					.entry(owner)941					.or_insert_with(|| <AccountBalance<T>>::get((collection.id, owner)));942				*balance = balance.checked_add(1).ok_or(ArithmeticError::Overflow)?;943944				ensure!(945					*balance <= collection.limits.account_token_ownership_limit(),946					<CommonError<T>>::AccountTokenLimitExceeded,947				);948			}949		}950951		for (i, token) in data.iter().enumerate() {952			let token_id = TokenId(first_token_id + i as u32 + 1);953			for (to, _) in token.users.iter() {954				<PalletStructure<T>>::check_nesting(955					sender.clone(),956					to,957					collection.id,958					token_id,959					nesting_budget,960				)?;961			}962		}963964		// =========965966		with_transaction(|| {967			for (i, data) in data.iter().enumerate() {968				let token_id = first_token_id + i as u32 + 1;969				<TotalSupply<T>>::insert((collection.id, token_id), totals[i]);970971				for (user, amount) in data.users.iter() {972					if *amount == 0 {973						continue;974					}975					<Balance<T>>::insert((collection.id, token_id, &user), amount);976					<Owned<T>>::insert((collection.id, &user, TokenId(token_id)), true);977					<PalletStructure<T>>::nest_if_sent_to_token_unchecked(978						user,979						collection.id,980						TokenId(token_id),981					);982				}983984				if let Err(e) = Self::set_token_properties(985					collection,986					sender,987					TokenId(token_id),988					data.properties.clone().into_iter(),989					true,990					nesting_budget,991				) {992					return TransactionOutcome::Rollback(Err(e));993				}994			}995			TransactionOutcome::Commit(Ok(()))996		})?;997998		<TokensMinted<T>>::insert(collection.id, tokens_minted);9991000		for (account, balance) in balances {1001			<AccountBalance<T>>::insert((collection.id, account), balance);1002		}10031004		for (i, token) in data.into_iter().enumerate() {1005			let token_id = first_token_id + i as u32 + 1;10061007			let receivers = token1008				.users1009				.into_iter()1010				.filter(|(_, amount)| *amount > 0)1011				.collect::<Vec<_>>();10121013			if let [(user, _)] = receivers.as_slice() {1014				// if there is exactly one receiver1015				<PalletEvm<T>>::deposit_log(1016					ERC721Events::Transfer {1017						from: H160::default(),1018						to: *user.as_eth(),1019						token_id: token_id.into(),1020					}1021					.to_log(collection_id_to_address(collection.id)),1022				);1023			} else if let [_, ..] = receivers.as_slice() {1024				// if there is more than one receiver1025				<PalletEvm<T>>::deposit_log(1026					ERC721Events::Transfer {1027						from: H160::default(),1028						to: erc::ADDRESS_FOR_PARTIALLY_OWNED_TOKENS,1029						token_id: token_id.into(),1030					}1031					.to_log(collection_id_to_address(collection.id)),1032				);1033			}10341035			for (user, amount) in receivers.into_iter() {1036				<PalletEvm<T>>::deposit_log(1037					ERC20Events::Transfer {1038						from: H160::default(),1039						to: *user.as_eth(),1040						value: amount.into(),1041					}1042					.to_log(T::EvmTokenAddressMapping::token_to_address(1043						collection.id,1044						TokenId(token_id),1045					)),1046				);1047				<PalletCommon<T>>::deposit_event(CommonEvent::ItemCreated(1048					collection.id,1049					TokenId(token_id),1050					user,1051					amount,1052				));1053			}1054		}1055		Ok(())1056	}10571058	pub fn set_allowance_unchecked(1059		collection: &RefungibleHandle<T>,1060		sender: &T::CrossAccountId,1061		spender: &T::CrossAccountId,1062		token: TokenId,1063		amount: u128,1064	) {1065		if amount == 0 {1066			<Allowance<T>>::remove((collection.id, token, sender, spender));1067		} else {1068			<Allowance<T>>::insert((collection.id, token, sender, spender), amount);1069		}10701071		<PalletEvm<T>>::deposit_log(1072			ERC20Events::Approval {1073				owner: *sender.as_eth(),1074				spender: *spender.as_eth(),1075				value: amount.into(),1076			}1077			.to_log(T::EvmTokenAddressMapping::token_to_address(1078				collection.id,1079				token,1080			)),1081		);1082		<PalletCommon<T>>::deposit_event(CommonEvent::Approved(1083			collection.id,1084			token,1085			sender.clone(),1086			spender.clone(),1087			amount,1088		))1089	}10901091	/// Set allowance for the spender to `transfer` or `burn` sender's token pieces.1092	///1093	/// - `amount`: Amount of token pieces the spender is allowed to `transfer` or `burn.1094	pub fn set_allowance(1095		collection: &RefungibleHandle<T>,1096		sender: &T::CrossAccountId,1097		spender: &T::CrossAccountId,1098		token: TokenId,1099		amount: u128,1100	) -> DispatchResult {1101		if collection.permissions.access() == AccessMode::AllowList {1102			collection.check_allowlist(sender)?;1103			collection.check_allowlist(spender)?;1104		}11051106		<PalletCommon<T>>::ensure_correct_receiver(spender)?;11071108		if <Balance<T>>::get((collection.id, token, sender)) < amount {1109			ensure!(1110				collection.ignores_owned_amount(sender) && Self::token_exists(collection, token),1111				<CommonError<T>>::CantApproveMoreThanOwned1112			);1113		}11141115		// =========11161117		Self::set_allowance_unchecked(collection, sender, spender, token, amount);1118		Ok(())1119	}11201121	/// Returns allowance, which should be set after transaction1122	fn check_allowed(1123		collection: &RefungibleHandle<T>,1124		spender: &T::CrossAccountId,1125		from: &T::CrossAccountId,1126		token: TokenId,1127		amount: u128,1128		nesting_budget: &dyn Budget,1129	) -> Result<Option<u128>, DispatchError> {1130		if spender.conv_eq(from) {1131			return Ok(None);1132		}1133		if collection.permissions.access() == AccessMode::AllowList {1134			// `from`, `to` checked in [`transfer`]1135			collection.check_allowlist(spender)?;1136		}1137		if let Some(source) = T::CrossTokenAddressMapping::address_to_token(from) {1138			// TODO: should collection owner be allowed to perform this transfer?1139			ensure!(1140				<PalletStructure<T>>::check_indirectly_owned(1141					spender.clone(),1142					source.0,1143					source.1,1144					None,1145					nesting_budget1146				)?,1147				<CommonError<T>>::ApprovedValueTooLow,1148			);1149			return Ok(None);1150		}1151		let allowance =1152			<Allowance<T>>::get((collection.id, token, from, &spender)).checked_sub(amount);1153		if allowance.is_none() {1154			ensure!(1155				collection.ignores_allowance(spender),1156				<CommonError<T>>::ApprovedValueTooLow1157			);1158		}1159		Ok(allowance)1160	}11611162	/// Transfer RFT token pieces from one account to another.1163	///1164	/// Same as the [`transfer`] but spender doesn't needs to be an owner of the token pieces.1165	/// The owner should set allowance for the spender to transfer pieces.1166	///1167	/// [`transfer`]: struct.Pallet.html#method.transfer1168	pub fn transfer_from(1169		collection: &RefungibleHandle<T>,1170		spender: &T::CrossAccountId,1171		from: &T::CrossAccountId,1172		to: &T::CrossAccountId,1173		token: TokenId,1174		amount: u128,1175		nesting_budget: &dyn Budget,1176	) -> DispatchResult {1177		let allowance =1178			Self::check_allowed(collection, spender, from, token, amount, nesting_budget)?;11791180		// =========11811182		Self::transfer(collection, from, to, token, amount, nesting_budget)?;1183		if let Some(allowance) = allowance {1184			Self::set_allowance_unchecked(collection, from, spender, token, allowance);1185		}1186		Ok(())1187	}11881189	/// Burn RFT token pieces from the account.1190	///1191	/// Same as the [`burn`] but spender doesn't need to be an owner of the token pieces. The owner should1192	/// set allowance for the spender to burn pieces1193	///1194	/// [`burn`]: struct.Pallet.html#method.burn1195	pub fn burn_from(1196		collection: &RefungibleHandle<T>,1197		spender: &T::CrossAccountId,1198		from: &T::CrossAccountId,1199		token: TokenId,1200		amount: u128,1201		nesting_budget: &dyn Budget,1202	) -> DispatchResult {1203		let allowance =1204			Self::check_allowed(collection, spender, from, token, amount, nesting_budget)?;12051206		// =========12071208		Self::burn(collection, from, token, amount)?;1209		if let Some(allowance) = allowance {1210			Self::set_allowance_unchecked(collection, from, spender, token, allowance);1211		}1212		Ok(())1213	}12141215	/// Create RFT token.1216	///1217	/// The sender should be the owner/admin of the collection or collection should be configured1218	/// to allow public minting.1219	///1220	/// - `data`: Contains list of users who will become the owners of the token pieces and amount1221	///   of token pieces they will receive.1222	pub fn create_item(1223		collection: &RefungibleHandle<T>,1224		sender: &T::CrossAccountId,1225		data: CreateItemData<T::CrossAccountId>,1226		nesting_budget: &dyn Budget,1227	) -> DispatchResult {1228		Self::create_multiple_items(collection, sender, vec![data], nesting_budget)1229	}12301231	/// Repartition RFT token.1232	///1233	/// `repartition` will set token balance of the sender and total amount of token pieces.1234	/// Sender should own all of the token pieces. `repartition' could be done even if some1235	/// token pieces were burned before.1236	///1237	/// - `amount`: Total amount of token pieces that the token will have after `repartition`.1238	pub fn repartition(1239		collection: &RefungibleHandle<T>,1240		owner: &T::CrossAccountId,1241		token: TokenId,1242		amount: u128,1243	) -> DispatchResult {1244		ensure!(1245			amount <= MAX_REFUNGIBLE_PIECES,1246			<Error<T>>::WrongRefungiblePieces1247		);1248		ensure!(amount > 0, <CommonError<T>>::TokenValueTooLow);1249		// Ensure user owns all pieces1250		let total_pieces = Self::total_pieces(collection.id, token).unwrap_or(u128::MAX);1251		let balance = <Balance<T>>::get((collection.id, token, owner));1252		ensure!(1253			total_pieces == balance,1254			<Error<T>>::RepartitionWhileNotOwningAllPieces1255		);12561257		<Balance<T>>::insert((collection.id, token, owner), amount);1258		<TotalSupply<T>>::insert((collection.id, token), amount);12591260		if amount > total_pieces {1261			let mint_amount = amount - total_pieces;1262			<PalletEvm<T>>::deposit_log(1263				ERC20Events::Transfer {1264					from: H160::default(),1265					to: *owner.as_eth(),1266					value: mint_amount.into(),1267				}1268				.to_log(T::EvmTokenAddressMapping::token_to_address(1269					collection.id,1270					token,1271				)),1272			);1273			<PalletCommon<T>>::deposit_event(CommonEvent::ItemCreated(1274				collection.id,1275				token,1276				owner.clone(),1277				mint_amount,1278			));1279		} else if total_pieces > amount {1280			let burn_amount = total_pieces - amount;1281			<PalletEvm<T>>::deposit_log(1282				ERC20Events::Transfer {1283					from: *owner.as_eth(),1284					to: H160::default(),1285					value: burn_amount.into(),1286				}1287				.to_log(T::EvmTokenAddressMapping::token_to_address(1288					collection.id,1289					token,1290				)),1291			);1292			<PalletCommon<T>>::deposit_event(CommonEvent::ItemDestroyed(1293				collection.id,1294				token,1295				owner.clone(),1296				burn_amount,1297			));1298		}12991300		Ok(())1301	}13021303	fn token_owner(collection_id: CollectionId, token_id: TokenId) -> Option<T::CrossAccountId> {1304		let mut owner = None;1305		let mut count = 0;1306		for key in Balance::<T>::iter_key_prefix((collection_id, token_id)) {1307			count += 1;1308			if count > 1 {1309				return None;1310			}1311			owner = Some(key);1312		}1313		owner1314	}13151316	fn total_pieces(collection_id: CollectionId, token_id: TokenId) -> Option<u128> {1317		<TotalSupply<T>>::try_get((collection_id, token_id)).ok()1318	}13191320	pub fn set_collection_properties(1321		collection: &RefungibleHandle<T>,1322		sender: &T::CrossAccountId,1323		properties: Vec<Property>,1324	) -> DispatchResult {1325		<PalletCommon<T>>::set_collection_properties(collection, sender, properties)1326	}13271328	pub fn delete_collection_properties(1329		collection: &RefungibleHandle<T>,1330		sender: &T::CrossAccountId,1331		property_keys: Vec<PropertyKey>,1332	) -> DispatchResult {1333		<PalletCommon<T>>::delete_collection_properties(collection, sender, property_keys)1334	}13351336	pub fn set_token_property_permissions(1337		collection: &RefungibleHandle<T>,1338		sender: &T::CrossAccountId,1339		property_permissions: Vec<PropertyKeyPermission>,1340	) -> DispatchResult {1341		<PalletCommon<T>>::set_token_property_permissions(collection, sender, property_permissions)1342	}13431344	/// Returns 10 token in no particular order.1345	///1346	/// There is no direct way to get token holders in ascending order,1347	/// since `iter_prefix` returns values in no particular order.1348	/// Therefore, getting the 10 largest holders with a large value of holders1349	/// can lead to impact memory allocation + sorting with  `n * log (n)`.1350	pub fn token_owners(1351		collection_id: CollectionId,1352		token: TokenId,1353	) -> Option<Vec<T::CrossAccountId>> {1354		let res: Vec<T::CrossAccountId> = <Balance<T>>::iter_prefix((collection_id, token))1355			.map(|(owner, _amount)| owner)1356			.take(10)1357			.collect();13581359		if res.is_empty() {1360			None1361		} else {1362			Some(res)1363		}1364	}1365}
modifiedprimitives/data-structs/src/lib.rsdiffbeforeafterboth
--- a/primitives/data-structs/src/lib.rs
+++ b/primitives/data-structs/src/lib.rs
@@ -826,13 +826,23 @@
 /// Extended data for create ReFungible item.
 #[derive(Encode, Decode, MaxEncodedLen, PartialEq, Clone, TypeInfo, Derivative)]
 #[derivative(Debug(bound = "CrossAccountId: fmt::Debug + Ord"))]
-pub struct CreateRefungibleExData<CrossAccountId> {
+pub struct CreateRefungibleExMultipleOwners<CrossAccountId> {
 	#[derivative(Debug(format_with = "bounded::map_debug"))]
 	pub users: BoundedBTreeMap<CrossAccountId, u128, ConstU32<MAX_ITEMS_PER_BATCH>>,
 	#[derivative(Debug(format_with = "bounded::vec_debug"))]
 	pub properties: CollectionPropertiesVec,
 }
 
+/// Extended data for create ReFungible item.
+#[derive(Encode, Decode, MaxEncodedLen, PartialEq, Clone, TypeInfo, Derivative)]
+#[derivative(Debug(bound = "CrossAccountId: fmt::Debug"))]
+pub struct CreateRefungibleExSingleOwner<CrossAccountId> {
+	pub user: CrossAccountId,
+	pub pieces: u128,
+	#[derivative(Debug(format_with = "bounded::vec_debug"))]
+	pub properties: CollectionPropertiesVec,
+}
+
 /// Unified extended data for creating item.
 #[derive(Encode, Decode, MaxEncodedLen, PartialEq, Clone, TypeInfo, Derivative)]
 #[derivative(Debug(bound = "CrossAccountId: fmt::Debug + Ord"))]
@@ -853,12 +863,12 @@
 	/// many tokens, each may have only one owner
 	RefungibleMultipleItems(
 		#[derivative(Debug(format_with = "bounded::vec_debug"))]
-		BoundedVec<CreateRefungibleExData<CrossAccountId>, ConstU32<MAX_ITEMS_PER_BATCH>>,
+		BoundedVec<CreateRefungibleExSingleOwner<CrossAccountId>, ConstU32<MAX_ITEMS_PER_BATCH>>,
 	),
 
 	/// Extended data for create ReFungible item in case of
 	/// single token, which may have many owners
-	RefungibleMultipleOwners(CreateRefungibleExData<CrossAccountId>),
+	RefungibleMultipleOwners(CreateRefungibleExMultipleOwners<CrossAccountId>),
 }
 
 impl From<CreateNftData> for CreateItemData {