git.delta.rocks / unique-network / refs/commits / e4d3792751ad

difftreelog

feat add benchmarks for burn_from

Yaroslav Bolyukin2021-11-05parent: #3d14ec5.patch.diff
in: master

12 files changed

modifiedpallets/common/src/benchmarking.rsdiffbeforeafterboth
--- a/pallets/common/src/benchmarking.rs
+++ b/pallets/common/src/benchmarking.rs
@@ -54,7 +54,6 @@
 		variable_on_chain_schema,
 		const_on_chain_schema,
 		meta_update_permission: Default::default(),
-		transfers_enabled: true,
 	})
 	.and_then(CollectionHandle::try_get)
 	.map(cast)
modifiedpallets/fungible/src/benchmarking.rsdiffbeforeafterboth
--- a/pallets/fungible/src/benchmarking.rs
+++ b/pallets/fungible/src/benchmarking.rs
@@ -58,4 +58,13 @@
 		<Pallet<T>>::create_item(&collection, &owner, (sender.clone(), 200))?;
 		<Pallet<T>>::set_allowance(&collection, &sender, &spender, 200)?;
 	}: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, 100)?}
+
+	burn_from {
+		bench_init!{
+			owner: sub; collection: collection(owner);
+			owner: cross_from_sub; sender: cross_sub; burner: cross_sub;
+		};
+		<Pallet<T>>::create_item(&collection, &owner, (sender.clone(), 200))?;
+		<Pallet<T>>::set_allowance(&collection, &sender, &burner, 200)?;
+	}: {<Pallet<T>>::burn_from(&collection, &burner, &sender, 100)?}
 }
modifiedpallets/fungible/src/common.rsdiffbeforeafterboth
--- a/pallets/fungible/src/common.rs
+++ b/pallets/fungible/src/common.rs
@@ -37,7 +37,7 @@
 	}
 
 	fn burn_from() -> Weight {
-		0
+		<SelfWeightOf<T>>::burn_from()
 	}
 
 	fn set_variable_metadata(_bytes: u32) -> Weight {
modifiedpallets/fungible/src/weights.rsdiffbeforeafterboth
before · pallets/fungible/src/weights.rs
1// Template adopted from https://github.com/paritytech/substrate/blob/master/.maintain/frame-weight-template.hbs23//! Autogenerated weights for pallet_fungible4//!5//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev6//! DATE: 2021-10-21, STEPS: `50`, REPEAT: 20, LOW RANGE: `[]`, HIGH RANGE: `[]`7//! EXECUTION: None, WASM-EXECUTION: Compiled, CHAIN: None, DB CACHE: 12889// Executed Command:10// target/release/nft11// benchmark12// --pallet13// pallet-fungible14// --wasm-execution15// compiled16// --extrinsic17// *18// --template19// .maintain/frame-weight-template.hbs20// --steps=5021// --repeat=2022// --output=./pallets/fungible/src/weights.rs232425#![cfg_attr(rustfmt, rustfmt_skip)]26#![allow(unused_parens)]27#![allow(unused_imports)]2829use frame_support::{traits::Get, weights::{Weight, constants::RocksDbWeight}};30use sp_std::marker::PhantomData;3132/// Weight functions needed for pallet_fungible.33pub trait WeightInfo {34	fn create_item() -> Weight;35	fn burn_item() -> Weight;36	fn transfer() -> Weight;37	fn approve() -> Weight;38	fn transfer_from() -> Weight;39}4041/// Weights for pallet_fungible using the Substrate node and recommended hardware.42pub struct SubstrateWeight<T>(PhantomData<T>);43impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {44	// Storage: Fungible Balance (r:1 w:1)45	// Storage: Fungible TotalSupply (r:0 w:1)46	fn create_item() -> Weight {47		(12_069_000 as Weight)48			.saturating_add(T::DbWeight::get().reads(1 as Weight))49			.saturating_add(T::DbWeight::get().writes(2 as Weight))50	}51	// Storage: Fungible TotalSupply (r:1 w:1)52	// Storage: Fungible Balance (r:1 w:1)53	fn burn_item() -> Weight {54		(14_096_000 as Weight)55			.saturating_add(T::DbWeight::get().reads(2 as Weight))56			.saturating_add(T::DbWeight::get().writes(2 as Weight))57	}58	// Storage: Fungible Balance (r:2 w:2)59	fn transfer() -> Weight {60		(15_436_000 as Weight)61			.saturating_add(T::DbWeight::get().reads(2 as Weight))62			.saturating_add(T::DbWeight::get().writes(2 as Weight))63	}64	// Storage: Fungible Balance (r:1 w:0)65	// Storage: Fungible Allowance (r:0 w:1)66	fn approve() -> Weight {67		(12_867_000 as Weight)68			.saturating_add(T::DbWeight::get().reads(1 as Weight))69			.saturating_add(T::DbWeight::get().writes(1 as Weight))70	}71	// Storage: Fungible Allowance (r:1 w:1)72	// Storage: Fungible Balance (r:2 w:2)73	fn transfer_from() -> Weight {74		(21_462_000 as Weight)75			.saturating_add(T::DbWeight::get().reads(3 as Weight))76			.saturating_add(T::DbWeight::get().writes(3 as Weight))77	}78}7980// For backwards compatibility and tests81impl WeightInfo for () {82	// Storage: Fungible Balance (r:1 w:1)83	// Storage: Fungible TotalSupply (r:0 w:1)84	fn create_item() -> Weight {85		(12_069_000 as Weight)86			.saturating_add(RocksDbWeight::get().reads(1 as Weight))87			.saturating_add(RocksDbWeight::get().writes(2 as Weight))88	}89	// Storage: Fungible TotalSupply (r:1 w:1)90	// Storage: Fungible Balance (r:1 w:1)91	fn burn_item() -> Weight {92		(14_096_000 as Weight)93			.saturating_add(RocksDbWeight::get().reads(2 as Weight))94			.saturating_add(RocksDbWeight::get().writes(2 as Weight))95	}96	// Storage: Fungible Balance (r:2 w:2)97	fn transfer() -> Weight {98		(15_436_000 as Weight)99			.saturating_add(RocksDbWeight::get().reads(2 as Weight))100			.saturating_add(RocksDbWeight::get().writes(2 as Weight))101	}102	// Storage: Fungible Balance (r:1 w:0)103	// Storage: Fungible Allowance (r:0 w:1)104	fn approve() -> Weight {105		(12_867_000 as Weight)106			.saturating_add(RocksDbWeight::get().reads(1 as Weight))107			.saturating_add(RocksDbWeight::get().writes(1 as Weight))108	}109	// Storage: Fungible Allowance (r:1 w:1)110	// Storage: Fungible Balance (r:2 w:2)111	fn transfer_from() -> Weight {112		(21_462_000 as Weight)113			.saturating_add(RocksDbWeight::get().reads(3 as Weight))114			.saturating_add(RocksDbWeight::get().writes(3 as Weight))115	}116}
after · pallets/fungible/src/weights.rs
1// Template adopted from https://github.com/paritytech/substrate/blob/master/.maintain/frame-weight-template.hbs23//! Autogenerated weights for pallet_fungible4//!5//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev6//! DATE: 2021-10-21, STEPS: `50`, REPEAT: 20, LOW RANGE: `[]`, HIGH RANGE: `[]`7//! EXECUTION: None, WASM-EXECUTION: Compiled, CHAIN: None, DB CACHE: 12889// Executed Command:10// target/release/nft11// benchmark12// --pallet13// pallet-fungible14// --wasm-execution15// compiled16// --extrinsic17// *18// --template19// .maintain/frame-weight-template.hbs20// --steps=5021// --repeat=2022// --output=./pallets/fungible/src/weights.rs232425#![cfg_attr(rustfmt, rustfmt_skip)]26#![allow(unused_parens)]27#![allow(unused_imports)]2829use frame_support::{traits::Get, weights::{Weight, constants::RocksDbWeight}};30use sp_std::marker::PhantomData;3132/// Weight functions needed for pallet_fungible.33pub trait WeightInfo {34	fn create_item() -> Weight;35	fn burn_item() -> Weight;36	fn transfer() -> Weight;37	fn approve() -> Weight;38	fn transfer_from() -> Weight;39}4041/// Weights for pallet_fungible using the Substrate node and recommended hardware.42pub struct SubstrateWeight<T>(PhantomData<T>);43impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {44	// Storage: Fungible Balance (r:1 w:1)45	// Storage: Fungible TotalSupply (r:0 w:1)46	fn create_item() -> Weight {47		(12_069_000 as Weight)48			.saturating_add(T::DbWeight::get().reads(1 as Weight))49			.saturating_add(T::DbWeight::get().writes(2 as Weight))50	}51	// Storage: Fungible TotalSupply (r:1 w:1)52	// Storage: Fungible Balance (r:1 w:1)53	fn burn_item() -> Weight {54		(14_096_000 as Weight)55			.saturating_add(T::DbWeight::get().reads(2 as Weight))56			.saturating_add(T::DbWeight::get().writes(2 as Weight))57	}58	// Storage: Fungible Balance (r:2 w:2)59	fn transfer() -> Weight {60		(15_436_000 as Weight)61			.saturating_add(T::DbWeight::get().reads(2 as Weight))62			.saturating_add(T::DbWeight::get().writes(2 as Weight))63	}64	// Storage: Fungible Balance (r:1 w:0)65	// Storage: Fungible Allowance (r:0 w:1)66	fn approve() -> Weight {67		(12_867_000 as Weight)68			.saturating_add(T::DbWeight::get().reads(1 as Weight))69			.saturating_add(T::DbWeight::get().writes(1 as Weight))70	}71	// Storage: Fungible Allowance (r:1 w:1)72	// Storage: Fungible Balance (r:2 w:2)73	fn transfer_from() -> Weight {74		(21_462_000 as Weight)75			.saturating_add(T::DbWeight::get().reads(3 as Weight))76			.saturating_add(T::DbWeight::get().writes(3 as Weight))77	}78	// Storage: Fungible Allowance (r:1 w:1)79	// Storage: Fungible TotalSupply (r:1 w:1)80	// Storage: Fungible Balance (r:1 w:1)81	fn burn_from() -> Weight {82		(55_874_000 as Weight)83			.saturating_add(T::DbWeight::get().reads(3 as Weight))84			.saturating_add(T::DbWeight::get().writes(3 as Weight))85	}86}8788// For backwards compatibility and tests89impl WeightInfo for () {90	// Storage: Fungible Balance (r:1 w:1)91	// Storage: Fungible TotalSupply (r:0 w:1)92	fn create_item() -> Weight {93		(12_069_000 as Weight)94			.saturating_add(RocksDbWeight::get().reads(1 as Weight))95			.saturating_add(RocksDbWeight::get().writes(2 as Weight))96	}97	// Storage: Fungible TotalSupply (r:1 w:1)98	// Storage: Fungible Balance (r:1 w:1)99	fn burn_item() -> Weight {100		(14_096_000 as Weight)101			.saturating_add(RocksDbWeight::get().reads(2 as Weight))102			.saturating_add(RocksDbWeight::get().writes(2 as Weight))103	}104	// Storage: Fungible Balance (r:2 w:2)105	fn transfer() -> Weight {106		(15_436_000 as Weight)107			.saturating_add(RocksDbWeight::get().reads(2 as Weight))108			.saturating_add(RocksDbWeight::get().writes(2 as Weight))109	}110	// Storage: Fungible Balance (r:1 w:0)111	// Storage: Fungible Allowance (r:0 w:1)112	fn approve() -> Weight {113		(12_867_000 as Weight)114			.saturating_add(RocksDbWeight::get().reads(1 as Weight))115			.saturating_add(RocksDbWeight::get().writes(1 as Weight))116	}117	// Storage: Fungible Allowance (r:1 w:1)118	// Storage: Fungible Balance (r:2 w:2)119	fn transfer_from() -> Weight {120		(21_462_000 as Weight)121			.saturating_add(RocksDbWeight::get().reads(3 as Weight))122			.saturating_add(RocksDbWeight::get().writes(3 as Weight))123	}124	// Storage: Fungible Allowance (r:1 w:1)125	// Storage: Fungible TotalSupply (r:1 w:1)126	// Storage: Fungible Balance (r:1 w:1)127	fn burn_from() -> Weight {128		(55_874_000 as Weight)129			.saturating_add(RocksDbWeight::get().reads(3 as Weight))130			.saturating_add(RocksDbWeight::get().writes(3 as Weight))131	}132}
modifiedpallets/nonfungible/src/benchmarking.rsdiffbeforeafterboth
--- a/pallets/nonfungible/src/benchmarking.rs
+++ b/pallets/nonfungible/src/benchmarking.rs
@@ -89,6 +89,15 @@
 		<Pallet<T>>::set_allowance(&collection, &sender, item, Some(&spender))?;
 	}: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item)?}
 
+	burn_from {
+		bench_init!{
+			owner: sub; collection: collection(owner);
+			owner: cross_from_sub; sender: cross_sub; burner: cross_sub;
+		};
+		let item = create_max_item(&collection, &owner, sender.clone())?;
+		<Pallet<T>>::set_allowance(&collection, &sender, item, Some(&burner))?;
+	}: {<Pallet<T>>::burn_from(&collection, &burner, &sender, item)?}
+
 	set_variable_metadata {
 		let b in 0..CUSTOM_DATA_LIMIT;
 		bench_init!{
modifiedpallets/nonfungible/src/common.rsdiffbeforeafterboth
--- a/pallets/nonfungible/src/common.rs
+++ b/pallets/nonfungible/src/common.rs
@@ -38,7 +38,7 @@
 	}
 
 	fn burn_from() -> Weight {
-		0
+		<SelfWeightOf<T>>::burn_from()
 	}
 
 	fn set_variable_metadata(bytes: u32) -> Weight {
modifiedpallets/nonfungible/src/weights.rsdiffbeforeafterboth
--- a/pallets/nonfungible/src/weights.rs
+++ b/pallets/nonfungible/src/weights.rs
@@ -98,6 +98,15 @@
 			.saturating_add(T::DbWeight::get().reads(4 as Weight))
 			.saturating_add(T::DbWeight::get().writes(6 as Weight))
 	}
+	// Storage: Nonfungible Allowance (r:1 w:1)
+	// Storage: Nonfungible TokenData (r:1 w:1)
+	// Storage: Nonfungible TokensBurnt (r:1 w:1)
+	// Storage: Nonfungible Owned (r:0 w:1)
+	fn burn_from() -> Weight {
+		(53_429_000 as Weight)
+			.saturating_add(T::DbWeight::get().reads(3 as Weight))
+			.saturating_add(T::DbWeight::get().writes(4 as Weight))
+	}
 	// Storage: Nonfungible TokenData (r:1 w:1)
 	fn set_variable_metadata(_b: u32, ) -> Weight {
 		(6_380_000 as Weight)
@@ -163,6 +172,15 @@
 			.saturating_add(RocksDbWeight::get().reads(4 as Weight))
 			.saturating_add(RocksDbWeight::get().writes(6 as Weight))
 	}
+	// Storage: Nonfungible Allowance (r:1 w:1)
+	// Storage: Nonfungible TokenData (r:1 w:1)
+	// Storage: Nonfungible TokensBurnt (r:1 w:1)
+	// Storage: Nonfungible Owned (r:0 w:1)
+	fn burn_from() -> Weight {
+		(53_429_000 as Weight)
+			.saturating_add(RocksDbWeight::get().reads(3 as Weight))
+			.saturating_add(RocksDbWeight::get().writes(4 as Weight))
+	}
 	// Storage: Nonfungible TokenData (r:1 w:1)
 	fn set_variable_metadata(_b: u32, ) -> Weight {
 		(6_380_000 as Weight)
modifiedpallets/refungible/src/benchmarking.rsdiffbeforeafterboth
--- a/pallets/refungible/src/benchmarking.rs
+++ b/pallets/refungible/src/benchmarking.rs
@@ -149,6 +149,16 @@
 		<Pallet<T>>::set_allowance(&collection, &sender, &spender, item, 200)?;
 	}: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item, 200)?}
 
+	// Both source account and token is destroyed
+	burn_from {
+		bench_init!{
+			owner: sub; collection: collection(owner);
+			owner: cross_from_sub; sender: cross_sub; burner: cross_sub;
+		};
+		let item = create_max_item(&collection, &owner, [(sender.clone(), 200)])?;
+		<Pallet<T>>::set_allowance(&collection, &sender, &burner, item, 200)?;
+	}: {<Pallet<T>>::burn_from(&collection, &burner, &sender, item, 200)?}
+
 	set_variable_metadata {
 		let b in 0..CUSTOM_DATA_LIMIT;
 		bench_init!{
modifiedpallets/refungible/src/weights.rsdiffbeforeafterboth
--- a/pallets/refungible/src/weights.rs
+++ b/pallets/refungible/src/weights.rs
@@ -166,6 +166,18 @@
 			.saturating_add(T::DbWeight::get().reads(5 as Weight))
 			.saturating_add(T::DbWeight::get().writes(7 as Weight))
 	}
+	// Storage: Refungible Allowance (r:1 w:1)
+	// Storage: Refungible TotalSupply (r:1 w:1)
+	// Storage: Refungible Balance (r:1 w:1)
+	// Storage: Refungible AccountBalance (r:1 w:1)
+	// Storage: Refungible TokensBurnt (r:1 w:1)
+	// Storage: Refungible TokenData (r:0 w:1)
+	// Storage: Refungible Owned (r:0 w:1)
+	fn burn_from() -> Weight {
+		(60_903_000 as Weight)
+			.saturating_add(T::DbWeight::get().reads(5 as Weight))
+			.saturating_add(T::DbWeight::get().writes(7 as Weight))
+	}
 	// Storage: Refungible TokenData (r:1 w:1)
 	fn set_variable_metadata(_b: u32, ) -> Weight {
 		(6_801_000 as Weight)
@@ -292,6 +304,18 @@
 			.saturating_add(RocksDbWeight::get().reads(5 as Weight))
 			.saturating_add(RocksDbWeight::get().writes(7 as Weight))
 	}
+	// Storage: Refungible Allowance (r:1 w:1)
+	// Storage: Refungible TotalSupply (r:1 w:1)
+	// Storage: Refungible Balance (r:1 w:1)
+	// Storage: Refungible AccountBalance (r:1 w:1)
+	// Storage: Refungible TokensBurnt (r:1 w:1)
+	// Storage: Refungible TokenData (r:0 w:1)
+	// Storage: Refungible Owned (r:0 w:1)
+	fn burn_from() -> Weight {
+		(60_903_000 as Weight)
+			.saturating_add(RocksDbWeight::get().reads(5 as Weight))
+			.saturating_add(RocksDbWeight::get().writes(7 as Weight))
+	}
 	// Storage: Refungible TokenData (r:1 w:1)
 	fn set_variable_metadata(_b: u32, ) -> Weight {
 		(6_801_000 as Weight)
modifiedpallets/scheduler/src/benchmarking.rsdiffbeforeafterboth
--- a/pallets/scheduler/src/benchmarking.rs
+++ b/pallets/scheduler/src/benchmarking.rs
@@ -33,7 +33,7 @@
 // Add `n` named items to the schedule
 fn fill_schedule<T: Config>(when: T::BlockNumber, n: u32) -> Result<(), &'static str> {
 	// Essentially a no-op call.
-	let call = frame_system::Call::set_storage(vec![]);
+	let call = frame_system::Call::set_storage { items: vec![] };
 	for i in 0..n {
 		// Named schedule is strictly heavier than anonymous
 		Scheduler::<T>::do_schedule_named(
@@ -61,7 +61,7 @@
 		let periodic = Some((T::BlockNumber::one(), 100));
 		let priority = 0;
 		// Essentially a no-op call.
-		let call = Box::new(frame_system::Call::set_storage(vec![]).into());
+		let call = Box::new(frame_system::Call::set_storage { items: vec![] }.into());
 
 		fill_schedule::<T>(when, s)?;
 	}: _(RawOrigin::Root, when, periodic, priority, call)
@@ -98,7 +98,7 @@
 		let periodic = Some((T::BlockNumber::one(), 100));
 		let priority = 0;
 		// Essentially a no-op call.
-		let call = Box::new(frame_system::Call::set_storage(vec![]).into());
+		let call = Box::new(frame_system::Call::set_storage { items: vec![] }.into());
 
 		fill_schedule::<T>(when, s)?;
 	}: _(RawOrigin::Root, id, when, periodic, priority, call)
modifiedruntime/Cargo.tomldiffbeforeafterboth
--- a/runtime/Cargo.toml
+++ b/runtime/Cargo.toml
@@ -23,7 +23,9 @@
     'frame-support/runtime-benchmarks',
     'frame-system-benchmarking',
     'frame-system/runtime-benchmarks',
+    'pallet-ethereum/runtime-benchmarks',
     'pallet-evm-migration/runtime-benchmarks',
+    'pallet-evm-coder-substrate/runtime-benchmarks',
     'pallet-balances/runtime-benchmarks',
     'pallet-timestamp/runtime-benchmarks',
     'pallet-common/runtime-benchmarks',
modifiedruntime/src/lib.rsdiffbeforeafterboth
--- a/runtime/src/lib.rs
+++ b/runtime/src/lib.rs
@@ -1327,6 +1327,7 @@
 			list_benchmark!(list, extra, pallet_fungible, Fungible);
 			list_benchmark!(list, extra, pallet_refungible, Refungible);
 			list_benchmark!(list, extra, pallet_nonfungible, Nonfungible);
+			// list_benchmark!(list, extra, pallet_evm_coder_substrate, EvmCoderSubstrate);
 
 			let storage_info = AllPalletsWithSystem::storage_info();
 
@@ -1360,6 +1361,7 @@
 			add_benchmark!(params, batches, pallet_fungible, Fungible);
 			add_benchmark!(params, batches, pallet_refungible, Refungible);
 			add_benchmark!(params, batches, pallet_nonfungible, Nonfungible);
+			// add_benchmark!(params, batches, pallet_evm_coder_substrate, EvmCoderSubstrate);
 
 			if batches.is_empty() { return Err("Benchmark not found for this pallet.".into()) }
 			Ok(batches)