difftreelog
fix small fixes
in: master
7 files changed
pallets/common/src/erc.rsdiffbeforeafterboth--- a/pallets/common/src/erc.rs
+++ b/pallets/common/src/erc.rs
@@ -179,15 +179,19 @@
///
/// @return Tuble with sponsor address and his substrate mirror. If there is no confirmed sponsor error "Contract has no sponsor" throw.
fn get_collection_sponsor(&self) -> Result<(address, uint256)> {
- let sponsor = match self.collection.sponsorship {
- SponsorshipState::Disabled | SponsorshipState::Unconfirmed(_) => {
- return Ok(Default::default())
- }
- SponsorshipState::Confirmed(ref sponsor) => sponsor,
+ let sponsor = match self.collection.sponsorship.sponsor() {
+ Some(sponsor) => sponsor,
+ None => return Ok(Default::default()),
};
let sponsor = T::CrossAccountId::from_sub(sponsor.clone());
- let sponsor_sub = convert_cross_account_to_uint256::<T>(&sponsor);
- Ok((*sponsor.as_eth(), sponsor_sub))
+ let result: (address, uint256) = if sponsor.is_canonical_substrate() {
+ let sponsor = convert_cross_account_to_uint256::<T>(&sponsor);
+ (Default::default(), sponsor)
+ } else {
+ let sponsor = *sponsor.as_eth();
+ (sponsor, Default::default())
+ };
+ Ok(result)
}
/// Set limits for the collection.
pallets/common/src/eth.rsdiffbeforeafterboth--- a/pallets/common/src/eth.rs
+++ b/pallets/common/src/eth.rs
@@ -64,7 +64,7 @@
where
T::AccountId: From<[u8; 32]>,
{
- let mut new_admin_arr: [u8; 32] = Default::default();
+ let mut new_admin_arr = [0_u8; 32];
from.to_big_endian(&mut new_admin_arr);
let account_id = T::AccountId::from(new_admin_arr);
T::CrossAccountId::from_sub(account_id)
pallets/fungible/CHANGELOG.mddiffbeforeafterboth--- a/pallets/fungible/CHANGELOG.md
+++ b/pallets/fungible/CHANGELOG.md
@@ -5,7 +5,7 @@
## [v0.1.4] - 2022-08-24
### Change
- - Add bound `AsRef<[u8]>` to `T::CrossAccountId`.
+ - Add bound `AsRef<[u8; 32]>` to `T::CrossAccountId`.
<!-- bureaucrate goes here -->
## [v0.1.3] 2022-08-16
pallets/nonfungible/CHANGELOG.mddiffbeforeafterboth5## [v0.1.5] - 2022-08-245## [v0.1.5] - 2022-08-24667### Change7### Change8 - Add bound `AsRef<[u8]>` to `T::CrossAccountId`.8 - Add bound `AsRef<[u8; 32]>` to `T::CrossAccountId`.9910<!-- bureaucrate goes here -->10<!-- bureaucrate goes here -->11## [v0.1.4] 2022-08-1611## [v0.1.4] 2022-08-16pallets/refungible/CHANGELOG.mddiffbeforeafterboth--- a/pallets/refungible/CHANGELOG.md
+++ b/pallets/refungible/CHANGELOG.md
@@ -5,7 +5,7 @@
## [v0.2.4] - 2022-08-24
### Change
- - Add bound `AsRef<[u8]>` to `T::CrossAccountId`.
+ - Add bound `AsRef<[u8; 32]>` to `T::CrossAccountId`.
<!-- bureaucrate goes here -->
## [v0.2.3] 2022-08-16
tests/src/eth/collectionSponsoring.test.tsdiffbeforeafterboth--- a/tests/src/eth/collectionSponsoring.test.ts
+++ b/tests/src/eth/collectionSponsoring.test.ts
@@ -1,4 +1,4 @@
-import {addToAllowListExpectSuccess, confirmSponsorshipExpectSuccess, createCollectionExpectSuccess, enablePublicMintingExpectSuccess, getDetailedCollectionInfo, setCollectionSponsorExpectSuccess} from '../util/helpers';
+import {addToAllowListExpectSuccess, bigIntToSub, confirmSponsorshipExpectSuccess, createCollectionExpectSuccess, enablePublicMintingExpectSuccess, getDetailedCollectionInfo, setCollectionSponsorExpectSuccess} from '../util/helpers';
import {itWeb3, createEthAccount, collectionIdToAddress, GAS_ARGS, normalizeEvents, createEthAccountWithBalance, evmCollectionHelpers, getCollectionAddressFromResult, evmCollection, ethBalanceViaSub, subToEth} from './util/helpers';
import nonFungibleAbi from './nonFungibleAbi.json';
import {expect} from 'chai';
@@ -57,7 +57,7 @@
expect(await collectionEvm.methods.hasCollectionPendingSponsor().call({from: owner})).to.be.false;
const sponsorTuple = await collectionEvm.methods.getCollectionSponsor().call({from: owner});
- expect(sponsorTuple.field_0).to.be.eq(subToEth(sponsor.address));
+ expect(bigIntToSub(api, BigInt(sponsorTuple[1]))).to.be.eq(sponsor.address);
});
itWeb3('Remove sponsor', async ({api, web3, privateKeyWrapper}) => {
tests/src/util/helpers.tsdiffbeforeafterboth--- a/tests/src/util/helpers.ts
+++ b/tests/src/util/helpers.ts
@@ -99,6 +99,10 @@
}
}
+export function bigIntToSub(api: ApiPromise, number: bigint) {
+ return api.registry.createType('AccountId', '0x' + number.toString(16).padStart(64, '0')).toJSON();
+}
+
export function normalizeAccountId(input: string | AccountId | CrossAccountId | IKeyringPair): CrossAccountId {
if (typeof input === 'string') {
if (input.length >= 47) {