git.delta.rocks / unique-network / refs/commits / d8de1b3c39fb

difftreelog

fix bulk properties set

Daniel Shiposha2023-01-12parent: #46515fa.patch.diff
in: master

6 files changed

modifiedpallets/common/src/erc.rsdiffbeforeafterboth
--- a/pallets/common/src/erc.rs
+++ b/pallets/common/src/erc.rs
@@ -125,7 +125,7 @@
 			.map(eth::Property::try_into)
 			.collect::<Result<Vec<_>>>()?;
 
-		<Pallet<T>>::set_collection_properties(self, &caller, properties)
+		<Pallet<T>>::set_collection_properties(self, &caller, properties.into_iter())
 			.map_err(dispatch_to_evm::<T>)
 	}
 
@@ -158,7 +158,8 @@
 			})
 			.collect::<Result<Vec<_>>>()?;
 
-		<Pallet<T>>::delete_collection_properties(self, &caller, keys).map_err(dispatch_to_evm::<T>)
+		<Pallet<T>>::delete_collection_properties(self, &caller, keys.into_iter())
+			.map_err(dispatch_to_evm::<T>)
 	}
 
 	/// Get collection property.
modifiedpallets/common/src/lib.rsdiffbeforeafterboth
--- a/pallets/common/src/lib.rs
+++ b/pallets/common/src/lib.rs
@@ -1198,6 +1198,51 @@
 		Ok(())
 	}
 
+	fn modify_collection_properties(
+		collection: &CollectionHandle<T>,
+		sender: &T::CrossAccountId,
+		properties_updates: impl Iterator<Item = (PropertyKey, Option<PropertyValue>)>,
+	) -> DispatchResult {
+		collection.check_is_owner_or_admin(sender)?;
+
+		let mut stored_properties = <CollectionProperties<T>>::get(collection.id);
+
+		for (key, value) in properties_updates {
+			match value {
+				Some(value) => {
+					stored_properties
+						.try_set(key.clone(), value)
+						.map_err(<Error<T>>::from)?;
+
+					Self::deposit_event(Event::CollectionPropertySet(collection.id, key));
+					<PalletEvm<T>>::deposit_log(
+						erc::CollectionHelpersEvents::CollectionChanged {
+							collection_id: eth::collection_id_to_address(collection.id),
+						}
+						.to_log(T::ContractAddress::get()),
+					);
+				}
+				None => {
+					stored_properties.remove(&key).map_err(<Error<T>>::from)?;
+
+					Self::deposit_event(Event::CollectionPropertyDeleted(collection.id, key));
+					<PalletEvm<T>>::deposit_log(
+						erc::CollectionHelpersEvents::CollectionChanged {
+							collection_id: eth::collection_id_to_address(collection.id),
+						}
+						.to_log(T::ContractAddress::get()),
+					);
+				}
+			}
+		}
+
+		<CollectionProperties<T>>::mutate(collection.id, |properties| {
+			*properties = stored_properties;
+		});
+
+		Ok(())
+	}
+
 	/// Set collection property.
 	///
 	/// * `collection` - Collection handler.
@@ -1208,23 +1253,7 @@
 		sender: &T::CrossAccountId,
 		property: Property,
 	) -> DispatchResult {
-		collection.check_is_owner_or_admin(sender)?;
-
-		CollectionProperties::<T>::try_mutate(collection.id, |properties| {
-			let property = property.clone();
-			properties.try_set(property.key, property.value)
-		})
-		.map_err(<Error<T>>::from)?;
-
-		Self::deposit_event(Event::CollectionPropertySet(collection.id, property.key));
-		<PalletEvm<T>>::deposit_log(
-			erc::CollectionHelpersEvents::CollectionChanged {
-				collection_id: eth::collection_id_to_address(collection.id),
-			}
-			.to_log(T::ContractAddress::get()),
-		);
-
-		Ok(())
+		Self::set_collection_properties(collection, sender, [property].into_iter())
 	}
 
 	/// Set a scoped collection property, where the scope is a special prefix
@@ -1274,13 +1303,13 @@
 	pub fn set_collection_properties(
 		collection: &CollectionHandle<T>,
 		sender: &T::CrossAccountId,
-		properties: Vec<Property>,
+		properties: impl Iterator<Item = Property>,
 	) -> DispatchResult {
-		for property in properties {
-			Self::set_collection_property(collection, sender, property)?;
-		}
-
-		Ok(())
+		Self::modify_collection_properties(
+			collection,
+			sender,
+			properties.map(|property| (property.key, Some(property.value))),
+		)
 	}
 
 	/// Delete collection property.
@@ -1293,25 +1322,7 @@
 		sender: &T::CrossAccountId,
 		property_key: PropertyKey,
 	) -> DispatchResult {
-		collection.check_is_owner_or_admin(sender)?;
-
-		CollectionProperties::<T>::try_mutate(collection.id, |properties| {
-			properties.remove(&property_key)
-		})
-		.map_err(<Error<T>>::from)?;
-
-		Self::deposit_event(Event::CollectionPropertyDeleted(
-			collection.id,
-			property_key,
-		));
-		<PalletEvm<T>>::deposit_log(
-			erc::CollectionHelpersEvents::CollectionChanged {
-				collection_id: eth::collection_id_to_address(collection.id),
-			}
-			.to_log(T::ContractAddress::get()),
-		);
-
-		Ok(())
+		Self::delete_collection_properties(collection, sender, [property_key].into_iter())
 	}
 
 	/// Delete collection properties.
@@ -1323,13 +1334,9 @@
 	pub fn delete_collection_properties(
 		collection: &CollectionHandle<T>,
 		sender: &T::CrossAccountId,
-		property_keys: Vec<PropertyKey>,
+		property_keys: impl Iterator<Item = PropertyKey>,
 	) -> DispatchResult {
-		for key in property_keys {
-			Self::delete_collection_property(collection, sender, key)?;
-		}
-
-		Ok(())
+		Self::modify_collection_properties(collection, sender, property_keys.map(|key| (key, None)))
 	}
 
 	/// Set collection propetry permission without any checks.
modifiedpallets/fungible/src/lib.rsdiffbeforeafterboth
--- a/pallets/fungible/src/lib.rs
+++ b/pallets/fungible/src/lib.rs
@@ -266,7 +266,7 @@
 		sender: &T::CrossAccountId,
 		properties: Vec<Property>,
 	) -> DispatchResult {
-		<PalletCommon<T>>::set_collection_properties(collection, sender, properties)
+		<PalletCommon<T>>::set_collection_properties(collection, sender, properties.into_iter())
 	}
 
 	/// Delete properties of the collection, associated with the provided keys.
@@ -275,7 +275,11 @@
 		sender: &T::CrossAccountId,
 		property_keys: Vec<PropertyKey>,
 	) -> DispatchResult {
-		<PalletCommon<T>>::delete_collection_properties(collection, sender, property_keys)
+		<PalletCommon<T>>::delete_collection_properties(
+			collection,
+			sender,
+			property_keys.into_iter(),
+		)
 	}
 
 	/// Checks if collection has tokens. Return `true` if it has.
modifiedpallets/nonfungible/src/lib.rsdiffbeforeafterboth
after · pallets/nonfungible/src/lib.rs
1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617//! # Nonfungible Pallet18//!19//! The Nonfungible pallet provides functionality for handling nonfungible collections and tokens.20//!21//! - [`Config`]22//! - [`NonfungibleHandle`]23//! - [`Pallet`]24//! - [`CommonWeights`](common::CommonWeights)25//!26//! ## Overview27//!28//! The Nonfungible pallet provides functions for:29//!30//! - NFT collection creation and removal31//! - Minting and burning of NFT tokens32//! - Retrieving account balances33//! - Transfering NFT tokens34//! - Setting and checking allowance for NFT tokens35//! - Setting properties and permissions for NFT collections and tokens36//! - Nesting and unnesting tokens37//!38//! ### Terminology39//!40//! - **NFT token:** Non fungible token.41//!42//! - **NFT Collection:** A collection of NFT tokens. All NFT tokens are part of a collection.43//!   Each collection can define it's own properties, properties for it's tokens and set of permissions.44//!45//! - **Balance:** Number of NFT tokens owned by an account46//!47//! - **Allowance:** NFT tokens owned by one account that another account is allowed to make operations on48//!49//! - **Burning:** The process of “deleting” a token from a collection and from50//!   an account balance of the owner.51//!52//! - **Nesting:** Setting up parent-child relationship between tokens. Nested tokens are inhereting53//!   owner from their parent. There could be multiple levels of nesting. Token couldn't be nested in54//!   it's child token i.e. parent-child relationship graph shouldn't have cycles.55//!56//! - **Properties:** Key-Values pairs. Token properties are attached to a token. Collection properties are57//!   attached to a collection. Set of permissions could be defined for each property.58//!59//! ### Implementations60//!61//! The Nonfungible pallet provides implementations for the following traits. If these traits provide62//! the functionality that you need, then you can avoid coupling with the Nonfungible pallet.63//!64//! - [`CommonWeightInfo`](pallet_common::CommonWeightInfo): Functions for retrieval of transaction weight65//! - [`CommonCollectionOperations`](pallet_common::CommonCollectionOperations): Functions for dealing66//!   with collections67//!68//! ## Interface69//!70//! ### Dispatchable Functions71//!72//! - `init_collection` - Create NFT collection. NFT collection can be configured to allow or deny access for73//!   some accounts.74//! - `destroy_collection` - Destroy exising NFT collection. There should be no tokens in the collection.75//! - `burn` - Burn NFT token owned by account.76//! - `transfer` - Transfer NFT token. Transfers should be enabled for NFT collection.77//!   Nests the NFT token if it is sent to another token.78//! - `create_item` - Mint NFT token in collection. Sender should have permission to mint tokens.79//! - `set_allowance` - Set allowance for another account.80//! - `set_token_property` - Set token property value.81//! - `delete_token_property` - Remove property from the token.82//! - `set_collection_properties` - Set collection properties.83//! - `delete_collection_properties` - Remove properties from the collection.84//! - `set_property_permission` - Set collection property permission.85//! - `set_token_property_permissions` - Set token property permissions.86//!87//! ## Assumptions88//!89//! * To perform operations on tokens sender should be in collection's allow list if collection access mode is `AllowList`.9091#![cfg_attr(not(feature = "std"), no_std)]9293use erc::ERC721Events;94use evm_coder::ToLog;95use frame_support::{96	BoundedVec, ensure, fail, transactional,97	storage::with_transaction,98	pallet_prelude::DispatchResultWithPostInfo,99	pallet_prelude::Weight,100	dispatch::{PostDispatchInfo, Pays},101};102use up_data_structs::{103	AccessMode, CollectionId, CollectionFlags, CustomDataLimit, TokenId, CreateCollectionData,104	CreateNftExData, mapping::TokenAddressMapping, budget::Budget, Property, PropertyPermission,105	PropertyKey, PropertyValue, PropertyKeyPermission, Properties, PropertyScope, TrySetProperty,106	TokenChild, AuxPropertyValue, PropertiesPermissionMap,107};108use pallet_evm::{account::CrossAccountId, Pallet as PalletEvm};109use pallet_common::{110	Error as CommonError, Pallet as PalletCommon, Event as CommonEvent, CollectionHandle,111	eth::collection_id_to_address, erc::CollectionHelpersEvents,112};113use pallet_structure::{Pallet as PalletStructure, Error as StructureError};114use pallet_evm_coder_substrate::{SubstrateRecorder, WithRecorder};115use sp_core::{H160, Get};116use sp_runtime::{ArithmeticError, DispatchError, DispatchResult, TransactionOutcome};117use sp_std::{vec::Vec, vec, collections::btree_map::BTreeMap};118use core::ops::Deref;119use codec::{Encode, Decode, MaxEncodedLen};120use scale_info::TypeInfo;121122pub use pallet::*;123use weights::WeightInfo;124#[cfg(feature = "runtime-benchmarks")]125pub mod benchmarking;126pub mod common;127pub mod erc;128pub mod weights;129130pub type CreateItemData<T> = CreateNftExData<<T as pallet_evm::Config>::CrossAccountId>;131pub(crate) type SelfWeightOf<T> = <T as Config>::WeightInfo;132133/// Token data, stored independently from other data used to describe it134/// for the convenience of database access. Notably contains the owner account address.135#[struct_versioning::versioned(version = 2, upper)]136#[derive(Encode, Decode, TypeInfo, MaxEncodedLen)]137pub struct ItemData<CrossAccountId> {138	#[version(..2)]139	pub const_data: BoundedVec<u8, CustomDataLimit>,140141	#[version(..2)]142	pub variable_data: BoundedVec<u8, CustomDataLimit>,143144	pub owner: CrossAccountId,145}146147#[frame_support::pallet]148pub mod pallet {149	use super::*;150	use frame_support::{151		Blake2_128Concat, Twox64Concat, pallet_prelude::*, storage::Key, traits::StorageVersion,152	};153	use frame_system::pallet_prelude::*;154	use up_data_structs::{CollectionId, TokenId};155	use super::weights::WeightInfo;156157	#[pallet::error]158	pub enum Error<T> {159		/// Not Nonfungible item data used to mint in Nonfungible collection.160		NotNonfungibleDataUsedToMintFungibleCollectionToken,161		/// Used amount > 1 with NFT162		NonfungibleItemsHaveNoAmount,163		/// Unable to burn NFT with children164		CantBurnNftWithChildren,165	}166167	#[pallet::config]168	pub trait Config:169		frame_system::Config + pallet_common::Config + pallet_structure::Config + pallet_evm::Config170	{171		type WeightInfo: WeightInfo;172	}173174	const STORAGE_VERSION: StorageVersion = StorageVersion::new(1);175176	#[pallet::pallet]177	#[pallet::storage_version(STORAGE_VERSION)]178	#[pallet::generate_store(pub(super) trait Store)]179	pub struct Pallet<T>(_);180181	/// Total amount of minted tokens in a collection.182	#[pallet::storage]183	pub type TokensMinted<T: Config> =184		StorageMap<Hasher = Twox64Concat, Key = CollectionId, Value = u32, QueryKind = ValueQuery>;185186	/// Amount of burnt tokens in a collection.187	#[pallet::storage]188	pub type TokensBurnt<T: Config> =189		StorageMap<Hasher = Twox64Concat, Key = CollectionId, Value = u32, QueryKind = ValueQuery>;190191	/// Token data, used to partially describe a token.192	#[pallet::storage]193	pub type TokenData<T: Config> = StorageNMap<194		Key = (Key<Twox64Concat, CollectionId>, Key<Twox64Concat, TokenId>),195		Value = ItemData<T::CrossAccountId>,196		QueryKind = OptionQuery,197	>;198199	/// Map of key-value pairs, describing the metadata of a token.200	#[pallet::storage]201	#[pallet::getter(fn token_properties)]202	pub type TokenProperties<T: Config> = StorageNMap<203		Key = (Key<Twox64Concat, CollectionId>, Key<Twox64Concat, TokenId>),204		Value = Properties,205		QueryKind = ValueQuery,206		OnEmpty = up_data_structs::TokenProperties,207	>;208209	/// Custom data of a token that is serialized to bytes,210	/// primarily reserved for on-chain operations,211	/// normally obscured from the external users.212	///213	/// Auxiliary properties are slightly different from214	/// usual [`TokenProperties`] due to an unlimited number215	/// and separately stored and written-to key-value pairs.216	///217	/// Currently used to store RMRK data.218	#[pallet::storage]219	#[pallet::getter(fn token_aux_property)]220	pub type TokenAuxProperties<T: Config> = StorageNMap<221		Key = (222			Key<Twox64Concat, CollectionId>,223			Key<Twox64Concat, TokenId>,224			Key<Twox64Concat, PropertyScope>,225			Key<Twox64Concat, PropertyKey>,226		),227		Value = AuxPropertyValue,228		QueryKind = OptionQuery,229	>;230231	/// Used to enumerate tokens owned by account.232	#[pallet::storage]233	pub type Owned<T: Config> = StorageNMap<234		Key = (235			Key<Twox64Concat, CollectionId>,236			Key<Blake2_128Concat, T::CrossAccountId>,237			Key<Twox64Concat, TokenId>,238		),239		Value = bool,240		QueryKind = ValueQuery,241	>;242243	/// Used to enumerate token's children.244	#[pallet::storage]245	#[pallet::getter(fn token_children)]246	pub type TokenChildren<T: Config> = StorageNMap<247		Key = (248			Key<Twox64Concat, CollectionId>,249			Key<Twox64Concat, TokenId>,250			Key<Twox64Concat, (CollectionId, TokenId)>,251		),252		Value = bool,253		QueryKind = ValueQuery,254	>;255256	/// Amount of tokens owned by an account in a collection.257	#[pallet::storage]258	pub type AccountBalance<T: Config> = StorageNMap<259		Key = (260			Key<Twox64Concat, CollectionId>,261			Key<Blake2_128Concat, T::CrossAccountId>,262		),263		Value = u32,264		QueryKind = ValueQuery,265	>;266267	/// Allowance set by a token owner for another user to perform one of certain transactions on a token.268	#[pallet::storage]269	pub type Allowance<T: Config> = StorageNMap<270		Key = (Key<Twox64Concat, CollectionId>, Key<Twox64Concat, TokenId>),271		Value = T::CrossAccountId,272		QueryKind = OptionQuery,273	>;274275	/// Operator set by a wallet owner that could perform certain transactions on all tokens in the wallet.276	#[pallet::storage]277	pub type CollectionAllowance<T: Config> = StorageNMap<278		Key = (279			Key<Twox64Concat, CollectionId>,280			Key<Blake2_128Concat, T::CrossAccountId>,281			Key<Blake2_128Concat, T::CrossAccountId>,282		),283		Value = bool,284		QueryKind = ValueQuery,285	>;286287	/// Upgrade from the old schema to properties.288	#[pallet::hooks]289	impl<T: Config> Hooks<BlockNumberFor<T>> for Pallet<T> {290		fn on_runtime_upgrade() -> Weight {291			StorageVersion::new(1).put::<Pallet<T>>();292293			Weight::zero()294		}295	}296}297298pub struct NonfungibleHandle<T: Config>(pallet_common::CollectionHandle<T>);299impl<T: Config> NonfungibleHandle<T> {300	pub fn cast(inner: pallet_common::CollectionHandle<T>) -> Self {301		Self(inner)302	}303	pub fn into_inner(self) -> pallet_common::CollectionHandle<T> {304		self.0305	}306	pub fn common_mut(&mut self) -> &mut pallet_common::CollectionHandle<T> {307		&mut self.0308	}309}310311impl<T: Config> WithRecorder<T> for NonfungibleHandle<T> {312	fn recorder(&self) -> &SubstrateRecorder<T> {313		self.0.recorder()314	}315	fn into_recorder(self) -> SubstrateRecorder<T> {316		self.0.into_recorder()317	}318}319impl<T: Config> Deref for NonfungibleHandle<T> {320	type Target = pallet_common::CollectionHandle<T>;321322	fn deref(&self) -> &Self::Target {323		&self.0324	}325}326327impl<T: Config> Pallet<T> {328	/// Get number of NFT tokens in collection.329	pub fn total_supply(collection: &NonfungibleHandle<T>) -> u32 {330		<TokensMinted<T>>::get(collection.id) - <TokensBurnt<T>>::get(collection.id)331	}332333	/// Check that NFT token exists.334	///335	/// - `token`: Token ID.336	pub fn token_exists(collection: &NonfungibleHandle<T>, token: TokenId) -> bool {337		<TokenData<T>>::contains_key((collection.id, token))338	}339340	/// Set the token property with the scope.341	///342	/// - `property`: Contains key-value pair.343	pub fn set_scoped_token_property(344		collection_id: CollectionId,345		token_id: TokenId,346		scope: PropertyScope,347		property: Property,348	) -> DispatchResult {349		TokenProperties::<T>::try_mutate((collection_id, token_id), |properties| {350			properties.try_scoped_set(scope, property.key, property.value)351		})352		.map_err(<CommonError<T>>::from)?;353354		Ok(())355	}356357	/// Batch operation to set multiple properties with the same scope.358	pub fn set_scoped_token_properties(359		collection_id: CollectionId,360		token_id: TokenId,361		scope: PropertyScope,362		properties: impl Iterator<Item = Property>,363	) -> DispatchResult {364		TokenProperties::<T>::try_mutate((collection_id, token_id), |stored_properties| {365			stored_properties.try_scoped_set_from_iter(scope, properties)366		})367		.map_err(<CommonError<T>>::from)?;368369		Ok(())370	}371372	/// Add or edit auxiliary data for the property.373	///374	/// - `f`: function that adds or edits auxiliary data.375	pub fn try_mutate_token_aux_property<R, E>(376		collection_id: CollectionId,377		token_id: TokenId,378		scope: PropertyScope,379		key: PropertyKey,380		f: impl FnOnce(&mut Option<AuxPropertyValue>) -> Result<R, E>,381	) -> Result<R, E> {382		<TokenAuxProperties<T>>::try_mutate((collection_id, token_id, scope, key), f)383	}384385	/// Remove auxiliary data for the property.386	pub fn remove_token_aux_property(387		collection_id: CollectionId,388		token_id: TokenId,389		scope: PropertyScope,390		key: PropertyKey,391	) {392		<TokenAuxProperties<T>>::remove((collection_id, token_id, scope, key));393	}394395	/// Get all auxiliary data in a given scope.396	///397	/// Returns iterator over Property Key - Data pairs.398	pub fn iterate_token_aux_properties(399		collection_id: CollectionId,400		token_id: TokenId,401		scope: PropertyScope,402	) -> impl Iterator<Item = (PropertyKey, AuxPropertyValue)> {403		<TokenAuxProperties<T>>::iter_prefix((collection_id, token_id, scope))404	}405406	/// Get ID of the last minted token407	pub fn current_token_id(collection_id: CollectionId) -> TokenId {408		TokenId(<TokensMinted<T>>::get(collection_id))409	}410}411412// unchecked calls skips any permission checks413impl<T: Config> Pallet<T> {414	/// Create NFT collection415	///416	/// `init_collection` will take non-refundable deposit for collection creation.417	///418	/// - `data`: Contains settings for collection limits and permissions.419	pub fn init_collection(420		owner: T::CrossAccountId,421		payer: T::CrossAccountId,422		data: CreateCollectionData<T::AccountId>,423		flags: CollectionFlags,424	) -> Result<CollectionId, DispatchError> {425		<PalletCommon<T>>::init_collection(owner, payer, data, flags)426	}427428	/// Destroy NFT collection429	///430	/// `destroy_collection` will throw error if collection contains any tokens.431	/// Only owner can destroy collection.432	pub fn destroy_collection(433		collection: NonfungibleHandle<T>,434		sender: &T::CrossAccountId,435	) -> DispatchResult {436		let id = collection.id;437438		if Self::collection_has_tokens(id) {439			return Err(<CommonError<T>>::CantDestroyNotEmptyCollection.into());440		}441442		// =========443444		PalletCommon::destroy_collection(collection.0, sender)?;445446		let _ = <TokenData<T>>::clear_prefix((id,), u32::MAX, None);447		let _ = <TokenChildren<T>>::clear_prefix((id,), u32::MAX, None);448		let _ = <Owned<T>>::clear_prefix((id,), u32::MAX, None);449		<TokensMinted<T>>::remove(id);450		<TokensBurnt<T>>::remove(id);451		let _ = <Allowance<T>>::clear_prefix((id,), u32::MAX, None);452		let _ = <AccountBalance<T>>::clear_prefix((id,), u32::MAX, None);453		let _ = <CollectionAllowance<T>>::clear_prefix((id,), u32::MAX, None);454		Ok(())455	}456457	/// Burn NFT token458	///459	/// `burn` removes `token` from the `collection`, from it's owner and from the parent token460	/// if the token is nested.461	/// Only the owner can `burn` the token. The `token` shouldn't have any nested tokens.462	/// Also removes all corresponding properties and auxiliary properties.463	///464	/// - `token`: Token that should be burned465	/// - `collection`: Collection that contains the token466	pub fn burn(467		collection: &NonfungibleHandle<T>,468		sender: &T::CrossAccountId,469		token: TokenId,470	) -> DispatchResult {471		let token_data =472			<TokenData<T>>::get((collection.id, token)).ok_or(<CommonError<T>>::TokenNotFound)?;473		ensure!(&token_data.owner == sender, <CommonError<T>>::NoPermission);474475		if collection.permissions.access() == AccessMode::AllowList {476			collection.check_allowlist(sender)?;477		}478479		if Self::token_has_children(collection.id, token) {480			return Err(<Error<T>>::CantBurnNftWithChildren.into());481		}482483		let burnt = <TokensBurnt<T>>::get(collection.id)484			.checked_add(1)485			.ok_or(ArithmeticError::Overflow)?;486487		let balance = <AccountBalance<T>>::get((collection.id, token_data.owner.clone()))488			.checked_sub(1)489			.ok_or(ArithmeticError::Overflow)?;490491		// =========492493		if balance == 0 {494			<AccountBalance<T>>::remove((collection.id, token_data.owner.clone()));495		} else {496			<AccountBalance<T>>::insert((collection.id, token_data.owner.clone()), balance);497		}498499		<PalletStructure<T>>::unnest_if_nested(&token_data.owner, collection.id, token);500501		<Owned<T>>::remove((collection.id, &token_data.owner, token));502		<TokensBurnt<T>>::insert(collection.id, burnt);503		<TokenData<T>>::remove((collection.id, token));504		<TokenProperties<T>>::remove((collection.id, token));505		let _ = <TokenAuxProperties<T>>::clear_prefix((collection.id, token), u32::MAX, None);506		let old_spender = <Allowance<T>>::take((collection.id, token));507508		if let Some(old_spender) = old_spender {509			<PalletCommon<T>>::deposit_event(CommonEvent::Approved(510				collection.id,511				token,512				token_data.owner.clone(),513				old_spender,514				0,515			));516		}517518		<PalletEvm<T>>::deposit_log(519			ERC721Events::Transfer {520				from: *token_data.owner.as_eth(),521				to: H160::default(),522				token_id: token.into(),523			}524			.to_log(collection_id_to_address(collection.id)),525		);526		<PalletCommon<T>>::deposit_event(CommonEvent::ItemDestroyed(527			collection.id,528			token,529			token_data.owner,530			1,531		));532		Ok(())533	}534535	/// Same as [`burn`] but burns all the tokens that are nested in the token first536	///537	/// - `self_budget`: Limit for searching children in depth.538	/// - `breadth_budget`: Limit of breadth of searching children.539	///540	/// [`burn`]: struct.Pallet.html#method.burn541	#[transactional]542	pub fn burn_recursively(543		collection: &NonfungibleHandle<T>,544		sender: &T::CrossAccountId,545		token: TokenId,546		self_budget: &dyn Budget,547		breadth_budget: &dyn Budget,548	) -> DispatchResultWithPostInfo {549		ensure!(self_budget.consume(), <StructureError<T>>::DepthLimit,);550551		let current_token_account =552			T::CrossTokenAddressMapping::token_to_address(collection.id, token);553554		let mut weight = Weight::zero();555556		// This method is transactional, if user in fact doesn't have permissions to remove token -557		// tokens removed here will be restored after rejected transaction558		for ((collection, token), _) in <TokenChildren<T>>::iter_prefix((collection.id, token)) {559			ensure!(breadth_budget.consume(), <StructureError<T>>::BreadthLimit,);560			let PostDispatchInfo { actual_weight, .. } =561				<PalletStructure<T>>::burn_item_recursively(562					current_token_account.clone(),563					collection,564					token,565					self_budget,566					breadth_budget,567				)?;568			if let Some(actual_weight) = actual_weight {569				weight = weight.saturating_add(actual_weight);570			}571		}572573		Self::burn(collection, sender, token)?;574		DispatchResultWithPostInfo::Ok(PostDispatchInfo {575			actual_weight: Some(weight + <SelfWeightOf<T>>::burn_item()),576			pays_fee: Pays::Yes,577		})578	}579580	/// Batch operation to add, edit or remove properties for the token581	///582	/// All affected properties should have mutable permission and sender should have583	/// permission to edit those properties.584	///585	/// - `nesting_budget`: Limit for searching parents in depth to check ownership.586	/// - `is_token_create`: Indicates that method is called during token initialization.587	///   Allows to bypass ownership check.588	#[transactional]589	fn modify_token_properties(590		collection: &NonfungibleHandle<T>,591		sender: &T::CrossAccountId,592		token_id: TokenId,593		properties_updates: impl Iterator<Item = (PropertyKey, Option<PropertyValue>)>,594		is_token_create: bool,595		nesting_budget: &dyn Budget,596	) -> DispatchResult {597		let mut collection_admin_status = None;598		let mut token_owner_result = None;599600		let mut is_collection_admin =601			|| *collection_admin_status.get_or_insert_with(|| collection.is_owner_or_admin(sender));602603		let mut is_token_owner = || {604			*token_owner_result.get_or_insert_with(|| -> Result<bool, DispatchError> {605				let is_owned = <PalletStructure<T>>::check_indirectly_owned(606					sender.clone(),607					collection.id,608					token_id,609					None,610					nesting_budget,611				)?;612613				Ok(is_owned)614			})615		};616617		let mut stored_properties = <TokenProperties<T>>::get((collection.id, token_id));618		let permissions = <PalletCommon<T>>::property_permissions(collection.id);619620		for (key, value) in properties_updates {621			let permission = permissions622				.get(&key)623				.cloned()624				.unwrap_or_else(PropertyPermission::none);625626			let is_property_exists = stored_properties.get(&key).is_some();627628			match permission {629				PropertyPermission { mutable: false, .. } if is_property_exists => {630					return Err(<CommonError<T>>::NoPermission.into());631				}632633				PropertyPermission {634					collection_admin,635					token_owner,636					..637				} => {638					//TODO: investigate threats during public minting.639					if is_token_create && (collection_admin || token_owner) && value.is_some() {640						// Pass641					} else if collection_admin && is_collection_admin() {642						// Pass643					} else if token_owner && is_token_owner()? {644						// Pass645					} else {646						fail!(<CommonError<T>>::NoPermission);647					}648				}649			}650651			match value {652				Some(value) => {653					stored_properties654						.try_set(key.clone(), value)655						.map_err(<CommonError<T>>::from)?;656657					<PalletCommon<T>>::deposit_event(CommonEvent::TokenPropertySet(658						collection.id,659						token_id,660						key,661					));662				}663				None => {664					stored_properties665						.remove(&key)666						.map_err(<CommonError<T>>::from)?;667668					<PalletCommon<T>>::deposit_event(CommonEvent::TokenPropertyDeleted(669						collection.id,670						token_id,671						key,672					));673				}674			}675676			<PalletEvm<T>>::deposit_log(677				CollectionHelpersEvents::TokenChanged {678					collection_id: collection_id_to_address(collection.id),679					token_id: token_id.into(),680				}681				.to_log(T::ContractAddress::get()),682			);683		}684685		<TokenProperties<T>>::mutate((collection.id, token_id), |properties| {686			*properties = stored_properties;687		});688689		Ok(())690	}691692	/// Batch operation to add or edit properties for the token693	///694	/// Same as [`modify_token_properties`] but doesn't allow to remove properties695	///696	/// [`modify_token_properties`]: struct.Pallet.html#method.modify_token_properties697	pub fn set_token_properties(698		collection: &NonfungibleHandle<T>,699		sender: &T::CrossAccountId,700		token_id: TokenId,701		properties: impl Iterator<Item = Property>,702		is_token_create: bool,703		nesting_budget: &dyn Budget,704	) -> DispatchResult {705		Self::modify_token_properties(706			collection,707			sender,708			token_id,709			properties.map(|p| (p.key, Some(p.value))),710			is_token_create,711			nesting_budget,712		)713	}714715	/// Add or edit single property for the token716	///717	/// Calls [`set_token_properties`] internally718	///719	/// [`set_token_properties`]: struct.Pallet.html#method.set_token_properties720	pub fn set_token_property(721		collection: &NonfungibleHandle<T>,722		sender: &T::CrossAccountId,723		token_id: TokenId,724		property: Property,725		nesting_budget: &dyn Budget,726	) -> DispatchResult {727		let is_token_create = false;728729		Self::set_token_properties(730			collection,731			sender,732			token_id,733			[property].into_iter(),734			is_token_create,735			nesting_budget,736		)737	}738739	/// Batch operation to remove properties from the token740	///741	/// Same as [`modify_token_properties`] but doesn't allow to add or edit properties742	///743	/// [`modify_token_properties`]: struct.Pallet.html#method.modify_token_properties744	pub fn delete_token_properties(745		collection: &NonfungibleHandle<T>,746		sender: &T::CrossAccountId,747		token_id: TokenId,748		property_keys: impl Iterator<Item = PropertyKey>,749		nesting_budget: &dyn Budget,750	) -> DispatchResult {751		let is_token_create = false;752753		Self::modify_token_properties(754			collection,755			sender,756			token_id,757			property_keys.into_iter().map(|key| (key, None)),758			is_token_create,759			nesting_budget,760		)761	}762763	/// Remove single property from the token764	///765	/// Calls [`delete_token_properties`] internally766	///767	/// [`delete_token_properties`]: struct.Pallet.html#method.delete_token_properties768	pub fn delete_token_property(769		collection: &NonfungibleHandle<T>,770		sender: &T::CrossAccountId,771		token_id: TokenId,772		property_key: PropertyKey,773		nesting_budget: &dyn Budget,774	) -> DispatchResult {775		Self::delete_token_properties(776			collection,777			sender,778			token_id,779			[property_key].into_iter(),780			nesting_budget,781		)782	}783784	/// Add or edit properties for the collection785	pub fn set_collection_properties(786		collection: &NonfungibleHandle<T>,787		sender: &T::CrossAccountId,788		properties: Vec<Property>,789	) -> DispatchResult {790		<PalletCommon<T>>::set_collection_properties(collection, sender, properties.into_iter())791	}792793	/// Remove properties from the collection794	pub fn delete_collection_properties(795		collection: &CollectionHandle<T>,796		sender: &T::CrossAccountId,797		property_keys: Vec<PropertyKey>,798	) -> DispatchResult {799		<PalletCommon<T>>::delete_collection_properties(800			collection,801			sender,802			property_keys.into_iter(),803		)804	}805806	/// Set property permissions for the token.807	///808	/// Sender should be the owner or admin of token's collection.809	pub fn set_token_property_permissions(810		collection: &CollectionHandle<T>,811		sender: &T::CrossAccountId,812		property_permissions: Vec<PropertyKeyPermission>,813	) -> DispatchResult {814		<PalletCommon<T>>::set_token_property_permissions(collection, sender, property_permissions)815	}816817	/// Set property permissions for the token with scope.818	///819	/// Sender should be the owner or admin of token's collection.820	pub fn set_scoped_token_property_permissions(821		collection: &CollectionHandle<T>,822		sender: &T::CrossAccountId,823		scope: PropertyScope,824		property_permissions: Vec<PropertyKeyPermission>,825	) -> DispatchResult {826		<PalletCommon<T>>::set_scoped_token_property_permissions(827			collection,828			sender,829			scope,830			property_permissions,831		)832	}833834	pub fn token_property_permission(collection_id: CollectionId) -> PropertiesPermissionMap {835		<PalletCommon<T>>::property_permissions(collection_id)836	}837838	pub fn check_token_immediate_ownership(839		collection: &NonfungibleHandle<T>,840		token: TokenId,841		possible_owner: &T::CrossAccountId,842	) -> DispatchResult {843		let token_data =844			<TokenData<T>>::get((collection.id, token)).ok_or(<CommonError<T>>::TokenNotFound)?;845		ensure!(846			&token_data.owner == possible_owner,847			<CommonError<T>>::NoPermission848		);849		Ok(())850	}851852	/// Transfer NFT token from one account to another.853	///854	/// `from` account stops being the owner and `to` account becomes the owner of the token.855	/// If `to` is token than `to` becomes owner of the token and the token become nested.856	/// Unnests token from previous parent if it was nested before.857	/// Removes allowance for the token if there was any.858	/// Throws if transfers aren't allowed for collection or if receiver reached token ownership limit.859	///860	/// - `nesting_budget`: Limit for token nesting depth861	pub fn transfer(862		collection: &NonfungibleHandle<T>,863		from: &T::CrossAccountId,864		to: &T::CrossAccountId,865		token: TokenId,866		nesting_budget: &dyn Budget,867	) -> DispatchResult {868		ensure!(869			collection.limits.transfers_enabled(),870			<CommonError<T>>::TransferNotAllowed871		);872873		let token_data =874			<TokenData<T>>::get((collection.id, token)).ok_or(<CommonError<T>>::TokenNotFound)?;875		ensure!(&token_data.owner == from, <CommonError<T>>::NoPermission);876877		if collection.permissions.access() == AccessMode::AllowList {878			collection.check_allowlist(from)?;879			collection.check_allowlist(to)?;880		}881		<PalletCommon<T>>::ensure_correct_receiver(to)?;882883		let balance_from = <AccountBalance<T>>::get((collection.id, from))884			.checked_sub(1)885			.ok_or(<CommonError<T>>::TokenValueTooLow)?;886		let balance_to = if from != to {887			let balance_to = <AccountBalance<T>>::get((collection.id, to))888				.checked_add(1)889				.ok_or(ArithmeticError::Overflow)?;890891			ensure!(892				balance_to < collection.limits.account_token_ownership_limit(),893				<CommonError<T>>::AccountTokenLimitExceeded,894			);895896			Some(balance_to)897		} else {898			None899		};900901		<PalletStructure<T>>::nest_if_sent_to_token(902			from.clone(),903			to,904			collection.id,905			token,906			nesting_budget,907		)?;908909		// =========910911		<PalletStructure<T>>::unnest_if_nested(&token_data.owner, collection.id, token);912913		<TokenData<T>>::insert(914			(collection.id, token),915			ItemData {916				owner: to.clone(),917				..token_data918			},919		);920921		if let Some(balance_to) = balance_to {922			// from != to923			if balance_from == 0 {924				<AccountBalance<T>>::remove((collection.id, from));925			} else {926				<AccountBalance<T>>::insert((collection.id, from), balance_from);927			}928			<AccountBalance<T>>::insert((collection.id, to), balance_to);929			<Owned<T>>::remove((collection.id, from, token));930			<Owned<T>>::insert((collection.id, to, token), true);931		}932		Self::set_allowance_unchecked(collection, from, token, None, true);933934		<PalletEvm<T>>::deposit_log(935			ERC721Events::Transfer {936				from: *from.as_eth(),937				to: *to.as_eth(),938				token_id: token.into(),939			}940			.to_log(collection_id_to_address(collection.id)),941		);942		<PalletCommon<T>>::deposit_event(CommonEvent::Transfer(943			collection.id,944			token,945			from.clone(),946			to.clone(),947			1,948		));949		Ok(())950	}951952	/// Batch operation to mint multiple NFT tokens.953	///954	/// The sender should be the owner/admin of the collection or collection should be configured955	/// to allow public minting.956	/// Throws if amount of tokens reached it's limit for the collection or if caller reached957	/// token ownership limit.958	///959	/// - `data`: Contains list of token properties and users who will become the owners of the960	///   corresponging tokens.961	/// - `nesting_budget`: Limit for token nesting depth962	pub fn create_multiple_items(963		collection: &NonfungibleHandle<T>,964		sender: &T::CrossAccountId,965		data: Vec<CreateItemData<T>>,966		nesting_budget: &dyn Budget,967	) -> DispatchResult {968		if !collection.is_owner_or_admin(sender) {969			ensure!(970				collection.permissions.mint_mode(),971				<CommonError<T>>::PublicMintingNotAllowed972			);973			collection.check_allowlist(sender)?;974975			for item in data.iter() {976				collection.check_allowlist(&item.owner)?;977			}978		}979980		for data in data.iter() {981			<PalletCommon<T>>::ensure_correct_receiver(&data.owner)?;982		}983984		let first_token = <TokensMinted<T>>::get(collection.id);985		let tokens_minted = first_token986			.checked_add(data.len() as u32)987			.ok_or(ArithmeticError::Overflow)?;988		ensure!(989			tokens_minted <= collection.limits.token_limit(),990			<CommonError<T>>::CollectionTokenLimitExceeded991		);992993		let mut balances = BTreeMap::new();994		for data in &data {995			let balance = balances996				.entry(&data.owner)997				.or_insert_with(|| <AccountBalance<T>>::get((collection.id, &data.owner)));998			*balance = balance.checked_add(1).ok_or(ArithmeticError::Overflow)?;9991000			ensure!(1001				*balance <= collection.limits.account_token_ownership_limit(),1002				<CommonError<T>>::AccountTokenLimitExceeded,1003			);1004		}10051006		for (i, data) in data.iter().enumerate() {1007			let token = TokenId(first_token + i as u32 + 1);10081009			<PalletStructure<T>>::check_nesting(1010				sender.clone(),1011				&data.owner,1012				collection.id,1013				token,1014				nesting_budget,1015			)?;1016		}10171018		// =========10191020		with_transaction(|| {1021			for (i, data) in data.iter().enumerate() {1022				let token = first_token + i as u32 + 1;10231024				<TokenData<T>>::insert(1025					(collection.id, token),1026					ItemData {1027						// const_data: data.const_data.clone(),1028						owner: data.owner.clone(),1029					},1030				);10311032				<PalletStructure<T>>::nest_if_sent_to_token_unchecked(1033					&data.owner,1034					collection.id,1035					TokenId(token),1036				);10371038				if let Err(e) = Self::set_token_properties(1039					collection,1040					sender,1041					TokenId(token),1042					data.properties.clone().into_iter(),1043					true,1044					nesting_budget,1045				) {1046					return TransactionOutcome::Rollback(Err(e));1047				}1048			}1049			TransactionOutcome::Commit(Ok(()))1050		})?;10511052		<TokensMinted<T>>::insert(collection.id, tokens_minted);1053		for (account, balance) in balances {1054			<AccountBalance<T>>::insert((collection.id, account), balance);1055		}1056		for (i, data) in data.into_iter().enumerate() {1057			let token = first_token + i as u32 + 1;1058			<Owned<T>>::insert((collection.id, &data.owner, token), true);10591060			<PalletEvm<T>>::deposit_log(1061				ERC721Events::Transfer {1062					from: H160::default(),1063					to: *data.owner.as_eth(),1064					token_id: token.into(),1065				}1066				.to_log(collection_id_to_address(collection.id)),1067			);1068			<PalletCommon<T>>::deposit_event(CommonEvent::ItemCreated(1069				collection.id,1070				TokenId(token),1071				data.owner.clone(),1072				1,1073			));1074		}1075		Ok(())1076	}10771078	pub fn set_allowance_unchecked(1079		collection: &NonfungibleHandle<T>,1080		sender: &T::CrossAccountId,1081		token: TokenId,1082		spender: Option<&T::CrossAccountId>,1083		assume_implicit_eth: bool,1084	) {1085		if let Some(spender) = spender {1086			let old_spender = <Allowance<T>>::get((collection.id, token));1087			<Allowance<T>>::insert((collection.id, token), spender);1088			// In ERC721 there is only one possible approved user of token, so we set1089			// approved user to spender1090			<PalletEvm<T>>::deposit_log(1091				ERC721Events::Approval {1092					owner: *sender.as_eth(),1093					approved: *spender.as_eth(),1094					token_id: token.into(),1095				}1096				.to_log(collection_id_to_address(collection.id)),1097			);1098			// In Unique chain, any token can have any amount of approved users, so we need to1099			// set allowance of old owner to 0, and allowance of new owner to 11100			if old_spender.as_ref() != Some(spender) {1101				if let Some(old_owner) = old_spender {1102					<PalletCommon<T>>::deposit_event(CommonEvent::Approved(1103						collection.id,1104						token,1105						sender.clone(),1106						old_owner,1107						0,1108					));1109				}1110				<PalletCommon<T>>::deposit_event(CommonEvent::Approved(1111					collection.id,1112					token,1113					sender.clone(),1114					spender.clone(),1115					1,1116				));1117			}1118		} else {1119			let old_spender = <Allowance<T>>::take((collection.id, token));1120			if !assume_implicit_eth {1121				// In ERC721 there is only one possible approved user of token, so we set1122				// approved user to zero address1123				<PalletEvm<T>>::deposit_log(1124					ERC721Events::Approval {1125						owner: *sender.as_eth(),1126						approved: H160::default(),1127						token_id: token.into(),1128					}1129					.to_log(collection_id_to_address(collection.id)),1130				);1131			}1132			// In Unique chain, any token can have any amount of approved users, so we need to1133			// set allowance of old owner to 01134			if let Some(old_spender) = old_spender {1135				<PalletCommon<T>>::deposit_event(CommonEvent::Approved(1136					collection.id,1137					token,1138					sender.clone(),1139					old_spender,1140					0,1141				));1142			}1143		}1144	}11451146	/// Set allowance for the spender to `transfer` or `burn` sender's token.1147	///1148	/// - `token`: Token the spender is allowed to `transfer` or `burn`.1149	pub fn set_allowance(1150		collection: &NonfungibleHandle<T>,1151		sender: &T::CrossAccountId,1152		token: TokenId,1153		spender: Option<&T::CrossAccountId>,1154	) -> DispatchResult {1155		if collection.permissions.access() == AccessMode::AllowList {1156			collection.check_allowlist(sender)?;1157			if let Some(spender) = spender {1158				collection.check_allowlist(spender)?;1159			}1160		}11611162		if let Some(spender) = spender {1163			<PalletCommon<T>>::ensure_correct_receiver(spender)?;1164		}11651166		let token_data =1167			<TokenData<T>>::get((collection.id, token)).ok_or(<CommonError<T>>::TokenNotFound)?;1168		if &token_data.owner != sender {1169			ensure!(1170				collection.ignores_owned_amount(sender),1171				<CommonError<T>>::CantApproveMoreThanOwned1172			);1173		}11741175		// =========11761177		Self::set_allowance_unchecked(collection, sender, token, spender, false);1178		Ok(())1179	}11801181	/// Set allowance for the spender to `transfer` or `burn` sender's token from eth mirror.1182	///1183	/// - `from`: Address of sender's eth mirror.1184	/// - `to`: Adress of spender.1185	/// - `token`: Token the spender is allowed to `transfer` or `burn`.1186	pub fn set_allowance_from(1187		collection: &NonfungibleHandle<T>,1188		sender: &T::CrossAccountId,1189		from: &T::CrossAccountId,1190		token: TokenId,1191		to: Option<&T::CrossAccountId>,1192	) -> DispatchResult {1193		if collection.permissions.access() == AccessMode::AllowList {1194			collection.check_allowlist(sender)?;1195			collection.check_allowlist(from)?;1196			if let Some(to) = to {1197				collection.check_allowlist(to)?;1198			}1199		}12001201		if let Some(to) = to {1202			<PalletCommon<T>>::ensure_correct_receiver(to)?;1203		}12041205		ensure!(1206			sender.conv_eq(from),1207			<CommonError<T>>::AddressIsNotEthMirror1208		);12091210		let token_data =1211			<TokenData<T>>::get((collection.id, token)).ok_or(<CommonError<T>>::TokenNotFound)?;1212		if token_data.owner != *from {1213			ensure!(1214				collection.limits.owner_can_transfer()1215					&& (collection.is_owner_or_admin(sender) || collection.is_owner_or_admin(from)),1216				<CommonError<T>>::CantApproveMoreThanOwned1217			);1218		}12191220		// =========12211222		Self::set_allowance_unchecked(collection, from, token, to, false);1223		Ok(())1224	}12251226	/// Checks allowance for the spender to use the token.1227	fn check_allowed(1228		collection: &NonfungibleHandle<T>,1229		spender: &T::CrossAccountId,1230		from: &T::CrossAccountId,1231		token: TokenId,1232		nesting_budget: &dyn Budget,1233	) -> DispatchResult {1234		if spender.conv_eq(from) {1235			return Ok(());1236		}1237		if collection.permissions.access() == AccessMode::AllowList {1238			// `from`, `to` checked in [`transfer`]1239			collection.check_allowlist(spender)?;1240		}12411242		if collection.limits.owner_can_transfer() && collection.is_owner_or_admin(spender) {1243			return Ok(());1244		}12451246		if let Some(source) = T::CrossTokenAddressMapping::address_to_token(from) {1247			ensure!(1248				<PalletStructure<T>>::check_indirectly_owned(1249					spender.clone(),1250					source.0,1251					source.1,1252					None,1253					nesting_budget1254				)?,1255				<CommonError<T>>::ApprovedValueTooLow,1256			);1257			return Ok(());1258		}1259		if <Allowance<T>>::get((collection.id, token)).as_ref() == Some(spender) {1260			return Ok(());1261		}1262		if <CollectionAllowance<T>>::get((collection.id, from, spender)) {1263			return Ok(());1264		}1265		ensure!(1266			collection.ignores_allowance(spender),1267			<CommonError<T>>::ApprovedValueTooLow1268		);1269		Ok(())1270	}12711272	/// Transfer NFT token from one account to another.1273	///1274	/// Same as the [`transfer`] but spender doesn't needs to be the owner of the token.1275	/// The owner should set allowance for the spender to transfer token.1276	///1277	/// [`transfer`]: struct.Pallet.html#method.transfer1278	pub fn transfer_from(1279		collection: &NonfungibleHandle<T>,1280		spender: &T::CrossAccountId,1281		from: &T::CrossAccountId,1282		to: &T::CrossAccountId,1283		token: TokenId,1284		nesting_budget: &dyn Budget,1285	) -> DispatchResult {1286		Self::check_allowed(collection, spender, from, token, nesting_budget)?;12871288		// =========12891290		// Allowance is reset in [`transfer`]1291		Self::transfer(collection, from, to, token, nesting_budget)1292	}12931294	/// Burn NFT token for `from` account.1295	///1296	/// Same as the [`burn`] but spender doesn't need to be an owner of the token. The owner should1297	/// set allowance for the spender to burn token.1298	///1299	/// [`burn`]: struct.Pallet.html#method.burn1300	pub fn burn_from(1301		collection: &NonfungibleHandle<T>,1302		spender: &T::CrossAccountId,1303		from: &T::CrossAccountId,1304		token: TokenId,1305		nesting_budget: &dyn Budget,1306	) -> DispatchResult {1307		Self::check_allowed(collection, spender, from, token, nesting_budget)?;13081309		// =========13101311		Self::burn(collection, from, token)1312	}13131314	/// Check that `from` token could be nested in `under` token.1315	///1316	pub fn check_nesting(1317		handle: &NonfungibleHandle<T>,1318		sender: T::CrossAccountId,1319		from: (CollectionId, TokenId),1320		under: TokenId,1321		nesting_budget: &dyn Budget,1322	) -> DispatchResult {1323		let nesting = handle.permissions.nesting();13241325		#[cfg(not(feature = "runtime-benchmarks"))]1326		let permissive = false;1327		#[cfg(feature = "runtime-benchmarks")]1328		let permissive = nesting.permissive;13291330		if permissive {1331			// Pass1332		} else if nesting.token_owner1333			&& <PalletStructure<T>>::check_indirectly_owned(1334				sender.clone(),1335				handle.id,1336				under,1337				Some(from),1338				nesting_budget,1339			)? {1340			// Pass1341		} else if nesting.collection_admin && handle.is_owner_or_admin(&sender) {1342			// Pass1343		} else {1344			fail!(<CommonError<T>>::UserIsNotAllowedToNest);1345		}13461347		if let Some(whitelist) = &nesting.restricted {1348			ensure!(1349				whitelist.contains(&from.0),1350				<CommonError<T>>::SourceCollectionIsNotAllowedToNest1351			);1352		}1353		Ok(())1354	}13551356	fn nest(under: (CollectionId, TokenId), to_nest: (CollectionId, TokenId)) {1357		<TokenChildren<T>>::insert((under.0, under.1, (to_nest.0, to_nest.1)), true);1358	}13591360	fn unnest(under: (CollectionId, TokenId), to_unnest: (CollectionId, TokenId)) {1361		<TokenChildren<T>>::remove((under.0, under.1, to_unnest));1362	}13631364	fn collection_has_tokens(collection_id: CollectionId) -> bool {1365		<TokenData<T>>::iter_prefix((collection_id,))1366			.next()1367			.is_some()1368	}13691370	fn token_has_children(collection_id: CollectionId, token_id: TokenId) -> bool {1371		<TokenChildren<T>>::iter_prefix((collection_id, token_id))1372			.next()1373			.is_some()1374	}13751376	pub fn token_children_ids(collection_id: CollectionId, token_id: TokenId) -> Vec<TokenChild> {1377		<TokenChildren<T>>::iter_prefix((collection_id, token_id))1378			.map(|((child_collection_id, child_id), _)| TokenChild {1379				collection: child_collection_id,1380				token: child_id,1381			})1382			.collect()1383	}13841385	/// Mint single NFT token.1386	///1387	/// Delegated to [`create_multiple_items`]1388	///1389	/// [`create_multiple_items`]: struct.Pallet.html#method.create_multiple_items1390	pub fn create_item(1391		collection: &NonfungibleHandle<T>,1392		sender: &T::CrossAccountId,1393		data: CreateItemData<T>,1394		nesting_budget: &dyn Budget,1395	) -> DispatchResult {1396		Self::create_multiple_items(collection, sender, vec![data], nesting_budget)1397	}13981399	/// Sets or unsets the approval of a given operator.1400	///1401	/// The `operator` is allowed to transfer all token pieces of the `owner` on their behalf.1402	/// - `owner`: Token owner1403	/// - `operator`: Operator1404	/// - `approve`: Should operator status be granted or revoked?1405	pub fn set_allowance_for_all(1406		collection: &NonfungibleHandle<T>,1407		owner: &T::CrossAccountId,1408		operator: &T::CrossAccountId,1409		approve: bool,1410	) -> DispatchResult {1411		if collection.permissions.access() == AccessMode::AllowList {1412			collection.check_allowlist(owner)?;1413			collection.check_allowlist(operator)?;1414		}14151416		<PalletCommon<T>>::ensure_correct_receiver(operator)?;14171418		// =========14191420		<CollectionAllowance<T>>::insert((collection.id, owner, operator), approve);1421		<PalletEvm<T>>::deposit_log(1422			ERC721Events::ApprovalForAll {1423				owner: *owner.as_eth(),1424				operator: *operator.as_eth(),1425				approved: approve,1426			}1427			.to_log(collection_id_to_address(collection.id)),1428		);1429		<PalletCommon<T>>::deposit_event(CommonEvent::ApprovedForAll(1430			collection.id,1431			owner.clone(),1432			operator.clone(),1433			approve,1434		));1435		Ok(())1436	}14371438	/// Tells whether the given `owner` approves the `operator`.1439	pub fn allowance_for_all(1440		collection: &NonfungibleHandle<T>,1441		owner: &T::CrossAccountId,1442		operator: &T::CrossAccountId,1443	) -> bool {1444		<CollectionAllowance<T>>::get((collection.id, owner, operator))1445	}14461447	pub fn repair_item(collection: &NonfungibleHandle<T>, token: TokenId) -> DispatchResult {1448		<TokenProperties<T>>::mutate((collection.id, token), |properties| {1449			properties.recompute_consumed_space();1450		});14511452		Ok(())1453	}1454}
modifiedpallets/refungible/src/lib.rsdiffbeforeafterboth
--- a/pallets/refungible/src/lib.rs
+++ b/pallets/refungible/src/lib.rs
@@ -520,7 +520,7 @@
 		collection: &RefungibleHandle<T>,
 		sender: &T::CrossAccountId,
 		token_id: TokenId,
-		properties: impl Iterator<Item = (PropertyKey, Option<PropertyValue>)>,
+		properties_updates: impl Iterator<Item = (PropertyKey, Option<PropertyValue>)>,
 		is_token_create: bool,
 		nesting_budget: &dyn Budget,
 	) -> DispatchResult {
@@ -544,15 +544,16 @@
 			Ok(is_bundle_owner)
 		};
 
-		for (key, value) in properties {
-			let permission = <PalletCommon<T>>::property_permissions(collection.id)
+		let mut stored_properties = <TokenProperties<T>>::get((collection.id, token_id));
+		let permissions = <PalletCommon<T>>::property_permissions(collection.id);
+
+		for (key, value) in properties_updates {
+			let permission = permissions
 				.get(&key)
 				.cloned()
 				.unwrap_or_else(PropertyPermission::none);
 
-			let is_property_exists = TokenProperties::<T>::get((collection.id, token_id))
-				.get(&key)
-				.is_some();
+			let is_property_exists = stored_properties.get(&key).is_some();
 
 			match permission {
 				PropertyPermission { mutable: false, .. } if is_property_exists => {
@@ -578,10 +579,9 @@
 
 			match value {
 				Some(value) => {
-					<TokenProperties<T>>::try_mutate((collection.id, token_id), |properties| {
-						properties.try_set(key.clone(), value)
-					})
-					.map_err(<CommonError<T>>::from)?;
+					stored_properties
+						.try_set(key.clone(), value)
+						.map_err(<CommonError<T>>::from)?;
 
 					<PalletCommon<T>>::deposit_event(CommonEvent::TokenPropertySet(
 						collection.id,
@@ -590,10 +590,9 @@
 					));
 				}
 				None => {
-					<TokenProperties<T>>::try_mutate((collection.id, token_id), |properties| {
-						properties.remove(&key)
-					})
-					.map_err(<CommonError<T>>::from)?;
+					stored_properties
+						.remove(&key)
+						.map_err(<CommonError<T>>::from)?;
 
 					<PalletCommon<T>>::deposit_event(CommonEvent::TokenPropertyDeleted(
 						collection.id,
@@ -612,6 +611,10 @@
 			);
 		}
 
+		<TokenProperties<T>>::mutate((collection.id, token_id), |properties| {
+			*properties = stored_properties;
+		});
+
 		Ok(())
 	}
 
@@ -1353,7 +1356,7 @@
 		sender: &T::CrossAccountId,
 		properties: Vec<Property>,
 	) -> DispatchResult {
-		<PalletCommon<T>>::set_collection_properties(collection, sender, properties)
+		<PalletCommon<T>>::set_collection_properties(collection, sender, properties.into_iter())
 	}
 
 	pub fn delete_collection_properties(
@@ -1361,7 +1364,11 @@
 		sender: &T::CrossAccountId,
 		property_keys: Vec<PropertyKey>,
 	) -> DispatchResult {
-		<PalletCommon<T>>::delete_collection_properties(collection, sender, property_keys)
+		<PalletCommon<T>>::delete_collection_properties(
+			collection,
+			sender,
+			property_keys.into_iter(),
+		)
 	}
 
 	pub fn set_token_property_permissions(
modifiedpallets/unique/src/eth/mod.rsdiffbeforeafterboth
--- a/pallets/unique/src/eth/mod.rs
+++ b/pallets/unique/src/eth/mod.rs
@@ -33,7 +33,6 @@
 };
 use pallet_evm::{account::CrossAccountId, OnMethodCall, PrecompileHandle, PrecompileResult};
 use pallet_evm_coder_substrate::{dispatch_to_evm, SubstrateRecorder, WithRecorder};
-use sp_std::vec;
 use up_data_structs::{
 	CollectionDescription, CollectionMode, CollectionName, CollectionTokenPrefix,
 	CreateCollectionData,
@@ -316,13 +315,14 @@
 			<PalletCommon<T>>::set_collection_properties(
 				&collection,
 				&caller,
-				vec![up_data_structs::Property {
+				[up_data_structs::Property {
 					key: key::base_uri(),
 					value: base_uri
 						.into_bytes()
 						.try_into()
 						.map_err(|_| "base uri is too large")?,
-				}],
+				}]
+				.into_iter(),
 			)
 			.map_err(dispatch_to_evm::<T>)?;
 		}