difftreelog
feat Add events for set contract sponsoring.
in: master
7 files changed
Cargo.lockdiffbeforeafterboth--- a/Cargo.lock
+++ b/Cargo.lock
@@ -5735,6 +5735,7 @@
name = "pallet-evm-contract-helpers"
version = "0.2.0"
dependencies = [
+ "ethereum",
"evm-coder",
"fp-evm-mapping",
"frame-support",
pallets/evm-contract-helpers/Cargo.tomldiffbeforeafterboth--- a/pallets/evm-contract-helpers/Cargo.toml
+++ b/pallets/evm-contract-helpers/Cargo.toml
@@ -9,6 +9,7 @@
"derive",
] }
log = { default-features = false, version = "0.4.14" }
+ethereum = { version = "0.12.0", default-features = false }
# Substrate
frame-support = { default-features = false, git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.27" }
pallets/evm-contract-helpers/src/eth.rsdiffbeforeafterboth--- a/pallets/evm-contract-helpers/src/eth.rs
+++ b/pallets/evm-contract-helpers/src/eth.rs
@@ -17,7 +17,9 @@
//! Implementation of magic contract
use core::marker::PhantomData;
-use evm_coder::{abi::AbiWriter, execution::Result, generate_stubgen, solidity_interface, types::*};
+use evm_coder::{
+ abi::AbiWriter, execution::Result, generate_stubgen, solidity_interface, types::*, ToLog,
+};
use pallet_evm_coder_substrate::{SubstrateRecorder, WithRecorder, dispatch_to_evm};
use pallet_evm::{
ExitRevert, OnCreate, OnMethodCall, PrecompileResult, PrecompileFailure, PrecompileHandle,
@@ -33,6 +35,37 @@
use up_sponsorship::SponsorshipHandler;
use sp_std::vec::Vec;
+/// Pallet events.
+#[derive(ToLog)]
+pub enum ContractHelpersEvents {
+ /// Contract sponsor was set.
+ ContractSponsorSet {
+ /// Contract address of the affected collection.
+ #[indexed]
+ contract: address,
+ /// New sponsor address.
+ #[indexed]
+ sponsor: address,
+ },
+
+ /// New sponsor was confirm.
+ ContractSponsorshipConfirmed {
+ /// Contract address of the affected collection.
+ #[indexed]
+ contract: address,
+ /// New sponsor address.
+ #[indexed]
+ sponsor: address,
+ },
+
+ /// Collection sponsor was removed.
+ ContractSponsorRemoved {
+ /// Contract address of the affected collection.
+ #[indexed]
+ contract: address,
+ },
+}
+
/// See [`ContractHelpersCall`]
pub struct ContractHelpers<T: Config>(SubstrateRecorder<T>);
impl<T: Config> WithRecorder<T> for ContractHelpers<T> {
@@ -46,7 +79,7 @@
}
/// @title Magic contract, which allows users to reconfigure other contracts
-#[solidity_interface(name = ContractHelpers)]
+#[solidity_interface(name = ContractHelpers, events(ContractHelpersEvents))]
impl<T: Config> ContractHelpers<T>
where
T::AccountId: AsRef<[u8; 32]>,
@@ -91,7 +124,7 @@
self.recorder().consume_sload()?;
self.recorder().consume_sstore()?;
- Pallet::<T>::self_sponsored_enable(&T::CrossAccountId::from_eth(caller), contract_address)
+ Pallet::<T>::force_set_sponsor(&T::CrossAccountId::from_eth(caller), contract_address)
.map_err(dispatch_to_evm::<T>)?;
Ok(())
pallets/evm-contract-helpers/src/lib.rsdiffbeforeafterboth--- a/pallets/evm-contract-helpers/src/lib.rs
+++ b/pallets/evm-contract-helpers/src/lib.rs
@@ -16,7 +16,7 @@
#![doc = include_str!("../README.md")]
#![cfg_attr(not(feature = "std"), no_std)]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
use codec::{Decode, Encode, MaxEncodedLen};
pub use pallet::*;
@@ -27,18 +27,24 @@
#[frame_support::pallet]
pub mod pallet {
pub use super::*;
+ use crate::eth::ContractHelpersEvents;
use frame_support::pallet_prelude::*;
use pallet_evm_coder_substrate::DispatchResult;
use sp_core::H160;
- use pallet_evm::account::CrossAccountId;
+ use pallet_evm::{account::CrossAccountId, Pallet as PalletEvm};
use up_data_structs::SponsorshipState;
+ use evm_coder::ToLog;
#[pallet::config]
pub trait Config:
frame_system::Config + pallet_evm_coder_substrate::Config + pallet_evm::account::Config
{
+ /// Overarching event type.
+ type Event: IsType<<Self as frame_system::Config>::Event> + From<Event<Self>>;
+
/// Address, under which magic contract will be available
type ContractAddress: Get<H160>;
+
/// In case of enabled sponsoring, but no sponsoring rate limit set,
/// this value will be used implicitly
type DefaultSponsoringRateLimit: Get<Self::BlockNumber>;
@@ -150,6 +156,32 @@
QueryKind = ValueQuery,
>;
+ #[pallet::event]
+ #[pallet::generate_deposit(pub fn deposit_event)]
+ pub enum Event<T: Config> {
+ /// Contract sponsor was set.
+ ContractSponsorSet(
+ /// Contract address of the affected collection.
+ H160,
+ /// New sponsor address.
+ T::AccountId,
+ ),
+
+ /// New sponsor was confirm.
+ ContractSponsorshipConfirmed(
+ /// Contract address of the affected collection.
+ H160,
+ /// New sponsor address.
+ T::AccountId,
+ ),
+
+ /// Collection sponsor was removed.
+ ContractSponsorRemoved(
+ /// Contract address of the affected collection.
+ H160,
+ ),
+ }
+
impl<T: Config> Pallet<T> {
/// Get contract owner.
pub fn contract_owner(contract: H160) -> H160 {
@@ -169,13 +201,25 @@
contract,
SponsorshipState::<T::CrossAccountId>::Unconfirmed(sponsor.clone()),
);
+
+ <Pallet<T>>::deposit_event(Event::<T>::ContractSponsorSet(
+ contract,
+ sponsor.as_sub().clone(),
+ ));
+ <PalletEvm<T>>::deposit_log(
+ ContractHelpersEvents::ContractSponsorSet {
+ contract,
+ sponsor: *sponsor.as_eth(),
+ }
+ .to_log(contract),
+ );
Ok(())
}
- /// Set `contract` as self sponsored.
+ /// Set sponsor as already confirmed.
///
/// `sender` must be owner of contract.
- pub fn self_sponsored_enable(sender: &T::CrossAccountId, contract: H160) -> DispatchResult {
+ pub fn force_set_sponsor(sender: &T::CrossAccountId, contract: H160) -> DispatchResult {
Pallet::<T>::ensure_owner(contract, *sender.as_eth())?;
Sponsoring::<T>::insert(
contract,
@@ -192,6 +236,12 @@
pub fn remove_sponsor(sender: &T::CrossAccountId, contract: H160) -> DispatchResult {
Pallet::<T>::ensure_owner(contract, *sender.as_eth())?;
Sponsoring::<T>::remove(contract);
+
+ <Pallet<T>>::deposit_event(Event::<T>::ContractSponsorRemoved(contract));
+ <PalletEvm<T>>::deposit_log(
+ ContractHelpersEvents::ContractSponsorRemoved { contract }.to_log(contract),
+ );
+
Ok(())
}
@@ -202,10 +252,25 @@
match Sponsoring::<T>::get(contract) {
SponsorshipState::Unconfirmed(sponsor) => {
ensure!(sponsor == *sender, Error::<T>::NoPermission);
+ let eth_sponsor = *sponsor.as_eth();
+ let sub_sponsor = sponsor.as_sub().clone();
Sponsoring::<T>::insert(
contract,
SponsorshipState::<T::CrossAccountId>::Confirmed(sponsor),
);
+
+ <Pallet<T>>::deposit_event(Event::<T>::ContractSponsorshipConfirmed(
+ contract,
+ sub_sponsor,
+ ));
+ <PalletEvm<T>>::deposit_log(
+ ContractHelpersEvents::ContractSponsorshipConfirmed {
+ contract,
+ sponsor: eth_sponsor,
+ }
+ .to_log(contract),
+ );
+
Ok(())
}
SponsorshipState::Disabled | SponsorshipState::Confirmed(_) => {
runtime/common/config/ethereum.rsdiffbeforeafterboth1use sp_core::{U256, H160};2use frame_support::{3 weights::{Weight, constants::WEIGHT_PER_SECOND},4 traits::{FindAuthor},5 parameter_types, ConsensusEngineId,6};7use sp_runtime::{RuntimeAppPublic, Perbill};8use crate::{9 runtime_common::{10 dispatch::CollectionDispatchT, ethereum::sponsoring::EvmSponsorshipHandler,11 config::sponsoring::DefaultSponsoringRateLimit, DealWithFees,12 },13 Runtime, Aura, Balances, Event, ChainId,14};15use pallet_evm::{EnsureAddressTruncated, HashedAddressMapping};16use up_common::constants::*;1718pub type CrossAccountId = pallet_evm::account::BasicCrossAccountId<Runtime>;1920impl pallet_evm::account::Config for Runtime {21 type CrossAccountId = CrossAccountId;22 type EvmAddressMapping = pallet_evm::HashedAddressMapping<Self::Hashing>;23 type EvmBackwardsAddressMapping = fp_evm_mapping::MapBackwardsAddressTruncated;24}2526// Assuming slowest ethereum opcode is SSTORE, with gas price of 20000 as our worst case27// (contract, which only writes a lot of data),28// approximating on top of our real store write weight29parameter_types! {30 pub const WritesPerSecond: u64 = WEIGHT_PER_SECOND / <Runtime as frame_system::Config>::DbWeight::get().write;31 pub const GasPerSecond: u64 = WritesPerSecond::get() * 20000;32 pub const WeightPerGas: u64 = WEIGHT_PER_SECOND / GasPerSecond::get();33}3435/// Limiting EVM execution to 50% of block for substrate users and management tasks36/// EVM transaction consumes more weight than substrate's, so we can't rely on them being37/// scheduled fairly38const EVM_DISPATCH_RATIO: Perbill = Perbill::from_percent(50);39parameter_types! {40 pub BlockGasLimit: U256 = U256::from(NORMAL_DISPATCH_RATIO * EVM_DISPATCH_RATIO * MAXIMUM_BLOCK_WEIGHT / WeightPerGas::get());41}4243pub enum FixedGasWeightMapping {}44impl pallet_evm::GasWeightMapping for FixedGasWeightMapping {45 fn gas_to_weight(gas: u64) -> Weight {46 gas.saturating_mul(WeightPerGas::get())47 }48 fn weight_to_gas(weight: Weight) -> u64 {49 weight / WeightPerGas::get()50 }51}5253pub struct EthereumFindAuthor<F>(core::marker::PhantomData<F>);54impl<F: FindAuthor<u32>> FindAuthor<H160> for EthereumFindAuthor<F> {55 fn find_author<'a, I>(digests: I) -> Option<H160>56 where57 I: 'a + IntoIterator<Item = (ConsensusEngineId, &'a [u8])>,58 {59 if let Some(author_index) = F::find_author(digests) {60 let authority_id = Aura::authorities()[author_index as usize].clone();61 return Some(H160::from_slice(&authority_id.to_raw_vec()[4..24]));62 }63 None64 }65}6667impl pallet_evm::Config for Runtime {68 type BlockGasLimit = BlockGasLimit;69 type FeeCalculator = pallet_configuration::FeeCalculator<Self>;70 type GasWeightMapping = FixedGasWeightMapping;71 type BlockHashMapping = pallet_ethereum::EthereumBlockHashMapping<Self>;72 type CallOrigin = EnsureAddressTruncated<Self>;73 type WithdrawOrigin = EnsureAddressTruncated<Self>;74 type AddressMapping = HashedAddressMapping<Self::Hashing>;75 type PrecompilesType = ();76 type PrecompilesValue = ();77 type Currency = Balances;78 type Event = Event;79 type OnMethodCall = (80 pallet_evm_migration::OnMethodCall<Self>,81 pallet_evm_contract_helpers::HelpersOnMethodCall<Self>,82 CollectionDispatchT<Self>,83 pallet_unique::eth::CollectionHelpersOnMethodCall<Self>,84 );85 type OnCreate = pallet_evm_contract_helpers::HelpersOnCreate<Self>;86 type ChainId = ChainId;87 type Runner = pallet_evm::runner::stack::Runner<Self>;88 type OnChargeTransaction = pallet_evm::EVMCurrencyAdapter<Balances, DealWithFees>;89 type TransactionValidityHack = pallet_evm_transaction_payment::TransactionValidityHack<Self>;90 type FindAuthor = EthereumFindAuthor<Aura>;91}9293impl pallet_evm_migration::Config for Runtime {94 type WeightInfo = pallet_evm_migration::weights::SubstrateWeight<Self>;95}9697impl pallet_ethereum::Config for Runtime {98 type Event = Event;99 type StateRoot = pallet_ethereum::IntermediateStateRoot<Self>;100}101102parameter_types! {103 // 0x842899ECF380553E8a4de75bF534cdf6fBF64049104 pub const HelpersContractAddress: H160 = H160([105 0x84, 0x28, 0x99, 0xec, 0xf3, 0x80, 0x55, 0x3e, 0x8a, 0x4d, 0xe7, 0x5b, 0xf5, 0x34, 0xcd, 0xf6, 0xfb, 0xf6, 0x40, 0x49,106 ]);107108 // 0x6c4e9fe1ae37a41e93cee429e8e1881abdcbb54f109 pub const EvmCollectionHelpersAddress: H160 = H160([110 0x6c, 0x4e, 0x9f, 0xe1, 0xae, 0x37, 0xa4, 0x1e, 0x93, 0xce, 0xe4, 0x29, 0xe8, 0xe1, 0x88, 0x1a, 0xbd, 0xcb, 0xb5, 0x4f,111 ]);112}113114impl pallet_evm_contract_helpers::Config for Runtime {115 type ContractAddress = HelpersContractAddress;116 type DefaultSponsoringRateLimit = DefaultSponsoringRateLimit;117}118119impl pallet_evm_coder_substrate::Config for Runtime {}120121impl pallet_evm_transaction_payment::Config for Runtime {122 type EvmSponsorshipHandler = EvmSponsorshipHandler;123}runtime/common/config/pallets/app_promotion.rsdiffbeforeafterboth--- a/runtime/common/config/pallets/app_promotion.rs
+++ b/runtime/common/config/pallets/app_promotion.rs
@@ -22,7 +22,7 @@
use frame_support::{parameter_types, PalletId};
use sp_arithmetic::Perbill;
use up_common::{
- constants::{ UNIQUE, RELAY_DAYS},
+ constants::{UNIQUE, RELAY_DAYS},
types::Balance,
};
runtime/common/construct_runtime/mod.rsdiffbeforeafterboth--- a/runtime/common/construct_runtime/mod.rs
+++ b/runtime/common/construct_runtime/mod.rs
@@ -85,7 +85,7 @@
Ethereum: pallet_ethereum::{Pallet, Config, Call, Storage, Event, Origin} = 101,
EvmCoderSubstrate: pallet_evm_coder_substrate::{Pallet, Storage} = 150,
- EvmContractHelpers: pallet_evm_contract_helpers::{Pallet, Storage} = 151,
+ EvmContractHelpers: pallet_evm_contract_helpers::{Pallet, Storage, Event<T>} = 151,
EvmTransactionPayment: pallet_evm_transaction_payment::{Pallet} = 152,
EvmMigration: pallet_evm_migration::{Pallet, Call, Storage} = 153,
}