difftreelog
CORE-300 Adapt to CrossAccountId
in: master
20 files changed
Cargo.lockdiffbeforeafterboth--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2554,7 +2554,7 @@
"fc-db",
"fc-rpc-core",
"fp-consensus",
- "fp-evm 3.0.0-dev (git+https://github.com/uniquenetwork/frontier.git?branch=unique-polkadot-v0.9.17)",
+ "fp-evm",
"fp-rpc",
"fp-storage",
"futures 0.3.21",
@@ -2565,7 +2565,7 @@
"log",
"lru 0.6.6",
"pallet-ethereum",
- "pallet-evm 6.0.0-dev (git+https://github.com/uniquenetwork/frontier.git?branch=unique-polkadot-v0.9.17)",
+ "pallet-evm",
"parity-scale-codec",
"parking_lot 0.11.2",
"rand 0.7.3",
@@ -2757,7 +2757,7 @@
dependencies = [
"ethereum",
"ethereum-types",
- "fp-evm 3.0.0-dev (git+https://github.com/uniquenetwork/frontier.git?branch=unique-polkadot-v0.9.17)",
+ "fp-evm",
"parity-scale-codec",
"scale-info",
"sp-api",
@@ -2853,21 +2853,6 @@
]
[[package]]
-name = "frame-common"
-version = "0.1.0"
-source = "git+https://github.com/uniquenetwork/frontier.git?branch=feature/300#0a1dc4086cbe971ddf57edf82a61cfce52c8c20b"
-dependencies = [
- "frame-system",
- "pallet-evm 6.0.0-dev (git+https://github.com/uniquenetwork/frontier.git?branch=feature/300)",
- "parity-scale-codec",
- "scale-info",
- "serde",
- "sp-core",
- "sp-std",
- "up-evm-mapping",
-]
-
-[[package]]
name = "frame-election-provider-support"
version = "4.0.0-dev"
source = "git+https://github.com/paritytech/substrate.git?branch=polkadot-v0.9.18#fc3fd073d3a0acf9933c3994b660ebd7b5833f65"
@@ -5850,7 +5835,7 @@
dependencies = [
"frame-support",
"frame-system",
- "pallet-evm 6.0.0-dev (git+https://github.com/uniquenetwork/frontier.git?branch=unique-polkadot-v0.9.17)",
+ "pallet-evm",
"parity-scale-codec",
"scale-info",
"serde",
@@ -5999,10 +5984,9 @@
version = "0.1.0"
dependencies = [
"evm-coder",
- "frame-common",
"frame-support",
"frame-system",
- "pallet-evm 6.0.0-dev (git+https://github.com/uniquenetwork/frontier.git?branch=unique-polkadot-v0.9.17)",
+ "pallet-evm",
"pallet-evm-coder-substrate",
"parity-scale-codec",
"scale-info",
@@ -6080,7 +6064,7 @@
"ethereum-types",
"evm",
"fp-consensus",
- "fp-evm 3.0.0-dev (git+https://github.com/uniquenetwork/frontier.git?branch=unique-polkadot-v0.9.17)",
+ "fp-evm",
"fp-rpc",
"fp-self-contained",
"fp-storage",
@@ -6088,7 +6072,7 @@
"frame-system",
"log",
"pallet-balances",
- "pallet-evm 6.0.0-dev (git+https://github.com/uniquenetwork/frontier.git?branch=unique-polkadot-v0.9.17)",
+ "pallet-evm",
"pallet-timestamp",
"parity-scale-codec",
"rlp",
@@ -6109,7 +6093,7 @@
"evm",
"evm-gasometer",
"evm-runtime",
- "fp-evm 3.0.0-dev (git+https://github.com/uniquenetwork/frontier.git?branch=unique-polkadot-v0.9.17)",
+ "fp-evm",
"frame-benchmarking",
"frame-support",
"frame-system",
@@ -6140,7 +6124,7 @@
"frame-support",
"frame-system",
"pallet-ethereum",
- "pallet-evm 6.0.0-dev (git+https://github.com/uniquenetwork/frontier.git?branch=unique-polkadot-v0.9.17)",
+ "pallet-evm",
"parity-scale-codec",
"scale-info",
"sp-core",
@@ -6155,7 +6139,7 @@
"frame-support",
"frame-system",
"log",
- "pallet-evm 6.0.0-dev (git+https://github.com/uniquenetwork/frontier.git?branch=unique-polkadot-v0.9.17)",
+ "pallet-evm",
"pallet-evm-coder-substrate",
"parity-scale-codec",
"scale-info",
@@ -6170,11 +6154,11 @@
name = "pallet-evm-migration"
version = "0.1.0"
dependencies = [
- "fp-evm 3.0.0-dev (git+https://github.com/uniquenetwork/frontier.git?branch=unique-polkadot-v0.9.17)",
+ "fp-evm",
"frame-benchmarking",
"frame-support",
"frame-system",
- "pallet-evm 6.0.0-dev (git+https://github.com/uniquenetwork/frontier.git?branch=unique-polkadot-v0.9.17)",
+ "pallet-evm",
"parity-scale-codec",
"scale-info",
"sp-core",
@@ -6187,11 +6171,11 @@
name = "pallet-evm-transaction-payment"
version = "0.1.0"
dependencies = [
- "fp-evm 3.0.0-dev (git+https://github.com/uniquenetwork/frontier.git?branch=unique-polkadot-v0.9.17)",
+ "fp-evm",
"frame-support",
"frame-system",
"pallet-ethereum",
- "pallet-evm 6.0.0-dev (git+https://github.com/uniquenetwork/frontier.git?branch=unique-polkadot-v0.9.17)",
+ "pallet-evm",
"parity-scale-codec",
"scale-info",
"sp-core",
@@ -6209,10 +6193,10 @@
"ethereum",
"evm-coder",
"frame-benchmarking",
- "frame-common",
"frame-support",
"frame-system",
"pallet-common",
+ "pallet-evm",
"pallet-evm-coder-substrate",
"parity-scale-codec",
"scale-info",
@@ -6436,10 +6420,10 @@
"ethereum",
"evm-coder",
"frame-benchmarking",
- "frame-common",
"frame-support",
"frame-system",
"pallet-common",
+ "pallet-evm",
"pallet-evm-coder-substrate",
"parity-scale-codec",
"scale-info",
@@ -6553,10 +6537,10 @@
version = "0.1.0"
dependencies = [
"frame-benchmarking",
- "frame-common",
"frame-support",
"frame-system",
"pallet-common",
+ "pallet-evm",
"parity-scale-codec",
"scale-info",
"sp-core",
@@ -6814,16 +6798,15 @@
dependencies = [
"ethereum",
"evm-coder",
- "fp-evm 3.0.0-dev (git+https://github.com/uniquenetwork/frontier.git?branch=unique-polkadot-v0.9.17)",
+ "fp-evm",
"frame-benchmarking",
- "frame-common",
"frame-support",
"frame-system",
"hex-literal",
"pallet-balances",
"pallet-common",
"pallet-ethereum",
- "pallet-evm 6.0.0-dev (git+https://github.com/uniquenetwork/frontier.git?branch=unique-polkadot-v0.9.17)",
+ "pallet-evm",
"pallet-evm-coder-substrate",
"pallet-fungible",
"pallet-nonfungible",
@@ -12353,11 +12336,11 @@
name = "uc-rpc"
version = "0.1.0"
dependencies = [
- "frame-common",
"jsonrpc-core",
"jsonrpc-core-client",
"jsonrpc-derive",
"pallet-common",
+ "pallet-evm",
"parity-scale-codec",
"sp-api",
"sp-blockchain",
@@ -12570,7 +12553,6 @@
"fp-rpc",
"fp-self-contained",
"frame-benchmarking",
- "frame-common",
"frame-executive",
"frame-support",
"frame-system",
@@ -12583,7 +12565,7 @@
"pallet-base-fee",
"pallet-common",
"pallet-ethereum",
- "pallet-evm 6.0.0-dev (git+https://github.com/uniquenetwork/frontier.git?branch=unique-polkadot-v0.9.17)",
+ "pallet-evm",
"pallet-evm-coder-substrate",
"pallet-evm-contract-helpers",
"pallet-evm-migration",
@@ -12720,8 +12702,8 @@
name = "up-rpc"
version = "0.1.0"
dependencies = [
- "frame-common",
"pallet-common",
+ "pallet-evm",
"parity-scale-codec",
"sp-api",
"sp-core",
client/rpc/Cargo.tomldiffbeforeafterboth--- a/client/rpc/Cargo.toml
+++ b/client/rpc/Cargo.toml
@@ -18,4 +18,5 @@
sp-core = { default-features = false, git = "https://github.com/paritytech/substrate.git", branch = "polkadot-v0.9.18" }
sp-rpc = { default-features = false, git = "https://github.com/paritytech/substrate.git", branch = "polkadot-v0.9.18" }
sp-runtime = { default-features = false, git = "https://github.com/paritytech/substrate.git", branch = "polkadot-v0.9.18" }
+pallet-evm = { default-features = false, git = "https://github.com/uniquenetwork/frontier.git", branch = "unique-polkadot-v0.9.18" }
frame-common = { default-features = false, git = "https://github.com/uniquenetwork/frontier.git", branch = "feature/300" }
client/rpc/src/lib.rsdiffbeforeafterboth--- a/client/rpc/src/lib.rs
+++ b/client/rpc/src/lib.rs
@@ -201,7 +201,7 @@
AccountId: Decode,
C: 'static + ProvideRuntimeApi<Block> + HeaderBackend<Block>,
C::Api: UniqueRuntimeApi<Block, CrossAccountId, AccountId>,
- CrossAccountId: frame_common::account::CrossAccountId<AccountId>,
+ CrossAccountId: pallet_evm::account::CrossAccountId<AccountId>,
{
pass_method!(account_tokens(collection: CollectionId, account: CrossAccountId) -> Vec<TokenId>);
pass_method!(token_exists(collection: CollectionId, token: TokenId) -> bool);
pallets/common/src/lib.rsdiffbeforeafterboth--- a/pallets/common/src/lib.rs
+++ b/pallets/common/src/lib.rs
@@ -19,7 +19,7 @@
use core::ops::{Deref, DerefMut};
use pallet_evm_coder_substrate::{SubstrateRecorder, WithRecorder};
use sp_std::vec::Vec;
-use frame_common::account::CrossAccountId;
+use pallet_evm::account::CrossAccountId;
use frame_support::{
dispatch::{DispatchErrorWithPostInfo, DispatchResultWithPostInfo},
ensure, fail,
@@ -162,19 +162,14 @@
pub mod pallet {
use super::*;
use frame_support::{Blake2_128Concat, pallet_prelude::*, storage::Key};
- use frame_common::account::CrossAccountId;
+ use pallet_evm::account;
use frame_support::traits::Currency;
use up_data_structs::TokenId;
use scale_info::TypeInfo;
#[pallet::config]
- pub trait Config: frame_system::Config + pallet_evm_coder_substrate::Config + TypeInfo {
+ pub trait Config: frame_system::Config + pallet_evm_coder_substrate::Config + TypeInfo + account::Config {
type Event: IsType<<Self as frame_system::Config>::Event> + From<Event<Self>>;
-
- type CrossAccountId: CrossAccountId<Self::AccountId>;
-
- type EvmAddressMapping: pallet_evm::AddressMapping<Self::AccountId>;
- type EvmBackwardsAddressMapping: up_evm_mapping::EvmBackwardsAddressMapping<Self::AccountId>;
type Currency: Currency<Self::AccountId>;
pallets/evm-transaction-payment/src/lib.rsdiffbeforeafterboth--- a/pallets/evm-transaction-payment/src/lib.rs
+++ b/pallets/evm-transaction-payment/src/lib.rs
@@ -20,7 +20,7 @@
use fp_evm::WithdrawReason;
use frame_support::traits::{Currency, IsSubType};
pub use pallet::*;
-use pallet_evm::{EVMCurrencyAdapter, EnsureAddressOrigin};
+use pallet_evm::{EVMCurrencyAdapter, EnsureAddressOrigin, account::CrossAccountId};
use sp_core::{H160, U256};
use sp_runtime::TransactionOutcome;
use up_sponsorship::SponsorshipHandler;
@@ -35,11 +35,9 @@
use sp_std::vec::Vec;
#[pallet::config]
- pub trait Config: frame_system::Config {
+ pub trait Config: frame_system::Config + pallet_evm::account::Config {
type EvmSponsorshipHandler: SponsorshipHandler<Self::AccountId, (H160, Vec<u8>)>;
type Currency: Currency<Self::AccountId>;
- type EvmBackwardsAddressMapping: EvmBackwardsAddressMapping<Self::AccountId>;
- type EvmAddressMapping: AddressMapping<Self::AccountId>;
}
#[pallet::pallet]
@@ -86,14 +84,16 @@
type LiquidityInfo = Option<ChargeEvmLiquidityInfo<T>>;
fn withdraw_fee(
- who: &T::AccountId,
+ who: &T::CrossAccountId,
reason: WithdrawReason,
fee: U256,
) -> core::result::Result<Self::LiquidityInfo, pallet_evm::Error<T>> {
- let mut who_pays_fee = who.clone();
+ let who_pays_fee;
if let WithdrawReason::Call { target, input } = &reason {
- who_pays_fee = T::EvmSponsorshipHandler::get_sponsor(who, &(*target, input.clone()))
- .unwrap_or(who_pays_fee);
+ who_pays_fee = <T as pallet_evm::account::Config>::CrossAccountId::from_sub(T::EvmSponsorshipHandler::get_sponsor(&who.as_sub(), &(*target, input.clone()))
+ .unwrap_or(who.as_sub().clone()));
+ } else {
+ who_pays_fee = who.clone();
}
let negative_imbalance = EVMCurrencyAdapter::<<T as Config>::Currency, ()>::withdraw_fee(
@@ -102,20 +102,19 @@
fee,
)?;
- let who_pays_fee_eth = T::EvmBackwardsAddressMapping::from_account_id(who_pays_fee);
Ok(negative_imbalance.map(|i| ChargeEvmLiquidityInfo {
- who: who_pays_fee_eth,
+ who: who_pays_fee.as_eth().clone(),
negative_imbalance: i,
}))
}
fn correct_and_deposit_fee(
- who: &T::AccountId,
+ who: &T::CrossAccountId,
corrected_fee: U256,
already_withdrawn: Self::LiquidityInfo,
) {
<EVMCurrencyAdapter<<T as Config>::Currency, ()> as pallet_evm::OnChargeEVMTransaction<T>>::correct_and_deposit_fee(
- &already_withdrawn.as_ref().map(|e| T::EvmAddressMapping::into_account_id(e.who)).unwrap_or(who.clone()),
+ &already_withdrawn.as_ref().map(|e| T::CrossAccountId::from_eth(e.who)).unwrap_or(who.clone()),
corrected_fee,
already_withdrawn.map(|e| e.negative_imbalance),
)
pallets/fungible/Cargo.tomldiffbeforeafterboth--- a/pallets/fungible/Cargo.toml
+++ b/pallets/fungible/Cargo.toml
@@ -22,10 +22,10 @@
pallet-evm-coder-substrate = { default-features = false, path = '../evm-coder-substrate' }
ethereum = { version = "0.12.0", default-features = false }
frame-benchmarking = { default-features = false, optional = true, git = 'https://github.com/paritytech/substrate.git', branch = 'polkadot-v0.9.18' }
+pallet-evm = { default-features = false, git = "https://github.com/uniquenetwork/frontier.git", branch = "unique-polkadot-v0.9.18" }
scale-info = { version = "2.0.1", default-features = false, features = [
"derive",
] }
-frame-common = { default-features = false, git = "https://github.com/uniquenetwork/frontier.git", branch = "feature/300" }
[features]
default = ["std"]
@@ -40,5 +40,6 @@
"ethereum/std",
"pallet-evm-coder-substrate/std",
'frame-benchmarking/std',
+ "pallet-evm/std"
]
runtime-benchmarks = ['frame-benchmarking', 'pallet-common/runtime-benchmarks']
pallets/fungible/src/erc.rsdiffbeforeafterboth--- a/pallets/fungible/src/erc.rs
+++ b/pallets/fungible/src/erc.rs
@@ -21,7 +21,7 @@
use pallet_common::erc::{CommonEvmHandler, PrecompileResult};
use sp_core::{H160, U256};
use sp_std::vec::Vec;
-use frame_common::account::CrossAccountId;
+use pallet_evm::account::CrossAccountId;
use pallet_evm_coder_substrate::{call, dispatch_to_evm};
use crate::{
pallets/fungible/src/lib.rsdiffbeforeafterboth--- a/pallets/fungible/src/lib.rs
+++ b/pallets/fungible/src/lib.rs
@@ -22,7 +22,7 @@
use pallet_common::{
Error as CommonError, Event as CommonEvent, Pallet as PalletCommon,
};
-use frame_common::account::CrossAccountId;
+use pallet_evm::account::CrossAccountId;
use pallet_evm_coder_substrate::WithRecorder;
use sp_core::H160;
use sp_runtime::{ArithmeticError, DispatchError, DispatchResult};
@@ -37,7 +37,7 @@
pub mod erc;
pub mod weights;
-pub type CreateItemData<T> = (<T as pallet_common::Config>::CrossAccountId, u128);
+pub type CreateItemData<T> = (<T as pallet_evm::account::Config>::CrossAccountId, u128);
pub(crate) type SelfWeightOf<T> = <T as Config>::WeightInfo;
#[frame_support::pallet]
pallets/nonfungible/Cargo.tomldiffbeforeafterboth--- a/pallets/nonfungible/Cargo.toml
+++ b/pallets/nonfungible/Cargo.toml
@@ -16,6 +16,7 @@
sp-runtime = { default-features = false, git = 'https://github.com/paritytech/substrate.git', branch = 'polkadot-v0.9.18' }
sp-std = { default-features = false, git = 'https://github.com/paritytech/substrate.git', branch = 'polkadot-v0.9.18' }
sp-core = { default-features = false, git = 'https://github.com/paritytech/substrate.git', branch = 'polkadot-v0.9.18' }
+pallet-evm = { default-features = false, git = "https://github.com/uniquenetwork/frontier.git", branch = "unique-polkadot-v0.9.18" }
pallet-common = { default-features = false, path = '../common' }
up-data-structs = { default-features = false, path = '../../primitives/data-structs' }
evm-coder = { default-features = false, path = '../../crates/evm-coder' }
@@ -25,7 +26,6 @@
scale-info = { version = "2.0.1", default-features = false, features = [
"derive",
] }
-frame-common = { default-features = false, git = "https://github.com/uniquenetwork/frontier.git", branch = "feature/300" }
[features]
default = ["std"]
@@ -40,6 +40,7 @@
"ethereum/std",
"pallet-evm-coder-substrate/std",
'frame-benchmarking/std',
+ "pallet-evm/std"
]
runtime-benchmarks = [
'frame-benchmarking',
pallets/nonfungible/src/erc.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/erc.rs
+++ b/pallets/nonfungible/src/erc.rs
@@ -27,7 +27,7 @@
use pallet_common::{
erc::{CommonEvmHandler, PrecompileResult},
};
-use frame_common::account::CrossAccountId;
+use pallet_evm::account::CrossAccountId;
use pallet_evm_coder_substrate::call;
use crate::{
pallets/nonfungible/src/lib.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/lib.rs
+++ b/pallets/nonfungible/src/lib.rs
@@ -24,7 +24,7 @@
use pallet_common::{
Error as CommonError, Pallet as PalletCommon, Event as CommonEvent,
};
-use frame_common::account::CrossAccountId;
+use pallet_evm::account::CrossAccountId;
use pallet_evm_coder_substrate::{SubstrateRecorder, WithRecorder};
use sp_core::H160;
use sp_runtime::{ArithmeticError, DispatchError, DispatchResult};
@@ -41,7 +41,7 @@
pub mod erc;
pub mod weights;
-pub type CreateItemData<T> = CreateNftExData<<T as pallet_common::Config>::CrossAccountId>;
+pub type CreateItemData<T> = CreateNftExData<<T as pallet_evm::account::Config>::CrossAccountId>;
pub(crate) type SelfWeightOf<T> = <T as Config>::WeightInfo;
#[derive(Encode, Decode, TypeInfo, MaxEncodedLen)]
pallets/refungible/Cargo.tomldiffbeforeafterboth--- a/pallets/refungible/Cargo.toml
+++ b/pallets/refungible/Cargo.toml
@@ -16,13 +16,13 @@
sp-runtime = { default-features = false, git = 'https://github.com/paritytech/substrate.git', branch = 'polkadot-v0.9.18' }
sp-std = { default-features = false, git = 'https://github.com/paritytech/substrate.git', branch = 'polkadot-v0.9.18' }
sp-core = { default-features = false, git = 'https://github.com/paritytech/substrate.git', branch = 'polkadot-v0.9.18' }
+pallet-evm = { default-features = false, git = "https://github.com/uniquenetwork/frontier.git", branch = "unique-polkadot-v0.9.18" }
pallet-common = { default-features = false, path = '../common' }
up-data-structs = { default-features = false, path = '../../primitives/data-structs' }
frame-benchmarking = { default-features = false, optional = true, git = 'https://github.com/paritytech/substrate.git', branch = 'polkadot-v0.9.18' }
scale-info = { version = "2.0.1", default-features = false, features = [
"derive",
] }
-frame-common = { default-features = false, git = "https://github.com/uniquenetwork/frontier.git", branch = "feature/300" }
[features]
default = ["std"]
@@ -34,6 +34,7 @@
"up-data-structs/std",
"pallet-common/std",
'frame-benchmarking/std',
+ "pallet-evm/std",
]
runtime-benchmarks = [
'frame-benchmarking',
pallets/refungible/src/lib.rsdiffbeforeafterboth--- a/pallets/refungible/src/lib.rs
+++ b/pallets/refungible/src/lib.rs
@@ -24,7 +24,7 @@
use pallet_common::{
Error as CommonError, Event as CommonEvent, Pallet as PalletCommon,
};
-use frame_common::account::CrossAccountId;
+use pallet_evm::account::CrossAccountId;
use sp_runtime::{ArithmeticError, DispatchError, DispatchResult};
use sp_std::{vec::Vec, vec, collections::btree_map::BTreeMap};
use core::ops::Deref;
pallets/unique/Cargo.tomldiffbeforeafterboth--- a/pallets/unique/Cargo.toml
+++ b/pallets/unique/Cargo.toml
@@ -133,7 +133,6 @@
up-sponsorship = { version = "0.1.0", default-features = false, git = "https://github.com/UniqueNetwork/pallet-sponsoring", branch = 'polkadot-v0.9.18' }
up-evm-mapping = { default-features = false, git = "https://github.com/uniquenetwork/frontier.git", branch = "feature/300" }
-frame-common = { default-features = false, git = "https://github.com/uniquenetwork/frontier.git", branch = "feature/300" }
evm-coder = { default-features = false, path = "../../crates/evm-coder" }
pallet-evm-coder-substrate = { default-features = false, path = "../../pallets/evm-coder-substrate" }
primitive-types = { version = "0.11.1", default-features = false, features = [
pallets/unique/src/eth/sponsoring.rsdiffbeforeafterboth--- a/pallets/unique/src/eth/sponsoring.rs
+++ b/pallets/unique/src/eth/sponsoring.rs
@@ -25,7 +25,7 @@
use core::marker::PhantomData;
use core::convert::TryInto;
use up_data_structs::TokenId;
-use frame_common::account::CrossAccountId;
+use pallet_evm::account::CrossAccountId;
use pallet_nonfungible::erc::{UniqueNFTCall, ERC721UniqueExtensionsCall, ERC721Call};
use pallet_fungible::erc::{UniqueFungibleCall, ERC20Call};
pallets/unique/src/lib.rsdiffbeforeafterboth--- a/pallets/unique/src/lib.rs
+++ b/pallets/unique/src/lib.rs
@@ -57,7 +57,7 @@
CollectionHandle, Pallet as PalletCommon, Error as CommonError,
CommonWeightInfo,
};
-use frame_common::account::CrossAccountId;
+use pallet_evm::account::CrossAccountId;
use pallet_refungible::{Pallet as PalletRefungible, RefungibleHandle};
use pallet_fungible::{Pallet as PalletFungible, FungibleHandle};
use pallet_nonfungible::{Pallet as PalletNonfungible, NonfungibleHandle};
@@ -117,7 +117,7 @@
pub enum Event<T>
where
<T as frame_system::Config>::AccountId,
- <T as pallet_common::Config>::CrossAccountId,
+ <T as pallet_evm::account::Config>::CrossAccountId,
{
/// Collection sponsor was removed
///
pallets/unique/src/mock.rsdiffbeforeafterboth--- a/pallets/unique/src/mock.rs
+++ b/pallets/unique/src/mock.rs
@@ -27,7 +27,7 @@
use frame_system as system;
use pallet_evm::{AddressMapping, runner::stack::MaybeMirroredLog};
use up_evm_mapping::EvmBackwardsAddressMapping;
-use frame_common::account::CrossAccountId;
+use pallet_evm::account::CrossAccountId;
use codec::{Encode, Decode, MaxEncodedLen};
use scale_info::TypeInfo;
use up_data_structs::ConstU32;
@@ -192,15 +192,17 @@
impl pallet_common::Config for Test {
type Event = ();
- type EvmBackwardsAddressMapping = TestEvmBackwardsAddressMapping;
- type EvmAddressMapping = TestEvmAddressMapping;
- type CrossAccountId = TestCrossAccountId;
-
type Currency = Balances;
type CollectionCreationPrice = CollectionCreationPrice;
type TreasuryAccountId = TreasuryAccountId;
}
+impl pallet_evm::account::Config for Test {
+ type CrossAccountId = TestCrossAccountId;
+ type EvmAddressMapping = TestEvmAddressMapping;
+ type EvmBackwardsAddressMapping = TestEvmBackwardsAddressMapping;
+}
+
impl pallet_fungible::Config for Test {
type WeightInfo = ();
}
pallets/unique/src/sponsorship.rsdiffbeforeafterboth1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617use crate::{18 Config, Call, CreateItemBasket, VariableMetaDataBasket, ReFungibleTransferBasket,19 FungibleTransferBasket, NftTransferBasket, CreateItemData, CollectionMode, NftApproveBasket,20 FungibleApproveBasket, RefungibleApproveBasket,21};22use core::marker::PhantomData;23use up_sponsorship::SponsorshipHandler;24use frame_support::{25 traits::{IsSubType},26 storage::{StorageMap, StorageDoubleMap, StorageNMap},27};28use up_data_structs::{29 CollectionId, FUNGIBLE_SPONSOR_TRANSFER_TIMEOUT, MetaUpdatePermission,30 NFT_SPONSOR_TRANSFER_TIMEOUT, REFUNGIBLE_SPONSOR_TRANSFER_TIMEOUT, TokenId,31};32use pallet_common::{CollectionHandle};33use frame_common::account::CrossAccountId;3435pub fn withdraw_transfer<T: Config>(36 collection: &CollectionHandle<T>,37 who: &T::CrossAccountId,38 item_id: &TokenId,39) -> Option<()> {40 // preliminary sponsoring correctness check41 match collection.mode {42 CollectionMode::NFT => {43 let owner = pallet_nonfungible::TokenData::<T>::get((collection.id, item_id))?.owner;44 if !owner.conv_eq(who) {45 return None;46 }47 }48 CollectionMode::Fungible(_) => {49 if item_id != &TokenId::default() {50 return None;51 }52 if <pallet_fungible::Balance<T>>::get((collection.id, who)) == 0 {53 return None;54 }55 }56 CollectionMode::ReFungible => {57 if !<pallet_refungible::Owned<T>>::get((collection.id, who, item_id)) {58 return None;59 }60 }61 }6263 // sponsor timeout64 let block_number = <frame_system::Pallet<T>>::block_number() as T::BlockNumber;65 let limit = collection66 .limits67 .sponsor_transfer_timeout(match collection.mode {68 CollectionMode::NFT => NFT_SPONSOR_TRANSFER_TIMEOUT,69 CollectionMode::Fungible(_) => FUNGIBLE_SPONSOR_TRANSFER_TIMEOUT,70 CollectionMode::ReFungible => REFUNGIBLE_SPONSOR_TRANSFER_TIMEOUT,71 });7273 let last_tx_block = match collection.mode {74 CollectionMode::NFT => <NftTransferBasket<T>>::get(collection.id, item_id),75 CollectionMode::Fungible(_) => {76 <FungibleTransferBasket<T>>::get(collection.id, who.as_sub())77 }78 CollectionMode::ReFungible => {79 <ReFungibleTransferBasket<T>>::get((collection.id, item_id, who.as_sub()))80 }81 };8283 if let Some(last_tx_block) = last_tx_block {84 let timeout = last_tx_block + limit.into();85 if block_number < timeout {86 return None;87 }88 }8990 match collection.mode {91 CollectionMode::NFT => <NftTransferBasket<T>>::insert(collection.id, item_id, block_number),92 CollectionMode::Fungible(_) => {93 <FungibleTransferBasket<T>>::insert(collection.id, who.as_sub(), block_number)94 }95 CollectionMode::ReFungible => <ReFungibleTransferBasket<T>>::insert(96 (collection.id, item_id, who.as_sub()),97 block_number,98 ),99 };100101 Some(())102}103104pub fn withdraw_create_item<T: Config>(105 collection: &CollectionHandle<T>,106 who: &T::AccountId,107 _properties: &CreateItemData,108) -> Option<()> {109 if _properties.data_size() as u32 > collection.limits.sponsored_data_size() {110 return None;111 }112113 // sponsor timeout114 let block_number = <frame_system::Pallet<T>>::block_number() as T::BlockNumber;115 let limit = collection116 .limits117 .sponsor_transfer_timeout(match _properties {118 CreateItemData::NFT(_) => NFT_SPONSOR_TRANSFER_TIMEOUT,119 CreateItemData::Fungible(_) => FUNGIBLE_SPONSOR_TRANSFER_TIMEOUT,120 CreateItemData::ReFungible(_) => REFUNGIBLE_SPONSOR_TRANSFER_TIMEOUT,121 });122123 if let Some(last_tx_block) = <CreateItemBasket<T>>::get((collection.id, &who)) {124 let timeout = last_tx_block + limit.into();125 if block_number < timeout {126 return None;127 }128 }129130 CreateItemBasket::<T>::insert((collection.id, who.clone()), block_number);131132 Some(())133}134135pub fn withdraw_set_variable_meta_data<T: Config>(136 who: &T::CrossAccountId,137 collection: &CollectionHandle<T>,138 item_id: &TokenId,139 data: &[u8],140) -> Option<()> {141 // TODO: make it work for admins142 if collection.meta_update_permission != MetaUpdatePermission::ItemOwner {143 return None;144 }145 // preliminary sponsoring correctness check146 match collection.mode {147 CollectionMode::NFT => {148 let owner = pallet_nonfungible::TokenData::<T>::get((collection.id, item_id))?.owner;149 if !owner.conv_eq(who) {150 return None;151 }152 }153 CollectionMode::Fungible(_) => {154 if item_id != &TokenId::default() {155 return None;156 }157 if <pallet_fungible::Balance<T>>::get((collection.id, who)) == 0 {158 return None;159 }160 }161 CollectionMode::ReFungible => {162 if !<pallet_refungible::Owned<T>>::get((collection.id, who, item_id)) {163 return None;164 }165 }166 }167168 // Can't sponsor fungible collection, this tx will be rejected169 // as invalid170 if matches!(collection.mode, CollectionMode::Fungible(_)) {171 return None;172 }173 if data.len() > collection.limits.sponsored_data_size() as usize {174 return None;175 }176177 let block_number = <frame_system::Pallet<T>>::block_number() as T::BlockNumber;178 let limit = collection.limits.sponsored_data_rate_limit()?;179180 if let Some(last_tx_block) = VariableMetaDataBasket::<T>::get(collection.id, item_id) {181 let timeout = last_tx_block + limit.into();182 if block_number < timeout {183 return None;184 }185 }186187 <VariableMetaDataBasket<T>>::insert(collection.id, item_id, block_number);188189 Some(())190}191192pub fn withdraw_approve<T: Config>(193 collection: &CollectionHandle<T>,194 who: &T::AccountId,195 item_id: &TokenId,196) -> Option<()> {197 // sponsor timeout198 let block_number = <frame_system::Pallet<T>>::block_number() as T::BlockNumber;199 let limit = collection.limits.sponsor_approve_timeout();200201 let last_tx_block = match collection.mode {202 CollectionMode::NFT => <NftApproveBasket<T>>::get(collection.id, item_id),203 CollectionMode::Fungible(_) => <FungibleApproveBasket<T>>::get(collection.id, who),204 CollectionMode::ReFungible => {205 <RefungibleApproveBasket<T>>::get((collection.id, item_id, who))206 }207 };208209 if let Some(last_tx_block) = last_tx_block {210 let timeout = last_tx_block + limit.into();211 if block_number < timeout {212 return None;213 }214 }215216 match collection.mode {217 CollectionMode::NFT => <NftApproveBasket<T>>::insert(collection.id, item_id, block_number),218 CollectionMode::Fungible(_) => {219 <FungibleApproveBasket<T>>::insert(collection.id, who, block_number)220 }221 CollectionMode::ReFungible => {222 <RefungibleApproveBasket<T>>::insert((collection.id, item_id, who), block_number)223 }224 };225226 Some(())227}228229fn load<T: Config>(id: CollectionId) -> Option<(T::AccountId, CollectionHandle<T>)> {230 let collection = CollectionHandle::new(id)?;231 let sponsor = collection.sponsorship.sponsor().cloned()?;232 Some((sponsor, collection))233}234235pub struct UniqueSponsorshipHandler<T>(PhantomData<T>);236impl<T, C> SponsorshipHandler<T::AccountId, C> for UniqueSponsorshipHandler<T>237where238 T: Config,239 C: IsSubType<Call<T>>,240{241 fn get_sponsor(who: &T::AccountId, call: &C) -> Option<T::AccountId> {242 match IsSubType::<Call<T>>::is_sub_type(call)? {243 Call::create_item {244 collection_id,245 data,246 ..247 } => {248 let (sponsor, collection) = load(*collection_id)?;249 withdraw_create_item::<T>(&collection, who, data).map(|()| sponsor)250 }251 Call::transfer {252 collection_id,253 item_id,254 ..255 } => {256 let (sponsor, collection) = load(*collection_id)?;257 withdraw_transfer::<T>(258 &collection,259 &T::CrossAccountId::from_sub(who.clone()),260 item_id,261 )262 .map(|()| sponsor)263 }264 Call::transfer_from {265 collection_id,266 item_id,267 from,268 ..269 } => {270 let (sponsor, collection) = load(*collection_id)?;271 withdraw_transfer::<T>(&collection, from, item_id).map(|()| sponsor)272 }273 Call::approve {274 collection_id,275 item_id,276 ..277 } => {278 let (sponsor, collection) = load(*collection_id)?;279 withdraw_approve::<T>(&collection, who, item_id).map(|()| sponsor)280 }281 Call::set_variable_meta_data {282 collection_id,283 item_id,284 data,285 } => {286 let (sponsor, collection) = load(*collection_id)?;287 withdraw_set_variable_meta_data::<T>(288 &T::CrossAccountId::from_sub(who.clone()),289 &collection,290 item_id,291 data,292 )293 .map(|()| sponsor)294 }295 _ => None,296 }297 }298}1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617use crate::{18 Config, Call, CreateItemBasket, VariableMetaDataBasket, ReFungibleTransferBasket,19 FungibleTransferBasket, NftTransferBasket, CreateItemData, CollectionMode, NftApproveBasket,20 FungibleApproveBasket, RefungibleApproveBasket,21};22use core::marker::PhantomData;23use up_sponsorship::SponsorshipHandler;24use frame_support::{25 traits::{IsSubType},26 storage::{StorageMap, StorageDoubleMap, StorageNMap},27};28use up_data_structs::{29 CollectionId, FUNGIBLE_SPONSOR_TRANSFER_TIMEOUT, MetaUpdatePermission,30 NFT_SPONSOR_TRANSFER_TIMEOUT, REFUNGIBLE_SPONSOR_TRANSFER_TIMEOUT, TokenId,31};32use pallet_common::{CollectionHandle};33use pallet_evm::account::CrossAccountId;3435pub fn withdraw_transfer<T: Config>(36 collection: &CollectionHandle<T>,37 who: &T::CrossAccountId,38 item_id: &TokenId,39) -> Option<()> {40 // preliminary sponsoring correctness check41 match collection.mode {42 CollectionMode::NFT => {43 let owner = pallet_nonfungible::TokenData::<T>::get((collection.id, item_id))?.owner;44 if !owner.conv_eq(who) {45 return None;46 }47 }48 CollectionMode::Fungible(_) => {49 if item_id != &TokenId::default() {50 return None;51 }52 if <pallet_fungible::Balance<T>>::get((collection.id, who)) == 0 {53 return None;54 }55 }56 CollectionMode::ReFungible => {57 if !<pallet_refungible::Owned<T>>::get((collection.id, who, item_id)) {58 return None;59 }60 }61 }6263 // sponsor timeout64 let block_number = <frame_system::Pallet<T>>::block_number() as T::BlockNumber;65 let limit = collection66 .limits67 .sponsor_transfer_timeout(match collection.mode {68 CollectionMode::NFT => NFT_SPONSOR_TRANSFER_TIMEOUT,69 CollectionMode::Fungible(_) => FUNGIBLE_SPONSOR_TRANSFER_TIMEOUT,70 CollectionMode::ReFungible => REFUNGIBLE_SPONSOR_TRANSFER_TIMEOUT,71 });7273 let last_tx_block = match collection.mode {74 CollectionMode::NFT => <NftTransferBasket<T>>::get(collection.id, item_id),75 CollectionMode::Fungible(_) => {76 <FungibleTransferBasket<T>>::get(collection.id, who.as_sub())77 }78 CollectionMode::ReFungible => {79 <ReFungibleTransferBasket<T>>::get((collection.id, item_id, who.as_sub()))80 }81 };8283 if let Some(last_tx_block) = last_tx_block {84 let timeout = last_tx_block + limit.into();85 if block_number < timeout {86 return None;87 }88 }8990 match collection.mode {91 CollectionMode::NFT => <NftTransferBasket<T>>::insert(collection.id, item_id, block_number),92 CollectionMode::Fungible(_) => {93 <FungibleTransferBasket<T>>::insert(collection.id, who.as_sub(), block_number)94 }95 CollectionMode::ReFungible => <ReFungibleTransferBasket<T>>::insert(96 (collection.id, item_id, who.as_sub()),97 block_number,98 ),99 };100101 Some(())102}103104pub fn withdraw_create_item<T: Config>(105 collection: &CollectionHandle<T>,106 who: &T::AccountId,107 _properties: &CreateItemData,108) -> Option<()> {109 if _properties.data_size() as u32 > collection.limits.sponsored_data_size() {110 return None;111 }112113 // sponsor timeout114 let block_number = <frame_system::Pallet<T>>::block_number() as T::BlockNumber;115 let limit = collection116 .limits117 .sponsor_transfer_timeout(match _properties {118 CreateItemData::NFT(_) => NFT_SPONSOR_TRANSFER_TIMEOUT,119 CreateItemData::Fungible(_) => FUNGIBLE_SPONSOR_TRANSFER_TIMEOUT,120 CreateItemData::ReFungible(_) => REFUNGIBLE_SPONSOR_TRANSFER_TIMEOUT,121 });122123 if let Some(last_tx_block) = <CreateItemBasket<T>>::get((collection.id, &who)) {124 let timeout = last_tx_block + limit.into();125 if block_number < timeout {126 return None;127 }128 }129130 CreateItemBasket::<T>::insert((collection.id, who.clone()), block_number);131132 Some(())133}134135pub fn withdraw_set_variable_meta_data<T: Config>(136 who: &T::CrossAccountId,137 collection: &CollectionHandle<T>,138 item_id: &TokenId,139 data: &[u8],140) -> Option<()> {141 // TODO: make it work for admins142 if collection.meta_update_permission != MetaUpdatePermission::ItemOwner {143 return None;144 }145 // preliminary sponsoring correctness check146 match collection.mode {147 CollectionMode::NFT => {148 let owner = pallet_nonfungible::TokenData::<T>::get((collection.id, item_id))?.owner;149 if !owner.conv_eq(who) {150 return None;151 }152 }153 CollectionMode::Fungible(_) => {154 if item_id != &TokenId::default() {155 return None;156 }157 if <pallet_fungible::Balance<T>>::get((collection.id, who)) == 0 {158 return None;159 }160 }161 CollectionMode::ReFungible => {162 if !<pallet_refungible::Owned<T>>::get((collection.id, who, item_id)) {163 return None;164 }165 }166 }167168 // Can't sponsor fungible collection, this tx will be rejected169 // as invalid170 if matches!(collection.mode, CollectionMode::Fungible(_)) {171 return None;172 }173 if data.len() > collection.limits.sponsored_data_size() as usize {174 return None;175 }176177 let block_number = <frame_system::Pallet<T>>::block_number() as T::BlockNumber;178 let limit = collection.limits.sponsored_data_rate_limit()?;179180 if let Some(last_tx_block) = VariableMetaDataBasket::<T>::get(collection.id, item_id) {181 let timeout = last_tx_block + limit.into();182 if block_number < timeout {183 return None;184 }185 }186187 <VariableMetaDataBasket<T>>::insert(collection.id, item_id, block_number);188189 Some(())190}191192pub fn withdraw_approve<T: Config>(193 collection: &CollectionHandle<T>,194 who: &T::AccountId,195 item_id: &TokenId,196) -> Option<()> {197 // sponsor timeout198 let block_number = <frame_system::Pallet<T>>::block_number() as T::BlockNumber;199 let limit = collection.limits.sponsor_approve_timeout();200201 let last_tx_block = match collection.mode {202 CollectionMode::NFT => <NftApproveBasket<T>>::get(collection.id, item_id),203 CollectionMode::Fungible(_) => <FungibleApproveBasket<T>>::get(collection.id, who),204 CollectionMode::ReFungible => {205 <RefungibleApproveBasket<T>>::get((collection.id, item_id, who))206 }207 };208209 if let Some(last_tx_block) = last_tx_block {210 let timeout = last_tx_block + limit.into();211 if block_number < timeout {212 return None;213 }214 }215216 match collection.mode {217 CollectionMode::NFT => <NftApproveBasket<T>>::insert(collection.id, item_id, block_number),218 CollectionMode::Fungible(_) => {219 <FungibleApproveBasket<T>>::insert(collection.id, who, block_number)220 }221 CollectionMode::ReFungible => {222 <RefungibleApproveBasket<T>>::insert((collection.id, item_id, who), block_number)223 }224 };225226 Some(())227}228229fn load<T: Config>(id: CollectionId) -> Option<(T::AccountId, CollectionHandle<T>)> {230 let collection = CollectionHandle::new(id)?;231 let sponsor = collection.sponsorship.sponsor().cloned()?;232 Some((sponsor, collection))233}234235pub struct UniqueSponsorshipHandler<T>(PhantomData<T>);236impl<T, C> SponsorshipHandler<T::AccountId, C> for UniqueSponsorshipHandler<T>237where238 T: Config,239 C: IsSubType<Call<T>>,240{241 fn get_sponsor(who: &T::AccountId, call: &C) -> Option<T::AccountId> {242 match IsSubType::<Call<T>>::is_sub_type(call)? {243 Call::create_item {244 collection_id,245 data,246 ..247 } => {248 let (sponsor, collection) = load(*collection_id)?;249 withdraw_create_item::<T>(&collection, who, data).map(|()| sponsor)250 }251 Call::transfer {252 collection_id,253 item_id,254 ..255 } => {256 let (sponsor, collection) = load(*collection_id)?;257 withdraw_transfer::<T>(258 &collection,259 &T::CrossAccountId::from_sub(who.clone()),260 item_id,261 )262 .map(|()| sponsor)263 }264 Call::transfer_from {265 collection_id,266 item_id,267 from,268 ..269 } => {270 let (sponsor, collection) = load(*collection_id)?;271 withdraw_transfer::<T>(&collection, from, item_id).map(|()| sponsor)272 }273 Call::approve {274 collection_id,275 item_id,276 ..277 } => {278 let (sponsor, collection) = load(*collection_id)?;279 withdraw_approve::<T>(&collection, who, item_id).map(|()| sponsor)280 }281 Call::set_variable_meta_data {282 collection_id,283 item_id,284 data,285 } => {286 let (sponsor, collection) = load(*collection_id)?;287 withdraw_set_variable_meta_data::<T>(288 &T::CrossAccountId::from_sub(who.clone()),289 &collection,290 item_id,291 data,292 )293 .map(|()| sponsor)294 }295 _ => None,296 }297 }298}primitives/rpc/src/lib.rsdiffbeforeafterboth--- a/primitives/rpc/src/lib.rs
+++ b/primitives/rpc/src/lib.rs
@@ -28,7 +28,7 @@
#[api_version(2)]
pub trait UniqueApi<CrossAccountId, AccountId> where
AccountId: Decode,
- CrossAccountId: frame_common::account::CrossAccountId<AccountId>,
+ CrossAccountId: pallet_evm::account::CrossAccountId<AccountId>,
{
#[changed_in(2)]
fn token_owner(collection: CollectionId, token: TokenId) -> Result<CrossAccountId>;
runtime/opal/src/lib.rsdiffbeforeafterboth--- a/runtime/opal/src/lib.rs
+++ b/runtime/opal/src/lib.rs
@@ -127,6 +127,22 @@
}
}
+/// The type for looking up accounts. We don't expect more than 4 billion of them, but you
+/// never know...
+pub type AccountIndex = u32;
+
+/// Balance of an account.
+pub type Balance = u128;
+
+/// Index of a transaction in the chain.
+pub type Index = u32;
+
+/// A hash of some data used by the chain.
+pub type Hash = sp_core::H256;
+
+/// Digest item type.
+pub type DigestItem = generic::DigestItem;
+
/// Opaque types. These are used by the CLI to instantiate machinery that don't need to know
/// the specifics of the runtime. They can then be made to be agnostic over specific formats
/// of data like extrinsics, allowing for them to continue syncing the network through upgrades
@@ -256,6 +272,12 @@
}
}
+impl pallet_evm::account::Config for Runtime {
+ type CrossAccountId = pallet_evm::account::BasicCrossAccountId<Self>;
+ type EvmAddressMapping = pallet_evm::HashedAddressMapping<Self::Hashing>;
+ type EvmBackwardsAddressMapping = up_evm_mapping::MapBackwardsAddressTruncated;
+}
+
impl pallet_evm::Config for Runtime {
type BlockGasLimit = BlockGasLimit;
type FeeCalculator = FixedFee;
@@ -283,11 +305,6 @@
impl pallet_evm_migration::Config for Runtime {
type WeightInfo = pallet_evm_migration::weights::SubstrateWeight<Self>;
-}
-
-impl frame_common::account::Config for Runtime {
- type EvmAddressMapping = pallet_evm::HashedAddressMapping<Self::Hashing>;
- type EvmBackwardsAddressMapping = up_evm_mapping::MapBackwardsAddressTruncated;
}
pub struct EthereumFindAuthor<F>(core::marker::PhantomData<F>);
@@ -848,10 +865,6 @@
impl pallet_common::Config for Runtime {
type Event = Event;
- type EvmBackwardsAddressMapping = up_evm_mapping::MapBackwardsAddressTruncated;
- type EvmAddressMapping = HashedAddressMapping<Self::Hashing>;
- type CrossAccountId = frame_common::account::BasicCrossAccountId<Self>;
-
type Currency = Balances;
type CollectionCreationPrice = CollectionCreationPrice;
type TreasuryAccountId = TreasuryAccountId;
@@ -915,8 +928,6 @@
impl pallet_evm_transaction_payment::Config for Runtime {
type EvmSponsorshipHandler = EvmSponsorshipHandler;
type Currency = Balances;
- type EvmAddressMapping = HashedAddressMapping<Self::Hashing>;
- type EvmBackwardsAddressMapping = up_evm_mapping::MapBackwardsAddressTruncated;
}
impl pallet_charge_transaction::Config for Runtime {