git.delta.rocks / unique-network / refs/commits / d0064f7b27d6

difftreelog

Merge pull request #152 from UniqueNetwork/sbp-m2-review

usetech-llc2021-07-27parents: #40e660f #4b9c21e.patch.diff
in: master
SBP M2 review

1 file changed

modifiedpallets/inflation/src/tests.rsdiffbeforeafterboth
89 type InflationBlockInterval = InflationBlockInterval;89 type InflationBlockInterval = InflationBlockInterval;
90}90}
9191
92// Build genesis storage according to the mock runtime.
93pub fn new_test_ext() -> sp_io::TestExternalities {92pub fn new_test_ext() -> sp_io::TestExternalities {
94 frame_system::GenesisConfig::default()93 frame_system::GenesisConfig::default()
95 .build_storage::<Test>()94 .build_storage::<Test>()
105 let _ = <Balances as Currency<_>>::deposit_creating(&1234, initial_issuance);104 let _ = <Balances as Currency<_>>::deposit_creating(&1234, initial_issuance);
106 assert_eq!(Balances::free_balance(1234), initial_issuance);105 assert_eq!(Balances::free_balance(1234), initial_issuance);
107106
108 // BlockInflation should be set after 1st block and 107 // BlockInflation should be set after 1st block and
109 // first inflation deposit should be equal to BlockInflation108 // first inflation deposit should be equal to BlockInflation
110 Inflation::on_initialize(1);109 Inflation::on_initialize(1);
110
111 // SBP M2 review: Verify expected block inflation for year 1
111 assert!(Inflation::block_inflation() > 0);112 assert_eq!(Inflation::block_inflation(), 1901);
112 assert_eq!(Balances::free_balance(1234) - initial_issuance, Inflation::block_inflation());113 assert_eq!(
114 Balances::free_balance(1234) - initial_issuance,
115 Inflation::block_inflation()
152 Inflation::on_initialize(1);156 Inflation::on_initialize(1);
153 let block_inflation_year_0 = Inflation::block_inflation();157 let block_inflation_year_0 = Inflation::block_inflation();
158
159 // SBP M2 review: go through all the block inflations for year 1,
160 // total issuance will be updated accordingly
161 for block in (100..YEAR).step_by(100) {
162 Inflation::on_initialize(block);
163 }
164 assert_eq!(
165 initial_issuance + (1901 * (YEAR / 100)),
166 <Balances as Currency<_>>::total_issuance()
167 );
154168
155 Inflation::on_initialize(YEAR);169 Inflation::on_initialize(YEAR);
156 let block_inflation_year_1 = Inflation::block_inflation();170 let block_inflation_year_1 = Inflation::block_inflation();
157171 // SBP M2 review: Verify expected block inflation for year 2
158 // Assert that year 1 inflation is less than year 0
159 assert!(block_inflation_year_0 > block_inflation_year_1);172 assert_eq!(block_inflation_year_1, 1952);
173
174 // SBP M2 review: this is actually not true
175 // Assert that year 1 inflation is less than year 0
176 // assert!(block_inflation_year_0 > block_inflation_year_1);
160 });177 });
161}178}
162179
174 Inflation::on_initialize(YEAR * year);191 Inflation::on_initialize(YEAR * year);
175 let block_inflation_year_after = Inflation::block_inflation();192 let block_inflation_year_after = Inflation::block_inflation();
176193
194 // SBP M2 review: this is actually not true (not for the first few years)
177 // Assert that next year inflation is less than previous year inflation195 // Assert that next year inflation is less than previous year inflation
178 assert!(block_inflation_year_before > block_inflation_year_after);196 assert!(block_inflation_year_before > block_inflation_year_after);
179 }197 }