difftreelog
fix enable draft mode fot nodes only tests
in: master
1 file changed
.github/workflows/nodes-only-update.ymldiffbeforeafterboth7777787879 steps:79 steps:80# - name: Skip if pull request is in Draft80 - name: Skip if pull request is in Draft81 # `if: github.event.pull_request.draft == true` should be kept here, at81 # `if: github.event.pull_request.draft == true` should be kept here, at82 # the step level, rather than at the job level. The latter is not82 # the step level, rather than at the job level. The latter is not83 # recommended because when the PR is moved from "Draft" to "Ready to83 # recommended because when the PR is moved from "Draft" to "Ready to84 # review" the workflow will immediately be passing (since it was skipped),84 # review" the workflow will immediately be passing (since it was skipped),85 # even though it hasn't actually ran, since it takes a few seconds for85 # even though it hasn't actually ran, since it takes a few seconds for86 # the workflow to start. This is also disclosed in:86 # the workflow to start. This is also disclosed in:87 # https://github.community/t/dont-run-actions-on-draft-pull-requests/16817/1787 # https://github.community/t/dont-run-actions-on-draft-pull-requests/16817/1788 # That scenario would open an opportunity for the check to be bypassed:88 # That scenario would open an opportunity for the check to be bypassed:89 # 1. Get your PR approved89 # 1. Get your PR approved90 # 2. Move it to Draft90 # 2. Move it to Draft91 # 3. Push whatever commits you want91 # 3. Push whatever commits you want92 # 4. Move it to "Ready for review"; now the workflow is passing (it was92 # 4. Move it to "Ready for review"; now the workflow is passing (it was93 # skipped) and "Check reviews" is also passing (it won't be updated93 # skipped) and "Check reviews" is also passing (it won't be updated94 # until the workflow is finished)94 # until the workflow is finished)95# if: github.event.pull_request.draft == true95 if: github.event.pull_request.draft == true96# run: exit 196 run: exit 1979798 - name: Clean Workspace98 - name: Clean Workspace99 uses: AutoModality/action-clean@v1.1.099 uses: AutoModality/action-clean@v1.1.0