difftreelog
feat(collator-selection) benchmarks for collator-selection and data-management + cargo fmt
in: master
21 files changed
Makefilediffbeforeafterboth--- a/Makefile
+++ b/Makefile
@@ -127,16 +127,16 @@
.PHONY: bench-foreign-assets
bench-foreign-assets:
- make _bench PALLET=foreign-assets
+ make _bench PALLET=foreign-assets
+
+.PHONY: bench-collator-selection
+bench-collator-selection:
+ make _bench PALLET=collator-selection
.PHONY: bench-app-promotion
bench-app-promotion:
make _bench PALLET=app-promotion PALLET_DIR=app-promotion
.PHONY: bench
-<<<<<<< HEAD
-bench: bench-data-management bench-unique bench-structure bench-fungible bench-refungible bench-nonfungible bench-scheduler bench-rmrk-core bench-rmrk-equip bench-foreign-assets
-=======
# Disabled: bench-scheduler, bench-rmrk-core, bench-rmrk-equip
-bench: bench-evm-migration bench-unique bench-structure bench-fungible bench-refungible bench-nonfungible bench-foreign-assets
->>>>>>> develop
+bench: bench-data-management bench-unique bench-structure bench-fungible bench-refungible bench-nonfungible bench-foreign-assets
pallets/collator-selection/src/benchmarking.rsdiffbeforeafterboth--- a/pallets/collator-selection/src/benchmarking.rs
+++ b/pallets/collator-selection/src/benchmarking.rs
@@ -45,10 +45,15 @@
use frame_system::{EventRecord, RawOrigin};
use pallet_authorship::EventHandler;
use pallet_session::{self as session, SessionManager};
+use pallet_configuration::{
+ self as configuration, BalanceOf,
+ CollatorSelectionDesiredCollatorsOverride as DesiredCollators,
+ CollatorSelectionLicenseBondOverride as LicenseBond,
+};
use sp_std::prelude::*;
-pub type BalanceOf<T> =
- <<T as Config>::Currency as Currency<<T as frame_system::Config>::AccountId>>::Balance;
+/*pub type BalanceOf<T> =
+<<T as Config>::Currency as Currency<<T as frame_system::Config>::AccountId>>::Balance;*/
const SEED: u32 = 0;
@@ -111,7 +116,7 @@
validators.into_iter().map(|(who, _)| who).collect()
}
-fn register_candidates<T: Config>(count: u32) {
+fn register_candidates<T: Config + configuration::Config>(count: u32) {
let candidates = (0..count)
.map(|c| account("candidate", c, SEED))
.collect::<Vec<_>>();
@@ -122,27 +127,44 @@
for who in candidates {
T::Currency::make_free_balance_be(&who, <LicenseBond<T>>::get() * 2u32.into());
- <CollatorSelection<T>>::register_as_candidate(RawOrigin::Signed(who).into()).unwrap();
+ <CollatorSelection<T>>::get_license(RawOrigin::Signed(who.clone()).into()).unwrap();
+ <CollatorSelection<T>>::onboard(RawOrigin::Signed(who).into()).unwrap();
}
}
benchmarks! {
- where_clause { where T: pallet_authorship::Config + session::Config }
+ where_clause { where T: pallet_authorship::Config + session::Config + configuration::Config }
+
+ add_invulnerable {
+ let b in 1 .. T::MaxCollators::get();
+ let new_invulnerable = register_validators::<T>(b)[0].clone();
+ let origin = T::UpdateOrigin::successful_origin();
+ }: {
+ assert_ok!(
+ <CollatorSelection<T>>::add_invulnerable(origin, new_invulnerable.clone())
+ );
+ }
+ verify {
+ assert_last_event::<T>(Event::InvulnerableAdded{invulnerable: new_invulnerable}.into());
+ }
- set_invulnerables {
+ remove_invulnerable {
let b in 1 .. T::MaxCollators::get();
- let new_invulnerables = register_validators::<T>(b);
+ let new_invulnerable = register_validators::<T>(b)[0].clone();
let origin = T::UpdateOrigin::successful_origin();
+ assert_ok!(
+ <CollatorSelection<T>>::add_invulnerable(origin.clone(), new_invulnerable.clone())
+ );
}: {
assert_ok!(
- <CollatorSelection<T>>::set_invulnerables(origin, new_invulnerables.clone())
+ <CollatorSelection<T>>::remove_invulnerable(origin, new_invulnerable.clone())
);
}
verify {
- assert_last_event::<T>(Event::NewInvulnerables{invulnerables: new_invulnerables}.into());
+ assert_last_event::<T>(Event::InvulnerableRemoved{invulnerable: new_invulnerable}.into());
}
- set_desired_collators {
+ /*set_desired_collators {
let max: u32 = 999;
let origin = T::UpdateOrigin::successful_origin();
}: {
@@ -164,11 +186,9 @@
}
verify {
assert_last_event::<T>(Event::NewLicenseBond{bond_amount}.into());
- }
+ }*/
- // worse case is when we have all the max-candidate slots filled except one, and we fill that
- // one.
- register_as_candidate {
+ get_license {
let c in 1 .. T::MaxCollators::get();
<LicenseBond<T>>::put(T::Currency::minimum_balance());
@@ -189,27 +209,96 @@
}: _(RawOrigin::Signed(caller.clone()))
verify {
- assert_last_event::<T>(Event::CandidateAdded{account_id: caller, deposit: bond / 2u32.into()}.into());
+ assert_last_event::<T>(Event::LicenseObtained{account_id: caller, deposit: bond / 2u32.into()}.into());
}
- // worse case is the last candidate leaving.
- leave_intent {
- let c in (T::MinCandidates::get() + 1) .. T::MaxCollators::get();
+ // worst case is when we have all the max-candidate slots filled except one, and we fill that
+ // one.
+ onboard {
+ let c in 1 .. T::MaxCollators::get();
+
<LicenseBond<T>>::put(T::Currency::minimum_balance());
+ <DesiredCollators<T>>::put(c + 1);
+
+ register_validators::<T>(c);
+ register_candidates::<T>(c);
+
+ let caller: T::AccountId = whitelisted_caller();
+ let bond: BalanceOf<T> = T::Currency::minimum_balance() * 2u32.into();
+ T::Currency::make_free_balance_be(&caller, bond.clone());
+
+ let origin = RawOrigin::Signed(caller.clone());
+
+ <session::Pallet<T>>::set_keys(
+ origin.clone().into(),
+ keys::<T>(c + 1),
+ Vec::new()
+ ).unwrap();
+
+ assert_ok!(
+ <CollatorSelection<T>>::get_license(origin.clone().into())
+ );
+ }: _(origin)
+ verify {
+ assert_last_event::<T>(Event::CandidateAdded{account_id: caller}.into());
+ }
+
+ // worst case is the last candidate leaving.
+ offboard {
+ let c in 1 .. T::MaxCollators::get();
+ <LicenseBond<T>>::put(T::Currency::minimum_balance());
<DesiredCollators<T>>::put(c);
register_validators::<T>(c);
register_candidates::<T>(c);
- let leaving = <Candidates<T>>::get().last().unwrap().who.clone();
+ let leaving = <Candidates<T>>::get().last().unwrap().clone();
whitelist!(leaving);
}: _(RawOrigin::Signed(leaving.clone()))
verify {
- // todo:collator verify these
- assert_last_event::<T>(Event::CandidateRemoved{account_id: leaving, deposit_returned: bond / 2u32.into() }.into());
+ assert_last_event::<T>(Event::CandidateRemoved{account_id: leaving}.into());
}
- // worse case is paying a non-existing candidate account.
+ // worst case is the last candidate leaving.
+ release_license {
+ let c in 1 .. T::MaxCollators::get();
+ let bond = T::Currency::minimum_balance();
+ <LicenseBond<T>>::put(bond);
+ <DesiredCollators<T>>::put(c);
+
+ register_validators::<T>(c);
+ register_candidates::<T>(c);
+
+ let leaving = <Candidates<T>>::get().last().unwrap().clone();
+ whitelist!(leaving);
+ }: _(RawOrigin::Signed(leaving.clone()))
+ verify {
+ assert_last_event::<T>(Event::LicenseReleased{account_id: leaving, deposit_returned: bond}.into());
+ }
+
+ // worst case is the last candidate leaving.
+ force_release_license {
+ let c in 1 .. T::MaxCollators::get();
+ let bond = T::Currency::minimum_balance();
+ <LicenseBond<T>>::put(bond);
+ <DesiredCollators<T>>::put(c);
+
+ register_validators::<T>(c);
+ register_candidates::<T>(c);
+
+ let leaving = <Candidates<T>>::get().last().unwrap().clone();
+ whitelist!(leaving);
+ let origin = T::UpdateOrigin::successful_origin();
+ }: {
+ assert_ok!(
+ <CollatorSelection<T>>::force_release_license(origin, leaving.clone())
+ );
+ }
+ verify {
+ assert_last_event::<T>(Event::LicenseReleased{account_id: leaving, deposit_returned: bond}.into());
+ }
+
+ // worst case is paying a non-existing candidate account.
note_author {
<LicenseBond<T>>::put(T::Currency::minimum_balance());
T::Currency::make_free_balance_be(
@@ -247,16 +336,16 @@
let non_removals = c.saturating_sub(r);
for i in 0..c {
- <LastAuthoredBlock<T>>::insert(candidates[i as usize].who.clone(), zero_block);
+ <LastAuthoredBlock<T>>::insert(candidates[i as usize].clone(), zero_block);
}
if non_removals > 0 {
for i in 0..non_removals {
- <LastAuthoredBlock<T>>::insert(candidates[i as usize].who.clone(), new_block);
+ <LastAuthoredBlock<T>>::insert(candidates[i as usize].clone(), new_block);
}
} else {
for i in 0..c {
- <LastAuthoredBlock<T>>::insert(candidates[i as usize].who.clone(), new_block);
+ <LastAuthoredBlock<T>>::insert(candidates[i as usize].clone(), new_block);
}
}
@@ -268,10 +357,8 @@
}: {
<CollatorSelection<T> as SessionManager<_>>::new_session(0)
} verify {
- if c > r && non_removals >= T::MinCandidates::get() {
+ if c > r {
assert!(<Candidates<T>>::get().len() < pre_length);
- } else if c > r && non_removals < T::MinCandidates::get() {
- assert!(<Candidates<T>>::get().len() == T::MinCandidates::get() as usize);
} else {
assert!(<Candidates<T>>::get().len() == pre_length);
}
pallets/collator-selection/src/lib.rsdiffbeforeafterboth--- a/pallets/collator-selection/src/lib.rs
+++ b/pallets/collator-selection/src/lib.rs
@@ -235,7 +235,7 @@
account_id: T::AccountId,
deposit: BalanceOf<T>,
},
- LicenseForfeited {
+ LicenseReleased {
account_id: T::AccountId,
deposit_returned: BalanceOf<T>,
},
@@ -285,7 +285,7 @@
impl<T: Config> Pallet<T> {
/// Add a collator to the list of invulnerable (fixed) collators.
#[pallet::call_index(0)]
- #[pallet::weight(T::WeightInfo::set_invulnerables(1u32))] // todo:collator weight
+ #[pallet::weight(T::WeightInfo::add_invulnerable(T::MaxCollators::get()))] // todo:collator weight
pub fn add_invulnerable(
origin: OriginFor<T>,
new: T::AccountId,
@@ -315,7 +315,7 @@
/// Remove a collator from the list of invulnerable (fixed) collators.
#[pallet::call_index(1)]
- #[pallet::weight(T::WeightInfo::set_invulnerables(1))] // todo:collator weight
+ #[pallet::weight(T::WeightInfo::remove_invulnerable(T::MaxCollators::get()))] // todo:collator weight
pub fn remove_invulnerable(
origin: OriginFor<T>,
who: T::AccountId,
@@ -344,7 +344,7 @@
///
/// This call is not available to `Invulnerable` collators.
#[pallet::call_index(2)]
- #[pallet::weight(T::WeightInfo::register_as_candidate(T::MaxCollators::get()))] // todo:collator weight
+ #[pallet::weight(T::WeightInfo::get_license(T::MaxCollators::get()))] // todo:collator weight
pub fn get_license(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
// register_as_candidate
let who = ensure_signed(origin)?;
@@ -377,7 +377,7 @@
///
/// This call is not available to `Invulnerable` collators.
#[pallet::call_index(3)]
- #[pallet::weight(T::WeightInfo::register_as_candidate(T::MaxCollators::get()))] // todo:collator weight
+ #[pallet::weight(T::WeightInfo::onboard(T::MaxCollators::get()))] // todo:collator weight
pub fn onboard(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
// register_as_candidate
let who = ensure_signed(origin)?;
@@ -417,33 +417,33 @@
})?;
Self::deposit_event(Event::CandidateAdded { account_id: who });
- Ok(Some(T::WeightInfo::register_as_candidate(current_count as u32)).into())
+ Ok(Some(T::WeightInfo::onboard(current_count as u32)).into())
}
/// Deregister `origin` as a collator candidate. Note that the collator can only leave on
/// session change. The license to `onboard` later at any other time will remain.
#[pallet::call_index(4)]
- #[pallet::weight(T::WeightInfo::leave_intent(T::MaxCollators::get()))] // todo:collator weight
+ #[pallet::weight(T::WeightInfo::offboard(T::MaxCollators::get()))] // todo:collator weight
pub fn offboard(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
// leave_intent
let who = ensure_signed(origin)?;
let current_count = Self::try_remove_candidate(&who)?;
- Ok(Some(T::WeightInfo::leave_intent(current_count as u32)).into()) // todo:collator weight
+ Ok(Some(T::WeightInfo::offboard(current_count as u32)).into()) // todo:collator weight
}
/// Forfeit `origin`'s own license. The `LicenseBond` will be unreserved immediately.
///
/// This call is not available to `Invulnerable` collators.
#[pallet::call_index(5)]
- #[pallet::weight(T::WeightInfo::leave_intent(T::MaxCollators::get()))] // todo:collator weight
+ #[pallet::weight(T::WeightInfo::release_license(T::MaxCollators::get()))] // todo:collator weight
pub fn release_license(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
// leave_intent
let who = ensure_signed(origin)?;
let current_count = Self::try_remove_candidate_and_release_license(&who, false, true)?;
- Ok(Some(T::WeightInfo::leave_intent(current_count as u32)).into()) // todo:collator weight
+ Ok(Some(T::WeightInfo::release_license(current_count as u32)).into()) // todo:collator weight
}
/// Force deregister `origin` as a collator candidate as a governing authority, and revoke its license.
@@ -452,7 +452,7 @@
///
/// This call is, of course, not applicable to `Invulnerable` collators.
#[pallet::call_index(6)]
- #[pallet::weight(T::WeightInfo::leave_intent(T::MaxCollators::get()))] // todo:collator weight
+ #[pallet::weight(T::WeightInfo::force_release_license(T::MaxCollators::get()))] // todo:collator weight
pub fn force_release_license(
origin: OriginFor<T>,
who: T::AccountId,
@@ -462,7 +462,7 @@
let current_count = Self::try_remove_candidate_and_release_license(&who, false, true)?;
- Ok(Some(T::WeightInfo::leave_intent(current_count as u32)).into()) // todo:collator weight
+ Ok(Some(T::WeightInfo::force_release_license(current_count as u32)).into()) // todo:collator weight
}
}
@@ -534,7 +534,7 @@
Err(Error::<T>::NoLicense.into())
}
})?;
- Self::deposit_event(Event::LicenseForfeited {
+ Self::deposit_event(Event::LicenseReleased {
account_id: who.clone(),
deposit_returned,
});
pallets/collator-selection/src/weights.rsdiffbeforeafterboth--- a/pallets/collator-selection/src/weights.rs
+++ b/pallets/collator-selection/src/weights.rs
@@ -44,11 +44,13 @@
// todo:collator re-generate weights
// The weight info trait for `pallet_collator_selection`.
pub trait WeightInfo {
- fn set_invulnerables(_b: u32) -> Weight;
- fn set_desired_collators() -> Weight;
- fn set_license_bond() -> Weight;
- fn register_as_candidate(_c: u32) -> Weight;
- fn leave_intent(_c: u32) -> Weight;
+ fn add_invulnerable(_b: u32) -> Weight;
+ fn remove_invulnerable(_b: u32) -> Weight;
+ fn get_license(_c: u32) -> Weight;
+ fn onboard(_c: u32) -> Weight;
+ fn offboard(_c: u32) -> Weight;
+ fn release_license(_c: u32) -> Weight;
+ fn force_release_license(_c: u32) -> Weight;
fn note_author() -> Weight;
fn new_session(_c: u32, _r: u32) -> Weight;
}
@@ -56,26 +58,47 @@
/// Weights for pallet_collator_selection using the Substrate node and recommended hardware.
pub struct SubstrateWeight<T>(PhantomData<T>);
impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
- fn set_invulnerables(b: u32) -> Weight {
+ fn add_invulnerable(b: u32) -> Weight {
Weight::from_ref_time(18_563_000 as u64)
// Standard Error: 0
.saturating_add(Weight::from_ref_time(68_000 as u64).saturating_mul(b as u64))
.saturating_add(T::DbWeight::get().writes(1 as u64))
}
- fn set_desired_collators() -> Weight {
- Weight::from_ref_time(16_363_000 as u64).saturating_add(T::DbWeight::get().writes(1 as u64))
+ fn remove_invulnerable(b: u32) -> Weight {
+ Weight::from_ref_time(18_563_000 as u64)
+ // Standard Error: 0
+ .saturating_add(Weight::from_ref_time(68_000 as u64).saturating_mul(b as u64))
+ .saturating_add(T::DbWeight::get().writes(1 as u64))
}
- fn set_license_bond() -> Weight {
- Weight::from_ref_time(16_840_000 as u64).saturating_add(T::DbWeight::get().writes(1 as u64))
+ fn get_license(c: u32) -> Weight {
+ Weight::from_ref_time(71_196_000 as u64)
+ // Standard Error: 0
+ .saturating_add(Weight::from_ref_time(198_000 as u64).saturating_mul(c as u64))
+ .saturating_add(T::DbWeight::get().reads(4 as u64))
+ .saturating_add(T::DbWeight::get().writes(2 as u64))
}
- fn register_as_candidate(c: u32) -> Weight {
+ fn onboard(c: u32) -> Weight {
Weight::from_ref_time(71_196_000 as u64)
// Standard Error: 0
.saturating_add(Weight::from_ref_time(198_000 as u64).saturating_mul(c as u64))
.saturating_add(T::DbWeight::get().reads(4 as u64))
.saturating_add(T::DbWeight::get().writes(2 as u64))
}
- fn leave_intent(c: u32) -> Weight {
+ fn offboard(c: u32) -> Weight {
+ Weight::from_ref_time(55_336_000 as u64)
+ // Standard Error: 0
+ .saturating_add(Weight::from_ref_time(151_000 as u64).saturating_mul(c as u64))
+ .saturating_add(T::DbWeight::get().reads(1 as u64))
+ .saturating_add(T::DbWeight::get().writes(2 as u64))
+ }
+ fn release_license(c: u32) -> Weight {
+ Weight::from_ref_time(55_336_000 as u64)
+ // Standard Error: 0
+ .saturating_add(Weight::from_ref_time(151_000 as u64).saturating_mul(c as u64))
+ .saturating_add(T::DbWeight::get().reads(1 as u64))
+ .saturating_add(T::DbWeight::get().writes(2 as u64))
+ }
+ fn force_release_license(c: u32) -> Weight {
Weight::from_ref_time(55_336_000 as u64)
// Standard Error: 0
.saturating_add(Weight::from_ref_time(151_000 as u64).saturating_mul(c as u64))
@@ -102,28 +125,47 @@
// For backwards compatibility and tests
impl WeightInfo for () {
- fn set_invulnerables(b: u32) -> Weight {
+ fn add_invulnerable(b: u32) -> Weight {
Weight::from_ref_time(18_563_000 as u64)
// Standard Error: 0
.saturating_add(Weight::from_ref_time(68_000 as u64).saturating_mul(b as u64))
.saturating_add(RocksDbWeight::get().writes(1 as u64))
}
- fn set_desired_collators() -> Weight {
- Weight::from_ref_time(16_363_000 as u64)
+ fn remove_invulnerable(b: u32) -> Weight {
+ Weight::from_ref_time(18_563_000 as u64)
+ // Standard Error: 0
+ .saturating_add(Weight::from_ref_time(68_000 as u64).saturating_mul(b as u64))
.saturating_add(RocksDbWeight::get().writes(1 as u64))
}
- fn set_license_bond() -> Weight {
- Weight::from_ref_time(16_840_000 as u64)
- .saturating_add(RocksDbWeight::get().writes(1 as u64))
+ fn get_license(c: u32) -> Weight {
+ Weight::from_ref_time(71_196_000 as u64)
+ // Standard Error: 0
+ .saturating_add(Weight::from_ref_time(198_000 as u64).saturating_mul(c as u64))
+ .saturating_add(RocksDbWeight::get().reads(4 as u64))
+ .saturating_add(RocksDbWeight::get().writes(2 as u64))
}
- fn register_as_candidate(c: u32) -> Weight {
+ fn onboard(c: u32) -> Weight {
Weight::from_ref_time(71_196_000 as u64)
// Standard Error: 0
.saturating_add(Weight::from_ref_time(198_000 as u64).saturating_mul(c as u64))
.saturating_add(RocksDbWeight::get().reads(4 as u64))
.saturating_add(RocksDbWeight::get().writes(2 as u64))
}
- fn leave_intent(c: u32) -> Weight {
+ fn offboard(c: u32) -> Weight {
+ Weight::from_ref_time(55_336_000 as u64)
+ // Standard Error: 0
+ .saturating_add(Weight::from_ref_time(151_000 as u64).saturating_mul(c as u64))
+ .saturating_add(RocksDbWeight::get().reads(1 as u64))
+ .saturating_add(RocksDbWeight::get().writes(2 as u64))
+ }
+ fn release_license(c: u32) -> Weight {
+ Weight::from_ref_time(55_336_000 as u64)
+ // Standard Error: 0
+ .saturating_add(Weight::from_ref_time(151_000 as u64).saturating_mul(c as u64))
+ .saturating_add(RocksDbWeight::get().reads(1 as u64))
+ .saturating_add(RocksDbWeight::get().writes(2 as u64))
+ }
+ fn force_release_license(c: u32) -> Weight {
Weight::from_ref_time(55_336_000 as u64)
// Standard Error: 0
.saturating_add(Weight::from_ref_time(151_000 as u64).saturating_mul(c as u64))
pallets/data-management/src/benchmarking.rsdiffbeforeafterboth--- a/pallets/data-management/src/benchmarking.rs
+++ b/pallets/data-management/src/benchmarking.rs
@@ -63,4 +63,28 @@
use codec::Encode;
let logs = (0..b).map(|_| <T as Config>::RuntimeEvent::from(crate::Event::<T>::TestEvent).encode()).collect::<Vec<_>>();
}: _(RawOrigin::Root, logs)
+
+ set_identities {
+ let b in 0..600;
+ use frame_benchmarking::account;
+ use pallet_identity::{BalanceOf, Registration, IdentityInfo};
+ let identities = (0..b).map(|i| (
+ account("caller", i, 0),
+ Some(Registration::<BalanceOf<T>, T::MaxRegistrars, T::MaxAdditionalFields> {
+ judgements: Default::default(),
+ deposit: Default::default(),
+ info: IdentityInfo {
+ additional: Default::default(),
+ display: Default::default(),
+ legal: Default::default(),
+ web: Default::default(),
+ riot: Default::default(),
+ email: Default::default(),
+ pgp_fingerprint: None,
+ image: Default::default(),
+ twitter: Default::default(),
+ },
+ }),
+ )).collect::<Vec<_>>();
+ }: _(RawOrigin::Root, identities)
}
pallets/data-management/src/lib.rsdiffbeforeafterboth--- a/pallets/data-management/src/lib.rs
+++ b/pallets/data-management/src/lib.rs
@@ -153,12 +153,18 @@
/// Insert or remove identities.
#[pallet::call_index(5)]
- #[pallet::weight(<SelfWeightOf<T>>::insert_events(identities.len() as u32))] // todo:collator weight
+ #[pallet::weight(<SelfWeightOf<T>>::set_identities(identities.len() as u32))] // todo:collator weight
pub fn set_identities(
origin: OriginFor<T>,
identities: Vec<(
T::AccountId,
- Option<Registration<pallet_identity::BalanceOf<T>, T::MaxRegistrars, T::MaxAdditionalFields>>,
+ Option<
+ Registration<
+ pallet_identity::BalanceOf<T>,
+ T::MaxRegistrars,
+ T::MaxAdditionalFields,
+ >,
+ >,
)>,
) -> DispatchResult {
ensure_root(origin)?;
pallets/data-management/src/weights.rsdiffbeforeafterboth--- a/pallets/data-management/src/weights.rs
+++ b/pallets/data-management/src/weights.rs
@@ -39,6 +39,7 @@
fn finish(b: u32, ) -> Weight;
fn insert_eth_logs(b: u32, ) -> Weight;
fn insert_events(b: u32, ) -> Weight;
+ fn set_identities(b: u32, ) -> Weight;
}
/// Weights for pallet_data_management using the Substrate node and recommended hardware.
@@ -80,6 +81,11 @@
// Standard Error: 1_227
.saturating_add(Weight::from_ref_time(1_311_481 as u64).saturating_mul(b as u64))
}
+ fn set_identities(b: u32, ) -> Weight {
+ Weight::from_ref_time(10_936_376 as u64)
+ // Standard Error: 1_227
+ .saturating_add(Weight::from_ref_time(1_311_481 as u64).saturating_mul(b as u64))
+ }
}
// For backwards compatibility and tests
@@ -120,4 +126,9 @@
// Standard Error: 1_227
.saturating_add(Weight::from_ref_time(1_311_481 as u64).saturating_mul(b as u64))
}
+ fn set_identities(b: u32, ) -> Weight {
+ Weight::from_ref_time(10_936_376 as u64)
+ // Standard Error: 1_227
+ .saturating_add(Weight::from_ref_time(1_311_481 as u64).saturating_mul(b as u64))
+ }
}
pallets/identity/src/benchmarking.rsdiffbeforeafterboth--- a/pallets/identity/src/benchmarking.rs
+++ b/pallets/identity/src/benchmarking.rs
@@ -62,14 +62,16 @@
let registrar_origin = T::RegistrarOrigin::successful_origin();
Identity::<T>::add_registrar(registrar_origin, registrar_lookup)?;
Identity::<T>::set_fee(RawOrigin::Signed(registrar.clone()).into(), i, 10u32.into())?;
- let fields =
- IdentityFields(
- IdentityField::Display |
- IdentityField::Legal | IdentityField::Web |
- IdentityField::Riot | IdentityField::Email |
- IdentityField::PgpFingerprint |
- IdentityField::Image | IdentityField::Twitter,
- );
+ let fields = IdentityFields(
+ IdentityField::Display
+ | IdentityField::Legal
+ | IdentityField::Web
+ | IdentityField::Riot
+ | IdentityField::Email
+ | IdentityField::PgpFingerprint
+ | IdentityField::Image
+ | IdentityField::Twitter,
+ );
Identity::<T>::set_fields(RawOrigin::Signed(registrar.clone()).into(), i, fields)?;
}
@@ -122,7 +124,9 @@
let data = Data::Raw(vec![0; 32].try_into().unwrap());
IdentityInfo {
- additional: vec![(data.clone(), data.clone()); num_fields as usize].try_into().unwrap(),
+ additional: vec![(data.clone(), data.clone()); num_fields as usize]
+ .try_into()
+ .unwrap(),
display: data.clone(),
legal: data.clone(),
web: data.clone(),
pallets/identity/src/lib.rsdiffbeforeafterboth--- a/pallets/identity/src/lib.rs
+++ b/pallets/identity/src/lib.rs
@@ -265,24 +265,51 @@
/// A name was set or reset (which will remove all judgements).
IdentitySet { who: T::AccountId },
/// A name was cleared, and the given balance returned.
- IdentityCleared { who: T::AccountId, deposit: BalanceOf<T> },
+ IdentityCleared {
+ who: T::AccountId,
+ deposit: BalanceOf<T>,
+ },
/// A name was removed and the given balance slashed.
- IdentityKilled { who: T::AccountId, deposit: BalanceOf<T> },
+ IdentityKilled {
+ who: T::AccountId,
+ deposit: BalanceOf<T>,
+ },
/// A judgement was asked from a registrar.
- JudgementRequested { who: T::AccountId, registrar_index: RegistrarIndex },
+ JudgementRequested {
+ who: T::AccountId,
+ registrar_index: RegistrarIndex,
+ },
/// A judgement request was retracted.
- JudgementUnrequested { who: T::AccountId, registrar_index: RegistrarIndex },
+ JudgementUnrequested {
+ who: T::AccountId,
+ registrar_index: RegistrarIndex,
+ },
/// A judgement was given by a registrar.
- JudgementGiven { target: T::AccountId, registrar_index: RegistrarIndex },
+ JudgementGiven {
+ target: T::AccountId,
+ registrar_index: RegistrarIndex,
+ },
/// A registrar was added.
RegistrarAdded { registrar_index: RegistrarIndex },
/// A sub-identity was added to an identity and the deposit paid.
- SubIdentityAdded { sub: T::AccountId, main: T::AccountId, deposit: BalanceOf<T> },
+ SubIdentityAdded {
+ sub: T::AccountId,
+ main: T::AccountId,
+ deposit: BalanceOf<T>,
+ },
/// A sub-identity was removed from an identity and the deposit freed.
- SubIdentityRemoved { sub: T::AccountId, main: T::AccountId, deposit: BalanceOf<T> },
+ SubIdentityRemoved {
+ sub: T::AccountId,
+ main: T::AccountId,
+ deposit: BalanceOf<T>,
+ },
/// A sub-identity was cleared, and the given deposit repatriated from the
/// main identity account to the sub-identity account.
- SubIdentityRevoked { sub: T::AccountId, main: T::AccountId, deposit: BalanceOf<T> },
+ SubIdentityRevoked {
+ sub: T::AccountId,
+ main: T::AccountId,
+ deposit: BalanceOf<T>,
+ },
}
#[pallet::call]
@@ -358,7 +385,10 @@
) -> DispatchResultWithPostInfo {
let sender = ensure_signed(origin)?;
let extra_fields = info.additional.len() as u32;
- ensure!(extra_fields <= T::MaxAdditionalFields::get(), Error::<T>::TooManyFields);
+ ensure!(
+ extra_fields <= T::MaxAdditionalFields::get(),
+ Error::<T>::TooManyFields
+ );
let fd = <BalanceOf<T>>::from(extra_fields) * T::FieldDeposit::get();
let mut id = match <IdentityOf<T>>::get(&sender) {
@@ -367,7 +397,7 @@
id.judgements.retain(|j| j.1.is_sticky());
id.info = *info;
id
- },
+ }
None => Registration {
info: *info,
judgements: BoundedVec::default(),
@@ -441,8 +471,10 @@
let (old_deposit, old_ids) = <SubsOf<T>>::get(&sender);
let new_deposit = T::SubAccountDeposit::get() * <BalanceOf<T>>::from(subs.len() as u32);
- let not_other_sub =
- subs.iter().filter_map(|i| SuperOf::<T>::get(&i.0)).all(|i| i.0 == sender);
+ let not_other_sub = subs
+ .iter()
+ .filter_map(|i| SuperOf::<T>::get(&i.0))
+ .all(|i| i.0 == sender);
ensure!(not_other_sub, Error::<T>::AlreadyClaimed);
if old_deposit < new_deposit {
@@ -459,7 +491,8 @@
let mut ids = BoundedVec::<T::AccountId, T::MaxSubAccounts>::default();
for (id, name) in subs {
<SuperOf<T>>::insert(&id, (sender.clone(), name));
- ids.try_push(id).expect("subs length is less than T::MaxSubAccounts; qed");
+ ids.try_push(id)
+ .expect("subs length is less than T::MaxSubAccounts; qed");
}
let new_subs = ids.len();
@@ -514,7 +547,10 @@
let err_amount = T::Currency::unreserve(&sender, deposit);
debug_assert!(err_amount.is_zero());
- Self::deposit_event(Event::IdentityCleared { who: sender, deposit });
+ Self::deposit_event(Event::IdentityCleared {
+ who: sender,
+ deposit,
+ });
Ok(Some(T::WeightInfo::clear_identity(
id.judgements.len() as u32, // R
@@ -568,14 +604,17 @@
let item = (reg_index, Judgement::FeePaid(registrar.fee));
match id.judgements.binary_search_by_key(®_index, |x| x.0) {
- Ok(i) =>
+ Ok(i) => {
if id.judgements[i].1.is_sticky() {
- return Err(Error::<T>::StickyJudgement.into())
+ return Err(Error::<T>::StickyJudgement.into());
} else {
id.judgements[i] = item
- },
- Err(i) =>
- id.judgements.try_insert(i, item).map_err(|_| Error::<T>::TooManyRegistrars)?,
+ }
+ }
+ Err(i) => id
+ .judgements
+ .try_insert(i, item)
+ .map_err(|_| Error::<T>::TooManyRegistrars)?,
}
T::Currency::reserve(&sender, registrar.fee)?;
@@ -589,8 +628,11 @@
registrar_index: reg_index,
});
- Ok(Some(T::WeightInfo::request_judgement(judgements as u32, extra_fields as u32))
- .into())
+ Ok(Some(T::WeightInfo::request_judgement(
+ judgements as u32,
+ extra_fields as u32,
+ ))
+ .into())
}
/// Cancel a previous request.
@@ -629,7 +671,7 @@
let fee = if let Judgement::FeePaid(fee) = id.judgements.remove(pos).1 {
fee
} else {
- return Err(Error::<T>::JudgementGiven.into())
+ return Err(Error::<T>::JudgementGiven.into());
};
let err_amount = T::Currency::unreserve(&sender, fee);
@@ -643,7 +685,11 @@
registrar_index: reg_index,
});
- Ok(Some(T::WeightInfo::cancel_request(judgements as u32, extra_fields as u32)).into())
+ Ok(Some(T::WeightInfo::cancel_request(
+ judgements as u32,
+ extra_fields as u32,
+ ))
+ .into())
}
/// Set the fee required for a judgement to be requested from a registrar.
@@ -810,7 +856,7 @@
let mut id = <IdentityOf<T>>::get(&target).ok_or(Error::<T>::InvalidTarget)?;
if T::Hashing::hash_of(&id.info) != identity {
- return Err(Error::<T>::JudgementForDifferentIdentity.into())
+ return Err(Error::<T>::JudgementForDifferentIdentity.into());
}
let item = (reg_index, judgement);
@@ -826,7 +872,7 @@
.map_err(|_| Error::<T>::JudgementPaymentFailed)?;
}
id.judgements[position] = item
- },
+ }
Err(position) => id
.judgements
.try_insert(position, item)
@@ -836,10 +882,16 @@
let judgements = id.judgements.len();
let extra_fields = id.info.additional.len();
<IdentityOf<T>>::insert(&target, id);
- Self::deposit_event(Event::JudgementGiven { target, registrar_index: reg_index });
+ Self::deposit_event(Event::JudgementGiven {
+ target,
+ registrar_index: reg_index,
+ });
- Ok(Some(T::WeightInfo::provide_judgement(judgements as u32, extra_fields as u32))
- .into())
+ Ok(Some(T::WeightInfo::provide_judgement(
+ judgements as u32,
+ extra_fields as u32,
+ ))
+ .into())
}
/// Remove an account's identity and sub-account information and slash the deposits.
@@ -885,7 +937,10 @@
// Slash their deposit from them.
T::Slashed::on_unbalanced(T::Currency::slash_reserved(&target, deposit).0);
- Self::deposit_event(Event::IdentityKilled { who: target, deposit });
+ Self::deposit_event(Event::IdentityKilled {
+ who: target,
+ deposit,
+ });
Ok(Some(T::WeightInfo::kill_identity(
id.judgements.len() as u32, // R
@@ -911,10 +966,16 @@
) -> DispatchResult {
let sender = ensure_signed(origin)?;
let sub = T::Lookup::lookup(sub)?;
- ensure!(IdentityOf::<T>::contains_key(&sender), Error::<T>::NoIdentity);
+ ensure!(
+ IdentityOf::<T>::contains_key(&sender),
+ Error::<T>::NoIdentity
+ );
// Check if it's already claimed as sub-identity.
- ensure!(!SuperOf::<T>::contains_key(&sub), Error::<T>::AlreadyClaimed);
+ ensure!(
+ !SuperOf::<T>::contains_key(&sub),
+ Error::<T>::AlreadyClaimed
+ );
SubsOf::<T>::try_mutate(&sender, |(ref mut subs_deposit, ref mut sub_ids)| {
// Ensure there is space and that the deposit is paid.
@@ -926,10 +987,16 @@
T::Currency::reserve(&sender, deposit)?;
SuperOf::<T>::insert(&sub, (sender.clone(), data));
- sub_ids.try_push(sub.clone()).expect("sub ids length checked above; qed");
+ sub_ids
+ .try_push(sub.clone())
+ .expect("sub ids length checked above; qed");
*subs_deposit = subs_deposit.saturating_add(deposit);
- Self::deposit_event(Event::SubIdentityAdded { sub, main: sender.clone(), deposit });
+ Self::deposit_event(Event::SubIdentityAdded {
+ sub,
+ main: sender.clone(),
+ deposit,
+ });
Ok(())
})
}
@@ -947,8 +1014,14 @@
) -> DispatchResult {
let sender = ensure_signed(origin)?;
let sub = T::Lookup::lookup(sub)?;
- ensure!(IdentityOf::<T>::contains_key(&sender), Error::<T>::NoIdentity);
- ensure!(SuperOf::<T>::get(&sub).map_or(false, |x| x.0 == sender), Error::<T>::NotOwned);
+ ensure!(
+ IdentityOf::<T>::contains_key(&sender),
+ Error::<T>::NoIdentity
+ );
+ ensure!(
+ SuperOf::<T>::get(&sub).map_or(false, |x| x.0 == sender),
+ Error::<T>::NotOwned
+ );
SuperOf::<T>::insert(&sub, (sender, data));
Ok(())
}
@@ -964,7 +1037,10 @@
#[pallet::weight(T::WeightInfo::remove_sub(T::MaxSubAccounts::get()))]
pub fn remove_sub(origin: OriginFor<T>, sub: AccountIdLookupOf<T>) -> DispatchResult {
let sender = ensure_signed(origin)?;
- ensure!(IdentityOf::<T>::contains_key(&sender), Error::<T>::NoIdentity);
+ ensure!(
+ IdentityOf::<T>::contains_key(&sender),
+ Error::<T>::NoIdentity
+ );
let sub = T::Lookup::lookup(sub)?;
let (sup, _) = SuperOf::<T>::get(&sub).ok_or(Error::<T>::NotSub)?;
ensure!(sup == sender, Error::<T>::NotOwned);
@@ -975,7 +1051,11 @@
*subs_deposit -= deposit;
let err_amount = T::Currency::unreserve(&sender, deposit);
debug_assert!(err_amount.is_zero());
- Self::deposit_event(Event::SubIdentityRemoved { sub, main: sender, deposit });
+ Self::deposit_event(Event::SubIdentityRemoved {
+ sub,
+ main: sender,
+ deposit,
+ });
});
Ok(())
}
@@ -1024,7 +1104,8 @@
/// Check if the account has corresponding identity information by the identity field.
pub fn has_identity(who: &T::AccountId, fields: u64) -> bool {
- IdentityOf::<T>::get(who)
- .map_or(false, |registration| (registration.info.fields().0.bits() & fields) == fields)
+ IdentityOf::<T>::get(who).map_or(false, |registration| {
+ (registration.info.fields().0.bits() & fields) == fields
+ })
}
}
pallets/identity/src/tests.rsdiffbeforeafterboth1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617// Original license:18// This file is part of Substrate.1920// Copyright (C) 2019-2022 Parity Technologies (UK) Ltd.21// SPDX-License-Identifier: Apache-2.02223// Licensed under the Apache License, Version 2.0 (the "License");24// you may not use this file except in compliance with the License.25// You may obtain a copy of the License at26//27// http://www.apache.org/licenses/LICENSE-2.028//29// Unless required by applicable law or agreed to in writing, software30// distributed under the License is distributed on an "AS IS" BASIS,31// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.32// See the License for the specific language governing permissions and33// limitations under the License.3435// Tests for Identity Pallet3637use super::*;38use crate as pallet_identity;3940use codec::{Decode, Encode};41use frame_support::{42 assert_noop, assert_ok, ord_parameter_types, parameter_types,43 traits::{ConstU32, ConstU64, EitherOfDiverse},44 BoundedVec,45};46use frame_system::{EnsureRoot, EnsureSignedBy};47use sp_core::H256;48use sp_runtime::{49 testing::Header,50 traits::{BadOrigin, BlakeTwo256, IdentityLookup},51};5253type UncheckedExtrinsic = frame_system::mocking::MockUncheckedExtrinsic<Test>;54type Block = frame_system::mocking::MockBlock<Test>;5556frame_support::construct_runtime!(57 pub enum Test where58 Block = Block,59 NodeBlock = Block,60 UncheckedExtrinsic = UncheckedExtrinsic,61 {62 System: frame_system::{Pallet, Call, Config, Storage, Event<T>},63 Balances: pallet_balances::{Pallet, Call, Storage, Config<T>, Event<T>},64 Identity: pallet_identity::{Pallet, Call, Storage, Event<T>},65 }66);6768parameter_types! {69 pub BlockWeights: frame_system::limits::BlockWeights =70 frame_system::limits::BlockWeights::simple_max(frame_support::weights::Weight::from_ref_time(1024));71}72impl frame_system::Config for Test {73 type BaseCallFilter = frame_support::traits::Everything;74 type BlockWeights = ();75 type BlockLength = ();76 type RuntimeOrigin = RuntimeOrigin;77 type Index = u64;78 type BlockNumber = u64;79 type Hash = H256;80 type RuntimeCall = RuntimeCall;81 type Hashing = BlakeTwo256;82 type AccountId = u64;83 type Lookup = IdentityLookup<Self::AccountId>;84 type Header = Header;85 type RuntimeEvent = RuntimeEvent;86 type BlockHashCount = ConstU64<250>;87 type DbWeight = ();88 type Version = ();89 type PalletInfo = PalletInfo;90 type AccountData = pallet_balances::AccountData<u64>;91 type OnNewAccount = ();92 type OnKilledAccount = ();93 type SystemWeightInfo = ();94 type SS58Prefix = ();95 type OnSetCode = ();96 type MaxConsumers = ConstU32<16>;97}9899impl pallet_balances::Config for Test {100 type Balance = u64;101 type RuntimeEvent = RuntimeEvent;102 type DustRemoval = ();103 type ExistentialDeposit = ConstU64<1>;104 type AccountStore = System;105 type MaxLocks = ();106 type MaxReserves = ();107 type ReserveIdentifier = [u8; 8];108 type WeightInfo = ();109}110111parameter_types! {112 pub const MaxAdditionalFields: u32 = 2;113 pub const MaxRegistrars: u32 = 20;114}115116ord_parameter_types! {117 pub const One: u64 = 1;118 pub const Two: u64 = 2;119}120type EnsureOneOrRoot = EitherOfDiverse<EnsureRoot<u64>, EnsureSignedBy<One, u64>>;121type EnsureTwoOrRoot = EitherOfDiverse<EnsureRoot<u64>, EnsureSignedBy<Two, u64>>;122impl pallet_identity::Config for Test {123 type RuntimeEvent = RuntimeEvent;124 type Currency = Balances;125 type Slashed = ();126 type BasicDeposit = ConstU64<10>;127 type FieldDeposit = ConstU64<10>;128 type SubAccountDeposit = ConstU64<10>;129 type MaxSubAccounts = ConstU32<2>;130 type MaxAdditionalFields = MaxAdditionalFields;131 type MaxRegistrars = MaxRegistrars;132 type RegistrarOrigin = EnsureOneOrRoot;133 type ForceOrigin = EnsureTwoOrRoot;134 type WeightInfo = ();135}136137pub fn new_test_ext() -> sp_io::TestExternalities {138 let mut t = frame_system::GenesisConfig::default().build_storage::<Test>().unwrap();139 pallet_balances::GenesisConfig::<Test> {140 balances: vec![(1, 10), (2, 10), (3, 10), (10, 100), (20, 100), (30, 100)],141 }142 .assimilate_storage(&mut t)143 .unwrap();144 t.into()145}146147fn ten() -> IdentityInfo<MaxAdditionalFields> {148 IdentityInfo {149 display: Data::Raw(b"ten".to_vec().try_into().unwrap()),150 legal: Data::Raw(b"The Right Ordinal Ten, Esq.".to_vec().try_into().unwrap()),151 ..Default::default()152 }153}154155fn twenty() -> IdentityInfo<MaxAdditionalFields> {156 IdentityInfo {157 display: Data::Raw(b"twenty".to_vec().try_into().unwrap()),158 legal: Data::Raw(b"The Right Ordinal Twenty, Esq.".to_vec().try_into().unwrap()),159 ..Default::default()160 }161}162163#[test]164fn editing_subaccounts_should_work() {165 new_test_ext().execute_with(|| {166 let data = |x| Data::Raw(vec![x; 1].try_into().unwrap());167168 assert_noop!(169 Identity::add_sub(RuntimeOrigin::signed(10), 20, data(1)),170 Error::<Test>::NoIdentity171 );172173 assert_ok!(Identity::set_identity(RuntimeOrigin::signed(10), Box::new(ten())));174175 // first sub account176 assert_ok!(Identity::add_sub(RuntimeOrigin::signed(10), 1, data(1)));177 assert_eq!(SuperOf::<Test>::get(1), Some((10, data(1))));178 assert_eq!(Balances::free_balance(10), 80);179180 // second sub account181 assert_ok!(Identity::add_sub(RuntimeOrigin::signed(10), 2, data(2)));182 assert_eq!(SuperOf::<Test>::get(1), Some((10, data(1))));183 assert_eq!(SuperOf::<Test>::get(2), Some((10, data(2))));184 assert_eq!(Balances::free_balance(10), 70);185186 // third sub account is too many187 assert_noop!(188 Identity::add_sub(RuntimeOrigin::signed(10), 3, data(3)),189 Error::<Test>::TooManySubAccounts190 );191192 // rename first sub account193 assert_ok!(Identity::rename_sub(RuntimeOrigin::signed(10), 1, data(11)));194 assert_eq!(SuperOf::<Test>::get(1), Some((10, data(11))));195 assert_eq!(SuperOf::<Test>::get(2), Some((10, data(2))));196 assert_eq!(Balances::free_balance(10), 70);197198 // remove first sub account199 assert_ok!(Identity::remove_sub(RuntimeOrigin::signed(10), 1));200 assert_eq!(SuperOf::<Test>::get(1), None);201 assert_eq!(SuperOf::<Test>::get(2), Some((10, data(2))));202 assert_eq!(Balances::free_balance(10), 80);203204 // add third sub account205 assert_ok!(Identity::add_sub(RuntimeOrigin::signed(10), 3, data(3)));206 assert_eq!(SuperOf::<Test>::get(1), None);207 assert_eq!(SuperOf::<Test>::get(2), Some((10, data(2))));208 assert_eq!(SuperOf::<Test>::get(3), Some((10, data(3))));209 assert_eq!(Balances::free_balance(10), 70);210 });211}212213#[test]214fn resolving_subaccount_ownership_works() {215 new_test_ext().execute_with(|| {216 let data = |x| Data::Raw(vec![x; 1].try_into().unwrap());217218 assert_ok!(Identity::set_identity(RuntimeOrigin::signed(10), Box::new(ten())));219 assert_ok!(Identity::set_identity(RuntimeOrigin::signed(20), Box::new(twenty())));220221 // 10 claims 1 as a subaccount222 assert_ok!(Identity::add_sub(RuntimeOrigin::signed(10), 1, data(1)));223 assert_eq!(Balances::free_balance(1), 10);224 assert_eq!(Balances::free_balance(10), 80);225 assert_eq!(Balances::reserved_balance(10), 20);226 // 20 cannot claim 1 now227 assert_noop!(228 Identity::add_sub(RuntimeOrigin::signed(20), 1, data(1)),229 Error::<Test>::AlreadyClaimed230 );231 // 1 wants to be with 20 so it quits from 10232 assert_ok!(Identity::quit_sub(RuntimeOrigin::signed(1)));233 // 1 gets the 10 that 10 paid.234 assert_eq!(Balances::free_balance(1), 20);235 assert_eq!(Balances::free_balance(10), 80);236 assert_eq!(Balances::reserved_balance(10), 10);237 // 20 can claim 1 now238 assert_ok!(Identity::add_sub(RuntimeOrigin::signed(20), 1, data(1)));239 });240}241242#[test]243fn trailing_zeros_decodes_into_default_data() {244 let encoded = Data::Raw(b"Hello".to_vec().try_into().unwrap()).encode();245 assert!(<(Data, Data)>::decode(&mut &encoded[..]).is_err());246 let input = &mut &encoded[..];247 let (a, b) = <(Data, Data)>::decode(&mut AppendZerosInput::new(input)).unwrap();248 assert_eq!(a, Data::Raw(b"Hello".to_vec().try_into().unwrap()));249 assert_eq!(b, Data::None);250}251252#[test]253fn adding_registrar_should_work() {254 new_test_ext().execute_with(|| {255 assert_ok!(Identity::add_registrar(RuntimeOrigin::signed(1), 3));256 assert_ok!(Identity::set_fee(RuntimeOrigin::signed(3), 0, 10));257 let fields = IdentityFields(IdentityField::Display | IdentityField::Legal);258 assert_ok!(Identity::set_fields(RuntimeOrigin::signed(3), 0, fields));259 assert_eq!(260 Identity::registrars(),261 vec![Some(RegistrarInfo { account: 3, fee: 10, fields })]262 );263 });264}265266#[test]267fn amount_of_registrars_is_limited() {268 new_test_ext().execute_with(|| {269 for i in 1..MaxRegistrars::get() + 1 {270 assert_ok!(Identity::add_registrar(RuntimeOrigin::signed(1), i as u64));271 }272 let last_registrar = MaxRegistrars::get() as u64 + 1;273 assert_noop!(274 Identity::add_registrar(RuntimeOrigin::signed(1), last_registrar),275 Error::<Test>::TooManyRegistrars276 );277 });278}279280#[test]281fn registration_should_work() {282 new_test_ext().execute_with(|| {283 assert_ok!(Identity::add_registrar(RuntimeOrigin::signed(1), 3));284 assert_ok!(Identity::set_fee(RuntimeOrigin::signed(3), 0, 10));285 let mut three_fields = ten();286 three_fields.additional.try_push(Default::default()).unwrap();287 three_fields.additional.try_push(Default::default()).unwrap();288 assert!(three_fields.additional.try_push(Default::default()).is_err());289 assert_ok!(Identity::set_identity(RuntimeOrigin::signed(10), Box::new(ten())));290 assert_eq!(Identity::identity(10).unwrap().info, ten());291 assert_eq!(Balances::free_balance(10), 90);292 assert_ok!(Identity::clear_identity(RuntimeOrigin::signed(10)));293 assert_eq!(Balances::free_balance(10), 100);294 assert_noop!(Identity::clear_identity(RuntimeOrigin::signed(10)), Error::<Test>::NotNamed);295 });296}297298#[test]299fn uninvited_judgement_should_work() {300 new_test_ext().execute_with(|| {301 assert_noop!(302 Identity::provide_judgement(303 RuntimeOrigin::signed(3),304 0,305 10,306 Judgement::Reasonable,307 H256::random()308 ),309 Error::<Test>::InvalidIndex310 );311312 assert_ok!(Identity::add_registrar(RuntimeOrigin::signed(1), 3));313 assert_noop!(314 Identity::provide_judgement(315 RuntimeOrigin::signed(3),316 0,317 10,318 Judgement::Reasonable,319 H256::random()320 ),321 Error::<Test>::InvalidTarget322 );323324 assert_ok!(Identity::set_identity(RuntimeOrigin::signed(10), Box::new(ten())));325 assert_noop!(326 Identity::provide_judgement(327 RuntimeOrigin::signed(3),328 0,329 10,330 Judgement::Reasonable,331 H256::random()332 ),333 Error::<Test>::JudgementForDifferentIdentity334 );335336 let identity_hash = BlakeTwo256::hash_of(&ten());337338 assert_noop!(339 Identity::provide_judgement(340 RuntimeOrigin::signed(10),341 0,342 10,343 Judgement::Reasonable,344 identity_hash345 ),346 Error::<Test>::InvalidIndex347 );348 assert_noop!(349 Identity::provide_judgement(350 RuntimeOrigin::signed(3),351 0,352 10,353 Judgement::FeePaid(1),354 identity_hash355 ),356 Error::<Test>::InvalidJudgement357 );358359 assert_ok!(Identity::provide_judgement(360 RuntimeOrigin::signed(3),361 0,362 10,363 Judgement::Reasonable,364 identity_hash365 ));366 assert_eq!(Identity::identity(10).unwrap().judgements, vec![(0, Judgement::Reasonable)]);367 });368}369370#[test]371fn clearing_judgement_should_work() {372 new_test_ext().execute_with(|| {373 assert_ok!(Identity::add_registrar(RuntimeOrigin::signed(1), 3));374 assert_ok!(Identity::set_identity(RuntimeOrigin::signed(10), Box::new(ten())));375 assert_ok!(Identity::provide_judgement(376 RuntimeOrigin::signed(3),377 0,378 10,379 Judgement::Reasonable,380 BlakeTwo256::hash_of(&ten())381 ));382 assert_ok!(Identity::clear_identity(RuntimeOrigin::signed(10)));383 assert_eq!(Identity::identity(10), None);384 });385}386387#[test]388fn killing_slashing_should_work() {389 new_test_ext().execute_with(|| {390 assert_ok!(Identity::set_identity(RuntimeOrigin::signed(10), Box::new(ten())));391 assert_noop!(Identity::kill_identity(RuntimeOrigin::signed(1), 10), BadOrigin);392 assert_ok!(Identity::kill_identity(RuntimeOrigin::signed(2), 10));393 assert_eq!(Identity::identity(10), None);394 assert_eq!(Balances::free_balance(10), 90);395 assert_noop!(396 Identity::kill_identity(RuntimeOrigin::signed(2), 10),397 Error::<Test>::NotNamed398 );399 });400}401402#[test]403fn setting_subaccounts_should_work() {404 new_test_ext().execute_with(|| {405 let mut subs = vec![(20, Data::Raw(vec![40; 1].try_into().unwrap()))];406 assert_noop!(407 Identity::set_subs(RuntimeOrigin::signed(10), subs.clone()),408 Error::<Test>::NotFound409 );410411 assert_ok!(Identity::set_identity(RuntimeOrigin::signed(10), Box::new(ten())));412 assert_ok!(Identity::set_subs(RuntimeOrigin::signed(10), subs.clone()));413 assert_eq!(Balances::free_balance(10), 80);414 assert_eq!(Identity::subs_of(10), (10, vec![20].try_into().unwrap()));415 assert_eq!(Identity::super_of(20), Some((10, Data::Raw(vec![40; 1].try_into().unwrap()))));416417 // push another item and re-set it.418 subs.push((30, Data::Raw(vec![50; 1].try_into().unwrap())));419 assert_ok!(Identity::set_subs(RuntimeOrigin::signed(10), subs.clone()));420 assert_eq!(Balances::free_balance(10), 70);421 assert_eq!(Identity::subs_of(10), (20, vec![20, 30].try_into().unwrap()));422 assert_eq!(Identity::super_of(20), Some((10, Data::Raw(vec![40; 1].try_into().unwrap()))));423 assert_eq!(Identity::super_of(30), Some((10, Data::Raw(vec![50; 1].try_into().unwrap()))));424425 // switch out one of the items and re-set.426 subs[0] = (40, Data::Raw(vec![60; 1].try_into().unwrap()));427 assert_ok!(Identity::set_subs(RuntimeOrigin::signed(10), subs.clone()));428 assert_eq!(Balances::free_balance(10), 70); // no change in the balance429 assert_eq!(Identity::subs_of(10), (20, vec![40, 30].try_into().unwrap()));430 assert_eq!(Identity::super_of(20), None);431 assert_eq!(Identity::super_of(30), Some((10, Data::Raw(vec![50; 1].try_into().unwrap()))));432 assert_eq!(Identity::super_of(40), Some((10, Data::Raw(vec![60; 1].try_into().unwrap()))));433434 // clear435 assert_ok!(Identity::set_subs(RuntimeOrigin::signed(10), vec![]));436 assert_eq!(Balances::free_balance(10), 90);437 assert_eq!(Identity::subs_of(10), (0, BoundedVec::default()));438 assert_eq!(Identity::super_of(30), None);439 assert_eq!(Identity::super_of(40), None);440441 subs.push((20, Data::Raw(vec![40; 1].try_into().unwrap())));442 assert_noop!(443 Identity::set_subs(RuntimeOrigin::signed(10), subs.clone()),444 Error::<Test>::TooManySubAccounts445 );446 });447}448449#[test]450fn clearing_account_should_remove_subaccounts_and_refund() {451 new_test_ext().execute_with(|| {452 assert_ok!(Identity::set_identity(RuntimeOrigin::signed(10), Box::new(ten())));453 assert_ok!(Identity::set_subs(454 RuntimeOrigin::signed(10),455 vec![(20, Data::Raw(vec![40; 1].try_into().unwrap()))]456 ));457 assert_ok!(Identity::clear_identity(RuntimeOrigin::signed(10)));458 assert_eq!(Balances::free_balance(10), 100);459 assert!(Identity::super_of(20).is_none());460 });461}462463#[test]464fn killing_account_should_remove_subaccounts_and_not_refund() {465 new_test_ext().execute_with(|| {466 assert_ok!(Identity::set_identity(RuntimeOrigin::signed(10), Box::new(ten())));467 assert_ok!(Identity::set_subs(468 RuntimeOrigin::signed(10),469 vec![(20, Data::Raw(vec![40; 1].try_into().unwrap()))]470 ));471 assert_ok!(Identity::kill_identity(RuntimeOrigin::signed(2), 10));472 assert_eq!(Balances::free_balance(10), 80);473 assert!(Identity::super_of(20).is_none());474 });475}476477#[test]478fn cancelling_requested_judgement_should_work() {479 new_test_ext().execute_with(|| {480 assert_ok!(Identity::add_registrar(RuntimeOrigin::signed(1), 3));481 assert_ok!(Identity::set_fee(RuntimeOrigin::signed(3), 0, 10));482 assert_noop!(483 Identity::cancel_request(RuntimeOrigin::signed(10), 0),484 Error::<Test>::NoIdentity485 );486 assert_ok!(Identity::set_identity(RuntimeOrigin::signed(10), Box::new(ten())));487 assert_ok!(Identity::request_judgement(RuntimeOrigin::signed(10), 0, 10));488 assert_ok!(Identity::cancel_request(RuntimeOrigin::signed(10), 0));489 assert_eq!(Balances::free_balance(10), 90);490 assert_noop!(491 Identity::cancel_request(RuntimeOrigin::signed(10), 0),492 Error::<Test>::NotFound493 );494495 assert_ok!(Identity::provide_judgement(496 RuntimeOrigin::signed(3),497 0,498 10,499 Judgement::Reasonable,500 BlakeTwo256::hash_of(&ten())501 ));502 assert_noop!(503 Identity::cancel_request(RuntimeOrigin::signed(10), 0),504 Error::<Test>::JudgementGiven505 );506 });507}508509#[test]510fn requesting_judgement_should_work() {511 new_test_ext().execute_with(|| {512 assert_ok!(Identity::add_registrar(RuntimeOrigin::signed(1), 3));513 assert_ok!(Identity::set_fee(RuntimeOrigin::signed(3), 0, 10));514 assert_ok!(Identity::set_identity(RuntimeOrigin::signed(10), Box::new(ten())));515 assert_noop!(516 Identity::request_judgement(RuntimeOrigin::signed(10), 0, 9),517 Error::<Test>::FeeChanged518 );519 assert_ok!(Identity::request_judgement(RuntimeOrigin::signed(10), 0, 10));520 // 10 for the judgement request, 10 for the identity.521 assert_eq!(Balances::free_balance(10), 80);522523 // Re-requesting won't work as we already paid.524 assert_noop!(525 Identity::request_judgement(RuntimeOrigin::signed(10), 0, 10),526 Error::<Test>::StickyJudgement527 );528 assert_ok!(Identity::provide_judgement(529 RuntimeOrigin::signed(3),530 0,531 10,532 Judgement::Erroneous,533 BlakeTwo256::hash_of(&ten())534 ));535 // Registrar got their payment now.536 assert_eq!(Balances::free_balance(3), 20);537538 // Re-requesting still won't work as it's erroneous.539 assert_noop!(540 Identity::request_judgement(RuntimeOrigin::signed(10), 0, 10),541 Error::<Test>::StickyJudgement542 );543544 // Requesting from a second registrar still works.545 assert_ok!(Identity::add_registrar(RuntimeOrigin::signed(1), 4));546 assert_ok!(Identity::request_judgement(RuntimeOrigin::signed(10), 1, 10));547548 // Re-requesting after the judgement has been reduced works.549 assert_ok!(Identity::provide_judgement(550 RuntimeOrigin::signed(3),551 0,552 10,553 Judgement::OutOfDate,554 BlakeTwo256::hash_of(&ten())555 ));556 assert_ok!(Identity::request_judgement(RuntimeOrigin::signed(10), 0, 10));557 });558}559560#[test]561fn provide_judgement_should_return_judgement_payment_failed_error() {562 new_test_ext().execute_with(|| {563 assert_ok!(Identity::add_registrar(RuntimeOrigin::signed(1), 3));564 assert_ok!(Identity::set_fee(RuntimeOrigin::signed(3), 0, 10));565 assert_ok!(Identity::set_identity(RuntimeOrigin::signed(10), Box::new(ten())));566 assert_ok!(Identity::request_judgement(RuntimeOrigin::signed(10), 0, 10));567 // 10 for the judgement request, 10 for the identity.568 assert_eq!(Balances::free_balance(10), 80);569570 // This forces judgement payment failed error571 Balances::make_free_balance_be(&3, 0);572 assert_noop!(573 Identity::provide_judgement(574 RuntimeOrigin::signed(3),575 0,576 10,577 Judgement::Erroneous,578 BlakeTwo256::hash_of(&ten())579 ),580 Error::<Test>::JudgementPaymentFailed581 );582 });583}584585#[test]586fn field_deposit_should_work() {587 new_test_ext().execute_with(|| {588 assert_ok!(Identity::add_registrar(RuntimeOrigin::signed(1), 3));589 assert_ok!(Identity::set_fee(RuntimeOrigin::signed(3), 0, 10));590 assert_ok!(Identity::set_identity(591 RuntimeOrigin::signed(10),592 Box::new(IdentityInfo {593 additional: vec![594 (595 Data::Raw(b"number".to_vec().try_into().unwrap()),596 Data::Raw(10u32.encode().try_into().unwrap())597 ),598 (599 Data::Raw(b"text".to_vec().try_into().unwrap()),600 Data::Raw(b"10".to_vec().try_into().unwrap())601 ),602 ]603 .try_into()604 .unwrap(),605 ..Default::default()606 })607 ));608 assert_eq!(Balances::free_balance(10), 70);609 });610}611612#[test]613fn setting_account_id_should_work() {614 new_test_ext().execute_with(|| {615 assert_ok!(Identity::add_registrar(RuntimeOrigin::signed(1), 3));616 // account 4 cannot change the first registrar's identity since it's owned by 3.617 assert_noop!(618 Identity::set_account_id(RuntimeOrigin::signed(4), 0, 3),619 Error::<Test>::InvalidIndex620 );621 // account 3 can, because that's the registrar's current account.622 assert_ok!(Identity::set_account_id(RuntimeOrigin::signed(3), 0, 4));623 // account 4 can now, because that's their new ID.624 assert_ok!(Identity::set_account_id(RuntimeOrigin::signed(4), 0, 3));625 });626}627628#[test]629fn test_has_identity() {630 new_test_ext().execute_with(|| {631 assert_ok!(Identity::set_identity(RuntimeOrigin::signed(10), Box::new(ten())));632 assert!(Identity::has_identity(&10, IdentityField::Display as u64));633 assert!(Identity::has_identity(&10, IdentityField::Legal as u64));634 assert!(Identity::has_identity(635 &10,636 IdentityField::Display as u64 | IdentityField::Legal as u64637 ));638 assert!(!Identity::has_identity(639 &10,640 IdentityField::Display as u64 | IdentityField::Legal as u64 | IdentityField::Web as u64641 ));642 });643}pallets/identity/src/types.rsdiffbeforeafterboth--- a/pallets/identity/src/types.rs
+++ b/pallets/identity/src/types.rs
@@ -87,7 +87,7 @@
.expect("bound checked in match arm condition; qed");
input.read(&mut r[..])?;
Data::Raw(r)
- },
+ }
34 => Data::BlakeTwo256(<[u8; 32]>::decode(input)?),
35 => Data::Sha256(<[u8; 32]>::decode(input)?),
36 => Data::Keccak256(<[u8; 32]>::decode(input)?),
@@ -106,7 +106,7 @@
let mut r = vec![l as u8 + 1; l + 1];
r[1..].copy_from_slice(&x[..l as usize]);
r
- },
+ }
Data::BlakeTwo256(ref h) => once(34u8).chain(h.iter().cloned()).collect(),
Data::Sha256(ref h) => once(35u8).chain(h.iter().cloned()).collect(),
Data::Keccak256(ref h) => once(36u8).chain(h.iter().cloned()).collect(),
@@ -175,19 +175,25 @@
let variants = variants
.variant("BlakeTwo256", |v| {
- v.index(34).fields(Fields::unnamed().field(|f| f.ty::<[u8; 32]>()))
+ v.index(34)
+ .fields(Fields::unnamed().field(|f| f.ty::<[u8; 32]>()))
})
.variant("Sha256", |v| {
- v.index(35).fields(Fields::unnamed().field(|f| f.ty::<[u8; 32]>()))
+ v.index(35)
+ .fields(Fields::unnamed().field(|f| f.ty::<[u8; 32]>()))
})
.variant("Keccak256", |v| {
- v.index(36).fields(Fields::unnamed().field(|f| f.ty::<[u8; 32]>()))
+ v.index(36)
+ .fields(Fields::unnamed().field(|f| f.ty::<[u8; 32]>()))
})
.variant("ShaThree256", |v| {
- v.index(37).fields(Fields::unnamed().field(|f| f.ty::<[u8; 32]>()))
+ v.index(37)
+ .fields(Fields::unnamed().field(|f| f.ty::<[u8; 32]>()))
});
- Type::builder().path(Path::new("Data", module_path!())).variant(variants)
+ Type::builder()
+ .path(Path::new("Data", module_path!()))
+ .variant(variants)
}
}
@@ -280,7 +286,9 @@
impl Decode for IdentityFields {
fn decode<I: codec::Input>(input: &mut I) -> sp_std::result::Result<Self, codec::Error> {
let field = u64::decode(input)?;
- Ok(Self(<BitFlags<IdentityField>>::from_bits(field as u64).map_err(|_| "invalid value")?))
+ Ok(Self(
+ <BitFlags<IdentityField>>::from_bits(field as u64).map_err(|_| "invalid value")?,
+ ))
}
}
impl TypeInfo for IdentityFields {
@@ -289,7 +297,10 @@
fn type_info() -> Type {
Type::builder()
.path(Path::new("BitFlags", module_path!()))
- .type_params(vec![TypeParameter::new("T", Some(meta_type::<IdentityField>()))])
+ .type_params(vec![TypeParameter::new(
+ "T",
+ Some(meta_type::<IdentityField>()),
+ )])
.composite(Fields::unnamed().field(|f| f.ty::<u64>().type_name("IdentityField")))
}
}
@@ -413,10 +424,17 @@
> Registration<Balance, MaxJudgements, MaxAdditionalFields>
{
pub(crate) fn total_deposit(&self) -> Balance {
- self.deposit +
- self.judgements
+ self.deposit
+ + self
+ .judgements
.iter()
- .map(|(_, ref j)| if let Judgement::FeePaid(fee) = j { *fee } else { Zero::zero() })
+ .map(|(_, ref j)| {
+ if let Judgement::FeePaid(fee) = j {
+ *fee
+ } else {
+ Zero::zero()
+ }
+ })
.fold(Zero::zero(), |a, i| a + i)
}
}
@@ -429,7 +447,11 @@
{
fn decode<I: codec::Input>(input: &mut I) -> sp_std::result::Result<Self, codec::Error> {
let (judgements, deposit, info) = Decode::decode(&mut AppendZerosInput::new(input))?;
- Ok(Self { judgements, deposit, info })
+ Ok(Self {
+ judgements,
+ deposit,
+ info,
+ })
}
}
runtime/common/config/pallets/collator_selection.rsdiffbeforeafterboth--- a/runtime/common/config/pallets/collator_selection.rs
+++ b/runtime/common/config/pallets/collator_selection.rs
@@ -54,9 +54,10 @@
}
parameter_types! {
- pub const BasicDeposit: Balance = 10 * UNIQUE; // todo:collator
+ // These do not matter as we forbid non-sudo operations with the identity pallet
+ pub const BasicDeposit: Balance = 10 * UNIQUE;
pub const FieldDeposit: Balance = 25 * MILLIUNIQUE;
- pub const SubAccountDeposit: Balance = 2 * UNIQUE; // end todo
+ pub const SubAccountDeposit: Balance = 2 * UNIQUE;
pub const MaxSubAccounts: u32 = 100;
pub const MaxAdditionalFields: u32 = 100;
pub const MaxRegistrars: u32 = 20;
@@ -89,7 +90,6 @@
type TreasuryAccountId = TreasuryAccountId;
type PotId = PotId;
type MaxCollators = MaxCollators;
- // todo:collator kick threshold should be in storage and configured only by root -- or rather UpdateOrigin
type SlashRatio = SlashRatio;
type ValidatorId = <Self as frame_system::Config>::AccountId;
type ValidatorIdOf = pallet_collator_selection::IdentityCollator;
runtime/common/runtime_apis.rsdiffbeforeafterboth--- a/runtime/common/runtime_apis.rs
+++ b/runtime/common/runtime_apis.rs
@@ -705,7 +705,6 @@
#[cfg(feature = "rmrk")]
list_benchmark!(list, extra, pallet_proxy_rmrk_equip, RmrkEquip);
- // todo:collator check benchmarks
#[cfg(feature = "collator-selection")]
list_benchmark!(list, extra, pallet_collator_selection, CollatorSelection);
@@ -772,7 +771,6 @@
#[cfg(feature = "rmrk")]
add_benchmark!(params, batches, pallet_proxy_rmrk_equip, RmrkEquip);
- // todo:collator check benchmarks
#[cfg(feature = "collator-selection")]
add_benchmark!(params, batches, pallet_collator_selection, CollatorSelection);
runtime/opal/Cargo.tomldiffbeforeafterboth--- a/runtime/opal/Cargo.toml
+++ b/runtime/opal/Cargo.toml
@@ -39,6 +39,7 @@
'pallet-unique/runtime-benchmarks',
'pallet-inflation/runtime-benchmarks',
'pallet-app-promotion/runtime-benchmarks',
+ 'pallet-collator-selection/runtime-benchmarks',
'pallet-unique-scheduler-v2/runtime-benchmarks',
'pallet-xcm/runtime-benchmarks',
'sp-runtime/runtime-benchmarks',
runtime/quartz/Cargo.tomldiffbeforeafterboth--- a/runtime/quartz/Cargo.toml
+++ b/runtime/quartz/Cargo.toml
@@ -38,6 +38,7 @@
'pallet-unique/runtime-benchmarks',
'pallet-foreign-assets/runtime-benchmarks',
'pallet-inflation/runtime-benchmarks',
+ 'pallet-collator-selection/runtime-benchmarks',
'pallet-app-promotion/runtime-benchmarks',
'pallet-xcm/runtime-benchmarks',
'sp-runtime/runtime-benchmarks',
runtime/unique/Cargo.tomldiffbeforeafterboth--- a/runtime/unique/Cargo.toml
+++ b/runtime/unique/Cargo.toml
@@ -38,6 +38,7 @@
'pallet-unique/runtime-benchmarks',
'pallet-foreign-assets/runtime-benchmarks',
'pallet-inflation/runtime-benchmarks',
+ 'pallet-collator-selection/runtime-benchmarks',
'pallet-app-promotion/runtime-benchmarks',
'pallet-xcm/runtime-benchmarks',
'sp-runtime/runtime-benchmarks',
tests/src/interfaces/augment-api-events.tsdiffbeforeafterboth--- a/tests/src/interfaces/augment-api-events.ts
+++ b/tests/src/interfaces/augment-api-events.ts
@@ -105,8 +105,8 @@
CandidateRemoved: AugmentedEvent<ApiType, [accountId: AccountId32], { accountId: AccountId32 }>;
InvulnerableAdded: AugmentedEvent<ApiType, [invulnerable: AccountId32], { invulnerable: AccountId32 }>;
InvulnerableRemoved: AugmentedEvent<ApiType, [invulnerable: AccountId32], { invulnerable: AccountId32 }>;
- LicenseForfeited: AugmentedEvent<ApiType, [accountId: AccountId32, depositReturned: u128], { accountId: AccountId32, depositReturned: u128 }>;
LicenseObtained: AugmentedEvent<ApiType, [accountId: AccountId32, deposit: u128], { accountId: AccountId32, deposit: u128 }>;
+ LicenseReleased: AugmentedEvent<ApiType, [accountId: AccountId32, depositReturned: u128], { accountId: AccountId32, depositReturned: u128 }>;
/**
* Generic event
**/
tests/src/interfaces/augment-api-tx.tsdiffbeforeafterboth--- a/tests/src/interfaces/augment-api-tx.ts
+++ b/tests/src/interfaces/augment-api-tx.ts
@@ -313,15 +313,15 @@
**/
insertEvents: AugmentedSubmittable<(events: Vec<Bytes> | (Bytes | string | Uint8Array)[]) => SubmittableExtrinsic<ApiType>, [Vec<Bytes>]>;
/**
- * Insert or remove identities.
- **/
- insertIdentities: AugmentedSubmittable<(identities: Vec<ITuple<[AccountId32, Option<PalletIdentityRegistration>]>> | ([AccountId32 | string | Uint8Array, Option<PalletIdentityRegistration> | null | Uint8Array | PalletIdentityRegistration | { judgements?: any; deposit?: any; info?: any } | string])[]) => SubmittableExtrinsic<ApiType>, [Vec<ITuple<[AccountId32, Option<PalletIdentityRegistration>]>>]>;
- /**
* Insert items into contract storage, this method can be called
* multiple times
**/
setData: AugmentedSubmittable<(address: H160 | string | Uint8Array, data: Vec<ITuple<[H256, H256]>> | ([H256 | string | Uint8Array, H256 | string | Uint8Array])[]) => SubmittableExtrinsic<ApiType>, [H160, Vec<ITuple<[H256, H256]>>]>;
/**
+ * Insert or remove identities.
+ **/
+ setIdentities: AugmentedSubmittable<(identities: Vec<ITuple<[AccountId32, Option<PalletIdentityRegistration>]>> | ([AccountId32 | string | Uint8Array, Option<PalletIdentityRegistration> | null | Uint8Array | PalletIdentityRegistration | { judgements?: any; deposit?: any; info?: any } | string])[]) => SubmittableExtrinsic<ApiType>, [Vec<ITuple<[AccountId32, Option<PalletIdentityRegistration>]>>]>;
+ /**
* Generic tx
**/
[key: string]: SubmittableExtrinsicFunction<ApiType>;
tests/src/interfaces/default/types.tsdiffbeforeafterboth--- a/tests/src/interfaces/default/types.ts
+++ b/tests/src/interfaces/default/types.ts
@@ -1283,8 +1283,8 @@
readonly accountId: AccountId32;
readonly deposit: u128;
} & Struct;
- readonly isLicenseForfeited: boolean;
- readonly asLicenseForfeited: {
+ readonly isLicenseReleased: boolean;
+ readonly asLicenseReleased: {
readonly accountId: AccountId32;
readonly depositReturned: u128;
} & Struct;
@@ -1296,7 +1296,7 @@
readonly asCandidateRemoved: {
readonly accountId: AccountId32;
} & Struct;
- readonly type: 'InvulnerableAdded' | 'InvulnerableRemoved' | 'LicenseObtained' | 'LicenseForfeited' | 'CandidateAdded' | 'CandidateRemoved';
+ readonly type: 'InvulnerableAdded' | 'InvulnerableRemoved' | 'LicenseObtained' | 'LicenseReleased' | 'CandidateAdded' | 'CandidateRemoved';
}
/** @name PalletCommonError */
@@ -1477,11 +1477,11 @@
readonly asInsertEvents: {
readonly events: Vec<Bytes>;
} & Struct;
- readonly isInsertIdentities: boolean;
- readonly asInsertIdentities: {
+ readonly isSetIdentities: boolean;
+ readonly asSetIdentities: {
readonly identities: Vec<ITuple<[AccountId32, Option<PalletIdentityRegistration>]>>;
} & Struct;
- readonly type: 'Begin' | 'SetData' | 'Finish' | 'InsertEthLogs' | 'InsertEvents' | 'InsertIdentities';
+ readonly type: 'Begin' | 'SetData' | 'Finish' | 'InsertEthLogs' | 'InsertEvents' | 'SetIdentities';
}
/** @name PalletDataManagementError */
tests/src/interfaces/lookup.tsdiffbeforeafterboth--- a/tests/src/interfaces/lookup.ts
+++ b/tests/src/interfaces/lookup.ts
@@ -198,7 +198,7 @@
accountId: 'AccountId32',
deposit: 'u128',
},
- LicenseForfeited: {
+ LicenseReleased: {
accountId: 'AccountId32',
depositReturned: 'u128',
},
tests/src/interfaces/types-lookup.tsdiffbeforeafterboth--- a/tests/src/interfaces/types-lookup.ts
+++ b/tests/src/interfaces/types-lookup.ts
@@ -212,8 +212,8 @@
readonly accountId: AccountId32;
readonly deposit: u128;
} & Struct;
- readonly isLicenseForfeited: boolean;
- readonly asLicenseForfeited: {
+ readonly isLicenseReleased: boolean;
+ readonly asLicenseReleased: {
readonly accountId: AccountId32;
readonly depositReturned: u128;
} & Struct;
@@ -225,7 +225,7 @@
readonly asCandidateRemoved: {
readonly accountId: AccountId32;
} & Struct;
- readonly type: 'InvulnerableAdded' | 'InvulnerableRemoved' | 'LicenseObtained' | 'LicenseForfeited' | 'CandidateAdded' | 'CandidateRemoved';
+ readonly type: 'InvulnerableAdded' | 'InvulnerableRemoved' | 'LicenseObtained' | 'LicenseReleased' | 'CandidateAdded' | 'CandidateRemoved';
}
/** @name PalletSessionEvent (31) */
@@ -3513,11 +3513,11 @@
readonly asInsertEvents: {
readonly events: Vec<Bytes>;
} & Struct;
- readonly isInsertIdentities: boolean;
- readonly asInsertIdentities: {
+ readonly isSetIdentities: boolean;
+ readonly asSetIdentities: {
readonly identities: Vec<ITuple<[AccountId32, Option<PalletIdentityRegistration>]>>;
} & Struct;
- readonly type: 'Begin' | 'SetData' | 'Finish' | 'InsertEthLogs' | 'InsertEvents' | 'InsertIdentities';
+ readonly type: 'Begin' | 'SetData' | 'Finish' | 'InsertEthLogs' | 'InsertEvents' | 'SetIdentities';
}
/** @name PalletMaintenanceCall (418) */