git.delta.rocks / unique-network / refs/commits / c3c95caf228f

difftreelog

test fix build

Yaroslav Bolyukin2023-10-09parent: #22a5178.patch.diff
in: master

9 files changed

modifiedpallets/collator-selection/src/mock.rsdiffbeforeafterboth
3232
33use frame_support::{33use frame_support::{
34 ord_parameter_types, parameter_types,34 ord_parameter_types, parameter_types,
35 traits::{FindAuthor, GenesisBuild, ValidatorRegistration},35 traits::{ConstU32, FindAuthor, ValidatorRegistration},
36 PalletId,36 PalletId,
37};37};
38use frame_system as system;38use frame_system as system;
39use frame_system::EnsureSignedBy;39use frame_system::EnsureSignedBy;
40use sp_core::H256;40use sp_core::{ConstBool, H256};
41use sp_runtime::{41use sp_runtime::{
42 testing::{Header, UintAuthorityId},42 testing::UintAuthorityId,
43 traits::{BlakeTwo256, IdentityLookup, OpaqueKeys},43 traits::{BlakeTwo256, IdentityLookup, OpaqueKeys},
44 Perbill, RuntimeAppPublic,44 BuildStorage, Perbill, RuntimeAppPublic,
45};45};
4646
47use super::*;47use super::*;
48use crate as collator_selection;48use crate as collator_selection;
4949
50type UncheckedExtrinsic = frame_system::mocking::MockUncheckedExtrinsic<Test>;
51type Block = frame_system::mocking::MockBlock<Test>;50type Block = frame_system::mocking::MockBlockU32<Test>;
5251
53// Configure a mock runtime to test the pallet.52// Configure a mock runtime to test the pallet.
54frame_support::construct_runtime!(53frame_support::construct_runtime!(
64);63);
6564
66parameter_types! {65parameter_types! {
67 pub const BlockHashCount: u64 = 250;66 pub const BlockHashCount: u32 = 250;
68 pub const SS58Prefix: u8 = 42;67 pub const SS58Prefix: u8 = 42;
69}68}
7069
71impl system::Config for Test {70impl system::Config for Test {
72 type BaseCallFilter = frame_support::traits::Everything;71 type BaseCallFilter = frame_support::traits::Everything;
72 type Block = Block;
73 type BlockWeights = ();73 type BlockWeights = ();
74 type BlockLength = ();74 type BlockLength = ();
75 type DbWeight = ();75 type DbWeight = ();
90 type SystemWeightInfo = ();90 type SystemWeightInfo = ();
91 type SS58Prefix = SS58Prefix;91 type SS58Prefix = SS58Prefix;
92 type OnSetCode = ();92 type OnSetCode = ();
93 type MaxConsumers = frame_support::traits::ConstU32<16>;93 type MaxConsumers = ConstU32<16>;
94}94}
9595
96parameter_types! {96parameter_types! {
113 type FreezeIdentifier = [u8; 16];113 type FreezeIdentifier = [u8; 16];
114 type MaxHolds = MaxHolds;114 type MaxHolds = MaxHolds;
115 type MaxFreezes = MaxFreezes;115 type MaxFreezes = MaxFreezes;
116 type RuntimeHoldReason = RuntimeHoldReason;
116}117}
117118
118pub struct Author4;119pub struct Author4;
145 type AuthorityId = sp_consensus_aura::sr25519::AuthorityId;146 type AuthorityId = sp_consensus_aura::sr25519::AuthorityId;
146 type MaxAuthorities = MaxAuthorities;147 type MaxAuthorities = MaxAuthorities;
147 type DisabledValidators = ();148 type DisabledValidators = ();
149 type AllowMultipleBlocksPerSlot = ConstBool<true>;
148}150}
149151
150sp_runtime::impl_opaque_keys! {152sp_runtime::impl_opaque_keys! {
162164
163parameter_types! {165parameter_types! {
164 pub static SessionHandlerCollators: Vec<u64> = Vec::new();166 pub static SessionHandlerCollators: Vec<u64> = Vec::new();
165 pub static SessionChangeBlock: u64 = 0;167 pub static SessionChangeBlock: u32 = 0;
166}168}
167169
168pub struct TestSessionHandler;170pub struct TestSessionHandler;
169impl pallet_session::SessionHandler<u64> for TestSessionHandler {171impl pallet_session::SessionHandler<u64> for TestSessionHandler {
170 const KEY_TYPE_IDS: &'static [sp_runtime::KeyTypeId] = &[UintAuthorityId::ID];172 const KEY_TYPE_IDS: &'static [sp_runtime::KeyTypeId] = &[UintAuthorityId::ID];
171 fn on_genesis_session<Ks: OpaqueKeys>(keys: &[(u64, Ks)]) {173 fn on_genesis_session<Ks: OpaqueKeys>(keys: &[(u64, Ks)]) {
172 SessionHandlerCollators::set(keys.into_iter().map(|(a, _)| *a).collect::<Vec<_>>())174 SessionHandlerCollators::set(keys.iter().map(|(a, _)| *a).collect::<Vec<_>>())
173 }175 }
174 fn on_new_session<Ks: OpaqueKeys>(_: bool, keys: &[(u64, Ks)], _: &[(u64, Ks)]) {176 fn on_new_session<Ks: OpaqueKeys>(_: bool, keys: &[(u64, Ks)], _: &[(u64, Ks)]) {
175 SessionChangeBlock::set(System::block_number());177 SessionChangeBlock::set(System::block_number());
176 dbg!(keys.len());178 dbg!(keys.len());
177 SessionHandlerCollators::set(keys.into_iter().map(|(a, _)| *a).collect::<Vec<_>>())179 SessionHandlerCollators::set(keys.iter().map(|(a, _)| *a).collect::<Vec<_>>())
178 }180 }
179 fn on_before_session_ending() {}181 fn on_before_session_ending() {}
180 fn on_disabled(_: u32) {}182 fn on_disabled(_: u32) {}
181}183}
182184
183parameter_types! {185parameter_types! {
184 pub const Offset: u64 = 0;186 pub const Offset: u32 = 0;
185 pub const Period: u64 = 10;187 pub const Period: u32 = 10;
186}188}
187189
188impl pallet_session::Config for Test {190impl pallet_session::Config for Test {
201parameter_types! {203parameter_types! {
202 pub const MaxCollators: u32 = 5;204 pub const MaxCollators: u32 = 5;
203 pub const LicenseBond: u64 = 10;205 pub const LicenseBond: u64 = 10;
204 pub const KickThreshold: u64 = 10;206 pub const KickThreshold: u32 = 10;
205 // the following values do not matter and are meaningless, etc.207 // the following values do not matter and are meaningless, etc.
206 pub const DefaultWeightToFeeCoefficient: u64 = 100_000;208 pub const DefaultWeightToFeeCoefficient: u64 = 100_000;
207 pub const DefaultMinGasPrice: u64 = 100_000;209 pub const DefaultMinGasPrice: u64 = 100_000;
230232
231impl Config for Test {233impl Config for Test {
232 type RuntimeEvent = RuntimeEvent;234 type RuntimeEvent = RuntimeEvent;
235 type RuntimeHoldReason = RuntimeHoldReason;
233 type UpdateOrigin = EnsureSignedBy<RootAccount, u64>;236 type UpdateOrigin = EnsureSignedBy<RootAccount, u64>;
234 type PotId = PotId;237 type PotId = PotId;
235 type MaxCollators = MaxCollators;238 type MaxCollators = MaxCollators;
238 type ValidatorId = <Self as frame_system::Config>::AccountId;241 type ValidatorId = <Self as frame_system::Config>::AccountId;
239 type ValidatorIdOf = IdentityCollator;242 type ValidatorIdOf = IdentityCollator;
240 type ValidatorRegistration = IsRegistered;243 type ValidatorRegistration = IsRegistered;
241 type LicenceBondIdentifier = LicenceBondIdentifier;
242 type Currency = Balances;244 type Currency = Balances;
243 type DesiredCollators = MaxCollators;245 type DesiredCollators = MaxCollators;
244 type LicenseBond = LicenseBond;246 type LicenseBond = LicenseBond;
248250
249pub fn new_test_ext() -> sp_io::TestExternalities {251pub fn new_test_ext() -> sp_io::TestExternalities {
250 sp_tracing::try_init_simple();252 sp_tracing::try_init_simple();
251 let mut t = frame_system::GenesisConfig::default()253 let mut t = <frame_system::GenesisConfig<Test>>::default()
252 .build_storage::<Test>()254 .build_storage()
253 .unwrap();255 .unwrap();
254 let invulnerables = vec![1, 2];256 let invulnerables = vec![1, 2];
255257
284 t.into()286 t.into()
285}287}
286288
287pub fn initialize_to_block(n: u64) {289pub fn initialize_to_block(n: u32) {
288 for i in System::block_number() + 1..=n {290 for i in System::block_number() + 1..=n {
289 System::set_block_number(i);291 System::set_block_number(i);
290 <AllPalletsWithSystem as frame_support::traits::OnInitialize<u64>>::on_initialize(i);292 <AllPalletsWithSystem as frame_support::traits::OnInitialize<u32>>::on_initialize(i);
291 }293 }
292}294}
293295
modifiedpallets/collator-selection/src/tests.rsdiffbeforeafterboth
--- a/pallets/collator-selection/src/tests.rs
+++ b/pallets/collator-selection/src/tests.rs
@@ -32,10 +32,10 @@
 
 use frame_support::{
 	assert_noop, assert_ok,
-	traits::{fungible, GenesisBuild, OnInitialize},
+	traits::{fungible, OnInitialize},
 };
 use scale_info::prelude::*;
-use sp_runtime::{traits::BadOrigin, TokenError};
+use sp_runtime::{traits::BadOrigin, BuildStorage, TokenError};
 
 use crate::{self as collator_selection, mock::*, Config, Error};
 
@@ -464,8 +464,8 @@
 #[should_panic = "duplicate invulnerables in genesis."]
 fn cannot_set_genesis_value_twice() {
 	sp_tracing::try_init_simple();
-	let mut t = frame_system::GenesisConfig::default()
-		.build_storage::<Test>()
+	let mut t = <frame_system::GenesisConfig<Test>>::default()
+		.build_storage()
 		.unwrap();
 	let invulnerables = vec![1, 1];
 
modifiedpallets/identity/src/tests.rsdiffbeforeafterboth
--- a/pallets/identity/src/tests.rs
+++ b/pallets/identity/src/tests.rs
@@ -43,7 +43,6 @@
 use parity_scale_codec::{Decode, Encode};
 use sp_core::H256;
 use sp_runtime::{
-	testing::Header,
 	traits::{BadOrigin, BlakeTwo256, IdentityLookup},
 	BuildStorage,
 };
@@ -51,8 +50,7 @@
 use super::*;
 use crate as pallet_identity;
 
-type UncheckedExtrinsic = frame_system::mocking::MockUncheckedExtrinsic<Test>;
-type Block = frame_system::mocking::MockBlock<Test>;
+type Block = frame_system::mocking::MockBlockU32<Test>;
 
 frame_support::construct_runtime!(
 	pub enum Test {
@@ -79,7 +77,7 @@
 	type AccountId = u64;
 	type Lookup = IdentityLookup<Self::AccountId>;
 	type RuntimeEvent = RuntimeEvent;
-	type BlockHashCount = ConstU64<250>;
+	type BlockHashCount = ConstU32<250>;
 	type DbWeight = ();
 	type Version = ();
 	type PalletInfo = PalletInfo;
modifiedpallets/inflation/src/tests.rsdiffbeforeafterboth
--- a/pallets/inflation/src/tests.rs
+++ b/pallets/inflation/src/tests.rs
@@ -34,12 +34,12 @@
 
 use crate as pallet_inflation;
 
-type UncheckedExtrinsic = frame_system::mocking::MockUncheckedExtrinsic<Test>;
-type Block = frame_system::mocking::MockBlock<Test>;
+type Block = frame_system::mocking::MockBlockU32<Test>;
 
-const YEAR: u64 = 5_259_600; // 6-second blocks
-							 // const YEAR: u64 = 2_629_800; // 12-second blocks
-							 // Expected 100-block inflation for year 1 is 100 * 100_000_000 / YEAR = FIRST_YEAR_BLOCK_INFLATION
+// 6-second blocks
+// const YEAR: u32 = 2_629_800; // 12-second blocks
+// Expected 100-block inflation for year 1 is 100 * 100_000_000 / YEAR = FIRST_YEAR_BLOCK_INFLATION
+const YEAR: u32 = 5_259_600;
 const FIRST_YEAR_BLOCK_INFLATION: u64 = 1901;
 
 parameter_types! {
@@ -60,6 +60,7 @@
 	type FreezeIdentifier = ();
 	type MaxHolds = ();
 	type MaxFreezes = ();
+	type RuntimeHoldReason = RuntimeHoldReason;
 }
 
 frame_support::construct_runtime!(
@@ -71,7 +72,7 @@
 );
 
 parameter_types! {
-	pub const BlockHashCount: u64 = 250;
+	pub const BlockHashCount: u32 = 250;
 	pub BlockWeights: frame_system::limits::BlockWeights =
 		frame_system::limits::BlockWeights::simple_max(Weight::from_parts(1024, 0));
 	pub const SS58Prefix: u8 = 42;
@@ -79,6 +80,7 @@
 
 impl frame_system::Config for Test {
 	type BaseCallFilter = Everything;
+	type Block = Block;
 	type BlockWeights = ();
 	type BlockLength = ();
 	type DbWeight = ();
@@ -187,7 +189,7 @@
 fn inflation_second_deposit() {
 	new_test_ext().execute_with(|| {
 		// Total issuance = 1_000_000_000
-		let initial_issuance: u64 = 1_000_000_000;
+		let initial_issuance = 1_000_000_000;
 		let _ = <Balances as Balanced<_>>::deposit(&1234, initial_issuance, Precision::Exact);
 		assert_eq!(Balances::free_balance(1234), initial_issuance);
 		MockBlockNumberProvider::set(1);
@@ -196,20 +198,20 @@
 		assert_ok!(Inflation::start_inflation(RawOrigin::Root.into(), 1));
 
 		// Next inflation deposit happens when block is greater then or equal to NextInflationBlock
-		let mut block: u64 = 2;
-		let balance_before: u64 = Balances::free_balance(1234);
+		let mut block = 2;
+		let balance_before = Balances::free_balance(1234);
 		while block < <pallet_inflation::NextInflationBlock<Test>>::get() {
-			MockBlockNumberProvider::set(block as u64);
+			MockBlockNumberProvider::set(block);
 			Inflation::on_initialize(0);
 			block += 1;
 		}
-		let balance_just_before: u64 = Balances::free_balance(1234);
+		let balance_just_before = Balances::free_balance(1234);
 		assert_eq!(balance_before, balance_just_before);
 
 		// The block with inflation
-		MockBlockNumberProvider::set(block as u64);
+		MockBlockNumberProvider::set(block);
 		Inflation::on_initialize(0);
-		let balance_after: u64 = Balances::free_balance(1234);
+		let balance_after = Balances::free_balance(1234);
 		assert_eq!(balance_after - balance_just_before, block_inflation!());
 	});
 }
@@ -234,7 +236,7 @@
 			Inflation::on_initialize(0);
 		}
 		assert_eq!(
-			initial_issuance + (FIRST_YEAR_BLOCK_INFLATION * (YEAR / 100)),
+			initial_issuance + (FIRST_YEAR_BLOCK_INFLATION * ((YEAR as u64) / 100)),
 			<Balances as Inspect<_>>::total_issuance()
 		);
 
@@ -243,8 +245,8 @@
 		let block_inflation_year_2 = block_inflation!();
 		// Expected 100-block inflation for year 2: 100 * 9.33% * initial issuance * 110% / YEAR == 1951
 		let expecter_year_2_inflation: u64 = (initial_issuance
-			+ FIRST_YEAR_BLOCK_INFLATION * YEAR / 100)
-			* 933 * 100 / (10000 * YEAR);
+			+ FIRST_YEAR_BLOCK_INFLATION * (YEAR as u64) / 100)
+			* 933 * 100 / (10000 * (YEAR as u64));
 		assert_eq!(block_inflation_year_2 / 10, expecter_year_2_inflation / 10); // divide by 10 for approx. equality
 	});
 }
@@ -253,8 +255,8 @@
 fn inflation_start_large_kusama_block() {
 	new_test_ext().execute_with(|| {
 		// Total issuance = 1_000_000_000
-		let initial_issuance: u64 = 1_000_000_000;
-		let start_block: u64 = 10457457;
+		let initial_issuance = 1_000_000_000;
+		let start_block = 10457457;
 		let _ = <Balances as Balanced<_>>::deposit(&1234, initial_issuance, Precision::Exact);
 		assert_eq!(Balances::free_balance(1234), initial_issuance);
 		MockBlockNumberProvider::set(start_block);
@@ -273,7 +275,7 @@
 			Inflation::on_initialize(0);
 		}
 		assert_eq!(
-			initial_issuance + (FIRST_YEAR_BLOCK_INFLATION * (YEAR / 100)),
+			initial_issuance + (FIRST_YEAR_BLOCK_INFLATION * ((YEAR as u64) / 100)),
 			<Balances as Inspect<_>>::total_issuance()
 		);
 
@@ -282,8 +284,8 @@
 		let block_inflation_year_2 = block_inflation!();
 		// Expected 100-block inflation for year 2: 100 * 9.33% * initial issuance * 110% / YEAR == 1951
 		let expecter_year_2_inflation: u64 = (initial_issuance
-			+ FIRST_YEAR_BLOCK_INFLATION * YEAR / 100)
-			* 933 * 100 / (10000 * YEAR);
+			+ FIRST_YEAR_BLOCK_INFLATION * (YEAR as u64) / 100)
+			* 933 * 100 / (10000 * (YEAR as u64));
 		assert_eq!(block_inflation_year_2 / 10, expecter_year_2_inflation / 10); // divide by 10 for approx. equality
 	});
 }
@@ -320,14 +322,14 @@
 #[test]
 fn inflation_rate_by_year() {
 	new_test_ext().execute_with(|| {
-		let payouts: u64 = YEAR / InflationBlockInterval::get() as u64;
+		let payouts = (YEAR / InflationBlockInterval::get()) as u64;
 
 		// Inflation starts at 10% and does down by 2/3% every year until year 9 (included),
 		// then it is flat.
 		let payout_by_year: [u64; 11] = [1000, 933, 867, 800, 733, 667, 600, 533, 467, 400, 400];
 
 		// For accuracy total issuance = payout0 * payouts * 10;
-		let initial_issuance: u64 = payout_by_year[0] * payouts * 10;
+		let initial_issuance = payout_by_year[0] * payouts * 10;
 		let _ = <Balances as Balanced<_>>::deposit(&1234, initial_issuance, Precision::Exact);
 		assert_eq!(Balances::free_balance(1234), initial_issuance);
 
modifiedruntime/common/tests/mod.rsdiffbeforeafterboth
--- a/runtime/common/tests/mod.rs
+++ b/runtime/common/tests/mod.rs
@@ -19,7 +19,7 @@
 use sp_runtime::{BuildStorage, Storage};
 use up_common::types::AuraId;
 
-use crate::{BuildGenesisConfig, ParachainInfoConfig, Runtime, RuntimeEvent, System};
+use crate::{ParachainInfoConfig, Runtime, RuntimeEvent, RuntimeGenesisConfig, System};
 pub type Balance = u128;
 
 pub mod xcm;
@@ -51,8 +51,8 @@
 fn new_test_ext(balances: Vec<(AccountId, Balance)>) -> sp_io::TestExternalities {
 	let mut storage = make_basic_storage();
 
-	pallet_balances::BuildGenesisConfig::<Runtime> { balances }
-		.build_storage(&mut storage)
+	pallet_balances::GenesisConfig::<Runtime> { balances }
+		.assimilate_storage(&mut storage)
 		.unwrap();
 
 	let mut ext = sp_io::TestExternalities::new(storage);
@@ -95,7 +95,7 @@
 		.map(|acc| get_account_id_from_seed::<sr25519::Public>(acc))
 		.collect::<Vec<_>>();
 
-	let cfg = BuildGenesisConfig {
+	let cfg = RuntimeGenesisConfig {
 		collator_selection: CollatorSelectionConfig { invulnerables },
 		session: SessionConfig { keys },
 		parachain_info: ParachainInfoConfig {
@@ -112,7 +112,7 @@
 fn make_basic_storage() -> Storage {
 	use crate::AuraConfig;
 
-	let cfg = BuildGenesisConfig {
+	let cfg = RuntimeGenesisConfig {
 		aura: AuraConfig {
 			authorities: vec![
 				get_from_seed::<AuraId>("Alice"),
modifiedruntime/common/tests/xcm.rsdiffbeforeafterboth
--- a/runtime/common/tests/xcm.rs
+++ b/runtime/common/tests/xcm.rs
@@ -52,9 +52,9 @@
 
 		let xcm_event = &last_events(1)[0];
 		match xcm_event {
-			RuntimeEvent::PolkadotXcm(pallet_xcm::Event::<Runtime>::Attempted(
-				Outcome::Incomplete(_weight, Error::NoPermission),
-			)) => { /* Pass */ }
+			RuntimeEvent::PolkadotXcm(pallet_xcm::Event::<Runtime>::Attempted {
+				outcome: Outcome::Incomplete(_weight, Error::NoPermission),
+			}) => { /* Pass */ }
 			_ => panic!(
 				"Expected PolkadotXcm.Attempted(Incomplete(_weight, NoPermission)),\
 				found: {xcm_event:#?}"
addedruntime/tests/src/dispatch.rsdiffbeforeafterboth
--- /dev/null
+++ b/runtime/tests/src/dispatch.rs
@@ -0,0 +1 @@
+../../common/dispatch.rs
\ No newline at end of file
modifiedruntime/tests/src/lib.rsdiffbeforeafterboth
--- a/runtime/tests/src/lib.rs
+++ b/runtime/tests/src/lib.rs
@@ -33,23 +33,20 @@
 use scale_info::TypeInfo;
 use sp_core::{H160, H256, U256};
 use sp_runtime::{
-	testing::Header,
 	traits::{BlakeTwo256, IdentityLookup},
+	BuildStorage,
 };
 use up_data_structs::mapping::{CrossTokenAddressMapping, EvmTokenAddressMapping};
 
-#[path = "../../common/dispatch.rs"]
 mod dispatch;
 
 use dispatch::CollectionDispatchT;
 
-#[path = "../../common/weights/mod.rs"]
 mod weights;
 
 use weights::CommonWeights;
 
-type UncheckedExtrinsic = frame_system::mocking::MockUncheckedExtrinsic<Test>;
-type Block = frame_system::mocking::MockBlock<Test>;
+type Block = frame_system::mocking::MockBlockU32<Test>;
 
 #[cfg(test)]
 mod tests;
@@ -73,13 +70,14 @@
 );
 
 parameter_types! {
-	pub const BlockHashCount: u64 = 250;
+	pub const BlockHashCount: u32 = 250;
 	pub const SS58Prefix: u8 = 42;
 }
 
 impl system::Config for Test {
 	type RuntimeEvent = RuntimeEvent;
 	type BaseCallFilter = Everything;
+	type Block = Block;
 	type BlockWeights = ();
 	type BlockLength = ();
 	type DbWeight = ();
@@ -120,6 +118,7 @@
 	type MaxFreezes = MaxLocks;
 	type FreezeIdentifier = [u8; 8];
 	type MaxHolds = MaxLocks;
+	type RuntimeHoldReason = RuntimeHoldReason;
 }
 
 parameter_types! {
@@ -232,6 +231,7 @@
 	type OnMethodCall = ();
 	type OnCreate = ();
 	type OnChargeTransaction = ();
+	type OnCheckEvmTransaction = ();
 	type FindAuthor = ();
 	type BlockHashMapping = SubstrateBlockHashMapping<Self>;
 	type Timestamp = Timestamp;
@@ -296,8 +296,8 @@
 
 // Build genesis storage according to the mock runtime.
 pub fn new_test_ext() -> sp_io::TestExternalities {
-	system::GenesisConfig::default()
-		.build_storage::<Test>()
+	<system::GenesisConfig<Test>>::default()
+		.build_storage()
 		.unwrap()
 		.into()
 }
addedruntime/tests/src/weightsdiffbeforeafterboth
--- /dev/null
+++ b/runtime/tests/src/weights
@@ -0,0 +1 @@
+../../common/weights
\ No newline at end of file