git.delta.rocks / unique-network / refs/commits / b6b4ad113e7d

difftreelog

Integration tests setConstOnChainSchema and setVariableOnChainSchema fixed

str-mv2021-07-15parent: #430a12f.patch.diff
in: master

4 files changed

modifiedtests/src/change-collection-owner.test.tsdiffbeforeafterboth
before · tests/src/change-collection-owner.test.ts
1//2// This file is subject to the terms and conditions defined in3// file 'LICENSE', which is part of this source code package.4//56import chai from 'chai';7import chaiAsPromised from 'chai-as-promised';8import privateKey from './substrate/privateKey';9import { default as usingApi, submitTransactionAsync, submitTransactionExpectFailAsync } from './substrate/substrate-api';10import { createCollectionExpectSuccess, normalizeAccountId } from './util/helpers';1112chai.use(chaiAsPromised);13const expect = chai.expect;1415describe.only('Integration Test changeCollectionOwner(collection_id, new_owner):', () => {16  it('Changing owner changes owner address', async () => {17    await usingApi(async api => {18      const collectionId = await createCollectionExpectSuccess();19      const alice = privateKey('//Alice');20      const bob = privateKey('//Bob');2122      const collection: any = (await api.query.nft.collectionById(collectionId)).toJSON();23      expect(collection.Owner).to.be.deep.eq(alice.address);2425      const changeOwnerTx = api.tx.nft.changeCollectionOwner(collectionId, bob.address);26      await submitTransactionAsync(alice, changeOwnerTx);2728      const collectionAfterOwnerChange: any = (await api.query.nft.collectionById(collectionId)).toJSON();29      expect(collectionAfterOwnerChange.Owner).to.be.deep.eq(bob.address);30    });31  });32});3334describe.only('Negative Integration Test changeCollectionOwner(collection_id, new_owner):', () => {35  it('Not owner can\'t change owner.', async () => {36    await usingApi(async api => {37      const collectionId = await createCollectionExpectSuccess();38      const alice = privateKey('//Alice');39      const bob = privateKey('//Bob');4041      const changeOwnerTx = api.tx.nft.changeCollectionOwner(collectionId, bob.address);42      await expect(submitTransactionExpectFailAsync(bob, changeOwnerTx)).to.be.rejected;4344      const collectionAfterOwnerChange: any = (await api.query.nft.collectionById(collectionId)).toJSON();45      expect(collectionAfterOwnerChange.Owner).to.be.deep.eq(alice.address);4647      // Verifying that nothing bad happened (network is live, new collections can be created, etc.)48      await createCollectionExpectSuccess();49    });50  });51  it('Can\'t change owner of a non-existing collection.', async () => {52    await usingApi(async api => {53      const collectionId = (1<<32) - 1;54      const alice = privateKey('//Alice');55      const bob = privateKey('//Bob');5657      const changeOwnerTx = api.tx.nft.changeCollectionOwner(collectionId, bob.address);58      await expect(submitTransactionExpectFailAsync(alice, changeOwnerTx)).to.be.rejected;5960      // Verifying that nothing bad happened (network is live, new collections can be created, etc.)61      await createCollectionExpectSuccess();62    });63  });64});
after · tests/src/change-collection-owner.test.ts
1//2// This file is subject to the terms and conditions defined in3// file 'LICENSE', which is part of this source code package.4//56import chai from 'chai';7import chaiAsPromised from 'chai-as-promised';8import privateKey from './substrate/privateKey';9import { default as usingApi, submitTransactionAsync, submitTransactionExpectFailAsync } from './substrate/substrate-api';10import { createCollectionExpectSuccess, normalizeAccountId } from './util/helpers';1112chai.use(chaiAsPromised);13const expect = chai.expect;1415describe('Integration Test changeCollectionOwner(collection_id, new_owner):', () => {16  it('Changing owner changes owner address', async () => {17    await usingApi(async api => {18      const collectionId = await createCollectionExpectSuccess();19      const alice = privateKey('//Alice');20      const bob = privateKey('//Bob');2122      const collection: any = (await api.query.nft.collectionById(collectionId)).toJSON();23      expect(collection.Owner).to.be.deep.eq(alice.address);2425      const changeOwnerTx = api.tx.nft.changeCollectionOwner(collectionId, bob.address);26      await submitTransactionAsync(alice, changeOwnerTx);2728      const collectionAfterOwnerChange: any = (await api.query.nft.collectionById(collectionId)).toJSON();29      expect(collectionAfterOwnerChange.Owner).to.be.deep.eq(bob.address);30    });31  });32});3334describe('Negative Integration Test changeCollectionOwner(collection_id, new_owner):', () => {35  it('Not owner can\'t change owner.', async () => {36    await usingApi(async api => {37      const collectionId = await createCollectionExpectSuccess();38      const alice = privateKey('//Alice');39      const bob = privateKey('//Bob');4041      const changeOwnerTx = api.tx.nft.changeCollectionOwner(collectionId, bob.address);42      await expect(submitTransactionExpectFailAsync(bob, changeOwnerTx)).to.be.rejected;4344      const collectionAfterOwnerChange: any = (await api.query.nft.collectionById(collectionId)).toJSON();45      expect(collectionAfterOwnerChange.Owner).to.be.deep.eq(alice.address);4647      // Verifying that nothing bad happened (network is live, new collections can be created, etc.)48      await createCollectionExpectSuccess();49    });50  });51  it('Can\'t change owner of a non-existing collection.', async () => {52    await usingApi(async api => {53      const collectionId = (1<<32) - 1;54      const alice = privateKey('//Alice');55      const bob = privateKey('//Bob');5657      const changeOwnerTx = api.tx.nft.changeCollectionOwner(collectionId, bob.address);58      await expect(submitTransactionExpectFailAsync(alice, changeOwnerTx)).to.be.rejected;5960      // Verifying that nothing bad happened (network is live, new collections can be created, etc.)61      await createCollectionExpectSuccess();62    });63  });64});
modifiedtests/src/eth/nonFungible.test.tsdiffbeforeafterboth
--- a/tests/src/eth/nonFungible.test.ts
+++ b/tests/src/eth/nonFungible.test.ts
@@ -61,7 +61,7 @@
   });
 });
 
-describe.only('Plain calls', () => {
+describe('Plain calls', () => {
   itWeb3('Can perform approve()', async ({ web3, api }) => {
     const collection = await createCollectionExpectSuccess({
       mode: { type: 'NFT' },
modifiedtests/src/setConstOnChainSchema.test.tsdiffbeforeafterboth
--- a/tests/src/setConstOnChainSchema.test.ts
+++ b/tests/src/setConstOnChainSchema.test.ts
@@ -38,7 +38,7 @@
     await usingApi(async (api) => {
       const collectionId = await createCollectionExpectSuccess();
       const collection: any = (await api.query.nft.collectionById(collectionId)).toJSON();
-      expect(collection.Owner).to.be.deep.eq(normalizeAccountId(Alice.address));
+      expect(collection.Owner).to.be.eq(Alice.address);
       const setShema = api.tx.nft.setConstOnChainSchema(collectionId, Shema);
       await submitTransactionAsync(Alice, setShema);
     });
@@ -88,7 +88,7 @@
     await usingApi(async (api) => {
       const collectionId = await createCollectionExpectSuccess();
       const collection: any = (await api.query.nft.collectionById(collectionId)).toJSON();
-      expect(collection.Owner).to.be.deep.eq(normalizeAccountId(Alice.address));
+      expect(collection.Owner).to.be.eq(Alice.address);
       const setShema = api.tx.nft.setConstOnChainSchema(collectionId, Shema);
       await expect(submitTransactionExpectFailAsync(Bob, setShema)).to.be.rejected;
     });
modifiedtests/src/setVariableOnChainSchema.test.tsdiffbeforeafterboth
--- a/tests/src/setVariableOnChainSchema.test.ts
+++ b/tests/src/setVariableOnChainSchema.test.ts
@@ -38,7 +38,7 @@
     await usingApi(async (api) => {
       const collectionId = await createCollectionExpectSuccess();
       const collection: any = (await api.query.nft.collectionById(collectionId)).toJSON();
-      expect(collection.Owner).to.be.deep.eq(normalizeAccountId(Alice.address));
+      expect(collection.Owner).to.be.eq(Alice.address);
       const setSchema = api.tx.nft.setVariableOnChainSchema(collectionId, Schema);
       await submitTransactionAsync(Alice, setSchema);
     });
@@ -88,7 +88,7 @@
     await usingApi(async (api) => {
       const collectionId = await createCollectionExpectSuccess();
       const collection: any = (await api.query.nft.collectionById(collectionId)).toJSON();
-      expect(collection.Owner).to.be.deep.eq(normalizeAccountId(Alice.address));
+      expect(collection.Owner).to.be.eq(Alice.address);
       const setSchema = api.tx.nft.setVariableOnChainSchema(collectionId, Schema);
       await expect(submitTransactionExpectFailAsync(Bob, setSchema)).to.be.rejected;
     });