git.delta.rocks / unique-network / refs/commits / b69837dd758f

difftreelog

feat budgets

Yaroslav Bolyukin2022-04-07parent: #23942aa.patch.diff
in: master

19 files changed

modifiedpallets/common/src/lib.rsdiffbeforeafterboth
--- a/pallets/common/src/lib.rs
+++ b/pallets/common/src/lib.rs
@@ -33,7 +33,7 @@
 	COLLECTION_ADMINS_LIMIT, MetaUpdatePermission, TokenId, CollectionStats, MAX_TOKEN_OWNERSHIP,
 	CollectionMode, NFT_SPONSOR_TRANSFER_TIMEOUT, FUNGIBLE_SPONSOR_TRANSFER_TIMEOUT,
 	REFUNGIBLE_SPONSOR_TRANSFER_TIMEOUT, MAX_SPONSOR_TIMEOUT, CUSTOM_DATA_LIMIT, CollectionLimits,
-	CustomDataLimit, CreateCollectionData, SponsorshipState, CreateItemExData, SponsoringRateLimit,
+	CustomDataLimit, CreateCollectionData, SponsorshipState, CreateItemExData, SponsoringRateLimit, budget::Budget,
 };
 pub use pallet::*;
 use sp_core::H160;
@@ -763,6 +763,7 @@
 		to: T::CrossAccountId,
 		token: TokenId,
 		amount: u128,
+		nesting_budget: &dyn Budget,
 	) -> DispatchResultWithPostInfo;
 	fn burn_from(
 		&self,
@@ -770,6 +771,7 @@
 		from: T::CrossAccountId,
 		token: TokenId,
 		amount: u128,
+		nesting_budget: &dyn Budget,
 	) -> DispatchResultWithPostInfo;
 
 	fn set_variable_metadata(
modifiedpallets/evm-coder-substrate/Cargo.tomldiffbeforeafterboth
--- a/pallets/evm-coder-substrate/Cargo.toml
+++ b/pallets/evm-coder-substrate/Cargo.toml
@@ -17,6 +17,7 @@
 frame-support = { default-features = false, git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.20" }
 frame-system = { default-features = false, git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.20" }
 frame-benchmarking = { default-features = false, optional = true, git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.20" }
+up-data-structs = { default-features = false, path = "../../primitives/data-structs" }
 
 [dependencies.codec]
 default-features = false
modifiedpallets/evm-coder-substrate/src/lib.rsdiffbeforeafterboth
--- a/pallets/evm-coder-substrate/src/lib.rs
+++ b/pallets/evm-coder-substrate/src/lib.rs
@@ -18,33 +18,43 @@
 
 #[cfg(not(feature = "std"))]
 extern crate alloc;
+#[cfg(not(feature = "std"))]
+use alloc::format;
+use frame_support::dispatch::Weight;
+
+use core::marker::PhantomData;
+use sp_std::cell::RefCell;
+use sp_std::vec::Vec;
+
+use frame_support::pallet_prelude::DispatchError;
+use frame_support::traits::PalletInfo;
+use frame_support::{ensure, sp_runtime::ModuleError};
+use up_data_structs::budget;
+use pallet_evm::{
+	ExitError, ExitRevert, ExitSucceed, GasWeightMapping, PrecompileFailure, PrecompileOutput,
+	PrecompileResult, runner::stack::MaybeMirroredLog,
+};
+use ethereum::TransactionV2;
+use sp_core::{H160, H256};
+use pallet_ethereum::EthereumTransactionSender;
 // #[cfg(feature = "runtime-benchmarks")]
 // pub mod benchmarking;
 
+use evm_coder::{
+	ToLog,
+	abi::{AbiReader, AbiWrite, AbiWriter},
+	execution::{self, Result},
+	types::{Msg, value},
+};
+
 pub use pallet::*;
 
 #[frame_support::pallet]
 pub mod pallet {
-	#[cfg(not(feature = "std"))]
-	use alloc::format;
+	use super::*;
 
-	use evm_coder::{
-		ToLog,
-		abi::{AbiReader, AbiWrite, AbiWriter},
-		execution::{self, Result},
-		types::{Msg, value},
-	};
-	use frame_support::{ensure, sp_runtime::ModuleError};
-	use pallet_evm::{
-		ExitError, ExitRevert, ExitSucceed, GasWeightMapping, PrecompileFailure, PrecompileOutput,
-		PrecompileResult, runner::stack::MaybeMirroredLog,
-	};
 	use frame_system::ensure_signed;
 	pub use frame_support::dispatch::DispatchResult;
-	use pallet_ethereum::EthereumTransactionSender;
-	use sp_std::cell::RefCell;
-	use sp_std::vec::Vec;
-	use sp_core::H160;
 	use frame_support::{pallet_prelude::*, traits::PalletInfo};
 	use frame_system::pallet_prelude::*;
 
@@ -76,214 +86,258 @@
 			Ok(())
 		}
 	}
+}
 
-	// From instabul hardfork configuration: https://github.com/rust-blockchain/evm/blob/fd4fd6acc0ca3208d6770fdb3ba407c94cdf97c6/runtime/src/lib.rs#L284
-	pub const G_SLOAD_WORD: u64 = 800;
-	pub const G_SSTORE_WORD: u64 = 20000;
+// From instabul hardfork configuration: https://github.com/rust-blockchain/evm/blob/fd4fd6acc0ca3208d6770fdb3ba407c94cdf97c6/runtime/src/lib.rs#L284
+pub const G_SLOAD_WORD: u64 = 800;
+pub const G_SSTORE_WORD: u64 = 20000;
 
-	#[derive(Default)]
-	pub struct SubstrateRecorder<T: Config> {
-		contract: H160,
-		logs: RefCell<Vec<MaybeMirroredLog>>,
-		initial_gas: u64,
-		gas_limit: RefCell<u64>,
-		_phantom: PhantomData<*const T>,
+pub fn generate_transaction() -> TransactionV2 {
+	use ethereum::{TransactionV0, TransactionAction, TransactionSignature};
+	TransactionV2::Legacy(TransactionV0 {
+		nonce: 0.into(),
+		gas_price: 0.into(),
+		gas_limit: 0.into(),
+		action: TransactionAction::Call(H160([0; 20])),
+		value: 0.into(),
+		// zero selector, this transaction always has same sender, so all data should be acquired from logs
+		input: Vec::from([0, 0, 0, 0]),
+		// if v is not 27 - then we need to pass some other validity checks
+		signature: TransactionSignature::new(27, H256([0x88; 32]), H256([0x88; 32])).unwrap(),
+	})
+}
+
+pub struct GasCallsBudget<'r, T: Config> {
+	recorder: &'r SubstrateRecorder<T>,
+	gas_per_call: u64,
+}
+impl<T: Config> budget::Budget for GasCallsBudget<'_, T> {
+	fn consume_custom(&self, calls: u32) -> bool {
+		let (gas, overflown) = (calls as u64).overflowing_add(self.gas_per_call);
+		if overflown {
+			return false;
+		}
+		self.recorder.consume_gas(gas).is_ok()
 	}
+}
 
-	impl<T: Config> SubstrateRecorder<T> {
-		pub fn new(contract: H160, gas_limit: u64) -> Self {
-			Self {
-				contract,
-				logs: RefCell::new(Vec::new()),
-				initial_gas: gas_limit,
-				gas_limit: RefCell::new(gas_limit),
-				_phantom: PhantomData,
-			}
+#[derive(Default)]
+pub struct SubstrateRecorder<T: Config> {
+	contract: H160,
+	logs: RefCell<Vec<MaybeMirroredLog>>,
+	initial_gas: u64,
+	gas_limit: RefCell<u64>,
+	_phantom: PhantomData<*const T>,
+}
+
+impl<T: Config> SubstrateRecorder<T> {
+	pub fn new(contract: H160, gas_limit: u64) -> Self {
+		Self {
+			contract,
+			logs: RefCell::new(Vec::new()),
+			initial_gas: gas_limit,
+			gas_limit: RefCell::new(gas_limit),
+			_phantom: PhantomData,
 		}
+	}
+
+	pub fn is_empty(&self) -> bool {
+		self.logs.borrow().is_empty()
+	}
+	// Logs emitted with log_direct appear as substrate evm.Log event
+	pub fn log_direct(&self, log: impl ToLog) {
+		self.logs
+			.borrow_mut()
+			.push(MaybeMirroredLog::direct(log.to_log(self.contract)))
+	}
+	/// If log already has substrate equivalent - then we don't need to emit evm.Log
+	pub fn log_mirrored(&self, log: impl ToLog) {
+		self.logs
+			.borrow_mut()
+			.push(MaybeMirroredLog::mirrored(log.to_log(self.contract)))
+	}
+	pub fn retrieve_logs(self) -> Vec<MaybeMirroredLog> {
+		self.logs.into_inner()
+	}
 
-		pub fn is_empty(&self) -> bool {
-			self.logs.borrow().is_empty()
-		}
-		// Logs emitted with log_direct appear as substrate evm.Log event
-		pub fn log_direct(&self, log: impl ToLog) {
-			self.logs
-				.borrow_mut()
-				.push(MaybeMirroredLog::direct(log.to_log(self.contract)))
-		}
-		/// If log already has substrate equivalent - then we don't need to emit evm.Log
-		pub fn log_mirrored(&self, log: impl ToLog) {
-			self.logs
-				.borrow_mut()
-				.push(MaybeMirroredLog::mirrored(log.to_log(self.contract)))
+	pub fn gas_left(&self) -> u64 {
+		*self.gas_limit.borrow()
+	}
+	pub fn gas_calls_budget(&self, gas_per_call: u64) -> GasCallsBudget<T> {
+		GasCallsBudget {
+			recorder: self,
+			gas_per_call,
 		}
-		pub fn retrieve_logs(self) -> Vec<MaybeMirroredLog> {
-			self.logs.into_inner()
+	}
+	pub fn weight_calls_budget(&self, weight_per_call: Weight) -> GasCallsBudget<T> {
+		GasCallsBudget {
+			recorder: self,
+			gas_per_call: T::GasWeightMapping::weight_to_gas(weight_per_call),
 		}
+	}
+	pub fn consume_sload_sub(&self) -> DispatchResult {
+		self.consume_gas_sub(G_SLOAD_WORD)
+	}
+	pub fn consume_sstores_sub(&self, amount: usize) -> DispatchResult {
+		self.consume_gas_sub(G_SSTORE_WORD.saturating_mul(amount as u64))
+	}
+	pub fn consume_sstore_sub(&self) -> DispatchResult {
+		self.consume_gas_sub(G_SSTORE_WORD)
+	}
+	pub fn consume_gas_sub(&self, gas: u64) -> DispatchResult {
+		ensure!(gas != u64::MAX, Error::<T>::OutOfGas);
+		let mut gas_limit = self.gas_limit.borrow_mut();
+		ensure!(gas <= *gas_limit, Error::<T>::OutOfGas);
+		*gas_limit -= gas;
+		Ok(())
+	}
 
-		pub fn gas_left(&self) -> u64 {
-			*self.gas_limit.borrow()
+	pub fn consume_sload(&self) -> Result<()> {
+		self.consume_gas(G_SLOAD_WORD)
+	}
+	pub fn consume_sstore(&self) -> Result<()> {
+		self.consume_gas(G_SSTORE_WORD)
+	}
+	pub fn consume_gas(&self, gas: u64) -> Result<()> {
+		if gas == u64::MAX {
+			return Err(execution::Error::Error(ExitError::OutOfGas));
 		}
-		pub fn consume_sload_sub(&self) -> DispatchResult {
-			self.consume_gas_sub(G_SLOAD_WORD)
+		let mut gas_limit = self.gas_limit.borrow_mut();
+		if gas > *gas_limit {
+			return Err(execution::Error::Error(ExitError::OutOfGas));
 		}
-		pub fn consume_sstores_sub(&self, amount: usize) -> DispatchResult {
-			self.consume_gas_sub(G_SSTORE_WORD.saturating_mul(amount as u64))
-		}
-		pub fn consume_sstore_sub(&self) -> DispatchResult {
-			self.consume_gas_sub(G_SSTORE_WORD)
-		}
-		pub fn consume_gas_sub(&self, gas: u64) -> DispatchResult {
-			ensure!(gas != u64::MAX, Error::<T>::OutOfGas);
-			let mut gas_limit = self.gas_limit.borrow_mut();
-			ensure!(gas <= *gas_limit, Error::<T>::OutOfGas);
-			*gas_limit -= gas;
-			Ok(())
-		}
+		*gas_limit -= gas;
+		Ok(())
+	}
+	pub fn return_gas(&self, gas: u64) {
+		let mut gas_limit = self.gas_limit.borrow_mut();
+		*gas_limit += gas;
+	}
 
-		pub fn consume_sload(&self) -> Result<()> {
-			self.consume_gas(G_SLOAD_WORD)
-		}
-		pub fn consume_sstore(&self) -> Result<()> {
-			self.consume_gas(G_SSTORE_WORD)
-		}
-		pub fn consume_gas(&self, gas: u64) -> Result<()> {
-			if gas == u64::MAX {
-				return Err(execution::Error::Error(ExitError::OutOfGas));
-			}
-			let mut gas_limit = self.gas_limit.borrow_mut();
-			if gas > *gas_limit {
-				return Err(execution::Error::Error(ExitError::OutOfGas));
-			}
-			*gas_limit -= gas;
-			Ok(())
-		}
-		pub fn return_gas(&self, gas: u64) {
-			let mut gas_limit = self.gas_limit.borrow_mut();
-			*gas_limit += gas;
-		}
+	pub fn evm_to_precompile_output(
+		self,
+		result: evm_coder::execution::Result<Option<AbiWriter>>,
+	) -> Option<PrecompileResult> {
+		use evm_coder::execution::Error;
+		Some(match result {
+			Ok(Some(v)) => Ok(PrecompileOutput {
+				exit_status: ExitSucceed::Returned,
+				cost: self.initial_gas - self.gas_left(),
+				// TODO: preserve mirroring status
+				logs: self.retrieve_logs().into_iter().map(|l| l.log).collect(),
+				output: v.finish(),
+			}),
+			Ok(None) => return None,
+			Err(Error::Revert(e)) => {
+				let mut writer = AbiWriter::new_call(evm_coder::fn_selector!(Error(string)));
+				(&e as &str).abi_write(&mut writer);
 
-		pub fn evm_to_precompile_output(
-			self,
-			result: evm_coder::execution::Result<Option<AbiWriter>>,
-		) -> Option<PrecompileResult> {
-			use evm_coder::execution::Error;
-			Some(match result {
-				Ok(Some(v)) => Ok(PrecompileOutput {
-					exit_status: ExitSucceed::Returned,
+				Err(PrecompileFailure::Revert {
+					exit_status: ExitRevert::Reverted,
 					cost: self.initial_gas - self.gas_left(),
-					// TODO: preserve mirroring status
-					logs: self.retrieve_logs().into_iter().map(|l| l.log).collect(),
-					output: v.finish(),
-				}),
-				Ok(None) => return None,
-				Err(Error::Revert(e)) => {
-					let mut writer = AbiWriter::new_call(evm_coder::fn_selector!(Error(string)));
-					(&e as &str).abi_write(&mut writer);
+					output: writer.finish(),
+				})
+			}
+			Err(Error::Fatal(f)) => Err(f.into()),
+			Err(Error::Error(e)) => Err(e.into()),
+		})
+	}
 
-					Err(PrecompileFailure::Revert {
-						exit_status: ExitRevert::Reverted,
-						cost: self.initial_gas - self.gas_left(),
-						output: writer.finish(),
-					})
-				}
-				Err(Error::Fatal(f)) => Err(f.into()),
-				Err(Error::Error(e)) => Err(e.into()),
-			})
+	pub fn submit_logs(self) {
+		let logs = self.retrieve_logs();
+		if logs.is_empty() {
+			return;
 		}
+		T::EthereumTransactionSender::submit_logs_transaction(
+			Default::default(),
+			generate_transaction(),
+			logs,
+		)
+	}
+}
 
-		pub fn submit_logs(self) {
-			let logs = self.retrieve_logs();
-			if logs.is_empty() {
-				return;
+pub fn dispatch_to_evm<T: Config>(err: DispatchError) -> evm_coder::execution::Error {
+	use evm_coder::execution::Error as ExError;
+	match err {
+		DispatchError::Module(ModuleError { index, error, .. })
+			if index
+				== T::PalletInfo::index::<Pallet<T>>()
+					.expect("evm-coder-substrate is a pallet, which should be added to runtime")
+					as u8 =>
+		{
+			match error {
+				v if v == Error::<T>::OutOfGas.as_u8() => ExError::Error(ExitError::OutOfGas),
+				v if v == Error::<T>::OutOfFund.as_u8() => ExError::Error(ExitError::OutOfFund),
+				_ => unreachable!("this pallet only defines two possible errors"),
 			}
-			T::EthereumTransactionSender::submit_logs_transaction(Default::default(), logs)
 		}
+		DispatchError::Module(ModuleError {
+			message: Some(msg), ..
+		}) => ExError::Revert(msg.into()),
+		DispatchError::Module(ModuleError { index, error, .. }) => {
+			ExError::Revert(format!("error {} in pallet {}", error, index))
+		}
+		e => ExError::Revert(format!("substrate error: {:?}", e)),
 	}
+}
+
+pub trait WithRecorder<T: Config> {
+	fn recorder(&self) -> &SubstrateRecorder<T>;
+	fn into_recorder(self) -> SubstrateRecorder<T>;
+}
 
-	pub fn dispatch_to_evm<T: Config>(err: DispatchError) -> evm_coder::execution::Error {
-		use evm_coder::execution::Error as ExError;
-		match err {
-			DispatchError::Module(ModuleError { index, error, .. })
-				if index
-					== T::PalletInfo::index::<Pallet<T>>()
-						.expect("evm-coder-substrate is a pallet, which should be added to runtime")
-						as u8 =>
-			{
-				let mut read = &error as &[u8];
-				match Error::<T>::decode(&mut read) {
-					Ok(Error::<T>::OutOfGas) => ExError::Error(ExitError::OutOfGas),
-					Ok(Error::<T>::OutOfFund) => ExError::Error(ExitError::OutOfFund),
-					_ => unreachable!("this pallet only defines two possible errors"),
-				}
-			}
-			DispatchError::Module(ModuleError {
-				message: Some(msg), ..
-			}) => ExError::Revert(msg.into()),
-			DispatchError::Module(ModuleError { index, error, .. }) => {
-				ExError::Revert(format!("error {:?} in pallet {}", error, index))
-			}
-			e => ExError::Revert(format!("substrate error: {:?}", e)),
-		}
-	}
+/// Helper to simplify implementing bridge between evm-coder definitions and pallet-evm
+pub fn call<
+	T: Config,
+	C: evm_coder::Call + evm_coder::Weighted,
+	E: evm_coder::Callable<C> + WithRecorder<T>,
+>(
+	caller: H160,
+	mut e: E,
+	value: value,
+	input: &[u8],
+) -> Option<PrecompileResult> {
+	let result = call_internal(caller, &mut e, value, input);
+	e.into_recorder().evm_to_precompile_output(result)
+}
 
-	pub trait WithRecorder<T: Config> {
-		fn recorder(&self) -> &SubstrateRecorder<T>;
-		fn into_recorder(self) -> SubstrateRecorder<T>;
+fn call_internal<
+	T: Config,
+	C: evm_coder::Call + evm_coder::Weighted,
+	E: evm_coder::Callable<C> + WithRecorder<T>,
+>(
+	caller: H160,
+	e: &mut E,
+	value: value,
+	input: &[u8],
+) -> evm_coder::execution::Result<Option<AbiWriter>> {
+	let (selector, mut reader) = AbiReader::new_call(input)?;
+	let call = C::parse(selector, &mut reader)?;
+	if call.is_none() {
+		return Ok(None);
 	}
+	let call = call.unwrap();
 
-	/// Helper to simplify implementing bridge between evm-coder definitions and pallet-evm
-	pub fn call<
-		T: Config,
-		C: evm_coder::Call + evm_coder::Weighted,
-		E: evm_coder::Callable<C> + WithRecorder<T>,
-	>(
-		caller: H160,
-		mut e: E,
-		value: value,
-		input: &[u8],
-	) -> Option<PrecompileResult> {
-		let result = call_internal(caller, &mut e, value, input);
-		e.into_recorder().evm_to_precompile_output(result)
-	}
+	let dispatch_info = call.weight();
+	e.recorder()
+		.consume_gas(T::GasWeightMapping::weight_to_gas(dispatch_info.weight))?;
 
-	fn call_internal<
-		T: Config,
-		C: evm_coder::Call + evm_coder::Weighted,
-		E: evm_coder::Callable<C> + WithRecorder<T>,
-	>(
-		caller: H160,
-		e: &mut E,
-		value: value,
-		input: &[u8],
-	) -> evm_coder::execution::Result<Option<AbiWriter>> {
-		let (selector, mut reader) = AbiReader::new_call(input)?;
-		let call = C::parse(selector, &mut reader)?;
-		if call.is_none() {
-			return Ok(None);
+	match e.call(Msg {
+		call,
+		caller,
+		value,
+	}) {
+		Ok(v) => {
+			let unspent = v.post_info.calc_unspent(&dispatch_info);
+			e.recorder()
+				.return_gas(T::GasWeightMapping::weight_to_gas(unspent));
+			Ok(Some(v.data))
 		}
-		let call = call.unwrap();
-
-		let dispatch_info = call.weight();
-		e.recorder()
-			.consume_gas(T::GasWeightMapping::weight_to_gas(dispatch_info.weight))?;
-
-		match e.call(Msg {
-			call,
-			caller,
-			value,
-		}) {
-			Ok(v) => {
-				let unspent = v.post_info.calc_unspent(&dispatch_info);
-				e.recorder()
-					.return_gas(T::GasWeightMapping::weight_to_gas(unspent));
-				Ok(Some(v.data))
-			}
-			Err(v) => {
-				let unspent = v.post_info.calc_unspent(&dispatch_info);
-				e.recorder()
-					.return_gas(T::GasWeightMapping::weight_to_gas(unspent));
-				Err(v.data)
-			}
+		Err(v) => {
+			let unspent = v.post_info.calc_unspent(&dispatch_info);
+			e.recorder()
+				.return_gas(T::GasWeightMapping::weight_to_gas(unspent));
+			Err(v.data)
 		}
 	}
 }
modifiedpallets/fungible/src/benchmarking.rsdiffbeforeafterboth
--- a/pallets/fungible/src/benchmarking.rs
+++ b/pallets/fungible/src/benchmarking.rs
@@ -20,7 +20,7 @@
 use sp_std::prelude::*;
 use pallet_common::benchmarking::create_collection_raw;
 use frame_benchmarking::{benchmarks, account};
-use up_data_structs::{CollectionMode, MAX_ITEMS_PER_BATCH};
+use up_data_structs::{CollectionMode, MAX_ITEMS_PER_BATCH, budget::Unlimited};
 use pallet_common::bench_init;
 
 const SEED: u32 = 1;
@@ -52,7 +52,7 @@
 			bench_init!(to: cross_sub(i););
 			(to, 200)
 		}).collect::<BTreeMap<_, _>>().try_into().unwrap();
-	}: {<Pallet<T>>::create_multiple_items(&collection, &sender, data)}
+	}: {<Pallet<T>>::create_multiple_items(&collection, &sender, data)?}
 
 	burn_item {
 		bench_init!{
@@ -85,7 +85,7 @@
 		};
 		<Pallet<T>>::create_item(&collection, &owner, (sender.clone(), 200))?;
 		<Pallet<T>>::set_allowance(&collection, &sender, &spender, 200)?;
-	}: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, 100)?}
+	}: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, 100, &Unlimited)?}
 
 	burn_from {
 		bench_init!{
@@ -94,5 +94,5 @@
 		};
 		<Pallet<T>>::create_item(&collection, &owner, (sender.clone(), 200))?;
 		<Pallet<T>>::set_allowance(&collection, &sender, &burner, 200)?;
-	}: {<Pallet<T>>::burn_from(&collection, &burner, &sender, 100)?}
+	}: {<Pallet<T>>::burn_from(&collection, &burner, &sender, 100, &Unlimited)?}
 }
modifiedpallets/fungible/src/common.rsdiffbeforeafterboth
--- a/pallets/fungible/src/common.rs
+++ b/pallets/fungible/src/common.rs
@@ -17,7 +17,7 @@
 use core::marker::PhantomData;
 
 use frame_support::{dispatch::DispatchResultWithPostInfo, ensure, fail, weights::Weight, BoundedVec};
-use up_data_structs::{TokenId, CreateItemExData};
+use up_data_structs::{TokenId, CreateItemExData, budget::Budget};
 use pallet_common::{CommonCollectionOperations, CommonWeightInfo, with_weight};
 use sp_runtime::ArithmeticError;
 use sp_std::{vec::Vec, vec};
@@ -189,6 +189,7 @@
 		to: T::CrossAccountId,
 		token: TokenId,
 		amount: u128,
+		nesting_budget: &dyn Budget,
 	) -> DispatchResultWithPostInfo {
 		ensure!(
 			token == TokenId::default(),
@@ -196,7 +197,7 @@
 		);
 
 		with_weight(
-			<Pallet<T>>::transfer_from(self, &sender, &from, &to, amount),
+			<Pallet<T>>::transfer_from(self, &sender, &from, &to, amount, nesting_budget),
 			<CommonWeights<T>>::transfer_from(),
 		)
 	}
@@ -207,6 +208,7 @@
 		from: T::CrossAccountId,
 		token: TokenId,
 		amount: u128,
+		nesting_budget: &dyn Budget,
 	) -> DispatchResultWithPostInfo {
 		ensure!(
 			token == TokenId::default(),
@@ -214,7 +216,7 @@
 		);
 
 		with_weight(
-			<Pallet<T>>::burn_from(self, &sender, &from, amount),
+			<Pallet<T>>::burn_from(self, &sender, &from, amount, nesting_budget),
 			<CommonWeights<T>>::burn_from(),
 		)
 	}
modifiedpallets/fungible/src/erc.rsdiffbeforeafterboth
--- a/pallets/fungible/src/erc.rs
+++ b/pallets/fungible/src/erc.rs
@@ -23,6 +23,7 @@
 use sp_std::vec::Vec;
 use pallet_evm::account::CrossAccountId;
 use pallet_evm_coder_substrate::{call, dispatch_to_evm};
+use pallet_structure::{SelfWeightOf as StructureWeight, weights::WeightInfo as _};
 
 use crate::{
 	Allowance, Balance, Config, FungibleHandle, Pallet, SelfWeightOf, TotalSupply,
@@ -96,8 +97,11 @@
 		let from = T::CrossAccountId::from_eth(from);
 		let to = T::CrossAccountId::from_eth(to);
 		let amount = amount.try_into().map_err(|_| "amount overflow")?;
+		let budget = self
+			.recorder
+			.weight_calls_budget(<StructureWeight<T>>::find_parent());
 
-		<Pallet<T>>::transfer_from(self, &caller, &from, &to, amount)
+		<Pallet<T>>::transfer_from(self, &caller, &from, &to, amount, &budget)
 			.map_err(dispatch_to_evm::<T>)?;
 		Ok(true)
 	}
@@ -127,8 +131,12 @@
 		let caller = T::CrossAccountId::from_eth(caller);
 		let from = T::CrossAccountId::from_eth(from);
 		let amount = amount.try_into().map_err(|_| "amount overflow")?;
+		let budget = self
+			.recorder
+			.weight_calls_budget(<StructureWeight<T>>::find_parent());
 
-		<Pallet<T>>::burn_from(self, &caller, &from, amount).map_err(dispatch_to_evm::<T>)?;
+		<Pallet<T>>::burn_from(self, &caller, &from, amount, &budget)
+			.map_err(dispatch_to_evm::<T>)?;
 		Ok(true)
 	}
 }
modifiedpallets/fungible/src/lib.rsdiffbeforeafterboth
--- a/pallets/fungible/src/lib.rs
+++ b/pallets/fungible/src/lib.rs
@@ -21,6 +21,7 @@
 use pallet_evm::account::CrossAccountId;
 use up_data_structs::{
 	AccessMode, CollectionId, TokenId, CreateCollectionData, mapping::TokenAddressMapping,
+	budget::Budget,
 };
 use pallet_common::{
 	Error as CommonError, Event as CommonEvent, Pallet as PalletCommon,
@@ -361,6 +362,7 @@
 		spender: &T::CrossAccountId,
 		from: &T::CrossAccountId,
 		amount: u128,
+		nesting_budget: &dyn Budget,
 	) -> Result<Option<u128>, DispatchError> {
 		if spender.conv_eq(from) {
 			return Ok(None);
@@ -372,7 +374,12 @@
 		if let Some(source) = T::CrossTokenAddressMapping::address_to_token(from) {
 			// TODO: should collection owner be allowed to perform this transfer?
 			ensure!(
-				<PalletStructure<T>>::indirectly_owned(spender.clone(), source.0, source.1, 1)?,
+				<PalletStructure<T>>::indirectly_owned(
+					spender.clone(),
+					source.0,
+					source.1,
+					nesting_budget
+				)?,
 				<CommonError<T>>::ApprovedValueTooLow,
 			);
 			return Ok(None);
@@ -394,8 +401,9 @@
 		from: &T::CrossAccountId,
 		to: &T::CrossAccountId,
 		amount: u128,
+		nesting_budget: &dyn Budget,
 	) -> DispatchResult {
-		let allowance = Self::check_allowed(collection, spender, from, amount)?;
+		let allowance = Self::check_allowed(collection, spender, from, amount, nesting_budget)?;
 
 		// =========
 
@@ -411,8 +419,9 @@
 		spender: &T::CrossAccountId,
 		from: &T::CrossAccountId,
 		amount: u128,
+		nesting_budget: &dyn Budget,
 	) -> DispatchResult {
-		let allowance = Self::check_allowed(collection, spender, from, amount)?;
+		let allowance = Self::check_allowed(collection, spender, from, amount, nesting_budget)?;
 
 		// =========
 
modifiedpallets/nonfungible/src/benchmarking.rsdiffbeforeafterboth
--- a/pallets/nonfungible/src/benchmarking.rs
+++ b/pallets/nonfungible/src/benchmarking.rs
@@ -20,7 +20,7 @@
 use sp_std::prelude::*;
 use pallet_common::benchmarking::{create_collection_raw, create_data, create_var_data};
 use frame_benchmarking::{benchmarks, account};
-use up_data_structs::{CollectionMode, MAX_ITEMS_PER_BATCH, CUSTOM_DATA_LIMIT};
+use up_data_structs::{CollectionMode, MAX_ITEMS_PER_BATCH, CUSTOM_DATA_LIMIT, budget::Unlimited};
 use pallet_common::bench_init;
 use core::convert::TryInto;
 
@@ -115,7 +115,7 @@
 		};
 		let item = create_max_item(&collection, &owner, sender.clone())?;
 		<Pallet<T>>::set_allowance(&collection, &sender, item, Some(&spender))?;
-	}: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item)?}
+	}: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item, &Unlimited)?}
 
 	burn_from {
 		bench_init!{
@@ -124,7 +124,7 @@
 		};
 		let item = create_max_item(&collection, &owner, sender.clone())?;
 		<Pallet<T>>::set_allowance(&collection, &sender, item, Some(&burner))?;
-	}: {<Pallet<T>>::burn_from(&collection, &burner, &sender, item)?}
+	}: {<Pallet<T>>::burn_from(&collection, &burner, &sender, item, &Unlimited)?}
 
 	set_variable_metadata {
 		let b in 0..CUSTOM_DATA_LIMIT;
modifiedpallets/nonfungible/src/common.rsdiffbeforeafterboth
--- a/pallets/nonfungible/src/common.rs
+++ b/pallets/nonfungible/src/common.rs
@@ -17,7 +17,7 @@
 use core::marker::PhantomData;
 
 use frame_support::{dispatch::DispatchResultWithPostInfo, ensure, fail, weights::Weight, BoundedVec};
-use up_data_structs::{TokenId, CustomDataLimit, CreateItemExData, CollectionId};
+use up_data_structs::{TokenId, CustomDataLimit, CreateItemExData, CollectionId, budget::Budget};
 use pallet_common::{CommonCollectionOperations, CommonWeightInfo, with_weight};
 use sp_runtime::DispatchError;
 use sp_std::vec::Vec;
@@ -192,12 +192,13 @@
 		to: T::CrossAccountId,
 		token: TokenId,
 		amount: u128,
+		nesting_budget: &dyn Budget,
 	) -> DispatchResultWithPostInfo {
 		ensure!(amount <= 1, <Error<T>>::NonfungibleItemsHaveNoAmount);
 
 		if amount == 1 {
 			with_weight(
-				<Pallet<T>>::transfer_from(self, &sender, &from, &to, token),
+				<Pallet<T>>::transfer_from(self, &sender, &from, &to, token, nesting_budget),
 				<CommonWeights<T>>::transfer_from(),
 			)
 		} else {
@@ -211,12 +212,13 @@
 		from: T::CrossAccountId,
 		token: TokenId,
 		amount: u128,
+		nesting_budget: &dyn Budget,
 	) -> DispatchResultWithPostInfo {
 		ensure!(amount <= 1, <Error<T>>::NonfungibleItemsHaveNoAmount);
 
 		if amount == 1 {
 			with_weight(
-				<Pallet<T>>::burn_from(self, &sender, &from, token),
+				<Pallet<T>>::burn_from(self, &sender, &from, token, nesting_budget),
 				<CommonWeights<T>>::burn_from(),
 			)
 		} else {
modifiedpallets/nonfungible/src/erc.rsdiffbeforeafterboth
--- a/pallets/nonfungible/src/erc.rs
+++ b/pallets/nonfungible/src/erc.rs
@@ -30,6 +30,7 @@
 };
 use pallet_evm::account::CrossAccountId;
 use pallet_evm_coder_substrate::call;
+use pallet_structure::{SelfWeightOf as StructureWeight, weights::WeightInfo as _};
 
 use crate::{
 	AccountBalance, Config, CreateItemData, NonfungibleHandle, Pallet, TokenData, TokensMinted,
@@ -180,8 +181,11 @@
 		let from = T::CrossAccountId::from_eth(from);
 		let to = T::CrossAccountId::from_eth(to);
 		let token = token_id.try_into()?;
+		let budget = self
+			.recorder
+			.weight_calls_budget(<StructureWeight<T>>::find_parent());
 
-		<Pallet<T>>::transfer_from(self, &caller, &from, &to, token)
+		<Pallet<T>>::transfer_from(self, &caller, &from, &to, token, &budget)
 			.map_err(dispatch_to_evm::<T>)?;
 		Ok(())
 	}
@@ -350,8 +354,12 @@
 		let caller = T::CrossAccountId::from_eth(caller);
 		let from = T::CrossAccountId::from_eth(from);
 		let token = token_id.try_into()?;
+		let budget = self
+			.recorder
+			.weight_calls_budget(<StructureWeight<T>>::find_parent());
 
-		<Pallet<T>>::burn_from(self, &caller, &from, token).map_err(dispatch_to_evm::<T>)?;
+		<Pallet<T>>::burn_from(self, &caller, &from, token, &budget)
+			.map_err(dispatch_to_evm::<T>)?;
 		Ok(())
 	}
 
modifiedpallets/nonfungible/src/lib.rsdiffbeforeafterboth
--- a/pallets/nonfungible/src/lib.rs
+++ b/pallets/nonfungible/src/lib.rs
@@ -20,7 +20,7 @@
 use frame_support::{BoundedVec, ensure, fail};
 use up_data_structs::{
 	AccessMode, CollectionId, CustomDataLimit, TokenId, CreateCollectionData, CreateNftExData,
-	mapping::TokenAddressMapping, NestingRule,
+	mapping::TokenAddressMapping, NestingRule, budget::Budget,
 };
 use pallet_evm::account::CrossAccountId;
 use pallet_common::{
@@ -511,6 +511,7 @@
 		spender: &T::CrossAccountId,
 		from: &T::CrossAccountId,
 		token: TokenId,
+		nesting_budget: &dyn Budget,
 	) -> DispatchResult {
 		if spender.conv_eq(from) {
 			return Ok(());
@@ -522,7 +523,12 @@
 		if let Some(source) = T::CrossTokenAddressMapping::address_to_token(from) {
 			// TODO: should collection owner be allowed to perform this transfer?
 			ensure!(
-				<PalletStructure<T>>::indirectly_owned(spender.clone(), source.0, source.1, 1)?,
+				<PalletStructure<T>>::indirectly_owned(
+					spender.clone(),
+					source.0,
+					source.1,
+					nesting_budget
+				)?,
 				<CommonError<T>>::ApprovedValueTooLow,
 			);
 			return Ok(());
@@ -543,8 +549,9 @@
 		from: &T::CrossAccountId,
 		to: &T::CrossAccountId,
 		token: TokenId,
+		nesting_budget: &dyn Budget,
 	) -> DispatchResult {
-		Self::check_allowed(collection, spender, from, token)?;
+		Self::check_allowed(collection, spender, from, token, nesting_budget)?;
 
 		// =========
 
@@ -557,8 +564,9 @@
 		spender: &T::CrossAccountId,
 		from: &T::CrossAccountId,
 		token: TokenId,
+		nesting_budget: &dyn Budget,
 	) -> DispatchResult {
-		Self::check_allowed(collection, spender, from, token)?;
+		Self::check_allowed(collection, spender, from, token, nesting_budget)?;
 
 		// =========
 
modifiedpallets/refungible/src/benchmarking.rsdiffbeforeafterboth
--- a/pallets/refungible/src/benchmarking.rs
+++ b/pallets/refungible/src/benchmarking.rs
@@ -20,7 +20,7 @@
 use sp_std::prelude::*;
 use pallet_common::benchmarking::{create_collection_raw, create_data, create_var_data};
 use frame_benchmarking::{benchmarks, account};
-use up_data_structs::{CollectionMode, MAX_ITEMS_PER_BATCH, CUSTOM_DATA_LIMIT};
+use up_data_structs::{CollectionMode, MAX_ITEMS_PER_BATCH, CUSTOM_DATA_LIMIT, budget::Unlimited};
 use pallet_common::bench_init;
 use core::convert::TryInto;
 use core::iter::IntoIterator;
@@ -165,7 +165,7 @@
 		};
 		let item = create_max_item(&collection, &owner, [(sender.clone(), 200), (receiver.clone(), 200)])?;
 		<Pallet<T>>::set_allowance(&collection, &sender, &spender, item, 100)?;
-	}: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item, 100)?}
+	}: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item, 100, &Unlimited)?}
 	// Target account is created
 	transfer_from_creating {
 		bench_init!{
@@ -174,7 +174,7 @@
 		};
 		let item = create_max_item(&collection, &owner, [(sender.clone(), 200)])?;
 		<Pallet<T>>::set_allowance(&collection, &sender, &spender, item, 100)?;
-	}: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item, 100)?}
+	}: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item, 100, &Unlimited)?}
 	// Source account is destroyed
 	transfer_from_removing {
 		bench_init!{
@@ -183,7 +183,7 @@
 		};
 		let item = create_max_item(&collection, &owner, [(sender.clone(), 200), (receiver.clone(), 200)])?;
 		<Pallet<T>>::set_allowance(&collection, &sender, &spender, item, 200)?;
-	}: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item, 200)?}
+	}: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item, 200, &Unlimited)?}
 	// Source account destroyed, target created
 	transfer_from_creating_removing {
 		bench_init!{
@@ -192,7 +192,7 @@
 		};
 		let item = create_max_item(&collection, &owner, [(sender.clone(), 200)])?;
 		<Pallet<T>>::set_allowance(&collection, &sender, &spender, item, 200)?;
-	}: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item, 200)?}
+	}: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item, 200, &Unlimited)?}
 
 	// Both source account and token is destroyed
 	burn_from {
@@ -202,7 +202,7 @@
 		};
 		let item = create_max_item(&collection, &owner, [(sender.clone(), 200)])?;
 		<Pallet<T>>::set_allowance(&collection, &sender, &burner, item, 200)?;
-	}: {<Pallet<T>>::burn_from(&collection, &burner, &sender, item, 200)?}
+	}: {<Pallet<T>>::burn_from(&collection, &burner, &sender, item, 200, &Unlimited)?}
 
 	set_variable_metadata {
 		let b in 0..CUSTOM_DATA_LIMIT;
modifiedpallets/refungible/src/common.rsdiffbeforeafterboth
--- a/pallets/refungible/src/common.rs
+++ b/pallets/refungible/src/common.rs
@@ -18,7 +18,9 @@
 
 use sp_std::collections::btree_map::BTreeMap;
 use frame_support::{dispatch::DispatchResultWithPostInfo, fail, weights::Weight, BoundedVec};
-use up_data_structs::{TokenId, CustomDataLimit, CreateItemExData, CreateRefungibleExData};
+use up_data_structs::{
+	TokenId, CustomDataLimit, CreateItemExData, CreateRefungibleExData, budget::Budget,
+};
 use pallet_common::{CommonCollectionOperations, CommonWeightInfo, with_weight};
 use sp_runtime::DispatchError;
 use sp_std::{vec::Vec, vec};
@@ -210,9 +212,10 @@
 		to: T::CrossAccountId,
 		token: TokenId,
 		amount: u128,
+		nesting_budget: &dyn Budget,
 	) -> DispatchResultWithPostInfo {
 		with_weight(
-			<Pallet<T>>::transfer_from(self, &sender, &from, &to, token, amount),
+			<Pallet<T>>::transfer_from(self, &sender, &from, &to, token, amount, nesting_budget),
 			<CommonWeights<T>>::transfer_from(),
 		)
 	}
@@ -223,9 +226,10 @@
 		from: T::CrossAccountId,
 		token: TokenId,
 		amount: u128,
+		nesting_budget: &dyn Budget,
 	) -> DispatchResultWithPostInfo {
 		with_weight(
-			<Pallet<T>>::burn_from(self, &sender, &from, token, amount),
+			<Pallet<T>>::burn_from(self, &sender, &from, token, amount, nesting_budget),
 			<CommonWeights<T>>::burn_from(),
 		)
 	}
modifiedpallets/refungible/src/lib.rsdiffbeforeafterboth
before · pallets/refungible/src/lib.rs
1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617#![cfg_attr(not(feature = "std"), no_std)]1819use frame_support::{ensure, BoundedVec};20use up_data_structs::{21	AccessMode, CollectionId, CustomDataLimit, MAX_REFUNGIBLE_PIECES, TokenId,22	CreateCollectionData, CreateRefungibleExData, mapping::TokenAddressMapping,23};24use pallet_evm::account::CrossAccountId;25use pallet_common::{26	Error as CommonError, Event as CommonEvent, Pallet as PalletCommon,27	CollectionHandle, dispatch::CollectionDispatch,28};29use pallet_structure::Pallet as PalletStructure;30use sp_runtime::{ArithmeticError, DispatchError, DispatchResult};31use sp_std::{vec::Vec, vec, collections::btree_map::BTreeMap};32use core::ops::Deref;33use codec::{Encode, Decode, MaxEncodedLen};34use scale_info::TypeInfo;3536pub use pallet::*;37#[cfg(feature = "runtime-benchmarks")]38pub mod benchmarking;39pub mod common;40pub mod erc;41pub mod weights;42pub(crate) type SelfWeightOf<T> = <T as Config>::WeightInfo;4344#[derive(Encode, Decode, Default, TypeInfo, MaxEncodedLen)]45pub struct ItemData {46	pub const_data: BoundedVec<u8, CustomDataLimit>,47	pub variable_data: BoundedVec<u8, CustomDataLimit>,48}4950#[frame_support::pallet]51pub mod pallet {52	use super::*;53	use frame_support::{Blake2_128, Blake2_128Concat, Twox64Concat, pallet_prelude::*, storage::Key};54	use up_data_structs::{CollectionId, TokenId};55	use super::weights::WeightInfo;5657	#[pallet::error]58	pub enum Error<T> {59		/// Not Refungible item data used to mint in Refungible collection.60		NotRefungibleDataUsedToMintFungibleCollectionToken,61		/// Maximum refungibility exceeded62		WrongRefungiblePieces,63		/// Refungible token can't nest other tokens64		RefungibleDisallowsNesting,65	}6667	#[pallet::config]68	pub trait Config:69		frame_system::Config + pallet_common::Config + pallet_structure::Config70	{71		type WeightInfo: WeightInfo;72	}7374	#[pallet::pallet]75	#[pallet::generate_store(pub(super) trait Store)]76	pub struct Pallet<T>(_);7778	#[pallet::storage]79	pub type TokensMinted<T: Config> =80		StorageMap<Hasher = Twox64Concat, Key = CollectionId, Value = u32, QueryKind = ValueQuery>;81	#[pallet::storage]82	pub type TokensBurnt<T: Config> =83		StorageMap<Hasher = Twox64Concat, Key = CollectionId, Value = u32, QueryKind = ValueQuery>;8485	#[pallet::storage]86	pub type TokenData<T: Config> = StorageNMap<87		Key = (Key<Twox64Concat, CollectionId>, Key<Twox64Concat, TokenId>),88		Value = ItemData,89		QueryKind = ValueQuery,90	>;9192	#[pallet::storage]93	pub type TotalSupply<T: Config> = StorageNMap<94		Key = (Key<Twox64Concat, CollectionId>, Key<Twox64Concat, TokenId>),95		Value = u128,96		QueryKind = ValueQuery,97	>;9899	/// Used to enumerate tokens owned by account100	#[pallet::storage]101	pub type Owned<T: Config> = StorageNMap<102		Key = (103			Key<Twox64Concat, CollectionId>,104			Key<Blake2_128Concat, T::CrossAccountId>,105			Key<Twox64Concat, TokenId>,106		),107		Value = bool,108		QueryKind = ValueQuery,109	>;110111	#[pallet::storage]112	pub type AccountBalance<T: Config> = StorageNMap<113		Key = (114			Key<Twox64Concat, CollectionId>,115			// Owner116			Key<Blake2_128Concat, T::CrossAccountId>,117		),118		Value = u32,119		QueryKind = ValueQuery,120	>;121122	#[pallet::storage]123	pub type Balance<T: Config> = StorageNMap<124		Key = (125			Key<Twox64Concat, CollectionId>,126			Key<Twox64Concat, TokenId>,127			// Owner128			Key<Blake2_128Concat, T::CrossAccountId>,129		),130		Value = u128,131		QueryKind = ValueQuery,132	>;133134	#[pallet::storage]135	pub type Allowance<T: Config> = StorageNMap<136		Key = (137			Key<Twox64Concat, CollectionId>,138			Key<Twox64Concat, TokenId>,139			// Owner140			Key<Blake2_128, T::CrossAccountId>,141			// Spender142			Key<Blake2_128Concat, T::CrossAccountId>,143		),144		Value = u128,145		QueryKind = ValueQuery,146	>;147}148149pub struct RefungibleHandle<T: Config>(pallet_common::CollectionHandle<T>);150impl<T: Config> RefungibleHandle<T> {151	pub fn cast(inner: pallet_common::CollectionHandle<T>) -> Self {152		Self(inner)153	}154	pub fn into_inner(self) -> pallet_common::CollectionHandle<T> {155		self.0156	}157}158impl<T: Config> Deref for RefungibleHandle<T> {159	type Target = pallet_common::CollectionHandle<T>;160161	fn deref(&self) -> &Self::Target {162		&self.0163	}164}165166impl<T: Config> Pallet<T> {167	pub fn total_supply(collection: &RefungibleHandle<T>) -> u32 {168		<TokensMinted<T>>::get(collection.id) - <TokensBurnt<T>>::get(collection.id)169	}170	pub fn token_exists(collection: &RefungibleHandle<T>, token: TokenId) -> bool {171		<TotalSupply<T>>::contains_key((collection.id, token))172	}173}174175// unchecked calls skips any permission checks176impl<T: Config> Pallet<T> {177	pub fn init_collection(178		owner: T::AccountId,179		data: CreateCollectionData<T::AccountId>,180	) -> Result<CollectionId, DispatchError> {181		<PalletCommon<T>>::init_collection(owner, data)182	}183	pub fn destroy_collection(184		collection: RefungibleHandle<T>,185		sender: &T::CrossAccountId,186	) -> DispatchResult {187		let id = collection.id;188189		// =========190191		PalletCommon::destroy_collection(collection.0, sender)?;192193		<TokensMinted<T>>::remove(id);194		<TokensBurnt<T>>::remove(id);195		<TokenData<T>>::remove_prefix((id,), None);196		<TotalSupply<T>>::remove_prefix((id,), None);197		<Balance<T>>::remove_prefix((id,), None);198		<Allowance<T>>::remove_prefix((id,), None);199		<Owned<T>>::remove_prefix((id,), None);200		<AccountBalance<T>>::remove_prefix((id,), None);201		Ok(())202	}203204	pub fn burn_token(collection: &RefungibleHandle<T>, token_id: TokenId) -> DispatchResult {205		let burnt = <TokensBurnt<T>>::get(collection.id)206			.checked_add(1)207			.ok_or(ArithmeticError::Overflow)?;208209		<TokensBurnt<T>>::insert(collection.id, burnt);210		<TokenData<T>>::remove((collection.id, token_id));211		<TotalSupply<T>>::remove((collection.id, token_id));212		<Balance<T>>::remove_prefix((collection.id, token_id), None);213		<Allowance<T>>::remove_prefix((collection.id, token_id), None);214		// TODO: ERC721 transfer event215		Ok(())216	}217218	pub fn burn(219		collection: &RefungibleHandle<T>,220		owner: &T::CrossAccountId,221		token: TokenId,222		amount: u128,223	) -> DispatchResult {224		let total_supply = <TotalSupply<T>>::get((collection.id, token))225			.checked_sub(amount)226			.ok_or(<CommonError<T>>::TokenValueTooLow)?;227228		// This was probally last owner of this token?229		if total_supply == 0 {230			// Ensure user actually owns this amount231			ensure!(232				<Balance<T>>::get((collection.id, token, owner)) == amount,233				<CommonError<T>>::TokenValueTooLow234			);235			let account_balance = <AccountBalance<T>>::get((collection.id, owner))236				.checked_sub(1)237				// Should not occur238				.ok_or(ArithmeticError::Underflow)?;239240			// =========241242			<Owned<T>>::remove((collection.id, owner, token));243			<AccountBalance<T>>::insert((collection.id, owner), account_balance);244			Self::burn_token(collection, token)?;245			<PalletCommon<T>>::deposit_event(CommonEvent::ItemDestroyed(246				collection.id,247				token,248				owner.clone(),249				amount,250			));251			return Ok(());252		}253254		let balance = <Balance<T>>::get((collection.id, token, owner))255			.checked_sub(amount)256			.ok_or(<CommonError<T>>::TokenValueTooLow)?;257		let account_balance = if balance == 0 {258			<AccountBalance<T>>::get((collection.id, owner))259				.checked_sub(1)260				// Should not occur261				.ok_or(ArithmeticError::Underflow)?262		} else {263			0264		};265266		// =========267268		if balance == 0 {269			<Owned<T>>::remove((collection.id, owner, token));270			<Balance<T>>::remove((collection.id, token, owner));271			<AccountBalance<T>>::insert((collection.id, owner), account_balance);272		} else {273			<Balance<T>>::insert((collection.id, token, owner), balance);274		}275		<TotalSupply<T>>::insert((collection.id, token), total_supply);276		// TODO: ERC20 transfer event277		<PalletCommon<T>>::deposit_event(CommonEvent::ItemDestroyed(278			collection.id,279			token,280			owner.clone(),281			amount,282		));283		Ok(())284	}285286	pub fn transfer(287		collection: &RefungibleHandle<T>,288		from: &T::CrossAccountId,289		to: &T::CrossAccountId,290		token: TokenId,291		amount: u128,292	) -> DispatchResult {293		ensure!(294			collection.limits.transfers_enabled(),295			<CommonError<T>>::TransferNotAllowed296		);297298		if collection.access == AccessMode::AllowList {299			collection.check_allowlist(from)?;300			collection.check_allowlist(to)?;301		}302		<PalletCommon<T>>::ensure_correct_receiver(to)?;303304		let balance_from = <Balance<T>>::get((collection.id, token, from))305			.checked_sub(amount)306			.ok_or(<CommonError<T>>::TokenValueTooLow)?;307		let mut create_target = false;308		let from_to_differ = from != to;309		let balance_to = if from != to {310			let old_balance = <Balance<T>>::get((collection.id, token, to));311			if old_balance == 0 {312				create_target = true;313			}314			Some(315				old_balance316					.checked_add(amount)317					.ok_or(ArithmeticError::Overflow)?,318			)319		} else {320			None321		};322323		let account_balance_from = if balance_from == 0 {324			Some(325				<AccountBalance<T>>::get((collection.id, from))326					.checked_sub(1)327					// Should not occur328					.ok_or(ArithmeticError::Underflow)?,329			)330		} else {331			None332		};333		// Account data is created in token, AccountBalance should be increased334		// But only if from != to as we shouldn't check overflow in this case335		let account_balance_to = if create_target && from_to_differ {336			let account_balance_to = <AccountBalance<T>>::get((collection.id, to))337				.checked_add(1)338				.ok_or(ArithmeticError::Overflow)?;339			ensure!(340				account_balance_to < collection.limits.account_token_ownership_limit(),341				<CommonError<T>>::AccountTokenLimitExceeded,342			);343344			Some(account_balance_to)345		} else {346			None347		};348349		if let Some(target) = T::CrossTokenAddressMapping::address_to_token(to) {350			let handle = <CollectionHandle<T>>::try_get(target.0)?;351			let dispatch = T::CollectionDispatch::dispatch(handle);352			let dispatch = dispatch.as_dyn();353354			// =========355356			dispatch.nest_token(from.clone(), (collection.id, token), target.1)?;357		}358359		if let Some(balance_to) = balance_to {360			// from != to361			if balance_from == 0 {362				<Balance<T>>::remove((collection.id, token, from));363			} else {364				<Balance<T>>::insert((collection.id, token, from), balance_from);365			}366			<Balance<T>>::insert((collection.id, token, to), balance_to);367			if let Some(account_balance_from) = account_balance_from {368				<AccountBalance<T>>::insert((collection.id, from), account_balance_from);369				<Owned<T>>::remove((collection.id, from, token));370			}371			if let Some(account_balance_to) = account_balance_to {372				<AccountBalance<T>>::insert((collection.id, to), account_balance_to);373				<Owned<T>>::insert((collection.id, to, token), true);374			}375		}376377		// TODO: ERC20 transfer event378		<PalletCommon<T>>::deposit_event(CommonEvent::Transfer(379			collection.id,380			token,381			from.clone(),382			to.clone(),383			amount,384		));385		Ok(())386	}387388	pub fn create_multiple_items(389		collection: &RefungibleHandle<T>,390		sender: &T::CrossAccountId,391		data: Vec<CreateRefungibleExData<T::CrossAccountId>>,392	) -> DispatchResult {393		if !collection.is_owner_or_admin(sender) {394			ensure!(395				collection.mint_mode,396				<CommonError<T>>::PublicMintingNotAllowed397			);398			collection.check_allowlist(sender)?;399400			for item in data.iter() {401				for user in item.users.keys() {402					collection.check_allowlist(user)?;403				}404			}405		}406407		for item in data.iter() {408			for (owner, _) in item.users.iter() {409				<PalletCommon<T>>::ensure_correct_receiver(owner)?;410			}411		}412413		// Total pieces per tokens414		let totals = data415			.iter()416			.map(|data| {417				Ok(data418					.users419					.iter()420					.map(|u| u.1)421					.try_fold(0u128, |acc, v| acc.checked_add(*v))422					.ok_or(ArithmeticError::Overflow)?)423			})424			.collect::<Result<Vec<_>, DispatchError>>()?;425		for total in &totals {426			ensure!(427				*total <= MAX_REFUNGIBLE_PIECES,428				<Error<T>>::WrongRefungiblePieces429			);430		}431432		let first_token_id = <TokensMinted<T>>::get(collection.id);433		let tokens_minted = first_token_id434			.checked_add(data.len() as u32)435			.ok_or(ArithmeticError::Overflow)?;436		ensure!(437			tokens_minted < collection.limits.token_limit(),438			<CommonError<T>>::CollectionTokenLimitExceeded439		);440441		let mut balances = BTreeMap::new();442		for data in &data {443			for owner in data.users.keys() {444				let balance = balances445					.entry(owner)446					.or_insert_with(|| <AccountBalance<T>>::get((collection.id, owner)));447				*balance = balance.checked_add(1).ok_or(ArithmeticError::Overflow)?;448449				ensure!(450					*balance <= collection.limits.account_token_ownership_limit(),451					<CommonError<T>>::AccountTokenLimitExceeded,452				);453			}454		}455456		// =========457458		<TokensMinted<T>>::insert(collection.id, tokens_minted);459		for (account, balance) in balances {460			<AccountBalance<T>>::insert((collection.id, account), balance);461		}462		for (i, token) in data.into_iter().enumerate() {463			let token_id = first_token_id + i as u32 + 1;464			<TotalSupply<T>>::insert((collection.id, token_id), totals[i]);465466			<TokenData<T>>::insert(467				(collection.id, token_id),468				ItemData {469					const_data: token.const_data,470					variable_data: token.variable_data,471				},472			);473			for (user, amount) in token.users.into_iter() {474				if amount == 0 {475					continue;476				}477				<Balance<T>>::insert((collection.id, token_id, &user), amount);478				<Owned<T>>::insert((collection.id, &user, TokenId(token_id)), true);479				// TODO: ERC20 transfer event480				<PalletCommon<T>>::deposit_event(CommonEvent::ItemCreated(481					collection.id,482					TokenId(token_id),483					user,484					amount,485				));486			}487		}488		Ok(())489	}490491	pub fn set_allowance_unchecked(492		collection: &RefungibleHandle<T>,493		sender: &T::CrossAccountId,494		spender: &T::CrossAccountId,495		token: TokenId,496		amount: u128,497	) {498		if amount == 0 {499			<Allowance<T>>::remove((collection.id, token, sender, spender));500		} else {501			<Allowance<T>>::insert((collection.id, token, sender, spender), amount);502		}503		// TODO: ERC20 approval event504		<PalletCommon<T>>::deposit_event(CommonEvent::Approved(505			collection.id,506			token,507			sender.clone(),508			spender.clone(),509			amount,510		))511	}512513	pub fn set_allowance(514		collection: &RefungibleHandle<T>,515		sender: &T::CrossAccountId,516		spender: &T::CrossAccountId,517		token: TokenId,518		amount: u128,519	) -> DispatchResult {520		if collection.access == AccessMode::AllowList {521			collection.check_allowlist(sender)?;522			collection.check_allowlist(spender)?;523		}524525		<PalletCommon<T>>::ensure_correct_receiver(spender)?;526527		if <Balance<T>>::get((collection.id, token, sender)) < amount {528			ensure!(529				collection.ignores_owned_amount(sender) && Self::token_exists(collection, token),530				<CommonError<T>>::CantApproveMoreThanOwned531			);532		}533534		// =========535536		Self::set_allowance_unchecked(collection, sender, spender, token, amount);537		Ok(())538	}539540	/// Returns allowance, which should be set after transaction541	fn check_allowed(542		collection: &RefungibleHandle<T>,543		spender: &T::CrossAccountId,544		from: &T::CrossAccountId,545		token: TokenId,546		amount: u128,547	) -> Result<Option<u128>, DispatchError> {548		if spender.conv_eq(from) {549			return Ok(None);550		}551		if collection.access == AccessMode::AllowList {552			// `from`, `to` checked in [`transfer`]553			collection.check_allowlist(spender)?;554		}555		if let Some(source) = T::CrossTokenAddressMapping::address_to_token(from) {556			// TODO: should collection owner be allowed to perform this transfer?557			ensure!(558				<PalletStructure<T>>::indirectly_owned(spender.clone(), source.0, source.1, 1)?,559				<CommonError<T>>::ApprovedValueTooLow,560			);561			return Ok(None);562		}563		let allowance =564			<Allowance<T>>::get((collection.id, token, from, &spender)).checked_sub(amount);565		if allowance.is_none() {566			ensure!(567				collection.ignores_allowance(spender),568				<CommonError<T>>::ApprovedValueTooLow569			);570		}571		Ok(allowance)572	}573574	pub fn transfer_from(575		collection: &RefungibleHandle<T>,576		spender: &T::CrossAccountId,577		from: &T::CrossAccountId,578		to: &T::CrossAccountId,579		token: TokenId,580		amount: u128,581	) -> DispatchResult {582		let allowance = Self::check_allowed(collection, spender, from, token, amount)?;583584		// =========585586		Self::transfer(collection, from, to, token, amount)?;587		if let Some(allowance) = allowance {588			Self::set_allowance_unchecked(collection, from, spender, token, allowance);589		}590		Ok(())591	}592593	pub fn burn_from(594		collection: &RefungibleHandle<T>,595		spender: &T::CrossAccountId,596		from: &T::CrossAccountId,597		token: TokenId,598		amount: u128,599	) -> DispatchResult {600		let allowance = Self::check_allowed(collection, spender, from, token, amount)?;601602		// =========603604		Self::burn(collection, from, token, amount)?;605		if let Some(allowance) = allowance {606			Self::set_allowance_unchecked(collection, from, spender, token, allowance);607		}608		Ok(())609	}610611	pub fn set_variable_metadata(612		collection: &RefungibleHandle<T>,613		sender: &T::CrossAccountId,614		token: TokenId,615		data: BoundedVec<u8, CustomDataLimit>,616	) -> DispatchResult {617		collection.check_can_update_meta(618			sender,619			&T::CrossAccountId::from_sub(collection.owner.clone()),620		)?;621622		let token_data = <TokenData<T>>::get((collection.id, token));623624		// =========625626		<TokenData<T>>::insert(627			(collection.id, token),628			ItemData {629				variable_data: data,630				..token_data631			},632		);633		Ok(())634	}635636	/// Delegated to `create_multiple_items`637	pub fn create_item(638		collection: &RefungibleHandle<T>,639		sender: &T::CrossAccountId,640		data: CreateRefungibleExData<T::CrossAccountId>,641	) -> DispatchResult {642		Self::create_multiple_items(collection, sender, vec![data])643	}644}
modifiedpallets/structure/src/lib.rsdiffbeforeafterboth
--- a/pallets/structure/src/lib.rs
+++ b/pallets/structure/src/lib.rs
@@ -6,8 +6,14 @@
 use frame_support::fail;
 pub use pallet::*;
 use pallet_common::{dispatch::CollectionDispatch, CollectionHandle};
-use up_data_structs::{CollectionId, TokenId, mapping::TokenAddressMapping};
+use up_data_structs::{CollectionId, TokenId, mapping::TokenAddressMapping, budget::Budget};
 
+#[cfg(feature = "runtime-benchmarks")]
+pub mod benchmarking;
+pub mod weights;
+
+pub type SelfWeightOf<T> = <T as crate::Config>::WeightInfo;
+
 #[frame_support::pallet]
 pub mod pallet {
 	use frame_support::Parameter;
@@ -35,6 +41,7 @@
 
 	#[pallet::config]
 	pub trait Config: frame_system::Config + pallet_common::Config {
+		type WeightInfo: weights::WeightInfo;
 		type Event: IsType<<Self as frame_system::Config>::Event> + From<Event<Self>>;
 		type Call: Parameter + UnfilteredDispatchable<Origin = Self::Origin> + GetDispatchInfo;
 	}
@@ -127,10 +134,10 @@
 	pub fn find_topmost_owner(
 		collection: CollectionId,
 		token: TokenId,
-		max_depth: u32,
+		budget: &dyn Budget,
 	) -> Result<T::CrossAccountId, DispatchError> {
 		let owner = Self::parent_chain(collection, token)
-			.take(max_depth as usize)
+			.take_while(|_| budget.consume())
 			.find(|p| matches!(p, Ok(Parent::Normal(_) | Parent::TokenNotFound)))
 			.ok_or(<Error<T>>::DepthLimit)??;
 
@@ -145,7 +152,7 @@
 		user: T::CrossAccountId,
 		collection: CollectionId,
 		token: TokenId,
-		max_depth: u32,
+		budget: &dyn Budget,
 	) -> Result<bool, DispatchError> {
 		let target_parent = match T::CrossTokenAddressMapping::address_to_token(&user) {
 			Some((collection, token)) => Parent::Token(collection, token),
@@ -153,7 +160,7 @@
 		};
 
 		Ok(Self::parent_chain(collection, token)
-			.take(max_depth as usize)
+			.take_while(|_| budget.consume())
 			.any(|parent| Ok(&target_parent) == parent.as_ref()))
 	}
 }
modifiedpallets/unique/src/benchmarking.rsdiffbeforeafterboth
--- a/pallets/unique/src/benchmarking.rs
+++ b/pallets/unique/src/benchmarking.rs
@@ -19,8 +19,8 @@
 use super::*;
 use crate::Pallet;
 use frame_system::RawOrigin;
+use frame_support::traits::{tokens::currency::Currency, Get};
 use frame_benchmarking::{benchmarks, account};
-use up_data_structs::*;
 use sp_runtime::DispatchError;
 use pallet_common::benchmarking::{create_data, create_var_data, create_u16_data};
 
@@ -173,6 +173,7 @@
 			owner_can_transfer: Some(true),
 			sponsored_data_rate_limit: None,
 			transfers_enabled: Some(true),
+			nesting_rule: None,
 		};
 	}: set_collection_limits(RawOrigin::Signed(caller.clone()), collection, cl)
 
modifiedpallets/unique/src/lib.rsdiffbeforeafterboth
--- a/pallets/unique/src/lib.rs
+++ b/pallets/unique/src/lib.rs
@@ -43,7 +43,7 @@
 	MAX_COLLECTION_NAME_LENGTH, MAX_COLLECTION_DESCRIPTION_LENGTH, MAX_TOKEN_PREFIX_LENGTH,
 	AccessMode, CreateItemData, CollectionLimits, CollectionId, CollectionMode, TokenId,
 	SchemaVersion, SponsorshipState, MetaUpdatePermission, CreateCollectionData, CustomDataLimit,
-	CreateItemExData,
+	CreateItemExData, budget,
 };
 use pallet_evm::account::CrossAccountId;
 use pallet_common::{
@@ -807,8 +807,9 @@
 		#[transactional]
 		pub fn burn_from(origin, collection_id: CollectionId, from: T::CrossAccountId, item_id: TokenId, value: u128) -> DispatchResultWithPostInfo {
 			let sender = T::CrossAccountId::from_sub(ensure_signed(origin)?);
+			let budget = budget::Value::new(2);
 
-			dispatch_call::<T, _>(collection_id, |d| d.burn_from(sender, from, item_id, value))
+			dispatch_call::<T, _>(collection_id, |d| d.burn_from(sender, from, item_id, value, &budget))
 		}
 
 		/// Change ownership of the token.
@@ -888,8 +889,9 @@
 		#[transactional]
 		pub fn transfer_from(origin, from: T::CrossAccountId, recipient: T::CrossAccountId, collection_id: CollectionId, item_id: TokenId, value: u128 ) -> DispatchResultWithPostInfo {
 			let sender = T::CrossAccountId::from_sub(ensure_signed(origin)?);
+			let budget = budget::Value::new(2);
 
-			dispatch_call::<T, _>(collection_id, |d| d.transfer_from(sender, from, recipient, item_id, value))
+			dispatch_call::<T, _>(collection_id, |d| d.transfer_from(sender, from, recipient, item_id, value, &budget))
 		}
 
 		/// Set off-chain data schema.
addedprimitives/data-structs/src/budget.rsdiffbeforeafterboth
--- /dev/null
+++ b/primitives/data-structs/src/budget.rs
@@ -0,0 +1,38 @@
+use core::cell::Cell;
+
+pub trait Budget {
+	/// Returns true while not exceeded
+	fn consume(&self) -> bool {
+		self.consume_custom(1)
+	}
+	/// Returns true while not exceeded
+	/// Implementations should use interior mutabilitiy
+	fn consume_custom(&self, calls: u32) -> bool;
+}
+
+pub struct Unlimited;
+impl Budget for Unlimited {
+	fn consume_custom(&self, _calls: u32) -> bool {
+		true
+	}
+}
+
+pub struct Value(Cell<u32>);
+impl Value {
+	pub fn new(v: u32) -> Self {
+		Self(Cell::new(v))
+	}
+	pub fn refund(self) -> u32 {
+		self.0.get()
+	}
+}
+impl Budget for Value {
+	fn consume_custom(&self, calls: u32) -> bool {
+		let (result, overflown) = self.0.get().overflowing_sub(calls);
+		if overflown {
+			return false;
+		}
+		self.0.set(result);
+		true
+	}
+}
modifiedprimitives/data-structs/src/lib.rsdiffbeforeafterboth
--- a/primitives/data-structs/src/lib.rs
+++ b/primitives/data-structs/src/lib.rs
@@ -35,6 +35,7 @@
 use scale_info::TypeInfo;
 
 mod bounded;
+pub mod budget;
 pub mod mapping;
 mod migration;