git.delta.rocks / unique-network / refs/commits / a0a04c832ebb

difftreelog

test Add test for "sef sponsoring" and "remove sponsor".

Trubnikov Sergey2022-08-05parent: #f1e64f2.patch.diff
in: master

4 files changed

modifiedpallets/evm-contract-helpers/src/stubs/ContractHelpers.soldiffbeforeafterboth
before · pallets/evm-contract-helpers/src/stubs/ContractHelpers.sol
1// SPDX-License-Identifier: OTHER2// This code is automatically generated34pragma solidity >=0.8.0 <0.9.0;56// Anonymous struct7struct Tuple0 {8	address field_0;9	uint256 field_1;10}1112// Common stubs holder13contract Dummy {14	uint8 dummy;15	string stub_error = "this contract is implemented in native";16}1718contract ERC165 is Dummy {19	function supportsInterface(bytes4 interfaceID)20		external21		view22		returns (bool)23	{24		require(false, stub_error);25		interfaceID;26		return true;27	}28}2930// Selector: 06fc42e931contract ContractHelpers is Dummy, ERC165 {32	// Selector: contractOwner(address) 5152b14c33	function contractOwner(address contractAddress)34		public35		view36		returns (address)37	{38		require(false, stub_error);39		contractAddress;40		dummy;41		return 0x0000000000000000000000000000000000000000;42	}4344	// Selector: setSponsor(address,address) f01fba9345	function setSponsor(address contractAddress, address sponsor) public {46		require(false, stub_error);47		contractAddress;48		sponsor;49		dummy = 0;50	}5152	// Selector: confirmSponsorship(address) abc0000153	function confirmSponsorship(address contractAddress) public {54		require(false, stub_error);55		contractAddress;56		dummy = 0;57	}5859	// Selector: getSponsor(address) 743fc74560	function getSponsor(address contractAddress)61		public62		view63		returns (Tuple0 memory)64	{65		require(false, stub_error);66		contractAddress;67		dummy;68		return Tuple0(0x0000000000000000000000000000000000000000, 0);69	}7071	// Selector: hasSponsor(address) 9741860372	function hasSponsor(address contractAddress) public view returns (bool) {73		require(false, stub_error);74		contractAddress;75		dummy;76		return false;77	}7879	// Selector: hasPendingSponsor(address) 39b9b24280	function hasPendingSponsor(address contractAddress)81		public82		view83		returns (bool)84	{85		require(false, stub_error);86		contractAddress;87		dummy;88		return false;89	}9091	// Selector: sponsoringEnabled(address) 6027dc6192	function sponsoringEnabled(address contractAddress)93		public94		view95		returns (bool)96	{97		require(false, stub_error);98		contractAddress;99		dummy;100		return false;101	}102103	// Selector: setSponsoringMode(address,uint8) fde8a560104	function setSponsoringMode(address contractAddress, uint8 mode) public {105		require(false, stub_error);106		contractAddress;107		mode;108		dummy = 0;109	}110111	// Selector: sponsoringMode(address) b70c7267112	function sponsoringMode(address contractAddress)113		public114		view115		returns (uint8)116	{117		require(false, stub_error);118		contractAddress;119		dummy;120		return 0;121	}122123	// Selector: setSponsoringRateLimit(address,uint32) 77b6c908124	function setSponsoringRateLimit(address contractAddress, uint32 rateLimit)125		public126	{127		require(false, stub_error);128		contractAddress;129		rateLimit;130		dummy = 0;131	}132133	// Selector: getSponsoringRateLimit(address) 610cfabd134	function getSponsoringRateLimit(address contractAddress)135		public136		view137		returns (uint32)138	{139		require(false, stub_error);140		contractAddress;141		dummy;142		return 0;143	}144145	// Selector: allowed(address,address) 5c658165146	function allowed(address contractAddress, address user)147		public148		view149		returns (bool)150	{151		require(false, stub_error);152		contractAddress;153		user;154		dummy;155		return false;156	}157158	// Selector: allowlistEnabled(address) c772ef6c159	function allowlistEnabled(address contractAddress)160		public161		view162		returns (bool)163	{164		require(false, stub_error);165		contractAddress;166		dummy;167		return false;168	}169170	// Selector: toggleAllowlist(address,bool) 36de20f5171	function toggleAllowlist(address contractAddress, bool enabled) public {172		require(false, stub_error);173		contractAddress;174		enabled;175		dummy = 0;176	}177178	// Selector: toggleAllowed(address,address,bool) 4706cc1c179	function toggleAllowed(180		address contractAddress,181		address user,182		bool allowed183	) public {184		require(false, stub_error);185		contractAddress;186		user;187		allowed;188		dummy = 0;189	}190}
after · pallets/evm-contract-helpers/src/stubs/ContractHelpers.sol
1// SPDX-License-Identifier: OTHER2// This code is automatically generated34pragma solidity >=0.8.0 <0.9.0;56// Anonymous struct7struct Tuple0 {8	address field_0;9	uint256 field_1;10}1112// Common stubs holder13contract Dummy {14	uint8 dummy;15	string stub_error = "this contract is implemented in native";16}1718contract ERC165 is Dummy {19	function supportsInterface(bytes4 interfaceID)20		external21		view22		returns (bool)23	{24		require(false, stub_error);25		interfaceID;26		return true;27	}28}2930// Selector: 6073d91731contract ContractHelpers is Dummy, ERC165 {32	// Get contract ovner33	//34	// @param Contract_address contract for which the owner is being determined.35	// @return Contract owner.36	//37	// Selector: contractOwner(address) 5152b14c38	function contractOwner(address contractAddress)39		public40		view41		returns (address)42	{43		require(false, stub_error);44		contractAddress;45		dummy;46		return 0x0000000000000000000000000000000000000000;47	}4849	// Set sponsor.50	//51	// @param contract_address Contract for which a sponsor is being established.52	// @param sponsor User address who set as pending sponsor.53	//54	// Selector: setSponsor(address,address) f01fba9355	function setSponsor(address contractAddress, address sponsor) public {56		require(false, stub_error);57		contractAddress;58		sponsor;59		dummy = 0;60	}6162	// Set contract as self sponsored.63	//64	// @param contract_address Contract for which a self sponsoring is being enabled.65	//66	// Selector: selfSponsoredEnable(address) 89f7d9ae67	function selfSponsoredEnable(address contractAddress) public {68		require(false, stub_error);69		contractAddress;70		dummy = 0;71	}7273	// Remove sponsor.74	//75	// @param contract_address Contract for which a sponsorship is being removed.76	//77	// Selector: removeSponsor(address) ef78425078	function removeSponsor(address contractAddress) public {79		require(false, stub_error);80		contractAddress;81		dummy = 0;82	}8384	// Confirm sponsorship.85	//86	// @dev Caller must be same that set via [`set_sponsor`].87	//88	// @param contract_address Сontract for which need to confirm sponsorship.89	//90	// Selector: confirmSponsorship(address) abc0000191	function confirmSponsorship(address contractAddress) public {92		require(false, stub_error);93		contractAddress;94		dummy = 0;95	}9697	// Get current sponsor.98	//99	// @param contract_address The contract for which a sponsor is requested.100	// @return Tuble with sponsor address and his substrate mirror. If there is no confirmed sponsor error "Contract has no sponsor" throw.101	//102	// Selector: getSponsor(address) 743fc745103	function getSponsor(address contractAddress)104		public105		view106		returns (Tuple0 memory)107	{108		require(false, stub_error);109		contractAddress;110		dummy;111		return Tuple0(0x0000000000000000000000000000000000000000, 0);112	}113114	// Check tat contract has confirmed sponsor.115	//116	// @param contract_address The contract for which the presence of a confirmed sponsor is checked.117	// @return **true** if contract has confirmed sponsor.118	//119	// Selector: hasSponsor(address) 97418603120	function hasSponsor(address contractAddress) public view returns (bool) {121		require(false, stub_error);122		contractAddress;123		dummy;124		return false;125	}126127	// Check tat contract has pending sponsor.128	//129	// @param contract_address The contract for which the presence of a pending sponsor is checked.130	// @return **true** if contract has pending sponsor.131	//132	// Selector: hasPendingSponsor(address) 39b9b242133	function hasPendingSponsor(address contractAddress)134		public135		view136		returns (bool)137	{138		require(false, stub_error);139		contractAddress;140		dummy;141		return false;142	}143144	// Selector: sponsoringEnabled(address) 6027dc61145	function sponsoringEnabled(address contractAddress)146		public147		view148		returns (bool)149	{150		require(false, stub_error);151		contractAddress;152		dummy;153		return false;154	}155156	// Selector: setSponsoringMode(address,uint8) fde8a560157	function setSponsoringMode(address contractAddress, uint8 mode) public {158		require(false, stub_error);159		contractAddress;160		mode;161		dummy = 0;162	}163164	// Selector: sponsoringMode(address) b70c7267165	function sponsoringMode(address contractAddress)166		public167		view168		returns (uint8)169	{170		require(false, stub_error);171		contractAddress;172		dummy;173		return 0;174	}175176	// Selector: setSponsoringRateLimit(address,uint32) 77b6c908177	function setSponsoringRateLimit(address contractAddress, uint32 rateLimit)178		public179	{180		require(false, stub_error);181		contractAddress;182		rateLimit;183		dummy = 0;184	}185186	// Selector: getSponsoringRateLimit(address) 610cfabd187	function getSponsoringRateLimit(address contractAddress)188		public189		view190		returns (uint32)191	{192		require(false, stub_error);193		contractAddress;194		dummy;195		return 0;196	}197198	// Selector: allowed(address,address) 5c658165199	function allowed(address contractAddress, address user)200		public201		view202		returns (bool)203	{204		require(false, stub_error);205		contractAddress;206		user;207		dummy;208		return false;209	}210211	// Selector: allowlistEnabled(address) c772ef6c212	function allowlistEnabled(address contractAddress)213		public214		view215		returns (bool)216	{217		require(false, stub_error);218		contractAddress;219		dummy;220		return false;221	}222223	// Selector: toggleAllowlist(address,bool) 36de20f5224	function toggleAllowlist(address contractAddress, bool enabled) public {225		require(false, stub_error);226		contractAddress;227		enabled;228		dummy = 0;229	}230231	// Selector: toggleAllowed(address,address,bool) 4706cc1c232	function toggleAllowed(233		address contractAddress,234		address user,235		bool allowed236	) public {237		require(false, stub_error);238		contractAddress;239		user;240		allowed;241		dummy = 0;242	}243}
modifiedtests/src/eth/api/ContractHelpers.soldiffbeforeafterboth
--- a/tests/src/eth/api/ContractHelpers.sol
+++ b/tests/src/eth/api/ContractHelpers.sol
@@ -18,29 +18,74 @@
 	function supportsInterface(bytes4 interfaceID) external view returns (bool);
 }
 
-// Selector: 06fc42e9
+// Selector: 6073d917
 interface ContractHelpers is Dummy, ERC165 {
+	// Get contract ovner
+	//
+	// @param Contract_address contract for which the owner is being determined.
+	// @return Contract owner.
+	//
 	// Selector: contractOwner(address) 5152b14c
 	function contractOwner(address contractAddress)
 		external
 		view
 		returns (address);
 
+	// Set sponsor.
+	//
+	// @param contract_address Contract for which a sponsor is being established.
+	// @param sponsor User address who set as pending sponsor.
+	//
 	// Selector: setSponsor(address,address) f01fba93
 	function setSponsor(address contractAddress, address sponsor) external;
 
+	// Set contract as self sponsored.
+	//
+	// @param contract_address Contract for which a self sponsoring is being enabled.
+	//
+	// Selector: selfSponsoredEnable(address) 89f7d9ae
+	function selfSponsoredEnable(address contractAddress) external;
+
+	// Remove sponsor.
+	//
+	// @param contract_address Contract for which a sponsorship is being removed.
+	//
+	// Selector: removeSponsor(address) ef784250
+	function removeSponsor(address contractAddress) external;
+
+	// Confirm sponsorship.
+	//
+	// @dev Caller must be same that set via [`set_sponsor`].
+	//
+	// @param contract_address Сontract for which need to confirm sponsorship.
+	//
 	// Selector: confirmSponsorship(address) abc00001
 	function confirmSponsorship(address contractAddress) external;
 
+	// Get current sponsor.
+	//
+	// @param contract_address The contract for which a sponsor is requested.
+	// @return Tuble with sponsor address and his substrate mirror. If there is no confirmed sponsor error "Contract has no sponsor" throw.
+	//
 	// Selector: getSponsor(address) 743fc745
 	function getSponsor(address contractAddress)
 		external
 		view
 		returns (Tuple0 memory);
 
+	// Check tat contract has confirmed sponsor.
+	//
+	// @param contract_address The contract for which the presence of a confirmed sponsor is checked.
+	// @return **true** if contract has confirmed sponsor.
+	//
 	// Selector: hasSponsor(address) 97418603
 	function hasSponsor(address contractAddress) external view returns (bool);
 
+	// Check tat contract has pending sponsor.
+	//
+	// @param contract_address The contract for which the presence of a pending sponsor is checked.
+	// @return **true** if contract has pending sponsor.
+	//
 	// Selector: hasPendingSponsor(address) 39b9b242
 	function hasPendingSponsor(address contractAddress)
 		external
modifiedtests/src/eth/contractSponsoring.test.tsdiffbeforeafterboth
--- a/tests/src/eth/contractSponsoring.test.ts
+++ b/tests/src/eth/contractSponsoring.test.ts
@@ -28,12 +28,31 @@
 import {evmToAddress} from '@polkadot/util-crypto';
 
 describe('Sponsoring EVM contracts', () => {
+  itWeb3('Self sponsored can be set by the address that deployed the contract', async ({api, web3, privateKeyWrapper}) => {
+    const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
+    const flipper = await deployFlipper(web3, owner);
+    const helpers = contractHelpers(web3, owner);
+    expect(await helpers.methods.hasSponsor(flipper.options.address).call()).to.be.false;
+    await expect(helpers.methods.selfSponsoredEnable(flipper.options.address).send()).to.be.not.rejected;
+    expect(await helpers.methods.hasSponsor(flipper.options.address).call()).to.be.true;
+  });
+
+  itWeb3('Self sponsored can not be set by the address that did not deployed the contract', async ({api, web3, privateKeyWrapper}) => {
+    const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
+    const notOwner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
+    const flipper = await deployFlipper(web3, owner);
+    const helpers = contractHelpers(web3, owner);
+    expect(await helpers.methods.hasSponsor(flipper.options.address).call()).to.be.false;
+    await expect(helpers.methods.selfSponsoredEnable(flipper.options.address).call({from: notOwner})).to.be.rejectedWith('NoPermission');
+    expect(await helpers.methods.hasSponsor(flipper.options.address).call()).to.be.false;
+  });
+
   itWeb3('Sponsoring can be set by the address that has deployed the contract', async ({api, web3, privateKeyWrapper}) => {
     const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
     const flipper = await deployFlipper(web3, owner);
     const helpers = contractHelpers(web3, owner);
     expect(await helpers.methods.sponsoringEnabled(flipper.options.address).call()).to.be.false;
-    await helpers.methods.setSponsoringMode(flipper.options.address, SponsoringMode.Allowlisted).send({from: owner});
+    await expect(helpers.methods.setSponsoringMode(flipper.options.address, SponsoringMode.Allowlisted).send({from: owner})).to.be.not.rejected;
     expect(await helpers.methods.sponsoringEnabled(flipper.options.address).call()).to.be.true;
   });
 
@@ -43,7 +62,7 @@
     const flipper = await deployFlipper(web3, owner);
     const helpers = contractHelpers(web3, owner);
     expect(await helpers.methods.sponsoringEnabled(flipper.options.address).call()).to.be.false;
-    await expect(helpers.methods.setSponsoringMode(notOwner, SponsoringMode.Allowlisted).send({from: notOwner})).to.rejected;
+    await expect(helpers.methods.setSponsoringMode(notOwner, SponsoringMode.Allowlisted).call({from: notOwner})).to.be.rejectedWith('NoPermission');
     expect(await helpers.methods.sponsoringEnabled(flipper.options.address).call()).to.be.false;
   });
   
@@ -91,6 +110,19 @@
     expect(await helpers.methods.hasSponsor(flipper.options.address).call()).to.be.false;
   });
 
+  itWeb3('Get self sponsored sponsor', async ({api, web3, privateKeyWrapper}) => {
+    const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
+    const flipper = await deployFlipper(web3, owner);
+    const helpers = contractHelpers(web3, owner);
+    await helpers.methods.selfSponsoredEnable(flipper.options.address).send();
+    
+    const result = await helpers.methods.getSponsor(flipper.options.address).call();
+
+    expect(result[0]).to.be.eq(flipper.options.address);
+    const sponsorSub = api.registry.createType('AccountId', '0x' + BigInt(result[1]).toString(16).padStart(64, '0')).toJSON();
+    expect(sponsorSub).to.be.eq(evmToAddress(flipper.options.address));
+  });
+
   itWeb3('Get confirmed sponsor', async ({api, web3, privateKeyWrapper}) => {
     const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
     const sponsor = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
@@ -106,6 +138,37 @@
     expect(sponsorSub).to.be.eq(evmToAddress(sponsor));
   });
 
+  itWeb3('Sponsor can be removed by the address that deployed the contract', async ({api, web3, privateKeyWrapper}) => {
+    const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
+    const sponsor = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
+    const flipper = await deployFlipper(web3, owner);
+    const helpers = contractHelpers(web3, owner);
+
+    expect(await helpers.methods.hasSponsor(flipper.options.address).call()).to.be.false;
+    await helpers.methods.setSponsor(flipper.options.address, sponsor).send();
+    await helpers.methods.confirmSponsorship(flipper.options.address).send({from: sponsor});
+    expect(await helpers.methods.hasSponsor(flipper.options.address).call()).to.be.true;
+    
+    await helpers.methods.removeSponsor(flipper.options.address).send();
+    expect(await helpers.methods.hasSponsor(flipper.options.address).call()).to.be.false;
+  });
+
+  itWeb3('Sponsor can not be removed by the address that did not deployed the contract', async ({api, web3, privateKeyWrapper}) => {
+    const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
+    const notOwner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
+    const sponsor = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
+    const flipper = await deployFlipper(web3, owner);
+    const helpers = contractHelpers(web3, owner);
+
+    expect(await helpers.methods.hasSponsor(flipper.options.address).call()).to.be.false;
+    await helpers.methods.setSponsor(flipper.options.address, sponsor).send();
+    await helpers.methods.confirmSponsorship(flipper.options.address).send({from: sponsor});
+    expect(await helpers.methods.hasSponsor(flipper.options.address).call()).to.be.true;
+    
+    await expect(helpers.methods.removeSponsor(flipper.options.address).call({from: notOwner})).to.be.rejectedWith('NoPermission');
+    expect(await helpers.methods.hasSponsor(flipper.options.address).call()).to.be.true;
+  });
+
   itWeb3('In generous mode, non-allowlisted user transaction will be sponsored', async ({api, web3, privateKeyWrapper}) => {
     const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
     const sponsor = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
@@ -115,10 +178,8 @@
 
     const helpers = contractHelpers(web3, owner);
 
-    expect(await helpers.methods.hasSponsor(flipper.options.address).call()).to.be.false;
     await helpers.methods.setSponsor(flipper.options.address, sponsor).send();
     await helpers.methods.confirmSponsorship(flipper.options.address).send({from: sponsor});
-    expect(await helpers.methods.hasSponsor(flipper.options.address).call()).to.be.true;
 
     await helpers.methods.setSponsoringMode(flipper.options.address, SponsoringMode.Generous).send({from: owner});
     await helpers.methods.setSponsoringRateLimit(flipper.options.address, 0).send({from: owner});
@@ -136,6 +197,36 @@
     expect(callerBalanceAfter).to.be.eq(callerBalanceBefore);
   });
 
+  itWeb3('In generous mode, non-allowlisted user transaction will be self sponsored', async ({api, web3, privateKeyWrapper}) => {
+    const alice = privateKeyWrapper('//Alice');
+
+    const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
+    const caller = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
+
+    const flipper = await deployFlipper(web3, owner);
+
+    const helpers = contractHelpers(web3, owner);
+
+    await helpers.methods.selfSponsoredEnable(flipper.options.address).send();
+
+    await helpers.methods.setSponsoringMode(flipper.options.address, SponsoringMode.Generous).send({from: owner});
+    await helpers.methods.setSponsoringRateLimit(flipper.options.address, 0).send({from: owner});
+
+    await transferBalanceToEth(api, alice, flipper.options.address);
+
+    const contractBalanceBefore = await ethBalanceViaSub(api, flipper.options.address);
+    const callerBalanceBefore = await ethBalanceViaSub(api, caller);
+
+    await flipper.methods.flip().send({from: caller});
+    expect(await flipper.methods.getValue().call()).to.be.true;
+
+    // Balance should be taken from sponsor instead of caller
+    const contractBalanceAfter = await ethBalanceViaSub(api, flipper.options.address);
+    const callerBalanceAfter = await ethBalanceViaSub(api, caller);
+    expect(contractBalanceAfter < contractBalanceBefore).to.be.true;
+    expect(callerBalanceAfter).to.be.eq(callerBalanceBefore);
+  });
+
   itWeb3('Sponsoring is set, an address that has no UNQ can send a transaction and it works. Sponsor balance should decrease (allowlisted)', async ({api, web3, privateKeyWrapper}) => {
     const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
     const sponsor = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
modifiedtests/src/eth/util/contractHelpersAbi.jsondiffbeforeafterboth
--- a/tests/src/eth/util/contractHelpersAbi.json
+++ b/tests/src/eth/util/contractHelpersAbi.json
@@ -120,6 +120,32 @@
         "internalType": "address",
         "name": "contractAddress",
         "type": "address"
+      }
+    ],
+    "name": "removeSponsor",
+    "outputs": [],
+    "stateMutability": "nonpayable",
+    "type": "function"
+  },
+  {
+    "inputs": [
+      {
+        "internalType": "address",
+        "name": "contractAddress",
+        "type": "address"
+      }
+    ],
+    "name": "selfSponsoredEnable",
+    "outputs": [],
+    "stateMutability": "nonpayable",
+    "type": "function"
+  },
+  {
+    "inputs": [
+      {
+        "internalType": "address",
+        "name": "contractAddress",
+        "type": "address"
       },
       { "internalType": "address", "name": "sponsor", "type": "address" }
     ],