git.delta.rocks / unique-network / refs/commits / 96d265cead38

difftreelog

fix scheduler doesn't change nonce

Daniel Shiposha2022-11-08parent: #a4f0bd9.patch.diff
in: master

2 files changed

modifiedruntime/common/scheduler.rsdiffbeforeafterboth
--- a/runtime/common/scheduler.rs
+++ b/runtime/common/scheduler.rs
@@ -32,10 +32,6 @@
 
 /// The SignedExtension to the basic transaction logic.
 pub type SignedExtraScheduler = (
-	frame_system::CheckSpecVersion<Runtime>,
-	frame_system::CheckGenesis<Runtime>,
-	frame_system::CheckEra<Runtime>,
-	frame_system::CheckNonce<Runtime>,
 	frame_system::CheckWeight<Runtime>,
 	maintenance::CheckMaintenance,
 	ChargeTransactionPayment<Runtime>,
@@ -43,12 +39,6 @@
 
 fn get_signed_extras(from: <Runtime as frame_system::Config>::AccountId) -> SignedExtraScheduler {
 	(
-		frame_system::CheckSpecVersion::<Runtime>::new(),
-		frame_system::CheckGenesis::<Runtime>::new(),
-		frame_system::CheckEra::<Runtime>::from(Era::Immortal),
-		frame_system::CheckNonce::<Runtime>::from(frame_system::Pallet::<Runtime>::account_nonce(
-			from,
-		)),
 		frame_system::CheckWeight::<Runtime>::new(),
 		maintenance::CheckMaintenance,
 		ChargeTransactionPayment::<Runtime>::from(0),
modifiedtests/src/scheduler.seqtest.tsdiffbeforeafterboth
468 expect(await helper.testUtils.testValue()).to.be.equal(secondExecTestVal);468 expect(await helper.testUtils.testValue()).to.be.equal(secondExecTestVal);
469 });469 });
470
471 itSub('scheduled operations does not change nonce', async ({helper}) => {
472 const scheduledId = await helper.arrange.makeScheduledId();
473 const blocksBeforeExecution = 4;
474
475 await helper.scheduler
476 .scheduleAfter<DevUniqueHelper>(scheduledId, blocksBeforeExecution)
477 .balance.transferToSubstrate(alice, bob.address, 1n);
478
479 const initNonce = await helper.chain.getNonce(alice.address);
480
481 await helper.wait.newBlocks(blocksBeforeExecution + 1);
482
483 const finalNonce = await helper.chain.getNonce(alice.address);
484
485 expect(initNonce).to.be.equal(finalNonce);
486 });
470});487});
471488
472describe('Negative Test: Scheduling', () => {489describe('Negative Test: Scheduling', () => {