difftreelog
Merge pull request #254 from UniqueNetwork/feature/decimals-18-v2
in: master
change decimals from 15 to 18
8 files changed
launch-config-westend.jsondiffbeforeafterboth1{2 "relaychain": {3 "bin": "../polkadot/target/release/polkadot",4 "chain": "westend-local",5 "nodes": [6 {7 "name": "alice",8 "wsPort": 9844,9 "rpcPort": 9843,10 "port": 30444,11 "flags": [12 "--rpc-port=9843",13 "-lparachain::candidate_validation=debug"14 ]15 },16 {17 "name": "bob",18 "wsPort": 9855,19 "rpcPort": 9854,20 "port": 30555,21 "flags": [22 "--rpc-port=9854",23 "-lparachain::candidate_validation=debug"24 ]25 },26 {27 "name": "charlie",28 "wsPort": 9866,29 "rpcPort": 9865,30 "port": 30666,31 "flags": [32 "--rpc-port=9865",33 "-lparachain::candidate_validation=debug"34 ]35 },36 {37 "name": "dave",38 "wsPort": 9877,39 "rpcPort": 9876,40 "port": 30777,41 "flags": [42 "--rpc-port=9876",43 "-lparachain::candidate_validation=debug"44 ]45 },46 {47 "name": "eve",48 "wsPort": 9888,49 "rpcPort": 9886,50 "port": 30888,51 "flags": [52 "--rpc-port=9886",53 "-lparachain::candidate_validation=debug"54 ]55 },56 {57 "name": "ferdie",58 "wsPort": 9897,59 "rpcPort": 9896,60 "port": 30999,61 "flags": [62 "--rpc-port=9896",63 "-lparachain::candidate_validation=debug"64 ]65 }66 ],67 "genesis": {68 "runtime": {69 "runtime_genesis_config": {70 "parachainsConfiguration": {71 "config": {72 "validation_upgrade_frequency": 1,73 "validation_upgrade_delay": 174 }75 }76 }77 }78 }79 },80 "parachains": [81 {82 "bin": "../unique-chain/target/release/nft",83 "chain": "westend-local",84 "balance": "1000000000000000000000",85 "nodes": [86 {87 "port": 31200,88 "wsPort": 9944,89 "rpcPort": 9933,90 "name": "alice",91 "flags": [92 "--rpc-cors=all",93 "--rpc-port=9933",94 "--unsafe-rpc-external",95 "--unsafe-ws-external"96 ]97 },98 {99 "port": 31201,100 "wsPort": 9945,101 "rpcPort": 9934,102 "name": "bob",103 "flags": [104 "--rpc-cors=all",105 "--rpc-port=9934",106 "--unsafe-rpc-external",107 "--unsafe-ws-external"108 ]109 },110 {111 "port": 31202,112 "wsPort": 9946,113 "rpcPort": 9935,114 "name": "charlie",115 "flags": [116 "--rpc-cors=all",117 "--rpc-port=9935",118 "--unsafe-rpc-external",119 "--unsafe-ws-external"120 ]121 },122 {123 "port": 31203,124 "wsPort": 9947,125 "rpcPort": 9936,126 "name": "dave",127 "flags": [128 "--rpc-cors=all",129 "--rpc-port=9936",130 "--unsafe-rpc-external",131 "--unsafe-ws-external"132 ]133 },134 {135 "port": 31204,136 "wsPort": 9948,137 "rpcPort": 9937,138 "name": "eve",139 "flags": [140 "--rpc-cors=all",141 "--rpc-port=9937",142 "--unsafe-rpc-external",143 "--unsafe-ws-external"144 ]145 }146 ]147 }148 ],149 "simpleParachains": [],150 "hrmpChannels": [],151 "finalization": false152}1{2 "relaychain": {3 "bin": "../polkadot/target/release/polkadot",4 "chain": "westend-local",5 "nodes": [6 {7 "name": "alice",8 "wsPort": 9844,9 "rpcPort": 9843,10 "port": 30444,11 "flags": [12 "--rpc-port=9843",13 "-lparachain::candidate_validation=debug"14 ]15 },16 {17 "name": "bob",18 "wsPort": 9855,19 "rpcPort": 9854,20 "port": 30555,21 "flags": [22 "--rpc-port=9854",23 "-lparachain::candidate_validation=debug"24 ]25 },26 {27 "name": "charlie",28 "wsPort": 9866,29 "rpcPort": 9865,30 "port": 30666,31 "flags": [32 "--rpc-port=9865",33 "-lparachain::candidate_validation=debug"34 ]35 },36 {37 "name": "dave",38 "wsPort": 9877,39 "rpcPort": 9876,40 "port": 30777,41 "flags": [42 "--rpc-port=9876",43 "-lparachain::candidate_validation=debug"44 ]45 },46 {47 "name": "eve",48 "wsPort": 9888,49 "rpcPort": 9886,50 "port": 30888,51 "flags": [52 "--rpc-port=9886",53 "-lparachain::candidate_validation=debug"54 ]55 },56 {57 "name": "ferdie",58 "wsPort": 9897,59 "rpcPort": 9896,60 "port": 30999,61 "flags": [62 "--rpc-port=9896",63 "-lparachain::candidate_validation=debug"64 ]65 }66 ],67 "genesis": {68 "runtime": {69 "runtime_genesis_config": {70 "parachainsConfiguration": {71 "config": {72 "validation_upgrade_frequency": 1,73 "validation_upgrade_delay": 174 }75 }76 }77 }78 }79 },80 "parachains": [81 {82 "bin": "../unique-chain/target/release/unique-collator",83 "chain": "westend-local",84 "balance": "1000000000000000000000000",85 "nodes": [86 {87 "port": 31200,88 "wsPort": 9944,89 "rpcPort": 9933,90 "name": "alice",91 "flags": [92 "--rpc-cors=all",93 "--rpc-port=9933",94 "--unsafe-rpc-external",95 "--unsafe-ws-external"96 ]97 },98 {99 "port": 31201,100 "wsPort": 9945,101 "rpcPort": 9934,102 "name": "bob",103 "flags": [104 "--rpc-cors=all",105 "--rpc-port=9934",106 "--unsafe-rpc-external",107 "--unsafe-ws-external"108 ]109 },110 {111 "port": 31202,112 "wsPort": 9946,113 "rpcPort": 9935,114 "name": "charlie",115 "flags": [116 "--rpc-cors=all",117 "--rpc-port=9935",118 "--unsafe-rpc-external",119 "--unsafe-ws-external"120 ]121 },122 {123 "port": 31203,124 "wsPort": 9947,125 "rpcPort": 9936,126 "name": "dave",127 "flags": [128 "--rpc-cors=all",129 "--rpc-port=9936",130 "--unsafe-rpc-external",131 "--unsafe-ws-external"132 ]133 },134 {135 "port": 31204,136 "wsPort": 9948,137 "rpcPort": 9937,138 "name": "eve",139 "flags": [140 "--rpc-cors=all",141 "--rpc-port=9937",142 "--unsafe-rpc-external",143 "--unsafe-ws-external"144 ]145 }146 ]147 }148 ],149 "simpleParachains": [],150 "hrmpChannels": [],151 "finalization": false152}launch-config.jsondiffbeforeafterboth--- a/launch-config.json
+++ b/launch-config.json
@@ -57,7 +57,7 @@
{
"bin": "../unique-chain/target/release/unique-collator",
"id": "2000",
- "balance": "1000000000000000000000",
+ "balance": "1000000000000000000000000",
"nodes": [
{
"port": 31200,
node/cli/src/chain_spec.rsdiffbeforeafterboth--- a/node/cli/src/chain_spec.rs
+++ b/node/cli/src/chain_spec.rs
@@ -53,9 +53,9 @@
pub fn development_config(id: ParaId) -> ChainSpec {
let mut properties = Map::new();
- properties.insert("tokenSymbol".into(), "testUNQ".into());
+ properties.insert("tokenSymbol".into(), "OPL".into());
properties.insert("tokenDecimals".into(), 15.into());
- properties.insert("ss58Format".into(), 42.into()); // Generic Substrate wildcard (SS58 checksum preimage)
+ properties.insert("ss58Format".into(), 42.into());
ChainSpec::from_genesis(
// Name
runtime/src/lib.rsdiffbeforeafterboth--- a/runtime/src/lib.rs
+++ b/runtime/src/lib.rs
@@ -243,7 +243,7 @@
impl FeeCalculator for FixedFee {
fn min_gas_price() -> U256 {
// Targeting 0.15 UNQ per transfer
- 1_024_947_215u32.into()
+ 1_024_947_215_000u64.into()
}
}
@@ -403,7 +403,7 @@
type WeightInfo = pallet_balances::weights::SubstrateWeight<Self>;
}
-pub const MICROUNIQUE: Balance = 1_000_000_000;
+pub const MICROUNIQUE: Balance = 1_000_000_000_000;
pub const MILLIUNIQUE: Balance = 1_000 * MICROUNIQUE;
pub const CENTIUNIQUE: Balance = 10 * MILLIUNIQUE;
pub const UNIQUE: Balance = 100 * CENTIUNIQUE;
@@ -481,7 +481,7 @@
fn polynomial() -> WeightToFeeCoefficients<Self::Balance> {
smallvec!(WeightToFeeCoefficient {
// Targeting 0.1 Unique per NFT transfer
- coeff_integer: 142_688u32.into(),
+ coeff_integer: 142_688_000u32.into(),
coeff_frac: Perbill::zero(),
negative: false,
degree: 1,
tests/src/confirmSponsorship.test.tsdiffbeforeafterboth--- a/tests/src/confirmSponsorship.test.ts
+++ b/tests/src/confirmSponsorship.test.ts
@@ -21,6 +21,7 @@
normalizeAccountId,
addCollectionAdminExpectSuccess,
getCreatedCollectionCount,
+ UNIQUE,
} from './util/helpers';
import {Keyring} from '@polkadot/api';
import {IKeyringPair} from '@polkadot/types/types';
@@ -198,7 +199,7 @@
const sponsorBalanceAfter = (await api.query.system.account(bob.address)).data.free.toBigInt();
// Try again after Zero gets some balance - now it should succeed
- const balancetx = api.tx.balances.transfer(zeroBalance.address, 1e15);
+ const balancetx = api.tx.balances.transfer(zeroBalance.address, 1n * UNIQUE);
await submitTransactionAsync(alice, balancetx);
const events2 = await submitTransactionAsync(zeroBalance, zeroToAlice);
const result2 = getGenericResult(events2);
@@ -232,7 +233,7 @@
const sponsorBalanceAfter = (await api.query.system.account(bob.address)).data.free.toBigInt();
// Try again after Zero gets some balance - now it should succeed
- const balancetx = api.tx.balances.transfer(zeroBalance.address, 1e15);
+ const balancetx = api.tx.balances.transfer(zeroBalance.address, 1n * UNIQUE);
await submitTransactionAsync(alice, balancetx);
const events2 = await submitTransactionAsync(zeroBalance, zeroToAlice);
const result2 = getGenericResult(events2);
@@ -268,7 +269,7 @@
expect(sponsorBalanceAfter).to.be.equal(sponsorBalanceBefore);
// Try again after Zero gets some balance - now it should succeed
- const balancetx = api.tx.balances.transfer(zeroBalance.address, 1e15);
+ const balancetx = api.tx.balances.transfer(zeroBalance.address, 1n * UNIQUE);
await submitTransactionAsync(alice, balancetx);
const events2 = await submitTransactionAsync(zeroBalance, zeroToAlice);
const result2 = getGenericResult(events2);
@@ -307,7 +308,7 @@
const sponsorBalanceAfter = (await api.query.system.account(bob.address)).data.free.toBigInt();
// Try again after Zero gets some balance - now it should succeed
- const balancetx = api.tx.balances.transfer(zeroBalance.address, 1e15);
+ const balancetx = api.tx.balances.transfer(zeroBalance.address, 1n * UNIQUE);
await submitTransactionAsync(alice, balancetx);
await createItemExpectSuccess(zeroBalance, collectionId, 'NFT', zeroBalance.address);
tests/src/creditFeesToTreasury.test.tsdiffbeforeafterboth--- a/tests/src/creditFeesToTreasury.test.ts
+++ b/tests/src/creditFeesToTreasury.test.ts
@@ -154,8 +154,8 @@
const aliceBalanceAfter: bigint = (await api.query.system.account(alicesPublicKey)).data.free.toBigInt();
const fee = aliceBalanceBefore - aliceBalanceAfter;
- expect(fee / 10n ** 15n < BigInt(Math.ceil(saneMaximumFee + createCollectionDeposit))).to.be.true;
- expect(fee / 10n ** 15n < BigInt(Math.ceil(saneMinimumFee + createCollectionDeposit))).to.be.true;
+ expect(fee / UNIQUE < BigInt(Math.ceil(saneMaximumFee + createCollectionDeposit))).to.be.true;
+ expect(fee / UNIQUE < BigInt(Math.ceil(saneMinimumFee + createCollectionDeposit))).to.be.true;
});
});
tests/src/eth/payable.test.tsdiffbeforeafterboth--- a/tests/src/eth/payable.test.ts
+++ b/tests/src/eth/payable.test.ts
@@ -54,7 +54,7 @@
expect(await contract.methods.getUnaccounted().call()).to.be.equal('10000');
});
- itWeb3('Balance can be retrieved from evm contract', async({api, web3}) => {
+ itWeb3.only('Balance can be retrieved from evm contract', async({api, web3}) => {
const FEE_BALANCE = 10n ** 18n;
const CONTRACT_BALANCE = 10n ** 14n;
tests/src/util/helpers.tsdiffbeforeafterboth--- a/tests/src/util/helpers.ts
+++ b/tests/src/util/helpers.ts
@@ -69,7 +69,7 @@
export const U128_MAX = (1n << 128n) - 1n;
-const MICROUNIQUE = 1_000_000_000n;
+const MICROUNIQUE = 1_000_000_000_000n;
const MILLIUNIQUE = 1_000n * MICROUNIQUE;
const CENTIUNIQUE = 10n * MILLIUNIQUE;
export const UNIQUE = 100n * CENTIUNIQUE;