git.delta.rocks / unique-network / refs/commits / 91e514bdbb72

difftreelog

doc: modify properties fns

Daniel Shiposha2023-01-13parent: #5906b72.patch.diff
in: master

3 files changed

modifiedpallets/common/src/lib.rsdiffbeforeafterboth
--- a/pallets/common/src/lib.rs
+++ b/pallets/common/src/lib.rs
@@ -1198,6 +1198,15 @@
 		Ok(())
 	}
 
+	/// This function sets or removes a collection properties according to
+	/// `properties_updates` contents:
+	/// * sets a property under the <key> with the value provided `(<key>, Some(<value>))`
+	/// * removes a property under the <key> if the value is `None` `(<key>, None)`.
+	///
+	/// This function fires an event for each property change.
+	/// In case of an error, all the changes (including the events) will be reverted
+	/// since the function is transactional.
+	#[transactional]
 	fn modify_collection_properties(
 		collection: &CollectionHandle<T>,
 		sender: &T::CrossAccountId,
@@ -1297,7 +1306,6 @@
 	/// * `collection` - Collection handler.
 	/// * `sender` - The owner or administrator of the collection.
 	/// * `properties` - The properties to set.
-	#[transactional]
 	pub fn set_collection_properties(
 		collection: &CollectionHandle<T>,
 		sender: &T::CrossAccountId,
@@ -1328,7 +1336,6 @@
 	/// * `collection` - Collection handler.
 	/// * `sender` - The owner or administrator of the collection.
 	/// * `properties` - The properties to delete.
-	#[transactional]
 	pub fn delete_collection_properties(
 		collection: &CollectionHandle<T>,
 		sender: &T::CrossAccountId,
modifiedpallets/nonfungible/src/lib.rsdiffbeforeafterboth
--- a/pallets/nonfungible/src/lib.rs
+++ b/pallets/nonfungible/src/lib.rs
@@ -577,14 +577,23 @@
 		})
 	}
 
-	/// Batch operation to add, edit or remove properties for the token
+	/// A batch operation to add, edit or remove properties for a token.
+	/// It sets or removes a token's properties according to
+	/// `properties_updates` contents:
+	/// * sets a property under the <key> with the value provided `(<key>, Some(<value>))`
+	/// * removes a property under the <key> if the value is `None` `(<key>, None)`.
 	///
-	/// All affected properties should have mutable permission and sender should have
-	/// permission to edit those properties.
-	///
-	/// - `nesting_budget`: Limit for searching parents in depth to check ownership.
+	/// - `nesting_budget`: Limit for searching parents in-depth to check ownership.
 	/// - `is_token_create`: Indicates that method is called during token initialization.
 	///   Allows to bypass ownership check.
+	///
+	/// All affected properties should have `mutable` permission
+	/// to be **deleted** or to be **set more than once**,
+	/// and the sender should have permission to edit those properties.
+	///
+	/// This function fires an event for each property change.
+	/// In case of an error, all the changes (including the events) will be reverted
+	/// since the function is transactional.
 	#[transactional]
 	fn modify_token_properties(
 		collection: &NonfungibleHandle<T>,
modifiedpallets/refungible/src/lib.rsdiffbeforeafterboth
515 Ok(())515 Ok(())
516 }516 }
517517
518 /// A batch operation to add, edit or remove properties for a token.
519 /// It sets or removes a token's properties according to
520 /// `properties_updates` contents:
521 /// * sets a property under the <key> with the value provided `(<key>, Some(<value>))`
522 /// * removes a property under the <key> if the value is `None` `(<key>, None)`.
523 ///
524 /// - `nesting_budget`: Limit for searching parents in-depth to check ownership.
525 /// - `is_token_create`: Indicates that method is called during token initialization.
526 /// Allows to bypass ownership check.
527 ///
528 /// All affected properties should have `mutable` permission
529 /// to be **deleted** or to be **set more than once**,
530 /// and the sender should have permission to edit those properties.
531 ///
532 /// This function fires an event for each property change.
533 /// In case of an error, all the changes (including the events) will be reverted
534 /// since the function is transactional.
518 #[transactional]535 #[transactional]
519 fn modify_token_properties(536 fn modify_token_properties(
520 collection: &RefungibleHandle<T>,537 collection: &RefungibleHandle<T>,