difftreelog
CORE-386 Fix PR
in: master
7 files changed
pallets/common/src/erc.rsdiffbeforeafterboth--- a/pallets/common/src/erc.rs
+++ b/pallets/common/src/erc.rs
@@ -261,13 +261,13 @@
Ok(())
}
- fn set_collection_access(&mut self, caller: caller, mode: string) -> Result<void> {
+ fn set_collection_access(&mut self, caller: caller, mode: uint8) -> Result<void> {
let caller = T::CrossAccountId::from_eth(caller);
self.check_is_owner_or_admin(&caller)
.map_err(dispatch_to_evm::<T>)?;
- self.collection.permissions.access = Some(match mode.as_str() {
- "Normal" => AccessMode::Normal,
- "AllowList" => AccessMode::AllowList,
+ self.collection.permissions.access = Some(match mode {
+ 0 => AccessMode::Normal,
+ 1 => AccessMode::AllowList,
_ => return Err("Not supported access mode".into()),
});
save(self);
pallets/nonfungible/src/lib.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/lib.rs
+++ b/pallets/nonfungible/src/lib.rs
@@ -543,6 +543,7 @@
token_owner,
..
} => {
+ //TODO: исследовать угрозы при публичном минтинге.
if is_token_create && (collection_admin || token_owner) {
return Ok(());
}
pallets/nonfungible/src/stubs/UniqueNFT.rawdiffbeforeafterbothbinary blob — no preview
pallets/nonfungible/src/stubs/UniqueNFT.soldiffbeforeafterboth--- a/pallets/nonfungible/src/stubs/UniqueNFT.sol
+++ b/pallets/nonfungible/src/stubs/UniqueNFT.sol
@@ -51,135 +51,6 @@
event MintingFinished();
}
-// Selector: 1248b7d1
-contract Collection is Dummy, ERC165 {
- // Selector: setCollectionProperty(string,bytes) 2f073f66
- function setCollectionProperty(string memory key, bytes memory value)
- public
- {
- require(false, stub_error);
- key;
- value;
- dummy = 0;
- }
-
- // Selector: deleteCollectionProperty(string) 7b7debce
- function deleteCollectionProperty(string memory key) public {
- require(false, stub_error);
- key;
- dummy = 0;
- }
-
- // Throws error if key not found
- //
- // Selector: collectionProperty(string) cf24fd6d
- function collectionProperty(string memory key)
- public
- view
- returns (bytes memory)
- {
- require(false, stub_error);
- key;
- dummy;
- return hex"";
- }
-
- // Selector: setCollectionSponsor(address) 7623402e
- function setCollectionSponsor(address sponsor) public {
- require(false, stub_error);
- sponsor;
- dummy = 0;
- }
-
- // Selector: confirmCollectionSponsorship() 3c50e97a
- function confirmCollectionSponsorship() public {
- require(false, stub_error);
- dummy = 0;
- }
-
- // Selector: setCollectionLimit(string,uint32) 6a3841db
- function setCollectionLimit(string memory limit, uint32 value) public {
- require(false, stub_error);
- limit;
- value;
- dummy = 0;
- }
-
- // Selector: setCollectionLimit(string,bool) 993b7fba
- function setCollectionLimit(string memory limit, bool value) public {
- require(false, stub_error);
- limit;
- value;
- dummy = 0;
- }
-
- // Selector: contractAddress() f6b4dfb4
- function contractAddress() public view returns (address) {
- require(false, stub_error);
- dummy;
- return 0x0000000000000000000000000000000000000000;
- }
-
- // Selector: addCollectionAdmin(address) 92e462c7
- function addCollectionAdmin(address newAdmin) public view {
- require(false, stub_error);
- newAdmin;
- dummy;
- }
-
- // Selector: removeCollectionAdmin(address) fafd7b42
- function removeCollectionAdmin(address admin) public view {
- require(false, stub_error);
- admin;
- dummy;
- }
-
- // Selector: setCollectionNesting(bool) 112d4586
- function setCollectionNesting(bool enable) public {
- require(false, stub_error);
- enable;
- dummy = 0;
- }
-
- // Selector: setCollectionNesting(bool,address[]) 64872396
- function setCollectionNesting(bool enable, address[] memory collections)
- public
- {
- require(false, stub_error);
- enable;
- collections;
- dummy = 0;
- }
-
- // Selector: setCollectionAccess(string) 392172a9
- function setCollectionAccess(string memory mode) public {
- require(false, stub_error);
- mode;
- dummy = 0;
- }
-
- // Selector: addToCollectionAllowList(address) 67844fe6
- function addToCollectionAllowList(address user) public view {
- require(false, stub_error);
- user;
- dummy;
- }
-
- // Selector: removeFromCollectionAllowList(address) 85c51acb
- function removeFromCollectionAllowList(address user) public view {
- require(false, stub_error);
- user;
- dummy;
- }
-
- // Selector: setCollectionMintMode(bool) 00018e84
- function setCollectionMintMode(bool mode) public {
- require(false, stub_error);
- mode;
- dummy = 0;
- }
-}
-
// Selector: 41369377
contract TokenProperties is Dummy, ERC165 {
// Selector: setTokenPropertyPermission(string,bool,bool,bool) 222d97fa
@@ -426,6 +297,135 @@
}
}
+// Selector: 6aea9834
+contract Collection is Dummy, ERC165 {
+ // Selector: setCollectionProperty(string,bytes) 2f073f66
+ function setCollectionProperty(string memory key, bytes memory value)
+ public
+ {
+ require(false, stub_error);
+ key;
+ value;
+ dummy = 0;
+ }
+
+ // Selector: deleteCollectionProperty(string) 7b7debce
+ function deleteCollectionProperty(string memory key) public {
+ require(false, stub_error);
+ key;
+ dummy = 0;
+ }
+
+ // Throws error if key not found
+ //
+ // Selector: collectionProperty(string) cf24fd6d
+ function collectionProperty(string memory key)
+ public
+ view
+ returns (bytes memory)
+ {
+ require(false, stub_error);
+ key;
+ dummy;
+ return hex"";
+ }
+
+ // Selector: setCollectionSponsor(address) 7623402e
+ function setCollectionSponsor(address sponsor) public {
+ require(false, stub_error);
+ sponsor;
+ dummy = 0;
+ }
+
+ // Selector: confirmCollectionSponsorship() 3c50e97a
+ function confirmCollectionSponsorship() public {
+ require(false, stub_error);
+ dummy = 0;
+ }
+
+ // Selector: setCollectionLimit(string,uint32) 6a3841db
+ function setCollectionLimit(string memory limit, uint32 value) public {
+ require(false, stub_error);
+ limit;
+ value;
+ dummy = 0;
+ }
+
+ // Selector: setCollectionLimit(string,bool) 993b7fba
+ function setCollectionLimit(string memory limit, bool value) public {
+ require(false, stub_error);
+ limit;
+ value;
+ dummy = 0;
+ }
+
+ // Selector: contractAddress() f6b4dfb4
+ function contractAddress() public view returns (address) {
+ require(false, stub_error);
+ dummy;
+ return 0x0000000000000000000000000000000000000000;
+ }
+
+ // Selector: addCollectionAdmin(address) 92e462c7
+ function addCollectionAdmin(address newAdmin) public view {
+ require(false, stub_error);
+ newAdmin;
+ dummy;
+ }
+
+ // Selector: removeCollectionAdmin(address) fafd7b42
+ function removeCollectionAdmin(address admin) public view {
+ require(false, stub_error);
+ admin;
+ dummy;
+ }
+
+ // Selector: setCollectionNesting(bool) 112d4586
+ function setCollectionNesting(bool enable) public {
+ require(false, stub_error);
+ enable;
+ dummy = 0;
+ }
+
+ // Selector: setCollectionNesting(bool,address[]) 64872396
+ function setCollectionNesting(bool enable, address[] memory collections)
+ public
+ {
+ require(false, stub_error);
+ enable;
+ collections;
+ dummy = 0;
+ }
+
+ // Selector: setCollectionAccess(uint8) 41835d4c
+ function setCollectionAccess(uint8 mode) public {
+ require(false, stub_error);
+ mode;
+ dummy = 0;
+ }
+
+ // Selector: addToCollectionAllowList(address) 67844fe6
+ function addToCollectionAllowList(address user) public view {
+ require(false, stub_error);
+ user;
+ dummy;
+ }
+
+ // Selector: removeFromCollectionAllowList(address) 85c51acb
+ function removeFromCollectionAllowList(address user) public view {
+ require(false, stub_error);
+ user;
+ dummy;
+ }
+
+ // Selector: setCollectionMintMode(bool) 00018e84
+ function setCollectionMintMode(bool mode) public {
+ require(false, stub_error);
+ mode;
+ dummy = 0;
+ }
+}
+
// Selector: 780e9d63
contract ERC721Enumerable is Dummy, ERC165 {
// Selector: tokenByIndex(uint256) 4f6ccce7
tests/src/eth/api/UniqueNFT.soldiffbeforeafterboth1// SPDX-License-Identifier: OTHER2// This code is automatically generated34pragma solidity >=0.8.0 <0.9.0;56// Anonymous struct7struct Tuple0 {8 uint256 field_0;9 string field_1;10}1112// Common stubs holder13interface Dummy {1415}1617interface ERC165 is Dummy {18 function supportsInterface(bytes4 interfaceID) external view returns (bool);19}2021// Inline22interface ERC721Events {23 event Transfer(24 address indexed from,25 address indexed to,26 uint256 indexed tokenId27 );28 event Approval(29 address indexed owner,30 address indexed approved,31 uint256 indexed tokenId32 );33 event ApprovalForAll(34 address indexed owner,35 address indexed operator,36 bool approved37 );38}3940// Inline41interface ERC721MintableEvents {42 event MintingFinished();43}4445// Selector: 1248b7d146interface Collection is Dummy, ERC165 {47 // Selector: setCollectionProperty(string,bytes) 2f073f6648 function setCollectionProperty(string memory key, bytes memory value)49 external;5051 // Selector: deleteCollectionProperty(string) 7b7debce52 function deleteCollectionProperty(string memory key) external;5354 // Throws error if key not found55 //56 // Selector: collectionProperty(string) cf24fd6d57 function collectionProperty(string memory key)58 external59 view60 returns (bytes memory);6162 // Selector: setCollectionSponsor(address) 7623402e63 function setCollectionSponsor(address sponsor) external;6465 // Selector: confirmCollectionSponsorship() 3c50e97a66 function confirmCollectionSponsorship() external;6768 // Selector: setCollectionLimit(string,uint32) 6a3841db69 function setCollectionLimit(string memory limit, uint32 value) external;7071 // Selector: setCollectionLimit(string,bool) 993b7fba72 function setCollectionLimit(string memory limit, bool value) external;7374 // Selector: contractAddress() f6b4dfb475 function contractAddress() external view returns (address);7677 // Selector: addCollectionAdmin(address) 92e462c778 function addCollectionAdmin(address newAdmin) external view;7980 // Selector: removeCollectionAdmin(address) fafd7b4281 function removeCollectionAdmin(address admin) external view;8283 // Selector: setCollectionNesting(bool) 112d458684 function setCollectionNesting(bool enable) external;8586 // Selector: setCollectionNesting(bool,address[]) 6487239687 function setCollectionNesting(bool enable, address[] memory collections)88 external;8990 // Selector: setCollectionAccess(string) 392172a991 function setCollectionAccess(string memory mode) external;9293 // Selector: addToCollectionAllowList(address) 67844fe694 function addToCollectionAllowList(address user) external view;9596 // Selector: removeFromCollectionAllowList(address) 85c51acb97 function removeFromCollectionAllowList(address user) external view;9899 // Selector: setCollectionMintMode(bool) 00018e84100 function setCollectionMintMode(bool mode) external;101}102103// Selector: 41369377104interface TokenProperties is Dummy, ERC165 {105 // Selector: setTokenPropertyPermission(string,bool,bool,bool) 222d97fa106 function setTokenPropertyPermission(107 string memory key,108 bool isMutable,109 bool collectionAdmin,110 bool tokenOwner111 ) external;112113 // Selector: setProperty(uint256,string,bytes) 1752d67b114 function setProperty(115 uint256 tokenId,116 string memory key,117 bytes memory value118 ) external;119120 // Selector: deleteProperty(uint256,string) 066111d1121 function deleteProperty(uint256 tokenId, string memory key) external;122123 // Throws error if key not found124 //125 // Selector: property(uint256,string) 7228c327126 function property(uint256 tokenId, string memory key)127 external128 view129 returns (bytes memory);130}131132// Selector: 42966c68133interface ERC721Burnable is Dummy, ERC165 {134 // Selector: burn(uint256) 42966c68135 function burn(uint256 tokenId) external;136}137138// Selector: 58800161139interface ERC721 is Dummy, ERC165, ERC721Events {140 // Selector: balanceOf(address) 70a08231141 function balanceOf(address owner) external view returns (uint256);142143 // Selector: ownerOf(uint256) 6352211e144 function ownerOf(uint256 tokenId) external view returns (address);145146 // Not implemented147 //148 // Selector: safeTransferFromWithData(address,address,uint256,bytes) 60a11672149 function safeTransferFromWithData(150 address from,151 address to,152 uint256 tokenId,153 bytes memory data154 ) external;155156 // Not implemented157 //158 // Selector: safeTransferFrom(address,address,uint256) 42842e0e159 function safeTransferFrom(160 address from,161 address to,162 uint256 tokenId163 ) external;164165 // Selector: transferFrom(address,address,uint256) 23b872dd166 function transferFrom(167 address from,168 address to,169 uint256 tokenId170 ) external;171172 // Selector: approve(address,uint256) 095ea7b3173 function approve(address approved, uint256 tokenId) external;174175 // Not implemented176 //177 // Selector: setApprovalForAll(address,bool) a22cb465178 function setApprovalForAll(address operator, bool approved) external;179180 // Not implemented181 //182 // Selector: getApproved(uint256) 081812fc183 function getApproved(uint256 tokenId) external view returns (address);184185 // Not implemented186 //187 // Selector: isApprovedForAll(address,address) e985e9c5188 function isApprovedForAll(address owner, address operator)189 external190 view191 returns (address);192}193194// Selector: 5b5e139f195interface ERC721Metadata is Dummy, ERC165 {196 // Selector: name() 06fdde03197 function name() external view returns (string memory);198199 // Selector: symbol() 95d89b41200 function symbol() external view returns (string memory);201202 // Returns token's const_metadata203 //204 // Selector: tokenURI(uint256) c87b56dd205 function tokenURI(uint256 tokenId) external view returns (string memory);206}207208// Selector: 68ccfe89209interface ERC721Mintable is Dummy, ERC165, ERC721MintableEvents {210 // Selector: mintingFinished() 05d2035b211 function mintingFinished() external view returns (bool);212213 // `token_id` should be obtained with `next_token_id` method,214 // unlike standard, you can't specify it manually215 //216 // Selector: mint(address,uint256) 40c10f19217 function mint(address to, uint256 tokenId) external returns (bool);218219 // `token_id` should be obtained with `next_token_id` method,220 // unlike standard, you can't specify it manually221 //222 // Selector: mintWithTokenURI(address,uint256,string) 50bb4e7f223 function mintWithTokenURI(224 address to,225 uint256 tokenId,226 string memory tokenUri227 ) external returns (bool);228229 // Not implemented230 //231 // Selector: finishMinting() 7d64bcb4232 function finishMinting() external returns (bool);233}234235// Selector: 780e9d63236interface ERC721Enumerable is Dummy, ERC165 {237 // Selector: tokenByIndex(uint256) 4f6ccce7238 function tokenByIndex(uint256 index) external view returns (uint256);239240 // Not implemented241 //242 // Selector: tokenOfOwnerByIndex(address,uint256) 2f745c59243 function tokenOfOwnerByIndex(address owner, uint256 index)244 external245 view246 returns (uint256);247248 // Selector: totalSupply() 18160ddd249 function totalSupply() external view returns (uint256);250}251252// Selector: d74d154f253interface ERC721UniqueExtensions is Dummy, ERC165 {254 // Selector: transfer(address,uint256) a9059cbb255 function transfer(address to, uint256 tokenId) external;256257 // Selector: burnFrom(address,uint256) 79cc6790258 function burnFrom(address from, uint256 tokenId) external;259260 // Selector: nextTokenId() 75794a3c261 function nextTokenId() external view returns (uint256);262263 // Selector: mintBulk(address,uint256[]) 44a9945e264 function mintBulk(address to, uint256[] memory tokenIds)265 external266 returns (bool);267268 // Selector: mintBulkWithTokenURI(address,(uint256,string)[]) 36543006269 function mintBulkWithTokenURI(address to, Tuple0[] memory tokens)270 external271 returns (bool);272}273274interface UniqueNFT is275 Dummy,276 ERC165,277 ERC721,278 ERC721Metadata,279 ERC721Enumerable,280 ERC721UniqueExtensions,281 ERC721Mintable,282 ERC721Burnable,283 Collection,284 TokenProperties285{}tests/src/eth/contractSponsoring.test.tsdiffbeforeafterboth--- a/tests/src/eth/contractSponsoring.test.ts
+++ b/tests/src/eth/contractSponsoring.test.ts
@@ -247,7 +247,8 @@
expect(oldPermissions.mintMode).to.be.false;
expect(oldPermissions.access).to.be.equal('Normal');
- await collectionEvm.methods.setCollectionAccess('AllowList').send({from: owner});
+ //TODO: change value, when enum generated
+ await collectionEvm.methods.setCollectionAccess(1 /*'AllowList'*/).send({from: owner});
await collectionEvm.methods.addToCollectionAllowList(user).send({from: owner});
await collectionEvm.methods.setCollectionMintMode(true).send({from: owner});
tests/src/eth/nonFungibleAbi.jsondiffbeforeafterboth--- a/tests/src/eth/nonFungibleAbi.json
+++ b/tests/src/eth/nonFungibleAbi.json
@@ -341,7 +341,7 @@
"type": "function"
},
{
- "inputs": [{ "internalType": "string", "name": "mode", "type": "string" }],
+ "inputs": [{ "internalType": "uint8", "name": "mode", "type": "uint8" }],
"name": "setCollectionAccess",
"outputs": [],
"stateMutability": "nonpayable",