difftreelog
Merge branch 'develop' into feature/docker-base-img
in: master
11 files changed
pallets/common/src/benchmarking.rsdiffbeforeafterboth--- a/pallets/common/src/benchmarking.rs
+++ b/pallets/common/src/benchmarking.rs
@@ -176,7 +176,7 @@
key: property_key(p as usize),
value: property_value(),
}).collect::<Vec<_>>();
- }: {<Pallet<T>>::set_collection_properties(&collection, &owner, props)?}
+ }: {<Pallet<T>>::set_collection_properties(&collection, &owner, props.into_iter())?}
delete_collection_properties {
let b in 0..MAX_PROPERTIES_PER_ITEM;
@@ -188,7 +188,7 @@
key: property_key(p as usize),
value: property_value(),
}).collect::<Vec<_>>();
- <Pallet<T>>::set_collection_properties(&collection, &owner, props)?;
+ <Pallet<T>>::set_collection_properties(&collection, &owner, props.into_iter())?;
let to_delete = (0..b).map(|p| property_key(p as usize)).collect::<Vec<_>>();
- }: {<Pallet<T>>::delete_collection_properties(&collection, &owner, to_delete)?}
+ }: {<Pallet<T>>::delete_collection_properties(&collection, &owner, to_delete.into_iter())?}
}
pallets/common/src/erc.rsdiffbeforeafterboth--- a/pallets/common/src/erc.rs
+++ b/pallets/common/src/erc.rs
@@ -125,7 +125,7 @@
.map(eth::Property::try_into)
.collect::<Result<Vec<_>>>()?;
- <Pallet<T>>::set_collection_properties(self, &caller, properties)
+ <Pallet<T>>::set_collection_properties(self, &caller, properties.into_iter())
.map_err(dispatch_to_evm::<T>)
}
@@ -158,7 +158,8 @@
})
.collect::<Result<Vec<_>>>()?;
- <Pallet<T>>::delete_collection_properties(self, &caller, keys).map_err(dispatch_to_evm::<T>)
+ <Pallet<T>>::delete_collection_properties(self, &caller, keys.into_iter())
+ .map_err(dispatch_to_evm::<T>)
}
/// Get collection property.
pallets/common/src/lib.rsdiffbeforeafterboth--- a/pallets/common/src/lib.rs
+++ b/pallets/common/src/lib.rs
@@ -1198,6 +1198,58 @@
Ok(())
}
+ /// This function sets or removes a collection properties according to
+ /// `properties_updates` contents:
+ /// * sets a property under the <key> with the value provided `(<key>, Some(<value>))`
+ /// * removes a property under the <key> if the value is `None` `(<key>, None)`.
+ ///
+ /// This function fires an event for each property change.
+ /// In case of an error, all the changes (including the events) will be reverted
+ /// since the function is transactional.
+ #[transactional]
+ fn modify_collection_properties(
+ collection: &CollectionHandle<T>,
+ sender: &T::CrossAccountId,
+ properties_updates: impl Iterator<Item = (PropertyKey, Option<PropertyValue>)>,
+ ) -> DispatchResult {
+ collection.check_is_owner_or_admin(sender)?;
+
+ let mut stored_properties = <CollectionProperties<T>>::get(collection.id);
+
+ for (key, value) in properties_updates {
+ match value {
+ Some(value) => {
+ stored_properties
+ .try_set(key.clone(), value)
+ .map_err(<Error<T>>::from)?;
+
+ Self::deposit_event(Event::CollectionPropertySet(collection.id, key));
+ <PalletEvm<T>>::deposit_log(
+ erc::CollectionHelpersEvents::CollectionChanged {
+ collection_id: eth::collection_id_to_address(collection.id),
+ }
+ .to_log(T::ContractAddress::get()),
+ );
+ }
+ None => {
+ stored_properties.remove(&key).map_err(<Error<T>>::from)?;
+
+ Self::deposit_event(Event::CollectionPropertyDeleted(collection.id, key));
+ <PalletEvm<T>>::deposit_log(
+ erc::CollectionHelpersEvents::CollectionChanged {
+ collection_id: eth::collection_id_to_address(collection.id),
+ }
+ .to_log(T::ContractAddress::get()),
+ );
+ }
+ }
+ }
+
+ <CollectionProperties<T>>::set(collection.id, stored_properties);
+
+ Ok(())
+ }
+
/// Set collection property.
///
/// * `collection` - Collection handler.
@@ -1208,23 +1260,7 @@
sender: &T::CrossAccountId,
property: Property,
) -> DispatchResult {
- collection.check_is_owner_or_admin(sender)?;
-
- CollectionProperties::<T>::try_mutate(collection.id, |properties| {
- let property = property.clone();
- properties.try_set(property.key, property.value)
- })
- .map_err(<Error<T>>::from)?;
-
- Self::deposit_event(Event::CollectionPropertySet(collection.id, property.key));
- <PalletEvm<T>>::deposit_log(
- erc::CollectionHelpersEvents::CollectionChanged {
- collection_id: eth::collection_id_to_address(collection.id),
- }
- .to_log(T::ContractAddress::get()),
- );
-
- Ok(())
+ Self::set_collection_properties(collection, sender, [property].into_iter())
}
/// Set a scoped collection property, where the scope is a special prefix
@@ -1270,17 +1306,16 @@
/// * `collection` - Collection handler.
/// * `sender` - The owner or administrator of the collection.
/// * `properties` - The properties to set.
- #[transactional]
pub fn set_collection_properties(
collection: &CollectionHandle<T>,
sender: &T::CrossAccountId,
- properties: Vec<Property>,
+ properties: impl Iterator<Item = Property>,
) -> DispatchResult {
- for property in properties {
- Self::set_collection_property(collection, sender, property)?;
- }
-
- Ok(())
+ Self::modify_collection_properties(
+ collection,
+ sender,
+ properties.map(|property| (property.key, Some(property.value))),
+ )
}
/// Delete collection property.
@@ -1293,25 +1328,7 @@
sender: &T::CrossAccountId,
property_key: PropertyKey,
) -> DispatchResult {
- collection.check_is_owner_or_admin(sender)?;
-
- CollectionProperties::<T>::try_mutate(collection.id, |properties| {
- properties.remove(&property_key)
- })
- .map_err(<Error<T>>::from)?;
-
- Self::deposit_event(Event::CollectionPropertyDeleted(
- collection.id,
- property_key,
- ));
- <PalletEvm<T>>::deposit_log(
- erc::CollectionHelpersEvents::CollectionChanged {
- collection_id: eth::collection_id_to_address(collection.id),
- }
- .to_log(T::ContractAddress::get()),
- );
-
- Ok(())
+ Self::delete_collection_properties(collection, sender, [property_key].into_iter())
}
/// Delete collection properties.
@@ -1319,17 +1336,12 @@
/// * `collection` - Collection handler.
/// * `sender` - The owner or administrator of the collection.
/// * `properties` - The properties to delete.
- #[transactional]
pub fn delete_collection_properties(
collection: &CollectionHandle<T>,
sender: &T::CrossAccountId,
- property_keys: Vec<PropertyKey>,
+ property_keys: impl Iterator<Item = PropertyKey>,
) -> DispatchResult {
- for key in property_keys {
- Self::delete_collection_property(collection, sender, key)?;
- }
-
- Ok(())
+ Self::modify_collection_properties(collection, sender, property_keys.map(|key| (key, None)))
}
/// Set collection propetry permission without any checks.
pallets/fungible/src/lib.rsdiffbeforeafterboth--- a/pallets/fungible/src/lib.rs
+++ b/pallets/fungible/src/lib.rs
@@ -266,7 +266,7 @@
sender: &T::CrossAccountId,
properties: Vec<Property>,
) -> DispatchResult {
- <PalletCommon<T>>::set_collection_properties(collection, sender, properties)
+ <PalletCommon<T>>::set_collection_properties(collection, sender, properties.into_iter())
}
/// Delete properties of the collection, associated with the provided keys.
@@ -275,7 +275,11 @@
sender: &T::CrossAccountId,
property_keys: Vec<PropertyKey>,
) -> DispatchResult {
- <PalletCommon<T>>::delete_collection_properties(collection, sender, property_keys)
+ <PalletCommon<T>>::delete_collection_properties(
+ collection,
+ sender,
+ property_keys.into_iter(),
+ )
}
/// Checks if collection has tokens. Return `true` if it has.
pallets/nonfungible/src/lib.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/lib.rs
+++ b/pallets/nonfungible/src/lib.rs
@@ -577,20 +577,29 @@
})
}
- /// Batch operation to add, edit or remove properties for the token
+ /// A batch operation to add, edit or remove properties for a token.
+ /// It sets or removes a token's properties according to
+ /// `properties_updates` contents:
+ /// * sets a property under the <key> with the value provided `(<key>, Some(<value>))`
+ /// * removes a property under the <key> if the value is `None` `(<key>, None)`.
///
- /// All affected properties should have mutable permission and sender should have
- /// permission to edit those properties.
- ///
- /// - `nesting_budget`: Limit for searching parents in depth to check ownership.
+ /// - `nesting_budget`: Limit for searching parents in-depth to check ownership.
/// - `is_token_create`: Indicates that method is called during token initialization.
/// Allows to bypass ownership check.
+ ///
+ /// All affected properties should have `mutable` permission
+ /// to be **deleted** or to be **set more than once**,
+ /// and the sender should have permission to edit those properties.
+ ///
+ /// This function fires an event for each property change.
+ /// In case of an error, all the changes (including the events) will be reverted
+ /// since the function is transactional.
#[transactional]
fn modify_token_properties(
collection: &NonfungibleHandle<T>,
sender: &T::CrossAccountId,
token_id: TokenId,
- properties: impl Iterator<Item = (PropertyKey, Option<PropertyValue>)>,
+ properties_updates: impl Iterator<Item = (PropertyKey, Option<PropertyValue>)>,
is_token_create: bool,
nesting_budget: &dyn Budget,
) -> DispatchResult {
@@ -614,15 +623,16 @@
})
};
- for (key, value) in properties {
- let permission = <PalletCommon<T>>::property_permissions(collection.id)
+ let mut stored_properties = <TokenProperties<T>>::get((collection.id, token_id));
+ let permissions = <PalletCommon<T>>::property_permissions(collection.id);
+
+ for (key, value) in properties_updates {
+ let permission = permissions
.get(&key)
.cloned()
.unwrap_or_else(PropertyPermission::none);
- let is_property_exists = TokenProperties::<T>::get((collection.id, token_id))
- .get(&key)
- .is_some();
+ let is_property_exists = stored_properties.get(&key).is_some();
match permission {
PropertyPermission { mutable: false, .. } if is_property_exists => {
@@ -649,10 +659,9 @@
match value {
Some(value) => {
- <TokenProperties<T>>::try_mutate((collection.id, token_id), |properties| {
- properties.try_set(key.clone(), value)
- })
- .map_err(<CommonError<T>>::from)?;
+ stored_properties
+ .try_set(key.clone(), value)
+ .map_err(<CommonError<T>>::from)?;
<PalletCommon<T>>::deposit_event(CommonEvent::TokenPropertySet(
collection.id,
@@ -661,10 +670,9 @@
));
}
None => {
- <TokenProperties<T>>::try_mutate((collection.id, token_id), |properties| {
- properties.remove(&key)
- })
- .map_err(<CommonError<T>>::from)?;
+ stored_properties
+ .remove(&key)
+ .map_err(<CommonError<T>>::from)?;
<PalletCommon<T>>::deposit_event(CommonEvent::TokenPropertyDeleted(
collection.id,
@@ -683,6 +691,8 @@
);
}
+ <TokenProperties<T>>::set((collection.id, token_id), stored_properties);
+
Ok(())
}
@@ -784,7 +794,7 @@
sender: &T::CrossAccountId,
properties: Vec<Property>,
) -> DispatchResult {
- <PalletCommon<T>>::set_collection_properties(collection, sender, properties)
+ <PalletCommon<T>>::set_collection_properties(collection, sender, properties.into_iter())
}
/// Remove properties from the collection
@@ -793,7 +803,11 @@
sender: &T::CrossAccountId,
property_keys: Vec<PropertyKey>,
) -> DispatchResult {
- <PalletCommon<T>>::delete_collection_properties(collection, sender, property_keys)
+ <PalletCommon<T>>::delete_collection_properties(
+ collection,
+ sender,
+ property_keys.into_iter(),
+ )
}
/// Set property permissions for the token.
pallets/nonfungible/src/weights.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/weights.rs
+++ b/pallets/nonfungible/src/weights.rs
@@ -184,21 +184,21 @@
.saturating_add(T::DbWeight::get().reads(1 as u64))
.saturating_add(T::DbWeight::get().writes(1 as u64))
}
+ // Storage: Nonfungible TokenProperties (r:1 w:1)
// Storage: Common CollectionPropertyPermissions (r:1 w:0)
- // Storage: Nonfungible TokenProperties (r:1 w:1)
fn set_token_properties(b: u32, ) -> Weight {
- Weight::from_ref_time(4_361_000 as u64)
- // Standard Error: 5_349_868
- .saturating_add(Weight::from_ref_time(637_246_356 as u64).saturating_mul(b as u64))
+ Weight::from_ref_time(31_850_484 as u64)
+ // Standard Error: 9_618
+ .saturating_add(Weight::from_ref_time(4_721_947 as u64).saturating_mul(b as u64))
.saturating_add(T::DbWeight::get().reads(2 as u64))
.saturating_add(T::DbWeight::get().writes(1 as u64))
}
+ // Storage: Nonfungible TokenProperties (r:1 w:1)
// Storage: Common CollectionPropertyPermissions (r:1 w:0)
- // Storage: Nonfungible TokenProperties (r:1 w:1)
fn delete_token_properties(b: u32, ) -> Weight {
- Weight::from_ref_time(4_489_000 as u64)
- // Standard Error: 5_738_954
- .saturating_add(Weight::from_ref_time(689_912_822 as u64).saturating_mul(b as u64))
+ Weight::from_ref_time(13_795_000 as u64)
+ // Standard Error: 28_239
+ .saturating_add(Weight::from_ref_time(12_840_446 as u64).saturating_mul(b as u64))
.saturating_add(T::DbWeight::get().reads(2 as u64))
.saturating_add(T::DbWeight::get().writes(1 as u64))
}
@@ -354,21 +354,21 @@
.saturating_add(RocksDbWeight::get().reads(1 as u64))
.saturating_add(RocksDbWeight::get().writes(1 as u64))
}
+ // Storage: Nonfungible TokenProperties (r:1 w:1)
// Storage: Common CollectionPropertyPermissions (r:1 w:0)
- // Storage: Nonfungible TokenProperties (r:1 w:1)
fn set_token_properties(b: u32, ) -> Weight {
- Weight::from_ref_time(4_361_000 as u64)
- // Standard Error: 5_349_868
- .saturating_add(Weight::from_ref_time(637_246_356 as u64).saturating_mul(b as u64))
+ Weight::from_ref_time(31_850_484 as u64)
+ // Standard Error: 9_618
+ .saturating_add(Weight::from_ref_time(4_721_947 as u64).saturating_mul(b as u64))
.saturating_add(RocksDbWeight::get().reads(2 as u64))
.saturating_add(RocksDbWeight::get().writes(1 as u64))
}
+ // Storage: Nonfungible TokenProperties (r:1 w:1)
// Storage: Common CollectionPropertyPermissions (r:1 w:0)
- // Storage: Nonfungible TokenProperties (r:1 w:1)
fn delete_token_properties(b: u32, ) -> Weight {
- Weight::from_ref_time(4_489_000 as u64)
- // Standard Error: 5_738_954
- .saturating_add(Weight::from_ref_time(689_912_822 as u64).saturating_mul(b as u64))
+ Weight::from_ref_time(13_795_000 as u64)
+ // Standard Error: 28_239
+ .saturating_add(Weight::from_ref_time(12_840_446 as u64).saturating_mul(b as u64))
.saturating_add(RocksDbWeight::get().reads(2 as u64))
.saturating_add(RocksDbWeight::get().writes(1 as u64))
}
pallets/refungible/src/lib.rsdiffbeforeafterboth--- a/pallets/refungible/src/lib.rs
+++ b/pallets/refungible/src/lib.rs
@@ -515,12 +515,29 @@
Ok(())
}
+ /// A batch operation to add, edit or remove properties for a token.
+ /// It sets or removes a token's properties according to
+ /// `properties_updates` contents:
+ /// * sets a property under the <key> with the value provided `(<key>, Some(<value>))`
+ /// * removes a property under the <key> if the value is `None` `(<key>, None)`.
+ ///
+ /// - `nesting_budget`: Limit for searching parents in-depth to check ownership.
+ /// - `is_token_create`: Indicates that method is called during token initialization.
+ /// Allows to bypass ownership check.
+ ///
+ /// All affected properties should have `mutable` permission
+ /// to be **deleted** or to be **set more than once**,
+ /// and the sender should have permission to edit those properties.
+ ///
+ /// This function fires an event for each property change.
+ /// In case of an error, all the changes (including the events) will be reverted
+ /// since the function is transactional.
#[transactional]
fn modify_token_properties(
collection: &RefungibleHandle<T>,
sender: &T::CrossAccountId,
token_id: TokenId,
- properties: impl Iterator<Item = (PropertyKey, Option<PropertyValue>)>,
+ properties_updates: impl Iterator<Item = (PropertyKey, Option<PropertyValue>)>,
is_token_create: bool,
nesting_budget: &dyn Budget,
) -> DispatchResult {
@@ -544,15 +561,16 @@
Ok(is_bundle_owner)
};
- for (key, value) in properties {
- let permission = <PalletCommon<T>>::property_permissions(collection.id)
+ let mut stored_properties = <TokenProperties<T>>::get((collection.id, token_id));
+ let permissions = <PalletCommon<T>>::property_permissions(collection.id);
+
+ for (key, value) in properties_updates {
+ let permission = permissions
.get(&key)
.cloned()
.unwrap_or_else(PropertyPermission::none);
- let is_property_exists = TokenProperties::<T>::get((collection.id, token_id))
- .get(&key)
- .is_some();
+ let is_property_exists = stored_properties.get(&key).is_some();
match permission {
PropertyPermission { mutable: false, .. } if is_property_exists => {
@@ -578,10 +596,9 @@
match value {
Some(value) => {
- <TokenProperties<T>>::try_mutate((collection.id, token_id), |properties| {
- properties.try_set(key.clone(), value)
- })
- .map_err(<CommonError<T>>::from)?;
+ stored_properties
+ .try_set(key.clone(), value)
+ .map_err(<CommonError<T>>::from)?;
<PalletCommon<T>>::deposit_event(CommonEvent::TokenPropertySet(
collection.id,
@@ -590,10 +607,9 @@
));
}
None => {
- <TokenProperties<T>>::try_mutate((collection.id, token_id), |properties| {
- properties.remove(&key)
- })
- .map_err(<CommonError<T>>::from)?;
+ stored_properties
+ .remove(&key)
+ .map_err(<CommonError<T>>::from)?;
<PalletCommon<T>>::deposit_event(CommonEvent::TokenPropertyDeleted(
collection.id,
@@ -612,6 +628,8 @@
);
}
+ <TokenProperties<T>>::set((collection.id, token_id), stored_properties);
+
Ok(())
}
@@ -1353,7 +1371,7 @@
sender: &T::CrossAccountId,
properties: Vec<Property>,
) -> DispatchResult {
- <PalletCommon<T>>::set_collection_properties(collection, sender, properties)
+ <PalletCommon<T>>::set_collection_properties(collection, sender, properties.into_iter())
}
pub fn delete_collection_properties(
@@ -1361,7 +1379,11 @@
sender: &T::CrossAccountId,
property_keys: Vec<PropertyKey>,
) -> DispatchResult {
- <PalletCommon<T>>::delete_collection_properties(collection, sender, property_keys)
+ <PalletCommon<T>>::delete_collection_properties(
+ collection,
+ sender,
+ property_keys.into_iter(),
+ )
}
pub fn set_token_property_permissions(
pallets/refungible/src/weights.rsdiffbeforeafterboth--- a/pallets/refungible/src/weights.rs
+++ b/pallets/refungible/src/weights.rs
@@ -246,21 +246,21 @@
.saturating_add(T::DbWeight::get().reads(1 as u64))
.saturating_add(T::DbWeight::get().writes(1 as u64))
}
+ // Storage: Refungible TokenProperties (r:1 w:1)
// Storage: Common CollectionPropertyPermissions (r:1 w:0)
- // Storage: Refungible TokenProperties (r:1 w:1)
fn set_token_properties(b: u32, ) -> Weight {
- Weight::from_ref_time(4_578_000 as u64)
- // Standard Error: 5_396_287
- .saturating_add(Weight::from_ref_time(633_314_546 as u64).saturating_mul(b as u64))
+ Weight::from_ref_time(25_518_267 as u64)
+ // Standard Error: 20_451
+ .saturating_add(Weight::from_ref_time(5_041_089 as u64).saturating_mul(b as u64))
.saturating_add(T::DbWeight::get().reads(2 as u64))
.saturating_add(T::DbWeight::get().writes(1 as u64))
}
+ // Storage: Refungible TokenProperties (r:1 w:1)
// Storage: Common CollectionPropertyPermissions (r:1 w:0)
- // Storage: Refungible TokenProperties (r:1 w:1)
fn delete_token_properties(b: u32, ) -> Weight {
- Weight::from_ref_time(4_583_000 as u64)
- // Standard Error: 5_762_380
- .saturating_add(Weight::from_ref_time(696_007_076 as u64).saturating_mul(b as u64))
+ Weight::from_ref_time(13_715_000 as u64)
+ // Standard Error: 28_323
+ .saturating_add(Weight::from_ref_time(13_113_351 as u64).saturating_mul(b as u64))
.saturating_add(T::DbWeight::get().reads(2 as u64))
.saturating_add(T::DbWeight::get().writes(1 as u64))
}
@@ -478,21 +478,21 @@
.saturating_add(RocksDbWeight::get().reads(1 as u64))
.saturating_add(RocksDbWeight::get().writes(1 as u64))
}
+ // Storage: Refungible TokenProperties (r:1 w:1)
// Storage: Common CollectionPropertyPermissions (r:1 w:0)
- // Storage: Refungible TokenProperties (r:1 w:1)
fn set_token_properties(b: u32, ) -> Weight {
- Weight::from_ref_time(4_578_000 as u64)
- // Standard Error: 5_396_287
- .saturating_add(Weight::from_ref_time(633_314_546 as u64).saturating_mul(b as u64))
+ Weight::from_ref_time(25_518_267 as u64)
+ // Standard Error: 20_451
+ .saturating_add(Weight::from_ref_time(5_041_089 as u64).saturating_mul(b as u64))
.saturating_add(RocksDbWeight::get().reads(2 as u64))
.saturating_add(RocksDbWeight::get().writes(1 as u64))
}
+ // Storage: Refungible TokenProperties (r:1 w:1)
// Storage: Common CollectionPropertyPermissions (r:1 w:0)
- // Storage: Refungible TokenProperties (r:1 w:1)
fn delete_token_properties(b: u32, ) -> Weight {
- Weight::from_ref_time(4_583_000 as u64)
- // Standard Error: 5_762_380
- .saturating_add(Weight::from_ref_time(696_007_076 as u64).saturating_mul(b as u64))
+ Weight::from_ref_time(13_715_000 as u64)
+ // Standard Error: 28_323
+ .saturating_add(Weight::from_ref_time(13_113_351 as u64).saturating_mul(b as u64))
.saturating_add(RocksDbWeight::get().reads(2 as u64))
.saturating_add(RocksDbWeight::get().writes(1 as u64))
}
pallets/unique/src/eth/mod.rsdiffbeforeafterboth1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617//! Implementation of CollectionHelpers contract.1819use core::marker::PhantomData;20use ethereum as _;21use evm_coder::{22 abi::AbiType, execution::*, generate_stubgen, solidity, solidity_interface, types::*, weight,23};24use frame_support::traits::Get;25use crate::Pallet;2627use pallet_common::{28 CollectionById,29 dispatch::CollectionDispatch,30 erc::{CollectionHelpersEvents, static_property::key},31 eth::{map_eth_to_id, collection_id_to_address},32 Pallet as PalletCommon,33};34use pallet_evm::{account::CrossAccountId, OnMethodCall, PrecompileHandle, PrecompileResult};35use pallet_evm_coder_substrate::{dispatch_to_evm, SubstrateRecorder, WithRecorder};36use sp_std::vec;37use up_data_structs::{38 CollectionDescription, CollectionMode, CollectionName, CollectionTokenPrefix,39 CreateCollectionData,40};4142use crate::{weights::WeightInfo, Config, SelfWeightOf};4344use alloc::format;45use sp_std::vec::Vec;4647/// See [`CollectionHelpersCall`]48pub struct EvmCollectionHelpers<T: Config>(SubstrateRecorder<T>);49impl<T: Config> WithRecorder<T> for EvmCollectionHelpers<T> {50 fn recorder(&self) -> &SubstrateRecorder<T> {51 &self.052 }5354 fn into_recorder(self) -> SubstrateRecorder<T> {55 self.056 }57}5859fn convert_data<T: Config>(60 caller: caller,61 name: string,62 description: string,63 token_prefix: string,64) -> Result<(65 T::CrossAccountId,66 CollectionName,67 CollectionDescription,68 CollectionTokenPrefix,69)> {70 let caller = T::CrossAccountId::from_eth(caller);71 let name = name72 .encode_utf16()73 .collect::<Vec<u16>>()74 .try_into()75 .map_err(|_| error_field_too_long(stringify!(name), CollectionName::bound()))?;76 let description = description77 .encode_utf16()78 .collect::<Vec<u16>>()79 .try_into()80 .map_err(|_| {81 error_field_too_long(stringify!(description), CollectionDescription::bound())82 })?;83 let token_prefix = token_prefix.into_bytes().try_into().map_err(|_| {84 error_field_too_long(stringify!(token_prefix), CollectionTokenPrefix::bound())85 })?;86 Ok((caller, name, description, token_prefix))87}8889#[inline(always)]90fn create_collection_internal<T: Config>(91 caller: caller,92 value: value,93 name: string,94 collection_mode: CollectionMode,95 description: string,96 token_prefix: string,97) -> Result<address> {98 let (caller, name, description, token_prefix) =99 convert_data::<T>(caller, name, description, token_prefix)?;100 let data = CreateCollectionData {101 name,102 mode: collection_mode,103 description,104 token_prefix,105 ..Default::default()106 };107 check_sent_amount_equals_collection_creation_price::<T>(value)?;108 let collection_helpers_address =109 T::CrossAccountId::from_eth(<T as pallet_common::Config>::ContractAddress::get());110111 let collection_id = T::CollectionDispatch::create(112 caller.clone(),113 collection_helpers_address,114 data,115 Default::default(),116 )117 .map_err(pallet_evm_coder_substrate::dispatch_to_evm::<T>)?;118 let address = pallet_common::eth::collection_id_to_address(collection_id);119 Ok(address)120}121122fn check_sent_amount_equals_collection_creation_price<T: Config>(value: value) -> Result<()> {123 let value = value.as_u128();124 let creation_price: u128 = T::CollectionCreationPrice::get()125 .try_into()126 .map_err(|_| ()) // workaround for `expect` requiring `Debug` trait127 .expect("Collection creation price should be convertible to u128");128 if value != creation_price {129 return Err(format!(130 "Sent amount not equals to collection creation price ({0})",131 creation_price132 )133 .into());134 }135 Ok(())136}137138/// @title Contract, which allows users to operate with collections139#[solidity_interface(name = CollectionHelpers, events(CollectionHelpersEvents))]140impl<T> EvmCollectionHelpers<T>141where142 T: Config + pallet_common::Config + pallet_nonfungible::Config + pallet_refungible::Config,143{144 /// Create an NFT collection145 /// @param name Name of the collection146 /// @param description Informative description of the collection147 /// @param tokenPrefix Token prefix to represent the collection tokens in UI and user applications148 /// @return address Address of the newly created collection149 #[weight(<SelfWeightOf<T>>::create_collection())]150 #[solidity(rename_selector = "createNFTCollection")]151 fn create_nft_collection(152 &mut self,153 caller: caller,154 value: value,155 name: string,156 description: string,157 token_prefix: string,158 ) -> Result<address> {159 let (caller, name, description, token_prefix) =160 convert_data::<T>(caller, name, description, token_prefix)?;161 let data = CreateCollectionData {162 name,163 mode: CollectionMode::NFT,164 description,165 token_prefix,166 ..Default::default()167 };168 check_sent_amount_equals_collection_creation_price::<T>(value)?;169 let collection_helpers_address =170 T::CrossAccountId::from_eth(<T as pallet_common::Config>::ContractAddress::get());171 let collection_id = T::CollectionDispatch::create(172 caller,173 collection_helpers_address,174 data,175 Default::default(),176 )177 .map_err(dispatch_to_evm::<T>)?;178179 let address = pallet_common::eth::collection_id_to_address(collection_id);180 Ok(address)181 }182 /// Create an NFT collection183 /// @param name Name of the collection184 /// @param description Informative description of the collection185 /// @param tokenPrefix Token prefix to represent the collection tokens in UI and user applications186 /// @return address Address of the newly created collection187 #[weight(<SelfWeightOf<T>>::create_collection())]188 #[deprecated(note = "mathod was renamed to `create_nft_collection`, prefer it instead")]189 #[solidity(hide)]190 fn create_nonfungible_collection(191 &mut self,192 caller: caller,193 value: value,194 name: string,195 description: string,196 token_prefix: string,197 ) -> Result<address> {198 create_collection_internal::<T>(199 caller,200 value,201 name,202 CollectionMode::NFT,203 description,204 token_prefix,205 )206 }207208 #[weight(<SelfWeightOf<T>>::create_collection())]209 #[solidity(rename_selector = "createRFTCollection")]210 fn create_rft_collection(211 &mut self,212 caller: caller,213 value: value,214 name: string,215 description: string,216 token_prefix: string,217 ) -> Result<address> {218 create_collection_internal::<T>(219 caller,220 value,221 name,222 CollectionMode::ReFungible,223 description,224 token_prefix,225 )226 }227228 #[weight(<SelfWeightOf<T>>::create_collection())]229 #[solidity(rename_selector = "createFTCollection")]230 fn create_fungible_collection(231 &mut self,232 caller: caller,233 value: value,234 name: string,235 decimals: uint8,236 description: string,237 token_prefix: string,238 ) -> Result<address> {239 create_collection_internal::<T>(240 caller,241 value,242 name,243 CollectionMode::Fungible(decimals),244 description,245 token_prefix,246 )247 }248249 #[solidity(rename_selector = "makeCollectionERC721MetadataCompatible")]250 fn make_collection_metadata_compatible(251 &mut self,252 caller: caller,253 collection: address,254 base_uri: string,255 ) -> Result<()> {256 let caller = T::CrossAccountId::from_eth(caller);257 let collection =258 pallet_common::eth::map_eth_to_id(&collection).ok_or("not a collection address")?;259 let mut collection =260 <crate::CollectionHandle<T>>::new(collection).ok_or("collection not found")?;261262 if !matches!(263 collection.mode,264 CollectionMode::NFT | CollectionMode::ReFungible265 ) {266 return Err("target collection should be either NFT or Refungible".into());267 }268269 self.recorder().consume_sstore()?;270 collection271 .check_is_owner_or_admin(&caller)272 .map_err(dispatch_to_evm::<T>)?;273274 if collection.flags.erc721metadata {275 return Err("target collection is already Erc721Metadata compatible".into());276 }277 collection.flags.erc721metadata = true;278279 let all_permissions = <pallet_common::CollectionPropertyPermissions<T>>::get(collection.id);280 if all_permissions.get(&key::url()).is_none() {281 self.recorder().consume_sstore()?;282 <PalletCommon<T>>::set_property_permission(283 &collection,284 &caller,285 up_data_structs::PropertyKeyPermission {286 key: key::url(),287 permission: up_data_structs::PropertyPermission {288 mutable: true,289 collection_admin: true,290 token_owner: false,291 },292 },293 )294 .map_err(dispatch_to_evm::<T>)?;295 }296 if all_permissions.get(&key::suffix()).is_none() {297 self.recorder().consume_sstore()?;298 <PalletCommon<T>>::set_property_permission(299 &collection,300 &caller,301 up_data_structs::PropertyKeyPermission {302 key: key::suffix(),303 permission: up_data_structs::PropertyPermission {304 mutable: true,305 collection_admin: true,306 token_owner: false,307 },308 },309 )310 .map_err(dispatch_to_evm::<T>)?;311 }312313 let all_properties = <pallet_common::CollectionProperties<T>>::get(collection.id);314 if all_properties.get(&key::base_uri()).is_none() && !base_uri.is_empty() {315 self.recorder().consume_sstore()?;316 <PalletCommon<T>>::set_collection_properties(317 &collection,318 &caller,319 vec![up_data_structs::Property {320 key: key::base_uri(),321 value: base_uri322 .into_bytes()323 .try_into()324 .map_err(|_| "base uri is too large")?,325 }],326 )327 .map_err(dispatch_to_evm::<T>)?;328 }329330 self.recorder().consume_sstore()?;331 collection.save().map_err(dispatch_to_evm::<T>)?;332333 Ok(())334 }335336 #[weight(<SelfWeightOf<T>>::destroy_collection())]337 fn destroy_collection(&mut self, caller: caller, collection_address: address) -> Result<void> {338 let caller = T::CrossAccountId::from_eth(caller);339340 let collection_id = pallet_common::eth::map_eth_to_id(&collection_address)341 .ok_or("Invalid collection address format")?;342 <Pallet<T>>::destroy_collection_internal(caller, collection_id)343 .map_err(pallet_evm_coder_substrate::dispatch_to_evm::<T>)344 }345346 /// Check if a collection exists347 /// @param collectionAddress Address of the collection in question348 /// @return bool Does the collection exist?349 fn is_collection_exist(&self, _caller: caller, collection_address: address) -> Result<bool> {350 if let Some(id) = pallet_common::eth::map_eth_to_id(&collection_address) {351 let collection_id = id;352 return Ok(<CollectionById<T>>::contains_key(collection_id));353 }354355 Ok(false)356 }357358 fn collection_creation_fee(&self) -> Result<value> {359 let price: u128 = T::CollectionCreationPrice::get()360 .try_into()361 .map_err(|_| ()) // workaround for `expect` requiring `Debug` trait362 .expect("Collection creation price should be convertible to u128");363 Ok(price.into())364 }365366 /// Returns address of a collection.367 /// @param collectionId - CollectionId of the collection368 /// @return eth mirror address of the collection369 fn collection_address(&self, collection_id: uint32) -> Result<address> {370 Ok(collection_id_to_address(collection_id.into()))371 }372373 /// Returns collectionId of a collection.374 /// @param collectionAddress - Eth address of the collection375 /// @return collectionId of the collection376 fn collection_id(&self, collection_address: address) -> Result<uint32> {377 map_eth_to_id(&collection_address)378 .map(|id| id.0)379 .ok_or(Error::Revert(format!(380 "failed to convert address {} into collectionId.",381 collection_address382 )))383 }384}385386/// Implements [`OnMethodCall`], which delegates call to [`EvmCollectionHelpers`]387pub struct CollectionHelpersOnMethodCall<T: Config>(PhantomData<*const T>);388impl<T: Config + pallet_nonfungible::Config + pallet_refungible::Config> OnMethodCall<T>389 for CollectionHelpersOnMethodCall<T>390{391 fn is_reserved(contract: &sp_core::H160) -> bool {392 contract == &T::ContractAddress::get()393 }394395 fn is_used(contract: &sp_core::H160) -> bool {396 contract == &T::ContractAddress::get()397 }398399 fn call(handle: &mut impl PrecompileHandle) -> Option<PrecompileResult> {400 if handle.code_address() != T::ContractAddress::get() {401 return None;402 }403404 let helpers =405 EvmCollectionHelpers::<T>(SubstrateRecorder::<T>::new(handle.remaining_gas()));406 pallet_evm_coder_substrate::call(handle, helpers)407 }408409 fn get_code(contract: &sp_core::H160) -> Option<Vec<u8>> {410 (contract == &T::ContractAddress::get())411 .then(|| include_bytes!("./stubs/CollectionHelpers.raw").to_vec())412 }413}414415generate_stubgen!(collection_helper_impl, CollectionHelpersCall<()>, true);416generate_stubgen!(collection_helper_iface, CollectionHelpersCall<()>, false);417418fn error_field_too_long(feild: &str, bound: usize) -> Error {419 Error::Revert(format!("{} is too long. Max length is {}.", feild, bound))420}1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617//! Implementation of CollectionHelpers contract.1819use core::marker::PhantomData;20use ethereum as _;21use evm_coder::{22 abi::AbiType, execution::*, generate_stubgen, solidity, solidity_interface, types::*, weight,23};24use frame_support::traits::Get;25use crate::Pallet;2627use pallet_common::{28 CollectionById,29 dispatch::CollectionDispatch,30 erc::{CollectionHelpersEvents, static_property::key},31 eth::{map_eth_to_id, collection_id_to_address},32 Pallet as PalletCommon,33};34use pallet_evm::{account::CrossAccountId, OnMethodCall, PrecompileHandle, PrecompileResult};35use pallet_evm_coder_substrate::{dispatch_to_evm, SubstrateRecorder, WithRecorder};36use up_data_structs::{37 CollectionDescription, CollectionMode, CollectionName, CollectionTokenPrefix,38 CreateCollectionData,39};4041use crate::{weights::WeightInfo, Config, SelfWeightOf};4243use alloc::format;44use sp_std::vec::Vec;4546/// See [`CollectionHelpersCall`]47pub struct EvmCollectionHelpers<T: Config>(SubstrateRecorder<T>);48impl<T: Config> WithRecorder<T> for EvmCollectionHelpers<T> {49 fn recorder(&self) -> &SubstrateRecorder<T> {50 &self.051 }5253 fn into_recorder(self) -> SubstrateRecorder<T> {54 self.055 }56}5758fn convert_data<T: Config>(59 caller: caller,60 name: string,61 description: string,62 token_prefix: string,63) -> Result<(64 T::CrossAccountId,65 CollectionName,66 CollectionDescription,67 CollectionTokenPrefix,68)> {69 let caller = T::CrossAccountId::from_eth(caller);70 let name = name71 .encode_utf16()72 .collect::<Vec<u16>>()73 .try_into()74 .map_err(|_| error_field_too_long(stringify!(name), CollectionName::bound()))?;75 let description = description76 .encode_utf16()77 .collect::<Vec<u16>>()78 .try_into()79 .map_err(|_| {80 error_field_too_long(stringify!(description), CollectionDescription::bound())81 })?;82 let token_prefix = token_prefix.into_bytes().try_into().map_err(|_| {83 error_field_too_long(stringify!(token_prefix), CollectionTokenPrefix::bound())84 })?;85 Ok((caller, name, description, token_prefix))86}8788#[inline(always)]89fn create_collection_internal<T: Config>(90 caller: caller,91 value: value,92 name: string,93 collection_mode: CollectionMode,94 description: string,95 token_prefix: string,96) -> Result<address> {97 let (caller, name, description, token_prefix) =98 convert_data::<T>(caller, name, description, token_prefix)?;99 let data = CreateCollectionData {100 name,101 mode: collection_mode,102 description,103 token_prefix,104 ..Default::default()105 };106 check_sent_amount_equals_collection_creation_price::<T>(value)?;107 let collection_helpers_address =108 T::CrossAccountId::from_eth(<T as pallet_common::Config>::ContractAddress::get());109110 let collection_id = T::CollectionDispatch::create(111 caller.clone(),112 collection_helpers_address,113 data,114 Default::default(),115 )116 .map_err(pallet_evm_coder_substrate::dispatch_to_evm::<T>)?;117 let address = pallet_common::eth::collection_id_to_address(collection_id);118 Ok(address)119}120121fn check_sent_amount_equals_collection_creation_price<T: Config>(value: value) -> Result<()> {122 let value = value.as_u128();123 let creation_price: u128 = T::CollectionCreationPrice::get()124 .try_into()125 .map_err(|_| ()) // workaround for `expect` requiring `Debug` trait126 .expect("Collection creation price should be convertible to u128");127 if value != creation_price {128 return Err(format!(129 "Sent amount not equals to collection creation price ({0})",130 creation_price131 )132 .into());133 }134 Ok(())135}136137/// @title Contract, which allows users to operate with collections138#[solidity_interface(name = CollectionHelpers, events(CollectionHelpersEvents))]139impl<T> EvmCollectionHelpers<T>140where141 T: Config + pallet_common::Config + pallet_nonfungible::Config + pallet_refungible::Config,142{143 /// Create an NFT collection144 /// @param name Name of the collection145 /// @param description Informative description of the collection146 /// @param tokenPrefix Token prefix to represent the collection tokens in UI and user applications147 /// @return address Address of the newly created collection148 #[weight(<SelfWeightOf<T>>::create_collection())]149 #[solidity(rename_selector = "createNFTCollection")]150 fn create_nft_collection(151 &mut self,152 caller: caller,153 value: value,154 name: string,155 description: string,156 token_prefix: string,157 ) -> Result<address> {158 let (caller, name, description, token_prefix) =159 convert_data::<T>(caller, name, description, token_prefix)?;160 let data = CreateCollectionData {161 name,162 mode: CollectionMode::NFT,163 description,164 token_prefix,165 ..Default::default()166 };167 check_sent_amount_equals_collection_creation_price::<T>(value)?;168 let collection_helpers_address =169 T::CrossAccountId::from_eth(<T as pallet_common::Config>::ContractAddress::get());170 let collection_id = T::CollectionDispatch::create(171 caller,172 collection_helpers_address,173 data,174 Default::default(),175 )176 .map_err(dispatch_to_evm::<T>)?;177178 let address = pallet_common::eth::collection_id_to_address(collection_id);179 Ok(address)180 }181 /// Create an NFT collection182 /// @param name Name of the collection183 /// @param description Informative description of the collection184 /// @param tokenPrefix Token prefix to represent the collection tokens in UI and user applications185 /// @return address Address of the newly created collection186 #[weight(<SelfWeightOf<T>>::create_collection())]187 #[deprecated(note = "mathod was renamed to `create_nft_collection`, prefer it instead")]188 #[solidity(hide)]189 fn create_nonfungible_collection(190 &mut self,191 caller: caller,192 value: value,193 name: string,194 description: string,195 token_prefix: string,196 ) -> Result<address> {197 create_collection_internal::<T>(198 caller,199 value,200 name,201 CollectionMode::NFT,202 description,203 token_prefix,204 )205 }206207 #[weight(<SelfWeightOf<T>>::create_collection())]208 #[solidity(rename_selector = "createRFTCollection")]209 fn create_rft_collection(210 &mut self,211 caller: caller,212 value: value,213 name: string,214 description: string,215 token_prefix: string,216 ) -> Result<address> {217 create_collection_internal::<T>(218 caller,219 value,220 name,221 CollectionMode::ReFungible,222 description,223 token_prefix,224 )225 }226227 #[weight(<SelfWeightOf<T>>::create_collection())]228 #[solidity(rename_selector = "createFTCollection")]229 fn create_fungible_collection(230 &mut self,231 caller: caller,232 value: value,233 name: string,234 decimals: uint8,235 description: string,236 token_prefix: string,237 ) -> Result<address> {238 create_collection_internal::<T>(239 caller,240 value,241 name,242 CollectionMode::Fungible(decimals),243 description,244 token_prefix,245 )246 }247248 #[solidity(rename_selector = "makeCollectionERC721MetadataCompatible")]249 fn make_collection_metadata_compatible(250 &mut self,251 caller: caller,252 collection: address,253 base_uri: string,254 ) -> Result<()> {255 let caller = T::CrossAccountId::from_eth(caller);256 let collection =257 pallet_common::eth::map_eth_to_id(&collection).ok_or("not a collection address")?;258 let mut collection =259 <crate::CollectionHandle<T>>::new(collection).ok_or("collection not found")?;260261 if !matches!(262 collection.mode,263 CollectionMode::NFT | CollectionMode::ReFungible264 ) {265 return Err("target collection should be either NFT or Refungible".into());266 }267268 self.recorder().consume_sstore()?;269 collection270 .check_is_owner_or_admin(&caller)271 .map_err(dispatch_to_evm::<T>)?;272273 if collection.flags.erc721metadata {274 return Err("target collection is already Erc721Metadata compatible".into());275 }276 collection.flags.erc721metadata = true;277278 let all_permissions = <pallet_common::CollectionPropertyPermissions<T>>::get(collection.id);279 if all_permissions.get(&key::url()).is_none() {280 self.recorder().consume_sstore()?;281 <PalletCommon<T>>::set_property_permission(282 &collection,283 &caller,284 up_data_structs::PropertyKeyPermission {285 key: key::url(),286 permission: up_data_structs::PropertyPermission {287 mutable: true,288 collection_admin: true,289 token_owner: false,290 },291 },292 )293 .map_err(dispatch_to_evm::<T>)?;294 }295 if all_permissions.get(&key::suffix()).is_none() {296 self.recorder().consume_sstore()?;297 <PalletCommon<T>>::set_property_permission(298 &collection,299 &caller,300 up_data_structs::PropertyKeyPermission {301 key: key::suffix(),302 permission: up_data_structs::PropertyPermission {303 mutable: true,304 collection_admin: true,305 token_owner: false,306 },307 },308 )309 .map_err(dispatch_to_evm::<T>)?;310 }311312 let all_properties = <pallet_common::CollectionProperties<T>>::get(collection.id);313 if all_properties.get(&key::base_uri()).is_none() && !base_uri.is_empty() {314 self.recorder().consume_sstore()?;315 <PalletCommon<T>>::set_collection_properties(316 &collection,317 &caller,318 [up_data_structs::Property {319 key: key::base_uri(),320 value: base_uri321 .into_bytes()322 .try_into()323 .map_err(|_| "base uri is too large")?,324 }]325 .into_iter(),326 )327 .map_err(dispatch_to_evm::<T>)?;328 }329330 self.recorder().consume_sstore()?;331 collection.save().map_err(dispatch_to_evm::<T>)?;332333 Ok(())334 }335336 #[weight(<SelfWeightOf<T>>::destroy_collection())]337 fn destroy_collection(&mut self, caller: caller, collection_address: address) -> Result<void> {338 let caller = T::CrossAccountId::from_eth(caller);339340 let collection_id = pallet_common::eth::map_eth_to_id(&collection_address)341 .ok_or("Invalid collection address format")?;342 <Pallet<T>>::destroy_collection_internal(caller, collection_id)343 .map_err(pallet_evm_coder_substrate::dispatch_to_evm::<T>)344 }345346 /// Check if a collection exists347 /// @param collectionAddress Address of the collection in question348 /// @return bool Does the collection exist?349 fn is_collection_exist(&self, _caller: caller, collection_address: address) -> Result<bool> {350 if let Some(id) = pallet_common::eth::map_eth_to_id(&collection_address) {351 let collection_id = id;352 return Ok(<CollectionById<T>>::contains_key(collection_id));353 }354355 Ok(false)356 }357358 fn collection_creation_fee(&self) -> Result<value> {359 let price: u128 = T::CollectionCreationPrice::get()360 .try_into()361 .map_err(|_| ()) // workaround for `expect` requiring `Debug` trait362 .expect("Collection creation price should be convertible to u128");363 Ok(price.into())364 }365366 /// Returns address of a collection.367 /// @param collectionId - CollectionId of the collection368 /// @return eth mirror address of the collection369 fn collection_address(&self, collection_id: uint32) -> Result<address> {370 Ok(collection_id_to_address(collection_id.into()))371 }372373 /// Returns collectionId of a collection.374 /// @param collectionAddress - Eth address of the collection375 /// @return collectionId of the collection376 fn collection_id(&self, collection_address: address) -> Result<uint32> {377 map_eth_to_id(&collection_address)378 .map(|id| id.0)379 .ok_or(Error::Revert(format!(380 "failed to convert address {} into collectionId.",381 collection_address382 )))383 }384}385386/// Implements [`OnMethodCall`], which delegates call to [`EvmCollectionHelpers`]387pub struct CollectionHelpersOnMethodCall<T: Config>(PhantomData<*const T>);388impl<T: Config + pallet_nonfungible::Config + pallet_refungible::Config> OnMethodCall<T>389 for CollectionHelpersOnMethodCall<T>390{391 fn is_reserved(contract: &sp_core::H160) -> bool {392 contract == &T::ContractAddress::get()393 }394395 fn is_used(contract: &sp_core::H160) -> bool {396 contract == &T::ContractAddress::get()397 }398399 fn call(handle: &mut impl PrecompileHandle) -> Option<PrecompileResult> {400 if handle.code_address() != T::ContractAddress::get() {401 return None;402 }403404 let helpers =405 EvmCollectionHelpers::<T>(SubstrateRecorder::<T>::new(handle.remaining_gas()));406 pallet_evm_coder_substrate::call(handle, helpers)407 }408409 fn get_code(contract: &sp_core::H160) -> Option<Vec<u8>> {410 (contract == &T::ContractAddress::get())411 .then(|| include_bytes!("./stubs/CollectionHelpers.raw").to_vec())412 }413}414415generate_stubgen!(collection_helper_impl, CollectionHelpersCall<()>, true);416generate_stubgen!(collection_helper_iface, CollectionHelpersCall<()>, false);417418fn error_field_too_long(feild: &str, bound: usize) -> Error {419 Error::Revert(format!("{} is too long. Max length is {}.", feild, bound))420}runtime/common/identity.rsdiffbeforeafterboth--- a/runtime/common/identity.rs
+++ b/runtime/common/identity.rs
@@ -24,6 +24,9 @@
transaction_validity::{TransactionValidity, ValidTransaction, TransactionValidityError},
};
+#[cfg(feature = "collator-selection")]
+use sp_runtime::transaction_validity::InvalidTransaction;
+
#[derive(Debug, Encode, Decode, PartialEq, Eq, Clone, TypeInfo)]
pub struct DisableIdentityCalls;
tests/src/util/playgrounds/unique.tsdiffbeforeafterboth--- a/tests/src/util/playgrounds/unique.ts
+++ b/tests/src/util/playgrounds/unique.ts
@@ -651,6 +651,9 @@
try {
result = await this.signTransaction(sender, this.constructApiCall(extrinsic, params), options, extrinsic) as ITransactionResult;
events = this.eventHelper.extractEvents(result.result.events);
+ const errorEvent = events.find((event) => event.method == 'ExecutedFailed' || event.method == 'CreatedFailed');
+ if (errorEvent)
+ throw Error(errorEvent.method + ': ' + extrinsic);
}
catch(e) {
if(!(e as object).hasOwnProperty('status')) throw e;