git.delta.rocks / unique-network / refs/commits / 7781ab982a4b

difftreelog

style(Scheduler) removed unlikely to be used commented chunks of code

Fahrrader2022-02-21parent: #be56642.patch.diff
in: master

3 files changed

modifiedpallets/scheduler/src/lib.rsdiffbeforeafterboth
before · pallets/scheduler/src/lib.rs
1// This file is part of Substrate.23// Copyright (C) 2017-2021 Parity Technologies (UK) Ltd.4// SPDX-License-Identifier: Apache-2.056// Licensed under the Apache License, Version 2.0 (the "License");7// you may not use this file except in compliance with the License.8// You may obtain a copy of the License at9//10// 	http://www.apache.org/licenses/LICENSE-2.011//12// Unless required by applicable law or agreed to in writing, software13// distributed under the License is distributed on an "AS IS" BASIS,14// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.15// See the License for the specific language governing permissions and16// limitations under the License.1718//! # Scheduler19//! A module for scheduling dispatches.20//!21//! - [`Config`]22//! - [`Call`]23//! - [`Module`]24//!25//! ## Overview26//!27//! This module exposes capabilities for scheduling dispatches to occur at a28//! specified block number or at a specified period. These scheduled dispatches29//! may be named or anonymous and may be canceled.30//!31//! **NOTE:** The scheduled calls will be dispatched with the default filter32//! for the origin: namely `frame_system::Config::BaseCallFilter` for all origin33//! except root which will get no filter. And not the filter contained in origin34//! use to call `fn schedule`.35//!36//! If a call is scheduled using proxy or whatever mecanism which adds filter,37//! then those filter will not be used when dispatching the schedule call.38//!39//! ## Interface40//!41//! ### Dispatchable Functions42//!43//! * `schedule` - schedule a dispatch, which may be periodic, to occur at a44//!   specified block and with a specified priority.45//! * `cancel` - cancel a scheduled dispatch, specified by block number and46//!   index.47//! * `schedule_named` - augments the `schedule` interface with an additional48//!   `Vec<u8>` parameter that can be used for identification.49//! * `cancel_named` - the named complement to the cancel function.5051// Ensure we're `no_std` when compiling for Wasm.52#![cfg_attr(not(feature = "std"), no_std)]53#![allow(clippy::type_complexity, clippy::boxed_local, clippy::unused_unit)]5455mod benchmarking;56pub mod weights;5758use sp_std::{prelude::*, marker::PhantomData, borrow::Borrow, cmp};59use codec::{Encode, Decode, Codec};60use sp_runtime::{61	RuntimeDebug,62	traits::{Zero, One, BadOrigin, Saturating},63	transaction_validity::TransactionValidityError,64	DispatchErrorWithPostInfo,65};66use frame_support::{67	decl_module, decl_storage, decl_event, decl_error,68	dispatch::{Dispatchable, DispatchError, DispatchResult, Parameter},69	traits::{70		Get,71		schedule::{self, DispatchTime},72		OriginTrait, EnsureOrigin, IsType,73	},74	weights::{GetDispatchInfo, Weight, PostDispatchInfo},75};76use frame_system::{self as system, ensure_signed};77pub use weights::WeightInfo;78use up_sponsorship::SponsorshipHandler;79use scale_info::TypeInfo;80use sp_core::H160;8182/// Our pallet's configuration trait. All our types and constants go in here. If the83/// pallet is dependent on specific other pallets, then their configuration traits84/// should be added to our implied traits list.85///86/// `system::Config` should always be included in our implied traits.87/// //88pub trait Config: system::Config {89	/// The overarching event type.90	type Event: From<Event<Self>> + Into<<Self as system::Config>::Event>;9192	/// The aggregated origin which the dispatch will take.93	type Origin: OriginTrait<PalletsOrigin = Self::PalletsOrigin>94		+ From<Self::PalletsOrigin>95		+ IsType<<Self as system::Config>::Origin>;9697	/// The caller origin, overarching type of all pallets origins.98	type PalletsOrigin: From<system::RawOrigin<Self::AccountId>> + Codec + TypeInfo + Clone + Eq;99100	/// The aggregated call type.101	type Call: Parameter102		+ Dispatchable<Origin = <Self as Config>::Origin>103		+ GetDispatchInfo104		+ From<system::Call<Self>>;105106	/// The maximum weight that may be scheduled per block for any dispatchables of less priority107	/// than `schedule::HARD_DEADLINE`.108	type MaximumWeight: Get<Weight>;109110	/// Required origin to schedule or cancel calls.111	type ScheduleOrigin: EnsureOrigin<<Self as system::Config>::Origin>;112113	/// The maximum number of scheduled calls in the queue for a single block.114	/// Not strictly enforced, but used for weight estimation.115	type MaxScheduledPerBlock: Get<u32>;116117	/// Sponsoring function.118	type SponsorshipHandler: SponsorshipHandler<Self::AccountId, <Self as Config>::Call>;119120	/// Weight information for extrinsics in this pallet.121	type WeightInfo: WeightInfo;122123	/// The helper type used for custom transaction fee logic.124	type CallExecutor: DispatchCall<Self, H160>;125}126127/// A Scheduler-Runtime interface for finer payment handling.128pub trait DispatchCall<T: frame_system::Config + Config, SelfContainedSignedInfo> {129	/// The type that encodes information that can be passed from pre_dispatch to post-dispatch.130	type Pre: Default + Codec + Clone + TypeInfo;131132	/// Resolve the call dispatch, including any post-dispatch operations.133	fn dispatch_call(134		pre_dispatch: Self::Pre,135		function: <T as Config>::Call,136	) -> Result<137		Result<PostDispatchInfo, DispatchErrorWithPostInfo<PostDispatchInfo>>,138		TransactionValidityError,139	>;140141	/// Prepare for the scheduled call (e.g. by withdrawing the fee in advance).142	fn pre_dispatch(143		signer: T::AccountId,144		function: <T as Config>::Call,145	) -> Result<Self::Pre, TransactionValidityError>;146147	/// Perform a clean-up after a cancelled call (e.g. by returning the remaining fee).148	fn cancel_dispatch(pre_dispatch: Self::Pre) -> Result<(), TransactionValidityError>;149}150151pub const MAX_TASK_ID_LENGTH_IN_BYTES: u8 = 16;152153pub const PERIODIC_CALLS_LIMIT: u32 = 100;154155// pub type SelfWeightInfo<T> = <T as system::Config>::WeightInfo;156157/// Just a simple index for naming period tasks.158pub type PeriodicIndex = u32;159/// The location of a scheduled task that can be used to remove it.160pub type TaskAddress<BlockNumber> = (BlockNumber, u32);161162/*#[cfg_attr(any(feature = "std", test), derive(PartialEq, Eq))] todo remove completely?163#[derive(Clone, RuntimeDebug, Encode, Decode)]164struct ScheduledV1<Call, BlockNumber> {165	maybe_id: Option<Vec<u8>>,166	priority: schedule::Priority,167	call: Call,168	maybe_periodic: Option<schedule::Period<BlockNumber>>,169}*/170171/// Information regarding an item to be executed in the future.172#[cfg_attr(any(feature = "std", test), derive(PartialEq, Eq))]173#[derive(Clone, RuntimeDebug, Encode, Decode, TypeInfo)]174pub struct Scheduled<Call, BlockNumber, PalletsOrigin, AccountId, PreDispatch> {175	/// The unique identity for this task, if there is one.176	maybe_id: Option<Vec<u8>>,177	/// This task's priority.178	priority: schedule::Priority,179	/// The call to be dispatched.180	call: Call,181	/// If the call is periodic, then this points to the information concerning that.182	maybe_periodic: Option<schedule::Period<BlockNumber>>,183	/// The origin to dispatch the call.184	origin: PalletsOrigin,185	/// The information regarding the call's preparation for dispatch, in particular the fee, to be sent to post-dispatch.186	pre_dispatch: PreDispatch,187	_phantom: PhantomData<AccountId>,188}189190/// The current version of Scheduled struct.191/*pub type Scheduled<Call, BlockNumber, PalletsOrigin, AccountId, PreDispatch> =192	ScheduledV2<Call, BlockNumber, PalletsOrigin, AccountId, PreDispatch>;*/193194// A value placed in storage that represents the current version of the Scheduler storage.195// This value is used by the `on_runtime_upgrade` logic to determine whether we run196// storage migration logic.197/*#[derive(Encode, Decode, Clone, Copy, PartialEq, Eq, RuntimeDebug, TypeInfo)] todo remove completely?198enum Releases {199	V1,200	V2,201}202203impl Default for Releases {204	fn default() -> Self {205		Releases::V1206	}207}*/208209#[derive(Encode, Decode, Clone, PartialEq, Eq, RuntimeDebug, TypeInfo)]210pub struct CallSpec {211	module: u32,212	method: u32,213}214215decl_storage! {216	trait Store for Module<T: Config> as Scheduler {217		/// Items to be executed, indexed by the block number that they should be executed on.218		pub Agenda: map hasher(twox_64_concat) T::BlockNumber219			=> Vec<Option<Scheduled<220				<T as Config>::Call,221				T::BlockNumber,222				T::PalletsOrigin,223				T::AccountId,224				<<T as Config>::CallExecutor as DispatchCall<T, H160>>::Pre225			>>>;226227		/*pub SpecAgenda: map hasher(twox_64_concat) T::BlockNumber todo remove completely?228			=> Vec<Option<CallSpec>>;*/229230		/// Lookup from identity to the block number and index of the task.231		Lookup: map hasher(twox_64_concat) Vec<u8> => Option<TaskAddress<T::BlockNumber>>;232233		// / Storage version of the pallet.234		// /235		// / New networks start with last version.236		//StorageVersion build(|_| Releases::V2): Releases; todo remove completely?237	}238}239240decl_event!(241	pub enum Event<T> where <T as system::Config>::BlockNumber {242		/// Scheduled some task. \[when, index\]243		Scheduled(BlockNumber, u32),244		/// Canceled some task. \[when, index\]245		Canceled(BlockNumber, u32),246		/// Dispatched some task. \[task, id, result\]247		Dispatched(TaskAddress<BlockNumber>, Option<Vec<u8>>, DispatchResult),248	}249);250251decl_error! {252	pub enum Error for Module<T: Config> {253		/// Failed to schedule a call254		FailedToSchedule,255		/// Cannot find the scheduled call.256		NotFound,257		/// Given target block number is in the past.258		TargetBlockNumberInPast,259		/// Reschedule failed because it does not change scheduled time.260		RescheduleNoChange,261	}262}263264decl_module! {265	/// Scheduler module declaration.266	pub struct Module<T: Config> for enum Call267	where268		origin: <T as system::Config>::Origin269	{270		type Error = Error<T>;271		fn deposit_event() = default;272273		/// Anonymously schedule a task.274		///275		/// # <weight>276		/// - S = Number of already scheduled calls277		/// - Base Weight: 22.29 + .126 * S µs278		/// - DB Weight:279		///     - Read: Agenda280		///     - Write: Agenda281		/// - Will use base weight of 25 which should be good for up to 30 scheduled calls282		/// # </weight>283		#[weight = <T as Config>::WeightInfo::schedule(T::MaxScheduledPerBlock::get())]284		fn schedule(origin,285			when: T::BlockNumber,286			maybe_periodic: Option<schedule::Period<T::BlockNumber>>,287			priority: schedule::Priority,288			call: Box<<T as Config>::Call>,289		)290		{291			let origin = <T as Config>::Origin::from(origin);292			Self::do_schedule_nameless(DispatchTime::At(when), maybe_periodic, priority, origin.caller().clone(), *call)?;293		}294295		/// Cancel an anonymously scheduled task.296		///297		/// # <weight>298		/// - S = Number of already scheduled calls299		/// - Base Weight: 22.15 + 2.869 * S µs300		/// - DB Weight:301		///     - Read: Agenda302		///     - Write: Agenda, Lookup303		/// - Will use base weight of 100 which should be good for up to 30 scheduled calls304		/// # </weight>305		#[weight = <T as Config>::WeightInfo::cancel(T::MaxScheduledPerBlock::get())]306		fn cancel(origin, when: T::BlockNumber, index: u32) {307			T::ScheduleOrigin::ensure_origin(origin.clone())?;308			let origin = <T as Config>::Origin::from(origin);309			Self::do_cancel(Some(origin.caller().clone()), (when, index))?;310		}311312		/// Schedule a named task.313		///314		/// # <weight>315		/// - S = Number of already scheduled calls316		/// - Base Weight: 29.6 + .159 * S µs317		/// - DB Weight:318		///     - Read: Agenda, Lookup319		///     - Write: Agenda, Lookup320		/// - Will use base weight of 35 which should be good for more than 30 scheduled calls321		/// # </weight>322		#[weight = <T as Config>::WeightInfo::schedule_named(T::MaxScheduledPerBlock::get())]323		fn schedule_named(origin,324			id: Vec<u8>,325			when: T::BlockNumber,326			maybe_periodic: Option<schedule::Period<T::BlockNumber>>,327			priority: schedule::Priority,328			call: Box<<T as Config>::Call>,329		) {330			T::ScheduleOrigin::ensure_origin(origin.clone())?;331			let origin = <T as Config>::Origin::from(origin);332			Self::do_schedule_named(333				id, DispatchTime::At(when), maybe_periodic, priority, origin.caller().clone(), *call334			)?;335		}336337		/// Cancel a named scheduled task.338		///339		/// # <weight>340		/// - S = Number of already scheduled calls341		/// - Base Weight: 24.91 + 2.907 * S µs342		/// - DB Weight:343		///     - Read: Agenda, Lookup344		///     - Write: Agenda, Lookup345		/// - Will use base weight of 100 which should be good for up to 30 scheduled calls346		/// # </weight>347		#[weight = <T as Config>::WeightInfo::cancel_named(T::MaxScheduledPerBlock::get())]348		fn cancel_named(origin, id: Vec<u8>) {349			T::ScheduleOrigin::ensure_origin(origin.clone())?;350			let origin = <T as Config>::Origin::from(origin);351			Self::do_cancel_named(Some(origin.caller().clone()), id)?;352		}353354		/// Anonymously schedule a task after a delay.355		///356		/// # <weight>357		/// Same as [`schedule`].358		/// # </weight>359		#[weight = <T as Config>::WeightInfo::schedule(T::MaxScheduledPerBlock::get())]360		fn schedule_after(origin,361			after: T::BlockNumber,362			maybe_periodic: Option<schedule::Period<T::BlockNumber>>,363			priority: schedule::Priority,364			call: Box<<T as Config>::Call>,365		) {366			T::ScheduleOrigin::ensure_origin(origin.clone())?;367			let origin = <T as Config>::Origin::from(origin);368			Self::do_schedule_nameless(369				DispatchTime::After(after), maybe_periodic, priority, origin.caller().clone(), *call370			)?;371		}372373		/// Schedule a named task after a delay.374		///375		/// # <weight>376		/// Same as [`schedule_named`].377		/// # </weight>378		#[weight = <T as Config>::WeightInfo::schedule_named(T::MaxScheduledPerBlock::get())]379		fn schedule_named_after(origin,380			id: Vec<u8>,381			after: T::BlockNumber,382			maybe_periodic: Option<schedule::Period<T::BlockNumber>>,383			priority: schedule::Priority,384			call: Box<<T as Config>::Call>,385		) {386			T::ScheduleOrigin::ensure_origin(origin.clone())?;387			let origin = <T as Config>::Origin::from(origin);388			Self::do_schedule_named(389				id, DispatchTime::After(after), maybe_periodic, priority, origin.caller().clone(), *call390			)?;391		}392393		/// Execute the scheduled calls394		///395		/// # <weight>396		/// - S = Number of already scheduled calls397		/// - N = Named scheduled calls398		/// - P = Periodic Calls399		/// - Base Weight: 9.243 + 23.45 * S µs400		/// - DB Weight:401		///     - Read: Agenda + Lookup * N + Agenda(Future) * P402		///     - Write: Agenda + Lookup * N  + Agenda(future) * P403		/// # </weight>404		fn on_initialize(now: T::BlockNumber) -> Weight {405			let limit = T::MaximumWeight::get();406			let mut queued = Agenda::<T>::take(now)407				.into_iter()408				.enumerate()409				.filter_map(|(index, s)| s.map(|inner| (index as u32, inner)))410				.collect::<Vec<_>>();411			if queued.len() as u32 > T::MaxScheduledPerBlock::get() {412				log::warn!(413					target: "runtime::scheduler",414					"Warning: This block has more items queued in Scheduler than \415					expected from the runtime configuration. An update might be needed."416				);417			}418			queued.sort_by_key(|(_, s)| s.priority);419			let base_weight: Weight = T::DbWeight::get().reads_writes(1, 2); // Agenda + Agenda(next)420			let mut total_weight: Weight = 0; // T::WeightInfo::on_initialize(0)421			queued.into_iter()422				.enumerate()423				.scan(base_weight, |cumulative_weight, (order, (index, s))| {424					*cumulative_weight = cumulative_weight425						.saturating_add(s.call.get_dispatch_info().weight);426427					let origin = <<T as Config>::Origin as From<T::PalletsOrigin>>::from(428						s.origin.clone()429					).into();430431					if ensure_signed(origin).is_ok() {432						 // AccountData for inner call origin accountdata.433						*cumulative_weight = cumulative_weight434							.saturating_add(T::DbWeight::get().reads_writes(1, 1));435					}436437					if s.maybe_id.is_some() {438						// Remove/Modify Lookup439						*cumulative_weight = cumulative_weight.saturating_add(T::DbWeight::get().writes(1));440					}441					if s.maybe_periodic.is_some() {442						// Read/Write Agenda for future block443						*cumulative_weight = cumulative_weight.saturating_add(T::DbWeight::get().reads_writes(1, 1));444					}445446					Some((order, index, *cumulative_weight, s))447				})448				.filter_map(|(order, index, cumulative_weight, mut s)| {449					// We allow a scheduled call if:450					// - It's priority is `HARD_DEADLINE`451					// - It does not push the weight past the limit452					// or, alternatively,453					// - It is the first item in the schedule454					if s.priority <= schedule::HARD_DEADLINE && cumulative_weight <= limit || order == 0 {455						let r = T::CallExecutor::dispatch_call(s.pre_dispatch.clone(), s.call.clone());456457						if let Err(_) = r {458							log::warn!(459								target: "runtime::scheduler",460								"Warning: Scheduler has failed to execute a post-dispatch transaction. \461								This block might have become invalid.",462							);463							// todo possibly force a skip/return here, do something with the error464						}465466						let r = r.unwrap(); // todo dangerous! but it shouldn't come to that, and if it does, the error is critical, is it safe to panic?467468						let maybe_id = s.maybe_id.clone();469						if let Some((period, count)) = s.maybe_periodic {470							if count > 1 {471								s.maybe_periodic = Some((period, count - 1));472							} else {473								s.maybe_periodic = None;474							}475							let next = now + period;476							// If scheduled is named, place it's information in `Lookup`477							if let Some(ref id) = s.maybe_id {478								let next_index = Agenda::<T>::decode_len(now + period).unwrap_or(0);479								Lookup::<T>::insert(id, (next, next_index as u32));480							}481							Agenda::<T>::append(next, Some(s));482						} else if let Some(ref id) = s.maybe_id {483									  Lookup::<T>::remove(id);484								  }485						Self::deposit_event(RawEvent::Dispatched(486							(now, index),487							maybe_id,488							r.map(|_| ()).map_err(|e| e.error)489						));490						total_weight = cumulative_weight;491						None492					} else {493						Some(Some(s))494					}495				})496				.for_each(|unused| {497					let next = now + One::one();498					Agenda::<T>::append(next, unused);499				});500501			total_weight502		}503	}504}505506impl<T: Config> Module<T> {507	fn resolve_time(when: DispatchTime<T::BlockNumber>) -> Result<T::BlockNumber, DispatchError> {508		let now = frame_system::Pallet::<T>::block_number();509510		let when = match when {511			DispatchTime::At(x) => x,512			// The current block has already completed it's scheduled tasks, so513			// Schedule the task at lest one block after this current block.514			DispatchTime::After(x) => now.saturating_add(x).saturating_add(One::one()),515		};516517		if when <= now {518			return Err(Error::<T>::TargetBlockNumberInPast.into());519		}520521		Ok(when)522	}523524	fn do_schedule(525		maybe_id: Option<Vec<u8>>,526		when: DispatchTime<T::BlockNumber>,527		maybe_periodic: Option<schedule::Period<T::BlockNumber>>,528		priority: schedule::Priority,529		origin: T::PalletsOrigin,530		call: <T as Config>::Call,531	) -> Result<(T::BlockNumber, u32), DispatchError> {532		let when = Self::resolve_time(when)?;533534		let sender = ensure_signed(535			<<T as Config>::Origin as From<T::PalletsOrigin>>::from(origin.clone()).into(),536		)537		.unwrap_or_default(); // todo sponsoring doesn't work with the line below -- found sponsoring is already checked for in transaction_payment538					  //let who_will_pay = T::SponsorshipHandler::get_sponsor(&sender, &call).unwrap_or(sender);539					  //let sponsor = T::PalletsOrigin::from(system::RawOrigin::Signed(who_will_pay.clone()));540					  //let r = call.clone().dispatch(sponsor.into());541542		let pre_dispatch = match T::CallExecutor::pre_dispatch(sender.clone(), call.clone()) {543			Ok(pre_dispatch) => pre_dispatch,544			Err(_) => return Err(Error::<T>::FailedToSchedule.into()),545		};546547		// todo continually pre-dispatch according to maybe_periodic -- but it's called only once?548		// no, reschedule and cancel rely on scheduled being only the next instance549		// actually can count with OnChargePayment, so no need to run around. expand Pre with unspent_total_fee and single_fee, deduct single_fee550551		// sanitize maybe_periodic552		let maybe_periodic = maybe_periodic553			.filter(|p| p.1 > 1 && !p.0.is_zero())554			// Limit the repetitions to 100 calls and remove one from the number of repetitions since we will schedule one now.555			.map(|(p, c)| (p, cmp::min(c, PERIODIC_CALLS_LIMIT) - 1));556557		if let Some(periodic) = maybe_periodic {558			for _i in 0..=periodic.1 {559				// displace to runtime and count the total required fee, then deduct. find a way to use OnChargePayment560				// send constants and priority to runtime for fee computation, too. should create constants here or just declare them in runtime?561				// roadblock - they will return on post_dispatch -- oh! tips?562			}563		}564565		let s = Some(Scheduled {566			maybe_id,567			priority,568			call,569			maybe_periodic,570			origin,571			pre_dispatch,572			_phantom: PhantomData::<T::AccountId>::default(),573		});574		Agenda::<T>::append(when, s);575		let index = Agenda::<T>::decode_len(when).unwrap_or(1) as u32 - 1;576		if index > T::MaxScheduledPerBlock::get() {577			log::warn!(578				target: "runtime::scheduler",579				"Warning: There are more items queued in the Scheduler than \580				expected from the runtime configuration. An update might be needed.",581			);582		}583584		Ok((when, index))585	}586587	fn do_schedule_nameless(588		when: DispatchTime<T::BlockNumber>,589		maybe_periodic: Option<schedule::Period<T::BlockNumber>>,590		priority: schedule::Priority,591		origin: T::PalletsOrigin,592		call: <T as Config>::Call,593	) -> Result<TaskAddress<T::BlockNumber>, DispatchError> {594		let address = Self::do_schedule(None, when, maybe_periodic, priority, origin, call)?;595		let (when, index) = address;596597		Self::deposit_event(RawEvent::Scheduled(when, index));598599		Ok(address)600	}601602	fn do_cancel(603		origin: Option<T::PalletsOrigin>,604		(when, index): TaskAddress<T::BlockNumber>,605	) -> Result<(), DispatchError> {606		let scheduled = Agenda::<T>::try_mutate(when, |agenda| {607			agenda.get_mut(index as usize).map_or(608				Ok(None),609				|s| -> Result<Option<Scheduled<_, _, _, _, _>>, DispatchError> {610					if let (Some(ref o), Some(ref s)) = (origin, s.borrow()) {611						if *o != s.origin {612							return Err(BadOrigin.into());613						}614					};615					Ok(s.take())616				},617			)618		})?;619		if let Some(s) = scheduled {620			if let Some(id) = s.maybe_id {621				Lookup::<T>::remove(id);622			}623			if let Err(_) = T::CallExecutor::cancel_dispatch(s.pre_dispatch.clone()) {624				log::warn!(625					target: "runtime::scheduler",626					"Warning: Scheduler has failed to execute a post-dispatch transaction. \627					This block might have become invalid.",628				);629			} // maybe do something with the error?630			Self::deposit_event(RawEvent::Canceled(when, index));631			Ok(())632		} else {633			Err(Error::<T>::NotFound.into())634		}635	}636637	fn do_reschedule(638		(when, index): TaskAddress<T::BlockNumber>,639		new_time: DispatchTime<T::BlockNumber>,640	) -> Result<TaskAddress<T::BlockNumber>, DispatchError> {641		let new_time = Self::resolve_time(new_time)?;642643		if new_time == when {644			return Err(Error::<T>::RescheduleNoChange.into());645		}646647		Agenda::<T>::try_mutate(when, |agenda| -> DispatchResult {648			let task = agenda.get_mut(index as usize).ok_or(Error::<T>::NotFound)?;649			let task = task.take().ok_or(Error::<T>::NotFound)?;650			Agenda::<T>::append(new_time, Some(task));651			Ok(())652		})?;653654		let new_index = Agenda::<T>::decode_len(new_time).unwrap_or(1) as u32 - 1;655		Self::deposit_event(RawEvent::Canceled(when, index));656		Self::deposit_event(RawEvent::Scheduled(new_time, new_index));657658		Ok((new_time, new_index))659	}660661	fn do_schedule_named(662		id: Vec<u8>,663		when: DispatchTime<T::BlockNumber>,664		maybe_periodic: Option<schedule::Period<T::BlockNumber>>,665		priority: schedule::Priority,666		origin: T::PalletsOrigin,667		call: <T as Config>::Call,668	) -> Result<TaskAddress<T::BlockNumber>, DispatchError> {669		// ensure id length does not exceed expectations & is unique670		if id.len() > MAX_TASK_ID_LENGTH_IN_BYTES.try_into().unwrap()671			|| Lookup::<T>::contains_key(&id)672		{673			return Err(Error::<T>::FailedToSchedule.into());674		}675676		let address = Self::do_schedule(677			Some(id.clone()),678			when,679			maybe_periodic,680			priority,681			origin,682			call,683		)?;684		let (when, index) = address;685686		Lookup::<T>::insert(&id, &address);687		Self::deposit_event(RawEvent::Scheduled(when, index));688		Ok(address)689	}690691	fn do_cancel_named(origin: Option<T::PalletsOrigin>, id: Vec<u8>) -> DispatchResult {692		Lookup::<T>::try_mutate_exists(id, |lookup| -> DispatchResult {693			if let Some((when, index)) = lookup.take() {694				let i = index as usize;695				Agenda::<T>::try_mutate(when, |agenda| -> DispatchResult {696					if let Some(s) = agenda.get_mut(i) {697						if let (Some(ref o), Some(ref s)) = (origin, s.borrow()) {698							if *o != s.origin {699								return Err(BadOrigin.into());700							}701							if let Err(_) = T::CallExecutor::cancel_dispatch(s.pre_dispatch.clone())702							{703								log::warn!(704									target: "runtime::scheduler",705									"Warning: Scheduler has failed to execute a post-dispatch transaction. \706									This block might have become invalid.",707								);708							} // maybe do something with the error?709						}710						*s = None;711					}712					Ok(())713				})?;714				Self::deposit_event(RawEvent::Canceled(when, index));715				Ok(())716			} else {717				Err(Error::<T>::NotFound.into())718			}719		})720	}721722	fn do_reschedule_named(723		id: Vec<u8>,724		new_time: DispatchTime<T::BlockNumber>,725	) -> Result<TaskAddress<T::BlockNumber>, DispatchError> {726		let new_time = Self::resolve_time(new_time)?;727728		Lookup::<T>::try_mutate_exists(729			id,730			|lookup| -> Result<TaskAddress<T::BlockNumber>, DispatchError> {731				let (when, index) = lookup.ok_or(Error::<T>::NotFound)?;732733				if new_time == when {734					return Err(Error::<T>::RescheduleNoChange.into());735				}736737				Agenda::<T>::try_mutate(when, |agenda| -> DispatchResult {738					let task = agenda.get_mut(index as usize).ok_or(Error::<T>::NotFound)?;739					let task = task.take().ok_or(Error::<T>::NotFound)?;740					Agenda::<T>::append(new_time, Some(task));741742					Ok(())743				})?;744745				let new_index = Agenda::<T>::decode_len(new_time).unwrap_or(1) as u32 - 1;746				Self::deposit_event(RawEvent::Canceled(when, index));747				Self::deposit_event(RawEvent::Scheduled(new_time, new_index));748749				*lookup = Some((new_time, new_index));750751				Ok((new_time, new_index))752			},753		)754	}755}756757impl<T: Config> schedule::Anon<T::BlockNumber, <T as Config>::Call, T::PalletsOrigin>758	for Module<T>759{760	type Address = TaskAddress<T::BlockNumber>;761762	fn schedule(763		when: DispatchTime<T::BlockNumber>,764		maybe_periodic: Option<schedule::Period<T::BlockNumber>>,765		priority: schedule::Priority,766		origin: T::PalletsOrigin,767		call: <T as Config>::Call,768	) -> Result<Self::Address, DispatchError> {769		Self::do_schedule_nameless(when, maybe_periodic, priority, origin, call)770	}771772	fn cancel((when, index): Self::Address) -> Result<(), ()> {773		Self::do_cancel(None, (when, index)).map_err(|_| ())774	}775776	fn reschedule(777		address: Self::Address,778		when: DispatchTime<T::BlockNumber>,779	) -> Result<Self::Address, DispatchError> {780		Self::do_reschedule(address, when)781	}782783	fn next_dispatch_time((when, index): Self::Address) -> Result<T::BlockNumber, ()> {784		Agenda::<T>::get(when)785			.get(index as usize)786			.ok_or(())787			.map(|_| when)788	}789}790791impl<T: Config> schedule::Named<T::BlockNumber, <T as Config>::Call, T::PalletsOrigin>792	for Module<T>793{794	type Address = TaskAddress<T::BlockNumber>;795796	fn schedule_named(797		id: Vec<u8>,798		when: DispatchTime<T::BlockNumber>,799		maybe_periodic: Option<schedule::Period<T::BlockNumber>>,800		priority: schedule::Priority,801		origin: T::PalletsOrigin,802		call: <T as Config>::Call,803	) -> Result<Self::Address, ()> {804		Self::do_schedule_named(id, when, maybe_periodic, priority, origin, call).map_err(|_| ())805	}806807	fn cancel_named(id: Vec<u8>) -> Result<(), ()> {808		Self::do_cancel_named(None, id).map_err(|_| ())809	}810811	fn reschedule_named(812		id: Vec<u8>,813		when: DispatchTime<T::BlockNumber>,814	) -> Result<Self::Address, DispatchError> {815		Self::do_reschedule_named(id, when)816	}817818	fn next_dispatch_time(id: Vec<u8>) -> Result<T::BlockNumber, ()> {819		Lookup::<T>::get(id)820			.and_then(|(when, index)| Agenda::<T>::get(when).get(index as usize).map(|_| when))821			.ok_or(())822	}823}824825#[cfg(test)]826#[allow(clippy::from_over_into)]827mod tests {828	use super::*;829830	use frame_support::{831		ord_parameter_types, parameter_types, traits::Contains, weights::constants::RocksDbWeight,832	};833	use sp_core::H256;834	use sp_runtime::{835		Perbill,836		testing::Header,837		traits::{BlakeTwo256, IdentityLookup},838	};839	use frame_system::{EnsureOneOf, EnsureRoot, EnsureSignedBy};840	use crate as scheduler;841842	mod logger {843		use super::*;844		use std::cell::RefCell;845846		thread_local! {847			static LOG: RefCell<Vec<(OriginCaller, u32)>> = RefCell::new(Vec::new());848		}849		pub trait Config: system::Config {850			type Event: From<Event> + Into<<Self as system::Config>::Event>;851		}852		decl_event! {853			pub enum Event {854				Logged(u32, Weight),855			}856		}857		decl_module! {858			pub struct Module<T: Config> for enum Call859			where860				origin: <T as system::Config>::Origin,861					<T as system::Config>::Origin: OriginTrait<PalletsOrigin = OriginCaller>862			{863				fn deposit_event() = default;864865				#[weight = *weight]866				fn log(origin, i: u32, weight: Weight) {867					Self::deposit_event(Event::Logged(i, weight));868					LOG.with(|log| {869						log.borrow_mut().push((origin.caller().clone(), i));870					})871				}872873				#[weight = *weight]874				fn log_without_filter(origin, i: u32, weight: Weight) {875					Self::deposit_event(Event::Logged(i, weight));876					LOG.with(|log| {877						log.borrow_mut().push((origin.caller().clone(), i));878					})879				}880			}881		}882	}883884	type UncheckedExtrinsic = frame_system::mocking::MockUncheckedExtrinsic<Test>;885	type Block = frame_system::mocking::MockBlock<Test>;886887	frame_support::construct_runtime!(888		pub enum Test where889			Block = Block,890			NodeBlock = Block,891			UncheckedExtrinsic = UncheckedExtrinsic,892		{893			System: frame_system::{Pallet, Call, Config, Storage, Event<T>},894			Logger: logger::{Pallet, Call, Event},895			Scheduler: scheduler::{Pallet, Call, Storage, Event<T>},896		}897	);898899	// Scheduler must dispatch with root and no filter, this tests base filter is indeed not used.900	pub struct BaseFilter;901	impl Contains<Call> for BaseFilter {902		fn contains(call: &Call) -> bool {903			!matches!(call, Call::Logger(logger::Call::log { .. }))904		}905	}906907	pub struct DummyExecutor;908	impl<T: frame_system::Config + Config, SelfContainedSignedInfo>909		DispatchCall<T, SelfContainedSignedInfo> for DummyExecutor910	{911		type Pre = ();912913		fn dispatch_call(914			_pre: Self::Pre,915			_call: <T as Config>::Call,916		) -> Result<917			Result<PostDispatchInfo, DispatchErrorWithPostInfo<PostDispatchInfo>>,918			TransactionValidityError,919		> {920			todo!()921		}922923		fn pre_dispatch(924			_signer: <T as frame_system::Config>::AccountId,925			_call: <T as Config>::Call,926		) -> Result<Self::Pre, TransactionValidityError> {927			todo!()928		}929930		fn cancel_dispatch(_pre: Self::Pre) -> Result<(), TransactionValidityError> {931			todo!()932		}933	}934935	parameter_types! {936		pub const BlockHashCount: u64 = 250;937		pub BlockWeights: frame_system::limits::BlockWeights =938			frame_system::limits::BlockWeights::simple_max(2_000_000_000_000);939	}940	impl system::Config for Test {941		type BaseCallFilter = BaseFilter;942		type BlockWeights = ();943		type BlockLength = ();944		type DbWeight = RocksDbWeight;945		type Origin = Origin;946		type Call = Call;947		type Index = u64;948		type BlockNumber = u64;949		type Hash = H256;950		type Hashing = BlakeTwo256;951		type AccountId = u64;952		type Lookup = IdentityLookup<Self::AccountId>;953		type Header = Header;954		type Event = Event;955		type BlockHashCount = BlockHashCount;956		type Version = ();957		type PalletInfo = PalletInfo;958		type AccountData = ();959		type OnNewAccount = ();960		type OnKilledAccount = ();961		type SystemWeightInfo = ();962		type SS58Prefix = ();963		type OnSetCode = ();964	}965	impl logger::Config for Test {966		type Event = Event;967	}968	parameter_types! {969		pub MaximumSchedulerWeight: Weight = Perbill::from_percent(80) * BlockWeights::get().max_block;970		pub const MaxScheduledPerBlock: u32 = 10;971	}972	ord_parameter_types! {973		pub const One: u64 = 1;974	}975976	impl Config for Test {977		type Event = Event;978		type Origin = Origin;979		type PalletsOrigin = OriginCaller;980		type Call = Call;981		type MaximumWeight = MaximumSchedulerWeight;982		type ScheduleOrigin = EnsureOneOf<u64, EnsureRoot<u64>, EnsureSignedBy<One, u64>>;983		type MaxScheduledPerBlock = MaxScheduledPerBlock;984		type SponsorshipHandler = ();985		type WeightInfo = ();986		type CallExecutor = DummyExecutor;987	}988}
after · pallets/scheduler/src/lib.rs
1// This file is part of Substrate.23// Copyright (C) 2017-2021 Parity Technologies (UK) Ltd.4// SPDX-License-Identifier: Apache-2.056// Licensed under the Apache License, Version 2.0 (the "License");7// you may not use this file except in compliance with the License.8// You may obtain a copy of the License at9//10// 	http://www.apache.org/licenses/LICENSE-2.011//12// Unless required by applicable law or agreed to in writing, software13// distributed under the License is distributed on an "AS IS" BASIS,14// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.15// See the License for the specific language governing permissions and16// limitations under the License.1718//! # Scheduler19//! A module for scheduling dispatches.20//!21//! - [`Config`]22//! - [`Call`]23//! - [`Module`]24//!25//! ## Overview26//!27//! This module exposes capabilities for scheduling dispatches to occur at a28//! specified block number or at a specified period. These scheduled dispatches29//! may be named or anonymous and may be canceled.30//!31//! **NOTE:** The scheduled calls will be dispatched with the default filter32//! for the origin: namely `frame_system::Config::BaseCallFilter` for all origin33//! except root which will get no filter. And not the filter contained in origin34//! use to call `fn schedule`.35//!36//! If a call is scheduled using proxy or whatever mecanism which adds filter,37//! then those filter will not be used when dispatching the schedule call.38//!39//! ## Interface40//!41//! ### Dispatchable Functions42//!43//! * `schedule` - schedule a dispatch, which may be periodic, to occur at a44//!   specified block and with a specified priority.45//! * `cancel` - cancel a scheduled dispatch, specified by block number and46//!   index.47//! * `schedule_named` - augments the `schedule` interface with an additional48//!   `Vec<u8>` parameter that can be used for identification.49//! * `cancel_named` - the named complement to the cancel function.5051// Ensure we're `no_std` when compiling for Wasm.52#![cfg_attr(not(feature = "std"), no_std)]53#![allow(clippy::type_complexity, clippy::boxed_local, clippy::unused_unit)]5455mod benchmarking;56pub mod weights;5758use sp_std::{prelude::*, marker::PhantomData, borrow::Borrow, cmp};59use codec::{Encode, Decode, Codec};60use sp_runtime::{61	RuntimeDebug,62	traits::{Zero, One, BadOrigin, Saturating},63	transaction_validity::TransactionValidityError,64	DispatchErrorWithPostInfo,65};66use frame_support::{67	decl_module, decl_storage, decl_event, decl_error,68	dispatch::{Dispatchable, DispatchError, DispatchResult, Parameter},69	traits::{70		Get,71		schedule::{self, DispatchTime},72		OriginTrait, EnsureOrigin, IsType,73	},74	weights::{GetDispatchInfo, Weight, PostDispatchInfo},75};76use frame_system::{self as system, ensure_signed};77pub use weights::WeightInfo;78use up_sponsorship::SponsorshipHandler;79use scale_info::TypeInfo;80use sp_core::H160;8182/// Our pallet's configuration trait. All our types and constants go in here. If the83/// pallet is dependent on specific other pallets, then their configuration traits84/// should be added to our implied traits list.85///86/// `system::Config` should always be included in our implied traits.87/// //88pub trait Config: system::Config {89	/// The overarching event type.90	type Event: From<Event<Self>> + Into<<Self as system::Config>::Event>;9192	/// The aggregated origin which the dispatch will take.93	type Origin: OriginTrait<PalletsOrigin = Self::PalletsOrigin>94		+ From<Self::PalletsOrigin>95		+ IsType<<Self as system::Config>::Origin>;9697	/// The caller origin, overarching type of all pallets origins.98	type PalletsOrigin: From<system::RawOrigin<Self::AccountId>> + Codec + TypeInfo + Clone + Eq;99100	/// The aggregated call type.101	type Call: Parameter102		+ Dispatchable<Origin = <Self as Config>::Origin>103		+ GetDispatchInfo104		+ From<system::Call<Self>>;105106	/// The maximum weight that may be scheduled per block for any dispatchables of less priority107	/// than `schedule::HARD_DEADLINE`.108	type MaximumWeight: Get<Weight>;109110	/// Required origin to schedule or cancel calls.111	type ScheduleOrigin: EnsureOrigin<<Self as system::Config>::Origin>;112113	/// The maximum number of scheduled calls in the queue for a single block.114	/// Not strictly enforced, but used for weight estimation.115	type MaxScheduledPerBlock: Get<u32>;116117	/// Sponsoring function.118	type SponsorshipHandler: SponsorshipHandler<Self::AccountId, <Self as Config>::Call>;119120	/// Weight information for extrinsics in this pallet.121	type WeightInfo: WeightInfo;122123	/// The helper type used for custom transaction fee logic.124	type CallExecutor: DispatchCall<Self, H160>;125}126127/// A Scheduler-Runtime interface for finer payment handling.128pub trait DispatchCall<T: frame_system::Config + Config, SelfContainedSignedInfo> {129	/// The type that encodes information that can be passed from pre_dispatch to post-dispatch.130	type Pre: Default + Codec + Clone + TypeInfo;131132	/// Resolve the call dispatch, including any post-dispatch operations.133	fn dispatch_call(134		pre_dispatch: Self::Pre,135		function: <T as Config>::Call,136	) -> Result<137		Result<PostDispatchInfo, DispatchErrorWithPostInfo<PostDispatchInfo>>,138		TransactionValidityError,139	>;140141	/// Prepare for the scheduled call (e.g. by withdrawing the fee in advance).142	fn pre_dispatch(143		signer: T::AccountId,144		function: <T as Config>::Call,145	) -> Result<Self::Pre, TransactionValidityError>;146147	/// Perform a clean-up after a cancelled call (e.g. by returning the remaining fee).148	fn cancel_dispatch(pre_dispatch: Self::Pre) -> Result<(), TransactionValidityError>;149}150151pub const MAX_TASK_ID_LENGTH_IN_BYTES: u8 = 16;152153pub const PERIODIC_CALLS_LIMIT: u32 = 100;154155// pub type SelfWeightInfo<T> = <T as system::Config>::WeightInfo;156157/// Just a simple index for naming period tasks.158pub type PeriodicIndex = u32;159/// The location of a scheduled task that can be used to remove it.160pub type TaskAddress<BlockNumber> = (BlockNumber, u32);161162/// Information regarding an item to be executed in the future.163#[cfg_attr(any(feature = "std", test), derive(PartialEq, Eq))]164#[derive(Clone, RuntimeDebug, Encode, Decode, TypeInfo)]165pub struct Scheduled<Call, BlockNumber, PalletsOrigin, AccountId, PreDispatch> {166	/// The unique identity for this task, if there is one.167	maybe_id: Option<Vec<u8>>,168	/// This task's priority.169	priority: schedule::Priority,170	/// The call to be dispatched.171	call: Call,172	/// If the call is periodic, then this points to the information concerning that.173	maybe_periodic: Option<schedule::Period<BlockNumber>>,174	/// The origin to dispatch the call.175	origin: PalletsOrigin,176	/// The information regarding the call's preparation for dispatch, in particular the fee, to be sent to post-dispatch.177	pre_dispatch: PreDispatch,178	_phantom: PhantomData<AccountId>,179}180181#[derive(Encode, Decode, Clone, PartialEq, Eq, RuntimeDebug, TypeInfo)]182pub struct CallSpec {183	module: u32,184	method: u32,185}186187decl_storage! {188	trait Store for Module<T: Config> as Scheduler {189		/// Items to be executed, indexed by the block number that they should be executed on.190		pub Agenda: map hasher(twox_64_concat) T::BlockNumber191			=> Vec<Option<Scheduled<192				<T as Config>::Call,193				T::BlockNumber,194				T::PalletsOrigin,195				T::AccountId,196				<<T as Config>::CallExecutor as DispatchCall<T, H160>>::Pre197			>>>;198			199		/// Lookup from identity to the block number and index of the task.200		Lookup: map hasher(twox_64_concat) Vec<u8> => Option<TaskAddress<T::BlockNumber>>;201	}202}203204decl_event!(205	pub enum Event<T> where <T as system::Config>::BlockNumber {206		/// Scheduled some task. \[when, index\]207		Scheduled(BlockNumber, u32),208		/// Canceled some task. \[when, index\]209		Canceled(BlockNumber, u32),210		/// Dispatched some task. \[task, id, result\]211		Dispatched(TaskAddress<BlockNumber>, Option<Vec<u8>>, DispatchResult),212	}213);214215decl_error! {216	pub enum Error for Module<T: Config> {217		/// Failed to schedule a call218		FailedToSchedule,219		/// Cannot find the scheduled call.220		NotFound,221		/// Given target block number is in the past.222		TargetBlockNumberInPast,223		/// Reschedule failed because it does not change scheduled time.224		RescheduleNoChange,225	}226}227228decl_module! {229	/// Scheduler module declaration.230	pub struct Module<T: Config> for enum Call231	where232		origin: <T as system::Config>::Origin233	{234		type Error = Error<T>;235		fn deposit_event() = default;236237		/// Anonymously schedule a task.238		///239		/// # <weight>240		/// - S = Number of already scheduled calls241		/// - Base Weight: 22.29 + .126 * S µs242		/// - DB Weight:243		///     - Read: Agenda244		///     - Write: Agenda245		/// - Will use base weight of 25 which should be good for up to 30 scheduled calls246		/// # </weight>247		#[weight = <T as Config>::WeightInfo::schedule(T::MaxScheduledPerBlock::get())]248		fn schedule(origin,249			when: T::BlockNumber,250			maybe_periodic: Option<schedule::Period<T::BlockNumber>>,251			priority: schedule::Priority,252			call: Box<<T as Config>::Call>,253		)254		{255			let origin = <T as Config>::Origin::from(origin);256			Self::do_schedule_nameless(DispatchTime::At(when), maybe_periodic, priority, origin.caller().clone(), *call)?;257		}258259		/// Cancel an anonymously scheduled task.260		///261		/// # <weight>262		/// - S = Number of already scheduled calls263		/// - Base Weight: 22.15 + 2.869 * S µs264		/// - DB Weight:265		///     - Read: Agenda266		///     - Write: Agenda, Lookup267		/// - Will use base weight of 100 which should be good for up to 30 scheduled calls268		/// # </weight>269		#[weight = <T as Config>::WeightInfo::cancel(T::MaxScheduledPerBlock::get())]270		fn cancel(origin, when: T::BlockNumber, index: u32) {271			T::ScheduleOrigin::ensure_origin(origin.clone())?;272			let origin = <T as Config>::Origin::from(origin);273			Self::do_cancel(Some(origin.caller().clone()), (when, index))?;274		}275276		/// Schedule a named task.277		///278		/// # <weight>279		/// - S = Number of already scheduled calls280		/// - Base Weight: 29.6 + .159 * S µs281		/// - DB Weight:282		///     - Read: Agenda, Lookup283		///     - Write: Agenda, Lookup284		/// - Will use base weight of 35 which should be good for more than 30 scheduled calls285		/// # </weight>286		#[weight = <T as Config>::WeightInfo::schedule_named(T::MaxScheduledPerBlock::get())]287		fn schedule_named(origin,288			id: Vec<u8>,289			when: T::BlockNumber,290			maybe_periodic: Option<schedule::Period<T::BlockNumber>>,291			priority: schedule::Priority,292			call: Box<<T as Config>::Call>,293		) {294			T::ScheduleOrigin::ensure_origin(origin.clone())?;295			let origin = <T as Config>::Origin::from(origin);296			Self::do_schedule_named(297				id, DispatchTime::At(when), maybe_periodic, priority, origin.caller().clone(), *call298			)?;299		}300301		/// Cancel a named scheduled task.302		///303		/// # <weight>304		/// - S = Number of already scheduled calls305		/// - Base Weight: 24.91 + 2.907 * S µs306		/// - DB Weight:307		///     - Read: Agenda, Lookup308		///     - Write: Agenda, Lookup309		/// - Will use base weight of 100 which should be good for up to 30 scheduled calls310		/// # </weight>311		#[weight = <T as Config>::WeightInfo::cancel_named(T::MaxScheduledPerBlock::get())]312		fn cancel_named(origin, id: Vec<u8>) {313			T::ScheduleOrigin::ensure_origin(origin.clone())?;314			let origin = <T as Config>::Origin::from(origin);315			Self::do_cancel_named(Some(origin.caller().clone()), id)?;316		}317318		/// Anonymously schedule a task after a delay.319		///320		/// # <weight>321		/// Same as [`schedule`].322		/// # </weight>323		#[weight = <T as Config>::WeightInfo::schedule(T::MaxScheduledPerBlock::get())]324		fn schedule_after(origin,325			after: T::BlockNumber,326			maybe_periodic: Option<schedule::Period<T::BlockNumber>>,327			priority: schedule::Priority,328			call: Box<<T as Config>::Call>,329		) {330			T::ScheduleOrigin::ensure_origin(origin.clone())?;331			let origin = <T as Config>::Origin::from(origin);332			Self::do_schedule_nameless(333				DispatchTime::After(after), maybe_periodic, priority, origin.caller().clone(), *call334			)?;335		}336337		/// Schedule a named task after a delay.338		///339		/// # <weight>340		/// Same as [`schedule_named`].341		/// # </weight>342		#[weight = <T as Config>::WeightInfo::schedule_named(T::MaxScheduledPerBlock::get())]343		fn schedule_named_after(origin,344			id: Vec<u8>,345			after: T::BlockNumber,346			maybe_periodic: Option<schedule::Period<T::BlockNumber>>,347			priority: schedule::Priority,348			call: Box<<T as Config>::Call>,349		) {350			T::ScheduleOrigin::ensure_origin(origin.clone())?;351			let origin = <T as Config>::Origin::from(origin);352			Self::do_schedule_named(353				id, DispatchTime::After(after), maybe_periodic, priority, origin.caller().clone(), *call354			)?;355		}356357		/// Execute the scheduled calls358		///359		/// # <weight>360		/// - S = Number of already scheduled calls361		/// - N = Named scheduled calls362		/// - P = Periodic Calls363		/// - Base Weight: 9.243 + 23.45 * S µs364		/// - DB Weight:365		///     - Read: Agenda + Lookup * N + Agenda(Future) * P366		///     - Write: Agenda + Lookup * N  + Agenda(future) * P367		/// # </weight>368		fn on_initialize(now: T::BlockNumber) -> Weight {369			let limit = T::MaximumWeight::get();370			let mut queued = Agenda::<T>::take(now)371				.into_iter()372				.enumerate()373				.filter_map(|(index, s)| s.map(|inner| (index as u32, inner)))374				.collect::<Vec<_>>();375			if queued.len() as u32 > T::MaxScheduledPerBlock::get() {376				log::warn!(377					target: "runtime::scheduler",378					"Warning: This block has more items queued in Scheduler than \379					expected from the runtime configuration. An update might be needed."380				);381			}382			queued.sort_by_key(|(_, s)| s.priority);383			let base_weight: Weight = T::DbWeight::get().reads_writes(1, 2); // Agenda + Agenda(next)384			let mut total_weight: Weight = 0; // T::WeightInfo::on_initialize(0)385			queued.into_iter()386				.enumerate()387				.scan(base_weight, |cumulative_weight, (order, (index, s))| {388					*cumulative_weight = cumulative_weight389						.saturating_add(s.call.get_dispatch_info().weight);390391					let origin = <<T as Config>::Origin as From<T::PalletsOrigin>>::from(392						s.origin.clone()393					).into();394395					if ensure_signed(origin).is_ok() {396						 // AccountData for inner call origin accountdata.397						*cumulative_weight = cumulative_weight398							.saturating_add(T::DbWeight::get().reads_writes(1, 1));399					}400401					if s.maybe_id.is_some() {402						// Remove/Modify Lookup403						*cumulative_weight = cumulative_weight.saturating_add(T::DbWeight::get().writes(1));404					}405					if s.maybe_periodic.is_some() {406						// Read/Write Agenda for future block407						*cumulative_weight = cumulative_weight.saturating_add(T::DbWeight::get().reads_writes(1, 1));408					}409410					Some((order, index, *cumulative_weight, s))411				})412				.filter_map(|(order, index, cumulative_weight, mut s)| {413					// We allow a scheduled call if:414					// - It's priority is `HARD_DEADLINE`415					// - It does not push the weight past the limit416					// or, alternatively,417					// - It is the first item in the schedule418					if s.priority <= schedule::HARD_DEADLINE && cumulative_weight <= limit || order == 0 {419						let r = T::CallExecutor::dispatch_call(s.pre_dispatch.clone(), s.call.clone());420421						if let Err(_) = r {422							log::warn!(423								target: "runtime::scheduler",424								"Warning: Scheduler has failed to execute a post-dispatch transaction. \425								This block might have become invalid.",426							);427							// todo possibly force a skip/return here, do something with the error428						}429430						let r = r.unwrap(); // todo dangerous! but it shouldn't come to that, and if it does, the error is critical, is it safe to panic?431432						let maybe_id = s.maybe_id.clone();433						if let Some((period, count)) = s.maybe_periodic {434							if count > 1 {435								s.maybe_periodic = Some((period, count - 1));436							} else {437								s.maybe_periodic = None;438							}439							let next = now + period;440							// If scheduled is named, place it's information in `Lookup`441							if let Some(ref id) = s.maybe_id {442								let next_index = Agenda::<T>::decode_len(now + period).unwrap_or(0);443								Lookup::<T>::insert(id, (next, next_index as u32));444							}445							Agenda::<T>::append(next, Some(s));446						} else if let Some(ref id) = s.maybe_id {447									  Lookup::<T>::remove(id);448								  }449						Self::deposit_event(RawEvent::Dispatched(450							(now, index),451							maybe_id,452							r.map(|_| ()).map_err(|e| e.error)453						));454						total_weight = cumulative_weight;455						None456					} else {457						Some(Some(s))458					}459				})460				.for_each(|unused| {461					let next = now + One::one();462					Agenda::<T>::append(next, unused);463				});464465			total_weight466		}467	}468}469470impl<T: Config> Module<T> {471	fn resolve_time(when: DispatchTime<T::BlockNumber>) -> Result<T::BlockNumber, DispatchError> {472		let now = frame_system::Pallet::<T>::block_number();473474		let when = match when {475			DispatchTime::At(x) => x,476			// The current block has already completed it's scheduled tasks, so477			// Schedule the task at lest one block after this current block.478			DispatchTime::After(x) => now.saturating_add(x).saturating_add(One::one()),479		};480481		if when <= now {482			return Err(Error::<T>::TargetBlockNumberInPast.into());483		}484485		Ok(when)486	}487488	fn do_schedule(489		maybe_id: Option<Vec<u8>>,490		when: DispatchTime<T::BlockNumber>,491		maybe_periodic: Option<schedule::Period<T::BlockNumber>>,492		priority: schedule::Priority,493		origin: T::PalletsOrigin,494		call: <T as Config>::Call,495	) -> Result<(T::BlockNumber, u32), DispatchError> {496		let when = Self::resolve_time(when)?;497498		let sender = ensure_signed(499			<<T as Config>::Origin as From<T::PalletsOrigin>>::from(origin.clone()).into(),500		)501		.unwrap_or_default(); // todo sponsoring doesn't work with the line below -- found sponsoring is already checked for in transaction_payment502		//let who_will_pay = T::SponsorshipHandler::get_sponsor(&sender, &call).unwrap_or(sender);503		//let sponsor = T::PalletsOrigin::from(system::RawOrigin::Signed(who_will_pay.clone()));504		//let r = call.clone().dispatch(sponsor.into());505506		let pre_dispatch = match T::CallExecutor::pre_dispatch(sender.clone(), call.clone()) {507			Ok(pre_dispatch) => pre_dispatch,508			Err(_) => return Err(Error::<T>::FailedToSchedule.into()),509		};510511		// todo continually pre-dispatch according to maybe_periodic -- but it's called only once?512		// no, reschedule and cancel rely on scheduled being only the next instance513		// actually can count with OnChargePayment, so no need to run around. expand Pre with unspent_total_fee and single_fee, deduct single_fee514515		// sanitize maybe_periodic516		let maybe_periodic = maybe_periodic517			.filter(|p| p.1 > 1 && !p.0.is_zero())518			// Limit the repetitions to 100 calls and remove one from the number of repetitions since we will schedule one now.519			.map(|(p, c)| (p, cmp::min(c, PERIODIC_CALLS_LIMIT) - 1));520521		if let Some(periodic) = maybe_periodic {522			for _i in 0..=periodic.1 {523				// displace to runtime and count the total required fee, then deduct. find a way to use OnChargePayment524				// send constants and priority to runtime for fee computation, too. should create constants here or just declare them in runtime?525				// roadblock - they will return on post_dispatch -- oh! tips?526			}527		}528529		let s = Some(Scheduled {530			maybe_id,531			priority,532			call,533			maybe_periodic,534			origin,535			pre_dispatch,536			_phantom: PhantomData::<T::AccountId>::default(),537		});538		Agenda::<T>::append(when, s);539		let index = Agenda::<T>::decode_len(when).unwrap_or(1) as u32 - 1;540		if index > T::MaxScheduledPerBlock::get() {541			log::warn!(542				target: "runtime::scheduler",543				"Warning: There are more items queued in the Scheduler than \544				expected from the runtime configuration. An update might be needed.",545			);546		}547548		Ok((when, index))549	}550551	fn do_schedule_nameless(552		when: DispatchTime<T::BlockNumber>,553		maybe_periodic: Option<schedule::Period<T::BlockNumber>>,554		priority: schedule::Priority,555		origin: T::PalletsOrigin,556		call: <T as Config>::Call,557	) -> Result<TaskAddress<T::BlockNumber>, DispatchError> {558		let address = Self::do_schedule(None, when, maybe_periodic, priority, origin, call)?;559		let (when, index) = address;560561		Self::deposit_event(RawEvent::Scheduled(when, index));562563		Ok(address)564	}565566	fn do_cancel(567		origin: Option<T::PalletsOrigin>,568		(when, index): TaskAddress<T::BlockNumber>,569	) -> Result<(), DispatchError> {570		let scheduled = Agenda::<T>::try_mutate(when, |agenda| {571			agenda.get_mut(index as usize).map_or(572				Ok(None),573				|s| -> Result<Option<Scheduled<_, _, _, _, _>>, DispatchError> {574					if let (Some(ref o), Some(ref s)) = (origin, s.borrow()) {575						if *o != s.origin {576							return Err(BadOrigin.into());577						}578					};579					Ok(s.take())580				},581			)582		})?;583		if let Some(s) = scheduled {584			if let Some(id) = s.maybe_id {585				Lookup::<T>::remove(id);586			}587			if let Err(_) = T::CallExecutor::cancel_dispatch(s.pre_dispatch.clone()) {588				log::warn!(589					target: "runtime::scheduler",590					"Warning: Scheduler has failed to execute a post-dispatch transaction. \591					This block might have become invalid.",592				);593			} // maybe do something with the error?594			Self::deposit_event(RawEvent::Canceled(when, index));595			Ok(())596		} else {597			Err(Error::<T>::NotFound.into())598		}599	}600601	fn do_reschedule(602		(when, index): TaskAddress<T::BlockNumber>,603		new_time: DispatchTime<T::BlockNumber>,604	) -> Result<TaskAddress<T::BlockNumber>, DispatchError> {605		let new_time = Self::resolve_time(new_time)?;606607		if new_time == when {608			return Err(Error::<T>::RescheduleNoChange.into());609		}610611		Agenda::<T>::try_mutate(when, |agenda| -> DispatchResult {612			let task = agenda.get_mut(index as usize).ok_or(Error::<T>::NotFound)?;613			let task = task.take().ok_or(Error::<T>::NotFound)?;614			Agenda::<T>::append(new_time, Some(task));615			Ok(())616		})?;617618		let new_index = Agenda::<T>::decode_len(new_time).unwrap_or(1) as u32 - 1;619		Self::deposit_event(RawEvent::Canceled(when, index));620		Self::deposit_event(RawEvent::Scheduled(new_time, new_index));621622		Ok((new_time, new_index))623	}624625	fn do_schedule_named(626		id: Vec<u8>,627		when: DispatchTime<T::BlockNumber>,628		maybe_periodic: Option<schedule::Period<T::BlockNumber>>,629		priority: schedule::Priority,630		origin: T::PalletsOrigin,631		call: <T as Config>::Call,632	) -> Result<TaskAddress<T::BlockNumber>, DispatchError> {633		// ensure id length does not exceed expectations & is unique634		if id.len() > MAX_TASK_ID_LENGTH_IN_BYTES.try_into().unwrap()635			|| Lookup::<T>::contains_key(&id)636		{637			return Err(Error::<T>::FailedToSchedule.into());638		}639640		let address = Self::do_schedule(641			Some(id.clone()),642			when,643			maybe_periodic,644			priority,645			origin,646			call,647		)?;648		let (when, index) = address;649650		Lookup::<T>::insert(&id, &address);651		Self::deposit_event(RawEvent::Scheduled(when, index));652		Ok(address)653	}654655	fn do_cancel_named(origin: Option<T::PalletsOrigin>, id: Vec<u8>) -> DispatchResult {656		Lookup::<T>::try_mutate_exists(id, |lookup| -> DispatchResult {657			if let Some((when, index)) = lookup.take() {658				let i = index as usize;659				Agenda::<T>::try_mutate(when, |agenda| -> DispatchResult {660					if let Some(s) = agenda.get_mut(i) {661						if let (Some(ref o), Some(ref s)) = (origin, s.borrow()) {662							if *o != s.origin {663								return Err(BadOrigin.into());664							}665							if let Err(_) = T::CallExecutor::cancel_dispatch(s.pre_dispatch.clone())666							{667								log::warn!(668									target: "runtime::scheduler",669									"Warning: Scheduler has failed to execute a post-dispatch transaction. \670									This block might have become invalid.",671								);672							} // maybe do something with the error?673						}674						*s = None;675					}676					Ok(())677				})?;678				Self::deposit_event(RawEvent::Canceled(when, index));679				Ok(())680			} else {681				Err(Error::<T>::NotFound.into())682			}683		})684	}685686	fn do_reschedule_named(687		id: Vec<u8>,688		new_time: DispatchTime<T::BlockNumber>,689	) -> Result<TaskAddress<T::BlockNumber>, DispatchError> {690		let new_time = Self::resolve_time(new_time)?;691692		Lookup::<T>::try_mutate_exists(693			id,694			|lookup| -> Result<TaskAddress<T::BlockNumber>, DispatchError> {695				let (when, index) = lookup.ok_or(Error::<T>::NotFound)?;696697				if new_time == when {698					return Err(Error::<T>::RescheduleNoChange.into());699				}700701				Agenda::<T>::try_mutate(when, |agenda| -> DispatchResult {702					let task = agenda.get_mut(index as usize).ok_or(Error::<T>::NotFound)?;703					let task = task.take().ok_or(Error::<T>::NotFound)?;704					Agenda::<T>::append(new_time, Some(task));705706					Ok(())707				})?;708709				let new_index = Agenda::<T>::decode_len(new_time).unwrap_or(1) as u32 - 1;710				Self::deposit_event(RawEvent::Canceled(when, index));711				Self::deposit_event(RawEvent::Scheduled(new_time, new_index));712713				*lookup = Some((new_time, new_index));714715				Ok((new_time, new_index))716			},717		)718	}719}720721impl<T: Config> schedule::Anon<T::BlockNumber, <T as Config>::Call, T::PalletsOrigin>722	for Module<T>723{724	type Address = TaskAddress<T::BlockNumber>;725726	fn schedule(727		when: DispatchTime<T::BlockNumber>,728		maybe_periodic: Option<schedule::Period<T::BlockNumber>>,729		priority: schedule::Priority,730		origin: T::PalletsOrigin,731		call: <T as Config>::Call,732	) -> Result<Self::Address, DispatchError> {733		Self::do_schedule_nameless(when, maybe_periodic, priority, origin, call)734	}735736	fn cancel((when, index): Self::Address) -> Result<(), ()> {737		Self::do_cancel(None, (when, index)).map_err(|_| ())738	}739740	fn reschedule(741		address: Self::Address,742		when: DispatchTime<T::BlockNumber>,743	) -> Result<Self::Address, DispatchError> {744		Self::do_reschedule(address, when)745	}746747	fn next_dispatch_time((when, index): Self::Address) -> Result<T::BlockNumber, ()> {748		Agenda::<T>::get(when)749			.get(index as usize)750			.ok_or(())751			.map(|_| when)752	}753}754755impl<T: Config> schedule::Named<T::BlockNumber, <T as Config>::Call, T::PalletsOrigin>756	for Module<T>757{758	type Address = TaskAddress<T::BlockNumber>;759760	fn schedule_named(761		id: Vec<u8>,762		when: DispatchTime<T::BlockNumber>,763		maybe_periodic: Option<schedule::Period<T::BlockNumber>>,764		priority: schedule::Priority,765		origin: T::PalletsOrigin,766		call: <T as Config>::Call,767	) -> Result<Self::Address, ()> {768		Self::do_schedule_named(id, when, maybe_periodic, priority, origin, call).map_err(|_| ())769	}770771	fn cancel_named(id: Vec<u8>) -> Result<(), ()> {772		Self::do_cancel_named(None, id).map_err(|_| ())773	}774775	fn reschedule_named(776		id: Vec<u8>,777		when: DispatchTime<T::BlockNumber>,778	) -> Result<Self::Address, DispatchError> {779		Self::do_reschedule_named(id, when)780	}781782	fn next_dispatch_time(id: Vec<u8>) -> Result<T::BlockNumber, ()> {783		Lookup::<T>::get(id)784			.and_then(|(when, index)| Agenda::<T>::get(when).get(index as usize).map(|_| when))785			.ok_or(())786	}787}788789#[cfg(test)]790#[allow(clippy::from_over_into)]791mod tests {792	use super::*;793794	use frame_support::{795		ord_parameter_types, parameter_types, traits::Contains, weights::constants::RocksDbWeight,796	};797	use sp_core::H256;798	use sp_runtime::{799		Perbill,800		testing::Header,801		traits::{BlakeTwo256, IdentityLookup},802	};803	use frame_system::{EnsureOneOf, EnsureRoot, EnsureSignedBy};804	use crate as scheduler;805806	mod logger {807		use super::*;808		use std::cell::RefCell;809810		thread_local! {811			static LOG: RefCell<Vec<(OriginCaller, u32)>> = RefCell::new(Vec::new());812		}813		pub trait Config: system::Config {814			type Event: From<Event> + Into<<Self as system::Config>::Event>;815		}816		decl_event! {817			pub enum Event {818				Logged(u32, Weight),819			}820		}821		decl_module! {822			pub struct Module<T: Config> for enum Call823			where824				origin: <T as system::Config>::Origin,825					<T as system::Config>::Origin: OriginTrait<PalletsOrigin = OriginCaller>826			{827				fn deposit_event() = default;828829				#[weight = *weight]830				fn log(origin, i: u32, weight: Weight) {831					Self::deposit_event(Event::Logged(i, weight));832					LOG.with(|log| {833						log.borrow_mut().push((origin.caller().clone(), i));834					})835				}836837				#[weight = *weight]838				fn log_without_filter(origin, i: u32, weight: Weight) {839					Self::deposit_event(Event::Logged(i, weight));840					LOG.with(|log| {841						log.borrow_mut().push((origin.caller().clone(), i));842					})843				}844			}845		}846	}847848	type UncheckedExtrinsic = frame_system::mocking::MockUncheckedExtrinsic<Test>;849	type Block = frame_system::mocking::MockBlock<Test>;850851	frame_support::construct_runtime!(852		pub enum Test where853			Block = Block,854			NodeBlock = Block,855			UncheckedExtrinsic = UncheckedExtrinsic,856		{857			System: frame_system::{Pallet, Call, Config, Storage, Event<T>},858			Logger: logger::{Pallet, Call, Event},859			Scheduler: scheduler::{Pallet, Call, Storage, Event<T>},860		}861	);862863	// Scheduler must dispatch with root and no filter, this tests base filter is indeed not used.864	pub struct BaseFilter;865	impl Contains<Call> for BaseFilter {866		fn contains(call: &Call) -> bool {867			!matches!(call, Call::Logger(logger::Call::log { .. }))868		}869	}870871	pub struct DummyExecutor;872	impl<T: frame_system::Config + Config, SelfContainedSignedInfo>873		DispatchCall<T, SelfContainedSignedInfo> for DummyExecutor874	{875		type Pre = ();876877		fn dispatch_call(878			_pre: Self::Pre,879			_call: <T as Config>::Call,880		) -> Result<881			Result<PostDispatchInfo, DispatchErrorWithPostInfo<PostDispatchInfo>>,882			TransactionValidityError,883		> {884			todo!()885		}886887		fn pre_dispatch(888			_signer: <T as frame_system::Config>::AccountId,889			_call: <T as Config>::Call,890		) -> Result<Self::Pre, TransactionValidityError> {891			todo!()892		}893894		fn cancel_dispatch(_pre: Self::Pre) -> Result<(), TransactionValidityError> {895			todo!()896		}897	}898899	parameter_types! {900		pub const BlockHashCount: u64 = 250;901		pub BlockWeights: frame_system::limits::BlockWeights =902			frame_system::limits::BlockWeights::simple_max(2_000_000_000_000);903	}904	impl system::Config for Test {905		type BaseCallFilter = BaseFilter;906		type BlockWeights = ();907		type BlockLength = ();908		type DbWeight = RocksDbWeight;909		type Origin = Origin;910		type Call = Call;911		type Index = u64;912		type BlockNumber = u64;913		type Hash = H256;914		type Hashing = BlakeTwo256;915		type AccountId = u64;916		type Lookup = IdentityLookup<Self::AccountId>;917		type Header = Header;918		type Event = Event;919		type BlockHashCount = BlockHashCount;920		type Version = ();921		type PalletInfo = PalletInfo;922		type AccountData = ();923		type OnNewAccount = ();924		type OnKilledAccount = ();925		type SystemWeightInfo = ();926		type SS58Prefix = ();927		type OnSetCode = ();928	}929	impl logger::Config for Test {930		type Event = Event;931	}932	parameter_types! {933		pub MaximumSchedulerWeight: Weight = Perbill::from_percent(80) * BlockWeights::get().max_block;934		pub const MaxScheduledPerBlock: u32 = 10;935	}936	ord_parameter_types! {937		pub const One: u64 = 1;938	}939940	impl Config for Test {941		type Event = Event;942		type Origin = Origin;943		type PalletsOrigin = OriginCaller;944		type Call = Call;945		type MaximumWeight = MaximumSchedulerWeight;946		type ScheduleOrigin = EnsureOneOf<u64, EnsureRoot<u64>, EnsureSignedBy<One, u64>>;947		type MaxScheduledPerBlock = MaxScheduledPerBlock;948		type SponsorshipHandler = ();949		type WeightInfo = ();950		type CallExecutor = DummyExecutor;951	}952}
modifiedruntime/src/lib.rsdiffbeforeafterboth
--- a/runtime/src/lib.rs
+++ b/runtime/src/lib.rs
@@ -811,19 +811,6 @@
 
 type ChargeTransactionPayment = pallet_charge_transaction::ChargeTransactionPayment<Runtime>;
 
-/*fn get_signed_extra(from: <Runtime as frame_system::Config>::AccountId) -> SignedExtra {
-	(
-		frame_system::CheckSpecVersion::<Runtime>::new(),
-		frame_system::CheckGenesis::<Runtime>::new(),
-		frame_system::CheckEra::<Runtime>::from(Era::Immortal),
-		frame_system::CheckNonce::<Runtime>::from(frame_system::Pallet::<Runtime>::account_nonce(
-			from,
-		)),
-		frame_system::CheckWeight::<Runtime>::new(),
-		ChargeTransactionPayment::new(0),
-	)
-}*/
-
 #[derive(Default, Encode, Decode, Clone, TypeInfo)]
 pub struct SchedulerPreDispatch {
 	tip: Balance,
@@ -849,29 +836,12 @@
 	type Pre = SchedulerPreDispatch;
 
 	fn dispatch_call(
-		//signer: <T as frame_system::Config>::AccountId,
 		pre_dispatch: Self::Pre,
 		call: <T as pallet_unq_scheduler::Config>::Call,
 	) -> Result<
 		Result<PostDispatchInfo, DispatchErrorWithPostInfo<PostDispatchInfo>>,
 		TransactionValidityError,
 	> {
-		/*let dispatch_info = call.get_dispatch_info();
-
-		let extrinsic = fp_self_contained::CheckedExtrinsic::<
-			AccountId,
-			Call,
-			SignedExtra,
-			SelfContainedSignedInfo,
-		> {
-			signed: CheckedSignature::<AccountId, SignedExtra, SelfContainedSignedInfo>::Signed(
-				signer.clone().into(),
-				get_signed_extra(signer.clone().into()),
-			),
-			function: call.clone().into(),
-		};
-
-		extrinsic.apply::<Runtime>(&dispatch_info, 0)*/
 		let dispatch_info = call.get_dispatch_info();
 		let pre = (
 			pre_dispatch.tip,
modifiedtests/src/scheduler.test.tsdiffbeforeafterboth
--- a/tests/src/scheduler.test.ts
+++ b/tests/src/scheduler.test.ts
@@ -3,7 +3,7 @@
 // file 'LICENSE', which is part of this source code package.
 //
 
-import chai, { expect } from 'chai';
+import chai, {expect} from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 import privateKey from './substrate/privateKey';
 import {
@@ -27,8 +27,6 @@
   getTokenOwner,
   getGenericResult,
   scheduleTransferFundsPeriodicExpectSuccess,
-  setCollectionLimitsExpectSuccess,
-  getDetailedCollectionInfo,
   getFreeBalance,
   confirmSponsorshipByKeyExpectSuccess,
 } from './util/helpers';
@@ -142,51 +140,6 @@
       expect(await getTokenOwner(api, collectionId, tokenId)).to.be.deep.equal(normalizeAccountId(alice.address));
     });
   });
-
-  /*it.skip('Going bankrupt after sponsoring a scheduled transaction does not nullify the transaction', async () => {
-    await usingApi(async (api) => {
-      // Find two empty, unused accounts
-      const zeroBalance = await findUnusedAddress(api);
-      const zeroBalanceSponsor = await findUnusedAddress(api);
-
-      const collectionId = await createCollectionExpectSuccess();
-
-      // Grace these with money, enough to cover future transactions
-      const balanceTx = api.tx.balances.transfer(zeroBalance.address, 1n * UNIQUE);
-      await submitTransactionAsync(alice, balanceTx);
-
-      // Grace these with money, enough to cover future transactions
-      const balanceSponsorTx = api.tx.balances.transfer(zeroBalanceSponsor.address, 1n * UNIQUE);
-      await submitTransactionAsync(alice, balanceSponsorTx);
-
-      // Set a collection sponsor
-      await setCollectionSponsorExpectSuccess(collectionId, zeroBalanceSponsor.address);
-      await confirmSponsorshipExpectSuccess(collectionId);
-
-      // Add zeroBalance address to allow list
-      await enablePublicMintingExpectSuccess(alice, collectionId);
-      await addToAllowListExpectSuccess(alice, collectionId, zeroBalance.address);
-
-      // Mint a fresh NFT
-      const tokenId = await createItemExpectSuccess(zeroBalance, collectionId, 'NFT');
-
-      // Schedule transfer of the NFT a few blocks ahead
-      // const waitForBlocks = 4;
-      await scheduleTransferExpectSuccess(collectionId, tokenId, zeroBalance, alice, 1, 4);
-      //await waitAfterScheduleExpectSuccess(collectionId, tokenId, alice, 3);
-
-      // Get rid of the account's funds before the scheduled transaction takes place
-      const emptyBalanceSponsorTx = api.tx.balances.setBalance(zeroBalanceSponsor.address, 0, 0);
-      const sudoTx = api.tx.sudo.sudo(emptyBalanceSponsorTx as any);
-      const events = await submitTransactionAsync(alice, sudoTx);
-      expect(getGenericResult(events).success).to.be.true;
-
-      // Wait for a certain number of blocks, save for the ones that already happened while accepting the late transactions
-      await waitNewBlocks(4);
-
-      expect(await getTokenOwner(api, collectionId, tokenId)).to.be.deep.equal(normalizeAccountId(alice.address));
-    });
-  });*/
 
   it('Sponsor going bankrupt does not impact a scheduled transaction', async () => {
     const collectionId = await createCollectionExpectSuccess();