difftreelog
fix remove known xcm locations -- unneeded due to limited opened hrmp channels
in: master
5 files changed
pallets/configuration/src/benchmarking.rsdiffbeforeafterboth--- a/pallets/configuration/src/benchmarking.rs
+++ b/pallets/configuration/src/benchmarking.rs
@@ -19,8 +19,7 @@
use super::*;
use frame_benchmarking::benchmarks;
use frame_system::{EventRecord, RawOrigin};
-use frame_support::{assert_ok, BoundedVec, traits::Currency};
-use xcm::latest::MultiLocation;
+use frame_support::{assert_ok, traits::Currency};
fn assert_last_event<T: Config>(generic_event: <T as Config>::RuntimeEvent) {
let events = frame_system::Pallet::<T>::events();
@@ -46,14 +45,6 @@
}: {
assert_ok!(
<Pallet<T>>::set_min_gas_price_override(RawOrigin::Root.into(), Some(coeff))
- );
- }
-
- set_xcm_allowed_locations {
- let locations: BoundedVec<MultiLocation, T::MaxXcmAllowedLocations> = Default::default();
- }: {
- assert_ok!(
- <Pallet<T>>::set_xcm_allowed_locations(RawOrigin::Root.into(), Some(locations))
);
}
pallets/configuration/src/lib.rsdiffbeforeafterboth--- a/pallets/configuration/src/lib.rs
+++ b/pallets/configuration/src/lib.rs
@@ -43,11 +43,9 @@
use super::*;
use frame_support::{
traits::{Get, ReservableCurrency, Currency},
- pallet_prelude::{StorageValue, ValueQuery, DispatchResult, IsType, OptionQuery},
- BoundedVec, log,
+ pallet_prelude::{StorageValue, ValueQuery, DispatchResult, IsType}, log,
};
use frame_system::{pallet_prelude::OriginFor, ensure_root, Config as SystemConfig};
- use xcm::latest::MultiLocation;
pub use crate::weights::WeightInfo;
pub type BalanceOf<T> =
@@ -115,12 +113,6 @@
StorageValue<Value = u64, QueryKind = ValueQuery, OnEmpty = T::DefaultMinGasPrice>;
#[pallet::storage]
- pub type XcmAllowedLocationsOverride<T: Config> = StorageValue<
- Value = BoundedVec<xcm::v3::MultiLocation, T::MaxXcmAllowedLocations>,
- QueryKind = OptionQuery,
- >;
-
- #[pallet::storage]
pub type AppPromomotionConfigurationOverride<T: Config> =
StorageValue<Value = AppPromotionConfiguration<T::BlockNumber>, QueryKind = ValueQuery>;
@@ -174,17 +166,6 @@
} else {
<MinGasPriceOverride<T>>::kill();
}
- Ok(())
- }
-
- #[pallet::call_index(2)]
- #[pallet::weight(T::WeightInfo::set_xcm_allowed_locations())]
- pub fn set_xcm_allowed_locations(
- origin: OriginFor<T>,
- locations: Option<BoundedVec<MultiLocation, T::MaxXcmAllowedLocations>>,
- ) -> DispatchResult {
- ensure_root(origin)?;
- <XcmAllowedLocationsOverride<T>>::set(locations);
Ok(())
}
runtime/common/config/xcm/mod.rsdiffbeforeafterboth--- a/runtime/common/config/xcm/mod.rs
+++ b/runtime/common/config/xcm/mod.rs
@@ -148,38 +148,6 @@
}
}
-// Allow xcm exchange only with locations in list
-pub struct DenyExchangeWithUnknownLocation<T>(PhantomData<T>);
-impl<T: Get<Vec<MultiLocation>>> TryPass for DenyExchangeWithUnknownLocation<T> {
- fn try_pass<Call>(origin: &MultiLocation, message: &mut [Instruction<Call>]) -> Result<(), ()> {
- let allowed_locations = T::get();
-
- // Check if deposit or transfer belongs to allowed parachains
- let mut allowed = allowed_locations.contains(origin);
-
- message.iter().for_each(|inst| match inst {
- DepositReserveAsset { dest: dst, .. }
- | TransferReserveAsset { dest: dst, .. }
- | InitiateReserveWithdraw { reserve: dst, .. } => {
- allowed |= allowed_locations.contains(&dst);
- }
- // ? There are more instructions worth checking
- _ => {}
- });
-
- if allowed {
- return Ok(());
- }
-
- log::warn!(
- target: "xcm::barrier",
- "Unexpected deposit or transfer location"
- );
- // Deny
- Err(())
- }
-}
-
pub type Weigher = FixedWeightBounds<UnitWeightCost, RuntimeCall, MaxInstructions>;
pub struct XcmExecutorConfig<T>(PhantomData<T>);
runtime/quartz/src/xcm_barrier.rsdiffbeforeafterboth--- a/runtime/quartz/src/xcm_barrier.rs
+++ b/runtime/quartz/src/xcm_barrier.rs
@@ -15,23 +15,16 @@
// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.
use frame_support::{
- match_types, parameter_types,
- traits::{Get, Everything},
+ match_types,
+ traits::Everything,
};
-use sp_std::{vec, vec::Vec};
-use xcm::latest::{Junction::*, Junctions::*, MultiLocation};
+use xcm::latest::{Junctions::*, MultiLocation};
use xcm_builder::{
AllowKnownQueryResponses, AllowSubscriptionsFrom, TakeWeightCredit,
AllowTopLevelPaidExecutionFrom,
};
-use crate::{
- Runtime, ParachainInfo, PolkadotXcm,
- runtime_common::{
- config::xcm::{DenyThenTry, DenyExchangeWithUnknownLocation},
- xcm::OverridableAllowedLocations,
- },
-};
+use crate::PolkadotXcm;
match_types! {
pub type ParentOrSiblings: impl Contains<MultiLocation> = {
@@ -40,51 +33,11 @@
};
}
-parameter_types! {
- pub QuartzDefaultAllowedLocations: Vec<MultiLocation> = vec![
- // Self location
- MultiLocation {
- parents: 0,
- interior: Here,
- },
- // Parent location
- MultiLocation {
- parents: 1,
- interior: Here,
- },
- // Statemint/Statemint location
- MultiLocation {
- parents: 1,
- interior: X1(Parachain(1000)),
- },
- // Karura/Acala location
- MultiLocation {
- parents: 1,
- interior: X1(Parachain(2000)),
- },
- // Moonriver location
- MultiLocation {
- parents: 1,
- interior: X1(Parachain(2023)),
- },
- // Self parachain address
- MultiLocation {
- parents: 1,
- interior: X1(Parachain(ParachainInfo::get().into())),
- },
- ];
-}
-
-pub type Barrier = DenyThenTry<
- DenyExchangeWithUnknownLocation<
- OverridableAllowedLocations<Runtime, QuartzDefaultAllowedLocations>,
- >,
- (
- TakeWeightCredit,
- AllowTopLevelPaidExecutionFrom<Everything>,
- // Expected responses are OK.
- AllowKnownQueryResponses<PolkadotXcm>,
- // Subscriptions for version tracking are OK.
- AllowSubscriptionsFrom<ParentOrSiblings>,
- ),
->;
+pub type Barrier = (
+ TakeWeightCredit,
+ AllowTopLevelPaidExecutionFrom<Everything>,
+ // Expected responses are OK.
+ AllowKnownQueryResponses<PolkadotXcm>,
+ // Subscriptions for version tracking are OK.
+ AllowSubscriptionsFrom<ParentOrSiblings>,
+);
runtime/unique/src/xcm_barrier.rsdiffbeforeafterboth1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617use frame_support::{18 match_types, parameter_types,19 traits::{Get, Everything},20};21use sp_std::{vec, vec::Vec};22use xcm::latest::{Junction::*, Junctions::*, MultiLocation};23use xcm_builder::{24 AllowKnownQueryResponses, AllowSubscriptionsFrom, TakeWeightCredit,25 AllowTopLevelPaidExecutionFrom,26};2728use crate::{29 Runtime, ParachainInfo, PolkadotXcm,30 runtime_common::{31 config::xcm::{DenyThenTry, DenyExchangeWithUnknownLocation},32 xcm::OverridableAllowedLocations,33 },34};3536match_types! {37 pub type ParentOrSiblings: impl Contains<MultiLocation> = {38 MultiLocation { parents: 1, interior: Here } |39 MultiLocation { parents: 1, interior: X1(_) }40 };41}4243parameter_types! {44 pub UniqueDefaultAllowedLocations: Vec<MultiLocation> = vec![45 // Self location46 MultiLocation {47 parents: 0,48 interior: Here,49 },50 // Parent location51 MultiLocation {52 parents: 1,53 interior: Here,54 },55 // Statemint/Statemint location56 MultiLocation {57 parents: 1,58 interior: X1(Parachain(1000)),59 },60 // Karura/Acala location61 MultiLocation {62 parents: 1,63 interior: X1(Parachain(2000)),64 },65 // Moonbeam location66 MultiLocation {67 parents: 1,68 interior: X1(Parachain(2004)),69 },70 // Self parachain address71 MultiLocation {72 parents: 1,73 interior: X1(Parachain(ParachainInfo::get().into())),74 },75 ];76}7778pub type Barrier = DenyThenTry<79 DenyExchangeWithUnknownLocation<80 OverridableAllowedLocations<Runtime, UniqueDefaultAllowedLocations>,81 >,82 (83 TakeWeightCredit,84 AllowTopLevelPaidExecutionFrom<Everything>,85 // Expected responses are OK.86 AllowKnownQueryResponses<PolkadotXcm>,87 // Subscriptions for version tracking are OK.88 AllowSubscriptionsFrom<ParentOrSiblings>,89 ),90>;