git.delta.rocks / unique-network / refs/commits / 6adc689f67ef

difftreelog

Refactor admin tests

Max Andreev2022-11-30parent: #d7cd036.patch.diff
in: master
combine tests
remove Bob
add e2e test

2 files changed

modifiedtests/src/eth/collectionAdmin.test.tsdiffbeforeafterboth
before · tests/src/eth/collectionAdmin.test.ts
1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.3// Unique Network is free software: you can redistribute it and/or modify4// it under the terms of the GNU General Public License as published by5// the Free Software Foundation, either version 3 of the License, or6// (at your option) any later version.7//8// Unique Network is distributed in the hope that it will be useful,9// but WITHOUT ANY WARRANTY; without even the implied warranty of10// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the11// GNU General Public License for more details.1213// You should have received a copy of the GNU General Public License14// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1516import {IKeyringPair} from '@polkadot/types/types';17import {expect} from 'chai';18import {IEthCrossAccountId} from '../util/playgrounds/types';19import {usingEthPlaygrounds, itEth} from './util';20import {EthUniqueHelper} from './util/playgrounds/unique.dev';2122async function recordEthFee(helper: EthUniqueHelper, userAddress: string, call: () => Promise<any>) {23  const before = await helper.balance.getSubstrate(helper.address.ethToSubstrate(userAddress));24  await call();25  await helper.wait.newBlocks(1);26  const after = await helper.balance.getSubstrate(helper.address.ethToSubstrate(userAddress));2728  expect(after < before).to.be.true;2930  return before - after;31}3233describe('Add collection admins', () => {34  let donor: IKeyringPair;3536  before(async function() {37    await usingEthPlaygrounds(async (_helper, privateKey) => {38      donor = await privateKey({filename: __filename});39    });40  });4142  // Soft-deprecated43  itEth('Add admin by owner', async ({helper}) => {44    const owner = await helper.eth.createAccountWithBalance(donor);45    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');46    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);4748    const newAdmin = helper.eth.createAccount();4950    await collectionEvm.methods.addCollectionAdmin(newAdmin).send();51    const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);52    expect(adminList[0].asEthereum.toString().toLocaleLowerCase())53      .to.be.eq(newAdmin.toLocaleLowerCase());54  });5556  itEth('Add cross account admin by owner', async ({helper, privateKey}) => {57    const owner = await helper.eth.createAccountWithBalance(donor);58        59    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');60    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);61    62    const newAdmin = await privateKey('//Bob');63    const newAdminCross = helper.ethCrossAccount.fromKeyringPair(newAdmin);64    await collectionEvm.methods.addCollectionAdminCross(newAdminCross).send();6566    const adminList = await helper.collection.getAdmins(collectionId);67    expect(adminList).to.be.like([{Substrate: newAdmin.address}]);68  });6970  itEth('Check adminlist', async ({helper, privateKey}) => {71    const owner = await helper.eth.createAccountWithBalance(donor);72        73    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');74    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);7576    const admin1 = helper.eth.createAccount();77    const admin2 = await privateKey('admin');78    const admin2Cross = helper.ethCrossAccount.fromKeyringPair(admin2);79    80    // Soft-deprecated81    await collectionEvm.methods.addCollectionAdmin(admin1).send();82    await collectionEvm.methods.addCollectionAdminCross(admin2Cross).send();8384    const adminListRpc = await helper.collection.getAdmins(collectionId);85    let adminListEth = await collectionEvm.methods.collectionAdmins().call();86    adminListEth = adminListEth.map((element: IEthCrossAccountId) => {87      return helper.address.convertCrossAccountFromEthCrossAcoount(element);88    });89    expect(adminListRpc).to.be.like(adminListEth);90  });9192  // Soft-deprecated93  itEth('Verify owner or admin', async ({helper}) => {94    const owner = await helper.eth.createAccountWithBalance(donor);95    const {collectionAddress} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');9697    const newAdmin = helper.eth.createAccount();98    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);99  100    expect(await collectionEvm.methods.isOwnerOrAdmin(newAdmin).call()).to.be.false;101    await collectionEvm.methods.addCollectionAdmin(newAdmin).send();102    expect(await collectionEvm.methods.isOwnerOrAdmin(newAdmin).call()).to.be.true;103  });104105  itEth('Verify owner or admin cross', async ({helper, privateKey}) => {106    const owner = await helper.eth.createAccountWithBalance(donor);107    const {collectionAddress} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');108109    const newAdmin = await privateKey('admin');110    const newAdminCross = helper.ethCrossAccount.fromKeyringPair(newAdmin);111    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);112  113    expect(await collectionEvm.methods.isOwnerOrAdminCross(newAdminCross).call()).to.be.false;114    await collectionEvm.methods.addCollectionAdminCross(newAdminCross).send();115    expect(await collectionEvm.methods.isOwnerOrAdminCross(newAdminCross).call()).to.be.true;116  });117118  // Soft-deprecated119  itEth('(!negative tests!) Add admin by ADMIN is not allowed', async ({helper}) => {120    const owner = await helper.eth.createAccountWithBalance(donor);121    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');122123    const admin = await helper.eth.createAccountWithBalance(donor);124    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);125    await collectionEvm.methods.addCollectionAdmin(admin).send();126127    const user = helper.eth.createAccount();128    await expect(collectionEvm.methods.addCollectionAdmin(user).call({from: admin}))129      .to.be.rejectedWith('NoPermission');130131    const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);132    expect(adminList.length).to.be.eq(1);133    expect(adminList[0].asEthereum.toString().toLocaleLowerCase())134      .to.be.eq(admin.toLocaleLowerCase());135  });136137  // Soft-deprecated138  itEth('(!negative tests!) Add admin by USER is not allowed', async ({helper}) => {139    const owner = await helper.eth.createAccountWithBalance(donor);140    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');141142    const notAdmin = await helper.eth.createAccountWithBalance(donor);143    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);144145    const user = helper.eth.createAccount();146    await expect(collectionEvm.methods.addCollectionAdmin(user).call({from: notAdmin}))147      .to.be.rejectedWith('NoPermission');148149    const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);150    expect(adminList.length).to.be.eq(0);151  });152153  itEth('(!negative tests!) Add [cross] admin by ADMIN is not allowed', async ({helper}) => {154    const owner = await helper.eth.createAccountWithBalance(donor);155    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');156157    const [admin] = await helper.arrange.createAccounts([10n], donor);158    const adminCross = helper.ethCrossAccount.fromKeyringPair(admin);159    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);160    await collectionEvm.methods.addCollectionAdminCross(adminCross).send();161162    const [notAdmin] = await helper.arrange.createAccounts([10n], donor);163    const notAdminCross = helper.ethCrossAccount.fromKeyringPair(notAdmin);164    await expect(collectionEvm.methods.addCollectionAdminCross(notAdminCross).call({from: adminCross.eth}))165      .to.be.rejectedWith('NoPermission');166167    const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);168    expect(adminList.length).to.be.eq(1);169    170    const admin0Cross = helper.ethCrossAccount.fromKeyringPair(adminList[0]);171    expect(admin0Cross.eth.toLocaleLowerCase())172      .to.be.eq(adminCross.eth.toLocaleLowerCase());173  });174175  itEth('(!negative tests!) Add [cross] admin by USER is not allowed', async ({helper}) => {176    const owner = await helper.eth.createAccountWithBalance(donor);177    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');178179    const notAdmin0 = await helper.eth.createAccountWithBalance(donor);180    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);181    const [notAdmin1] = await helper.arrange.createAccounts([10n], donor);182    const notAdmin1Cross = helper.ethCrossAccount.fromKeyringPair(notAdmin1);183    await expect(collectionEvm.methods.addCollectionAdminCross(notAdmin1Cross).call({from: notAdmin0}))184      .to.be.rejectedWith('NoPermission');185186    const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);187    expect(adminList.length).to.be.eq(0);188  });189});190191describe('Remove collection admins', () => {192  let donor: IKeyringPair;193194  before(async function() {195    await usingEthPlaygrounds(async (_helper, privateKey) => {196      donor = await privateKey({filename: __filename});197    });198  });199200  // Soft-deprecated201  itEth('Remove admin by owner', async ({helper}) => {202    const owner = await helper.eth.createAccountWithBalance(donor);203    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');204205    const newAdmin = helper.eth.createAccount();206    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);207    await collectionEvm.methods.addCollectionAdmin(newAdmin).send();208209    {210      const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);211      expect(adminList.length).to.be.eq(1);212      expect(adminList[0].asEthereum.toString().toLocaleLowerCase())213        .to.be.eq(newAdmin.toLocaleLowerCase());214    }215216    await collectionEvm.methods.removeCollectionAdmin(newAdmin).send();217    const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);218    expect(adminList.length).to.be.eq(0);219  });220221  itEth('Remove [cross] admin by owner', async ({helper}) => {222    const owner = await helper.eth.createAccountWithBalance(donor);223    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');224225    const [newAdmin] = await helper.arrange.createAccounts([10n], donor);226    const newAdminCross = helper.ethCrossAccount.fromKeyringPair(newAdmin);227    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);228    await collectionEvm.methods.addCollectionAdminCross(newAdminCross).send();229    {230      const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);231      expect(adminList[0].asSubstrate.toString().toLocaleLowerCase())232        .to.be.eq(newAdmin.address.toLocaleLowerCase());233    }234235    await collectionEvm.methods.removeCollectionAdminCross(newAdminCross).send();236    const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);237    expect(adminList.length).to.be.eq(0);238  });239240  // Soft-deprecated241  itEth('(!negative tests!) Remove admin by ADMIN is not allowed', async ({helper}) => {242    const owner = await helper.eth.createAccountWithBalance(donor);243    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');244245    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);246247    const admin0 = await helper.eth.createAccountWithBalance(donor);248    await collectionEvm.methods.addCollectionAdmin(admin0).send();249    const admin1 = await helper.eth.createAccountWithBalance(donor);250    await collectionEvm.methods.addCollectionAdmin(admin1).send();251252    await expect(collectionEvm.methods.removeCollectionAdmin(admin1).call({from: admin0}))253      .to.be.rejectedWith('NoPermission');254    {255      const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);256      expect(adminList.length).to.be.eq(2);257      expect(adminList.toString().toLocaleLowerCase())258        .to.be.deep.contains(admin0.toLocaleLowerCase())259        .to.be.deep.contains(admin1.toLocaleLowerCase());260    }261  });262263  // Soft-deprecated264  itEth('(!negative tests!) Remove admin by USER is not allowed', async ({helper}) => {265    const owner = await helper.eth.createAccountWithBalance(donor);266    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');267268    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);269270    const admin = await helper.eth.createAccountWithBalance(donor);271    await collectionEvm.methods.addCollectionAdmin(admin).send();272    const notAdmin = helper.eth.createAccount();273274    await expect(collectionEvm.methods.removeCollectionAdmin(admin).call({from: notAdmin}))275      .to.be.rejectedWith('NoPermission');276    {277      const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);278      expect(adminList[0].asEthereum.toString().toLocaleLowerCase())279        .to.be.eq(admin.toLocaleLowerCase());280      expect(adminList.length).to.be.eq(1);281    }282  });283284  itEth('(!negative tests!) Remove [cross] admin by ADMIN is not allowed', async ({helper}) => {285    const owner = await helper.eth.createAccountWithBalance(donor);286    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');287288    const [admin1] = await helper.arrange.createAccounts([10n], donor);289    const admin1Cross = helper.ethCrossAccount.fromKeyringPair(admin1);290    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);291    await collectionEvm.methods.addCollectionAdminCross(admin1Cross).send();292    293    const [admin2] = await helper.arrange.createAccounts([10n], donor);294    const admin2Cross = helper.ethCrossAccount.fromKeyringPair(admin2);295    await collectionEvm.methods.addCollectionAdminCross(admin2Cross).send();296297    await expect(collectionEvm.methods.removeCollectionAdminCross(admin1Cross).call({from: admin2Cross.eth}))298      .to.be.rejectedWith('NoPermission');299300    const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);301    expect(adminList.length).to.be.eq(2);302    expect(adminList.toString().toLocaleLowerCase())303      .to.be.deep.contains(admin1.address.toLocaleLowerCase())304      .to.be.deep.contains(admin2.address.toLocaleLowerCase());305  });306307  itEth('(!negative tests!) Remove [cross] admin by USER is not allowed', async ({helper}) => {308    const owner = await helper.eth.createAccountWithBalance(donor);309    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');310311    const [adminSub] = await helper.arrange.createAccounts([10n], donor);312    const adminSubCross = helper.ethCrossAccount.fromKeyringPair(adminSub);313    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);314    await collectionEvm.methods.addCollectionAdminCross(adminSubCross).send();315    const notAdminEth = await helper.eth.createAccountWithBalance(donor);316317    await expect(collectionEvm.methods.removeCollectionAdminCross(adminSubCross).call({from: notAdminEth}))318      .to.be.rejectedWith('NoPermission');319320    const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);321    expect(adminList.length).to.be.eq(1);322    expect(adminList[0].asSubstrate.toString().toLocaleLowerCase())323      .to.be.eq(adminSub.address.toLocaleLowerCase());324  });325});326327// Soft-deprecated328describe('Change owner tests', () => {329  let donor: IKeyringPair;330331  before(async function() {332    await usingEthPlaygrounds(async (_helper, privateKey) => {333      donor = await privateKey({filename: __filename});334    });335  });336337  itEth('Change owner', async ({helper}) => {338    const owner = await helper.eth.createAccountWithBalance(donor);339    const newOwner = await helper.eth.createAccountWithBalance(donor);340    const {collectionAddress} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');341    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);342343    await collectionEvm.methods.changeCollectionOwner(newOwner).send();344345    expect(await collectionEvm.methods.isOwnerOrAdmin(owner).call()).to.be.false;346    expect(await collectionEvm.methods.isOwnerOrAdmin(newOwner).call()).to.be.true;347  });348349  itEth('change owner call fee', async ({helper}) => {350    const owner = await helper.eth.createAccountWithBalance(donor);351    const newOwner = await helper.eth.createAccountWithBalance(donor);352    const {collectionAddress} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');353    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);354    const cost = await recordEthFee(helper, owner, () => collectionEvm.methods.changeCollectionOwner(newOwner).send());355    expect(cost < BigInt(0.2 * Number(helper.balance.getOneTokenNominal())));356    expect(cost > 0);357  });358359  itEth('(!negative tests!) call setOwner by non owner', async ({helper}) => {360    const owner = await helper.eth.createAccountWithBalance(donor);361    const newOwner = await helper.eth.createAccountWithBalance(donor);362    const {collectionAddress} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');363    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);364365    await expect(collectionEvm.methods.changeCollectionOwner(newOwner).send({from: newOwner})).to.be.rejected;366    expect(await collectionEvm.methods.isOwnerOrAdmin(newOwner).call()).to.be.false;367  });368});369370describe('Change substrate owner tests', () => {371  let donor: IKeyringPair;372373  before(async function() {374    await usingEthPlaygrounds(async (_helper, privateKey) => {375      donor = await privateKey({filename: __filename});376    });377  });378379  itEth('Change owner [cross]', async ({helper}) => {380    const owner = await helper.eth.createAccountWithBalance(donor);381    const [newOwner] = await helper.arrange.createAccounts([10n], donor);382    const newOwnerCross = helper.ethCrossAccount.fromKeyringPair(newOwner);383    const {collectionAddress} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');384    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);385386    expect(await collectionEvm.methods.isOwnerOrAdminCross(newOwnerCross).call()).to.be.false;387388    await collectionEvm.methods.changeCollectionOwnerCross(newOwnerCross).send();389390    expect(await collectionEvm.methods.isOwnerOrAdminCross(newOwnerCross).call()).to.be.true;391  });392393  itEth.skip('change owner call fee', async ({helper}) => {394    const owner = await helper.eth.createAccountWithBalance(donor);395    const [newOwner] = await helper.arrange.createAccounts([10n], donor);396    const {collectionAddress} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');397    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);398399    const cost = await recordEthFee(helper, owner, () => collectionEvm.methods.setOwnerSubstrate(newOwner.addressRaw).send());400    expect(cost < BigInt(0.2 * Number(helper.balance.getOneTokenNominal())));401    expect(cost > 0);402  });403404  itEth('(!negative tests!) call setOwner by non owner [cross]', async ({helper}) => {405    const owner = await helper.eth.createAccountWithBalance(donor);406    const otherReceiver = await helper.eth.createAccountWithBalance(donor);407    const [newOwner] = await helper.arrange.createAccounts([10n], donor);408    const newOwnerCross = helper.ethCrossAccount.fromKeyringPair(newOwner);409    const {collectionAddress} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');410    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);411412    await expect(collectionEvm.methods.changeCollectionOwnerCross(newOwnerCross).send({from: otherReceiver})).to.be.rejected;413    expect(await collectionEvm.methods.isOwnerOrAdminCross(newOwnerCross).call()).to.be.false;414  });415});
after · tests/src/eth/collectionAdmin.test.ts
1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.3// Unique Network is free software: you can redistribute it and/or modify4// it under the terms of the GNU General Public License as published by5// the Free Software Foundation, either version 3 of the License, or6// (at your option) any later version.7//8// Unique Network is distributed in the hope that it will be useful,9// but WITHOUT ANY WARRANTY; without even the implied warranty of10// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the11// GNU General Public License for more details.1213// You should have received a copy of the GNU General Public License14// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1516import {IKeyringPair} from '@polkadot/types/types';17import {expect} from 'chai';18import {IEthCrossAccountId} from '../util/playgrounds/types';19import {usingEthPlaygrounds, itEth} from './util';20import {EthUniqueHelper} from './util/playgrounds/unique.dev';2122async function recordEthFee(helper: EthUniqueHelper, userAddress: string, call: () => Promise<any>) {23  const before = await helper.balance.getSubstrate(helper.address.ethToSubstrate(userAddress));24  await call();25  await helper.wait.newBlocks(1);26  const after = await helper.balance.getSubstrate(helper.address.ethToSubstrate(userAddress));2728  expect(after < before).to.be.true;2930  return before - after;31}3233describe('Add collection admins', () => {34  let donor: IKeyringPair;3536  before(async function() {37    await usingEthPlaygrounds(async (_helper, privateKey) => {38      donor = await privateKey({filename: __filename});39    });40  });4142  itEth('can add account admin by owner', async ({helper, privateKey}) => {43    // arrange44    const owner = await helper.eth.createAccountWithBalance(donor);45    const adminSub = await privateKey('//admin2');46    const adminEth = helper.eth.createAccount().toLowerCase();4748    const adminDeprecated = helper.eth.createAccount().toLowerCase();49    const adminCrossSub = helper.ethCrossAccount.fromKeyringPair(adminSub);50    const adminCrossEth = helper.ethCrossAccount.fromAddress(adminEth);51        52    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');53    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);5455    // Soft-deprecated: can addCollectionAdmin 56    await collectionEvm.methods.addCollectionAdmin(adminDeprecated).send();57    // Can addCollectionAdminCross for substrate and ethereum address58    await collectionEvm.methods.addCollectionAdminCross(adminCrossSub).send();59    await collectionEvm.methods.addCollectionAdminCross(adminCrossEth).send();6061    // 1. Expect api.rpc.unique.adminlist returns admins:62    const adminListRpc = await helper.collection.getAdmins(collectionId);63    expect(adminListRpc).to.has.length(3);64    expect(adminListRpc).to.be.deep.contain.members([{Substrate: adminSub.address}, {Ethereum: adminEth}, {Ethereum: adminDeprecated}]);6566    // 2. Expect methods.collectionAdmins == api.rpc.unique.adminlist67    let adminListEth = await collectionEvm.methods.collectionAdmins().call();68    adminListEth = adminListEth.map((element: IEthCrossAccountId) => {69      return helper.address.convertCrossAccountFromEthCrossAccount(element);70    });71    expect(adminListRpc).to.be.like(adminListEth);72  });7374  itEth('cross account admin can mint', async ({helper}) => {75    // arrange: create collection and accounts76    const owner = await helper.eth.createAccountWithBalance(donor);77    const {collectionAddress, collectionId} = await helper.eth.createERC721MetadataCompatibleNFTCollection(owner, 'Mint collection', 'a', 'b', 'uri');78    const adminEth = (await helper.eth.createAccountWithBalance(donor)).toLowerCase();79    const adminCrossEth = helper.ethCrossAccount.fromAddress(adminEth);80    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);81    82    // cannot mint while not admin83    await expect(collectionEvm.methods.mint(owner).call({from: adminEth})).to.be.rejectedWith('PublicMintingNotAllowed');84    85    // admin can mint token:86    await collectionEvm.methods.addCollectionAdminCross(adminCrossEth).send();87    const result = await collectionEvm.methods.mint(owner).call({from: adminEth});8889    // TODO: Why fail90    expect(await helper.collection.getLastTokenId(collectionId)).to.eq(1);91  });9293  itEth('cannot add invalid cross account admin', async ({helper}) => {94    const owner = await helper.eth.createAccountWithBalance(donor);95    const [admin] = await helper.arrange.createAccounts([100n, 100n], donor);9697    const {collectionAddress} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');98    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);99100    const adminCross = {101      eth: helper.address.substrateToEth(admin.address),102      sub: admin.addressRaw,103    };104    await expect(collectionEvm.methods.addCollectionAdminCross(adminCross).send()).to.be.rejected;105  });106107  itEth('can verify owner with methods.isOwnerOrAdmin[Cross]', async ({helper, privateKey}) => {108    const owner = await helper.eth.createAccountWithBalance(donor);109    const {collectionAddress} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');110111    const adminDeprecated = helper.eth.createAccount();112    const admin1Cross = helper.ethCrossAccount.fromKeyringPair(await privateKey('admin'));113    const admin2Cross = helper.ethCrossAccount.fromAddress(helper.address.substrateToEth((await privateKey('admin3')).address));114    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);115  116    // Soft-deprecated:117    expect(await collectionEvm.methods.isOwnerOrAdmin(adminDeprecated).call()).to.be.false;118    expect(await collectionEvm.methods.isOwnerOrAdminCross(admin1Cross).call()).to.be.false;119    expect(await collectionEvm.methods.isOwnerOrAdminCross(admin2Cross).call()).to.be.false;120121    await collectionEvm.methods.addCollectionAdmin(adminDeprecated).send();122    await collectionEvm.methods.addCollectionAdminCross(admin1Cross).send();123    await collectionEvm.methods.addCollectionAdminCross(admin2Cross).send();124125    // Soft-deprecated: isOwnerOrAdmin returns true126    expect(await collectionEvm.methods.isOwnerOrAdmin(adminDeprecated).call()).to.be.true;127    // Expect isOwnerOrAdminCross return true128    expect(await collectionEvm.methods.isOwnerOrAdminCross(admin1Cross).call()).to.be.true;129    expect(await collectionEvm.methods.isOwnerOrAdminCross(admin2Cross).call()).to.be.true;130  });131132  // Soft-deprecated133  itEth('(!negative tests!) Add admin by ADMIN is not allowed', async ({helper}) => {134    const owner = await helper.eth.createAccountWithBalance(donor);135    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');136137    const admin = await helper.eth.createAccountWithBalance(donor);138    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);139    await collectionEvm.methods.addCollectionAdmin(admin).send();140141    const user = helper.eth.createAccount();142    await expect(collectionEvm.methods.addCollectionAdmin(user).call({from: admin}))143      .to.be.rejectedWith('NoPermission');144145    const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);146    expect(adminList.length).to.be.eq(1);147    expect(adminList[0].asEthereum.toString().toLocaleLowerCase())148      .to.be.eq(admin.toLocaleLowerCase());149  });150151  // Soft-deprecated152  itEth('(!negative tests!) Add admin by USER is not allowed', async ({helper}) => {153    const owner = await helper.eth.createAccountWithBalance(donor);154    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');155156    const notAdmin = await helper.eth.createAccountWithBalance(donor);157    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);158159    const user = helper.eth.createAccount();160    await expect(collectionEvm.methods.addCollectionAdmin(user).call({from: notAdmin}))161      .to.be.rejectedWith('NoPermission');162163    const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);164    expect(adminList.length).to.be.eq(0);165  });166167  itEth('(!negative tests!) Add [cross] admin by ADMIN is not allowed', async ({helper}) => {168    const owner = await helper.eth.createAccountWithBalance(donor);169    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');170171    const [admin, notAdmin] = await helper.arrange.createAccounts([10n, 10n], donor);172    const adminCross = helper.ethCrossAccount.fromKeyringPair(admin);173    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);174    await collectionEvm.methods.addCollectionAdminCross(adminCross).send();175176    const notAdminCross = helper.ethCrossAccount.fromKeyringPair(notAdmin);177    await expect(collectionEvm.methods.addCollectionAdminCross(notAdminCross).call({from: adminCross.eth}))178      .to.be.rejectedWith('NoPermission');179180    const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);181    expect(adminList.length).to.be.eq(1);182    183    const admin0Cross = helper.ethCrossAccount.fromKeyringPair(adminList[0]);184    expect(admin0Cross.eth.toLocaleLowerCase())185      .to.be.eq(adminCross.eth.toLocaleLowerCase());186  });187188  itEth('(!negative tests!) Add [cross] admin by USER is not allowed', async ({helper}) => {189    const owner = await helper.eth.createAccountWithBalance(donor);190    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');191192    const notAdmin0 = await helper.eth.createAccountWithBalance(donor);193    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);194    const [notAdmin1] = await helper.arrange.createAccounts([10n], donor);195    const notAdmin1Cross = helper.ethCrossAccount.fromKeyringPair(notAdmin1);196    await expect(collectionEvm.methods.addCollectionAdminCross(notAdmin1Cross).call({from: notAdmin0}))197      .to.be.rejectedWith('NoPermission');198199    const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);200    expect(adminList.length).to.be.eq(0);201  });202});203204describe('Remove collection admins', () => {205  let donor: IKeyringPair;206207  before(async function() {208    await usingEthPlaygrounds(async (_helper, privateKey) => {209      donor = await privateKey({filename: __filename});210    });211  });212213  // Soft-deprecated214  itEth('Remove admin by owner', async ({helper}) => {215    const owner = await helper.eth.createAccountWithBalance(donor);216    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');217218    const newAdmin = helper.eth.createAccount();219    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);220    await collectionEvm.methods.addCollectionAdmin(newAdmin).send();221222    {223      const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);224      expect(adminList.length).to.be.eq(1);225      expect(adminList[0].asEthereum.toString().toLocaleLowerCase())226        .to.be.eq(newAdmin.toLocaleLowerCase());227    }228229    await collectionEvm.methods.removeCollectionAdmin(newAdmin).send();230    const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);231    expect(adminList.length).to.be.eq(0);232  });233234  itEth('Remove [cross] admin by owner', async ({helper}) => {235    const owner = await helper.eth.createAccountWithBalance(donor);236    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');237238    const [newAdmin] = await helper.arrange.createAccounts([10n], donor);239    const newAdminCross = helper.ethCrossAccount.fromKeyringPair(newAdmin);240    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);241    await collectionEvm.methods.addCollectionAdminCross(newAdminCross).send();242    {243      const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);244      expect(adminList[0].asSubstrate.toString().toLocaleLowerCase())245        .to.be.eq(newAdmin.address.toLocaleLowerCase());246    }247248    await collectionEvm.methods.removeCollectionAdminCross(newAdminCross).send();249    const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);250    expect(adminList.length).to.be.eq(0);251  });252253  // Soft-deprecated254  itEth('(!negative tests!) Remove admin by ADMIN is not allowed', async ({helper}) => {255    const owner = await helper.eth.createAccountWithBalance(donor);256    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');257258    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);259260    const admin0 = await helper.eth.createAccountWithBalance(donor);261    await collectionEvm.methods.addCollectionAdmin(admin0).send();262    const admin1 = await helper.eth.createAccountWithBalance(donor);263    await collectionEvm.methods.addCollectionAdmin(admin1).send();264265    await expect(collectionEvm.methods.removeCollectionAdmin(admin1).call({from: admin0}))266      .to.be.rejectedWith('NoPermission');267    {268      const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);269      expect(adminList.length).to.be.eq(2);270      expect(adminList.toString().toLocaleLowerCase())271        .to.be.deep.contains(admin0.toLocaleLowerCase())272        .to.be.deep.contains(admin1.toLocaleLowerCase());273    }274  });275276  // Soft-deprecated277  itEth('(!negative tests!) Remove admin by USER is not allowed', async ({helper}) => {278    const owner = await helper.eth.createAccountWithBalance(donor);279    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');280281    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);282283    const admin = await helper.eth.createAccountWithBalance(donor);284    await collectionEvm.methods.addCollectionAdmin(admin).send();285    const notAdmin = helper.eth.createAccount();286287    await expect(collectionEvm.methods.removeCollectionAdmin(admin).call({from: notAdmin}))288      .to.be.rejectedWith('NoPermission');289    {290      const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);291      expect(adminList[0].asEthereum.toString().toLocaleLowerCase())292        .to.be.eq(admin.toLocaleLowerCase());293      expect(adminList.length).to.be.eq(1);294    }295  });296297  itEth('(!negative tests!) Remove [cross] admin by ADMIN is not allowed', async ({helper}) => {298    const owner = await helper.eth.createAccountWithBalance(donor);299    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');300301    const [admin1] = await helper.arrange.createAccounts([10n], donor);302    const admin1Cross = helper.ethCrossAccount.fromKeyringPair(admin1);303    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);304    await collectionEvm.methods.addCollectionAdminCross(admin1Cross).send();305    306    const [admin2] = await helper.arrange.createAccounts([10n], donor);307    const admin2Cross = helper.ethCrossAccount.fromKeyringPair(admin2);308    await collectionEvm.methods.addCollectionAdminCross(admin2Cross).send();309310    await expect(collectionEvm.methods.removeCollectionAdminCross(admin1Cross).call({from: admin2Cross.eth}))311      .to.be.rejectedWith('NoPermission');312313    const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);314    expect(adminList.length).to.be.eq(2);315    expect(adminList.toString().toLocaleLowerCase())316      .to.be.deep.contains(admin1.address.toLocaleLowerCase())317      .to.be.deep.contains(admin2.address.toLocaleLowerCase());318  });319320  itEth('(!negative tests!) Remove [cross] admin by USER is not allowed', async ({helper}) => {321    const owner = await helper.eth.createAccountWithBalance(donor);322    const {collectionAddress, collectionId} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');323324    const [adminSub] = await helper.arrange.createAccounts([10n], donor);325    const adminSubCross = helper.ethCrossAccount.fromKeyringPair(adminSub);326    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);327    await collectionEvm.methods.addCollectionAdminCross(adminSubCross).send();328    const notAdminEth = await helper.eth.createAccountWithBalance(donor);329330    await expect(collectionEvm.methods.removeCollectionAdminCross(adminSubCross).call({from: notAdminEth}))331      .to.be.rejectedWith('NoPermission');332333    const adminList = await helper.callRpc('api.rpc.unique.adminlist', [collectionId]);334    expect(adminList.length).to.be.eq(1);335    expect(adminList[0].asSubstrate.toString().toLocaleLowerCase())336      .to.be.eq(adminSub.address.toLocaleLowerCase());337  });338});339340// Soft-deprecated341describe('Change owner tests', () => {342  let donor: IKeyringPair;343344  before(async function() {345    await usingEthPlaygrounds(async (_helper, privateKey) => {346      donor = await privateKey({filename: __filename});347    });348  });349350  itEth('Change owner', async ({helper}) => {351    const owner = await helper.eth.createAccountWithBalance(donor);352    const newOwner = await helper.eth.createAccountWithBalance(donor);353    const {collectionAddress} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');354    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);355356    await collectionEvm.methods.changeCollectionOwner(newOwner).send();357358    expect(await collectionEvm.methods.isOwnerOrAdmin(owner).call()).to.be.false;359    expect(await collectionEvm.methods.isOwnerOrAdmin(newOwner).call()).to.be.true;360  });361362  itEth('change owner call fee', async ({helper}) => {363    const owner = await helper.eth.createAccountWithBalance(donor);364    const newOwner = await helper.eth.createAccountWithBalance(donor);365    const {collectionAddress} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');366    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);367    const cost = await recordEthFee(helper, owner, () => collectionEvm.methods.changeCollectionOwner(newOwner).send());368    expect(cost < BigInt(0.2 * Number(helper.balance.getOneTokenNominal())));369    expect(cost > 0);370  });371372  itEth('(!negative tests!) call setOwner by non owner', async ({helper}) => {373    const owner = await helper.eth.createAccountWithBalance(donor);374    const newOwner = await helper.eth.createAccountWithBalance(donor);375    const {collectionAddress} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');376    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner, true);377378    await expect(collectionEvm.methods.changeCollectionOwner(newOwner).send({from: newOwner})).to.be.rejected;379    expect(await collectionEvm.methods.isOwnerOrAdmin(newOwner).call()).to.be.false;380  });381});382383describe('Change substrate owner tests', () => {384  let donor: IKeyringPair;385386  before(async function() {387    await usingEthPlaygrounds(async (_helper, privateKey) => {388      donor = await privateKey({filename: __filename});389    });390  });391392  itEth('Change owner [cross]', async ({helper}) => {393    const owner = await helper.eth.createAccountWithBalance(donor);394    const [newOwner] = await helper.arrange.createAccounts([10n], donor);395    const newOwnerCross = helper.ethCrossAccount.fromKeyringPair(newOwner);396    const {collectionAddress} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');397    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);398399    expect(await collectionEvm.methods.isOwnerOrAdminCross(newOwnerCross).call()).to.be.false;400401    await collectionEvm.methods.changeCollectionOwnerCross(newOwnerCross).send();402403    expect(await collectionEvm.methods.isOwnerOrAdminCross(newOwnerCross).call()).to.be.true;404  });405406  itEth.skip('change owner call fee', async ({helper}) => {407    const owner = await helper.eth.createAccountWithBalance(donor);408    const [newOwner] = await helper.arrange.createAccounts([10n], donor);409    const {collectionAddress} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');410    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);411412    const cost = await recordEthFee(helper, owner, () => collectionEvm.methods.setOwnerSubstrate(newOwner.addressRaw).send());413    expect(cost < BigInt(0.2 * Number(helper.balance.getOneTokenNominal())));414    expect(cost > 0);415  });416417  itEth('(!negative tests!) call setOwner by non owner [cross]', async ({helper}) => {418    const owner = await helper.eth.createAccountWithBalance(donor);419    const otherReceiver = await helper.eth.createAccountWithBalance(donor);420    const [newOwner] = await helper.arrange.createAccounts([10n], donor);421    const newOwnerCross = helper.ethCrossAccount.fromKeyringPair(newOwner);422    const {collectionAddress} = await helper.eth.createNFTCollection(owner, 'A', 'B', 'C');423    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'nft', owner);424425    await expect(collectionEvm.methods.changeCollectionOwnerCross(newOwnerCross).send({from: otherReceiver})).to.be.rejected;426    expect(await collectionEvm.methods.isOwnerOrAdminCross(newOwnerCross).call()).to.be.false;427  });428});
modifiedtests/src/util/playgrounds/unique.tsdiffbeforeafterboth
--- a/tests/src/util/playgrounds/unique.ts
+++ b/tests/src/util/playgrounds/unique.ts
@@ -2429,7 +2429,7 @@
    * @param ethCrossAccount etherium cross account
    * @returns substrate cross account id
    */
-  convertCrossAccountFromEthCrossAcoount(ethCrossAccount: IEthCrossAccountId): ICrossAccountId {
+  convertCrossAccountFromEthCrossAccount(ethCrossAccount: IEthCrossAccountId): ICrossAccountId {
     if (ethCrossAccount.sub === '0') {
       return {Ethereum: ethCrossAccount.eth.toLocaleLowerCase()};
     }