difftreelog
CORE-302 Refactor collection for eth
in: master
20 files changed
Cargo.lockdiffbeforeafterboth--- a/Cargo.lock
+++ b/Cargo.lock
@@ -5467,9 +5467,9 @@
[[package]]
name = "once_cell"
-version = "1.11.0"
+version = "1.12.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "7b10983b38c53aebdf33f542c6275b0f58a238129d00c4ae0e6fb59738d783ca"
+checksum = "7709cef83f0c1f58f666e746a08b21e0085f7440fa6a29cc194d68aac97a4225"
[[package]]
name = "opal-runtime"
@@ -6830,7 +6830,6 @@
"parity-scale-codec 3.1.2",
"scale-info",
"serde",
- "serde-json-core",
"sp-core",
"sp-io",
"sp-runtime",
@@ -10735,16 +10734,6 @@
]
[[package]]
-name = "serde-json-core"
-version = "0.4.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "8014aeea272bca0f0779778d43253f2f3375b414185b30e6ecc4d3e4a9994781"
-dependencies = [
- "ryu",
- "serde",
-]
-
-[[package]]
name = "serde_derive"
version = "1.0.137"
source = "registry+https://github.com/rust-lang/crates.io-index"
@@ -12025,9 +12014,9 @@
[[package]]
name = "target-lexicon"
-version = "0.12.3"
+version = "0.12.4"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "d7fa7e55043acb85fca6b3c01485a2eeb6b69c5d21002e273c79e465f43b7ac1"
+checksum = "c02424087780c9b71cc96799eaeddff35af2bc513278cda5c99fc1f5d026d3c1"
[[package]]
name = "tempfile"
Makefilediffbeforeafterboth--- a/Makefile
+++ b/Makefile
@@ -15,16 +15,13 @@
CONTRACT_HELPERS_STUBS=./pallets/evm-contract-helpers/src/stubs/
CONTRACT_HELPERS_ABI=./tests/src/eth/util/contractHelpersAbi.json
-COLLECTION_STUBS=./pallets/unique/src/eth/stubs/
-COLLECTION_ABI=./tests/src/eth/collectionAbi.json
-
COLLECTION_HELPER_STUBS=$(COLLECTION_STUBS)
COLLECTION_HELPER_ABI=./tests/src/eth/collectionHelperAbi.json
TESTS_API=./tests/src/eth/api/
.PHONY: regenerate_solidity
-regenerate_solidity: UniqueFungible.sol UniqueNFT.sol ContractHelpers.sol Collection.sol CollectionHelper.sol
+regenerate_solidity: UniqueFungible.sol UniqueNFT.sol ContractHelpers.sol CollectionHelper.sol
UniqueFungible.sol:
PACKAGE=pallet-fungible NAME=erc::gen_iface OUTPUT=$(TESTS_API)/$@ ./.maintain/scripts/generate_sol.sh
@@ -38,10 +35,6 @@
PACKAGE=pallet-evm-contract-helpers NAME=eth::contract_helpers_iface OUTPUT=$(TESTS_API)/$@ ./.maintain/scripts/generate_sol.sh
PACKAGE=pallet-evm-contract-helpers NAME=eth::contract_helpers_impl OUTPUT=$(CONTRACT_HELPERS_STUBS)/$@ ./.maintain/scripts/generate_sol.sh
-Collection.sol:
- PACKAGE=pallet-unique NAME=eth::evm_collection::collection_iface OUTPUT=$(TESTS_API)/$@ ./.maintain/scripts/generate_sol.sh
- PACKAGE=pallet-unique NAME=eth::evm_collection::collection_impl OUTPUT=$(COLLECTION_STUBS)/$@ ./.maintain/scripts/generate_sol.sh
-
CollectionHelper.sol:
PACKAGE=pallet-unique NAME=eth::evm_collection::collection_helper_iface OUTPUT=$(TESTS_API)/$@ ./.maintain/scripts/generate_sol.sh
PACKAGE=pallet-unique NAME=eth::evm_collection::collection_helper_impl OUTPUT=$(COLLECTION_HELPER_STUBS)/$@ ./.maintain/scripts/generate_sol.sh
@@ -58,15 +51,11 @@
INPUT=$(CONTRACT_HELPERS_STUBS)/$< OUTPUT=$(CONTRACT_HELPERS_STUBS)/ContractHelpers.raw ./.maintain/scripts/compile_stub.sh
INPUT=$(CONTRACT_HELPERS_STUBS)/$< OUTPUT=$(CONTRACT_HELPERS_ABI) ./.maintain/scripts/generate_abi.sh
-Collection: Collection.sol
- INPUT=$(COLLECTION_STUBS)/$< OUTPUT=$(COLLECTION_STUBS)/Collection.raw ./.maintain/scripts/compile_stub.sh
- INPUT=$(COLLECTION_STUBS)/$< OUTPUT=$(COLLECTION_ABI) ./.maintain/scripts/generate_abi.sh
-
CollectionHelper: CollectionHelper.sol
INPUT=$(COLLECTION_HELPER_STUBS)/$< OUTPUT=$(COLLECTION_HELPER_STUBS)/CollectionHelper.raw ./.maintain/scripts/compile_stub.sh
INPUT=$(COLLECTION_HELPER_STUBS)/$< OUTPUT=$(COLLECTION_HELPER_ABI) ./.maintain/scripts/generate_abi.sh
-evm_stubs: UniqueFungible UniqueNFT ContractHelpers Collection CollectionHelper
+evm_stubs: UniqueFungible UniqueNFT ContractHelpers CollectionHelper
.PHONY: _bench
_bench:
pallets/common/src/erc.rsdiffbeforeafterboth--- a/pallets/common/src/erc.rs
+++ b/pallets/common/src/erc.rs
@@ -14,9 +14,9 @@
// You should have received a copy of the GNU General Public License
// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.
-use evm_coder::{solidity_interface, types::*, execution::Result};
+use evm_coder::{solidity_interface, types::*, execution::{Result, Error}};
pub use pallet_evm::{PrecompileOutput, PrecompileResult, account::CrossAccountId};
-use pallet_evm_coder_substrate::dispatch_to_evm;
+use pallet_evm_coder_substrate::{dispatch_to_evm, SubstrateRecorder};
use sp_core::{H160, U256};
use sp_std::vec::Vec;
use up_data_structs::Property;
@@ -31,7 +31,7 @@
fn call(self, source: &H160, input: &[u8], value: U256) -> Option<PrecompileResult>;
}
-#[solidity_interface(name = "CollectionProperties")]
+#[solidity_interface(name = "Collection")]
impl<T: Config> CollectionHandle<T> {
fn set_collection_property(&mut self, caller: caller, key: string, value: bytes) -> Result<()> {
let caller = T::CrossAccountId::from_eth(caller);
@@ -64,4 +64,70 @@
Ok(prop.to_vec())
}
+
+ fn eth_set_sponsor(
+ &mut self,
+ caller: caller,
+ sponsor: address,
+ ) -> Result<void> {
+ check_is_owner(caller, self)?;
+
+ let sponsor = T::CrossAccountId::from_eth(sponsor);
+ self.set_sponsor(sponsor.as_sub().clone());
+ save(self);
+ Ok(())
+ }
+
+ fn eth_confirm_sponsorship(&mut self, caller: caller) -> Result<void> {
+ let caller = T::CrossAccountId::from_eth(caller);
+ if !self.confirm_sponsorship(caller.as_sub()) {
+ return Err(Error::Revert("Caller is not set as sponsor".into()));
+ }
+ save(self);
+ Ok(())
+ }
+
+ fn set_limits(
+ &self,
+ caller: caller,
+ limits_json: string,
+ ) -> Result<void> {
+ // let mut collection = collection_from_address::<T>(self.contract_address(caller).unwrap(), self.1.gas_left())?;
+ // check_is_owner(caller, &collection)?;
+
+ // let limits = serde_json_core::from_str(limits_json.as_ref())
+ // .map_err(|e| Error::Revert(format!("Parse JSON error: {}", e)))?;
+ // collection.limits = limits.0;
+ // collection.save().map_err(pallet_evm_coder_substrate::dispatch_to_evm::<T>)?;
+ Ok(())
+ }
+
+ fn contract_address(&self, _caller: caller) -> Result<address> {
+ Ok(crate::eth::collection_id_to_address(self.id))
+ }
+}
+
+fn collection_from_address<T: Config>(
+ collection_address: address,
+ gas_limit: u64
+) -> Result<CollectionHandle<T>> {
+ let collection_id = crate::eth::map_eth_to_id(&collection_address)
+ .ok_or(Error::Revert("Contract is not an unique collection".into()))?;
+ let recorder = <SubstrateRecorder<T>>::new(gas_limit);
+ let collection =
+ CollectionHandle::new_with_recorder(collection_id, recorder)
+ .ok_or(Error::Revert("Create collection handle error".into()))?;
+ Ok(collection)
+}
+
+fn check_is_owner<T: Config>(caller: caller, collection: &CollectionHandle<T>) -> Result<()> {
+ let caller = T::CrossAccountId::from_eth(caller);
+ collection
+ .check_is_owner(&caller)
+ .map_err(pallet_evm_coder_substrate::dispatch_to_evm::<T>)?;
+ Ok(())
}
+
+fn save<T: Config>(collection: &CollectionHandle<T>) {
+ <crate::CollectionById<T>>::insert(collection.id, collection.collection.clone());
+}
\ No newline at end of file
pallets/common/src/lib.rsdiffbeforeafterboth--- a/pallets/common/src/lib.rs
+++ b/pallets/common/src/lib.rs
@@ -20,7 +20,7 @@
use core::ops::{Deref, DerefMut};
use pallet_evm_coder_substrate::{SubstrateRecorder, WithRecorder};
-use sp_std::{vec::Vec, rc::Rc};
+use sp_std::vec::Vec;
use pallet_evm::account::CrossAccountId;
use frame_support::{
dispatch::{DispatchErrorWithPostInfo, DispatchResultWithPostInfo, Weight, PostDispatchInfo},
pallets/fungible/src/erc.rsdiffbeforeafterboth--- a/pallets/fungible/src/erc.rs
+++ b/pallets/fungible/src/erc.rs
@@ -24,7 +24,7 @@
use pallet_evm::account::CrossAccountId;
use pallet_evm_coder_substrate::{call, dispatch_to_evm};
use pallet_structure::{SelfWeightOf as StructureWeight, weights::WeightInfo as _};
-use pallet_common::{CollectionHandle, erc::CollectionPropertiesCall};
+use pallet_common::{CollectionHandle, erc::CollectionCall};
use crate::{
Allowance, Balance, Config, FungibleHandle, Pallet, SelfWeightOf, TotalSupply,
@@ -150,7 +150,7 @@
is(
ERC20,
ERC20UniqueExtensions,
- via("CollectionHandle<T>", common_mut, CollectionProperties)
+ via("CollectionHandle<T>", common_mut, Collection)
)
)]
impl<T: Config> FungibleHandle<T> {}
pallets/nonfungible/src/erc.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/erc.rs
+++ b/pallets/nonfungible/src/erc.rs
@@ -26,7 +26,7 @@
use sp_core::{H160, U256};
use sp_std::vec::Vec;
use pallet_common::{
- erc::{CommonEvmHandler, PrecompileResult, CollectionPropertiesCall},
+ erc::{CommonEvmHandler, PrecompileResult, CollectionCall},
CollectionHandle,
};
use pallet_evm::account::CrossAccountId;
@@ -513,7 +513,7 @@
ERC721UniqueExtensions,
ERC721Mintable,
ERC721Burnable,
- via("CollectionHandle<T>", common_mut, CollectionProperties),
+ via("CollectionHandle<T>", common_mut, Collection),
TokenProperties,
)
)]
pallets/nonfungible/src/stubs/UniqueNFT.rawdiffbeforeafterbothbinary blob — no preview
pallets/nonfungible/src/stubs/UniqueNFT.soldiffbeforeafterboth--- a/pallets/nonfungible/src/stubs/UniqueNFT.sol
+++ b/pallets/nonfungible/src/stubs/UniqueNFT.sol
@@ -51,6 +51,67 @@
event MintingFinished();
}
+// Selector: 38e33c60
+contract Collection is Dummy, ERC165 {
+ // Selector: setCollectionProperty(string,bytes) 2f073f66
+ function setCollectionProperty(string memory key, bytes memory value)
+ public
+ {
+ require(false, stub_error);
+ key;
+ value;
+ dummy = 0;
+ }
+
+ // Selector: deleteCollectionProperty(string) 7b7debce
+ function deleteCollectionProperty(string memory key) public {
+ require(false, stub_error);
+ key;
+ dummy = 0;
+ }
+
+ // Throws error if key not found
+ //
+ // Selector: collectionProperty(string) cf24fd6d
+ function collectionProperty(string memory key)
+ public
+ view
+ returns (bytes memory)
+ {
+ require(false, stub_error);
+ key;
+ dummy;
+ return hex"";
+ }
+
+ // Selector: ethSetSponsor(address) 8f9af356
+ function ethSetSponsor(address sponsor) public {
+ require(false, stub_error);
+ sponsor;
+ dummy = 0;
+ }
+
+ // Selector: ethConfirmSponsorship() a8580d1a
+ function ethConfirmSponsorship() public {
+ require(false, stub_error);
+ dummy = 0;
+ }
+
+ // Selector: setLimits(string) 72cb345d
+ function setLimits(string memory limitsJson) public view {
+ require(false, stub_error);
+ limitsJson;
+ dummy;
+ }
+
+ // Selector: contractAddress() f6b4dfb4
+ function contractAddress() public view returns (address) {
+ require(false, stub_error);
+ dummy;
+ return 0x0000000000000000000000000000000000000000;
+ }
+}
+
// Selector: 41369377
contract TokenProperties is Dummy, ERC165 {
// Selector: setTokenPropertyPermission(string,bool,bool,bool) 222d97fa
@@ -327,40 +388,6 @@
require(false, stub_error);
dummy;
return 0;
- }
-}
-
-// Selector: 9b5e29c5
-contract CollectionProperties is Dummy, ERC165 {
- // Selector: setCollectionProperty(string,bytes) 2f073f66
- function setCollectionProperty(string memory key, bytes memory value)
- public
- {
- require(false, stub_error);
- key;
- value;
- dummy = 0;
- }
-
- // Selector: deleteCollectionProperty(string) 7b7debce
- function deleteCollectionProperty(string memory key) public {
- require(false, stub_error);
- key;
- dummy = 0;
- }
-
- // Throws error if key not found
- //
- // Selector: collectionProperty(string) cf24fd6d
- function collectionProperty(string memory key)
- public
- view
- returns (bytes memory)
- {
- require(false, stub_error);
- key;
- dummy;
- return hex"";
}
}
@@ -423,6 +450,6 @@
ERC721UniqueExtensions,
ERC721Mintable,
ERC721Burnable,
- CollectionProperties,
+ Collection,
TokenProperties
{}
pallets/unique/Cargo.tomldiffbeforeafterboth--- a/pallets/unique/Cargo.toml
+++ b/pallets/unique/Cargo.toml
@@ -20,7 +20,6 @@
std = [
'codec/std',
'serde/std',
- 'serde-json-core/std',
'frame-support/std',
'frame-system/std',
'pallet-evm/std',
@@ -42,10 +41,6 @@
default-features = false
features = ['derive']
version = '1.0.130'
-
-[dependencies.serde-json-core]
-default-features = false
-version = "0.4"
[dependencies.ethereum]
version = "0.12.0"
pallets/unique/src/eth/mod.rsdiffbeforeafterboth--- a/pallets/unique/src/eth/mod.rs
+++ b/pallets/unique/src/eth/mod.rs
@@ -110,17 +110,6 @@
}
}
- struct EvmCollection<T: Config>(H160, SubstrateRecorder<T>);
- impl<T: Config> WithRecorder<T> for EvmCollection<T> {
- fn recorder(&self) -> &SubstrateRecorder<T> {
- &self.1
- }
-
- fn into_recorder(self) -> SubstrateRecorder<T> {
- self.1
- }
- }
-
#[derive(ToLog)]
pub enum EthCollectionEvent {
CollectionCreated {
@@ -129,78 +118,7 @@
#[indexed]
collection_id: address,
},
- }
-
- #[solidity_interface(name = "Collection")]
- impl<T: Config> EvmCollection<T> {
- fn set_sponsor(
- &self,
- caller: caller,
- sponsor: address,
- ) -> Result<void> {
- let mut collection = collection_from_address::<T>(self.contract_address(caller).unwrap(), self.1.gas_left())?;
- check_is_owner(caller, &collection)?;
-
- let sponsor = T::CrossAccountId::from_eth(sponsor);
- collection.set_sponsor(sponsor.as_sub().clone());
- collection.save().map_err(pallet_evm_coder_substrate::dispatch_to_evm::<T>)?;
- Ok(())
- }
-
- fn confirm_sponsorship(&self, caller: caller) -> Result<void> {
- let mut collection = collection_from_address::<T>(self.contract_address(caller).unwrap(), self.1.gas_left())?;
- let caller = T::CrossAccountId::from_eth(caller);
- if !collection.confirm_sponsorship(caller.as_sub()) {
- return Err(Error::Revert("Caller is not set as sponsor".into()));
- }
- collection.save().map_err(pallet_evm_coder_substrate::dispatch_to_evm::<T>)?;
- Ok(())
- }
-
- fn set_limits(
- &self,
- caller: caller,
- limits_json: string,
- ) -> Result<void> {
- let mut collection = collection_from_address::<T>(self.contract_address(caller).unwrap(), self.1.gas_left())?;
- check_is_owner(caller, &collection)?;
-
- let limits = serde_json_core::from_str(limits_json.as_ref())
- .map_err(|e| Error::Revert(format!("Parse JSON error: {}", e)))?;
- collection.limits = limits.0;
- collection.save().map_err(pallet_evm_coder_substrate::dispatch_to_evm::<T>)?;
- Ok(())
- }
-
- fn contract_address(&self, _caller: caller) -> Result<address> {
- Ok(self.0)
- }
- }
-
- fn error_feild_too_long(feild: &str, bound: u32) -> Error {
- Error::Revert(format!("{} is too long. Max length is {}.", feild, bound))
}
-
- fn collection_from_address<T: Config>(
- collection_address: address,
- gas_limit: u64
- ) -> Result<CollectionHandle<T>> {
- let collection_id = pallet_common::eth::map_eth_to_id(&collection_address)
- .ok_or(Error::Revert("Contract is not an unique collection".into()))?;
- let recorder = <SubstrateRecorder<T>>::new(gas_limit);
- let collection =
- pallet_common::CollectionHandle::new_with_recorder(collection_id, recorder)
- .ok_or(Error::Revert("Create collection handle error".into()))?;
- Ok(collection)
- }
-
- fn check_is_owner<T: Config>(caller: caller, collection: &CollectionHandle<T>) -> Result<()> {
- let caller = T::CrossAccountId::from_eth(caller);
- collection
- .check_is_owner(&caller)
- .map_err(pallet_evm_coder_substrate::dispatch_to_evm::<T>)?;
- Ok(())
- }
pub struct CollectionHelperOnMethodCall<T: Config>(PhantomData<*const T>);
impl<T: Config> OnMethodCall<T> for CollectionHelperOnMethodCall<T> {
@@ -235,38 +153,8 @@
generate_stubgen!(collection_helper_impl, CollectionHelperCall<()>, true);
generate_stubgen!(collection_helper_iface, CollectionHelperCall<()>, false);
-
- pub struct CollectionOnMethodCall<T: Config>(PhantomData<*const T>);
- impl<T: Config> OnMethodCall<T> for CollectionOnMethodCall<T> {
- fn is_reserved(contract: &sp_core::H160) -> bool {
- contract == &T::ContractAddress::get()
- }
-
- fn is_used(contract: &sp_core::H160) -> bool {
- contract == &T::ContractAddress::get()
- }
-
- fn call(
- source: &sp_core::H160,
- target: &sp_core::H160,
- gas_left: u64,
- input: &[u8],
- value: sp_core::U256,
- ) -> Option<PrecompileResult> {
- if !pallet_common::eth::is_collection(target) {
- return None;
- }
- let helpers = EvmCollection::<T>(*target, SubstrateRecorder::<T>::new(gas_left));
- pallet_evm_coder_substrate::call(*source, helpers, value, input)
- }
-
- fn get_code(contract: &sp_core::H160) -> Option<Vec<u8>> {
- (contract == &T::ContractAddress::get())
- .then(|| include_bytes!("./stubs/Collection.raw").to_vec())
- }
+ fn error_feild_too_long(feild: &str, bound: u32) -> Error {
+ Error::Revert(format!("{} is too long. Max length is {}.", feild, bound))
}
-
- generate_stubgen!(collection_impl, CollectionCall<()>, true);
- generate_stubgen!(collection_iface, CollectionCall<()>, false);
}
pallets/unique/src/eth/stubs/Collection.rawdiffbeforeafterbothbinary blob — no preview
pallets/unique/src/eth/stubs/Collection.soldiffbeforeafterboth--- a/pallets/unique/src/eth/stubs/Collection.sol
+++ /dev/null
@@ -1,52 +0,0 @@
-// SPDX-License-Identifier: OTHER
-// This code is automatically generated
-
-pragma solidity >=0.8.0 <0.9.0;
-
-// Common stubs holder
-contract Dummy {
- uint8 dummy;
- string stub_error = "this contract is implemented in native";
-}
-
-contract ERC165 is Dummy {
- function supportsInterface(bytes4 interfaceID)
- external
- view
- returns (bool)
- {
- require(false, stub_error);
- interfaceID;
- return true;
- }
-}
-
-// Selector: 15cc740e
-contract Collection is Dummy, ERC165 {
- // Selector: setSponsor(address) 59753fb1
- function setSponsor(address sponsor) public view {
- require(false, stub_error);
- sponsor;
- dummy;
- }
-
- // Selector: confirmSponsorship() c8c6a056
- function confirmSponsorship() public view {
- require(false, stub_error);
- dummy;
- }
-
- // Selector: setLimits(string) 72cb345d
- function setLimits(string memory limitsJson) public view {
- require(false, stub_error);
- limitsJson;
- dummy;
- }
-
- // Selector: contractAddress() f6b4dfb4
- function contractAddress() public view returns (address) {
- require(false, stub_error);
- dummy;
- return 0x0000000000000000000000000000000000000000;
- }
-}
runtime/opal/src/lib.rsdiffbeforeafterboth--- a/runtime/opal/src/lib.rs
+++ b/runtime/opal/src/lib.rs
@@ -307,7 +307,6 @@
pallet_evm_migration::OnMethodCall<Self>,
pallet_evm_contract_helpers::HelpersOnMethodCall<Self>,
CollectionDispatchT<Self>,
- evm_collection::CollectionOnMethodCall<Self>,
evm_collection::CollectionHelperOnMethodCall<Self>,
);
type OnCreate = pallet_evm_contract_helpers::HelpersOnCreate<Self>;
runtime/quartz/src/lib.rsdiffbeforeafterboth--- a/runtime/quartz/src/lib.rs
+++ b/runtime/quartz/src/lib.rs
@@ -286,7 +286,6 @@
pallet_evm_migration::OnMethodCall<Self>,
pallet_evm_contract_helpers::HelpersOnMethodCall<Self>,
CollectionDispatchT<Self>,
- evm_collection::CollectionOnMethodCall<Self>,
evm_collection::CollectionHelperOnMethodCall<Self>,
);
type OnCreate = pallet_evm_contract_helpers::HelpersOnCreate<Self>;
runtime/unique/src/lib.rsdiffbeforeafterboth--- a/runtime/unique/src/lib.rs
+++ b/runtime/unique/src/lib.rs
@@ -291,7 +291,6 @@
pallet_evm_migration::OnMethodCall<Self>,
pallet_evm_contract_helpers::HelpersOnMethodCall<Self>,
CollectionDispatchT<Self>,
- evm_collection::CollectionOnMethodCall<Self>,
evm_collection::CollectionHelperOnMethodCall<Self>,
);
type OnCreate = pallet_evm_contract_helpers::HelpersOnCreate<Self>;
tests/src/eth/api/UniqueNFT.soldiffbeforeafterboth--- a/tests/src/eth/api/UniqueNFT.sol
+++ b/tests/src/eth/api/UniqueNFT.sol
@@ -42,6 +42,36 @@
event MintingFinished();
}
+// Selector: 38e33c60
+interface Collection is Dummy, ERC165 {
+ // Selector: setCollectionProperty(string,bytes) 2f073f66
+ function setCollectionProperty(string memory key, bytes memory value)
+ external;
+
+ // Selector: deleteCollectionProperty(string) 7b7debce
+ function deleteCollectionProperty(string memory key) external;
+
+ // Throws error if key not found
+ //
+ // Selector: collectionProperty(string) cf24fd6d
+ function collectionProperty(string memory key)
+ external
+ view
+ returns (bytes memory);
+
+ // Selector: ethSetSponsor(address) 8f9af356
+ function ethSetSponsor(address sponsor) external;
+
+ // Selector: ethConfirmSponsorship() a8580d1a
+ function ethConfirmSponsorship() external;
+
+ // Selector: setLimits(string) 72cb345d
+ function setLimits(string memory limitsJson) external view;
+
+ // Selector: contractAddress() f6b4dfb4
+ function contractAddress() external view returns (address);
+}
+
// Selector: 41369377
interface TokenProperties is Dummy, ERC165 {
// Selector: setTokenPropertyPermission(string,bool,bool,bool) 222d97fa
@@ -191,24 +221,6 @@
function totalSupply() external view returns (uint256);
}
-// Selector: 9b5e29c5
-interface CollectionProperties is Dummy, ERC165 {
- // Selector: setCollectionProperty(string,bytes) 2f073f66
- function setCollectionProperty(string memory key, bytes memory value)
- external;
-
- // Selector: deleteCollectionProperty(string) 7b7debce
- function deleteCollectionProperty(string memory key) external;
-
- // Throws error if key not found
- //
- // Selector: collectionProperty(string) cf24fd6d
- function collectionProperty(string memory key)
- external
- view
- returns (bytes memory);
-}
-
// Selector: d74d154f
interface ERC721UniqueExtensions is Dummy, ERC165 {
// Selector: transfer(address,uint256) a9059cbb
@@ -240,6 +252,6 @@
ERC721UniqueExtensions,
ERC721Mintable,
ERC721Burnable,
- CollectionProperties,
+ Collection,
TokenProperties
{}
tests/src/eth/collectionAbi.jsondiffbeforeafterboth--- a/tests/src/eth/collectionAbi.json
+++ /dev/null
@@ -1,43 +0,0 @@
-[
- {
- "inputs": [],
- "name": "confirmSponsorship",
- "outputs": [],
- "stateMutability": "view",
- "type": "function"
- },
- {
- "inputs": [],
- "name": "contractAddress",
- "outputs": [{ "internalType": "address", "name": "", "type": "address" }],
- "stateMutability": "view",
- "type": "function"
- },
- {
- "inputs": [
- { "internalType": "string", "name": "limitsJson", "type": "string" }
- ],
- "name": "setLimits",
- "outputs": [],
- "stateMutability": "view",
- "type": "function"
- },
- {
- "inputs": [
- { "internalType": "address", "name": "sponsor", "type": "address" }
- ],
- "name": "setSponsor",
- "outputs": [],
- "stateMutability": "view",
- "type": "function"
- },
- {
- "inputs": [
- { "internalType": "bytes4", "name": "interfaceID", "type": "bytes4" }
- ],
- "name": "supportsInterface",
- "outputs": [{ "internalType": "bool", "name": "", "type": "bool" }],
- "stateMutability": "view",
- "type": "function"
- }
-]
tests/src/eth/createCollection.test.tsdiffbeforeafterboth1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.8//9// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617import nonFungibleAbi from './nonFungibleAbi.json';18import {ApiPromise} from '@polkadot/api';19import {evmToAddress} from '@polkadot/util-crypto';20import {expect} from 'chai';21import {getCreatedCollectionCount, getDetailedCollectionInfo} from '../util/helpers';22import {23 evmCollectionHelper,24 collectionIdFromAddress,25 collectionIdToAddress,26 createEthAccount,27 createEthAccountWithBalance,28 evmCollection,29 GAS_ARGS,30 itWeb3,31 normalizeAddress,32 normalizeEvents,33} from './util/helpers';3435async function getCollectionAddressFromResult(api: ApiPromise, result: any) {36 const collectionIdAddress = normalizeAddress(result.events[0].raw.topics[2]);37 const collectionId = collectionIdFromAddress(collectionIdAddress); 38 const collection = (await getDetailedCollectionInfo(api, collectionId))!;39 return {collectionIdAddress, collectionId, collection};40}4142describe('Create collection from EVM', () => {43 itWeb3('Create collection', async ({api, web3}) => {44 const owner = await createEthAccountWithBalance(api, web3);45 const helper = evmCollectionHelper(web3, owner);46 const collectionName = 'CollectionEVM';47 const description = 'Some description';48 const tokenPrefix = 'token prefix';49 50 const collectionCountBefore = await getCreatedCollectionCount(api);51 const result = await helper.methods52 .create721Collection(collectionName, description, tokenPrefix)53 .send();54 const collectionCountAfter = await getCreatedCollectionCount(api);55 56 const {collectionId, collection} = await getCollectionAddressFromResult(api, result);57 expect(collectionCountAfter - collectionCountBefore).to.be.eq(1);58 expect(collectionId).to.be.eq(collectionCountAfter);59 expect(collection.name.map(v => String.fromCharCode(v.toNumber())).join('')).to.be.eq(collectionName);60 expect(collection.description.map(v => String.fromCharCode(v.toNumber())).join('')).to.be.eq(description);61 expect(collection.tokenPrefix.toHuman()).to.be.eq(tokenPrefix);62 expect(collection.schemaVersion.type).to.be.eq('ImageURL');63 });6465 itWeb3('Check collection address exist', async ({api, web3}) => {66 const owner = await createEthAccountWithBalance(api, web3);67 const collectionHelper = evmCollectionHelper(web3, owner);68 69 const expectedCollectionId = await getCreatedCollectionCount(api) + 1;70 const expectedCollectionAddress = collectionIdToAddress(expectedCollectionId);71 expect(await collectionHelper.methods72 .isCollectionExist(expectedCollectionAddress)73 .call()).to.be.false;7475 await collectionHelper.methods76 .create721Collection('A', 'A', 'A')77 .send();78 79 expect(await collectionHelper.methods80 .isCollectionExist(expectedCollectionAddress)81 .call()).to.be.true;82 });83 84 itWeb3('Set sponsorship', async ({api, web3}) => {85 const owner = await createEthAccountWithBalance(api, web3);86 const collectionHelper = evmCollectionHelper(web3, owner);87 let result = await collectionHelper.methods.create721Collection('Sponsor collection', '1', '1').send();88 const {collectionIdAddress, collectionId} = await getCollectionAddressFromResult(api, result);89 const sponsor = await createEthAccountWithBalance(api, web3);90 const collectionEvm = evmCollection(web3, owner, collectionIdAddress);91 result = await collectionEvm.methods.setSponsor(sponsor).send();92 let collectionSub = (await getDetailedCollectionInfo(api, collectionId))!;93 expect(collectionSub.sponsorship.isUnconfirmed).to.be.true;94 expect(collectionSub.sponsorship.asUnconfirmed.toHuman()).to.be.eq(evmToAddress(sponsor));95 await expect(collectionEvm.methods.confirmSponsorship().call()).to.be.rejectedWith('Caller is not set as sponsor');96 const sponsorCollection = evmCollection(web3, sponsor, collectionIdAddress);97 await sponsorCollection.methods.confirmSponsorship().send();98 collectionSub = (await getDetailedCollectionInfo(api, collectionId))!;99 expect(collectionSub.sponsorship.isConfirmed).to.be.true;100 expect(collectionSub.sponsorship.asConfirmed.toHuman()).to.be.eq(evmToAddress(sponsor));101 });102103 itWeb3('Set limits', async ({api, web3}) => {104 const owner = await createEthAccountWithBalance(api, web3);105 const collectionHelper = evmCollectionHelper(web3, owner);106 const result = await collectionHelper.methods.create721Collection('Const collection', '5', '5').send();107 const {collectionIdAddress, collectionId} = await getCollectionAddressFromResult(api, result);108 const limits = {109 accountTokenOwnershipLimit: 1000,110 sponsoredDataSize: 1024,111 sponsoredDataRateLimit: {Blocks: 30},112 tokenLimit: 1000000,113 sponsorTransferTimeout: 6,114 sponsorApproveTimeout: 6,115 ownerCanTransfer: false,116 ownerCanDestroy: false,117 transfersEnabled: false,118 };119120 const limitsJson = JSON.stringify(limits, null, 1);121 const collectionEvm = evmCollection(web3, owner, collectionIdAddress);122 await collectionEvm.methods.setLimits(limitsJson).send();123 124 const collectionSub = (await getDetailedCollectionInfo(api, collectionId))!;125 expect(collectionSub.limits.accountTokenOwnershipLimit.unwrap().toNumber()).to.be.eq(limits.accountTokenOwnershipLimit);126 expect(collectionSub.limits.sponsoredDataSize.unwrap().toNumber()).to.be.eq(limits.sponsoredDataSize);127 expect(collectionSub.limits.sponsoredDataRateLimit.unwrap().asBlocks.toNumber()).to.be.eq(limits.sponsoredDataRateLimit.Blocks);128 expect(collectionSub.limits.tokenLimit.unwrap().toNumber()).to.be.eq(limits.tokenLimit);129 expect(collectionSub.limits.sponsorTransferTimeout.unwrap().toNumber()).to.be.eq(limits.sponsorTransferTimeout);130 expect(collectionSub.limits.sponsorApproveTimeout.unwrap().toNumber()).to.be.eq(limits.sponsorApproveTimeout);131 expect(collectionSub.limits.ownerCanTransfer.toHuman()).to.be.eq(limits.ownerCanTransfer);132 expect(collectionSub.limits.ownerCanDestroy.toHuman()).to.be.eq(limits.ownerCanDestroy);133 expect(collectionSub.limits.transfersEnabled.toHuman()).to.be.eq(limits.transfersEnabled);134 });135136 itWeb3('Check tokenURI', async ({web3, api}) => {137 const owner = await createEthAccountWithBalance(api, web3);138 const helper = evmCollectionHelper(web3, owner);139 let result = await helper.methods.create721Collection('Mint collection', '6', '6').send();140 const {collectionIdAddress, collectionId} = await getCollectionAddressFromResult(api, result);141 const receiver = createEthAccount(web3);142 const contract = new web3.eth.Contract(nonFungibleAbi as any, collectionIdAddress, {from: owner, ...GAS_ARGS});143 const nextTokenId = await contract.methods.nextTokenId().call();144145 expect(nextTokenId).to.be.equal('1');146 result = await contract.methods.mintWithTokenURI(147 receiver,148 nextTokenId,149 'Test URI',150 ).send();151152 const events = normalizeEvents(result.events);153 const address = collectionIdToAddress(collectionId);154155 expect(events).to.be.deep.equal([156 {157 address,158 event: 'Transfer',159 args: {160 from: '0x0000000000000000000000000000000000000000',161 to: receiver,162 tokenId: nextTokenId,163 },164 },165 ]);166167 expect(await contract.methods.tokenURI(nextTokenId).call()).to.be.equal('Test URI');168169 // TODO: this wont work right now, need release 919000 first170 // await helper.methods.setOffchainSchema(collectionIdAddress, 'https://offchain-service.local/token-info/{id}').send();171 // const tokenUri = await contract.methods.tokenURI(nextTokenId).call();172 // expect(tokenUri).to.be.equal(`https://offchain-service.local/token-info/${nextTokenId}`);173 });174});175176describe('(!negative tests!) Create collection from EVM', () => {177 itWeb3('(!negative test!) Create collection (bad lengths)', async ({api, web3}) => {178 const owner = await createEthAccountWithBalance(api, web3);179 const helper = evmCollectionHelper(web3, owner);180 {181 const MAX_NAME_LENGHT = 64;182 const collectionName = 'A'.repeat(MAX_NAME_LENGHT + 1);183 const description = 'A';184 const tokenPrefix = 'A';185 186 await expect(helper.methods187 .create721Collection(collectionName, description, tokenPrefix)188 .call()).to.be.rejectedWith('name is too long. Max length is ' + MAX_NAME_LENGHT);189 190 }191 { 192 const MAX_DESCRIPTION_LENGHT = 256;193 const collectionName = 'A';194 const description = 'A'.repeat(MAX_DESCRIPTION_LENGHT + 1);195 const tokenPrefix = 'A';196 await expect(helper.methods197 .create721Collection(collectionName, description, tokenPrefix)198 .call()).to.be.rejectedWith('description is too long. Max length is ' + MAX_DESCRIPTION_LENGHT);199 }200 { 201 const MAX_TOKEN_PREFIX_LENGHT = 16;202 const collectionName = 'A';203 const description = 'A';204 const tokenPrefix = 'A'.repeat(MAX_TOKEN_PREFIX_LENGHT + 1);205 await expect(helper.methods206 .create721Collection(collectionName, description, tokenPrefix)207 .call()).to.be.rejectedWith('token_prefix is too long. Max length is ' + MAX_TOKEN_PREFIX_LENGHT);208 }209 });210 211 itWeb3('(!negative test!) Create collection (no funds)', async ({web3}) => {212 const owner = await createEthAccount(web3);213 const helper = evmCollectionHelper(web3, owner);214 const collectionName = 'A';215 const description = 'A';216 const tokenPrefix = 'A';217 218 await expect(helper.methods219 .create721Collection(collectionName, description, tokenPrefix)220 .call()).to.be.rejectedWith('NotSufficientFounds');221 });222223 itWeb3('(!negative test!) Collection address (Create collection handle error)', async ({api, web3}) => {224 const owner = await createEthAccountWithBalance(api, web3);225 const collectionAddressForNonexistentCollection = '0x17C4E6453CC49AAAAEACA894E6D9683E00112233';226 const collectionEvm = evmCollection(web3, owner, collectionAddressForNonexistentCollection);227 const EXPECTED_ERROR = 'Create collection handle error';228 {229 const sponsor = await createEthAccountWithBalance(api, web3);230 await expect(collectionEvm.methods231 .setSponsor(sponsor)232 .call()).to.be.rejectedWith(EXPECTED_ERROR);233 234 const sponsorCollection = evmCollection(web3, sponsor, collectionAddressForNonexistentCollection);235 await expect(sponsorCollection.methods236 .confirmSponsorship()237 .call()).to.be.rejectedWith(EXPECTED_ERROR);238 }239 {240 const limits = '{"account_token_ownership_limit":1000}';241 await expect(collectionEvm.methods242 .setLimits(limits)243 .call()).to.be.rejectedWith(EXPECTED_ERROR);244 }245 });246247 itWeb3('(!negative test!) Check owner', async ({api, web3}) => {248 const owner = await createEthAccountWithBalance(api, web3);249 const notOwner = await createEthAccount(web3);250 const collectionHelper = evmCollectionHelper(web3, owner);251 const result = await collectionHelper.methods.create721Collection('A', 'A', 'A').send();252 const {collectionIdAddress} = await getCollectionAddressFromResult(api, result);253 const contractEvmFromNotOwner = evmCollection(web3, notOwner, collectionIdAddress);254 const EXPECTED_ERROR = 'NoPermission';255 {256 const sponsor = await createEthAccountWithBalance(api, web3);257 await expect(contractEvmFromNotOwner.methods258 .setSponsor(sponsor)259 .call()).to.be.rejectedWith(EXPECTED_ERROR);260 261 const sponsorCollection = evmCollection(web3, sponsor, collectionIdAddress);262 await expect(sponsorCollection.methods263 .confirmSponsorship()264 .call()).to.be.rejectedWith('Caller is not set as sponsor');265 }266 {267 const limits = '{"account_token_ownership_limit":1000}';268 await expect(contractEvmFromNotOwner.methods269 .setLimits(limits)270 .call()).to.be.rejectedWith(EXPECTED_ERROR);271 }272 });273274 itWeb3('(!negative test!) Set limits', async ({api, web3}) => {275 const owner = await createEthAccountWithBalance(api, web3);276 const collectionHelper = evmCollectionHelper(web3, owner);277 const result = await collectionHelper.methods.create721Collection('Schema collection', 'A', 'A').send();278 const {collectionIdAddress} = await getCollectionAddressFromResult(api, result);279 const collectionEvm = evmCollection(web3, owner, collectionIdAddress);280 const badJson = '{accountTokenOwnershipLimit: 1000}';281 await expect(collectionEvm.methods282 .setLimits(badJson)283 .call()).to.be.rejectedWith('Parse JSON error:');284 });285});tests/src/eth/nonFungibleAbi.jsondiffbeforeafterboth--- a/tests/src/eth/nonFungibleAbi.json
+++ b/tests/src/eth/nonFungibleAbi.json
@@ -126,6 +126,13 @@
"type": "function"
},
{
+ "inputs": [],
+ "name": "contractAddress",
+ "outputs": [{ "internalType": "address", "name": "", "type": "address" }],
+ "stateMutability": "view",
+ "type": "function"
+ },
+ {
"inputs": [{ "internalType": "string", "name": "key", "type": "string" }],
"name": "deleteCollectionProperty",
"outputs": [],
@@ -144,6 +151,22 @@
},
{
"inputs": [],
+ "name": "ethConfirmSponsorship",
+ "outputs": [],
+ "stateMutability": "nonpayable",
+ "type": "function"
+ },
+ {
+ "inputs": [
+ { "internalType": "address", "name": "sponsor", "type": "address" }
+ ],
+ "name": "ethSetSponsor",
+ "outputs": [],
+ "stateMutability": "nonpayable",
+ "type": "function"
+ },
+ {
+ "inputs": [],
"name": "finishMinting",
"outputs": [{ "internalType": "bool", "name": "", "type": "bool" }],
"stateMutability": "nonpayable",
@@ -302,6 +325,15 @@
},
{
"inputs": [
+ { "internalType": "string", "name": "limitsJson", "type": "string" }
+ ],
+ "name": "setLimits",
+ "outputs": [],
+ "stateMutability": "view",
+ "type": "function"
+ },
+ {
+ "inputs": [
{ "internalType": "uint256", "name": "tokenId", "type": "uint256" },
{ "internalType": "string", "name": "key", "type": "string" },
{ "internalType": "bytes", "name": "value", "type": "bytes" }
tests/src/eth/util/helpers.tsdiffbeforeafterboth--- a/tests/src/eth/util/helpers.ts
+++ b/tests/src/eth/util/helpers.ts
@@ -28,7 +28,7 @@
import config from '../../config';
import privateKey from '../../substrate/privateKey';
import contractHelpersAbi from './contractHelpersAbi.json';
-import collectionAbi from '../collectionAbi.json';
+import collectionAbi from '../nonFungibleAbi.json';
import collectionHelperAbi from '../collectionHelperAbi.json';
import getBalance from '../../substrate/get-balance';
import waitNewBlocks from '../../substrate/wait-new-blocks';