difftreelog
refactor remove unneeded fn, add transactional attrs
in: master
2 files changed
pallets/common/src/lib.rsdiffbeforeafterboth--- a/pallets/common/src/lib.rs
+++ b/pallets/common/src/lib.rs
@@ -26,6 +26,7 @@
traits::{Imbalance, Get, Currency, WithdrawReasons, ExistenceRequirement},
BoundedVec,
weights::Pays,
+ transactional,
};
use pallet_evm::GasWeightMapping;
use up_data_structs::{
@@ -742,6 +743,7 @@
Ok(())
}
+ #[transactional]
pub fn set_collection_properties(
collection: &CollectionHandle<T>,
sender: &T::CrossAccountId,
@@ -774,6 +776,7 @@
Ok(())
}
+ #[transactional]
pub fn delete_collection_properties(
collection: &CollectionHandle<T>,
sender: &T::CrossAccountId,
@@ -816,6 +819,7 @@
Ok(())
}
+ #[transactional]
pub fn set_property_permissions(
collection: &CollectionHandle<T>,
sender: &T::CrossAccountId,
@@ -837,19 +841,6 @@
.map_err(|_| <Error<T>>::UnableToReadUnboundedKeys.into())
})
.collect::<Result<Vec<PropertyKey>, DispatchError>>()
- }
-
- pub fn check_property_key(key: &PropertyKey) -> Result<(), DispatchError> {
- let key_str = sp_std::str::from_utf8(key.as_slice())
- .map_err(|_| <Error<T>>::InvalidCharacterInPropertyKey)?;
-
- for ch in key_str.chars() {
- if !ch.is_ascii_alphanumeric() && ch != '_' && ch != '-' {
- return Err(<Error<T>>::InvalidCharacterInPropertyKey.into());
- }
- }
-
- Ok(())
}
pub fn filter_collection_properties(
pallets/nonfungible/src/lib.rsdiffbeforeafterboth1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617#![cfg_attr(not(feature = "std"), no_std)]1819use erc::ERC721Events;20use evm_coder::ToLog;21use frame_support::{BoundedVec, ensure, fail};22use up_data_structs::{23 AccessMode, CollectionId, CustomDataLimit, TokenId, CreateCollectionData, CreateNftExData,24 mapping::TokenAddressMapping, NestingRule, budget::Budget, Property, PropertyPermission,25 PropertyKey, PropertyKeyPermission, Properties, TrySet,26};27use pallet_evm::{account::CrossAccountId, Pallet as PalletEvm};28use pallet_common::{29 Error as CommonError, Pallet as PalletCommon, Event as CommonEvent, CollectionHandle,30 dispatch::CollectionDispatch, eth::collection_id_to_address,31};32use pallet_structure::Pallet as PalletStructure;33use pallet_evm_coder_substrate::{SubstrateRecorder, WithRecorder};34use sp_core::H160;35use sp_runtime::{ArithmeticError, DispatchError, DispatchResult};36use sp_std::{vec::Vec, vec};37use core::ops::Deref;38use sp_std::collections::btree_map::BTreeMap;39use codec::{Encode, Decode, MaxEncodedLen};40use scale_info::TypeInfo;4142pub use pallet::*;43#[cfg(feature = "runtime-benchmarks")]44pub mod benchmarking;45pub mod common;46pub mod erc;47pub mod weights;4849pub type CreateItemData<T> = CreateNftExData<<T as pallet_evm::account::Config>::CrossAccountId>;50pub(crate) type SelfWeightOf<T> = <T as Config>::WeightInfo;5152#[struct_versioning::versioned(version = 2, upper)]53#[derive(Encode, Decode, TypeInfo, MaxEncodedLen)]54pub struct ItemData<CrossAccountId> {55 pub const_data: BoundedVec<u8, CustomDataLimit>,5657 #[version(..2)]58 pub variable_data: BoundedVec<u8, CustomDataLimit>,5960 pub owner: CrossAccountId,61}6263#[frame_support::pallet]64pub mod pallet {65 use super::*;66 use frame_support::{Blake2_128Concat, Twox64Concat, pallet_prelude::*, storage::Key, traits::StorageVersion};67 use frame_system::pallet_prelude::*;68 use up_data_structs::{CollectionId, TokenId};69 use super::weights::WeightInfo;7071 #[pallet::error]72 pub enum Error<T> {73 /// Not Nonfungible item data used to mint in Nonfungible collection.74 NotNonfungibleDataUsedToMintFungibleCollectionToken,75 /// Used amount > 1 with NFT76 NonfungibleItemsHaveNoAmount,77 }7879 #[pallet::config]80 pub trait Config:81 frame_system::Config + pallet_common::Config + pallet_structure::Config + pallet_evm::Config82 {83 type WeightInfo: WeightInfo;84 }8586 const STORAGE_VERSION: StorageVersion = StorageVersion::new(1);8788 #[pallet::pallet]89 #[pallet::storage_version(STORAGE_VERSION)]90 #[pallet::generate_store(pub(super) trait Store)]91 pub struct Pallet<T>(_);9293 #[pallet::storage]94 pub type TokensMinted<T: Config> =95 StorageMap<Hasher = Twox64Concat, Key = CollectionId, Value = u32, QueryKind = ValueQuery>;96 #[pallet::storage]97 pub type TokensBurnt<T: Config> =98 StorageMap<Hasher = Twox64Concat, Key = CollectionId, Value = u32, QueryKind = ValueQuery>;99100 #[pallet::storage]101 pub type TokenData<T: Config> = StorageNMap<102 Key = (Key<Twox64Concat, CollectionId>, Key<Twox64Concat, TokenId>),103 Value = ItemData<T::CrossAccountId>,104 QueryKind = OptionQuery,105 >;106107 #[pallet::storage]108 #[pallet::getter(fn token_properties)]109 pub type TokenProperties<T: Config> = StorageNMap<110 Key = (Key<Twox64Concat, CollectionId>, Key<Twox64Concat, TokenId>),111 Value = Properties,112 QueryKind = ValueQuery,113 OnEmpty = up_data_structs::TokenProperties,114 >;115116 /// Used to enumerate tokens owned by account117 #[pallet::storage]118 pub type Owned<T: Config> = StorageNMap<119 Key = (120 Key<Twox64Concat, CollectionId>,121 Key<Blake2_128Concat, T::CrossAccountId>,122 Key<Twox64Concat, TokenId>,123 ),124 Value = bool,125 QueryKind = ValueQuery,126 >;127128 #[pallet::storage]129 pub type AccountBalance<T: Config> = StorageNMap<130 Key = (131 Key<Twox64Concat, CollectionId>,132 Key<Blake2_128Concat, T::CrossAccountId>,133 ),134 Value = u32,135 QueryKind = ValueQuery,136 >;137138 #[pallet::storage]139 pub type Allowance<T: Config> = StorageNMap<140 Key = (Key<Twox64Concat, CollectionId>, Key<Twox64Concat, TokenId>),141 Value = T::CrossAccountId,142 QueryKind = OptionQuery,143 >;144145 #[pallet::hooks]146 impl<T: Config> Hooks<BlockNumberFor<T>> for Pallet<T> {147 fn on_runtime_upgrade() -> Weight {148 if StorageVersion::get::<Pallet<T>>() < StorageVersion::new(1) {149 <TokenData<T>>::translate_values::<ItemDataVersion1<T::CrossAccountId>, _>(|v| {150 Some(<ItemDataVersion2<T::CrossAccountId>>::from(v))151 })152 }153154 0155 }156 }157}158159pub struct NonfungibleHandle<T: Config>(pallet_common::CollectionHandle<T>);160impl<T: Config> NonfungibleHandle<T> {161 pub fn cast(inner: pallet_common::CollectionHandle<T>) -> Self {162 Self(inner)163 }164 pub fn into_inner(self) -> pallet_common::CollectionHandle<T> {165 self.0166 }167 pub fn common_mut(&mut self) -> &mut pallet_common::CollectionHandle<T> {168 &mut self.0169 }170}171impl<T: Config> WithRecorder<T> for NonfungibleHandle<T> {172 fn recorder(&self) -> &SubstrateRecorder<T> {173 self.0.recorder()174 }175 fn into_recorder(self) -> SubstrateRecorder<T> {176 self.0.into_recorder()177 }178}179impl<T: Config> Deref for NonfungibleHandle<T> {180 type Target = pallet_common::CollectionHandle<T>;181182 fn deref(&self) -> &Self::Target {183 &self.0184 }185}186187impl<T: Config> Pallet<T> {188 pub fn total_supply(collection: &NonfungibleHandle<T>) -> u32 {189 <TokensMinted<T>>::get(collection.id) - <TokensBurnt<T>>::get(collection.id)190 }191 pub fn token_exists(collection: &NonfungibleHandle<T>, token: TokenId) -> bool {192 <TokenData<T>>::contains_key((collection.id, token))193 }194}195196// unchecked calls skips any permission checks197impl<T: Config> Pallet<T> {198 pub fn init_collection(199 owner: T::AccountId,200 data: CreateCollectionData<T::AccountId>,201 ) -> Result<CollectionId, DispatchError> {202 <PalletCommon<T>>::init_collection(owner, data)203 }204 pub fn destroy_collection(205 collection: NonfungibleHandle<T>,206 sender: &T::CrossAccountId,207 ) -> DispatchResult {208 let id = collection.id;209210 // =========211212 PalletCommon::destroy_collection(collection.0, sender)?;213214 <TokenData<T>>::remove_prefix((id,), None);215 <Owned<T>>::remove_prefix((id,), None);216 <TokensMinted<T>>::remove(id);217 <TokensBurnt<T>>::remove(id);218 <Allowance<T>>::remove_prefix((id,), None);219 <AccountBalance<T>>::remove_prefix((id,), None);220 Ok(())221 }222223 pub fn burn(224 collection: &NonfungibleHandle<T>,225 sender: &T::CrossAccountId,226 token: TokenId,227 ) -> DispatchResult {228 let token_data =229 <TokenData<T>>::get((collection.id, token)).ok_or(<CommonError<T>>::TokenNotFound)?;230 ensure!(231 &token_data.owner == sender232 || (collection.limits.owner_can_transfer() && collection.is_owner_or_admin(sender)),233 <CommonError<T>>::NoPermission234 );235236 if collection.access == AccessMode::AllowList {237 collection.check_allowlist(sender)?;238 }239240 let burnt = <TokensBurnt<T>>::get(collection.id)241 .checked_add(1)242 .ok_or(ArithmeticError::Overflow)?;243244 let balance = <AccountBalance<T>>::get((collection.id, token_data.owner.clone()))245 .checked_sub(1)246 .ok_or(ArithmeticError::Overflow)?;247248 if balance == 0 {249 <AccountBalance<T>>::remove((collection.id, token_data.owner.clone()));250 } else {251 <AccountBalance<T>>::insert((collection.id, token_data.owner.clone()), balance);252 }253 // =========254255 <Owned<T>>::remove((collection.id, &token_data.owner, token));256 <TokensBurnt<T>>::insert(collection.id, burnt);257 <TokenData<T>>::remove((collection.id, token));258 let old_spender = <Allowance<T>>::take((collection.id, token));259260 if let Some(old_spender) = old_spender {261 <PalletCommon<T>>::deposit_event(CommonEvent::Approved(262 collection.id,263 token,264 sender.clone(),265 old_spender,266 0,267 ));268 }269270 <PalletEvm<T>>::deposit_log(271 ERC721Events::Transfer {272 from: *token_data.owner.as_eth(),273 to: H160::default(),274 token_id: token.into(),275 }276 .to_log(collection_id_to_address(collection.id)),277 );278 <PalletCommon<T>>::deposit_event(CommonEvent::ItemDestroyed(279 collection.id,280 token,281 token_data.owner,282 1,283 ));284 Ok(())285 }286287 pub fn set_token_property(288 collection: &NonfungibleHandle<T>,289 sender: &T::CrossAccountId,290 token_id: TokenId,291 property: Property,292 ) -> DispatchResult {293 Self::check_token_change_permission(collection, sender, token_id, &property.key)?;294295 <TokenProperties<T>>::try_mutate((collection.id, token_id), |properties| {296 let property = property.clone();297 properties.try_set(property.key, property.value)298 })299 .map_err(<CommonError<T>>::from)?;300301 <PalletCommon<T>>::deposit_event(CommonEvent::TokenPropertySet(302 collection.id,303 token_id,304 property.key,305 ));306307 Ok(())308 }309310 pub fn set_token_properties(311 collection: &NonfungibleHandle<T>,312 sender: &T::CrossAccountId,313 token_id: TokenId,314 properties: Vec<Property>,315 ) -> DispatchResult {316 for property in properties {317 Self::set_token_property(collection, sender, token_id, property)?;318 }319320 Ok(())321 }322323 pub fn delete_token_property(324 collection: &NonfungibleHandle<T>,325 sender: &T::CrossAccountId,326 token_id: TokenId,327 property_key: PropertyKey,328 ) -> DispatchResult {329 Self::check_token_change_permission(collection, sender, token_id, &property_key)?;330331 <TokenProperties<T>>::try_mutate((collection.id, token_id), |properties| {332 properties.remove(&property_key)333 })334 .map_err(<CommonError<T>>::from)?;335336 <PalletCommon<T>>::deposit_event(CommonEvent::TokenPropertyDeleted(337 collection.id,338 token_id,339 property_key,340 ));341342 Ok(())343 }344345 fn check_token_change_permission(346 collection: &NonfungibleHandle<T>,347 sender: &T::CrossAccountId,348 token_id: TokenId,349 property_key: &PropertyKey,350 ) -> DispatchResult {351 let permission = <PalletCommon<T>>::property_permissions(collection.id)352 .get(property_key)353 .map(|p| p.clone())354 .unwrap_or(PropertyPermission::none());355356 let token_data = <TokenData<T>>::get((collection.id, token_id))357 .ok_or(<CommonError<T>>::TokenNotFound)?;358359 let check_token_owner = || -> DispatchResult {360 ensure!(&token_data.owner == sender, <CommonError<T>>::NoPermission);361 Ok(())362 };363364 let is_property_exists = TokenProperties::<T>::get((collection.id, token_id))365 .get(property_key)366 .is_some();367368 match permission {369 PropertyPermission { mutable: false, .. } if is_property_exists => {370 Err(<CommonError<T>>::NoPermission.into())371 }372373 PropertyPermission {374 collection_admin,375 token_owner,376 ..377 } => {378 let mut check_result = Err(<CommonError<T>>::NoPermission.into());379380 if collection_admin {381 check_result = collection.check_is_owner_or_admin(sender);382 }383384 if token_owner {385 check_result.or_else(|_| check_token_owner())386 } else {387 check_result388 }389 }390 }391 }392393 pub fn delete_token_properties(394 collection: &NonfungibleHandle<T>,395 sender: &T::CrossAccountId,396 token_id: TokenId,397 property_keys: Vec<PropertyKey>,398 ) -> DispatchResult {399 for key in property_keys {400 Self::delete_token_property(collection, sender, token_id, key)?;401 }402403 Ok(())404 }405406 pub fn set_collection_properties(407 collection: &NonfungibleHandle<T>,408 sender: &T::CrossAccountId,409 properties: Vec<Property>,410 ) -> DispatchResult {411 <PalletCommon<T>>::set_collection_properties(collection, sender, properties)412 }413414 pub fn delete_collection_properties(415 collection: &CollectionHandle<T>,416 sender: &T::CrossAccountId,417 property_keys: Vec<PropertyKey>,418 ) -> DispatchResult {419 <PalletCommon<T>>::delete_collection_properties(collection, sender, property_keys)420 }421422 pub fn set_property_permissions(423 collection: &CollectionHandle<T>,424 sender: &T::CrossAccountId,425 property_permissions: Vec<PropertyKeyPermission>,426 ) -> DispatchResult {427 <PalletCommon<T>>::set_property_permissions(collection, sender, property_permissions)428 }429430 pub fn transfer(431 collection: &NonfungibleHandle<T>,432 from: &T::CrossAccountId,433 to: &T::CrossAccountId,434 token: TokenId,435 nesting_budget: &dyn Budget,436 ) -> DispatchResult {437 ensure!(438 collection.limits.transfers_enabled(),439 <CommonError<T>>::TransferNotAllowed440 );441442 let token_data =443 <TokenData<T>>::get((collection.id, token)).ok_or(<CommonError<T>>::TokenNotFound)?;444 // TODO: require sender to be token, owner, require admins to go through transfer_from445 ensure!(446 &token_data.owner == from447 || (collection.limits.owner_can_transfer() && collection.is_owner_or_admin(from)),448 <CommonError<T>>::NoPermission449 );450451 if collection.access == AccessMode::AllowList {452 collection.check_allowlist(from)?;453 collection.check_allowlist(to)?;454 }455 <PalletCommon<T>>::ensure_correct_receiver(to)?;456457 let balance_from = <AccountBalance<T>>::get((collection.id, from))458 .checked_sub(1)459 .ok_or(<CommonError<T>>::TokenValueTooLow)?;460 let balance_to = if from != to {461 let balance_to = <AccountBalance<T>>::get((collection.id, to))462 .checked_add(1)463 .ok_or(ArithmeticError::Overflow)?;464465 ensure!(466 balance_to < collection.limits.account_token_ownership_limit(),467 <CommonError<T>>::AccountTokenLimitExceeded,468 );469470 Some(balance_to)471 } else {472 None473 };474475 if let Some(target) = T::CrossTokenAddressMapping::address_to_token(to) {476 let handle = <CollectionHandle<T>>::try_get(target.0)?;477 let dispatch = T::CollectionDispatch::dispatch(handle);478 let dispatch = dispatch.as_dyn();479480 dispatch.check_nesting(481 from.clone(),482 (collection.id, token),483 target.1,484 nesting_budget,485 )?;486 }487488 // =========489490 <TokenData<T>>::insert(491 (collection.id, token),492 ItemData {493 owner: to.clone(),494 ..token_data495 },496 );497498 if let Some(balance_to) = balance_to {499 // from != to500 if balance_from == 0 {501 <AccountBalance<T>>::remove((collection.id, from));502 } else {503 <AccountBalance<T>>::insert((collection.id, from), balance_from);504 }505 <AccountBalance<T>>::insert((collection.id, to), balance_to);506 <Owned<T>>::remove((collection.id, from, token));507 <Owned<T>>::insert((collection.id, to, token), true);508 }509 Self::set_allowance_unchecked(collection, from, token, None, true);510511 <PalletEvm<T>>::deposit_log(512 ERC721Events::Transfer {513 from: *from.as_eth(),514 to: *to.as_eth(),515 token_id: token.into(),516 }517 .to_log(collection_id_to_address(collection.id)),518 );519 <PalletCommon<T>>::deposit_event(CommonEvent::Transfer(520 collection.id,521 token,522 from.clone(),523 to.clone(),524 1,525 ));526 Ok(())527 }528529 pub fn create_multiple_items(530 collection: &NonfungibleHandle<T>,531 sender: &T::CrossAccountId,532 data: Vec<CreateItemData<T>>,533 nesting_budget: &dyn Budget,534 ) -> DispatchResult {535 if !collection.is_owner_or_admin(sender) {536 ensure!(537 collection.mint_mode,538 <CommonError<T>>::PublicMintingNotAllowed539 );540 collection.check_allowlist(sender)?;541542 for item in data.iter() {543 collection.check_allowlist(&item.owner)?;544 }545 }546547 for data in data.iter() {548 <PalletCommon<T>>::ensure_correct_receiver(&data.owner)?;549 }550551 let first_token = <TokensMinted<T>>::get(collection.id);552 let tokens_minted = first_token553 .checked_add(data.len() as u32)554 .ok_or(ArithmeticError::Overflow)?;555 ensure!(556 tokens_minted <= collection.limits.token_limit(),557 <CommonError<T>>::CollectionTokenLimitExceeded558 );559560 let mut balances = BTreeMap::new();561 for data in &data {562 let balance = balances563 .entry(&data.owner)564 .or_insert_with(|| <AccountBalance<T>>::get((collection.id, &data.owner)));565 *balance = balance.checked_add(1).ok_or(ArithmeticError::Overflow)?;566567 ensure!(568 *balance <= collection.limits.account_token_ownership_limit(),569 <CommonError<T>>::AccountTokenLimitExceeded,570 );571 }572573 for (i, data) in data.iter().enumerate() {574 let token = TokenId(first_token + i as u32 + 1);575 if let Some(target) = T::CrossTokenAddressMapping::address_to_token(&data.owner) {576 let handle = <CollectionHandle<T>>::try_get(target.0)?;577 let dispatch = T::CollectionDispatch::dispatch(handle);578 let dispatch = dispatch.as_dyn();579 dispatch.check_nesting(580 sender.clone(),581 (collection.id, token),582 target.1,583 nesting_budget,584 )?;585 }586 }587588 // =========589590 <TokensMinted<T>>::insert(collection.id, tokens_minted);591 for (account, balance) in balances {592 <AccountBalance<T>>::insert((collection.id, account), balance);593 }594 for (i, data) in data.into_iter().enumerate() {595 let token = first_token + i as u32 + 1;596597 <TokenData<T>>::insert(598 (collection.id, token),599 ItemData {600 const_data: data.const_data,601 owner: data.owner.clone(),602 },603 );604 <Owned<T>>::insert((collection.id, &data.owner, token), true);605606 Self::set_token_properties(607 collection,608 sender,609 TokenId(token),610 data.properties.into_inner(),611 )?;612613 <PalletEvm<T>>::deposit_log(614 ERC721Events::Transfer {615 from: H160::default(),616 to: *data.owner.as_eth(),617 token_id: token.into(),618 }619 .to_log(collection_id_to_address(collection.id)),620 );621 <PalletCommon<T>>::deposit_event(CommonEvent::ItemCreated(622 collection.id,623 TokenId(token),624 data.owner.clone(),625 1,626 ));627 }628 Ok(())629 }630631 pub fn set_allowance_unchecked(632 collection: &NonfungibleHandle<T>,633 sender: &T::CrossAccountId,634 token: TokenId,635 spender: Option<&T::CrossAccountId>,636 assume_implicit_eth: bool,637 ) {638 if let Some(spender) = spender {639 let old_spender = <Allowance<T>>::get((collection.id, token));640 <Allowance<T>>::insert((collection.id, token), spender);641 // In ERC721 there is only one possible approved user of token, so we set642 // approved user to spender643 <PalletEvm<T>>::deposit_log(644 ERC721Events::Approval {645 owner: *sender.as_eth(),646 approved: *spender.as_eth(),647 token_id: token.into(),648 }649 .to_log(collection_id_to_address(collection.id)),650 );651 // In Unique chain, any token can have any amount of approved users, so we need to652 // set allowance of old owner to 0, and allowance of new owner to 1653 if old_spender.as_ref() != Some(spender) {654 if let Some(old_owner) = old_spender {655 <PalletCommon<T>>::deposit_event(CommonEvent::Approved(656 collection.id,657 token,658 sender.clone(),659 old_owner,660 0,661 ));662 }663 <PalletCommon<T>>::deposit_event(CommonEvent::Approved(664 collection.id,665 token,666 sender.clone(),667 spender.clone(),668 1,669 ));670 }671 } else {672 let old_spender = <Allowance<T>>::take((collection.id, token));673 if !assume_implicit_eth {674 // In ERC721 there is only one possible approved user of token, so we set675 // approved user to zero address676 <PalletEvm<T>>::deposit_log(677 ERC721Events::Approval {678 owner: *sender.as_eth(),679 approved: H160::default(),680 token_id: token.into(),681 }682 .to_log(collection_id_to_address(collection.id)),683 );684 }685 // In Unique chain, any token can have any amount of approved users, so we need to686 // set allowance of old owner to 0687 if let Some(old_spender) = old_spender {688 <PalletCommon<T>>::deposit_event(CommonEvent::Approved(689 collection.id,690 token,691 sender.clone(),692 old_spender,693 0,694 ));695 }696 }697 }698699 pub fn set_allowance(700 collection: &NonfungibleHandle<T>,701 sender: &T::CrossAccountId,702 token: TokenId,703 spender: Option<&T::CrossAccountId>,704 ) -> DispatchResult {705 if collection.access == AccessMode::AllowList {706 collection.check_allowlist(sender)?;707 if let Some(spender) = spender {708 collection.check_allowlist(spender)?;709 }710 }711712 if let Some(spender) = spender {713 <PalletCommon<T>>::ensure_correct_receiver(spender)?;714 }715 let token_data =716 <TokenData<T>>::get((collection.id, token)).ok_or(<CommonError<T>>::TokenNotFound)?;717 if &token_data.owner != sender {718 ensure!(719 collection.ignores_owned_amount(sender),720 <CommonError<T>>::CantApproveMoreThanOwned721 );722 }723724 // =========725726 Self::set_allowance_unchecked(collection, sender, token, spender, false);727 Ok(())728 }729730 fn check_allowed(731 collection: &NonfungibleHandle<T>,732 spender: &T::CrossAccountId,733 from: &T::CrossAccountId,734 token: TokenId,735 nesting_budget: &dyn Budget,736 ) -> DispatchResult {737 if spender.conv_eq(from) {738 return Ok(());739 }740 if collection.access == AccessMode::AllowList {741 // `from`, `to` checked in [`transfer`]742 collection.check_allowlist(spender)?;743 }744 if let Some(source) = T::CrossTokenAddressMapping::address_to_token(from) {745 // TODO: should collection owner be allowed to perform this transfer?746 ensure!(747 <PalletStructure<T>>::check_indirectly_owned(748 spender.clone(),749 source.0,750 source.1,751 None,752 nesting_budget753 )?,754 <CommonError<T>>::ApprovedValueTooLow,755 );756 return Ok(());757 }758 if <Allowance<T>>::get((collection.id, token)).as_ref() == Some(spender) {759 return Ok(());760 }761 ensure!(762 collection.ignores_allowance(spender),763 <CommonError<T>>::ApprovedValueTooLow764 );765 Ok(())766 }767768 pub fn transfer_from(769 collection: &NonfungibleHandle<T>,770 spender: &T::CrossAccountId,771 from: &T::CrossAccountId,772 to: &T::CrossAccountId,773 token: TokenId,774 nesting_budget: &dyn Budget,775 ) -> DispatchResult {776 Self::check_allowed(collection, spender, from, token, nesting_budget)?;777778 // =========779780 // Allowance is reset in [`transfer`]781 Self::transfer(collection, from, to, token, nesting_budget)782 }783784 pub fn burn_from(785 collection: &NonfungibleHandle<T>,786 spender: &T::CrossAccountId,787 from: &T::CrossAccountId,788 token: TokenId,789 nesting_budget: &dyn Budget,790 ) -> DispatchResult {791 Self::check_allowed(collection, spender, from, token, nesting_budget)?;792793 // =========794795 Self::burn(collection, from, token)796 }797798 pub fn check_nesting(799 handle: &NonfungibleHandle<T>,800 sender: T::CrossAccountId,801 from: (CollectionId, TokenId),802 under: TokenId,803 nesting_budget: &dyn Budget,804 ) -> DispatchResult {805 fn ensure_sender_allowed<T: Config>(806 collection: CollectionId,807 token: TokenId,808 for_nest: (CollectionId, TokenId),809 sender: T::CrossAccountId,810 budget: &dyn Budget,811 ) -> DispatchResult {812 ensure!(813 <PalletStructure<T>>::check_indirectly_owned(814 sender,815 collection,816 token,817 Some(for_nest),818 budget819 )?,820 <CommonError<T>>::OnlyOwnerAllowedToNest,821 );822 Ok(())823 }824 match handle.limits.nesting_rule() {825 NestingRule::Disabled => fail!(<CommonError<T>>::NestingIsDisabled),826 NestingRule::Owner => {827 ensure_sender_allowed::<T>(handle.id, under, from, sender, nesting_budget)?828 }829 NestingRule::OwnerRestricted(whitelist) => {830 ensure!(831 whitelist.contains(&from.0),832 <CommonError<T>>::SourceCollectionIsNotAllowedToNest833 );834 ensure_sender_allowed::<T>(handle.id, under, from, sender, nesting_budget)?835 }836 }837 Ok(())838 }839840 /// Delegated to `create_multiple_items`841 pub fn create_item(842 collection: &NonfungibleHandle<T>,843 sender: &T::CrossAccountId,844 data: CreateItemData<T>,845 nesting_budget: &dyn Budget,846 ) -> DispatchResult {847 Self::create_multiple_items(collection, sender, vec![data], nesting_budget)848 }849}