difftreelog
Merge pull request #542 from UniqueNetwork/fix/RFT_and_fractionalizer
in: master
14 files changed
pallets/refungible/src/benchmarking.rsdiffbeforeafterboth--- a/pallets/refungible/src/benchmarking.rs
+++ b/pallets/refungible/src/benchmarking.rs
@@ -281,15 +281,6 @@
let item = create_max_item(&collection, &sender, [(owner.clone(), 100)])?;
}: {<Pallet<T>>::repartition(&collection, &owner, item, 200)?}
- set_parent_nft_unchecked {
- bench_init!{
- owner: sub; collection: collection(owner);
- sender: cross_from_sub(owner); owner: cross_sub;
- };
- let item = create_max_item(&collection, &sender, [(owner.clone(), 100)])?;
-
- }: {<Pallet<T>>::set_parent_nft_unchecked(&collection, item, owner, T::CrossAccountId::from_eth(H160::default()))?}
-
token_owner {
bench_init!{
owner: sub; collection: collection(owner);
pallets/refungible/src/erc_token.rsdiffbeforeafterboth1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617//! # Refungible Pallet EVM API for token pieces18//!19//! Provides ERC-20 standart support implementation and EVM API for unique extensions for Refungible Pallet.20//! Method implementations are mostly doing parameter conversion and calling Nonfungible Pallet methods.2122extern crate alloc;2324#[cfg(not(feature = "std"))]25use alloc::format;2627use core::{28 char::{REPLACEMENT_CHARACTER, decode_utf16},29 convert::TryInto,30 ops::Deref,31};32use evm_coder::{ToLog, execution::*, generate_stubgen, solidity, solidity_interface, types::*, weight};33use pallet_common::{34 CommonWeightInfo,35 erc::{CommonEvmHandler, PrecompileResult, static_property::key},36 eth::map_eth_to_id,37};38use pallet_evm::{account::CrossAccountId, PrecompileHandle};39use pallet_evm_coder_substrate::{call, dispatch_to_evm, WithRecorder};40use pallet_structure::{SelfWeightOf as StructureWeight, weights::WeightInfo as _};41use sp_core::H160;42use sp_std::vec::Vec;43use up_data_structs::{mapping::TokenAddressMapping, PropertyScope, TokenId};4445use crate::{46 Allowance, Balance, common::CommonWeights, Config, Pallet, RefungibleHandle, SelfWeightOf,47 TokenProperties, TotalSupply, weights::WeightInfo,48};4950pub struct RefungibleTokenHandle<T: Config>(pub RefungibleHandle<T>, pub TokenId);5152#[solidity_interface(name = ERC1633)]53impl<T: Config> RefungibleTokenHandle<T> {54 fn parent_token(&self) -> Result<address> {55 self.consume_store_reads(2)?;56 let props = <TokenProperties<T>>::get((self.id, self.1));57 let key = key::parent_nft();5859 let key_scoped = PropertyScope::Eth60 .apply(key)61 .expect("property key shouldn't exceed length limit");62 if let Some(value) = props.get(&key_scoped) {63 Ok(H160::from_slice(value.as_slice()))64 } else {65 Ok(*T::CrossTokenAddressMapping::token_to_address(self.id, self.1).as_eth())66 }67 }6869 fn parent_token_id(&self) -> Result<uint256> {70 self.consume_store_reads(2)?;71 let props = <TokenProperties<T>>::get((self.id, self.1));72 let key = key::parent_nft();7374 let key_scoped = PropertyScope::Eth75 .apply(key)76 .expect("property key shouldn't exceed length limit");77 if let Some(value) = props.get(&key_scoped) {78 let nft_token_address = H160::from_slice(value.as_slice());79 let nft_token_account = T::CrossAccountId::from_eth(nft_token_address);80 let (_, token_id) = T::CrossTokenAddressMapping::address_to_token(&nft_token_account)81 .ok_or("parent NFT should contain NFT token address")?;8283 Ok(token_id.into())84 } else {85 Ok(self.1.into())86 }87 }88}8990#[solidity_interface(name = ERC1633UniqueExtensions)]91impl<T: Config> RefungibleTokenHandle<T> {92 #[solidity(rename_selector = "setParentNFT")]93 #[weight(<CommonWeights<T>>::token_owner() + <SelfWeightOf<T>>::set_parent_nft_unchecked())]94 fn set_parent_nft(95 &mut self,96 caller: caller,97 collection: address,98 nft_id: uint256,99 ) -> Result<bool> {100 self.consume_store_reads(1)?;101 let caller = T::CrossAccountId::from_eth(caller);102 let nft_collection = map_eth_to_id(&collection).ok_or("collection not found")?;103 let nft_token = nft_id.try_into()?;104105 <Pallet<T>>::set_parent_nft(&self.0, self.1, caller, nft_collection, nft_token)106 .map_err(dispatch_to_evm::<T>)?;107108 Ok(true)109 }110}111112#[derive(ToLog)]113pub enum ERC20Events {114 /// @dev This event is emitted when the amount of tokens (value) is sent115 /// from the from address to the to address. In the case of minting new116 /// tokens, the transfer is usually from the 0 address while in the case117 /// of burning tokens the transfer is to 0.118 Transfer {119 #[indexed]120 from: address,121 #[indexed]122 to: address,123 value: uint256,124 },125 /// @dev This event is emitted when the amount of tokens (value) is approved126 /// by the owner to be used by the spender.127 Approval {128 #[indexed]129 owner: address,130 #[indexed]131 spender: address,132 value: uint256,133 },134}135136/// @title Standard ERC20 token137///138/// @dev Implementation of the basic standard token.139/// https://github.com/ethereum/EIPs/blob/master/EIPS/eip-20.md140#[solidity_interface(name = ERC20, events(ERC20Events))]141impl<T: Config> RefungibleTokenHandle<T> {142 /// @return the name of the token.143 fn name(&self) -> Result<string> {144 Ok(decode_utf16(self.name.iter().copied())145 .map(|r| r.unwrap_or(REPLACEMENT_CHARACTER))146 .collect::<string>())147 }148149 /// @return the symbol of the token.150 fn symbol(&self) -> Result<string> {151 Ok(string::from_utf8_lossy(&self.token_prefix).into())152 }153154 /// @dev Total number of tokens in existence155 fn total_supply(&self) -> Result<uint256> {156 self.consume_store_reads(1)?;157 Ok(<TotalSupply<T>>::get((self.id, self.1)).into())158 }159160 /// @dev Not supported161 fn decimals(&self) -> Result<uint8> {162 // Decimals aren't supported for refungible tokens163 Ok(0)164 }165166 /// @dev Gets the balance of the specified address.167 /// @param owner The address to query the balance of.168 /// @return An uint256 representing the amount owned by the passed address.169 fn balance_of(&self, owner: address) -> Result<uint256> {170 self.consume_store_reads(1)?;171 let owner = T::CrossAccountId::from_eth(owner);172 let balance = <Balance<T>>::get((self.id, self.1, owner));173 Ok(balance.into())174 }175176 /// @dev Transfer token for a specified address177 /// @param to The address to transfer to.178 /// @param amount The amount to be transferred.179 #[weight(<CommonWeights<T>>::transfer())]180 fn transfer(&mut self, caller: caller, to: address, amount: uint256) -> Result<bool> {181 let caller = T::CrossAccountId::from_eth(caller);182 let to = T::CrossAccountId::from_eth(to);183 let amount = amount.try_into().map_err(|_| "amount overflow")?;184 let budget = self185 .recorder186 .weight_calls_budget(<StructureWeight<T>>::find_parent());187188 <Pallet<T>>::transfer(self, &caller, &to, self.1, amount, &budget)189 .map_err(dispatch_to_evm::<T>)?;190 Ok(true)191 }192193 /// @dev Transfer tokens from one address to another194 /// @param from address The address which you want to send tokens from195 /// @param to address The address which you want to transfer to196 /// @param amount uint256 the amount of tokens to be transferred197 #[weight(<CommonWeights<T>>::transfer_from())]198 fn transfer_from(199 &mut self,200 caller: caller,201 from: address,202 to: address,203 amount: uint256,204 ) -> Result<bool> {205 let caller = T::CrossAccountId::from_eth(caller);206 let from = T::CrossAccountId::from_eth(from);207 let to = T::CrossAccountId::from_eth(to);208 let amount = amount.try_into().map_err(|_| "amount overflow")?;209 let budget = self210 .recorder211 .weight_calls_budget(<StructureWeight<T>>::find_parent());212213 <Pallet<T>>::transfer_from(self, &caller, &from, &to, self.1, amount, &budget)214 .map_err(dispatch_to_evm::<T>)?;215 Ok(true)216 }217218 /// @dev Approve the passed address to spend the specified amount of tokens on behalf of `msg.sender`.219 /// Beware that changing an allowance with this method brings the risk that someone may use both the old220 /// and the new allowance by unfortunate transaction ordering. One possible solution to mitigate this221 /// race condition is to first reduce the spender's allowance to 0 and set the desired value afterwards:222 /// https://github.com/ethereum/EIPs/issues/20#issuecomment-263524729223 /// @param spender The address which will spend the funds.224 /// @param amount The amount of tokens to be spent.225 #[weight(<SelfWeightOf<T>>::approve())]226 fn approve(&mut self, caller: caller, spender: address, amount: uint256) -> Result<bool> {227 let caller = T::CrossAccountId::from_eth(caller);228 let spender = T::CrossAccountId::from_eth(spender);229 let amount = amount.try_into().map_err(|_| "amount overflow")?;230231 <Pallet<T>>::set_allowance(self, &caller, &spender, self.1, amount)232 .map_err(dispatch_to_evm::<T>)?;233 Ok(true)234 }235236 /// @dev Function to check the amount of tokens that an owner allowed to a spender.237 /// @param owner address The address which owns the funds.238 /// @param spender address The address which will spend the funds.239 /// @return A uint256 specifying the amount of tokens still available for the spender.240 fn allowance(&self, owner: address, spender: address) -> Result<uint256> {241 self.consume_store_reads(1)?;242 let owner = T::CrossAccountId::from_eth(owner);243 let spender = T::CrossAccountId::from_eth(spender);244245 Ok(<Allowance<T>>::get((self.id, self.1, owner, spender)).into())246 }247}248249#[solidity_interface(name = ERC20UniqueExtensions)]250impl<T: Config> RefungibleTokenHandle<T> {251 /// @dev Function that burns an amount of the token of a given account,252 /// deducting from the sender's allowance for said account.253 /// @param from The account whose tokens will be burnt.254 /// @param amount The amount that will be burnt.255 #[weight(<SelfWeightOf<T>>::burn_from())]256 fn burn_from(&mut self, caller: caller, from: address, amount: uint256) -> Result<bool> {257 let caller = T::CrossAccountId::from_eth(caller);258 let from = T::CrossAccountId::from_eth(from);259 let amount = amount.try_into().map_err(|_| "amount overflow")?;260 let budget = self261 .recorder262 .weight_calls_budget(<StructureWeight<T>>::find_parent());263264 <Pallet<T>>::burn_from(self, &caller, &from, self.1, amount, &budget)265 .map_err(dispatch_to_evm::<T>)?;266 Ok(true)267 }268269 /// @dev Function that changes total amount of the tokens.270 /// Throws if `msg.sender` doesn't owns all of the tokens.271 /// @param amount New total amount of the tokens.272 #[weight(<SelfWeightOf<T>>::repartition_item())]273 fn repartition(&mut self, caller: caller, amount: uint256) -> Result<bool> {274 let caller = T::CrossAccountId::from_eth(caller);275 let amount = amount.try_into().map_err(|_| "amount overflow")?;276277 <Pallet<T>>::repartition(self, &caller, self.1, amount).map_err(dispatch_to_evm::<T>)?;278 Ok(true)279 }280}281282impl<T: Config> RefungibleTokenHandle<T> {283 pub fn into_inner(self) -> RefungibleHandle<T> {284 self.0285 }286 pub fn common_mut(&mut self) -> &mut RefungibleHandle<T> {287 &mut self.0288 }289}290291impl<T: Config> WithRecorder<T> for RefungibleTokenHandle<T> {292 fn recorder(&self) -> &pallet_evm_coder_substrate::SubstrateRecorder<T> {293 self.0.recorder()294 }295 fn into_recorder(self) -> pallet_evm_coder_substrate::SubstrateRecorder<T> {296 self.0.into_recorder()297 }298}299300impl<T: Config> Deref for RefungibleTokenHandle<T> {301 type Target = RefungibleHandle<T>;302303 fn deref(&self) -> &Self::Target {304 &self.0305 }306}307308#[solidity_interface(309 name = UniqueRefungibleToken,310 is(ERC20, ERC20UniqueExtensions, ERC1633, ERC1633UniqueExtensions)311)]312impl<T: Config> RefungibleTokenHandle<T> where T::AccountId: From<[u8; 32]> {}313314generate_stubgen!(gen_impl, UniqueRefungibleTokenCall<()>, true);315generate_stubgen!(gen_iface, UniqueRefungibleTokenCall<()>, false);316317impl<T: Config> CommonEvmHandler for RefungibleTokenHandle<T>318where319 T::AccountId: From<[u8; 32]>,320{321 const CODE: &'static [u8] = include_bytes!("./stubs/UniqueRefungibleToken.raw");322323 fn call(self, handle: &mut impl PrecompileHandle) -> Option<PrecompileResult> {324 call::<T, UniqueRefungibleTokenCall<T>, _, _>(handle, self)325 }326}1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617//! # Refungible Pallet EVM API for token pieces18//!19//! Provides ERC-20 standart support implementation and EVM API for unique extensions for Refungible Pallet.20//! Method implementations are mostly doing parameter conversion and calling Nonfungible Pallet methods.2122extern crate alloc;2324#[cfg(not(feature = "std"))]25use alloc::format;2627use core::{28 char::{REPLACEMENT_CHARACTER, decode_utf16},29 convert::TryInto,30 ops::Deref,31};32use evm_coder::{ToLog, execution::*, generate_stubgen, solidity_interface, types::*, weight};33use pallet_common::{34 CommonWeightInfo,35 erc::{CommonEvmHandler, PrecompileResult},36 eth::collection_id_to_address,37};38use pallet_evm::{account::CrossAccountId, PrecompileHandle};39use pallet_evm_coder_substrate::{call, dispatch_to_evm, WithRecorder};40use pallet_structure::{SelfWeightOf as StructureWeight, weights::WeightInfo as _};41use sp_std::vec::Vec;42use up_data_structs::TokenId;4344use crate::{45 Allowance, Balance, common::CommonWeights, Config, Pallet, RefungibleHandle, SelfWeightOf,46 TotalSupply, weights::WeightInfo,47};4849pub struct RefungibleTokenHandle<T: Config>(pub RefungibleHandle<T>, pub TokenId);5051#[solidity_interface(name = ERC1633)]52impl<T: Config> RefungibleTokenHandle<T> {53 fn parent_token(&self) -> Result<address> {54 Ok(collection_id_to_address(self.id))55 }5657 fn parent_token_id(&self) -> Result<uint256> {58 Ok(self.1.into())59 }60}6162#[derive(ToLog)]63pub enum ERC20Events {64 /// @dev This event is emitted when the amount of tokens (value) is sent65 /// from the from address to the to address. In the case of minting new66 /// tokens, the transfer is usually from the 0 address while in the case67 /// of burning tokens the transfer is to 0.68 Transfer {69 #[indexed]70 from: address,71 #[indexed]72 to: address,73 value: uint256,74 },75 /// @dev This event is emitted when the amount of tokens (value) is approved76 /// by the owner to be used by the spender.77 Approval {78 #[indexed]79 owner: address,80 #[indexed]81 spender: address,82 value: uint256,83 },84}8586/// @title Standard ERC20 token87///88/// @dev Implementation of the basic standard token.89/// https://github.com/ethereum/EIPs/blob/master/EIPS/eip-20.md90#[solidity_interface(name = ERC20, events(ERC20Events))]91impl<T: Config> RefungibleTokenHandle<T> {92 /// @return the name of the token.93 fn name(&self) -> Result<string> {94 Ok(decode_utf16(self.name.iter().copied())95 .map(|r| r.unwrap_or(REPLACEMENT_CHARACTER))96 .collect::<string>())97 }9899 /// @return the symbol of the token.100 fn symbol(&self) -> Result<string> {101 Ok(string::from_utf8_lossy(&self.token_prefix).into())102 }103104 /// @dev Total number of tokens in existence105 fn total_supply(&self) -> Result<uint256> {106 self.consume_store_reads(1)?;107 Ok(<TotalSupply<T>>::get((self.id, self.1)).into())108 }109110 /// @dev Not supported111 fn decimals(&self) -> Result<uint8> {112 // Decimals aren't supported for refungible tokens113 Ok(0)114 }115116 /// @dev Gets the balance of the specified address.117 /// @param owner The address to query the balance of.118 /// @return An uint256 representing the amount owned by the passed address.119 fn balance_of(&self, owner: address) -> Result<uint256> {120 self.consume_store_reads(1)?;121 let owner = T::CrossAccountId::from_eth(owner);122 let balance = <Balance<T>>::get((self.id, self.1, owner));123 Ok(balance.into())124 }125126 /// @dev Transfer token for a specified address127 /// @param to The address to transfer to.128 /// @param amount The amount to be transferred.129 #[weight(<CommonWeights<T>>::transfer())]130 fn transfer(&mut self, caller: caller, to: address, amount: uint256) -> Result<bool> {131 let caller = T::CrossAccountId::from_eth(caller);132 let to = T::CrossAccountId::from_eth(to);133 let amount = amount.try_into().map_err(|_| "amount overflow")?;134 let budget = self135 .recorder136 .weight_calls_budget(<StructureWeight<T>>::find_parent());137138 <Pallet<T>>::transfer(self, &caller, &to, self.1, amount, &budget)139 .map_err(dispatch_to_evm::<T>)?;140 Ok(true)141 }142143 /// @dev Transfer tokens from one address to another144 /// @param from address The address which you want to send tokens from145 /// @param to address The address which you want to transfer to146 /// @param amount uint256 the amount of tokens to be transferred147 #[weight(<CommonWeights<T>>::transfer_from())]148 fn transfer_from(149 &mut self,150 caller: caller,151 from: address,152 to: address,153 amount: uint256,154 ) -> Result<bool> {155 let caller = T::CrossAccountId::from_eth(caller);156 let from = T::CrossAccountId::from_eth(from);157 let to = T::CrossAccountId::from_eth(to);158 let amount = amount.try_into().map_err(|_| "amount overflow")?;159 let budget = self160 .recorder161 .weight_calls_budget(<StructureWeight<T>>::find_parent());162163 <Pallet<T>>::transfer_from(self, &caller, &from, &to, self.1, amount, &budget)164 .map_err(dispatch_to_evm::<T>)?;165 Ok(true)166 }167168 /// @dev Approve the passed address to spend the specified amount of tokens on behalf of `msg.sender`.169 /// Beware that changing an allowance with this method brings the risk that someone may use both the old170 /// and the new allowance by unfortunate transaction ordering. One possible solution to mitigate this171 /// race condition is to first reduce the spender's allowance to 0 and set the desired value afterwards:172 /// https://github.com/ethereum/EIPs/issues/20#issuecomment-263524729173 /// @param spender The address which will spend the funds.174 /// @param amount The amount of tokens to be spent.175 #[weight(<SelfWeightOf<T>>::approve())]176 fn approve(&mut self, caller: caller, spender: address, amount: uint256) -> Result<bool> {177 let caller = T::CrossAccountId::from_eth(caller);178 let spender = T::CrossAccountId::from_eth(spender);179 let amount = amount.try_into().map_err(|_| "amount overflow")?;180181 <Pallet<T>>::set_allowance(self, &caller, &spender, self.1, amount)182 .map_err(dispatch_to_evm::<T>)?;183 Ok(true)184 }185186 /// @dev Function to check the amount of tokens that an owner allowed to a spender.187 /// @param owner address The address which owns the funds.188 /// @param spender address The address which will spend the funds.189 /// @return A uint256 specifying the amount of tokens still available for the spender.190 fn allowance(&self, owner: address, spender: address) -> Result<uint256> {191 self.consume_store_reads(1)?;192 let owner = T::CrossAccountId::from_eth(owner);193 let spender = T::CrossAccountId::from_eth(spender);194195 Ok(<Allowance<T>>::get((self.id, self.1, owner, spender)).into())196 }197}198199#[solidity_interface(name = ERC20UniqueExtensions)]200impl<T: Config> RefungibleTokenHandle<T> {201 /// @dev Function that burns an amount of the token of a given account,202 /// deducting from the sender's allowance for said account.203 /// @param from The account whose tokens will be burnt.204 /// @param amount The amount that will be burnt.205 #[weight(<SelfWeightOf<T>>::burn_from())]206 fn burn_from(&mut self, caller: caller, from: address, amount: uint256) -> Result<bool> {207 let caller = T::CrossAccountId::from_eth(caller);208 let from = T::CrossAccountId::from_eth(from);209 let amount = amount.try_into().map_err(|_| "amount overflow")?;210 let budget = self211 .recorder212 .weight_calls_budget(<StructureWeight<T>>::find_parent());213214 <Pallet<T>>::burn_from(self, &caller, &from, self.1, amount, &budget)215 .map_err(dispatch_to_evm::<T>)?;216 Ok(true)217 }218219 /// @dev Function that changes total amount of the tokens.220 /// Throws if `msg.sender` doesn't owns all of the tokens.221 /// @param amount New total amount of the tokens.222 #[weight(<SelfWeightOf<T>>::repartition_item())]223 fn repartition(&mut self, caller: caller, amount: uint256) -> Result<bool> {224 let caller = T::CrossAccountId::from_eth(caller);225 let amount = amount.try_into().map_err(|_| "amount overflow")?;226227 <Pallet<T>>::repartition(self, &caller, self.1, amount).map_err(dispatch_to_evm::<T>)?;228 Ok(true)229 }230}231232impl<T: Config> RefungibleTokenHandle<T> {233 pub fn into_inner(self) -> RefungibleHandle<T> {234 self.0235 }236 pub fn common_mut(&mut self) -> &mut RefungibleHandle<T> {237 &mut self.0238 }239}240241impl<T: Config> WithRecorder<T> for RefungibleTokenHandle<T> {242 fn recorder(&self) -> &pallet_evm_coder_substrate::SubstrateRecorder<T> {243 self.0.recorder()244 }245 fn into_recorder(self) -> pallet_evm_coder_substrate::SubstrateRecorder<T> {246 self.0.into_recorder()247 }248}249250impl<T: Config> Deref for RefungibleTokenHandle<T> {251 type Target = RefungibleHandle<T>;252253 fn deref(&self) -> &Self::Target {254 &self.0255 }256}257258#[solidity_interface(259 name = UniqueRefungibleToken,260 is(ERC20, ERC20UniqueExtensions, ERC1633)261)]262impl<T: Config> RefungibleTokenHandle<T> where T::AccountId: From<[u8; 32]> {}263264generate_stubgen!(gen_impl, UniqueRefungibleTokenCall<()>, true);265generate_stubgen!(gen_iface, UniqueRefungibleTokenCall<()>, false);266267impl<T: Config> CommonEvmHandler for RefungibleTokenHandle<T>268where269 T::AccountId: From<[u8; 32]>,270{271 const CODE: &'static [u8] = include_bytes!("./stubs/UniqueRefungibleToken.raw");272273 fn call(self, handle: &mut impl PrecompileHandle) -> Option<PrecompileResult> {274 call::<T, UniqueRefungibleTokenCall<T>, _, _>(handle, self)275 }276}pallets/refungible/src/lib.rsdiffbeforeafterboth--- a/pallets/refungible/src/lib.rs
+++ b/pallets/refungible/src/lib.rs
@@ -1379,68 +1379,4 @@
Some(res)
}
}
-
- /// Sets the NFT token as a parent for the RFT token
- ///
- /// Throws if `sender` is not the owner of the NFT token.
- /// Throws if `sender` is not the owner of all of the RFT token pieces.
- pub fn set_parent_nft(
- collection: &RefungibleHandle<T>,
- rft_token_id: TokenId,
- sender: T::CrossAccountId,
- nft_collection: CollectionId,
- nft_token: TokenId,
- ) -> DispatchResult {
- let handle = <CollectionHandle<T>>::try_get(nft_collection)?;
- if handle.mode != CollectionMode::NFT {
- return Err("Only NFT token could be parent to RFT".into());
- }
- let dispatch = T::CollectionDispatch::dispatch(handle);
- let dispatch = dispatch.as_dyn();
-
- let owner = dispatch.token_owner(nft_token).ok_or("owner not found")?;
- if owner != sender {
- return Err("Only owned token could be set as parent".into());
- }
-
- let nft_token_address =
- T::CrossTokenAddressMapping::token_to_address(nft_collection, nft_token);
-
- Self::set_parent_nft_unchecked(collection, rft_token_id, sender, nft_token_address)
- }
-
- /// Sets the NFT token as a parent for the RFT token
- ///
- /// `sender` should be the owner of the NFT token.
- /// Throws if `sender` is not the owner of all of the RFT token pieces.
- pub fn set_parent_nft_unchecked(
- collection: &RefungibleHandle<T>,
- rft_token_id: TokenId,
- sender: T::CrossAccountId,
- nft_token_address: T::CrossAccountId,
- ) -> DispatchResult {
- let owner_balance = <Balance<T>>::get((collection.id, rft_token_id, &sender));
- let total_supply = <TotalSupply<T>>::get((collection.id, rft_token_id));
- if total_supply != owner_balance {
- return Err("token has multiple owners".into());
- }
-
- let parent_nft_property_key = key::parent_nft();
-
- let parent_nft_property_value =
- property_value_from_bytes(&nft_token_address.as_eth().to_fixed_bytes())
- .expect("address should fit in value length limit");
-
- <Pallet<T>>::set_scoped_token_property(
- collection.id,
- rft_token_id,
- PropertyScope::Eth,
- Property {
- key: parent_nft_property_key,
- value: parent_nft_property_value,
- },
- )?;
-
- Ok(())
- }
}
pallets/refungible/src/stubs/UniqueRefungibleToken.rawdiffbeforeafterbothbinary blob — no preview
pallets/refungible/src/stubs/UniqueRefungibleToken.soldiffbeforeafterboth--- a/pallets/refungible/src/stubs/UniqueRefungibleToken.sol
+++ b/pallets/refungible/src/stubs/UniqueRefungibleToken.sol
@@ -21,22 +21,6 @@
}
}
-/// @dev the ERC-165 identifier for this interface is 0x042f1106
-contract ERC1633UniqueExtensions is Dummy, ERC165 {
- /// @dev EVM selector for this function is: 0x042f1106,
- /// or in textual repr: setParentNFT(address,uint256)
- function setParentNFT(address collection, uint256 nftId)
- public
- returns (bool)
- {
- require(false, stub_error);
- collection;
- nftId;
- dummy = 0;
- return false;
- }
-}
-
/// @dev the ERC-165 identifier for this interface is 0x5755c3f2
contract ERC1633 is Dummy, ERC165 {
/// @dev EVM selector for this function is: 0x80a54001,
@@ -222,6 +206,5 @@
ERC165,
ERC20,
ERC20UniqueExtensions,
- ERC1633,
- ERC1633UniqueExtensions
+ ERC1633
{}
pallets/refungible/src/weights.rsdiffbeforeafterboth--- a/pallets/refungible/src/weights.rs
+++ b/pallets/refungible/src/weights.rs
@@ -53,7 +53,6 @@
fn set_token_properties(b: u32, ) -> Weight;
fn delete_token_properties(b: u32, ) -> Weight;
fn repartition_item() -> Weight;
- fn set_parent_nft_unchecked() -> Weight;
fn token_owner() -> Weight;
}
@@ -254,14 +253,6 @@
(22_356_000 as Weight)
.saturating_add(T::DbWeight::get().reads(2 as Weight))
.saturating_add(T::DbWeight::get().writes(2 as Weight))
- }
- // Storage: Refungible Balance (r:1 w:0)
- // Storage: Refungible TotalSupply (r:1 w:0)
- // Storage: Refungible TokenProperties (r:1 w:1)
- fn set_parent_nft_unchecked() -> Weight {
- (12_015_000 as Weight)
- .saturating_add(T::DbWeight::get().reads(3 as Weight))
- .saturating_add(T::DbWeight::get().writes(1 as Weight))
}
// Storage: Refungible Balance (r:2 w:0)
fn token_owner() -> Weight {
@@ -466,14 +457,6 @@
(22_356_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(2 as Weight))
.saturating_add(RocksDbWeight::get().writes(2 as Weight))
- }
- // Storage: Refungible Balance (r:1 w:0)
- // Storage: Refungible TotalSupply (r:1 w:0)
- // Storage: Refungible TokenProperties (r:1 w:1)
- fn set_parent_nft_unchecked() -> Weight {
- (12_015_000 as Weight)
- .saturating_add(RocksDbWeight::get().reads(3 as Weight))
- .saturating_add(RocksDbWeight::get().writes(1 as Weight))
}
// Storage: Refungible Balance (r:2 w:0)
fn token_owner() -> Weight {
pallets/unique/src/eth/mod.rsdiffbeforeafterboth--- a/pallets/unique/src/eth/mod.rs
+++ b/pallets/unique/src/eth/mod.rs
@@ -154,17 +154,6 @@
Ok(data)
}
-fn parent_nft_property_permissions() -> PropertyKeyPermission {
- PropertyKeyPermission {
- key: key::parent_nft(),
- permission: PropertyPermission {
- mutable: false,
- collection_admin: false,
- token_owner: true,
- },
- }
-}
-
fn create_refungible_collection_internal<
T: Config + pallet_nonfungible::Config + pallet_refungible::Config,
>(
@@ -188,16 +177,6 @@
let collection_id = T::CollectionDispatch::create(caller.clone(), data)
.map_err(pallet_evm_coder_substrate::dispatch_to_evm::<T>)?;
-
- let handle = <CollectionHandle<T>>::try_get(collection_id).map_err(dispatch_to_evm::<T>)?;
- <PalletCommon<T>>::set_scoped_token_property_permissions(
- &handle,
- &caller,
- PropertyScope::Eth,
- vec![parent_nft_property_permissions()],
- )
- .map_err(dispatch_to_evm::<T>)?;
-
let address = pallet_common::eth::collection_id_to_address(collection_id);
Ok(address)
}
primitives/data-structs/src/lib.rsdiffbeforeafterboth--- a/primitives/data-structs/src/lib.rs
+++ b/primitives/data-structs/src/lib.rs
@@ -1050,7 +1050,6 @@
pub enum PropertyScope {
None,
Rmrk,
- Eth,
}
impl PropertyScope {
@@ -1059,7 +1058,6 @@
let scope_str: &[u8] = match self {
Self::None => return Ok(key),
Self::Rmrk => b"rmrk",
- Self::Eth => b"eth",
};
[scope_str, b":", key.as_slice()]
tests/src/eth/api/UniqueRefungibleToken.soldiffbeforeafterboth--- a/tests/src/eth/api/UniqueRefungibleToken.sol
+++ b/tests/src/eth/api/UniqueRefungibleToken.sol
@@ -12,15 +12,6 @@
function supportsInterface(bytes4 interfaceID) external view returns (bool);
}
-/// @dev the ERC-165 identifier for this interface is 0x042f1106
-interface ERC1633UniqueExtensions is Dummy, ERC165 {
- /// @dev EVM selector for this function is: 0x042f1106,
- /// or in textual repr: setParentNFT(address,uint256)
- function setParentNFT(address collection, uint256 nftId)
- external
- returns (bool);
-}
-
/// @dev the ERC-165 identifier for this interface is 0x5755c3f2
interface ERC1633 is Dummy, ERC165 {
/// @dev EVM selector for this function is: 0x80a54001,
@@ -140,6 +131,5 @@
ERC165,
ERC20,
ERC20UniqueExtensions,
- ERC1633,
- ERC1633UniqueExtensions
+ ERC1633
{}
tests/src/eth/base.test.tsdiffbeforeafterboth--- a/tests/src/eth/base.test.ts
+++ b/tests/src/eth/base.test.ts
@@ -94,7 +94,7 @@
});
itWeb3('ERC721 support', async ({web3}) => {
- expect(await contract(web3).methods.supportsInterface('0x58800161').call()).to.be.true;
+ expect(await contract(web3).methods.supportsInterface('0x780e9d63').call()).to.be.true;
});
itWeb3('ERC721Metadata support', async ({web3}) => {
tests/src/eth/fractionalizer/Fractionalizer.soldiffbeforeafterboth--- a/tests/src/eth/fractionalizer/Fractionalizer.sol
+++ b/tests/src/eth/fractionalizer/Fractionalizer.sol
@@ -16,8 +16,8 @@
}
address rftCollection;
mapping(address => bool) nftCollectionAllowList;
- mapping(address => mapping(uint256 => uint256)) nft2rftMapping;
- mapping(address => Token) rft2nftMapping;
+ mapping(address => mapping(uint256 => uint256)) public nft2rftMapping;
+ mapping(address => Token) public rft2nftMapping;
bytes32 refungibleCollectionType = keccak256(bytes("ReFungible"));
receive() external payable onlyOwner {}
@@ -137,7 +137,6 @@
rft2nftMapping[rftTokenAddress] = Token(_collection, _token);
rftTokenContract = UniqueRefungibleToken(rftTokenAddress);
- rftTokenContract.setParentNFT(_collection, _token);
} else {
rftTokenId = nft2rftMapping[_collection][_token];
rftTokenAddress = rftCollectionContract.tokenContractAddress(rftTokenId);
tests/src/eth/fractionalizer/fractionalizer.test.tsdiffbeforeafterboth--- a/tests/src/eth/fractionalizer/fractionalizer.test.ts
+++ b/tests/src/eth/fractionalizer/fractionalizer.test.ts
@@ -223,6 +223,28 @@
},
});
});
+
+ itWeb3('Test fractionalizer NFT <-> RFT mapping ', async ({api, web3, privateKeyWrapper}) => {
+ const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
+
+ const {fractionalizer, rftCollectionAddress} = await initFractionalizer(api, web3, privateKeyWrapper, owner);
+ const {rftTokenAddress, nftCollectionAddress, nftTokenId} = await createRFTToken(api, web3, owner, fractionalizer, 100n);
+
+ const {collectionId, tokenId} = tokenIdFromAddress(rftTokenAddress);
+ const refungibleAddress = collectionIdToAddress(collectionId);
+ expect(rftCollectionAddress).to.be.equal(refungibleAddress);
+ const refungibleTokenContract = uniqueRefungibleToken(web3, rftTokenAddress, owner);
+ await refungibleTokenContract.methods.approve(fractionalizer.options.address, 100).send();
+
+ const rft2nft = await fractionalizer.methods.rft2nftMapping(rftTokenAddress).call();
+ expect(rft2nft).to.be.like({
+ _collection: nftCollectionAddress,
+ _tokenId: nftTokenId,
+ });
+
+ const nft2rft = await fractionalizer.methods.nft2rftMapping(nftCollectionAddress, nftTokenId).call();
+ expect(nft2rft).to.be.eq(tokenId.toString());
+ });
});
tests/src/eth/reFungibleToken.test.tsdiffbeforeafterboth--- a/tests/src/eth/reFungibleToken.test.ts
+++ b/tests/src/eth/reFungibleToken.test.ts
@@ -655,31 +655,6 @@
await requirePallets(this, [Pallets.ReFungible]);
});
- itWeb3('Parent NFT token address and id', async ({api, web3, privateKeyWrapper}) => {
- const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
-
- const {collectionIdAddress: nftCollectionAddress} = await createNonfungibleCollection(api, web3, owner);
- const nftContract = uniqueNFT(web3, nftCollectionAddress, owner);
- const nftTokenId = await nftContract.methods.nextTokenId().call();
- await nftContract.methods.mint(owner, nftTokenId).send();
- const nftCollectionId = collectionIdFromAddress(nftCollectionAddress);
-
- const {collectionIdAddress, collectionId} = await createRefungibleCollection(api, web3, owner);
- const refungibleContract = uniqueRefungible(web3, collectionIdAddress, owner);
- const refungibleTokenId = await refungibleContract.methods.nextTokenId().call();
- await refungibleContract.methods.mint(owner, refungibleTokenId).send();
-
- const rftTokenAddress = tokenIdToAddress(collectionId, refungibleTokenId);
- const refungibleTokenContract = uniqueRefungibleToken(web3, rftTokenAddress, owner);
- await refungibleTokenContract.methods.setParentNFT(nftCollectionAddress, nftTokenId).send();
-
- const tokenAddress = await refungibleTokenContract.methods.parentToken().call();
- const tokenId = await refungibleTokenContract.methods.parentTokenId().call();
- const nftTokenAddress = tokenIdToAddress(nftCollectionId, nftTokenId);
- expect(tokenAddress).to.be.equal(nftTokenAddress);
- expect(tokenId).to.be.equal(nftTokenId);
- });
-
itWeb3('Default parent token address and id', async ({api, web3, privateKeyWrapper}) => {
const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);
@@ -693,7 +668,7 @@
const tokenAddress = await refungibleTokenContract.methods.parentToken().call();
const tokenId = await refungibleTokenContract.methods.parentTokenId().call();
- expect(tokenAddress).to.be.equal(rftTokenAddress);
+ expect(tokenAddress).to.be.equal(collectionIdAddress);
expect(tokenId).to.be.equal(refungibleTokenId);
});
});
tests/src/eth/reFungibleTokenAbi.jsondiffbeforeafterboth--- a/tests/src/eth/reFungibleTokenAbi.json
+++ b/tests/src/eth/reFungibleTokenAbi.json
@@ -127,16 +127,6 @@
},
{
"inputs": [
- { "internalType": "address", "name": "collection", "type": "address" },
- { "internalType": "uint256", "name": "nftId", "type": "uint256" }
- ],
- "name": "setParentNFT",
- "outputs": [{ "internalType": "bool", "name": "", "type": "bool" }],
- "stateMutability": "nonpayable",
- "type": "function"
- },
- {
- "inputs": [
{ "internalType": "bytes4", "name": "interfaceID", "type": "bytes4" }
],
"name": "supportsInterface",