git.delta.rocks / unique-network / refs/commits / 534b1e6a235d

difftreelog

Add more approve tests

Max Andreev2022-12-21parent: #18ed554.patch.diff
in: master

4 files changed

modifiedtests/src/eth/fungible.test.tsdiffbeforeafterboth
before · tests/src/eth/fungible.test.ts
1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617import {expect, itEth, usingEthPlaygrounds} from './util';18import {IKeyringPair} from '@polkadot/types/types';1920describe('Fungible: Information getting', () => {21  let donor: IKeyringPair;22  let alice: IKeyringPair;2324  before(async function() {25    await usingEthPlaygrounds(async (helper, privateKey) => {26      donor = await privateKey({filename: __filename});27      [alice] = await helper.arrange.createAccounts([20n], donor);28    });29  });3031  itEth('totalSupply', async ({helper}) => {32    const caller = await helper.eth.createAccountWithBalance(donor);33    const collection = await helper.ft.mintCollection(alice);34    await collection.mint(alice, 200n);3536    const contract = helper.ethNativeContract.collectionById(collection.collectionId, 'ft', caller);37    const totalSupply = await contract.methods.totalSupply().call();38    expect(totalSupply).to.equal('200');39  });4041  itEth('balanceOf', async ({helper}) => {42    const caller = await helper.eth.createAccountWithBalance(donor);43    const collection = await helper.ft.mintCollection(alice);44    await collection.mint(alice, 200n, {Ethereum: caller});4546    const contract = helper.ethNativeContract.collectionById(collection.collectionId, 'ft', caller);47    const balance = await contract.methods.balanceOf(caller).call();48    expect(balance).to.equal('200');49  });50});5152describe('Fungible: Plain calls', () => {53  let donor: IKeyringPair;54  let alice: IKeyringPair;55  let owner: IKeyringPair;5657  before(async function() {58    await usingEthPlaygrounds(async (helper, privateKey) => {59      donor = await privateKey({filename: __filename});60      [alice, owner] = await helper.arrange.createAccounts([30n, 20n], donor);61    });62  });6364  itEth('Can perform mint()', async ({helper}) => {65    const owner = await helper.eth.createAccountWithBalance(donor);66    const receiver = helper.eth.createAccount();67    const collection = await helper.ft.mintCollection(alice);68    await collection.addAdmin(alice, {Ethereum: owner});6970    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);71    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner);7273    const result = await contract.methods.mint(receiver, 100).send();74    75    const event = result.events.Transfer;76    expect(event.address).to.equal(collectionAddress);77    expect(event.returnValues.from).to.equal('0x0000000000000000000000000000000000000000');78    expect(event.returnValues.to).to.equal(receiver);79    expect(event.returnValues.value).to.equal('100');80  });81  82  [83    'substrate' as const,84    'ethereum' as const,85  ].map(testCase => {86    itEth(`Can perform mintCross() for ${testCase} address`, async ({helper}) => {87      // 1. Create receiver depending on the test case:88      const receiverEth = helper.eth.createAccount();89      const receiverCrossEth = helper.ethCrossAccount.fromAddress(receiverEth);90      const receiverSub = owner;91      const receiverCrossSub = helper.ethCrossAccount.fromKeyringPair(owner);9293      const ethOwner = await helper.eth.createAccountWithBalance(donor);94      const collection = await helper.ft.mintCollection(alice);95      await collection.addAdmin(alice, {Ethereum: ethOwner});96  97      const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);98      const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'ft', ethOwner);99  100      // 2. Mint tokens:101      const result = await collectionEvm.methods.mintCross(testCase === 'ethereum' ? receiverCrossEth : receiverCrossSub, 100).send();102      103      const event = result.events.Transfer;104      expect(event.address).to.equal(collectionAddress);105      expect(event.returnValues.from).to.equal('0x0000000000000000000000000000000000000000');106      expect(event.returnValues.to).to.equal(testCase === 'ethereum' ? receiverEth : helper.address.substrateToEth(receiverSub.address));107      expect(event.returnValues.value).to.equal('100');108109      // 3. Get balance depending on the test case:110      let balance;111      if (testCase === 'ethereum') balance = await collection.getBalance({Ethereum: receiverEth});112      else if (testCase === 'substrate') balance = await collection.getBalance({Substrate: receiverSub.address});113      // 3.1 Check balance:114      expect(balance).to.eq(100n);115    });116  });117118  itEth('Can perform mintBulk()', async ({helper}) => {119    const owner = await helper.eth.createAccountWithBalance(donor);120    const bulkSize = 3;121    const receivers = [...new Array(bulkSize)].map(() => helper.eth.createAccount());122    const collection = await helper.ft.mintCollection(alice);123    await collection.addAdmin(alice, {Ethereum: owner});124125    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);126    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner);127128    const result = await contract.methods.mintBulk(Array.from({length: bulkSize}, (_, i) => (129      [receivers[i], (i + 1) * 10]130    ))).send();131    const events = result.events.Transfer.sort((a: any, b: any) => +a.returnValues.value - b.returnValues.value);132    for (let i = 0; i < bulkSize; i++) {133      const event = events[i];134      expect(event.address).to.equal(collectionAddress);135      expect(event.returnValues.from).to.equal('0x0000000000000000000000000000000000000000');136      expect(event.returnValues.to).to.equal(receivers[i]);137      expect(event.returnValues.value).to.equal(String(10 * (i + 1)));138    }139  });140141  // Soft-deprecated142  itEth('Can perform burn()', async ({helper}) => {143    const owner = await helper.eth.createAccountWithBalance(donor);144    const receiver = await helper.eth.createAccountWithBalance(donor);145    const collection = await helper.ft.mintCollection(alice);146    await collection.addAdmin(alice, {Ethereum: owner});147148    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);149    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner, true);150    await contract.methods.mint(receiver, 100).send();151152    const result = await contract.methods.burnFrom(receiver, 49).send({from: receiver});153    154    const event = result.events.Transfer;155    expect(event.address).to.equal(collectionAddress);156    expect(event.returnValues.from).to.equal(receiver);157    expect(event.returnValues.to).to.equal('0x0000000000000000000000000000000000000000');158    expect(event.returnValues.value).to.equal('49');159160    const balance = await contract.methods.balanceOf(receiver).call();161    expect(balance).to.equal('51');162  });163164  itEth('Can perform approve()', async ({helper}) => {165    const owner = await helper.eth.createAccountWithBalance(donor);166    const spender = helper.eth.createAccount();167    const collection = await helper.ft.mintCollection(alice);168    await collection.mint(alice, 200n, {Ethereum: owner});169170    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);171    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner);172173    {174      const result = await contract.methods.approve(spender, 100).send({from: owner});175176      const event = result.events.Approval;177      expect(event.address).to.be.equal(collectionAddress);178      expect(event.returnValues.owner).to.be.equal(owner);179      expect(event.returnValues.spender).to.be.equal(spender);180      expect(event.returnValues.value).to.be.equal('100');181    }182183    {184      const allowance = await contract.methods.allowance(owner, spender).call();185      expect(+allowance).to.equal(100);186    }187  });188189  itEth('Can perform burnFromCross()', async ({helper}) => {190    const sender = await helper.eth.createAccountWithBalance(donor, 100n);191192    const collection = await helper.ft.mintCollection(owner, {name: 'A', description: 'B', tokenPrefix: 'C'}, 0);193194    await collection.mint(owner, 200n, {Substrate: owner.address});195    await collection.approveTokens(owner, {Ethereum: sender}, 100n);196197    const address = helper.ethAddress.fromCollectionId(collection.collectionId);198    const contract = helper.ethNativeContract.collection(address, 'ft');199200    const fromBalanceBefore = await collection.getBalance({Substrate: owner.address});201    202    const ownerCross = helper.ethCrossAccount.fromKeyringPair(owner);203    const result = await contract.methods.burnFromCross(ownerCross, 49).send({from: sender});204    const events = result.events;205206    expect(events).to.be.like({207      Transfer: {208        address: helper.ethAddress.fromCollectionId(collection.collectionId),209        event: 'Transfer',210        returnValues: {211          from: helper.address.substrateToEth(owner.address),212          to: '0x0000000000000000000000000000000000000000',213          value: '49',214        },215      },216      Approval: {217        address: helper.ethAddress.fromCollectionId(collection.collectionId),218        returnValues: {219          owner: helper.address.substrateToEth(owner.address),220          spender: sender,221          value: '51',222        },223        event: 'Approval',224      },225    });226227    const fromBalanceAfter = await collection.getBalance({Substrate: owner.address});228    expect(fromBalanceBefore - fromBalanceAfter).to.be.eq(49n);229  });230231  itEth('Can perform transferFrom()', async ({helper}) => {232    const owner = await helper.eth.createAccountWithBalance(donor);233    const spender = await helper.eth.createAccountWithBalance(donor);234    const receiver = helper.eth.createAccount();235    const collection = await helper.ft.mintCollection(alice);236    await collection.mint(alice, 200n, {Ethereum: owner});237238    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);239    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner);240241    await contract.methods.approve(spender, 100).send();242243    {244      const result = await contract.methods.transferFrom(owner, receiver, 49).send({from: spender});245      246      let event = result.events.Transfer;247      expect(event.address).to.be.equal(collectionAddress);248      expect(event.returnValues.from).to.be.equal(owner);249      expect(event.returnValues.to).to.be.equal(receiver);250      expect(event.returnValues.value).to.be.equal('49');251252      event = result.events.Approval;253      expect(event.address).to.be.equal(collectionAddress);254      expect(event.returnValues.owner).to.be.equal(owner);255      expect(event.returnValues.spender).to.be.equal(spender);256      expect(event.returnValues.value).to.be.equal('51');257    }258259    {260      const balance = await contract.methods.balanceOf(receiver).call();261      expect(+balance).to.equal(49);262    }263264    {265      const balance = await contract.methods.balanceOf(owner).call();266      expect(+balance).to.equal(151);267    }268  });269270  itEth('Can perform transferCross()', async ({helper}) => {271    const sender = await helper.eth.createAccountWithBalance(donor);272    const receiverEth = await helper.eth.createAccountWithBalance(donor);273    const receiverCrossEth = helper.ethCrossAccount.fromAddress(receiverEth);274    const receiverCrossSub = helper.ethCrossAccount.fromKeyringPair(donor);275    const collection = await helper.ft.mintCollection(alice);276    await collection.mint(alice, 200n, {Ethereum: sender});277278    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);279    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'ft', sender);280281    {282      // Can transferCross to ethereum address:283      const result = await collectionEvm.methods.transferCross(receiverCrossEth, 50).send({from: sender});284      // Check events:285      const event = result.events.Transfer;286      expect(event.address).to.be.equal(collectionAddress);287      expect(event.returnValues.from).to.be.equal(sender);288      expect(event.returnValues.to).to.be.equal(receiverEth);289      expect(event.returnValues.value).to.be.equal('50');290      // Sender's balance decreased:291      const ownerBalance = await collectionEvm.methods.balanceOf(sender).call();292      expect(+ownerBalance).to.equal(150);293      // Receiver's balance increased:294      const receiverBalance = await collectionEvm.methods.balanceOf(receiverEth).call();295      expect(+receiverBalance).to.equal(50);296    }297    298    {299      // Can transferCross to substrate address:300      const result = await collectionEvm.methods.transferCross(receiverCrossSub, 50).send({from: sender});301      // Check events:302      const event = result.events.Transfer;303      expect(event.address).to.be.equal(collectionAddress);304      expect(event.returnValues.from).to.be.equal(sender);305      expect(event.returnValues.to).to.be.equal(helper.address.substrateToEth(donor.address));306      expect(event.returnValues.value).to.be.equal('50');307      // Sender's balance decreased:308      const senderBalance = await collection.getBalance({Ethereum: sender});309      expect(senderBalance).to.equal(100n);310      // Receiver's balance increased:311      const balance = await collection.getBalance({Substrate: donor.address});312      expect(balance).to.equal(50n);313    }314  });315316  ['transfer', 'transferCross'].map(testCase => itEth(`Cannot ${testCase} incorrect amount`, async ({helper}) => {317    const sender = await helper.eth.createAccountWithBalance(donor);318    const receiverEth = await helper.eth.createAccountWithBalance(donor);319    const receiverCrossEth = helper.ethCrossAccount.fromAddress(receiverEth);320    const BALANCE = 200n;321    const BALANCE_TO_TRANSFER = BALANCE + 100n;322323    const collection = await helper.ft.mintCollection(alice);324    await collection.mint(alice, BALANCE, {Ethereum: sender});325    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);326    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'ft', sender);327328    // 1. Cannot transfer more than have329    const receiver = testCase === 'transfer' ? receiverEth : receiverCrossEth;330    await expect(collectionEvm.methods[testCase](receiver, BALANCE_TO_TRANSFER).send({from: sender})).to.be.rejected;331    // 2. Zero transfer allowed (EIP-20):332    await collectionEvm.methods[testCase](receiver, 0n).send({from: sender});333  }));334  335  336  itEth('Can perform transfer()', async ({helper}) => {337    const owner = await helper.eth.createAccountWithBalance(donor);338    const receiver = await helper.eth.createAccountWithBalance(donor);339    const collection = await helper.ft.mintCollection(alice);340    await collection.mint(alice, 200n, {Ethereum: owner});341342    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);343    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner);344345    {346      const result = await contract.methods.transfer(receiver, 50).send({from: owner});347      348      const event = result.events.Transfer;349      expect(event.address).to.be.equal(collectionAddress);350      expect(event.returnValues.from).to.be.equal(owner);351      expect(event.returnValues.to).to.be.equal(receiver);352      expect(event.returnValues.value).to.be.equal('50');353    }354355    {356      const balance = await contract.methods.balanceOf(owner).call();357      expect(+balance).to.equal(150);358    }359360    {361      const balance = await contract.methods.balanceOf(receiver).call();362      expect(+balance).to.equal(50);363    }364  });365366  itEth('Can perform transferFromCross()', async ({helper}) => {367    const sender = await helper.eth.createAccountWithBalance(donor, 100n);368369    const collection = await helper.ft.mintCollection(owner, {name: 'A', description: 'B', tokenPrefix: 'C'}, 0);370371    const receiver = helper.eth.createAccount();372373    await collection.mint(owner, 200n, {Substrate: owner.address});374    await collection.approveTokens(owner, {Ethereum: sender}, 100n);375376    const address = helper.ethAddress.fromCollectionId(collection.collectionId);377    const contract = helper.ethNativeContract.collection(address, 'ft');378379    const from = helper.ethCrossAccount.fromKeyringPair(owner);380    const to = helper.ethCrossAccount.fromAddress(receiver);381382    const fromBalanceBefore = await collection.getBalance({Substrate: owner.address});383    const toBalanceBefore = await collection.getBalance({Ethereum: receiver});384    385    const result = await contract.methods.transferFromCross(from, to, 51).send({from: sender});386387    expect(result.events).to.be.like({388      Transfer: {389        address,390        event: 'Transfer',391        returnValues: {392          from: helper.address.substrateToEth(owner.address),393          to: receiver,394          value: '51',395        },396      },397      Approval: {398        address,399        event: 'Approval',400        returnValues: {401          owner: helper.address.substrateToEth(owner.address),402          spender: sender,403          value: '49',404        },405      }});406407    const fromBalanceAfter = await collection.getBalance({Substrate: owner.address});408    expect(fromBalanceBefore - fromBalanceAfter).to.be.eq(51n);409    const toBalanceAfter = await collection.getBalance({Ethereum: receiver});410    expect(toBalanceAfter - toBalanceBefore).to.be.eq(51n);411  });412});413414describe('Fungible: Fees', () => {415  let donor: IKeyringPair;416  let alice: IKeyringPair;417418  before(async function() {419    await usingEthPlaygrounds(async (helper, privateKey) => {420      donor = await privateKey({filename: __filename});421      [alice] = await helper.arrange.createAccounts([20n], donor);422    });423  });424  425  itEth('approve() call fee is less than 0.2UNQ', async ({helper}) => {426    const owner = await helper.eth.createAccountWithBalance(donor);427    const spender = helper.eth.createAccount();428    const collection = await helper.ft.mintCollection(alice);429    await collection.mint(alice, 200n, {Ethereum: owner});430431    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);432    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner);433434    const cost = await helper.eth.recordCallFee(owner, () => contract.methods.approve(spender, 100).send({from: owner}));435    expect(cost < BigInt(0.2 * Number(helper.balance.getOneTokenNominal())));436  });437438  itEth('transferFrom() call fee is less than 0.2UNQ', async ({helper}) => {439    const owner = await helper.eth.createAccountWithBalance(donor);440    const spender = await helper.eth.createAccountWithBalance(donor);441    const collection = await helper.ft.mintCollection(alice);442    await collection.mint(alice, 200n, {Ethereum: owner});443444    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);445    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner);446447    await contract.methods.approve(spender, 100).send({from: owner});448449    const cost = await helper.eth.recordCallFee(spender, () => contract.methods.transferFrom(owner, spender, 100).send({from: spender}));450    expect(cost < BigInt(0.2 * Number(helper.balance.getOneTokenNominal())));451  });452453  itEth('transfer() call fee is less than 0.2UNQ', async ({helper}) => {454    const owner = await helper.eth.createAccountWithBalance(donor);455    const receiver = helper.eth.createAccount();456    const collection = await helper.ft.mintCollection(alice);457    await collection.mint(alice, 200n, {Ethereum: owner});458459    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);460    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner);461462    const cost = await helper.eth.recordCallFee(owner, () => contract.methods.transfer(receiver, 100).send({from: owner}));463    expect(cost < BigInt(0.2 * Number(helper.balance.getOneTokenNominal())));464  });465});466467describe('Fungible: Substrate calls', () => {468  let donor: IKeyringPair;469  let alice: IKeyringPair;470  let owner: IKeyringPair;471472  before(async function() {473    await usingEthPlaygrounds(async (helper, privateKey) => {474      donor = await privateKey({filename: __filename});475      [alice, owner] = await helper.arrange.createAccounts([20n, 20n], donor);476    });477  });478479  itEth('Events emitted for approve()', async ({helper}) => {480    const receiver = helper.eth.createAccount();481    const collection = await helper.ft.mintCollection(alice);482    await collection.mint(alice, 200n);483484    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);485    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft');486487    const events: any = [];488    contract.events.allEvents((_: any, event: any) => {489      events.push(event);490    });491    492    await collection.approveTokens(alice, {Ethereum: receiver}, 100n);493    if (events.length == 0) await helper.wait.newBlocks(1);494    const event = events[0];495496    expect(event.event).to.be.equal('Approval');497    expect(event.address).to.be.equal(collectionAddress);498    expect(event.returnValues.owner).to.be.equal(helper.address.substrateToEth(alice.address));499    expect(event.returnValues.spender).to.be.equal(receiver);500    expect(event.returnValues.value).to.be.equal('100');501  });502503  itEth('Events emitted for transferFrom()', async ({helper}) => {504    const [bob] = await helper.arrange.createAccounts([10n], donor);505    const receiver = helper.eth.createAccount();506    const collection = await helper.ft.mintCollection(alice);507    await collection.mint(alice, 200n);508    await collection.approveTokens(alice, {Substrate: bob.address}, 100n);509510    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);511    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft');512513    const events: any = [];514    contract.events.allEvents((_: any, event: any) => {515      events.push(event);516    });517518    await collection.transferFrom(bob, {Substrate: alice.address}, {Ethereum: receiver}, 51n);519    if (events.length == 0) await helper.wait.newBlocks(1);520    let event = events[0];521522    expect(event.event).to.be.equal('Transfer');523    expect(event.address).to.be.equal(collectionAddress);524    expect(event.returnValues.from).to.be.equal(helper.address.substrateToEth(alice.address));525    expect(event.returnValues.to).to.be.equal(receiver);526    expect(event.returnValues.value).to.be.equal('51');527528    event = events[1];529    expect(event.event).to.be.equal('Approval');530    expect(event.address).to.be.equal(collectionAddress);531    expect(event.returnValues.owner).to.be.equal(helper.address.substrateToEth(alice.address));532    expect(event.returnValues.spender).to.be.equal(helper.address.substrateToEth(bob.address));533    expect(event.returnValues.value).to.be.equal('49');534  });535536  itEth('Events emitted for transfer()', async ({helper}) => {537    const receiver = helper.eth.createAccount();538    const collection = await helper.ft.mintCollection(alice);539    await collection.mint(alice, 200n);540541    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);542    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft');543544    const events: any = [];545    contract.events.allEvents((_: any, event: any) => {546      events.push(event);547    });548    549    await collection.transfer(alice, {Ethereum:receiver}, 51n);550    if (events.length == 0) await helper.wait.newBlocks(1);551    const event = events[0];552553    expect(event.event).to.be.equal('Transfer');554    expect(event.address).to.be.equal(collectionAddress);555    expect(event.returnValues.from).to.be.equal(helper.address.substrateToEth(alice.address));556    expect(event.returnValues.to).to.be.equal(receiver);557    expect(event.returnValues.value).to.be.equal('51');558  });559560  itEth('Events emitted for transferFromCross()', async ({helper}) => {561    const sender = await helper.eth.createAccountWithBalance(donor, 100n);562563    const collection = await helper.ft.mintCollection(owner, {name: 'A', description: 'B', tokenPrefix: 'C'}, 0);564565    const receiver = helper.eth.createAccount();566567    await collection.mint(owner, 200n, {Substrate: owner.address});568    await collection.approveTokens(owner, {Ethereum: sender}, 100n);569570    const address = helper.ethAddress.fromCollectionId(collection.collectionId);571    const contract = helper.ethNativeContract.collection(address, 'ft');572573    const from = helper.ethCrossAccount.fromKeyringPair(owner);574    const to = helper.ethCrossAccount.fromAddress(receiver);575    576    const result = await contract.methods.transferFromCross(from, to, 51).send({from: sender});577578    expect(result.events).to.be.like({579      Transfer: {580        address,581        event: 'Transfer',582        returnValues: {583          from: helper.address.substrateToEth(owner.address),584          to: receiver,585          value: '51',586        },587      },588      Approval: {589        address,590        event: 'Approval',591        returnValues: {592          owner: helper.address.substrateToEth(owner.address),593          spender: sender,594          value: '49',595        },596      }});597  });598});
after · tests/src/eth/fungible.test.ts
1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617import {expect, itEth, usingEthPlaygrounds} from './util';18import {IKeyringPair} from '@polkadot/types/types';1920describe('Fungible: Information getting', () => {21  let donor: IKeyringPair;22  let alice: IKeyringPair;2324  before(async function() {25    await usingEthPlaygrounds(async (helper, privateKey) => {26      donor = await privateKey({filename: __filename});27      [alice] = await helper.arrange.createAccounts([20n], donor);28    });29  });3031  itEth('totalSupply', async ({helper}) => {32    const caller = await helper.eth.createAccountWithBalance(donor);33    const collection = await helper.ft.mintCollection(alice);34    await collection.mint(alice, 200n);3536    const contract = helper.ethNativeContract.collectionById(collection.collectionId, 'ft', caller);37    const totalSupply = await contract.methods.totalSupply().call();38    expect(totalSupply).to.equal('200');39  });4041  itEth('balanceOf', async ({helper}) => {42    const caller = await helper.eth.createAccountWithBalance(donor);43    const collection = await helper.ft.mintCollection(alice);44    await collection.mint(alice, 200n, {Ethereum: caller});4546    const contract = helper.ethNativeContract.collectionById(collection.collectionId, 'ft', caller);47    const balance = await contract.methods.balanceOf(caller).call();48    expect(balance).to.equal('200');49  });50});5152describe('Fungible: Plain calls', () => {53  let donor: IKeyringPair;54  let alice: IKeyringPair;55  let owner: IKeyringPair;5657  before(async function() {58    await usingEthPlaygrounds(async (helper, privateKey) => {59      donor = await privateKey({filename: __filename});60      [alice, owner] = await helper.arrange.createAccounts([30n, 20n], donor);61    });62  });6364  itEth('Can perform mint()', async ({helper}) => {65    const owner = await helper.eth.createAccountWithBalance(donor);66    const receiver = helper.eth.createAccount();67    const collection = await helper.ft.mintCollection(alice);68    await collection.addAdmin(alice, {Ethereum: owner});6970    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);71    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner);7273    const result = await contract.methods.mint(receiver, 100).send();74    75    const event = result.events.Transfer;76    expect(event.address).to.equal(collectionAddress);77    expect(event.returnValues.from).to.equal('0x0000000000000000000000000000000000000000');78    expect(event.returnValues.to).to.equal(receiver);79    expect(event.returnValues.value).to.equal('100');80  });81  82  [83    'substrate' as const,84    'ethereum' as const,85  ].map(testCase => {86    itEth(`Can perform mintCross() for ${testCase} address`, async ({helper}) => {87      // 1. Create receiver depending on the test case:88      const receiverEth = helper.eth.createAccount();89      const receiverCrossEth = helper.ethCrossAccount.fromAddress(receiverEth);90      const receiverSub = owner;91      const receiverCrossSub = helper.ethCrossAccount.fromKeyringPair(owner);9293      const ethOwner = await helper.eth.createAccountWithBalance(donor);94      const collection = await helper.ft.mintCollection(alice);95      await collection.addAdmin(alice, {Ethereum: ethOwner});96  97      const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);98      const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'ft', ethOwner);99  100      // 2. Mint tokens:101      const result = await collectionEvm.methods.mintCross(testCase === 'ethereum' ? receiverCrossEth : receiverCrossSub, 100).send();102      103      const event = result.events.Transfer;104      expect(event.address).to.equal(collectionAddress);105      expect(event.returnValues.from).to.equal('0x0000000000000000000000000000000000000000');106      expect(event.returnValues.to).to.equal(testCase === 'ethereum' ? receiverEth : helper.address.substrateToEth(receiverSub.address));107      expect(event.returnValues.value).to.equal('100');108109      // 3. Get balance depending on the test case:110      let balance;111      if (testCase === 'ethereum') balance = await collection.getBalance({Ethereum: receiverEth});112      else if (testCase === 'substrate') balance = await collection.getBalance({Substrate: receiverSub.address});113      // 3.1 Check balance:114      expect(balance).to.eq(100n);115    });116  });117118  itEth('Can perform mintBulk()', async ({helper}) => {119    const owner = await helper.eth.createAccountWithBalance(donor);120    const bulkSize = 3;121    const receivers = [...new Array(bulkSize)].map(() => helper.eth.createAccount());122    const collection = await helper.ft.mintCollection(alice);123    await collection.addAdmin(alice, {Ethereum: owner});124125    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);126    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner);127128    const result = await contract.methods.mintBulk(Array.from({length: bulkSize}, (_, i) => (129      [receivers[i], (i + 1) * 10]130    ))).send();131    const events = result.events.Transfer.sort((a: any, b: any) => +a.returnValues.value - b.returnValues.value);132    for (let i = 0; i < bulkSize; i++) {133      const event = events[i];134      expect(event.address).to.equal(collectionAddress);135      expect(event.returnValues.from).to.equal('0x0000000000000000000000000000000000000000');136      expect(event.returnValues.to).to.equal(receivers[i]);137      expect(event.returnValues.value).to.equal(String(10 * (i + 1)));138    }139  });140141  // Soft-deprecated142  itEth('Can perform burn()', async ({helper}) => {143    const owner = await helper.eth.createAccountWithBalance(donor);144    const receiver = await helper.eth.createAccountWithBalance(donor);145    const collection = await helper.ft.mintCollection(alice);146    await collection.addAdmin(alice, {Ethereum: owner});147148    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);149    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner, true);150    await contract.methods.mint(receiver, 100).send();151152    const result = await contract.methods.burnFrom(receiver, 49).send({from: receiver});153    154    const event = result.events.Transfer;155    expect(event.address).to.equal(collectionAddress);156    expect(event.returnValues.from).to.equal(receiver);157    expect(event.returnValues.to).to.equal('0x0000000000000000000000000000000000000000');158    expect(event.returnValues.value).to.equal('49');159160    const balance = await contract.methods.balanceOf(receiver).call();161    expect(balance).to.equal('51');162  });163164  itEth('Can perform approve()', async ({helper}) => {165    const owner = await helper.eth.createAccountWithBalance(donor);166    const spender = helper.eth.createAccount();167    const collection = await helper.ft.mintCollection(alice);168    await collection.mint(alice, 200n, {Ethereum: owner});169170    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);171    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner);172173    {174      const result = await contract.methods.approve(spender, 100).send({from: owner});175176      const event = result.events.Approval;177      expect(event.address).to.be.equal(collectionAddress);178      expect(event.returnValues.owner).to.be.equal(owner);179      expect(event.returnValues.spender).to.be.equal(spender);180      expect(event.returnValues.value).to.be.equal('100');181    }182183    {184      const allowance = await contract.methods.allowance(owner, spender).call();185      expect(+allowance).to.equal(100);186    }187  });188189  itEth('Can perform approveCross()', async ({helper}) => {190    const owner = await helper.eth.createAccountWithBalance(donor);191    const spender = helper.eth.createAccount();192    const spenderSub = (await helper.arrange.createAccounts([1n], donor))[0];193    const spenderCrossEth = helper.ethCrossAccount.fromAddress(spender);194    const spenderCrossSub = helper.ethCrossAccount.fromKeyringPair(spenderSub);195    196197    const collection = await helper.ft.mintCollection(alice);198    await collection.mint(alice, 200n, {Ethereum: owner});199200    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);201    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner);202203    {204      const result = await contract.methods.approveCross(spenderCrossEth, 100).send({from: owner});205      const event = result.events.Approval;206      expect(event.address).to.be.equal(collectionAddress);207      expect(event.returnValues.owner).to.be.equal(owner);208      expect(event.returnValues.spender).to.be.equal(spender);209      expect(event.returnValues.value).to.be.equal('100');210    }211212    {213      const allowance = await contract.methods.allowance(owner, spender).call();214      expect(+allowance).to.equal(100);215    }216    217    218    {219      const result = await contract.methods.approveCross(spenderCrossSub, 100).send({from: owner});220      const event = result.events.Approval;221      expect(event.address).to.be.equal(collectionAddress);222      expect(event.returnValues.owner).to.be.equal(owner);223      expect(event.returnValues.spender).to.be.equal(helper.address.substrateToEth(spenderSub.address));224      expect(event.returnValues.value).to.be.equal('100');225    }226227    {228      const allowance = await collection.getApprovedTokens({Ethereum: owner}, {Substrate: spenderSub.address});229      expect(allowance).to.equal(100n);230    }231  232    {233      //TO-DO expect with future allowanceCross(owner, spenderCrossEth).call()234    }235  });236237  itEth('Non-owner and non admin cannot approveCross', async ({helper}) => {238    const nonOwner = await helper.eth.createAccountWithBalance(donor);239    const nonOwnerCross = helper.ethCrossAccount.fromAddress(nonOwner);240    const owner = await helper.eth.createAccountWithBalance(donor);241    const collection = await helper.ft.mintCollection(alice, {name: 'A', description: 'B', tokenPrefix: 'C'});242    await collection.mint(alice, 100n, {Ethereum: owner});243244    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);245    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'ft', owner);246247    await expect(collectionEvm.methods.approveCross(nonOwnerCross, 20).call({from: nonOwner})).to.be.rejectedWith('CantApproveMoreThanOwned');248  });249250251  itEth('Can perform burnFromCross()', async ({helper}) => {252    const sender = await helper.eth.createAccountWithBalance(donor, 100n);253254    const collection = await helper.ft.mintCollection(owner, {name: 'A', description: 'B', tokenPrefix: 'C'}, 0);255256    await collection.mint(owner, 200n, {Substrate: owner.address});257    await collection.approveTokens(owner, {Ethereum: sender}, 100n);258259    const address = helper.ethAddress.fromCollectionId(collection.collectionId);260    const contract = helper.ethNativeContract.collection(address, 'ft');261262    const fromBalanceBefore = await collection.getBalance({Substrate: owner.address});263    264    const ownerCross = helper.ethCrossAccount.fromKeyringPair(owner);265    const result = await contract.methods.burnFromCross(ownerCross, 49).send({from: sender});266    const events = result.events;267268    expect(events).to.be.like({269      Transfer: {270        address: helper.ethAddress.fromCollectionId(collection.collectionId),271        event: 'Transfer',272        returnValues: {273          from: helper.address.substrateToEth(owner.address),274          to: '0x0000000000000000000000000000000000000000',275          value: '49',276        },277      },278      Approval: {279        address: helper.ethAddress.fromCollectionId(collection.collectionId),280        returnValues: {281          owner: helper.address.substrateToEth(owner.address),282          spender: sender,283          value: '51',284        },285        event: 'Approval',286      },287    });288289    const fromBalanceAfter = await collection.getBalance({Substrate: owner.address});290    expect(fromBalanceBefore - fromBalanceAfter).to.be.eq(49n);291  });292293  itEth('Can perform transferFrom()', async ({helper}) => {294    const owner = await helper.eth.createAccountWithBalance(donor);295    const spender = await helper.eth.createAccountWithBalance(donor);296    const receiver = helper.eth.createAccount();297    const collection = await helper.ft.mintCollection(alice);298    await collection.mint(alice, 200n, {Ethereum: owner});299300    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);301    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner);302303    await contract.methods.approve(spender, 100).send();304305    {306      const result = await contract.methods.transferFrom(owner, receiver, 49).send({from: spender});307      308      let event = result.events.Transfer;309      expect(event.address).to.be.equal(collectionAddress);310      expect(event.returnValues.from).to.be.equal(owner);311      expect(event.returnValues.to).to.be.equal(receiver);312      expect(event.returnValues.value).to.be.equal('49');313314      event = result.events.Approval;315      expect(event.address).to.be.equal(collectionAddress);316      expect(event.returnValues.owner).to.be.equal(owner);317      expect(event.returnValues.spender).to.be.equal(spender);318      expect(event.returnValues.value).to.be.equal('51');319    }320321    {322      const balance = await contract.methods.balanceOf(receiver).call();323      expect(+balance).to.equal(49);324    }325326    {327      const balance = await contract.methods.balanceOf(owner).call();328      expect(+balance).to.equal(151);329    }330  });331332  itEth('Can perform transferCross()', async ({helper}) => {333    const sender = await helper.eth.createAccountWithBalance(donor);334    const receiverEth = await helper.eth.createAccountWithBalance(donor);335    const receiverCrossEth = helper.ethCrossAccount.fromAddress(receiverEth);336    const receiverCrossSub = helper.ethCrossAccount.fromKeyringPair(donor);337    const collection = await helper.ft.mintCollection(alice);338    await collection.mint(alice, 200n, {Ethereum: sender});339340    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);341    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'ft', sender);342343    {344      // Can transferCross to ethereum address:345      const result = await collectionEvm.methods.transferCross(receiverCrossEth, 50).send({from: sender});346      // Check events:347      const event = result.events.Transfer;348      expect(event.address).to.be.equal(collectionAddress);349      expect(event.returnValues.from).to.be.equal(sender);350      expect(event.returnValues.to).to.be.equal(receiverEth);351      expect(event.returnValues.value).to.be.equal('50');352      // Sender's balance decreased:353      const ownerBalance = await collectionEvm.methods.balanceOf(sender).call();354      expect(+ownerBalance).to.equal(150);355      // Receiver's balance increased:356      const receiverBalance = await collectionEvm.methods.balanceOf(receiverEth).call();357      expect(+receiverBalance).to.equal(50);358    }359    360    {361      // Can transferCross to substrate address:362      const result = await collectionEvm.methods.transferCross(receiverCrossSub, 50).send({from: sender});363      // Check events:364      const event = result.events.Transfer;365      expect(event.address).to.be.equal(collectionAddress);366      expect(event.returnValues.from).to.be.equal(sender);367      expect(event.returnValues.to).to.be.equal(helper.address.substrateToEth(donor.address));368      expect(event.returnValues.value).to.be.equal('50');369      // Sender's balance decreased:370      const senderBalance = await collection.getBalance({Ethereum: sender});371      expect(senderBalance).to.equal(100n);372      // Receiver's balance increased:373      const balance = await collection.getBalance({Substrate: donor.address});374      expect(balance).to.equal(50n);375    }376  });377378  ['transfer', 'transferCross'].map(testCase => itEth(`Cannot ${testCase} incorrect amount`, async ({helper}) => {379    const sender = await helper.eth.createAccountWithBalance(donor);380    const receiverEth = await helper.eth.createAccountWithBalance(donor);381    const receiverCrossEth = helper.ethCrossAccount.fromAddress(receiverEth);382    const BALANCE = 200n;383    const BALANCE_TO_TRANSFER = BALANCE + 100n;384385    const collection = await helper.ft.mintCollection(alice);386    await collection.mint(alice, BALANCE, {Ethereum: sender});387    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);388    const collectionEvm = helper.ethNativeContract.collection(collectionAddress, 'ft', sender);389390    // 1. Cannot transfer more than have391    const receiver = testCase === 'transfer' ? receiverEth : receiverCrossEth;392    await expect(collectionEvm.methods[testCase](receiver, BALANCE_TO_TRANSFER).send({from: sender})).to.be.rejected;393    // 2. Zero transfer allowed (EIP-20):394    await collectionEvm.methods[testCase](receiver, 0n).send({from: sender});395  }));396  397  398  itEth('Can perform transfer()', async ({helper}) => {399    const owner = await helper.eth.createAccountWithBalance(donor);400    const receiver = await helper.eth.createAccountWithBalance(donor);401    const collection = await helper.ft.mintCollection(alice);402    await collection.mint(alice, 200n, {Ethereum: owner});403404    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);405    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner);406407    {408      const result = await contract.methods.transfer(receiver, 50).send({from: owner});409      410      const event = result.events.Transfer;411      expect(event.address).to.be.equal(collectionAddress);412      expect(event.returnValues.from).to.be.equal(owner);413      expect(event.returnValues.to).to.be.equal(receiver);414      expect(event.returnValues.value).to.be.equal('50');415    }416417    {418      const balance = await contract.methods.balanceOf(owner).call();419      expect(+balance).to.equal(150);420    }421422    {423      const balance = await contract.methods.balanceOf(receiver).call();424      expect(+balance).to.equal(50);425    }426  });427428  itEth('Can perform transferFromCross()', async ({helper}) => {429    const sender = await helper.eth.createAccountWithBalance(donor, 100n);430431    const collection = await helper.ft.mintCollection(owner, {name: 'A', description: 'B', tokenPrefix: 'C'}, 0);432433    const receiver = helper.eth.createAccount();434435    await collection.mint(owner, 200n, {Substrate: owner.address});436    await collection.approveTokens(owner, {Ethereum: sender}, 100n);437438    const address = helper.ethAddress.fromCollectionId(collection.collectionId);439    const contract = helper.ethNativeContract.collection(address, 'ft');440441    const from = helper.ethCrossAccount.fromKeyringPair(owner);442    const to = helper.ethCrossAccount.fromAddress(receiver);443444    const fromBalanceBefore = await collection.getBalance({Substrate: owner.address});445    const toBalanceBefore = await collection.getBalance({Ethereum: receiver});446    447    const result = await contract.methods.transferFromCross(from, to, 51).send({from: sender});448449    expect(result.events).to.be.like({450      Transfer: {451        address,452        event: 'Transfer',453        returnValues: {454          from: helper.address.substrateToEth(owner.address),455          to: receiver,456          value: '51',457        },458      },459      Approval: {460        address,461        event: 'Approval',462        returnValues: {463          owner: helper.address.substrateToEth(owner.address),464          spender: sender,465          value: '49',466        },467      }});468469    const fromBalanceAfter = await collection.getBalance({Substrate: owner.address});470    expect(fromBalanceBefore - fromBalanceAfter).to.be.eq(51n);471    const toBalanceAfter = await collection.getBalance({Ethereum: receiver});472    expect(toBalanceAfter - toBalanceBefore).to.be.eq(51n);473  });474});475476describe('Fungible: Fees', () => {477  let donor: IKeyringPair;478  let alice: IKeyringPair;479480  before(async function() {481    await usingEthPlaygrounds(async (helper, privateKey) => {482      donor = await privateKey({filename: __filename});483      [alice] = await helper.arrange.createAccounts([20n], donor);484    });485  });486  487  itEth('approve() call fee is less than 0.2UNQ', async ({helper}) => {488    const owner = await helper.eth.createAccountWithBalance(donor);489    const spender = helper.eth.createAccount();490    const collection = await helper.ft.mintCollection(alice);491    await collection.mint(alice, 200n, {Ethereum: owner});492493    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);494    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner);495496    const cost = await helper.eth.recordCallFee(owner, () => contract.methods.approve(spender, 100).send({from: owner}));497    expect(cost < BigInt(0.2 * Number(helper.balance.getOneTokenNominal())));498  });499500  itEth('transferFrom() call fee is less than 0.2UNQ', async ({helper}) => {501    const owner = await helper.eth.createAccountWithBalance(donor);502    const spender = await helper.eth.createAccountWithBalance(donor);503    const collection = await helper.ft.mintCollection(alice);504    await collection.mint(alice, 200n, {Ethereum: owner});505506    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);507    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner);508509    await contract.methods.approve(spender, 100).send({from: owner});510511    const cost = await helper.eth.recordCallFee(spender, () => contract.methods.transferFrom(owner, spender, 100).send({from: spender}));512    expect(cost < BigInt(0.2 * Number(helper.balance.getOneTokenNominal())));513  });514515  itEth('transfer() call fee is less than 0.2UNQ', async ({helper}) => {516    const owner = await helper.eth.createAccountWithBalance(donor);517    const receiver = helper.eth.createAccount();518    const collection = await helper.ft.mintCollection(alice);519    await collection.mint(alice, 200n, {Ethereum: owner});520521    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);522    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft', owner);523524    const cost = await helper.eth.recordCallFee(owner, () => contract.methods.transfer(receiver, 100).send({from: owner}));525    expect(cost < BigInt(0.2 * Number(helper.balance.getOneTokenNominal())));526  });527});528529describe('Fungible: Substrate calls', () => {530  let donor: IKeyringPair;531  let alice: IKeyringPair;532  let owner: IKeyringPair;533534  before(async function() {535    await usingEthPlaygrounds(async (helper, privateKey) => {536      donor = await privateKey({filename: __filename});537      [alice, owner] = await helper.arrange.createAccounts([20n, 20n], donor);538    });539  });540541  itEth('Events emitted for approve()', async ({helper}) => {542    const receiver = helper.eth.createAccount();543    const collection = await helper.ft.mintCollection(alice);544    await collection.mint(alice, 200n);545546    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);547    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft');548549    const events: any = [];550    contract.events.allEvents((_: any, event: any) => {551      events.push(event);552    });553    554    await collection.approveTokens(alice, {Ethereum: receiver}, 100n);555    if (events.length == 0) await helper.wait.newBlocks(1);556    const event = events[0];557558    expect(event.event).to.be.equal('Approval');559    expect(event.address).to.be.equal(collectionAddress);560    expect(event.returnValues.owner).to.be.equal(helper.address.substrateToEth(alice.address));561    expect(event.returnValues.spender).to.be.equal(receiver);562    expect(event.returnValues.value).to.be.equal('100');563  });564565  itEth('Events emitted for transferFrom()', async ({helper}) => {566    const [bob] = await helper.arrange.createAccounts([10n], donor);567    const receiver = helper.eth.createAccount();568    const collection = await helper.ft.mintCollection(alice);569    await collection.mint(alice, 200n);570    await collection.approveTokens(alice, {Substrate: bob.address}, 100n);571572    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);573    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft');574575    const events: any = [];576    contract.events.allEvents((_: any, event: any) => {577      events.push(event);578    });579580    await collection.transferFrom(bob, {Substrate: alice.address}, {Ethereum: receiver}, 51n);581    if (events.length == 0) await helper.wait.newBlocks(1);582    let event = events[0];583584    expect(event.event).to.be.equal('Transfer');585    expect(event.address).to.be.equal(collectionAddress);586    expect(event.returnValues.from).to.be.equal(helper.address.substrateToEth(alice.address));587    expect(event.returnValues.to).to.be.equal(receiver);588    expect(event.returnValues.value).to.be.equal('51');589590    event = events[1];591    expect(event.event).to.be.equal('Approval');592    expect(event.address).to.be.equal(collectionAddress);593    expect(event.returnValues.owner).to.be.equal(helper.address.substrateToEth(alice.address));594    expect(event.returnValues.spender).to.be.equal(helper.address.substrateToEth(bob.address));595    expect(event.returnValues.value).to.be.equal('49');596  });597598  itEth('Events emitted for transfer()', async ({helper}) => {599    const receiver = helper.eth.createAccount();600    const collection = await helper.ft.mintCollection(alice);601    await collection.mint(alice, 200n);602603    const collectionAddress = helper.ethAddress.fromCollectionId(collection.collectionId);604    const contract = helper.ethNativeContract.collection(collectionAddress, 'ft');605606    const events: any = [];607    contract.events.allEvents((_: any, event: any) => {608      events.push(event);609    });610    611    await collection.transfer(alice, {Ethereum:receiver}, 51n);612    if (events.length == 0) await helper.wait.newBlocks(1);613    const event = events[0];614615    expect(event.event).to.be.equal('Transfer');616    expect(event.address).to.be.equal(collectionAddress);617    expect(event.returnValues.from).to.be.equal(helper.address.substrateToEth(alice.address));618    expect(event.returnValues.to).to.be.equal(receiver);619    expect(event.returnValues.value).to.be.equal('51');620  });621622  itEth('Events emitted for transferFromCross()', async ({helper}) => {623    const sender = await helper.eth.createAccountWithBalance(donor, 100n);624625    const collection = await helper.ft.mintCollection(owner, {name: 'A', description: 'B', tokenPrefix: 'C'}, 0);626627    const receiver = helper.eth.createAccount();628629    await collection.mint(owner, 200n, {Substrate: owner.address});630    await collection.approveTokens(owner, {Ethereum: sender}, 100n);631632    const address = helper.ethAddress.fromCollectionId(collection.collectionId);633    const contract = helper.ethNativeContract.collection(address, 'ft');634635    const from = helper.ethCrossAccount.fromKeyringPair(owner);636    const to = helper.ethCrossAccount.fromAddress(receiver);637    638    const result = await contract.methods.transferFromCross(from, to, 51).send({from: sender});639640    expect(result.events).to.be.like({641      Transfer: {642        address,643        event: 'Transfer',644        returnValues: {645          from: helper.address.substrateToEth(owner.address),646          to: receiver,647          value: '51',648        },649      },650      Approval: {651        address,652        event: 'Approval',653        returnValues: {654          owner: helper.address.substrateToEth(owner.address),655          spender: sender,656          value: '49',657        },658      }});659  });660});
modifiedtests/src/eth/nonFungible.test.tsdiffbeforeafterboth
--- a/tests/src/eth/nonFungible.test.ts
+++ b/tests/src/eth/nonFungible.test.ts
@@ -194,9 +194,9 @@
         .map(p => {
           return {
             key: p.key, permission: {
-              tokenOwner: true,
+              tokenOwner: false,
               collectionAdmin: true,
-              mutable: true,
+              mutable: false,
             },
           };
         });
@@ -482,6 +482,7 @@
     expect(await token2.doesExist()).to.be.false;
   });
 
+  // TODO combine all approve tests in one place
   itEth('Can perform approveCross()', async ({helper}) => {
     // arrange: create accounts
     const owner = await helper.eth.createAccountWithBalance(donor, 100n);
@@ -530,6 +531,17 @@
     expect(await helper.nft.getTokenOwner(collection.collectionId, token2.tokenId)).to.deep.eq({Ethereum: receiverEth.toLowerCase()});
   });
 
+  itEth('Non-owner and non admin cannot approveCross', async ({helper}) => {
+    const nonOwner = await helper.eth.createAccountWithBalance(donor);
+    const nonOwnerCross = helper.ethCrossAccount.fromAddress(nonOwner);
+    const owner = await helper.eth.createAccountWithBalance(donor);
+    const collection = await helper.nft.mintCollection(minter, {name: 'A', description: 'B', tokenPrefix: 'C'});
+    const collectionEvm = helper.ethNativeContract.collection(helper.ethAddress.fromCollectionId(collection.collectionId), 'nft');
+    const token = await collection.mintToken(minter, {Ethereum: owner});
+
+    await expect(collectionEvm.methods.approveCross(nonOwnerCross, token.tokenId).call({from: nonOwner})).to.be.rejectedWith('CantApproveMoreThanOwned');
+  });
+
   itEth('Can reaffirm approved address', async ({helper}) => {
     const owner = await helper.eth.createAccountWithBalance(donor, 100n);
     const ownerCrossEth = helper.ethCrossAccount.fromAddress(owner);
modifiedtests/src/eth/reFungible.test.tsdiffbeforeafterboth
--- a/tests/src/eth/reFungible.test.ts
+++ b/tests/src/eth/reFungible.test.ts
@@ -150,9 +150,11 @@
       const receiverCrossSub = helper.ethCrossAccount.fromKeyringPair(receiverSub);
 
       const properties = Array(5).fill(0).map((_, i) => { return {key: `key_${i}`, value: Buffer.from(`value_${i}`)}; });
-      const permissions: ITokenPropertyPermission[] = properties.map(p => { return {key: p.key, permission: {tokenOwner: true,
+      const permissions: ITokenPropertyPermission[] = properties.map(p => { return {key: p.key, permission: {
+        tokenOwner: false,
         collectionAdmin: true,
-        mutable: true}}; });
+        mutable: false}};
+      });
     
     
       const collection = await helper.rft.mintCollection(minter, {
modifiedtests/src/eth/reFungibleToken.test.tsdiffbeforeafterboth
--- a/tests/src/eth/reFungibleToken.test.ts
+++ b/tests/src/eth/reFungibleToken.test.ts
@@ -207,7 +207,20 @@
       //TO-DO expect with future allowanceCross(owner, spenderCrossEth).call()
     }
   });
-  
+
+  itEth('Non-owner and non admin cannot approveCross', async ({helper}) => {
+    const nonOwner = await helper.eth.createAccountWithBalance(donor);
+    const nonOwnerCross = helper.ethCrossAccount.fromAddress(nonOwner);
+    const owner = await helper.eth.createAccountWithBalance(donor);
+    const collection = await helper.rft.mintCollection(alice, {name: 'A', description: 'B', tokenPrefix: 'C'});
+    const token = await collection.mintToken(alice, 100n, {Ethereum: owner});
+
+    const tokenAddress = helper.ethAddress.fromTokenId(collection.collectionId, token.tokenId);
+    const tokenEvm = helper.ethNativeContract.rftToken(tokenAddress, owner);
+
+    await expect(tokenEvm.methods.approveCross(nonOwnerCross, 20).call({from: nonOwner})).to.be.rejectedWith('CantApproveMoreThanOwned');
+  });
+
   [
     'transferFrom',
     'transferFromCross',