difftreelog
feat(nonfungible) benchmarking
in: master
5 files changed
pallets/nonfungible/Cargo.tomldiffbeforeafterboth--- a/pallets/nonfungible/Cargo.toml
+++ b/pallets/nonfungible/Cargo.toml
@@ -20,6 +20,7 @@
evm-coder = { default-features = false, path = '../../crates/evm-coder' }
pallet-evm-coder-substrate = { default-features = false, path = '../evm-coder-substrate' }
ethereum = { default-features = false, version = "0.9.0" }
+frame-benchmarking = { default-features = false, optional = true, git = 'https://github.com/paritytech/substrate.git', branch = 'polkadot-v0.9.10' }
[features]
default = ["std"]
@@ -33,5 +34,10 @@
"evm-coder/std",
"ethereum/std",
"pallet-evm-coder-substrate/std",
+ 'frame-benchmarking/std',
+]
+runtime-benchmarks = [
+ 'frame-benchmarking',
+ 'frame-support/runtime-benchmarks',
+ 'frame-system/runtime-benchmarks',
]
-runtime-benchmarks = []
pallets/nonfungible/src/benchmarking.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/benchmarking.rs
+++ b/pallets/nonfungible/src/benchmarking.rs
@@ -1 +1,101 @@
-#![cfg(feature = "runtime-benchmarking")]
+use super::*;
+use crate::{Pallet, Config, NonfungibleHandle};
+
+use sp_std::prelude::*;
+use pallet_common::benchmarking::{create_collection_raw, create_data};
+use frame_benchmarking::{benchmarks, account};
+use nft_data_structs::{CollectionMode, MAX_ITEMS_PER_BATCH};
+use pallet_common::bench_init;
+use core::convert::TryInto;
+
+const SEED: u32 = 1;
+
+fn create_max_item_data<T: Config>(owner: T::CrossAccountId) -> CreateItemData<T> {
+ let const_data = create_data(CUSTOM_DATA_LIMIT as usize).try_into().unwrap();
+ let variable_data = create_data(CUSTOM_DATA_LIMIT as usize).try_into().unwrap();
+ CreateItemData {
+ const_data,
+ variable_data,
+ owner,
+ }
+}
+fn create_max_item<T: Config>(
+ collection: &NonfungibleHandle<T>,
+ sender: &T::CrossAccountId,
+ owner: T::CrossAccountId,
+) -> Result<TokenId, DispatchError> {
+ <Pallet<T>>::create_item(&collection, sender, create_max_item_data(owner))?;
+ Ok(TokenId(<TokensMinted<T>>::get(&collection.id)))
+}
+
+fn create_collection<T: Config>(
+ owner: T::AccountId,
+) -> Result<NonfungibleHandle<T>, DispatchError> {
+ create_collection_raw(
+ owner,
+ CollectionMode::NFT,
+ <Pallet<T>>::init_collection,
+ NonfungibleHandle::cast,
+ )
+}
+
+benchmarks! {
+ create_item {
+ bench_init!{
+ owner: sub; collection: collection(owner);
+ sender: cross_from_sub(owner); to: cross_sub;
+ };
+ }: {create_max_item(&collection, &sender, to.clone())?}
+
+ create_multiple_items {
+ let b in 0..MAX_ITEMS_PER_BATCH;
+ bench_init!{
+ owner: sub; collection: collection(owner);
+ sender: cross_from_sub(owner); to: cross_sub;
+ };
+ let data = (0..b).map(|_| create_max_item_data(to.clone())).collect();
+ }: {<Pallet<T>>::create_multiple_items(&collection, &sender, data)?}
+
+ burn_item {
+ bench_init!{
+ owner: sub; collection: collection(owner);
+ sender: cross_from_sub(owner); burner: cross_sub;
+ };
+ let item = create_max_item(&collection, &sender, burner.clone())?;
+ }: {<Pallet<T>>::burn(&collection, &burner, item)?}
+
+ transfer {
+ bench_init!{
+ owner: sub; collection: collection(owner);
+ owner: cross_from_sub; sender: cross_sub; receiver: cross_sub;
+ };
+ let item = create_max_item(&collection, &owner, sender.clone())?;
+ }: {<Pallet<T>>::transfer(&collection, &sender, &receiver, item)?}
+
+ approve {
+ bench_init!{
+ owner: sub; collection: collection(owner);
+ owner: cross_from_sub; sender: cross_sub; spender: cross_sub;
+ };
+ let item = create_max_item(&collection, &owner, sender.clone())?;
+ }: {<Pallet<T>>::set_allowance(&collection, &sender, item, Some(&spender))?}
+
+ transfer_from {
+ bench_init!{
+ owner: sub; collection: collection(owner);
+ owner: cross_from_sub; sender: cross_sub; spender: cross_sub; receiver: cross_sub;
+ };
+ let item = create_max_item(&collection, &owner, sender.clone())?;
+ <Pallet<T>>::set_allowance(&collection, &sender, item, Some(&spender))?;
+ }: {<Pallet<T>>::transfer_from(&collection, &spender, &sender, &receiver, item)?}
+
+ set_variable_metadata {
+ let b in 0..CUSTOM_DATA_LIMIT;
+ bench_init!{
+ owner: sub; collection: collection(owner);
+ owner: cross_from_sub; sender: cross_sub;
+ };
+ let item = create_max_item(&collection, &owner, sender.clone())?;
+ let data = create_data(b as usize);
+ }: {<Pallet<T>>::set_variable_metadata(&collection, &sender, item, data)?}
+}
pallets/nonfungible/src/common.rsdiffbeforeafterboth9use sp_std::vec::Vec;9use sp_std::vec::Vec;101011use crate::{11use crate::{12 AccountBalance, Allowance, Config, CreateItemData, DataKind, Error, NonfungibleHandle, Owned,12 AccountBalance, Allowance, Config, CreateItemData, Error, NonfungibleHandle, Owned, Pallet,13 Owner, Pallet, SelfWeightOf, TokenData, weights::WeightInfo,13 SelfWeightOf, TokenData, weights::WeightInfo, TokensMinted,14};14};151516pub struct CommonWeights<T: Config>(PhantomData<T>);16pub struct CommonWeights<T: Config>(PhantomData<T>);39 <SelfWeightOf<T>>::transfer_from()39 <SelfWeightOf<T>>::transfer_from()40 }40 }414142 fn set_variable_metadata(_bytes: u32) -> Weight {42 fn set_variable_metadata(bytes: u32) -> Weight {43 <SelfWeightOf<T>>::set_variable_metadata()43 <SelfWeightOf<T>>::set_variable_metadata(bytes)44 }44 }45}45}464667 ) -> DispatchResultWithPostInfo {67 ) -> DispatchResultWithPostInfo {68 with_weight(68 with_weight(69 <Pallet<T>>::create_item(self, &sender, map_create_data(data, &to)?),69 <Pallet<T>>::create_item(self, &sender, map_create_data(data, &to)?),70 <SelfWeightOf<T>>::create_item(),70 <CommonWeights<T>>::create_item(),71 )71 )72 }72 }737385 let amount = data.len();85 let amount = data.len();86 with_weight(86 with_weight(87 <Pallet<T>>::create_multiple_items(self, &sender, data),87 <Pallet<T>>::create_multiple_items(self, &sender, data),88 <SelfWeightOf<T>>::create_multiple_items(amount as u32),88 <CommonWeights<T>>::create_multiple_items(amount as u32),89 )89 )90 }90 }919199 if amount == 1 {99 if amount == 1 {100 with_weight(100 with_weight(101 <Pallet<T>>::burn(&self, &sender, token),101 <Pallet<T>>::burn(&self, &sender, token),102 <SelfWeightOf<T>>::burn_item(),102 <CommonWeights<T>>::burn_item(),103 )103 )104 } else {104 } else {105 Ok(().into())105 Ok(().into())117 if amount == 1 {117 if amount == 1 {118 with_weight(118 with_weight(119 <Pallet<T>>::transfer(&self, &from, &to, token),119 <Pallet<T>>::transfer(&self, &from, &to, token),120 <SelfWeightOf<T>>::transfer(),120 <CommonWeights<T>>::transfer(),121 )121 )122 } else {122 } else {123 Ok(().into())123 Ok(().into())139 } else {139 } else {140 <Pallet<T>>::set_allowance(&self, &sender, token, None)140 <Pallet<T>>::set_allowance(&self, &sender, token, None)141 },141 },142 <SelfWeightOf<T>>::approve(),142 <CommonWeights<T>>::approve(),143 )143 )144 }144 }145145156 if amount == 1 {156 if amount == 1 {157 with_weight(157 with_weight(158 <Pallet<T>>::transfer_from(&self, &sender, &from, &to, token),158 <Pallet<T>>::transfer_from(&self, &sender, &from, &to, token),159 <SelfWeightOf<T>>::transfer_from(),159 <CommonWeights<T>>::transfer_from(),160 )160 )161 } else {161 } else {162 Ok(().into())162 Ok(().into())169 token: TokenId,169 token: TokenId,170 data: Vec<u8>,170 data: Vec<u8>,171 ) -> DispatchResultWithPostInfo {171 ) -> DispatchResultWithPostInfo {172 let len = data.len();172 with_weight(173 with_weight(173 <Pallet<T>>::set_variable_metadata(&self, &sender, token, data),174 <Pallet<T>>::set_variable_metadata(&self, &sender, token, data),174 <SelfWeightOf<T>>::set_variable_metadata(),175 <CommonWeights<T>>::set_variable_metadata(len as u32),175 )176 )176 }177 }177178pallets/nonfungible/src/lib.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/lib.rs
+++ b/pallets/nonfungible/src/lib.rs
@@ -16,6 +16,7 @@
use codec::{Encode, Decode};
pub use pallet::*;
+#[cfg(feature = "runtime-benchmarks")]
pub mod benchmarking;
pub mod common;
pub mod erc;
pallets/nonfungible/src/weights.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/weights.rs
+++ b/pallets/nonfungible/src/weights.rs
@@ -1,3 +1,27 @@
+// Template adopted from https://github.com/paritytech/substrate/blob/master/.maintain/frame-weight-template.hbs
+
+//! Autogenerated weights for pallet_nonfungible
+//!
+//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev
+//! DATE: 2021-10-21, STEPS: `50`, REPEAT: 20, LOW RANGE: `[]`, HIGH RANGE: `[]`
+//! EXECUTION: None, WASM-EXECUTION: Compiled, CHAIN: None, DB CACHE: 128
+
+// Executed Command:
+// target/release/nft
+// benchmark
+// --pallet
+// pallet-nonfungible
+// --wasm-execution
+// compiled
+// --extrinsic
+// *
+// --template
+// .maintain/frame-weight-template.hbs
+// --steps=50
+// --repeat=20
+// --output=./pallets/nonfungible/src/weights.rs
+
+
#![cfg_attr(rustfmt, rustfmt_skip)]
#![allow(unused_parens)]
#![allow(unused_imports)]
@@ -5,33 +29,144 @@
use frame_support::{traits::Get, weights::{Weight, constants::RocksDbWeight}};
use sp_std::marker::PhantomData;
+/// Weight functions needed for pallet_nonfungible.
pub trait WeightInfo {
fn create_item() -> Weight;
- fn create_multiple_items(b: u32) -> Weight;
+ fn create_multiple_items(b: u32, ) -> Weight;
fn burn_item() -> Weight;
fn transfer() -> Weight;
fn approve() -> Weight;
fn transfer_from() -> Weight;
- fn set_variable_metadata() -> Weight;
+ fn set_variable_metadata(b: u32, ) -> Weight;
}
+/// Weights for pallet_nonfungible using the Substrate node and recommended hardware.
pub struct SubstrateWeight<T>(PhantomData<T>);
impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
- fn create_item() -> Weight {0}
- fn create_multiple_items(_b: u32) -> Weight {0}
- fn burn_item() -> Weight {0}
- fn transfer() -> Weight {0}
- fn approve() -> Weight {0}
- fn transfer_from() -> Weight {0}
- fn set_variable_metadata() -> Weight {0}
+ // Storage: Nonfungible TokensMinted (r:1 w:1)
+ // Storage: Nonfungible AccountBalance (r:1 w:1)
+ // Storage: Nonfungible TokenData (r:0 w:1)
+ // Storage: Nonfungible Owned (r:0 w:1)
+ fn create_item() -> Weight {
+ (16_902_000 as Weight)
+ .saturating_add(T::DbWeight::get().reads(2 as Weight))
+ .saturating_add(T::DbWeight::get().writes(4 as Weight))
+ }
+ // Storage: Nonfungible TokensMinted (r:1 w:1)
+ // Storage: Nonfungible AccountBalance (r:1 w:1)
+ // Storage: Nonfungible TokenData (r:0 w:4)
+ // Storage: Nonfungible Owned (r:0 w:4)
+ fn create_multiple_items(b: u32, ) -> Weight {
+ (15_860_000 as Weight)
+ // Standard Error: 5_000
+ .saturating_add((3_916_000 as Weight).saturating_mul(b as Weight))
+ .saturating_add(T::DbWeight::get().reads(2 as Weight))
+ .saturating_add(T::DbWeight::get().writes(2 as Weight))
+ .saturating_add(T::DbWeight::get().writes((2 as Weight).saturating_mul(b as Weight)))
+ }
+ // Storage: Nonfungible TokenData (r:1 w:1)
+ // Storage: Nonfungible TokensBurnt (r:1 w:1)
+ // Storage: Nonfungible Allowance (r:1 w:0)
+ // Storage: Nonfungible Owned (r:0 w:1)
+ fn burn_item() -> Weight {
+ (17_966_000 as Weight)
+ .saturating_add(T::DbWeight::get().reads(3 as Weight))
+ .saturating_add(T::DbWeight::get().writes(3 as Weight))
+ }
+ // Storage: Nonfungible TokenData (r:1 w:1)
+ // Storage: Nonfungible AccountBalance (r:2 w:2)
+ // Storage: Nonfungible Allowance (r:1 w:0)
+ // Storage: Nonfungible Owned (r:0 w:2)
+ fn transfer() -> Weight {
+ (23_886_000 as Weight)
+ .saturating_add(T::DbWeight::get().reads(4 as Weight))
+ .saturating_add(T::DbWeight::get().writes(5 as Weight))
+ }
+ // Storage: Nonfungible TokenData (r:1 w:0)
+ // Storage: Nonfungible Allowance (r:1 w:1)
+ fn approve() -> Weight {
+ (14_697_000 as Weight)
+ .saturating_add(T::DbWeight::get().reads(2 as Weight))
+ .saturating_add(T::DbWeight::get().writes(1 as Weight))
+ }
+ // Storage: Nonfungible Allowance (r:1 w:1)
+ // Storage: Nonfungible TokenData (r:1 w:1)
+ // Storage: Nonfungible AccountBalance (r:2 w:2)
+ // Storage: Nonfungible Owned (r:0 w:2)
+ fn transfer_from() -> Weight {
+ (28_001_000 as Weight)
+ .saturating_add(T::DbWeight::get().reads(4 as Weight))
+ .saturating_add(T::DbWeight::get().writes(6 as Weight))
+ }
+ // Storage: Nonfungible TokenData (r:1 w:1)
+ fn set_variable_metadata(_b: u32, ) -> Weight {
+ (6_380_000 as Weight)
+ .saturating_add(T::DbWeight::get().reads(1 as Weight))
+ .saturating_add(T::DbWeight::get().writes(1 as Weight))
+ }
}
+// For backwards compatibility and tests
impl WeightInfo for () {
- fn create_item() -> Weight {0}
- fn create_multiple_items(_b: u32) -> Weight {0}
- fn burn_item() -> Weight {0}
- fn transfer() -> Weight {0}
- fn approve() -> Weight {0}
- fn transfer_from() -> Weight {0}
- fn set_variable_metadata() -> Weight {0}
+ // Storage: Nonfungible TokensMinted (r:1 w:1)
+ // Storage: Nonfungible AccountBalance (r:1 w:1)
+ // Storage: Nonfungible TokenData (r:0 w:1)
+ // Storage: Nonfungible Owned (r:0 w:1)
+ fn create_item() -> Weight {
+ (16_902_000 as Weight)
+ .saturating_add(RocksDbWeight::get().reads(2 as Weight))
+ .saturating_add(RocksDbWeight::get().writes(4 as Weight))
+ }
+ // Storage: Nonfungible TokensMinted (r:1 w:1)
+ // Storage: Nonfungible AccountBalance (r:1 w:1)
+ // Storage: Nonfungible TokenData (r:0 w:4)
+ // Storage: Nonfungible Owned (r:0 w:4)
+ fn create_multiple_items(b: u32, ) -> Weight {
+ (15_860_000 as Weight)
+ // Standard Error: 5_000
+ .saturating_add((3_916_000 as Weight).saturating_mul(b as Weight))
+ .saturating_add(RocksDbWeight::get().reads(2 as Weight))
+ .saturating_add(RocksDbWeight::get().writes(2 as Weight))
+ .saturating_add(RocksDbWeight::get().writes((2 as Weight).saturating_mul(b as Weight)))
+ }
+ // Storage: Nonfungible TokenData (r:1 w:1)
+ // Storage: Nonfungible TokensBurnt (r:1 w:1)
+ // Storage: Nonfungible Allowance (r:1 w:0)
+ // Storage: Nonfungible Owned (r:0 w:1)
+ fn burn_item() -> Weight {
+ (17_966_000 as Weight)
+ .saturating_add(RocksDbWeight::get().reads(3 as Weight))
+ .saturating_add(RocksDbWeight::get().writes(3 as Weight))
+ }
+ // Storage: Nonfungible TokenData (r:1 w:1)
+ // Storage: Nonfungible AccountBalance (r:2 w:2)
+ // Storage: Nonfungible Allowance (r:1 w:0)
+ // Storage: Nonfungible Owned (r:0 w:2)
+ fn transfer() -> Weight {
+ (23_886_000 as Weight)
+ .saturating_add(RocksDbWeight::get().reads(4 as Weight))
+ .saturating_add(RocksDbWeight::get().writes(5 as Weight))
+ }
+ // Storage: Nonfungible TokenData (r:1 w:0)
+ // Storage: Nonfungible Allowance (r:1 w:1)
+ fn approve() -> Weight {
+ (14_697_000 as Weight)
+ .saturating_add(RocksDbWeight::get().reads(2 as Weight))
+ .saturating_add(RocksDbWeight::get().writes(1 as Weight))
+ }
+ // Storage: Nonfungible Allowance (r:1 w:1)
+ // Storage: Nonfungible TokenData (r:1 w:1)
+ // Storage: Nonfungible AccountBalance (r:2 w:2)
+ // Storage: Nonfungible Owned (r:0 w:2)
+ fn transfer_from() -> Weight {
+ (28_001_000 as Weight)
+ .saturating_add(RocksDbWeight::get().reads(4 as Weight))
+ .saturating_add(RocksDbWeight::get().writes(6 as Weight))
+ }
+ // Storage: Nonfungible TokenData (r:1 w:1)
+ fn set_variable_metadata(_b: u32, ) -> Weight {
+ (6_380_000 as Weight)
+ .saturating_add(RocksDbWeight::get().reads(1 as Weight))
+ .saturating_add(RocksDbWeight::get().writes(1 as Weight))
+ }
}