difftreelog
refactor property writer / fix set_token_props weight
in: master
27 files changed
pallets/balances-adapter/src/common.rsdiffbeforeafterboth--- a/pallets/balances-adapter/src/common.rs
+++ b/pallets/balances-adapter/src/common.rs
@@ -30,15 +30,7 @@
Weight::default()
}
- fn delete_collection_properties(_amount: u32) -> Weight {
- Weight::default()
- }
-
fn set_token_properties(_amount: u32) -> Weight {
- Weight::default()
- }
-
- fn delete_token_properties(_amount: u32) -> Weight {
Weight::default()
}
@@ -63,18 +55,6 @@
}
fn burn_from() -> Weight {
- Weight::default()
- }
-
- fn burn_recursively_self_raw() -> Weight {
- Weight::default()
- }
-
- fn burn_recursively_breadth_raw(_amount: u32) -> Weight {
- Weight::default()
- }
-
- fn token_owner() -> Weight {
Weight::default()
}
@@ -124,16 +104,6 @@
_sender: <T>::CrossAccountId,
_token: TokenId,
_amount: u128,
- ) -> frame_support::pallet_prelude::DispatchResultWithPostInfo {
- fail!(<pallet_common::Error<T>>::UnsupportedOperation);
- }
-
- fn burn_item_recursively(
- &self,
- _sender: <T>::CrossAccountId,
- _token: TokenId,
- _self_budget: &dyn up_data_structs::budget::Budget,
- _breadth_budget: &dyn up_data_structs::budget::Budget,
) -> frame_support::pallet_prelude::DispatchResultWithPostInfo {
fail!(<pallet_common::Error<T>>::UnsupportedOperation);
}
pallets/common/src/benchmarking.rsdiffbeforeafterboth--- a/pallets/common/src/benchmarking.rs
+++ b/pallets/common/src/benchmarking.rs
@@ -34,7 +34,7 @@
MAX_TOKEN_PREFIX_LENGTH,
};
-use crate::{CollectionHandle, Config, Pallet};
+use crate::{BenchmarkPropertyWriter, CollectionHandle, Config, Pallet};
const SEED: u32 = 1;
@@ -123,16 +123,6 @@
CollectionMode::NFT,
|owner: T::CrossAccountId, data| <Pallet<T>>::init_collection(owner.clone(), owner, data),
|h| h,
- )
-}
-
-pub fn load_is_admin_and_property_permissions<T: Config>(
- collection: &CollectionHandle<T>,
- sender: &T::CrossAccountId,
-) -> (bool, PropertiesPermissionMap) {
- (
- collection.is_owner_or_admin(sender),
- <Pallet<T>>::property_permissions(collection.id),
)
}
@@ -272,7 +262,7 @@
#[block]
{
- load_is_admin_and_property_permissions(&collection, &sender);
+ <BenchmarkPropertyWriter<T>>::load_collection_info(&&collection, &sender);
}
Ok(())
pallets/common/src/lib.rsdiffbeforeafterboth--- a/pallets/common/src/lib.rs
+++ b/pallets/common/src/lib.rs
@@ -872,7 +872,7 @@
}
/// Value representation with delayed initialization time.
-pub struct LazyValue<T, F: FnOnce() -> T> {
+pub struct LazyValue<T, F> {
value: Option<T>,
f: Option<F>,
}
@@ -1902,7 +1902,9 @@
/// Collection property deletion weight.
///
/// * `amount`- The number of properties to set.
- fn delete_collection_properties(amount: u32) -> Weight;
+ fn delete_collection_properties(amount: u32) -> Weight {
+ Self::set_collection_properties(amount)
+ }
/// Token property setting weight.
///
@@ -1912,7 +1914,9 @@
/// Token property deletion weight.
///
/// * `amount`- The number of properties to delete.
- fn delete_token_properties(amount: u32) -> Weight;
+ fn delete_token_properties(amount: u32) -> Weight {
+ Self::set_token_properties(amount)
+ }
/// Token property permissions set weight.
///
@@ -1934,30 +1938,6 @@
/// The price of burning a token from another user.
fn burn_from() -> Weight;
- /// Differs from burn_item in case of Fungible and Refungible, as it should burn
- /// whole users's balance.
- ///
- /// This method shouldn't be used directly, as it doesn't count breadth price, use [burn_recursively](CommonWeightInfo::burn_recursively) instead
- fn burn_recursively_self_raw() -> Weight;
-
- /// Cost of iterating over `amount` children while burning, without counting child burning itself.
- ///
- /// This method shouldn't be used directly, as it doesn't count depth price, use [burn_recursively](CommonWeightInfo::burn_recursively) instead
- fn burn_recursively_breadth_raw(amount: u32) -> Weight;
-
- /// The price of recursive burning a token.
- ///
- /// `max_selfs` - The maximum burning weight of the token itself.
- /// `max_breadth` - The maximum number of nested tokens to burn.
- fn burn_recursively(max_selfs: u32, max_breadth: u32) -> Weight {
- Self::burn_recursively_self_raw()
- .saturating_mul(max_selfs.max(1) as u64)
- .saturating_add(Self::burn_recursively_breadth_raw(max_breadth))
- }
-
- /// The price of retrieving token owner
- fn token_owner() -> Weight;
-
/// The price of setting approval for all
fn set_allowance_for_all() -> Weight;
@@ -2029,20 +2009,6 @@
amount: u128,
) -> DispatchResultWithPostInfo;
- /// Burn token and all nested tokens recursievly.
- ///
- /// * `sender` - The user who owns the token.
- /// * `token` - Token id that will burned.
- /// * `self_budget` - The budget that can be spent on burning tokens.
- /// * `breadth_budget` - The budget that can be spent on burning nested tokens.
- fn burn_item_recursively(
- &self,
- sender: T::CrossAccountId,
- token: TokenId,
- self_budget: &dyn Budget,
- breadth_budget: &dyn Budget,
- ) -> DispatchResultWithPostInfo;
-
/// Set collection properties.
///
/// * `sender` - Must be either the owner of the collection or its admin.
@@ -2373,14 +2339,6 @@
}
}
}
-
-/// A marker structure that enables the writer implementation
-/// to provide the interface to write properties to **newly created** tokens.
-pub struct NewTokenPropertyWriter;
-
-/// A marker structure that enables the writer implementation
-/// to provide the interface to write properties to **already existing** tokens.
-pub struct ExistingTokenPropertyWriter;
/// The type-safe interface for writing properties (setting or deleting) to tokens.
/// It has two distinct implementations for newly created tokens and existing ones.
@@ -2388,146 +2346,39 @@
/// This type utilizes the lazy evaluation to avoid repeating the computation
/// of several performance-heavy or PoV-heavy tasks,
/// such as checking the indirect ownership or reading the token property permissions.
-pub struct PropertyWriter<
- 'a,
- T,
- Handle,
- WriterVariant,
- FIsAdmin,
- FPropertyPermissions,
- FCheckTokenExist,
- FGetProperties,
-> where
- T: Config,
- FIsAdmin: FnOnce() -> bool,
- FPropertyPermissions: FnOnce() -> PropertiesPermissionMap,
-{
+pub struct PropertyWriter<'a, WriterVariant, T, Handle, FIsAdmin, FPropertyPermissions> {
collection: &'a Handle,
- is_collection_admin: LazyValue<bool, FIsAdmin>,
- property_permissions: LazyValue<PropertiesPermissionMap, FPropertyPermissions>,
- check_token_exist: FCheckTokenExist,
- get_properties: FGetProperties,
+ collection_lazy_info: PropertyWriterLazyCollectionInfo<FIsAdmin, FPropertyPermissions>,
_phantom: PhantomData<(T, WriterVariant)>,
}
-impl<'a, T, Handle, FIsAdmin, FPropertyPermissions, FCheckTokenExist, FGetProperties>
- PropertyWriter<
- 'a,
- T,
- Handle,
- NewTokenPropertyWriter,
- FIsAdmin,
- FPropertyPermissions,
- FCheckTokenExist,
- FGetProperties,
- > where
+impl<'a, T, Handle, WriterVariant, FIsAdmin, FPropertyPermissions>
+ PropertyWriter<'a, WriterVariant, T, Handle, FIsAdmin, FPropertyPermissions>
+where
T: Config,
Handle: CommonCollectionOperations<T> + Deref<Target = CollectionHandle<T>>,
FIsAdmin: FnOnce() -> bool,
FPropertyPermissions: FnOnce() -> PropertiesPermissionMap,
- FCheckTokenExist: Copy + FnOnce(TokenId) -> bool,
- FGetProperties: Copy + FnOnce(TokenId) -> TokenProperties,
{
- /// A function to write properties to a **newly created** token.
- pub fn write_token_properties(
+ fn internal_write_token_properties<FCheckTokenExist, FCheckTokenOwner, FGetProperties>(
&mut self,
- mint_target_is_sender: bool,
token_id: TokenId,
- properties_updates: impl Iterator<Item = Property>,
- log: evm_coder::ethereum::Log,
- ) -> DispatchResult {
- self.internal_write_token_properties(
- token_id,
- properties_updates.map(|p| (p.key, Some(p.value))),
- |_| Ok(mint_target_is_sender),
- log,
- )
- }
-}
-
-impl<'a, T, Handle, FIsAdmin, FPropertyPermissions, FCheckTokenExist, FGetProperties>
- PropertyWriter<
- 'a,
- T,
- Handle,
- ExistingTokenPropertyWriter,
- FIsAdmin,
- FPropertyPermissions,
- FCheckTokenExist,
- FGetProperties,
- > where
- T: Config,
- Handle: CommonCollectionOperations<T> + Deref<Target = CollectionHandle<T>>,
- FIsAdmin: FnOnce() -> bool,
- FPropertyPermissions: FnOnce() -> PropertiesPermissionMap,
- FCheckTokenExist: Copy + FnOnce(TokenId) -> bool,
- FGetProperties: Copy + FnOnce(TokenId) -> TokenProperties,
-{
- /// A function to write properties to an **already existing** token.
- pub fn write_token_properties(
- &mut self,
- sender: &T::CrossAccountId,
- token_id: TokenId,
- properties_updates: impl Iterator<Item = (PropertyKey, Option<PropertyValue>)>,
- nesting_budget: &dyn Budget,
- log: evm_coder::ethereum::Log,
- ) -> DispatchResult {
- self.internal_write_token_properties(
- token_id,
- properties_updates,
- |collection| collection.check_token_indirect_owner(token_id, sender, nesting_budget),
- log,
- )
- }
-}
-
-impl<
- 'a,
- T,
- Handle,
- WriterVariant,
- FIsAdmin,
- FPropertyPermissions,
- FCheckTokenExist,
- FGetProperties,
- >
- PropertyWriter<
- 'a,
- T,
- Handle,
- WriterVariant,
- FIsAdmin,
- FPropertyPermissions,
- FCheckTokenExist,
- FGetProperties,
- > where
- T: Config,
- Handle: CommonCollectionOperations<T> + Deref<Target = CollectionHandle<T>>,
- FIsAdmin: FnOnce() -> bool,
- FPropertyPermissions: FnOnce() -> PropertiesPermissionMap,
- FCheckTokenExist: Copy + FnOnce(TokenId) -> bool,
- FGetProperties: Copy + FnOnce(TokenId) -> TokenProperties,
-{
- fn internal_write_token_properties<FCheckTokenOwner>(
- &mut self,
- token_id: TokenId,
+ mut token_lazy_info: PropertyWriterLazyTokenInfo<
+ FCheckTokenExist,
+ FCheckTokenOwner,
+ FGetProperties,
+ >,
properties_updates: impl Iterator<Item = (PropertyKey, Option<PropertyValue>)>,
- check_token_owner: FCheckTokenOwner,
log: evm_coder::ethereum::Log,
) -> DispatchResult
where
- FCheckTokenOwner: FnOnce(&Handle) -> Result<bool, DispatchError>,
+ FCheckTokenExist: FnOnce() -> bool,
+ FCheckTokenOwner: FnOnce() -> Result<bool, DispatchError>,
+ FGetProperties: FnOnce() -> TokenProperties,
{
- let get_properties = self.get_properties;
- let mut stored_properties = LazyValue::new(move || get_properties(token_id));
-
- let mut is_token_owner = LazyValue::new(|| check_token_owner(self.collection));
-
- let check_token_exist = self.check_token_exist;
- let mut is_token_exist = LazyValue::new(move || check_token_exist(token_id));
-
for (key, value) in properties_updates {
let permission = self
+ .collection_lazy_info
.property_permissions
.value()
.get(&key)
@@ -2536,7 +2387,11 @@
match permission {
PropertyPermission { mutable: false, .. }
- if stored_properties.value().get(&key).is_some() =>
+ if token_lazy_info
+ .stored_properties
+ .value()
+ .get(&key)
+ .is_some() =>
{
return Err(<Error<T>>::NoPermission.into());
}
@@ -2548,15 +2403,16 @@
} => check_token_permissions::<T, _, _, _>(
collection_admin,
token_owner,
- &mut self.is_collection_admin,
- &mut is_token_owner,
- &mut is_token_exist,
+ &mut self.collection_lazy_info.is_collection_admin,
+ &mut token_lazy_info.is_token_owner,
+ &mut token_lazy_info.is_token_exist,
)?,
}
match value {
Some(value) => {
- stored_properties
+ token_lazy_info
+ .stored_properties
.value_mut()
.try_set(key.clone(), value)
.map_err(<Error<T>>::from)?;
@@ -2568,7 +2424,8 @@
));
}
None => {
- stored_properties
+ token_lazy_info
+ .stored_properties
.value_mut()
.remove(&key)
.map_err(<Error<T>>::from)?;
@@ -2582,142 +2439,330 @@
}
}
- let properties_changed = stored_properties.has_value();
+ let properties_changed = token_lazy_info.stored_properties.has_value();
if properties_changed {
<PalletEvm<T>>::deposit_log(log);
self.collection
- .set_token_properties_raw(token_id, stored_properties.into_inner());
+ .set_token_properties_raw(token_id, token_lazy_info.stored_properties.into_inner());
}
Ok(())
}
}
-/// Create a [`PropertyWriter`] for newly created tokens.
-pub fn property_writer_for_new_token<'a, T, Handle>(
- collection: &'a Handle,
- sender: &'a T::CrossAccountId,
-) -> PropertyWriter<
- 'a,
- T,
- Handle,
- NewTokenPropertyWriter,
- impl FnOnce() -> bool + 'a,
- impl FnOnce() -> PropertiesPermissionMap + 'a,
- impl Copy + FnOnce(TokenId) -> bool + 'a,
- impl Copy + FnOnce(TokenId) -> TokenProperties + 'a,
->
+/// A helper structure for the [`PropertyWriter`] that holds
+/// the collection-related info. The info is loaded using lazy evaluation.
+/// This info is common for any token for which we write properties.
+pub struct PropertyWriterLazyCollectionInfo<FIsAdmin, FPropertyPermissions> {
+ is_collection_admin: LazyValue<bool, FIsAdmin>,
+ property_permissions: LazyValue<PropertiesPermissionMap, FPropertyPermissions>,
+}
+
+/// A helper structure for the [`PropertyWriter`] that holds
+/// the token-related info. The info is loaded using lazy evaluation.
+pub struct PropertyWriterLazyTokenInfo<FCheckTokenExist, FCheckTokenOwner, FGetProperties> {
+ is_token_exist: LazyValue<bool, FCheckTokenExist>,
+ is_token_owner: LazyValue<Result<bool, DispatchError>, FCheckTokenOwner>,
+ stored_properties: LazyValue<TokenProperties, FGetProperties>,
+}
+
+impl<FCheckTokenExist, FCheckTokenOwner, FGetProperties>
+ PropertyWriterLazyTokenInfo<FCheckTokenExist, FCheckTokenOwner, FGetProperties>
where
+ FCheckTokenExist: FnOnce() -> bool,
+ FCheckTokenOwner: FnOnce() -> Result<bool, DispatchError>,
+ FGetProperties: FnOnce() -> TokenProperties,
+{
+ /// Create a lazy token info.
+ pub fn new(
+ check_token_exist: FCheckTokenExist,
+ check_token_owner: FCheckTokenOwner,
+ get_token_properties: FGetProperties,
+ ) -> Self {
+ Self {
+ is_token_exist: LazyValue::new(check_token_exist),
+ is_token_owner: LazyValue::new(check_token_owner),
+ stored_properties: LazyValue::new(get_token_properties),
+ }
+ }
+}
+
+/// A marker structure that enables the writer implementation
+/// to provide the interface to write properties to **newly created** tokens.
+pub struct NewTokenPropertyWriter<T>(PhantomData<T>);
+impl<T: Config> NewTokenPropertyWriter<T> {
+ /// Creates a [`PropertyWriter`] for **newly created** tokens.
+ pub fn new<'a, Handle>(
+ collection: &'a Handle,
+ sender: &'a T::CrossAccountId,
+ ) -> PropertyWriter<
+ 'a,
+ Self,
+ T,
+ Handle,
+ impl FnOnce() -> bool + 'a,
+ impl FnOnce() -> PropertiesPermissionMap + 'a,
+ >
+ where
+ T: Config,
+ Handle: CommonCollectionOperations<T> + Deref<Target = CollectionHandle<T>>,
+ {
+ PropertyWriter {
+ collection,
+ collection_lazy_info: PropertyWriterLazyCollectionInfo {
+ is_collection_admin: LazyValue::new(|| collection.is_owner_or_admin(sender)),
+ property_permissions: LazyValue::new(|| {
+ <Pallet<T>>::property_permissions(collection.id)
+ }),
+ },
+ _phantom: PhantomData,
+ }
+ }
+}
+
+impl<'a, T, Handle, FIsAdmin, FPropertyPermissions>
+ PropertyWriter<'a, NewTokenPropertyWriter<T>, T, Handle, FIsAdmin, FPropertyPermissions>
+where
T: Config,
Handle: CommonCollectionOperations<T> + Deref<Target = CollectionHandle<T>>,
+ FIsAdmin: FnOnce() -> bool,
+ FPropertyPermissions: FnOnce() -> PropertiesPermissionMap,
{
- PropertyWriter {
- collection,
- is_collection_admin: LazyValue::new(|| collection.is_owner_or_admin(sender)),
- property_permissions: LazyValue::new(|| <Pallet<T>>::property_permissions(collection.id)),
- check_token_exist: |token_id| {
- debug_assert!(collection.token_exists(token_id));
+ /// A function to write properties to a **newly created** token.
+ pub fn write_token_properties(
+ &mut self,
+ mint_target_is_sender: bool,
+ token_id: TokenId,
+ properties_updates: impl Iterator<Item = Property>,
+ log: evm_coder::ethereum::Log,
+ ) -> DispatchResult {
+ let check_token_exist = || {
+ debug_assert!(self.collection.token_exists(token_id));
true
- },
- get_properties: |token_id| {
- debug_assert!(collection.get_token_properties_raw(token_id).is_none());
+ };
+
+ let check_token_owner = || Ok(mint_target_is_sender);
+
+ let get_token_properties = || {
+ debug_assert!(self.collection.get_token_properties_raw(token_id).is_none());
TokenProperties::new()
- },
- _phantom: PhantomData,
+ };
+
+ self.internal_write_token_properties(
+ token_id,
+ PropertyWriterLazyTokenInfo::new(
+ check_token_exist,
+ check_token_owner,
+ get_token_properties,
+ ),
+ properties_updates.map(|p| (p.key, Some(p.value))),
+ log,
+ )
}
}
-#[cfg(feature = "runtime-benchmarks")]
-/// Create a `PropertyWriter` with preloaded `is_collection_admin` and `property_permissions.
-/// Also:
-/// * it will return `true` for the token ownership check.
-/// * it will return empty stored properties without reading them from the storage.
-pub fn collection_info_loaded_property_writer<T, Handle>(
- collection: &Handle,
- is_collection_admin: bool,
- property_permissions: PropertiesPermissionMap,
-) -> PropertyWriter<
- T,
- Handle,
- NewTokenPropertyWriter,
- impl FnOnce() -> bool,
- impl FnOnce() -> PropertiesPermissionMap,
- impl Copy + FnOnce(TokenId) -> bool,
- impl Copy + FnOnce(TokenId) -> TokenProperties,
->
+/// A marker structure that enables the writer implementation
+/// to provide the interface to write properties to **already existing** tokens.
+pub struct ExistingTokenPropertyWriter<T>(PhantomData<T>);
+impl<T: Config> ExistingTokenPropertyWriter<T> {
+ /// Creates a [`PropertyWriter`] for **already existing** tokens.
+ pub fn new<'a, Handle>(
+ collection: &'a Handle,
+ sender: &'a T::CrossAccountId,
+ ) -> PropertyWriter<
+ 'a,
+ Self,
+ T,
+ Handle,
+ impl FnOnce() -> bool + 'a,
+ impl FnOnce() -> PropertiesPermissionMap + 'a,
+ >
+ where
+ Handle: CommonCollectionOperations<T> + Deref<Target = CollectionHandle<T>>,
+ {
+ PropertyWriter {
+ collection,
+ collection_lazy_info: PropertyWriterLazyCollectionInfo {
+ is_collection_admin: LazyValue::new(|| collection.is_owner_or_admin(sender)),
+ property_permissions: LazyValue::new(|| {
+ <Pallet<T>>::property_permissions(collection.id)
+ }),
+ },
+ _phantom: PhantomData,
+ }
+ }
+}
+
+impl<'a, T, Handle, FIsAdmin, FPropertyPermissions>
+ PropertyWriter<'a, ExistingTokenPropertyWriter<T>, T, Handle, FIsAdmin, FPropertyPermissions>
where
T: Config,
Handle: CommonCollectionOperations<T> + Deref<Target = CollectionHandle<T>>,
+ FIsAdmin: FnOnce() -> bool,
+ FPropertyPermissions: FnOnce() -> PropertiesPermissionMap,
{
- PropertyWriter {
- collection,
- is_collection_admin: LazyValue::new(move || is_collection_admin),
- property_permissions: LazyValue::new(move || property_permissions),
- check_token_exist: |_token_id| true,
- get_properties: |_token_id| TokenProperties::new(),
- _phantom: PhantomData,
+ /// A function to write properties to an **already existing** token.
+ pub fn write_token_properties(
+ &mut self,
+ sender: &T::CrossAccountId,
+ token_id: TokenId,
+ properties_updates: impl Iterator<Item = (PropertyKey, Option<PropertyValue>)>,
+ nesting_budget: &dyn Budget,
+ log: evm_coder::ethereum::Log,
+ ) -> DispatchResult {
+ let check_token_exist = || self.collection.token_exists(token_id);
+ let check_token_owner = || {
+ self.collection
+ .check_token_indirect_owner(token_id, sender, nesting_budget)
+ };
+ let get_token_properties = || {
+ self.collection
+ .get_token_properties_raw(token_id)
+ .unwrap_or_default()
+ };
+
+ self.internal_write_token_properties(
+ token_id,
+ PropertyWriterLazyTokenInfo::new(
+ check_token_exist,
+ check_token_owner,
+ get_token_properties,
+ ),
+ properties_updates,
+ log,
+ )
}
}
-/// Create a [`PropertyWriter`] for already existing tokens.
-pub fn property_writer_for_existing_token<'a, T, Handle>(
- collection: &'a Handle,
- sender: &'a T::CrossAccountId,
-) -> PropertyWriter<
- 'a,
- T,
- Handle,
- ExistingTokenPropertyWriter,
- impl FnOnce() -> bool + 'a,
- impl FnOnce() -> PropertiesPermissionMap + 'a,
- impl Copy + FnOnce(TokenId) -> bool + 'a,
- impl Copy + FnOnce(TokenId) -> TokenProperties + 'a,
->
+/// A marker structure that enables the writer implementation
+/// to benchmark the token properties writing.
+#[cfg(feature = "runtime-benchmarks")]
+pub struct BenchmarkPropertyWriter<T>(PhantomData<T>);
+
+#[cfg(feature = "runtime-benchmarks")]
+impl<T: Config> BenchmarkPropertyWriter<T> {
+ /// Creates a [`PropertyWriter`] for benchmarking tokens properties writing.
+ pub fn new<'a, Handle, FIsAdmin, FPropertyPermissions>(
+ collection: &Handle,
+ collection_lazy_info: PropertyWriterLazyCollectionInfo<FIsAdmin, FPropertyPermissions>,
+ ) -> PropertyWriter<Self, T, Handle, FIsAdmin, FPropertyPermissions>
+ where
+ Handle: CommonCollectionOperations<T> + Deref<Target = CollectionHandle<T>>,
+ FIsAdmin: FnOnce() -> bool,
+ FPropertyPermissions: FnOnce() -> PropertiesPermissionMap,
+ {
+ PropertyWriter {
+ collection,
+ collection_lazy_info,
+ _phantom: PhantomData,
+ }
+ }
+
+ /// Load the [`PropertyWriterLazyCollectionInfo`] from the storage.
+ pub fn load_collection_info<Handle>(
+ collection_handle: &Handle,
+ sender: &T::CrossAccountId,
+ ) -> PropertyWriterLazyCollectionInfo<
+ impl FnOnce() -> bool,
+ impl FnOnce() -> PropertiesPermissionMap,
+ >
+ where
+ Handle: Deref<Target = CollectionHandle<T>>,
+ {
+ let is_collection_admin = collection_handle.is_owner_or_admin(sender);
+ let property_permissions = <Pallet<T>>::property_permissions(collection_handle.id);
+
+ PropertyWriterLazyCollectionInfo {
+ is_collection_admin: LazyValue::new(move || is_collection_admin),
+ property_permissions: LazyValue::new(move || property_permissions),
+ }
+ }
+
+ /// Load the [`PropertyWriterLazyTokenInfo`] with token properties from the storage.
+ pub fn load_token_properties<Handle>(
+ collection: &Handle,
+ token_id: TokenId,
+ ) -> PropertyWriterLazyTokenInfo<
+ impl FnOnce() -> bool,
+ impl FnOnce() -> Result<bool, DispatchError>,
+ impl FnOnce() -> TokenProperties,
+ >
+ where
+ Handle: CommonCollectionOperations<T>,
+ {
+ let stored_properties = collection
+ .get_token_properties_raw(token_id)
+ .unwrap_or_default();
+
+ PropertyWriterLazyTokenInfo {
+ is_token_exist: LazyValue::new(|| true),
+ is_token_owner: LazyValue::new(|| Ok(true)),
+ stored_properties: LazyValue::new(move || stored_properties),
+ }
+ }
+}
+
+#[cfg(feature = "runtime-benchmarks")]
+impl<'a, T, Handle, FIsAdmin, FPropertyPermissions>
+ PropertyWriter<'a, BenchmarkPropertyWriter<T>, T, Handle, FIsAdmin, FPropertyPermissions>
where
T: Config,
Handle: CommonCollectionOperations<T> + Deref<Target = CollectionHandle<T>>,
+ FIsAdmin: FnOnce() -> bool,
+ FPropertyPermissions: FnOnce() -> PropertiesPermissionMap,
{
- PropertyWriter {
- collection,
- is_collection_admin: LazyValue::new(|| collection.is_owner_or_admin(sender)),
- property_permissions: LazyValue::new(|| <Pallet<T>>::property_permissions(collection.id)),
- check_token_exist: |token_id| collection.token_exists(token_id),
- get_properties: |token_id| {
- collection
- .get_token_properties_raw(token_id)
- .unwrap_or_default()
- },
- _phantom: PhantomData,
+ /// A function to benchmark the writing of token properties.
+ pub fn write_token_properties(
+ &mut self,
+ token_id: TokenId,
+ properties_updates: impl Iterator<Item = Property>,
+ log: evm_coder::ethereum::Log,
+ ) -> DispatchResult {
+ let check_token_exist = || true;
+ let check_token_owner = || Ok(true);
+ let get_token_properties = || TokenProperties::new();
+
+ self.internal_write_token_properties(
+ token_id,
+ PropertyWriterLazyTokenInfo::new(
+ check_token_exist,
+ check_token_owner,
+ get_token_properties,
+ ),
+ properties_updates.map(|p| (p.key, Some(p.value))),
+ log,
+ )
}
}
-/// Computes the weight delta for newly created tokens with properties.
+/// Computes the weight of writing properties to tokens.
/// * `properties_nums` - The properties num of each created token.
-/// * `init_token_properties` - The function to obtain the weight from a token's properties num.
-pub fn init_token_properties_delta<T: Config, I: Fn(u32) -> Weight>(
+/// * `per_token_weight_weight` - The function to obtain the weight
+/// of writing properties from a token's properties num.
+pub fn write_token_properties_total_weight<T: Config, I: Fn(u32) -> Weight>(
properties_nums: impl Iterator<Item = u32>,
- init_token_properties: I,
+ per_token_weight: I,
) -> Weight {
- let mut delta = properties_nums
+ let mut weight = properties_nums
.filter_map(|properties_num| {
if properties_num > 0 {
- Some(init_token_properties(properties_num))
+ Some(per_token_weight(properties_num))
} else {
None
}
})
.fold(Weight::zero(), |a, b| a.saturating_add(b));
- // If at least once the `init_token_properties` was called,
- // it means at least one newly created token has properties.
- // Becuase of that, some common collection data also was loaded and we need to add this weight.
- // However, these common data was loaded only once which is guaranteed by the `PropertyWriter`.
- if !delta.is_zero() {
- delta = delta.saturating_add(<SelfWeightOf<T>>::init_token_properties_common())
+ if !weight.is_zero() {
+ // If we are here, it means the token properties were written at least once.
+ // Because of that, some common collection data was also loaded; we must add this weight.
+ // However, this common data was loaded only once, which is guaranteed by the `PropertyWriter`.
+
+ weight = weight.saturating_add(<SelfWeightOf<T>>::property_writer_load_collection_info());
}
- delta
+ weight
}
#[cfg(any(feature = "tests", test))]
pallets/common/src/weights.rsdiffbeforeafterboth--- a/pallets/common/src/weights.rs
+++ b/pallets/common/src/weights.rs
@@ -3,9 +3,9 @@
//! Autogenerated weights for pallet_common
//!
//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev
-//! DATE: 2023-09-30, STEPS: `50`, REPEAT: `400`, LOW RANGE: `[]`, HIGH RANGE: `[]`
+//! DATE: 2023-10-05, STEPS: `50`, REPEAT: `80`, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! WORST CASE MAP SIZE: `1000000`
-//! HOSTNAME: `bench-host`, CPU: `Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz`
+//! HOSTNAME: `hearthstone`, CPU: `AMD Ryzen 9 7950X3D 16-Core Processor`
//! EXECUTION: None, WASM-EXECUTION: Compiled, CHAIN: None, DB CACHE: 1024
// Executed Command:
@@ -20,7 +20,7 @@
// *
// --template=.maintain/frame-weight-template.hbs
// --steps=50
-// --repeat=400
+// --repeat=80
// --heap-pages=4096
// --output=./pallets/common/src/weights.rs
@@ -36,7 +36,7 @@
fn set_collection_properties(b: u32, ) -> Weight;
fn delete_collection_properties(b: u32, ) -> Weight;
fn check_accesslist() -> Weight;
- fn init_token_properties_common() -> Weight;
+ fn property_writer_load_collection_info() -> Weight;
}
/// Weights for pallet_common using the Substrate node and recommended hardware.
@@ -49,10 +49,10 @@
// Proof Size summary in bytes:
// Measured: `298`
// Estimated: `44457`
- // Minimum execution time: 4_987_000 picoseconds.
- Weight::from_parts(5_119_000, 44457)
- // Standard Error: 7_609
- .saturating_add(Weight::from_parts(5_750_459, 0).saturating_mul(b.into()))
+ // Minimum execution time: 2_840_000 picoseconds.
+ Weight::from_parts(1_988_405, 44457)
+ // Standard Error: 7_834
+ .saturating_add(Weight::from_parts(3_053_965, 0).saturating_mul(b.into()))
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -63,10 +63,10 @@
// Proof Size summary in bytes:
// Measured: `303 + b * (33030 ±0)`
// Estimated: `44457`
- // Minimum execution time: 4_923_000 picoseconds.
- Weight::from_parts(5_074_000, 44457)
- // Standard Error: 36_651
- .saturating_add(Weight::from_parts(23_145_677, 0).saturating_mul(b.into()))
+ // Minimum execution time: 2_770_000 picoseconds.
+ Weight::from_parts(2_940_000, 44457)
+ // Standard Error: 30_686
+ .saturating_add(Weight::from_parts(9_801_835, 0).saturating_mul(b.into()))
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -76,20 +76,20 @@
// Proof Size summary in bytes:
// Measured: `373`
// Estimated: `3535`
- // Minimum execution time: 4_271_000 picoseconds.
- Weight::from_parts(4_461_000, 3535)
+ // Minimum execution time: 2_830_000 picoseconds.
+ Weight::from_parts(2_950_000, 3535)
.saturating_add(T::DbWeight::get().reads(1_u64))
}
/// Storage: Common IsAdmin (r:1 w:0)
/// Proof: Common IsAdmin (max_values: None, max_size: Some(70), added: 2545, mode: MaxEncodedLen)
/// Storage: Common CollectionPropertyPermissions (r:1 w:0)
/// Proof: Common CollectionPropertyPermissions (max_values: None, max_size: Some(16726), added: 19201, mode: MaxEncodedLen)
- fn init_token_properties_common() -> Weight {
+ fn property_writer_load_collection_info() -> Weight {
// Proof Size summary in bytes:
// Measured: `326`
// Estimated: `20191`
- // Minimum execution time: 5_889_000 picoseconds.
- Weight::from_parts(6_138_000, 20191)
+ // Minimum execution time: 3_970_000 picoseconds.
+ Weight::from_parts(4_140_000, 20191)
.saturating_add(T::DbWeight::get().reads(2_u64))
}
}
@@ -103,10 +103,10 @@
// Proof Size summary in bytes:
// Measured: `298`
// Estimated: `44457`
- // Minimum execution time: 4_987_000 picoseconds.
- Weight::from_parts(5_119_000, 44457)
- // Standard Error: 7_609
- .saturating_add(Weight::from_parts(5_750_459, 0).saturating_mul(b.into()))
+ // Minimum execution time: 2_840_000 picoseconds.
+ Weight::from_parts(1_988_405, 44457)
+ // Standard Error: 7_834
+ .saturating_add(Weight::from_parts(3_053_965, 0).saturating_mul(b.into()))
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -117,10 +117,10 @@
// Proof Size summary in bytes:
// Measured: `303 + b * (33030 ±0)`
// Estimated: `44457`
- // Minimum execution time: 4_923_000 picoseconds.
- Weight::from_parts(5_074_000, 44457)
- // Standard Error: 36_651
- .saturating_add(Weight::from_parts(23_145_677, 0).saturating_mul(b.into()))
+ // Minimum execution time: 2_770_000 picoseconds.
+ Weight::from_parts(2_940_000, 44457)
+ // Standard Error: 30_686
+ .saturating_add(Weight::from_parts(9_801_835, 0).saturating_mul(b.into()))
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -130,20 +130,20 @@
// Proof Size summary in bytes:
// Measured: `373`
// Estimated: `3535`
- // Minimum execution time: 4_271_000 picoseconds.
- Weight::from_parts(4_461_000, 3535)
+ // Minimum execution time: 2_830_000 picoseconds.
+ Weight::from_parts(2_950_000, 3535)
.saturating_add(RocksDbWeight::get().reads(1_u64))
}
/// Storage: Common IsAdmin (r:1 w:0)
/// Proof: Common IsAdmin (max_values: None, max_size: Some(70), added: 2545, mode: MaxEncodedLen)
/// Storage: Common CollectionPropertyPermissions (r:1 w:0)
/// Proof: Common CollectionPropertyPermissions (max_values: None, max_size: Some(16726), added: 19201, mode: MaxEncodedLen)
- fn init_token_properties_common() -> Weight {
+ fn property_writer_load_collection_info() -> Weight {
// Proof Size summary in bytes:
// Measured: `326`
// Estimated: `20191`
- // Minimum execution time: 5_889_000 picoseconds.
- Weight::from_parts(6_138_000, 20191)
+ // Minimum execution time: 3_970_000 picoseconds.
+ Weight::from_parts(4_140_000, 20191)
.saturating_add(RocksDbWeight::get().reads(2_u64))
}
}
pallets/evm-coder-substrate/src/lib.rsdiffbeforeafterboth--- a/pallets/evm-coder-substrate/src/lib.rs
+++ b/pallets/evm-coder-substrate/src/lib.rs
@@ -84,7 +84,7 @@
}
impl<T: Config> budget::Budget for GasCallsBudget<'_, T> {
fn consume_custom(&self, calls: u32) -> bool {
- let (gas, overflown) = (calls as u64).overflowing_add(self.gas_per_call);
+ let (gas, overflown) = (calls as u64).overflowing_mul(self.gas_per_call);
if overflown {
return false;
}
pallets/foreign-assets/src/impl_fungibles.rsdiffbeforeafterboth--- a/pallets/foreign-assets/src/impl_fungibles.rs
+++ b/pallets/foreign-assets/src/impl_fungibles.rs
@@ -23,7 +23,7 @@
use pallet_common::{CollectionHandle, CommonCollectionOperations};
use pallet_fungible::FungibleHandle;
use sp_runtime::traits::{CheckedAdd, CheckedSub};
-use up_data_structs::budget::Value;
+use up_data_structs::budget;
use super::*;
@@ -327,7 +327,7 @@
&collection,
&account,
amount_data,
- &Value::new(0),
+ &budget::Value::new(0),
)?;
Ok(amount)
@@ -440,7 +440,7 @@
&T::CrossAccountId::from_sub(source.clone()),
&T::CrossAccountId::from_sub(dest.clone()),
amount.into(),
- &Value::new(0),
+ &budget::Value::new(0),
)
.map_err(|e| e.error)?;
pallets/fungible/src/common.rsdiffbeforeafterboth--- a/pallets/fungible/src/common.rs
+++ b/pallets/fungible/src/common.rs
@@ -16,14 +16,11 @@
use core::marker::PhantomData;
-use frame_support::{
- dispatch::DispatchResultWithPostInfo, ensure, fail, traits::Get, weights::Weight,
-};
+use frame_support::{dispatch::DispatchResultWithPostInfo, ensure, fail, weights::Weight};
use pallet_common::{
weights::WeightInfo as _, with_weight, CommonCollectionOperations, CommonWeightInfo,
RefungibleExtensions, SelfWeightOf as PalletCommonWeightOf,
};
-use pallet_structure::Error as StructureError;
use sp_runtime::{ArithmeticError, DispatchError};
use sp_std::{vec, vec::Vec};
use up_data_structs::{
@@ -58,18 +55,9 @@
fn set_collection_properties(amount: u32) -> Weight {
<pallet_common::SelfWeightOf<T>>::set_collection_properties(amount)
- }
-
- fn delete_collection_properties(amount: u32) -> Weight {
- <pallet_common::SelfWeightOf<T>>::delete_collection_properties(amount)
}
fn set_token_properties(_amount: u32) -> Weight {
- // Error
- Weight::zero()
- }
-
- fn delete_token_properties(_amount: u32) -> Weight {
// Error
Weight::zero()
}
@@ -80,7 +68,8 @@
}
fn transfer() -> Weight {
- <SelfWeightOf<T>>::transfer_raw() + <PalletCommonWeightOf<T>>::check_accesslist() * 2
+ <SelfWeightOf<T>>::transfer_raw()
+ .saturating_add(<PalletCommonWeightOf<T>>::check_accesslist().saturating_mul(2))
}
fn approve() -> Weight {
@@ -93,28 +82,14 @@
fn transfer_from() -> Weight {
Self::transfer()
- + <SelfWeightOf<T>>::check_allowed_raw()
- + <SelfWeightOf<T>>::set_allowance_unchecked_raw()
+ .saturating_add(<SelfWeightOf<T>>::check_allowed_raw())
+ .saturating_add(<SelfWeightOf<T>>::set_allowance_unchecked_raw())
}
fn burn_from() -> Weight {
<SelfWeightOf<T>>::burn_from()
}
- fn burn_recursively_self_raw() -> Weight {
- // Read to get total balance
- Self::burn_item() + T::DbWeight::get().reads(1)
- }
-
- fn burn_recursively_breadth_raw(_amount: u32) -> Weight {
- // Fungible tokens can't have children
- Weight::zero()
- }
-
- fn token_owner() -> Weight {
- Weight::zero()
- }
-
fn set_allowance_for_all() -> Weight {
Weight::zero()
}
@@ -200,26 +175,6 @@
with_weight(
<Pallet<T>>::burn(self, &sender, amount),
<CommonWeights<T>>::burn_item(),
- )
- }
-
- fn burn_item_recursively(
- &self,
- sender: T::CrossAccountId,
- token: TokenId,
- self_budget: &dyn Budget,
- _breadth_budget: &dyn Budget,
- ) -> DispatchResultWithPostInfo {
- // Should not happen?
- ensure!(
- token == TokenId::default(),
- <Error<T>>::FungibleItemsHaveNoId
- );
- ensure!(self_budget.consume(), <StructureError<T>>::DepthLimit,);
-
- with_weight(
- <Pallet<T>>::burn(self, &sender, <Balance<T>>::get((self.id, &sender))),
- <CommonWeights<T>>::burn_recursively_self_raw(),
)
}
pallets/fungible/src/erc.rsdiffbeforeafterboth--- a/pallets/fungible/src/erc.rs
+++ b/pallets/fungible/src/erc.rs
@@ -32,12 +32,12 @@
use pallet_evm_coder_substrate::{
call, dispatch_to_evm,
execution::{PreDispatch, Result},
- frontier_contract,
+ frontier_contract, SubstrateRecorder,
};
use pallet_structure::{weights::WeightInfo as _, SelfWeightOf as StructureWeight};
use sp_core::{Get, U256};
use sp_std::vec::Vec;
-use up_data_structs::CollectionMode;
+use up_data_structs::{budget::Budget, CollectionMode};
use crate::{
common::CommonWeights, weights::WeightInfo, Allowance, Balance, Config, FungibleHandle, Pallet,
@@ -73,6 +73,10 @@
amount: U256,
}
+fn nesting_budget<T: Config>(recorder: &SubstrateRecorder<T>) -> impl Budget + '_ {
+ recorder.weight_calls_budget(<StructureWeight<T>>::find_parent())
+}
+
#[solidity_interface(name = ERC20, events(ERC20Events), enum(derive(PreDispatch)), enum_attr(weight), expect_selector = 0x942e8b22)]
impl<T: Config> FungibleHandle<T> {
fn name(&self) -> Result<String> {
@@ -106,11 +110,8 @@
let caller = T::CrossAccountId::from_eth(caller);
let to = T::CrossAccountId::from_eth(to);
let amount = amount.try_into().map_err(|_| "amount overflow")?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::transfer(self, &caller, &to, amount, &budget)
+ <Pallet<T>>::transfer(self, &caller, &to, amount, &nesting_budget(&self.recorder))
.map_err(|e| dispatch_to_evm::<T>(e.error))?;
Ok(true)
}
@@ -127,12 +128,16 @@
let from = T::CrossAccountId::from_eth(from);
let to = T::CrossAccountId::from_eth(to);
let amount = amount.try_into().map_err(|_| "amount overflow")?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::transfer_from(self, &caller, &from, &to, amount, &budget)
- .map_err(|e| dispatch_to_evm::<T>(e.error))?;
+ <Pallet<T>>::transfer_from(
+ self,
+ &caller,
+ &from,
+ &to,
+ amount,
+ &nesting_budget(&self.recorder),
+ )
+ .map_err(|e| dispatch_to_evm::<T>(e.error))?;
Ok(true)
}
#[weight(<SelfWeightOf<T>>::approve())]
@@ -164,10 +169,8 @@
let caller = T::CrossAccountId::from_eth(caller);
let to = T::CrossAccountId::from_eth(to);
let amount = amount.try_into().map_err(|_| "amount overflow")?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::create_item(self, &caller, (to, amount), &budget)
+
+ <Pallet<T>>::create_item(self, &caller, (to, amount), &nesting_budget(&self.recorder))
.map_err(dispatch_to_evm::<T>)?;
Ok(true)
}
@@ -201,10 +204,8 @@
let caller = T::CrossAccountId::from_eth(caller);
let to = to.into_sub_cross_account::<T>()?;
let amount = amount.try_into().map_err(|_| "amount overflow")?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::create_item(self, &caller, (to, amount), &budget)
+
+ <Pallet<T>>::create_item(self, &caller, (to, amount), &nesting_budget(&self.recorder))
.map_err(dispatch_to_evm::<T>)?;
Ok(true)
}
@@ -236,12 +237,15 @@
let caller = T::CrossAccountId::from_eth(caller);
let from = T::CrossAccountId::from_eth(from);
let amount = amount.try_into().map_err(|_| "amount overflow")?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::burn_from(self, &caller, &from, amount, &budget)
- .map_err(dispatch_to_evm::<T>)?;
+ <Pallet<T>>::burn_from(
+ self,
+ &caller,
+ &from,
+ amount,
+ &nesting_budget(&self.recorder),
+ )
+ .map_err(dispatch_to_evm::<T>)?;
Ok(true)
}
@@ -260,12 +264,15 @@
let caller = T::CrossAccountId::from_eth(caller);
let from = from.into_sub_cross_account::<T>()?;
let amount = amount.try_into().map_err(|_| "amount overflow")?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::burn_from(self, &caller, &from, amount, &budget)
- .map_err(dispatch_to_evm::<T>)?;
+ <Pallet<T>>::burn_from(
+ self,
+ &caller,
+ &from,
+ amount,
+ &nesting_budget(&self.recorder),
+ )
+ .map_err(dispatch_to_evm::<T>)?;
Ok(true)
}
@@ -274,9 +281,6 @@
#[weight(<SelfWeightOf<T>>::create_multiple_items_ex(amounts.len() as u32))]
fn mint_bulk(&mut self, caller: Caller, amounts: Vec<AmountForAddress>) -> Result<bool> {
let caller = T::CrossAccountId::from_eth(caller);
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
let amounts = amounts
.into_iter()
.map(|AmountForAddress { to, amount }| {
@@ -287,7 +291,7 @@
})
.collect::<Result<_>>()?;
- <Pallet<T>>::create_multiple_items(self, &caller, amounts, &budget)
+ <Pallet<T>>::create_multiple_items(self, &caller, amounts, &nesting_budget(&self.recorder))
.map_err(dispatch_to_evm::<T>)?;
Ok(true)
}
@@ -297,11 +301,9 @@
let caller = T::CrossAccountId::from_eth(caller);
let to = to.into_sub_cross_account::<T>()?;
let amount = amount.try_into().map_err(|_| "amount overflow")?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::transfer(self, &caller, &to, amount, &budget).map_err(|_| "transfer error")?;
+ <Pallet<T>>::transfer(self, &caller, &to, amount, &nesting_budget(&self.recorder))
+ .map_err(|_| "transfer error")?;
Ok(true)
}
@@ -317,12 +319,16 @@
let from = from.into_sub_cross_account::<T>()?;
let to = to.into_sub_cross_account::<T>()?;
let amount = amount.try_into().map_err(|_| "amount overflow")?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::transfer_from(self, &caller, &from, &to, amount, &budget)
- .map_err(|e| dispatch_to_evm::<T>(e.error))?;
+ <Pallet<T>>::transfer_from(
+ self,
+ &caller,
+ &from,
+ &to,
+ amount,
+ &nesting_budget(&self.recorder),
+ )
+ .map_err(|e| dispatch_to_evm::<T>(e.error))?;
Ok(true)
}
pallets/nonfungible/src/benchmarking.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/benchmarking.rs
+++ b/pallets/nonfungible/src/benchmarking.rs
@@ -262,9 +262,82 @@
{
<Pallet<T>>::burn_from(&collection, &burner, &sender, item, &Unlimited)?;
}
+ }
- Ok(())
- }
+ // set_token_properties {
+ // let b in 0..MAX_PROPERTIES_PER_ITEM;
+ // bench_init!{
+ // owner: sub; collection: collection(owner);
+ // owner: cross_from_sub;
+ // };
+ // let perms = (0..b).map(|k| PropertyKeyPermission {
+ // key: property_key(k as usize),
+ // permission: PropertyPermission {
+ // mutable: false,
+ // collection_admin: true,
+ // token_owner: true,
+ // },
+ // }).collect::<Vec<_>>();
+ // <Pallet<T>>::set_token_property_permissions(&collection, &owner, perms)?;
+ // let props = (0..b).map(|k| Property {
+ // key: property_key(k as usize),
+ // value: property_value(),
+ // }).collect::<Vec<_>>();
+ // let item = create_max_item(&collection, &owner, owner.clone())?;
+ // }: {<Pallet<T>>::set_token_properties(&collection, &owner, item, props.into_iter(), &Unlimited)?}
+
+ // load_token_properties {
+ // bench_init!{
+ // owner: sub; collection: collection(owner);
+ // owner: cross_from_sub;
+ // };
+
+ // let item = create_max_item(&collection, &owner, owner.clone())?;
+ // }: {
+ // pallet_common::BenchmarkPropertyWriter::<T>::load_token_properties(
+ // &collection,
+ // item,
+ // )
+ // }
+
+ // write_token_properties {
+ // let b in 0..MAX_PROPERTIES_PER_ITEM;
+ // bench_init!{
+ // owner: sub; collection: collection(owner);
+ // owner: cross_from_sub;
+ // };
+
+ // let perms = (0..b).map(|k| PropertyKeyPermission {
+ // key: property_key(k as usize),
+ // permission: PropertyPermission {
+ // mutable: false,
+ // collection_admin: true,
+ // token_owner: true,
+ // },
+ // }).collect::<Vec<_>>();
+ // <Pallet<T>>::set_token_property_permissions(&collection, &owner, perms)?;
+ // let props = (0..b).map(|k| Property {
+ // key: property_key(k as usize),
+ // value: property_value(),
+ // }).collect::<Vec<_>>();
+ // let item = create_max_item(&collection, &owner, owner.clone())?;
+
+ // let lazy_collection_info = pallet_common::BenchmarkPropertyWriter::<T>::load_collection_info(
+ // &collection,
+ // &owner,
+ // );
+ // }: {
+ // let mut property_writer = pallet_common::BenchmarkPropertyWriter::new(&collection, lazy_collection_info);
+
+ // property_writer.write_token_properties(
+ // item,
+ // props.into_iter(),
+ // crate::erc::ERC721TokenEvent::TokenChanged {
+ // token_id: item.into(),
+ // }
+ // .to_log(T::ContractAddress::get()),
+ // )?
+ // }
#[benchmark]
fn set_token_property_permissions(
pallets/nonfungible/src/common.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/common.rs
+++ b/pallets/nonfungible/src/common.rs
@@ -18,8 +18,9 @@
use frame_support::{dispatch::DispatchResultWithPostInfo, ensure, fail, weights::Weight};
use pallet_common::{
- init_token_properties_delta, weights::WeightInfo as _, with_weight, CommonCollectionOperations,
- CommonWeightInfo, RefungibleExtensions, SelfWeightOf as PalletCommonWeightOf,
+ weights::WeightInfo as _, with_weight, write_token_properties_total_weight,
+ CommonCollectionOperations, CommonWeightInfo, RefungibleExtensions,
+ SelfWeightOf as PalletCommonWeightOf,
};
use pallet_structure::Pallet as PalletStructure;
use sp_runtime::DispatchError;
@@ -39,9 +40,9 @@
fn create_multiple_items_ex(data: &CreateItemExData<T::CrossAccountId>) -> Weight {
match data {
CreateItemExData::NFT(t) => <SelfWeightOf<T>>::create_multiple_items_ex(t.len() as u32)
- .saturating_add(init_token_properties_delta::<T, _>(
+ .saturating_add(write_token_properties_total_weight::<T, _>(
t.iter().map(|t| t.properties.len() as u32),
- <SelfWeightOf<T>>::init_token_properties,
+ <SelfWeightOf<T>>::write_token_properties,
)),
_ => Weight::zero(),
}
@@ -49,12 +50,12 @@
fn create_multiple_items(data: &[up_data_structs::CreateItemData]) -> Weight {
<SelfWeightOf<T>>::create_multiple_items(data.len() as u32).saturating_add(
- init_token_properties_delta::<T, _>(
+ write_token_properties_total_weight::<T, _>(
data.iter().map(|t| match t {
up_data_structs::CreateItemData::NFT(n) => n.properties.len() as u32,
_ => 0,
}),
- <SelfWeightOf<T>>::init_token_properties,
+ <SelfWeightOf<T>>::write_token_properties,
),
)
}
@@ -67,16 +68,15 @@
<pallet_common::SelfWeightOf<T>>::set_collection_properties(amount)
}
- fn delete_collection_properties(amount: u32) -> Weight {
- <pallet_common::SelfWeightOf<T>>::delete_collection_properties(amount)
- }
-
fn set_token_properties(amount: u32) -> Weight {
- <SelfWeightOf<T>>::set_token_properties(amount)
+ write_token_properties_total_weight::<T, _>([amount].into_iter(), |amount| {
+ <SelfWeightOf<T>>::load_token_properties()
+ .saturating_add(<SelfWeightOf<T>>::write_token_properties(amount))
+ })
}
fn delete_token_properties(amount: u32) -> Weight {
- <SelfWeightOf<T>>::delete_token_properties(amount)
+ Self::set_token_properties(amount)
}
fn set_token_property_permissions(amount: u32) -> Weight {
@@ -84,7 +84,8 @@
}
fn transfer() -> Weight {
- <SelfWeightOf<T>>::transfer_raw() + <PalletCommonWeightOf<T>>::check_accesslist() * 2
+ <SelfWeightOf<T>>::transfer_raw()
+ .saturating_add(<PalletCommonWeightOf<T>>::check_accesslist().saturating_mul(2))
}
fn approve() -> Weight {
@@ -96,24 +97,11 @@
}
fn transfer_from() -> Weight {
- Self::transfer() + <SelfWeightOf<T>>::check_allowed_raw()
+ Self::transfer().saturating_add(<SelfWeightOf<T>>::check_allowed_raw())
}
fn burn_from() -> Weight {
<SelfWeightOf<T>>::burn_from()
- }
-
- fn burn_recursively_self_raw() -> Weight {
- <SelfWeightOf<T>>::burn_recursively_self_raw()
- }
-
- fn burn_recursively_breadth_raw(amount: u32) -> Weight {
- <SelfWeightOf<T>>::burn_recursively_breadth_plus_self_plus_self_per_each_raw(amount)
- .saturating_sub(Self::burn_recursively_self_raw().saturating_mul(amount as u64 + 1))
- }
-
- fn token_owner() -> Weight {
- <SelfWeightOf<T>>::token_owner()
}
fn set_allowance_for_all() -> Weight {
@@ -306,16 +294,6 @@
<Pallet<T>>::check_token_immediate_ownership(self, token, &sender)?;
Ok(().into())
}
- }
-
- fn burn_item_recursively(
- &self,
- sender: T::CrossAccountId,
- token: TokenId,
- self_budget: &dyn Budget,
- breadth_budget: &dyn Budget,
- ) -> DispatchResultWithPostInfo {
- <Pallet<T>>::burn_recursively(self, &sender, token, self_budget, breadth_budget)
}
fn transfer(
pallets/nonfungible/src/erc.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/erc.rs
+++ b/pallets/nonfungible/src/erc.rs
@@ -38,14 +38,14 @@
use pallet_evm_coder_substrate::{
call, dispatch_to_evm,
execution::{Error, PreDispatch, Result},
- frontier_contract,
+ frontier_contract, SubstrateRecorder,
};
use pallet_structure::{weights::WeightInfo as _, SelfWeightOf as StructureWeight};
use sp_core::{Get, U256};
use sp_std::{vec, vec::Vec};
use up_data_structs::{
- CollectionId, CollectionPropertiesVec, Property, PropertyKey, PropertyKeyPermission,
- PropertyPermission, TokenId,
+ budget::Budget, CollectionId, CollectionPropertiesVec, Property, PropertyKey,
+ PropertyKeyPermission, PropertyPermission, TokenId,
};
use crate::{
@@ -78,6 +78,10 @@
impl<T: Config> Contract for NonfungibleHandle<T> {...}
}
+fn nesting_budget<T: Config>(recorder: &SubstrateRecorder<T>) -> impl Budget + '_ {
+ recorder.weight_calls_budget(<StructureWeight<T>>::find_parent())
+}
+
/// @title A contract that allows to set and delete token properties and change token property permissions.
#[solidity_interface(name = TokenProperties, events(ERC721TokenEvent), enum(derive(PreDispatch)), enum_attr(weight))]
impl<T: Config> NonfungibleHandle<T> {
@@ -146,7 +150,7 @@
/// @param key Property key.
/// @param value Property value.
#[solidity(hide)]
- #[weight(<SelfWeightOf<T>>::set_token_properties(1))]
+ #[weight(<CommonWeights<T>>::set_token_properties(1))]
fn set_property(
&mut self,
caller: Caller,
@@ -161,16 +165,12 @@
.map_err(|_| "key too long")?;
let value = value.0.try_into().map_err(|_| "value too long")?;
- let nesting_budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
-
<Pallet<T>>::set_token_property(
self,
&caller,
TokenId(token_id),
Property { key, value },
- &nesting_budget,
+ &nesting_budget(&self.recorder),
)
.map_err(dispatch_to_evm::<T>)
}
@@ -179,7 +179,7 @@
/// @dev Throws error if `msg.sender` has no permission to edit the property.
/// @param tokenId ID of the token.
/// @param properties settable properties
- #[weight(<SelfWeightOf<T>>::set_token_properties(properties.len() as u32))]
+ #[weight(<CommonWeights<T>>::set_token_properties(properties.len() as u32))]
fn set_properties(
&mut self,
caller: Caller,
@@ -189,10 +189,6 @@
let caller = T::CrossAccountId::from_eth(caller);
let token_id: u32 = token_id.try_into().map_err(|_| "token id overflow")?;
- let nesting_budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
-
let properties = properties
.into_iter()
.map(eth::Property::try_into)
@@ -203,7 +199,7 @@
&caller,
TokenId(token_id),
properties.into_iter(),
- &nesting_budget,
+ &nesting_budget(&self.recorder),
)
.map_err(dispatch_to_evm::<T>)
}
@@ -213,7 +209,7 @@
/// @param tokenId ID of the token.
/// @param key Property key.
#[solidity(hide)]
- #[weight(<SelfWeightOf<T>>::delete_token_properties(1))]
+ #[weight(<CommonWeights<T>>::delete_token_properties(1))]
fn delete_property(&mut self, token_id: U256, caller: Caller, key: String) -> Result<()> {
let caller = T::CrossAccountId::from_eth(caller);
let token_id: u32 = token_id.try_into().map_err(|_| "token id overflow")?;
@@ -221,19 +217,21 @@
.try_into()
.map_err(|_| "key too long")?;
- let nesting_budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
-
- <Pallet<T>>::delete_token_property(self, &caller, TokenId(token_id), key, &nesting_budget)
- .map_err(dispatch_to_evm::<T>)
+ <Pallet<T>>::delete_token_property(
+ self,
+ &caller,
+ TokenId(token_id),
+ key,
+ &nesting_budget(&self.recorder),
+ )
+ .map_err(dispatch_to_evm::<T>)
}
/// @notice Delete token properties value.
/// @dev Throws error if `msg.sender` has no permission to edit the property.
/// @param tokenId ID of the token.
/// @param keys Properties key.
- #[weight(<SelfWeightOf<T>>::delete_token_properties(keys.len() as u32))]
+ #[weight(<CommonWeights<T>>::delete_token_properties(keys.len() as u32))]
fn delete_properties(
&mut self,
token_id: U256,
@@ -247,16 +245,12 @@
.map(|k| Ok(<Vec<u8>>::from(k).try_into().map_err(|_| "key too long")?))
.collect::<Result<Vec<_>>>()?;
- let nesting_budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
-
<Pallet<T>>::delete_token_properties(
self,
&caller,
TokenId(token_id),
keys.into_iter(),
- &nesting_budget,
+ &nesting_budget(&self.recorder),
)
.map_err(dispatch_to_evm::<T>)
}
@@ -481,12 +475,16 @@
let from = T::CrossAccountId::from_eth(from);
let to = T::CrossAccountId::from_eth(to);
let token = token_id.try_into()?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::transfer_from(self, &caller, &from, &to, token, &budget)
- .map_err(|e| dispatch_to_evm::<T>(e.error))?;
+ <Pallet<T>>::transfer_from(
+ self,
+ &caller,
+ &from,
+ &to,
+ token,
+ &nesting_budget(&self.recorder),
+ )
+ .map_err(|e| dispatch_to_evm::<T>(e.error))?;
Ok(())
}
@@ -594,9 +592,6 @@
let caller = T::CrossAccountId::from_eth(caller);
let to = T::CrossAccountId::from_eth(to);
let token_id: u32 = token_id.try_into()?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
if <TokensMinted<T>>::get(self.id)
.checked_add(1)
@@ -613,7 +608,7 @@
properties: BoundedVec::default(),
owner: to,
},
- &budget,
+ &nesting_budget(&self.recorder),
)
.map_err(dispatch_to_evm::<T>)?;
@@ -664,9 +659,6 @@
let caller = T::CrossAccountId::from_eth(caller);
let to = T::CrossAccountId::from_eth(to);
let token_id: u32 = token_id.try_into().map_err(|_| "amount overflow")?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
if <TokensMinted<T>>::get(self.id)
.checked_add(1)
@@ -694,7 +686,7 @@
properties,
owner: to,
},
- &budget,
+ &nesting_budget(&self.recorder),
)
.map_err(dispatch_to_evm::<T>)?;
Ok(true)
@@ -840,11 +832,8 @@
let caller = T::CrossAccountId::from_eth(caller);
let to = T::CrossAccountId::from_eth(to);
let token = token_id.try_into()?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::transfer(self, &caller, &to, token, &budget)
+ <Pallet<T>>::transfer(self, &caller, &to, token, &nesting_budget(&self.recorder))
.map_err(|e| dispatch_to_evm::<T>(e.error))?;
Ok(())
}
@@ -864,11 +853,8 @@
let caller = T::CrossAccountId::from_eth(caller);
let to = to.into_sub_cross_account::<T>()?;
let token = token_id.try_into()?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::transfer(self, &caller, &to, token, &budget)
+ <Pallet<T>>::transfer(self, &caller, &to, token, &nesting_budget(&self.recorder))
.map_err(|e| dispatch_to_evm::<T>(e.error))?;
Ok(())
}
@@ -891,11 +877,16 @@
let from = from.into_sub_cross_account::<T>()?;
let to = to.into_sub_cross_account::<T>()?;
let token_id = token_id.try_into()?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- Pallet::<T>::transfer_from(self, &caller, &from, &to, token_id, &budget)
- .map_err(|e| dispatch_to_evm::<T>(e.error))?;
+
+ Pallet::<T>::transfer_from(
+ self,
+ &caller,
+ &from,
+ &to,
+ token_id,
+ &nesting_budget(&self.recorder),
+ )
+ .map_err(|e| dispatch_to_evm::<T>(e.error))?;
Ok(())
}
@@ -911,11 +902,8 @@
let caller = T::CrossAccountId::from_eth(caller);
let from = T::CrossAccountId::from_eth(from);
let token = token_id.try_into()?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::burn_from(self, &caller, &from, token, &budget)
+ <Pallet<T>>::burn_from(self, &caller, &from, token, &nesting_budget(&self.recorder))
.map_err(dispatch_to_evm::<T>)?;
Ok(())
}
@@ -936,11 +924,8 @@
let caller = T::CrossAccountId::from_eth(caller);
let from = from.into_sub_cross_account::<T>()?;
let token = token_id.try_into()?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::burn_from(self, &caller, &from, token, &budget)
+ <Pallet<T>>::burn_from(self, &caller, &from, token, &nesting_budget(&self.recorder))
.map_err(dispatch_to_evm::<T>)?;
Ok(())
}
@@ -966,9 +951,6 @@
let mut expected_index = <TokensMinted<T>>::get(self.id)
.checked_add(1)
.ok_or("item id overflow")?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
let total_tokens = token_ids.len();
for id in token_ids.into_iter() {
@@ -985,7 +967,7 @@
})
.collect();
- <Pallet<T>>::create_multiple_items(self, &caller, data, &budget)
+ <Pallet<T>>::create_multiple_items(self, &caller, data, &nesting_budget(&self.recorder))
.map_err(dispatch_to_evm::<T>)?;
Ok(true)
}
@@ -995,9 +977,6 @@
#[weight(<SelfWeightOf<T>>::create_multiple_items(data.len() as u32) + <SelfWeightOf<T>>::set_token_properties(data.len() as u32))]
fn mint_bulk_cross(&mut self, caller: Caller, data: Vec<MintTokenData>) -> Result<bool> {
let caller = T::CrossAccountId::from_eth(caller);
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
let mut create_nft_data = Vec::with_capacity(data.len());
for MintTokenData { owner, properties } in data {
@@ -1013,8 +992,13 @@
});
}
- <Pallet<T>>::create_multiple_items(self, &caller, create_nft_data, &budget)
- .map_err(dispatch_to_evm::<T>)?;
+ <Pallet<T>>::create_multiple_items(
+ self,
+ &caller,
+ create_nft_data,
+ &nesting_budget(&self.recorder),
+ )
+ .map_err(dispatch_to_evm::<T>)?;
Ok(true)
}
@@ -1037,9 +1021,6 @@
let mut expected_index = <TokensMinted<T>>::get(self.id)
.checked_add(1)
.ok_or("item id overflow")?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
let mut data = Vec::with_capacity(tokens.len());
for TokenUri { id, uri } in tokens {
@@ -1066,7 +1047,7 @@
});
}
- <Pallet<T>>::create_multiple_items(self, &caller, data, &budget)
+ <Pallet<T>>::create_multiple_items(self, &caller, data, &nesting_budget(&self.recorder))
.map_err(dispatch_to_evm::<T>)?;
Ok(true)
}
@@ -1096,10 +1077,6 @@
.map_err(|_| Error::Revert("too many properties".to_string()))?;
let caller = T::CrossAccountId::from_eth(caller);
-
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
<Pallet<T>>::create_item(
self,
@@ -1108,7 +1085,7 @@
properties,
owner: to,
},
- &budget,
+ &nesting_budget(&self.recorder),
)
.map_err(dispatch_to_evm::<T>)?;
pallets/nonfungible/src/lib.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/lib.rs
+++ b/pallets/nonfungible/src/lib.rs
@@ -109,7 +109,7 @@
};
use pallet_evm::{account::CrossAccountId, Pallet as PalletEvm};
use pallet_evm_coder_substrate::{SubstrateRecorder, WithRecorder};
-use pallet_structure::{Error as StructureError, Pallet as PalletStructure};
+use pallet_structure::Pallet as PalletStructure;
use parity_scale_codec::{Decode, Encode, MaxEncodedLen};
use scale_info::TypeInfo;
use sp_core::{Get, H160};
@@ -502,52 +502,7 @@
));
Ok(())
}
-
- /// Same as [`burn`] but burns all the tokens that are nested in the token first
- ///
- /// - `self_budget`: Limit for searching children in depth.
- /// - `breadth_budget`: Limit of breadth of searching children.
- ///
- /// [`burn`]: struct.Pallet.html#method.burn
- #[transactional]
- pub fn burn_recursively(
- collection: &NonfungibleHandle<T>,
- sender: &T::CrossAccountId,
- token: TokenId,
- self_budget: &dyn Budget,
- breadth_budget: &dyn Budget,
- ) -> DispatchResultWithPostInfo {
- ensure!(self_budget.consume(), <StructureError<T>>::DepthLimit,);
- let current_token_account =
- T::CrossTokenAddressMapping::token_to_address(collection.id, token);
-
- let mut weight = Weight::zero();
-
- // This method is transactional, if user in fact doesn't have permissions to remove token -
- // tokens removed here will be restored after rejected transaction
- for ((collection, token), _) in <TokenChildren<T>>::iter_prefix((collection.id, token)) {
- ensure!(breadth_budget.consume(), <StructureError<T>>::BreadthLimit,);
- let PostDispatchInfo { actual_weight, .. } =
- <PalletStructure<T>>::burn_item_recursively(
- current_token_account.clone(),
- collection,
- token,
- self_budget,
- breadth_budget,
- )?;
- if let Some(actual_weight) = actual_weight {
- weight = weight.saturating_add(actual_weight);
- }
- }
-
- Self::burn(collection, sender, token)?;
- DispatchResultWithPostInfo::Ok(PostDispatchInfo {
- actual_weight: Some(weight + <SelfWeightOf<T>>::burn_item()),
- pays_fee: Pays::Yes,
- })
- }
-
/// A batch operation to add, edit or remove properties for a token.
///
/// - `nesting_budget`: Limit for searching parents in-depth to check ownership.
@@ -568,7 +523,7 @@
nesting_budget: &dyn Budget,
) -> DispatchResult {
let mut property_writer =
- pallet_common::property_writer_for_existing_token(collection, sender);
+ pallet_common::ExistingTokenPropertyWriter::new(collection, sender);
property_writer.write_token_properties(
sender,
@@ -915,7 +870,7 @@
// =========
- let mut property_writer = pallet_common::property_writer_for_new_token(collection, sender);
+ let mut property_writer = pallet_common::NewTokenPropertyWriter::new(collection, sender);
with_transaction(|| {
for (i, data) in data.iter().enumerate() {
pallets/nonfungible/src/weights.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/weights.rs
+++ b/pallets/nonfungible/src/weights.rs
@@ -3,9 +3,9 @@
//! Autogenerated weights for pallet_nonfungible
//!
//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev
-//! DATE: 2023-09-30, STEPS: `50`, REPEAT: `400`, LOW RANGE: `[]`, HIGH RANGE: `[]`
+//! DATE: 2023-10-05, STEPS: `50`, REPEAT: `80`, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! WORST CASE MAP SIZE: `1000000`
-//! HOSTNAME: `bench-host`, CPU: `Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz`
+//! HOSTNAME: `hearthstone`, CPU: `AMD Ryzen 9 7950X3D 16-Core Processor`
//! EXECUTION: None, WASM-EXECUTION: Compiled, CHAIN: None, DB CACHE: 1024
// Executed Command:
@@ -20,7 +20,7 @@
// *
// --template=.maintain/frame-weight-template.hbs
// --steps=50
-// --repeat=400
+// --repeat=80
// --heap-pages=4096
// --output=./pallets/nonfungible/src/weights.rs
@@ -46,7 +46,8 @@
fn burn_from() -> Weight;
fn set_token_property_permissions(b: u32, ) -> Weight;
fn set_token_properties(b: u32, ) -> Weight;
- fn init_token_properties(b: u32, ) -> Weight;
+ fn load_token_properties() -> Weight;
+ fn write_token_properties(b: u32, ) -> Weight;
fn delete_token_properties(b: u32, ) -> Weight;
fn token_owner() -> Weight;
fn set_allowance_for_all() -> Weight;
@@ -69,8 +70,8 @@
// Proof Size summary in bytes:
// Measured: `142`
// Estimated: `3530`
- // Minimum execution time: 9_726_000 picoseconds.
- Weight::from_parts(10_059_000, 3530)
+ // Minimum execution time: 4_990_000 picoseconds.
+ Weight::from_parts(5_170_000, 3530)
.saturating_add(T::DbWeight::get().reads(2_u64))
.saturating_add(T::DbWeight::get().writes(4_u64))
}
@@ -87,10 +88,10 @@
// Proof Size summary in bytes:
// Measured: `142`
// Estimated: `3530`
- // Minimum execution time: 3_270_000 picoseconds.
- Weight::from_parts(3_693_659, 3530)
- // Standard Error: 255
- .saturating_add(Weight::from_parts(3_024_284, 0).saturating_mul(b.into()))
+ // Minimum execution time: 1_680_000 picoseconds.
+ Weight::from_parts(1_720_000, 3530)
+ // Standard Error: 674
+ .saturating_add(Weight::from_parts(2_406_591, 0).saturating_mul(b.into()))
.saturating_add(T::DbWeight::get().reads(2_u64))
.saturating_add(T::DbWeight::get().writes(2_u64))
.saturating_add(T::DbWeight::get().writes((2_u64).saturating_mul(b.into())))
@@ -108,10 +109,10 @@
// Proof Size summary in bytes:
// Measured: `142`
// Estimated: `3481 + b * (2540 ±0)`
- // Minimum execution time: 3_188_000 picoseconds.
- Weight::from_parts(3_307_000, 3481)
- // Standard Error: 567
- .saturating_add(Weight::from_parts(4_320_449, 0).saturating_mul(b.into()))
+ // Minimum execution time: 1_680_000 picoseconds.
+ Weight::from_parts(1_720_000, 3481)
+ // Standard Error: 1_729
+ .saturating_add(Weight::from_parts(3_418_983, 0).saturating_mul(b.into()))
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().reads((1_u64).saturating_mul(b.into())))
.saturating_add(T::DbWeight::get().writes(1_u64))
@@ -136,8 +137,8 @@
// Proof Size summary in bytes:
// Measured: `380`
// Estimated: `3530`
- // Minimum execution time: 18_062_000 picoseconds.
- Weight::from_parts(18_433_000, 3530)
+ // Minimum execution time: 10_700_000 picoseconds.
+ Weight::from_parts(11_180_000, 3530)
.saturating_add(T::DbWeight::get().reads(5_u64))
.saturating_add(T::DbWeight::get().writes(5_u64))
}
@@ -159,8 +160,8 @@
// Proof Size summary in bytes:
// Measured: `380`
// Estimated: `3530`
- // Minimum execution time: 22_942_000 picoseconds.
- Weight::from_parts(23_527_000, 3530)
+ // Minimum execution time: 13_650_000 picoseconds.
+ Weight::from_parts(13_910_000, 3530)
.saturating_add(T::DbWeight::get().reads(5_u64))
.saturating_add(T::DbWeight::get().writes(5_u64))
}
@@ -185,10 +186,10 @@
// Proof Size summary in bytes:
// Measured: `1500 + b * (58 ±0)`
// Estimated: `5874 + b * (5032 ±0)`
- // Minimum execution time: 22_709_000 picoseconds.
- Weight::from_parts(23_287_000, 5874)
- // Standard Error: 89_471
- .saturating_add(Weight::from_parts(63_285_201, 0).saturating_mul(b.into()))
+ // Minimum execution time: 13_500_000 picoseconds.
+ Weight::from_parts(13_830_000, 5874)
+ // Standard Error: 136_447
+ .saturating_add(Weight::from_parts(43_149_279, 0).saturating_mul(b.into()))
.saturating_add(T::DbWeight::get().reads(7_u64))
.saturating_add(T::DbWeight::get().reads((4_u64).saturating_mul(b.into())))
.saturating_add(T::DbWeight::get().writes(6_u64))
@@ -207,8 +208,8 @@
// Proof Size summary in bytes:
// Measured: `380`
// Estimated: `6070`
- // Minimum execution time: 13_652_000 picoseconds.
- Weight::from_parts(13_981_000, 6070)
+ // Minimum execution time: 8_440_000 picoseconds.
+ Weight::from_parts(8_680_000, 6070)
.saturating_add(T::DbWeight::get().reads(4_u64))
.saturating_add(T::DbWeight::get().writes(5_u64))
}
@@ -220,8 +221,8 @@
// Proof Size summary in bytes:
// Measured: `326`
// Estimated: `3522`
- // Minimum execution time: 7_837_000 picoseconds.
- Weight::from_parts(8_113_000, 3522)
+ // Minimum execution time: 4_580_000 picoseconds.
+ Weight::from_parts(4_850_000, 3522)
.saturating_add(T::DbWeight::get().reads(2_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -233,8 +234,8 @@
// Proof Size summary in bytes:
// Measured: `313`
// Estimated: `3522`
- // Minimum execution time: 7_769_000 picoseconds.
- Weight::from_parts(7_979_000, 3522)
+ // Minimum execution time: 4_650_000 picoseconds.
+ Weight::from_parts(4_890_000, 3522)
.saturating_add(T::DbWeight::get().reads(2_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -244,8 +245,8 @@
// Proof Size summary in bytes:
// Measured: `362`
// Estimated: `3522`
- // Minimum execution time: 4_194_000 picoseconds.
- Weight::from_parts(4_353_000, 3522)
+ // Minimum execution time: 2_630_000 picoseconds.
+ Weight::from_parts(2_760_000, 3522)
.saturating_add(T::DbWeight::get().reads(1_u64))
}
/// Storage: Nonfungible Allowance (r:1 w:1)
@@ -266,8 +267,8 @@
// Proof Size summary in bytes:
// Measured: `463`
// Estimated: `3530`
- // Minimum execution time: 21_978_000 picoseconds.
- Weight::from_parts(22_519_000, 3530)
+ // Minimum execution time: 13_300_000 picoseconds.
+ Weight::from_parts(13_650_000, 3530)
.saturating_add(T::DbWeight::get().reads(5_u64))
.saturating_add(T::DbWeight::get().writes(6_u64))
}
@@ -278,10 +279,10 @@
// Proof Size summary in bytes:
// Measured: `314`
// Estimated: `20191`
- // Minimum execution time: 1_457_000 picoseconds.
- Weight::from_parts(1_563_000, 20191)
- // Standard Error: 14_041
- .saturating_add(Weight::from_parts(8_452_415, 0).saturating_mul(b.into()))
+ // Minimum execution time: 550_000 picoseconds.
+ Weight::from_parts(600_000, 20191)
+ // Standard Error: 23_117
+ .saturating_add(Weight::from_parts(6_048_092, 0).saturating_mul(b.into()))
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -296,24 +297,34 @@
// Proof Size summary in bytes:
// Measured: `640 + b * (261 ±0)`
// Estimated: `36269`
- // Minimum execution time: 963_000 picoseconds.
- Weight::from_parts(1_126_511, 36269)
- // Standard Error: 9_175
- .saturating_add(Weight::from_parts(5_096_011, 0).saturating_mul(b.into()))
+ // Minimum execution time: 340_000 picoseconds.
+ Weight::from_parts(7_359_078, 36269)
+ // Standard Error: 9_052
+ .saturating_add(Weight::from_parts(2_763_267, 0).saturating_mul(b.into()))
.saturating_add(T::DbWeight::get().reads(3_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
+ /// Storage: Nonfungible TokenProperties (r:1 w:0)
+ /// Proof: Nonfungible TokenProperties (max_values: None, max_size: Some(32804), added: 35279, mode: MaxEncodedLen)
+ fn load_token_properties() -> Weight {
+ // Proof Size summary in bytes:
+ // Measured: `279`
+ // Estimated: `36269`
+ // Minimum execution time: 1_610_000 picoseconds.
+ Weight::from_parts(1_690_000, 36269)
+ .saturating_add(T::DbWeight::get().reads(1_u64))
+ }
/// Storage: Nonfungible TokenProperties (r:0 w:1)
/// Proof: Nonfungible TokenProperties (max_values: None, max_size: Some(32804), added: 35279, mode: MaxEncodedLen)
/// The range of component `b` is `[0, 64]`.
- fn init_token_properties(b: u32, ) -> Weight {
+ fn write_token_properties(b: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
- // Minimum execution time: 194_000 picoseconds.
- Weight::from_parts(222_000, 0)
- // Standard Error: 7_295
- .saturating_add(Weight::from_parts(4_499_463, 0).saturating_mul(b.into()))
+ // Minimum execution time: 70_000 picoseconds.
+ Weight::from_parts(3_262_181, 0)
+ // Standard Error: 5_240
+ .saturating_add(Weight::from_parts(2_426_582, 0).saturating_mul(b.into()))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
/// Storage: Common CollectionPropertyPermissions (r:1 w:0)
@@ -327,10 +338,10 @@
// Proof Size summary in bytes:
// Measured: `699 + b * (33291 ±0)`
// Estimated: `36269`
- // Minimum execution time: 992_000 picoseconds.
- Weight::from_parts(1_043_000, 36269)
- // Standard Error: 37_370
- .saturating_add(Weight::from_parts(23_672_870, 0).saturating_mul(b.into()))
+ // Minimum execution time: 350_000 picoseconds.
+ Weight::from_parts(370_000, 36269)
+ // Standard Error: 29_081
+ .saturating_add(Weight::from_parts(9_667_268, 0).saturating_mul(b.into()))
.saturating_add(T::DbWeight::get().reads(3_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -340,8 +351,8 @@
// Proof Size summary in bytes:
// Measured: `326`
// Estimated: `3522`
- // Minimum execution time: 3_743_000 picoseconds.
- Weight::from_parts(3_908_000, 3522)
+ // Minimum execution time: 2_380_000 picoseconds.
+ Weight::from_parts(2_500_000, 3522)
.saturating_add(T::DbWeight::get().reads(1_u64))
}
/// Storage: Nonfungible CollectionAllowance (r:0 w:1)
@@ -350,8 +361,8 @@
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
- // Minimum execution time: 4_106_000 picoseconds.
- Weight::from_parts(4_293_000, 0)
+ // Minimum execution time: 2_060_000 picoseconds.
+ Weight::from_parts(2_150_000, 0)
.saturating_add(T::DbWeight::get().writes(1_u64))
}
/// Storage: Nonfungible CollectionAllowance (r:1 w:0)
@@ -360,8 +371,8 @@
// Proof Size summary in bytes:
// Measured: `142`
// Estimated: `3576`
- // Minimum execution time: 2_775_000 picoseconds.
- Weight::from_parts(2_923_000, 3576)
+ // Minimum execution time: 1_630_000 picoseconds.
+ Weight::from_parts(1_730_000, 3576)
.saturating_add(T::DbWeight::get().reads(1_u64))
}
/// Storage: Nonfungible TokenProperties (r:1 w:1)
@@ -370,8 +381,8 @@
// Proof Size summary in bytes:
// Measured: `279`
// Estimated: `36269`
- // Minimum execution time: 3_033_000 picoseconds.
- Weight::from_parts(3_174_000, 36269)
+ // Minimum execution time: 1_700_000 picoseconds.
+ Weight::from_parts(1_780_000, 36269)
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -391,8 +402,8 @@
// Proof Size summary in bytes:
// Measured: `142`
// Estimated: `3530`
- // Minimum execution time: 9_726_000 picoseconds.
- Weight::from_parts(10_059_000, 3530)
+ // Minimum execution time: 4_990_000 picoseconds.
+ Weight::from_parts(5_170_000, 3530)
.saturating_add(RocksDbWeight::get().reads(2_u64))
.saturating_add(RocksDbWeight::get().writes(4_u64))
}
@@ -409,10 +420,10 @@
// Proof Size summary in bytes:
// Measured: `142`
// Estimated: `3530`
- // Minimum execution time: 3_270_000 picoseconds.
- Weight::from_parts(3_693_659, 3530)
- // Standard Error: 255
- .saturating_add(Weight::from_parts(3_024_284, 0).saturating_mul(b.into()))
+ // Minimum execution time: 1_680_000 picoseconds.
+ Weight::from_parts(1_720_000, 3530)
+ // Standard Error: 674
+ .saturating_add(Weight::from_parts(2_406_591, 0).saturating_mul(b.into()))
.saturating_add(RocksDbWeight::get().reads(2_u64))
.saturating_add(RocksDbWeight::get().writes(2_u64))
.saturating_add(RocksDbWeight::get().writes((2_u64).saturating_mul(b.into())))
@@ -430,10 +441,10 @@
// Proof Size summary in bytes:
// Measured: `142`
// Estimated: `3481 + b * (2540 ±0)`
- // Minimum execution time: 3_188_000 picoseconds.
- Weight::from_parts(3_307_000, 3481)
- // Standard Error: 567
- .saturating_add(Weight::from_parts(4_320_449, 0).saturating_mul(b.into()))
+ // Minimum execution time: 1_680_000 picoseconds.
+ Weight::from_parts(1_720_000, 3481)
+ // Standard Error: 1_729
+ .saturating_add(Weight::from_parts(3_418_983, 0).saturating_mul(b.into()))
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().reads((1_u64).saturating_mul(b.into())))
.saturating_add(RocksDbWeight::get().writes(1_u64))
@@ -458,8 +469,8 @@
// Proof Size summary in bytes:
// Measured: `380`
// Estimated: `3530`
- // Minimum execution time: 18_062_000 picoseconds.
- Weight::from_parts(18_433_000, 3530)
+ // Minimum execution time: 10_700_000 picoseconds.
+ Weight::from_parts(11_180_000, 3530)
.saturating_add(RocksDbWeight::get().reads(5_u64))
.saturating_add(RocksDbWeight::get().writes(5_u64))
}
@@ -481,8 +492,8 @@
// Proof Size summary in bytes:
// Measured: `380`
// Estimated: `3530`
- // Minimum execution time: 22_942_000 picoseconds.
- Weight::from_parts(23_527_000, 3530)
+ // Minimum execution time: 13_650_000 picoseconds.
+ Weight::from_parts(13_910_000, 3530)
.saturating_add(RocksDbWeight::get().reads(5_u64))
.saturating_add(RocksDbWeight::get().writes(5_u64))
}
@@ -507,10 +518,10 @@
// Proof Size summary in bytes:
// Measured: `1500 + b * (58 ±0)`
// Estimated: `5874 + b * (5032 ±0)`
- // Minimum execution time: 22_709_000 picoseconds.
- Weight::from_parts(23_287_000, 5874)
- // Standard Error: 89_471
- .saturating_add(Weight::from_parts(63_285_201, 0).saturating_mul(b.into()))
+ // Minimum execution time: 13_500_000 picoseconds.
+ Weight::from_parts(13_830_000, 5874)
+ // Standard Error: 136_447
+ .saturating_add(Weight::from_parts(43_149_279, 0).saturating_mul(b.into()))
.saturating_add(RocksDbWeight::get().reads(7_u64))
.saturating_add(RocksDbWeight::get().reads((4_u64).saturating_mul(b.into())))
.saturating_add(RocksDbWeight::get().writes(6_u64))
@@ -529,8 +540,8 @@
// Proof Size summary in bytes:
// Measured: `380`
// Estimated: `6070`
- // Minimum execution time: 13_652_000 picoseconds.
- Weight::from_parts(13_981_000, 6070)
+ // Minimum execution time: 8_440_000 picoseconds.
+ Weight::from_parts(8_680_000, 6070)
.saturating_add(RocksDbWeight::get().reads(4_u64))
.saturating_add(RocksDbWeight::get().writes(5_u64))
}
@@ -542,8 +553,8 @@
// Proof Size summary in bytes:
// Measured: `326`
// Estimated: `3522`
- // Minimum execution time: 7_837_000 picoseconds.
- Weight::from_parts(8_113_000, 3522)
+ // Minimum execution time: 4_580_000 picoseconds.
+ Weight::from_parts(4_850_000, 3522)
.saturating_add(RocksDbWeight::get().reads(2_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -555,8 +566,8 @@
// Proof Size summary in bytes:
// Measured: `313`
// Estimated: `3522`
- // Minimum execution time: 7_769_000 picoseconds.
- Weight::from_parts(7_979_000, 3522)
+ // Minimum execution time: 4_650_000 picoseconds.
+ Weight::from_parts(4_890_000, 3522)
.saturating_add(RocksDbWeight::get().reads(2_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -566,8 +577,8 @@
// Proof Size summary in bytes:
// Measured: `362`
// Estimated: `3522`
- // Minimum execution time: 4_194_000 picoseconds.
- Weight::from_parts(4_353_000, 3522)
+ // Minimum execution time: 2_630_000 picoseconds.
+ Weight::from_parts(2_760_000, 3522)
.saturating_add(RocksDbWeight::get().reads(1_u64))
}
/// Storage: Nonfungible Allowance (r:1 w:1)
@@ -588,8 +599,8 @@
// Proof Size summary in bytes:
// Measured: `463`
// Estimated: `3530`
- // Minimum execution time: 21_978_000 picoseconds.
- Weight::from_parts(22_519_000, 3530)
+ // Minimum execution time: 13_300_000 picoseconds.
+ Weight::from_parts(13_650_000, 3530)
.saturating_add(RocksDbWeight::get().reads(5_u64))
.saturating_add(RocksDbWeight::get().writes(6_u64))
}
@@ -600,10 +611,10 @@
// Proof Size summary in bytes:
// Measured: `314`
// Estimated: `20191`
- // Minimum execution time: 1_457_000 picoseconds.
- Weight::from_parts(1_563_000, 20191)
- // Standard Error: 14_041
- .saturating_add(Weight::from_parts(8_452_415, 0).saturating_mul(b.into()))
+ // Minimum execution time: 550_000 picoseconds.
+ Weight::from_parts(600_000, 20191)
+ // Standard Error: 23_117
+ .saturating_add(Weight::from_parts(6_048_092, 0).saturating_mul(b.into()))
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -618,24 +629,34 @@
// Proof Size summary in bytes:
// Measured: `640 + b * (261 ±0)`
// Estimated: `36269`
- // Minimum execution time: 963_000 picoseconds.
- Weight::from_parts(1_126_511, 36269)
- // Standard Error: 9_175
- .saturating_add(Weight::from_parts(5_096_011, 0).saturating_mul(b.into()))
+ // Minimum execution time: 340_000 picoseconds.
+ Weight::from_parts(7_359_078, 36269)
+ // Standard Error: 9_052
+ .saturating_add(Weight::from_parts(2_763_267, 0).saturating_mul(b.into()))
.saturating_add(RocksDbWeight::get().reads(3_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
+ /// Storage: Nonfungible TokenProperties (r:1 w:0)
+ /// Proof: Nonfungible TokenProperties (max_values: None, max_size: Some(32804), added: 35279, mode: MaxEncodedLen)
+ fn load_token_properties() -> Weight {
+ // Proof Size summary in bytes:
+ // Measured: `279`
+ // Estimated: `36269`
+ // Minimum execution time: 1_610_000 picoseconds.
+ Weight::from_parts(1_690_000, 36269)
+ .saturating_add(RocksDbWeight::get().reads(1_u64))
+ }
/// Storage: Nonfungible TokenProperties (r:0 w:1)
/// Proof: Nonfungible TokenProperties (max_values: None, max_size: Some(32804), added: 35279, mode: MaxEncodedLen)
/// The range of component `b` is `[0, 64]`.
- fn init_token_properties(b: u32, ) -> Weight {
+ fn write_token_properties(b: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
- // Minimum execution time: 194_000 picoseconds.
- Weight::from_parts(222_000, 0)
- // Standard Error: 7_295
- .saturating_add(Weight::from_parts(4_499_463, 0).saturating_mul(b.into()))
+ // Minimum execution time: 70_000 picoseconds.
+ Weight::from_parts(3_262_181, 0)
+ // Standard Error: 5_240
+ .saturating_add(Weight::from_parts(2_426_582, 0).saturating_mul(b.into()))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
/// Storage: Common CollectionPropertyPermissions (r:1 w:0)
@@ -649,10 +670,10 @@
// Proof Size summary in bytes:
// Measured: `699 + b * (33291 ±0)`
// Estimated: `36269`
- // Minimum execution time: 992_000 picoseconds.
- Weight::from_parts(1_043_000, 36269)
- // Standard Error: 37_370
- .saturating_add(Weight::from_parts(23_672_870, 0).saturating_mul(b.into()))
+ // Minimum execution time: 350_000 picoseconds.
+ Weight::from_parts(370_000, 36269)
+ // Standard Error: 29_081
+ .saturating_add(Weight::from_parts(9_667_268, 0).saturating_mul(b.into()))
.saturating_add(RocksDbWeight::get().reads(3_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -662,8 +683,8 @@
// Proof Size summary in bytes:
// Measured: `326`
// Estimated: `3522`
- // Minimum execution time: 3_743_000 picoseconds.
- Weight::from_parts(3_908_000, 3522)
+ // Minimum execution time: 2_380_000 picoseconds.
+ Weight::from_parts(2_500_000, 3522)
.saturating_add(RocksDbWeight::get().reads(1_u64))
}
/// Storage: Nonfungible CollectionAllowance (r:0 w:1)
@@ -672,8 +693,8 @@
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
- // Minimum execution time: 4_106_000 picoseconds.
- Weight::from_parts(4_293_000, 0)
+ // Minimum execution time: 2_060_000 picoseconds.
+ Weight::from_parts(2_150_000, 0)
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
/// Storage: Nonfungible CollectionAllowance (r:1 w:0)
@@ -682,8 +703,8 @@
// Proof Size summary in bytes:
// Measured: `142`
// Estimated: `3576`
- // Minimum execution time: 2_775_000 picoseconds.
- Weight::from_parts(2_923_000, 3576)
+ // Minimum execution time: 1_630_000 picoseconds.
+ Weight::from_parts(1_730_000, 3576)
.saturating_add(RocksDbWeight::get().reads(1_u64))
}
/// Storage: Nonfungible TokenProperties (r:1 w:1)
@@ -692,8 +713,8 @@
// Proof Size summary in bytes:
// Measured: `279`
// Estimated: `36269`
- // Minimum execution time: 3_033_000 picoseconds.
- Weight::from_parts(3_174_000, 36269)
+ // Minimum execution time: 1_700_000 picoseconds.
+ Weight::from_parts(1_780_000, 36269)
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
pallets/refungible/src/benchmarking.rsdiffbeforeafterboth--- a/pallets/refungible/src/benchmarking.rs
+++ b/pallets/refungible/src/benchmarking.rs
@@ -19,10 +19,7 @@
use frame_benchmarking::v2::*;
use pallet_common::{
bench_init,
- benchmarking::{
- create_collection_raw, /*load_is_admin_and_property_permissions,*/ property_key,
- property_value,
- },
+ benchmarking::{create_collection_raw, property_key, property_value},
};
use sp_std::prelude::*;
use up_data_structs::{
@@ -424,6 +421,81 @@
Ok(())
}
+ // set_token_properties {
+ // let b in 0..MAX_PROPERTIES_PER_ITEM;
+ // bench_init!{
+ // owner: sub; collection: collection(owner);
+ // owner: cross_from_sub;
+ // };
+ // let perms = (0..b).map(|k| PropertyKeyPermission {
+ // key: property_key(k as usize),
+ // permission: PropertyPermission {
+ // mutable: false,
+ // collection_admin: true,
+ // token_owner: true,
+ // },
+ // }).collect::<Vec<_>>();
+ // <Pallet<T>>::set_token_property_permissions(&collection, &owner, perms)?;
+ // let props = (0..b).map(|k| Property {
+ // key: property_key(k as usize),
+ // value: property_value(),
+ // }).collect::<Vec<_>>();
+ // let item = create_max_item(&collection, &owner, [(owner.clone(), 200)])?;
+ // }: {<Pallet<T>>::set_token_properties(&collection, &owner, item, props.into_iter(), &Unlimited)?}
+
+ // load_token_properties {
+ // bench_init!{
+ // owner: sub; collection: collection(owner);
+ // owner: cross_from_sub;
+ // };
+
+ // let item = create_max_item(&collection, &owner, [(owner.clone(), 200)])?;
+ // }: {
+ // pallet_common::BenchmarkPropertyWriter::<T>::load_token_properties(
+ // &collection,
+ // item,
+ // )
+ // }
+
+ // write_token_properties {
+ // let b in 0..MAX_PROPERTIES_PER_ITEM;
+ // bench_init!{
+ // owner: sub; collection: collection(owner);
+ // owner: cross_from_sub;
+ // };
+
+ // let perms = (0..b).map(|k| PropertyKeyPermission {
+ // key: property_key(k as usize),
+ // permission: PropertyPermission {
+ // mutable: false,
+ // collection_admin: true,
+ // token_owner: true,
+ // },
+ // }).collect::<Vec<_>>();
+ // <Pallet<T>>::set_token_property_permissions(&collection, &owner, perms)?;
+ // let props = (0..b).map(|k| Property {
+ // key: property_key(k as usize),
+ // value: property_value(),
+ // }).collect::<Vec<_>>();
+ // let item = create_max_item(&collection, &owner, [(owner.clone(), 200)])?;
+
+ // let lazy_collection_info = pallet_common::BenchmarkPropertyWriter::<T>::load_collection_info(
+ // &collection,
+ // &owner,
+ // );
+ // }: {
+ // let mut property_writer = pallet_common::BenchmarkPropertyWriter::new(&collection, lazy_collection_info);
+
+ // property_writer.write_token_properties(
+ // item,
+ // props.into_iter(),
+ // crate::erc::ERC721TokenEvent::TokenChanged {
+ // token_id: item.into(),
+ // }
+ // .to_log(T::ContractAddress::get()),
+ // )?
+ // }
+
#[benchmark]
fn set_token_property_permissions(
b: Linear<0, MAX_PROPERTIES_PER_ITEM>,
pallets/refungible/src/common.rsdiffbeforeafterboth--- a/pallets/refungible/src/common.rs
+++ b/pallets/refungible/src/common.rs
@@ -16,14 +16,12 @@
use core::marker::PhantomData;
-use frame_support::{
- dispatch::DispatchResultWithPostInfo, ensure, fail, traits::Get, weights::Weight,
-};
+use frame_support::{dispatch::DispatchResultWithPostInfo, fail, weights::Weight};
use pallet_common::{
- init_token_properties_delta, weights::WeightInfo as _, with_weight, CommonCollectionOperations,
- CommonWeightInfo, RefungibleExtensions,
+ weights::WeightInfo as _, with_weight, write_token_properties_total_weight,
+ CommonCollectionOperations, CommonWeightInfo, RefungibleExtensions,
};
-use pallet_structure::{Error as StructureError, Pallet as PalletStructure};
+use pallet_structure::Pallet as PalletStructure;
use sp_runtime::DispatchError;
use sp_std::{collections::btree_map::BTreeMap, vec, vec::Vec};
use up_data_structs::{
@@ -50,14 +48,14 @@
impl<T: Config> CommonWeightInfo<T::CrossAccountId> for CommonWeights<T> {
fn create_multiple_items(data: &[up_data_structs::CreateItemData]) -> Weight {
<SelfWeightOf<T>>::create_multiple_items(data.len() as u32).saturating_add(
- init_token_properties_delta::<T, _>(
+ write_token_properties_total_weight::<T, _>(
data.iter().map(|data| match data {
up_data_structs::CreateItemData::ReFungible(rft_data) => {
rft_data.properties.len() as u32
}
_ => 0,
}),
- <SelfWeightOf<T>>::init_token_properties,
+ <SelfWeightOf<T>>::write_token_properties,
),
)
}
@@ -66,16 +64,16 @@
match call {
CreateItemExData::RefungibleMultipleOwners(i) => {
<SelfWeightOf<T>>::create_multiple_items_ex_multiple_owners(i.users.len() as u32)
- .saturating_add(init_token_properties_delta::<T, _>(
+ .saturating_add(write_token_properties_total_weight::<T, _>(
[i.properties.len() as u32].into_iter(),
- <SelfWeightOf<T>>::init_token_properties,
+ <SelfWeightOf<T>>::write_token_properties,
))
}
CreateItemExData::RefungibleMultipleItems(i) => {
<SelfWeightOf<T>>::create_multiple_items_ex_multiple_items(i.len() as u32)
- .saturating_add(init_token_properties_delta::<T, _>(
+ .saturating_add(write_token_properties_total_weight::<T, _>(
i.iter().map(|d| d.properties.len() as u32),
- <SelfWeightOf<T>>::init_token_properties,
+ <SelfWeightOf<T>>::write_token_properties,
))
}
_ => Weight::zero(),
@@ -88,18 +86,13 @@
fn set_collection_properties(amount: u32) -> Weight {
<pallet_common::SelfWeightOf<T>>::set_collection_properties(amount)
- }
-
- fn delete_collection_properties(amount: u32) -> Weight {
- <pallet_common::SelfWeightOf<T>>::delete_collection_properties(amount)
}
fn set_token_properties(amount: u32) -> Weight {
- <SelfWeightOf<T>>::set_token_properties(amount)
- }
-
- fn delete_token_properties(amount: u32) -> Weight {
- <SelfWeightOf<T>>::delete_token_properties(amount)
+ write_token_properties_total_weight::<T, _>([amount].into_iter(), |amount| {
+ <SelfWeightOf<T>>::load_token_properties()
+ + <SelfWeightOf<T>>::write_token_properties(amount)
+ })
}
fn set_token_property_permissions(amount: u32) -> Weight {
@@ -136,19 +129,6 @@
<SelfWeightOf<T>>::burn_from()
}
- fn burn_recursively_self_raw() -> Weight {
- // Read to get total balance
- Self::burn_item() + T::DbWeight::get().reads(1)
- }
- fn burn_recursively_breadth_raw(_amount: u32) -> Weight {
- // Refungible token can't have children
- Weight::zero()
- }
-
- fn token_owner() -> Weight {
- <SelfWeightOf<T>>::token_owner()
- }
-
fn set_allowance_for_all() -> Weight {
<SelfWeightOf<T>>::set_allowance_for_all()
}
@@ -262,25 +242,6 @@
with_weight(
<Pallet<T>>::burn(self, &sender, token, amount),
<CommonWeights<T>>::burn_item(),
- )
- }
-
- fn burn_item_recursively(
- &self,
- sender: T::CrossAccountId,
- token: TokenId,
- self_budget: &dyn Budget,
- _breadth_budget: &dyn Budget,
- ) -> DispatchResultWithPostInfo {
- ensure!(self_budget.consume(), <StructureError<T>>::DepthLimit,);
- with_weight(
- <Pallet<T>>::burn(
- self,
- &sender,
- token,
- <Balance<T>>::get((self.id, token, &sender)),
- ),
- <CommonWeights<T>>::burn_recursively_self_raw(),
)
}
pallets/refungible/src/erc.rsdiffbeforeafterboth1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617//! # Refungible Pallet EVM API for tokens18//!19//! Provides ERC-721 standart support implementation and EVM API for unique extensions for Refungible Pallet.20//! Method implementations are mostly doing parameter conversion and calling Refungible Pallet methods.2122extern crate alloc;2324use alloc::string::ToString;25use core::{26 char::{decode_utf16, REPLACEMENT_CHARACTER},27 convert::TryInto,28};2930use evm_coder::{abi::AbiType, generate_stubgen, solidity_interface, types::*, AbiCoder, ToLog};31use frame_support::{BoundedBTreeMap, BoundedVec};32use pallet_common::{33 erc::{static_property::key, CollectionCall, CommonEvmHandler},34 eth::{self, TokenUri},35 CollectionHandle, CollectionPropertyPermissions, CommonCollectionOperations,36 Error as CommonError,37};38use pallet_evm::{account::CrossAccountId, PrecompileHandle};39use pallet_evm_coder_substrate::{40 call, dispatch_to_evm,41 execution::{Error, PreDispatch, Result},42 frontier_contract,43};44use pallet_structure::{weights::WeightInfo as _, SelfWeightOf as StructureWeight};45use sp_core::{Get, H160, U256};46use sp_std::{collections::btree_map::BTreeMap, vec, vec::Vec};47use up_data_structs::{48 mapping::TokenAddressMapping, CollectionId, CollectionPropertiesVec, Property, PropertyKey,49 PropertyKeyPermission, PropertyPermission, TokenId, TokenOwnerError,50};5152use crate::{53 weights::WeightInfo, AccountBalance, Balance, Config, CreateItemData, Pallet, RefungibleHandle,54 SelfWeightOf, TokenProperties, TokensMinted, TotalSupply,55};5657frontier_contract! {58 macro_rules! RefungibleHandle_result {...}59 impl<T: Config> Contract for RefungibleHandle<T> {...}60}6162pub const ADDRESS_FOR_PARTIALLY_OWNED_TOKENS: H160 = H160::repeat_byte(0xff);6364/// Rft events.65#[derive(ToLog)]66pub enum ERC721TokenEvent {67 /// The token has been changed.68 TokenChanged {69 /// Token ID.70 #[indexed]71 token_id: U256,72 },73}7475/// Token minting parameters76#[derive(AbiCoder, Default, Debug)]77pub struct OwnerPieces {78 /// Minted token owner79 pub owner: eth::CrossAddress,80 /// Number of token pieces81 pub pieces: u128,82}8384/// Token minting parameters85#[derive(AbiCoder, Default, Debug)]86pub struct MintTokenData {87 /// Minted token owner and number of pieces88 pub owners: Vec<OwnerPieces>,89 /// Minted token properties90 pub properties: Vec<eth::Property>,91}9293/// @title A contract that allows to set and delete token properties and change token property permissions.94#[solidity_interface(name = TokenProperties, events(ERC721TokenEvent), enum(derive(PreDispatch)), enum_attr(weight))]95impl<T: Config> RefungibleHandle<T> {96 /// @notice Set permissions for token property.97 /// @dev Throws error if `msg.sender` is not admin or owner of the collection.98 /// @param key Property key.99 /// @param isMutable Permission to mutate property.100 /// @param collectionAdmin Permission to mutate property by collection admin if property is mutable.101 /// @param tokenOwner Permission to mutate property by token owner if property is mutable.102 #[solidity(hide)]103 #[weight(<SelfWeightOf<T>>::set_token_property_permissions(1))]104 fn set_token_property_permission(105 &mut self,106 caller: Caller,107 key: String,108 is_mutable: bool,109 collection_admin: bool,110 token_owner: bool,111 ) -> Result<()> {112 let caller = T::CrossAccountId::from_eth(caller);113 <Pallet<T>>::set_token_property_permissions(114 self,115 &caller,116 vec![PropertyKeyPermission {117 key: <Vec<u8>>::from(key)118 .try_into()119 .map_err(|_| "too long key")?,120 permission: PropertyPermission {121 mutable: is_mutable,122 collection_admin,123 token_owner,124 },125 }],126 )127 .map_err(dispatch_to_evm::<T>)128 }129130 /// @notice Set permissions for token property.131 /// @dev Throws error if `msg.sender` is not admin or owner of the collection.132 /// @param permissions Permissions for keys.133 #[weight(<SelfWeightOf<T>>::set_token_property_permissions(permissions.len() as u32))]134 fn set_token_property_permissions(135 &mut self,136 caller: Caller,137 permissions: Vec<eth::TokenPropertyPermission>,138 ) -> Result<()> {139 let caller = T::CrossAccountId::from_eth(caller);140 let perms = eth::TokenPropertyPermission::into_property_key_permissions(permissions)?;141142 <Pallet<T>>::set_token_property_permissions(self, &caller, perms)143 .map_err(dispatch_to_evm::<T>)144 }145146 /// @notice Get permissions for token properties.147 fn token_property_permissions(&self) -> Result<Vec<eth::TokenPropertyPermission>> {148 let perms = <Pallet<T>>::token_property_permission(self.id);149 Ok(perms150 .into_iter()151 .map(eth::TokenPropertyPermission::from)152 .collect())153 }154155 /// @notice Set token property value.156 /// @dev Throws error if `msg.sender` has no permission to edit the property.157 /// @param tokenId ID of the token.158 /// @param key Property key.159 /// @param value Property value.160 #[solidity(hide)]161 #[weight(<SelfWeightOf<T>>::set_token_properties(1))]162 fn set_property(163 &mut self,164 caller: Caller,165 token_id: U256,166 key: String,167 value: Bytes,168 ) -> Result<()> {169 let caller = T::CrossAccountId::from_eth(caller);170 let token_id: u32 = token_id.try_into().map_err(|_| "token id overflow")?;171 let key = <Vec<u8>>::from(key)172 .try_into()173 .map_err(|_| "key too long")?;174 let value = value.0.try_into().map_err(|_| "value too long")?;175176 let nesting_budget = self177 .recorder178 .weight_calls_budget(<StructureWeight<T>>::find_parent());179180 <Pallet<T>>::set_token_property(181 self,182 &caller,183 TokenId(token_id),184 Property { key, value },185 &nesting_budget,186 )187 .map_err(dispatch_to_evm::<T>)188 }189190 /// @notice Set token properties value.191 /// @dev Throws error if `msg.sender` has no permission to edit the property.192 /// @param tokenId ID of the token.193 /// @param properties settable properties194 #[weight(<SelfWeightOf<T>>::set_token_properties(properties.len() as u32))]195 fn set_properties(196 &mut self,197 caller: Caller,198 token_id: U256,199 properties: Vec<eth::Property>,200 ) -> Result<()> {201 let caller = T::CrossAccountId::from_eth(caller);202 let token_id: u32 = token_id.try_into().map_err(|_| "token id overflow")?;203204 let nesting_budget = self205 .recorder206 .weight_calls_budget(<StructureWeight<T>>::find_parent());207208 let properties = properties209 .into_iter()210 .map(eth::Property::try_into)211 .collect::<Result<Vec<_>>>()?;212213 <Pallet<T>>::set_token_properties(214 self,215 &caller,216 TokenId(token_id),217 properties.into_iter(),218 &nesting_budget,219 )220 .map_err(dispatch_to_evm::<T>)221 }222223 /// @notice Delete token property value.224 /// @dev Throws error if `msg.sender` has no permission to edit the property.225 /// @param tokenId ID of the token.226 /// @param key Property key.227 #[solidity(hide)]228 #[weight(<SelfWeightOf<T>>::delete_token_properties(1))]229 fn delete_property(&mut self, token_id: U256, caller: Caller, key: String) -> Result<()> {230 let caller = T::CrossAccountId::from_eth(caller);231 let token_id: u32 = token_id.try_into().map_err(|_| "token id overflow")?;232 let key = <Vec<u8>>::from(key)233 .try_into()234 .map_err(|_| "key too long")?;235236 let nesting_budget = self237 .recorder238 .weight_calls_budget(<StructureWeight<T>>::find_parent());239240 <Pallet<T>>::delete_token_property(self, &caller, TokenId(token_id), key, &nesting_budget)241 .map_err(dispatch_to_evm::<T>)242 }243244 /// @notice Delete token properties value.245 /// @dev Throws error if `msg.sender` has no permission to edit the property.246 /// @param tokenId ID of the token.247 /// @param keys Properties key.248 #[weight(<SelfWeightOf<T>>::delete_token_properties(keys.len() as u32))]249 fn delete_properties(250 &mut self,251 token_id: U256,252 caller: Caller,253 keys: Vec<String>,254 ) -> Result<()> {255 let caller = T::CrossAccountId::from_eth(caller);256 let token_id: u32 = token_id.try_into().map_err(|_| "token id overflow")?;257 let keys = keys258 .into_iter()259 .map(|k| Ok(<Vec<u8>>::from(k).try_into().map_err(|_| "key too long")?))260 .collect::<Result<Vec<_>>>()?;261262 let nesting_budget = self263 .recorder264 .weight_calls_budget(<StructureWeight<T>>::find_parent());265266 <Pallet<T>>::delete_token_properties(267 self,268 &caller,269 TokenId(token_id),270 keys.into_iter(),271 &nesting_budget,272 )273 .map_err(dispatch_to_evm::<T>)274 }275276 /// @notice Get token property value.277 /// @dev Throws error if key not found278 /// @param tokenId ID of the token.279 /// @param key Property key.280 /// @return Property value bytes281 fn property(&self, token_id: U256, key: String) -> Result<Bytes> {282 let token_id: u32 = token_id.try_into().map_err(|_| "token id overflow")?;283 let key = <Vec<u8>>::from(key)284 .try_into()285 .map_err(|_| "key too long")?;286287 let props =288 <TokenProperties<T>>::get((self.id, token_id)).ok_or("token properties not found")?;289 let prop = props.get(&key).ok_or("key not found")?;290291 Ok(prop.to_vec().into())292 }293}294295#[derive(ToLog)]296pub enum ERC721Events {297 /// @dev This event emits when NFTs are created (`from` == 0) and destroyed298 /// (`to` == 0). Exception: during contract creation, any number of RFTs299 /// may be created and assigned without emitting Transfer.300 Transfer {301 #[indexed]302 from: Address,303 #[indexed]304 to: Address,305 #[indexed]306 token_id: U256,307 },308 /// @dev Not supported309 Approval {310 #[indexed]311 owner: Address,312 #[indexed]313 approved: Address,314 #[indexed]315 token_id: U256,316 },317 /// @dev Not supported318 #[allow(dead_code)]319 ApprovalForAll {320 #[indexed]321 owner: Address,322 #[indexed]323 operator: Address,324 approved: bool,325 },326}327328/// @title ERC-721 Non-Fungible Token Standard, optional metadata extension329/// @dev See https://eips.ethereum.org/EIPS/eip-721330#[solidity_interface(name = ERC721Metadata, enum(derive(PreDispatch)), expect_selector = 0x5b5e139f)]331impl<T: Config> RefungibleHandle<T>332where333 T::AccountId: From<[u8; 32]> + AsRef<[u8; 32]>,334{335 /// @notice A descriptive name for a collection of NFTs in this contract336 /// @dev real implementation of this function lies in `ERC721UniqueExtensions`337 #[solidity(hide, rename_selector = "name")]338 fn name_proxy(&self) -> Result<String> {339 self.name()340 }341342 /// @notice An abbreviated name for NFTs in this contract343 /// @dev real implementation of this function lies in `ERC721UniqueExtensions`344 #[solidity(hide, rename_selector = "symbol")]345 fn symbol_proxy(&self) -> Result<String> {346 self.symbol()347 }348349 /// @notice A distinct Uniform Resource Identifier (URI) for a given asset.350 ///351 /// @dev If the token has a `url` property and it is not empty, it is returned.352 /// Else If the collection does not have a property with key `schemaName` or its value is not equal to `ERC721Metadata`, it return an error `tokenURI not set`.353 /// If the collection property `baseURI` is empty or absent, return "" (empty string)354 /// otherwise, if token property `suffix` present and is non-empty, return concatenation of baseURI and suffix355 /// otherwise, return concatenation of `baseURI` and stringified token id (decimal stringifying, without paddings).356 ///357 /// @return token's const_metadata358 #[solidity(rename_selector = "tokenURI")]359 fn token_uri(&self, token_id: U256) -> Result<String> {360 let token_id_u32: u32 = token_id.try_into().map_err(|_| "token id overflow")?;361362 match get_token_property(self, token_id_u32, &key::url()).as_deref() {363 Err(_) | Ok("") => (),364 Ok(url) => {365 return Ok(url.into());366 }367 };368369 let base_uri =370 pallet_common::Pallet::<T>::get_collection_property(self.id, &key::base_uri())371 .map(BoundedVec::into_inner)372 .map(String::from_utf8)373 .transpose()374 .map_err(|e| {375 Error::Revert(alloc::format!(376 "can not convert value \"baseURI\" to string with error \"{e}\""377 ))378 })?;379380 let base_uri = match base_uri.as_deref() {381 None | Some("") => {382 return Ok("".into());383 }384 Some(base_uri) => base_uri.into(),385 };386387 Ok(388 match get_token_property(self, token_id_u32, &key::suffix()).as_deref() {389 Err(_) | Ok("") => base_uri,390 Ok(suffix) => base_uri + suffix,391 },392 )393 }394}395396/// @title ERC-721 Non-Fungible Token Standard, optional enumeration extension397/// @dev See https://eips.ethereum.org/EIPS/eip-721398#[solidity_interface(name = ERC721Enumerable, enum(derive(PreDispatch)), expect_selector = 0x780e9d63)]399impl<T: Config> RefungibleHandle<T> {400 /// @notice Enumerate valid RFTs401 /// @param index A counter less than `totalSupply()`402 /// @return The token identifier for the `index`th NFT,403 /// (sort order not specified)404 fn token_by_index(&self, index: U256) -> U256 {405 index406 }407408 /// Not implemented409 fn token_of_owner_by_index(&self, _owner: Address, _index: U256) -> Result<U256> {410 // TODO: Not implemetable411 Err("not implemented".into())412 }413414 /// @notice Count RFTs tracked by this contract415 /// @return A count of valid RFTs tracked by this contract, where each one of416 /// them has an assigned and queryable owner not equal to the zero address417 fn total_supply(&self) -> Result<U256> {418 self.consume_store_reads(1)?;419 Ok(<Pallet<T>>::total_supply(self).into())420 }421}422423/// @title ERC-721 Non-Fungible Token Standard424/// @dev See https://github.com/ethereum/EIPs/blob/master/EIPS/eip-721.md425#[solidity_interface(name = ERC721, events(ERC721Events), enum(derive(PreDispatch)), enum_attr(weight), expect_selector = 0x80ac58cd)]426impl<T: Config> RefungibleHandle<T> {427 /// @notice Count all RFTs assigned to an owner428 /// @dev RFTs assigned to the zero address are considered invalid, and this429 /// function throws for queries about the zero address.430 /// @param owner An address for whom to query the balance431 /// @return The number of RFTs owned by `owner`, possibly zero432 fn balance_of(&self, owner: Address) -> Result<U256> {433 self.consume_store_reads(1)?;434 let owner = T::CrossAccountId::from_eth(owner);435 let balance = <AccountBalance<T>>::get((self.id, owner));436 Ok(balance.into())437 }438439 /// @notice Find the owner of an RFT440 /// @dev RFTs assigned to zero address are considered invalid, and queries441 /// about them do throw.442 /// Returns special 0xffffffffffffffffffffffffffffffffffffffff address for443 /// the tokens that are partially owned.444 /// @param tokenId The identifier for an RFT445 /// @return The address of the owner of the RFT446 fn owner_of(&self, token_id: U256) -> Result<Address> {447 self.consume_store_reads(2)?;448 let token = token_id.try_into()?;449 let owner = <Pallet<T>>::token_owner(self.id, token);450 owner451 .map(|address| *address.as_eth())452 .or_else(|err| match err {453 TokenOwnerError::NotFound => Err(Error::Revert("token not found".into())),454 TokenOwnerError::MultipleOwners => Ok(ADDRESS_FOR_PARTIALLY_OWNED_TOKENS),455 })456 }457458 /// @dev Not implemented459 #[solidity(rename_selector = "safeTransferFrom")]460 fn safe_transfer_from_with_data(461 &mut self,462 _from: Address,463 _to: Address,464 _token_id: U256,465 _data: Bytes,466 ) -> Result<()> {467 // TODO: Not implemetable468 Err("not implemented".into())469 }470471 /// @dev Not implemented472 #[solidity(rename_selector = "safeTransferFrom")]473 fn safe_transfer_from(&mut self, _from: Address, _to: Address, _token_id: U256) -> Result<()> {474 // TODO: Not implemetable475 Err("not implemented".into())476 }477478 /// @notice Transfer ownership of an RFT -- THE CALLER IS RESPONSIBLE479 /// TO CONFIRM THAT `to` IS CAPABLE OF RECEIVING NFTS OR ELSE480 /// THEY MAY BE PERMANENTLY LOST481 /// @dev Throws unless `msg.sender` is the current owner or an authorized482 /// operator for this RFT. Throws if `from` is not the current owner. Throws483 /// if `to` is the zero address. Throws if `tokenId` is not a valid RFT.484 /// Throws if RFT pieces have multiple owners.485 /// @param from The current owner of the NFT486 /// @param to The new owner487 /// @param tokenId The NFT to transfer488 #[weight(<SelfWeightOf<T>>::transfer_from_creating_removing())]489 fn transfer_from(490 &mut self,491 caller: Caller,492 from: Address,493 to: Address,494 token_id: U256,495 ) -> Result<()> {496 let caller = T::CrossAccountId::from_eth(caller);497 let from = T::CrossAccountId::from_eth(from);498 let to = T::CrossAccountId::from_eth(to);499 let token = token_id.try_into()?;500 let budget = self501 .recorder502 .weight_calls_budget(<StructureWeight<T>>::find_parent());503504 let balance = balance(self, token, &from)?;505 ensure_single_owner(self, token, balance)?;506507 <Pallet<T>>::transfer_from(self, &caller, &from, &to, token, balance, &budget)508 .map_err(dispatch_to_evm::<T>)?;509510 Ok(())511 }512513 /// @dev Not implemented514 fn approve(&mut self, _caller: Caller, _approved: Address, _token_id: U256) -> Result<()> {515 Err("not implemented".into())516 }517518 /// @notice Sets or unsets the approval of a given operator.519 /// The `operator` is allowed to transfer all token pieces of the `caller` on their behalf.520 /// @param operator Operator521 /// @param approved Should operator status be granted or revoked?522 #[weight(<SelfWeightOf<T>>::set_allowance_for_all())]523 fn set_approval_for_all(524 &mut self,525 caller: Caller,526 operator: Address,527 approved: bool,528 ) -> Result<()> {529 let caller = T::CrossAccountId::from_eth(caller);530 let operator = T::CrossAccountId::from_eth(operator);531532 <Pallet<T>>::set_allowance_for_all(self, &caller, &operator, approved)533 .map_err(dispatch_to_evm::<T>)?;534 Ok(())535 }536537 /// @dev Not implemented538 fn get_approved(&self, _token_id: U256) -> Result<Address> {539 // TODO: Not implemetable540 Err("not implemented".into())541 }542543 /// @notice Tells whether the given `owner` approves the `operator`.544 #[weight(<SelfWeightOf<T>>::allowance_for_all())]545 fn is_approved_for_all(&self, owner: Address, operator: Address) -> Result<bool> {546 let owner = T::CrossAccountId::from_eth(owner);547 let operator = T::CrossAccountId::from_eth(operator);548549 Ok(<Pallet<T>>::allowance_for_all(self, &owner, &operator))550 }551}552553/// Returns amount of pieces of `token` that `owner` have554pub fn balance<T: Config>(555 collection: &RefungibleHandle<T>,556 token: TokenId,557 owner: &T::CrossAccountId,558) -> Result<u128> {559 collection.consume_store_reads(1)?;560 let balance = <Balance<T>>::get((collection.id, token, &owner));561 Ok(balance)562}563564/// Throws if `owner_balance` is lower than total amount of `token` pieces565pub fn ensure_single_owner<T: Config>(566 collection: &RefungibleHandle<T>,567 token: TokenId,568 owner_balance: u128,569) -> Result<()> {570 collection.consume_store_reads(1)?;571 let total_supply = <TotalSupply<T>>::get((collection.id, token));572573 if owner_balance == 0 {574 return Err(dispatch_to_evm::<T>(575 <CommonError<T>>::MustBeTokenOwner.into(),576 ));577 }578579 if total_supply != owner_balance {580 return Err("token has multiple owners".into());581 }582 Ok(())583}584585/// @title ERC721 Token that can be irreversibly burned (destroyed).586#[solidity_interface(name = ERC721Burnable, enum(derive(PreDispatch)), enum_attr(weight))]587impl<T: Config> RefungibleHandle<T> {588 /// @notice Burns a specific ERC721 token.589 /// @dev Throws unless `msg.sender` is the current RFT owner, or an authorized590 /// operator of the current owner.591 /// @param tokenId The RFT to approve592 #[weight(<SelfWeightOf<T>>::burn_item_fully())]593 fn burn(&mut self, caller: Caller, token_id: U256) -> Result<()> {594 let caller = T::CrossAccountId::from_eth(caller);595 let token = token_id.try_into()?;596597 let balance = balance(self, token, &caller)?;598 ensure_single_owner(self, token, balance)?;599600 <Pallet<T>>::burn(self, &caller, token, balance).map_err(dispatch_to_evm::<T>)?;601 Ok(())602 }603}604605/// @title ERC721 minting logic.606#[solidity_interface(name = ERC721UniqueMintable, enum(derive(PreDispatch)), enum_attr(weight))]607impl<T: Config> RefungibleHandle<T> {608 /// @notice Function to mint a token.609 /// @param to The new owner610 /// @return uint256 The id of the newly minted token611 #[weight(<SelfWeightOf<T>>::create_item())]612 fn mint(&mut self, caller: Caller, to: Address) -> Result<U256> {613 let token_id: U256 = <TokensMinted<T>>::get(self.id)614 .checked_add(1)615 .ok_or("item id overflow")?616 .into();617 self.mint_check_id(caller, to, token_id)?;618 Ok(token_id)619 }620621 /// @notice Function to mint a token.622 /// @dev `tokenId` should be obtained with `nextTokenId` method,623 /// unlike standard, you can't specify it manually624 /// @param to The new owner625 /// @param tokenId ID of the minted RFT626 #[solidity(hide, rename_selector = "mint")]627 #[weight(<SelfWeightOf<T>>::create_item())]628 fn mint_check_id(&mut self, caller: Caller, to: Address, token_id: U256) -> Result<bool> {629 let caller = T::CrossAccountId::from_eth(caller);630 let to = T::CrossAccountId::from_eth(to);631 let token_id: u32 = token_id.try_into()?;632 let budget = self633 .recorder634 .weight_calls_budget(<StructureWeight<T>>::find_parent());635636 if <TokensMinted<T>>::get(self.id)637 .checked_add(1)638 .ok_or("item id overflow")?639 != token_id640 {641 return Err("item id should be next".into());642 }643644 let users = [(to, 1)]645 .into_iter()646 .collect::<BTreeMap<_, _>>()647 .try_into()648 .unwrap();649 <Pallet<T>>::create_item(650 self,651 &caller,652 CreateItemData::<T> {653 users,654 properties: CollectionPropertiesVec::default(),655 },656 &budget,657 )658 .map_err(dispatch_to_evm::<T>)?;659660 Ok(true)661 }662663 /// @notice Function to mint token with the given tokenUri.664 /// @param to The new owner665 /// @param tokenUri Token URI that would be stored in the NFT properties666 /// @return uint256 The id of the newly minted token667 #[solidity(rename_selector = "mintWithTokenURI")]668 #[weight(<SelfWeightOf<T>>::create_item() + <SelfWeightOf<T>>::set_token_properties(1))]669 fn mint_with_token_uri(670 &mut self,671 caller: Caller,672 to: Address,673 token_uri: String,674 ) -> Result<U256> {675 let token_id: U256 = <TokensMinted<T>>::get(self.id)676 .checked_add(1)677 .ok_or("item id overflow")?678 .into();679 self.mint_with_token_uri_check_id(caller, to, token_id, token_uri)?;680 Ok(token_id)681 }682683 /// @notice Function to mint token with the given tokenUri.684 /// @dev `tokenId` should be obtained with `nextTokenId` method,685 /// unlike standard, you can't specify it manually686 /// @param to The new owner687 /// @param tokenId ID of the minted RFT688 /// @param tokenUri Token URI that would be stored in the RFT properties689 #[solidity(hide, rename_selector = "mintWithTokenURI")]690 #[weight(<SelfWeightOf<T>>::create_item() + <SelfWeightOf<T>>::set_token_properties(1))]691 fn mint_with_token_uri_check_id(692 &mut self,693 caller: Caller,694 to: Address,695 token_id: U256,696 token_uri: String,697 ) -> Result<bool> {698 let key = key::url();699 let permission = get_token_permission::<T>(self.id, &key)?;700 if !permission.collection_admin {701 return Err("operation is not allowed".into());702 }703704 let caller = T::CrossAccountId::from_eth(caller);705 let to = T::CrossAccountId::from_eth(to);706 let token_id: u32 = token_id.try_into().map_err(|_| "amount overflow")?;707 let budget = self708 .recorder709 .weight_calls_budget(<StructureWeight<T>>::find_parent());710711 if <TokensMinted<T>>::get(self.id)712 .checked_add(1)713 .ok_or("item id overflow")?714 != token_id715 {716 return Err("item id should be next".into());717 }718719 let mut properties = CollectionPropertiesVec::default();720 properties721 .try_push(Property {722 key,723 value: token_uri724 .into_bytes()725 .try_into()726 .map_err(|_| "token uri is too long")?,727 })728 .map_err(|e| Error::Revert(alloc::format!("can't add property: {e:?}")))?;729730 let users = [(to, 1)]731 .into_iter()732 .collect::<BTreeMap<_, _>>()733 .try_into()734 .unwrap();735 <Pallet<T>>::create_item(736 self,737 &caller,738 CreateItemData::<T> { users, properties },739 &budget,740 )741 .map_err(dispatch_to_evm::<T>)?;742 Ok(true)743 }744}745746fn get_token_property<T: Config>(747 collection: &CollectionHandle<T>,748 token_id: u32,749 key: &up_data_structs::PropertyKey,750) -> Result<String> {751 collection.consume_store_reads(1)?;752 let properties = <TokenProperties<T>>::try_get((collection.id, token_id))753 .map_err(|_| Error::Revert("token properties not found".into()))?;754 if let Some(property) = properties.get(key) {755 return Ok(String::from_utf8_lossy(property).into());756 }757758 Err("property tokenURI not found".into())759}760761fn get_token_permission<T: Config>(762 collection_id: CollectionId,763 key: &PropertyKey,764) -> Result<PropertyPermission> {765 let token_property_permissions = CollectionPropertyPermissions::<T>::try_get(collection_id)766 .map_err(|_| Error::Revert("no permissions for collection".into()))?;767 let a = token_property_permissions768 .get(key)769 .map(Clone::clone)770 .ok_or_else(|| {771 let key = String::from_utf8(key.clone().into_inner()).unwrap_or_default();772 Error::Revert(alloc::format!("no permission for key {key}"))773 })?;774 Ok(a)775}776777/// @title Unique extensions for ERC721.778#[solidity_interface(name = ERC721UniqueExtensions, enum(derive(PreDispatch)), enum_attr(weight))]779impl<T: Config> RefungibleHandle<T>780where781 T::AccountId: From<[u8; 32]> + AsRef<[u8; 32]>,782{783 /// @notice A descriptive name for a collection of NFTs in this contract784 fn name(&self) -> Result<String> {785 Ok(decode_utf16(self.name.iter().copied())786 .map(|r| r.unwrap_or(REPLACEMENT_CHARACTER))787 .collect::<String>())788 }789790 /// @notice An abbreviated name for NFTs in this contract791 fn symbol(&self) -> Result<String> {792 Ok(String::from_utf8_lossy(&self.token_prefix).into())793 }794795 /// @notice A description for the collection.796 fn description(&self) -> Result<String> {797 Ok(decode_utf16(self.description.iter().copied())798 .map(|r| r.unwrap_or(REPLACEMENT_CHARACTER))799 .collect::<String>())800 }801802 /// Returns the owner (in cross format) of the token.803 ///804 /// @param tokenId Id for the token.805 #[solidity(hide)]806 fn cross_owner_of(&self, token_id: U256) -> Result<eth::CrossAddress> {807 Self::owner_of_cross(self, token_id)808 }809810 /// Returns the owner (in cross format) of the token.811 ///812 /// @param tokenId Id for the token.813 fn owner_of_cross(&self, token_id: U256) -> Result<eth::CrossAddress> {814 Self::token_owner(self, token_id.try_into()?)815 .map(|o| eth::CrossAddress::from_sub_cross_account::<T>(&o))816 .or_else(|err| match err {817 TokenOwnerError::NotFound => Err(Error::Revert("token not found".into())),818 TokenOwnerError::MultipleOwners => Ok(eth::CrossAddress::from_eth(819 ADDRESS_FOR_PARTIALLY_OWNED_TOKENS,820 )),821 })822 }823824 /// @notice Count all RFTs assigned to an owner825 /// @param owner An cross address for whom to query the balance826 /// @return The number of RFTs owned by `owner`, possibly zero827 fn balance_of_cross(&self, owner: eth::CrossAddress) -> Result<U256> {828 self.consume_store_reads(1)?;829 let balance = <AccountBalance<T>>::get((self.id, owner.into_sub_cross_account::<T>()?));830 Ok(balance.into())831 }832833 /// Returns the token properties.834 ///835 /// @param tokenId Id for the token.836 /// @param keys Properties keys. Empty keys for all propertyes.837 /// @return Vector of properties key/value pairs.838 fn properties(&self, token_id: U256, keys: Vec<String>) -> Result<Vec<eth::Property>> {839 let keys = keys840 .into_iter()841 .map(|key| {842 <Vec<u8>>::from(key)843 .try_into()844 .map_err(|_| Error::Revert("key too large".into()))845 })846 .collect::<Result<Vec<_>>>()?;847848 <Self as CommonCollectionOperations<T>>::token_properties(849 self,850 token_id.try_into()?,851 if keys.is_empty() { None } else { Some(keys) },852 )853 .into_iter()854 .map(eth::Property::try_from)855 .collect::<Result<Vec<_>>>()856 }857 /// @notice Transfer ownership of an RFT858 /// @dev Throws unless `msg.sender` is the current owner. Throws if `to`859 /// is the zero address. Throws if `tokenId` is not a valid RFT.860 /// Throws if RFT pieces have multiple owners.861 /// @param to The new owner862 /// @param tokenId The RFT to transfer863 #[weight(<SelfWeightOf<T>>::transfer_creating_removing())]864 fn transfer(&mut self, caller: Caller, to: Address, token_id: U256) -> Result<()> {865 let caller = T::CrossAccountId::from_eth(caller);866 let to = T::CrossAccountId::from_eth(to);867 let token = token_id.try_into()?;868 let budget = self869 .recorder870 .weight_calls_budget(<StructureWeight<T>>::find_parent());871872 let balance = balance(self, token, &caller)?;873 ensure_single_owner(self, token, balance)?;874875 <Pallet<T>>::transfer(self, &caller, &to, token, balance, &budget)876 .map_err(dispatch_to_evm::<T>)?;877 Ok(())878 }879880 /// @notice Transfer ownership of an RFT881 /// @dev Throws unless `msg.sender` is the current owner. Throws if `to`882 /// is the zero address. Throws if `tokenId` is not a valid RFT.883 /// Throws if RFT pieces have multiple owners.884 /// @param to The new owner885 /// @param tokenId The RFT to transfer886 #[weight(<SelfWeightOf<T>>::transfer_creating_removing())]887 fn transfer_cross(888 &mut self,889 caller: Caller,890 to: eth::CrossAddress,891 token_id: U256,892 ) -> Result<()> {893 let caller = T::CrossAccountId::from_eth(caller);894 let to = to.into_sub_cross_account::<T>()?;895 let token = token_id.try_into()?;896 let budget = self897 .recorder898 .weight_calls_budget(<StructureWeight<T>>::find_parent());899900 let balance = balance(self, token, &caller)?;901 ensure_single_owner(self, token, balance)?;902903 <Pallet<T>>::transfer(self, &caller, &to, token, balance, &budget)904 .map_err(dispatch_to_evm::<T>)?;905 Ok(())906 }907908 /// @notice Transfer ownership of an RFT909 /// @dev Throws unless `msg.sender` is the current owner. Throws if `to`910 /// is the zero address. Throws if `tokenId` is not a valid RFT.911 /// Throws if RFT pieces have multiple owners.912 /// @param to The new owner913 /// @param tokenId The RFT to transfer914 #[weight(<SelfWeightOf<T>>::transfer_creating_removing())]915 fn transfer_from_cross(916 &mut self,917 caller: Caller,918 from: eth::CrossAddress,919 to: eth::CrossAddress,920 token_id: U256,921 ) -> Result<()> {922 let caller = T::CrossAccountId::from_eth(caller);923 let from = from.into_sub_cross_account::<T>()?;924 let to = to.into_sub_cross_account::<T>()?;925 let token_id = token_id.try_into()?;926 let budget = self927 .recorder928 .weight_calls_budget(<StructureWeight<T>>::find_parent());929930 let balance = balance(self, token_id, &from)?;931 ensure_single_owner(self, token_id, balance)?;932933 Pallet::<T>::transfer_from(self, &caller, &from, &to, token_id, balance, &budget)934 .map_err(dispatch_to_evm::<T>)?;935 Ok(())936 }937938 /// @notice Burns a specific ERC721 token.939 /// @dev Throws unless `msg.sender` is the current owner or an authorized940 /// operator for this RFT. Throws if `from` is not the current owner. Throws941 /// if `to` is the zero address. Throws if `tokenId` is not a valid RFT.942 /// Throws if RFT pieces have multiple owners.943 /// @param from The current owner of the RFT944 /// @param tokenId The RFT to transfer945 #[solidity(hide)]946 #[weight(<SelfWeightOf<T>>::burn_from())]947 fn burn_from(&mut self, caller: Caller, from: Address, token_id: U256) -> Result<()> {948 let caller = T::CrossAccountId::from_eth(caller);949 let from = T::CrossAccountId::from_eth(from);950 let token = token_id.try_into()?;951 let budget = self952 .recorder953 .weight_calls_budget(<StructureWeight<T>>::find_parent());954955 let balance = balance(self, token, &from)?;956 ensure_single_owner(self, token, balance)?;957958 <Pallet<T>>::burn_from(self, &caller, &from, token, balance, &budget)959 .map_err(dispatch_to_evm::<T>)?;960 Ok(())961 }962963 /// @notice Burns a specific ERC721 token.964 /// @dev Throws unless `msg.sender` is the current owner or an authorized965 /// operator for this RFT. Throws if `from` is not the current owner. Throws966 /// if `to` is the zero address. Throws if `tokenId` is not a valid RFT.967 /// Throws if RFT pieces have multiple owners.968 /// @param from The current owner of the RFT969 /// @param tokenId The RFT to transfer970 #[weight(<SelfWeightOf<T>>::burn_from())]971 fn burn_from_cross(972 &mut self,973 caller: Caller,974 from: eth::CrossAddress,975 token_id: U256,976 ) -> Result<()> {977 let caller = T::CrossAccountId::from_eth(caller);978 let from = from.into_sub_cross_account::<T>()?;979 let token = token_id.try_into()?;980 let budget = self981 .recorder982 .weight_calls_budget(<StructureWeight<T>>::find_parent());983984 let balance = balance(self, token, &from)?;985 ensure_single_owner(self, token, balance)?;986987 <Pallet<T>>::burn_from(self, &caller, &from, token, balance, &budget)988 .map_err(dispatch_to_evm::<T>)?;989 Ok(())990 }991992 /// @notice Returns next free RFT ID.993 fn next_token_id(&self) -> Result<U256> {994 self.consume_store_reads(1)?;995 Ok(<Pallet<T>>::next_token_id(self)996 .map_err(dispatch_to_evm::<T>)?997 .into())998 }9991000 /// @notice Function to mint multiple tokens.1001 /// @dev `tokenIds` should be an array of consecutive numbers and first number1002 /// should be obtained with `nextTokenId` method1003 /// @param to The new owner1004 /// @param tokenIds IDs of the minted RFTs1005 #[solidity(hide)]1006 #[weight(<SelfWeightOf<T>>::create_multiple_items(token_ids.len() as u32))]1007 fn mint_bulk(&mut self, caller: Caller, to: Address, token_ids: Vec<U256>) -> Result<bool> {1008 let caller = T::CrossAccountId::from_eth(caller);1009 let to = T::CrossAccountId::from_eth(to);1010 let mut expected_index = <TokensMinted<T>>::get(self.id)1011 .checked_add(1)1012 .ok_or("item id overflow")?;1013 let budget = self1014 .recorder1015 .weight_calls_budget(<StructureWeight<T>>::find_parent());10161017 let total_tokens = token_ids.len();1018 for id in token_ids.into_iter() {1019 let id: u32 = id.try_into().map_err(|_| "token id overflow")?;1020 if id != expected_index {1021 return Err("item id should be next".into());1022 }1023 expected_index = expected_index.checked_add(1).ok_or("item id overflow")?;1024 }1025 let users = [(to, 1)]1026 .into_iter()1027 .collect::<BTreeMap<_, _>>()1028 .try_into()1029 .unwrap();1030 let create_item_data = CreateItemData::<T> {1031 users,1032 properties: CollectionPropertiesVec::default(),1033 };1034 let data = (0..total_tokens)1035 .map(|_| create_item_data.clone())1036 .collect();10371038 <Pallet<T>>::create_multiple_items(self, &caller, data, &budget)1039 .map_err(dispatch_to_evm::<T>)?;1040 Ok(true)1041 }10421043 /// @notice Function to mint a token.1044 /// @param tokenProperties Properties of minted token1045 #[weight(if token_properties.len() == 1 {1046 <SelfWeightOf<T>>::create_multiple_items_ex_multiple_owners(token_properties.iter().next().unwrap().owners.len() as u32)1047 } else {1048 <SelfWeightOf<T>>::create_multiple_items_ex_multiple_items(token_properties.len() as u32)1049 } + <SelfWeightOf<T>>::set_token_properties(token_properties.len() as u32))]1050 fn mint_bulk_cross(1051 &mut self,1052 caller: Caller,1053 token_properties: Vec<MintTokenData>,1054 ) -> Result<bool> {1055 let caller = T::CrossAccountId::from_eth(caller);1056 let budget = self1057 .recorder1058 .weight_calls_budget(<StructureWeight<T>>::find_parent());1059 let has_multiple_tokens = token_properties.len() > 1;10601061 let mut create_rft_data = Vec::with_capacity(token_properties.len());1062 for MintTokenData { owners, properties } in token_properties {1063 let has_multiple_owners = owners.len() > 1;1064 if has_multiple_tokens & has_multiple_owners {1065 return Err(1066 "creation of multiple tokens supported only if they have single owner each"1067 .into(),1068 );1069 }1070 let users: BoundedBTreeMap<_, _, _> = owners1071 .into_iter()1072 .map(|data| Ok((data.owner.into_sub_cross_account::<T>()?, data.pieces)))1073 .collect::<Result<BTreeMap<_, _>>>()?1074 .try_into()1075 .map_err(|_| "too many users")?;1076 create_rft_data.push(CreateItemData::<T> {1077 properties: properties1078 .into_iter()1079 .map(|property| property.try_into())1080 .collect::<Result<Vec<_>>>()?1081 .try_into()1082 .map_err(|_| "too many properties")?,1083 users,1084 });1085 }10861087 <Pallet<T>>::create_multiple_items(self, &caller, create_rft_data, &budget)1088 .map_err(dispatch_to_evm::<T>)?;1089 Ok(true)1090 }10911092 /// @notice Function to mint multiple tokens with the given tokenUris.1093 /// @dev `tokenIds` is array of pairs of token ID and token URI. Token IDs should be consecutive1094 /// numbers and first number should be obtained with `nextTokenId` method1095 /// @param to The new owner1096 /// @param tokens array of pairs of token ID and token URI for minted tokens1097 #[solidity(hide, rename_selector = "mintBulkWithTokenURI")]1098 #[weight(<SelfWeightOf<T>>::create_multiple_items(tokens.len() as u32) + <SelfWeightOf<T>>::set_token_properties(tokens.len() as u32))]1099 fn mint_bulk_with_token_uri(1100 &mut self,1101 caller: Caller,1102 to: Address,1103 tokens: Vec<TokenUri>,1104 ) -> Result<bool> {1105 let key = key::url();1106 let caller = T::CrossAccountId::from_eth(caller);1107 let to = T::CrossAccountId::from_eth(to);1108 let mut expected_index = <TokensMinted<T>>::get(self.id)1109 .checked_add(1)1110 .ok_or("item id overflow")?;1111 let budget = self1112 .recorder1113 .weight_calls_budget(<StructureWeight<T>>::find_parent());11141115 let mut data = Vec::with_capacity(tokens.len());1116 let users: BoundedBTreeMap<_, _, _> = [(to, 1)]1117 .into_iter()1118 .collect::<BTreeMap<_, _>>()1119 .try_into()1120 .unwrap();1121 for TokenUri { id, uri } in tokens {1122 let id: u32 = id.try_into().map_err(|_| "token id overflow")?;1123 if id != expected_index {1124 return Err("item id should be next".into());1125 }1126 expected_index = expected_index.checked_add(1).ok_or("item id overflow")?;11271128 let mut properties = CollectionPropertiesVec::default();1129 properties1130 .try_push(Property {1131 key: key.clone(),1132 value: uri1133 .into_bytes()1134 .try_into()1135 .map_err(|_| "token uri is too long")?,1136 })1137 .map_err(|e| Error::Revert(alloc::format!("can't add property: {e:?}")))?;11381139 let create_item_data = CreateItemData::<T> {1140 users: users.clone(),1141 properties,1142 };1143 data.push(create_item_data);1144 }11451146 <Pallet<T>>::create_multiple_items(self, &caller, data, &budget)1147 .map_err(dispatch_to_evm::<T>)?;1148 Ok(true)1149 }11501151 /// @notice Function to mint a token.1152 /// @param to The new owner crossAccountId1153 /// @param properties Properties of minted token1154 /// @return uint256 The id of the newly minted token1155 #[weight(<SelfWeightOf<T>>::create_item() + <SelfWeightOf<T>>::set_token_properties(properties.len() as u32))]1156 fn mint_cross(1157 &mut self,1158 caller: Caller,1159 to: eth::CrossAddress,1160 properties: Vec<eth::Property>,1161 ) -> Result<U256> {1162 let token_id = <TokensMinted<T>>::get(self.id)1163 .checked_add(1)1164 .ok_or("item id overflow")?;11651166 let to = to.into_sub_cross_account::<T>()?;11671168 let properties = properties1169 .into_iter()1170 .map(eth::Property::try_into)1171 .collect::<Result<Vec<_>>>()?1172 .try_into()1173 .map_err(|_| Error::Revert("too many properties".to_string()))?;11741175 let caller = T::CrossAccountId::from_eth(caller);11761177 let budget = self1178 .recorder1179 .weight_calls_budget(<StructureWeight<T>>::find_parent());11801181 let users = [(to, 1)]1182 .into_iter()1183 .collect::<BTreeMap<_, _>>()1184 .try_into()1185 .unwrap();1186 <Pallet<T>>::create_item(1187 self,1188 &caller,1189 CreateItemData::<T> { users, properties },1190 &budget,1191 )1192 .map_err(dispatch_to_evm::<T>)?;11931194 Ok(token_id.into())1195 }11961197 /// Returns EVM address for refungible token1198 ///1199 /// @param token ID of the token1200 fn token_contract_address(&self, token: U256) -> Result<Address> {1201 Ok(T::EvmTokenAddressMapping::token_to_address(1202 self.id,1203 token.try_into().map_err(|_| "token id overflow")?,1204 ))1205 }12061207 /// @notice Returns collection helper contract address1208 fn collection_helper_address(&self) -> Result<Address> {1209 Ok(T::ContractAddress::get())1210 }1211}12121213#[solidity_interface(1214 name = UniqueRefungible,1215 is(1216 ERC721,1217 ERC721Enumerable,1218 ERC721UniqueExtensions,1219 ERC721UniqueMintable,1220 ERC721Burnable,1221 ERC721Metadata(if(this.flags.erc721metadata)),1222 Collection(via(common_mut returns CollectionHandle<T>)),1223 TokenProperties,1224 ),1225 enum(derive(PreDispatch)),1226)]1227impl<T: Config> RefungibleHandle<T> where T::AccountId: From<[u8; 32]> + AsRef<[u8; 32]> {}12281229// Not a tests, but code generators1230generate_stubgen!(gen_impl, UniqueRefungibleCall<()>, true);1231generate_stubgen!(gen_iface, UniqueRefungibleCall<()>, false);12321233impl<T: Config> CommonEvmHandler for RefungibleHandle<T>1234where1235 T::AccountId: From<[u8; 32]> + AsRef<[u8; 32]>,1236{1237 const CODE: &'static [u8] = include_bytes!("./stubs/UniqueRefungible.raw");1238 fn call(1239 self,1240 handle: &mut impl PrecompileHandle,1241 ) -> Option<pallet_common::erc::PrecompileResult> {1242 call::<T, UniqueRefungibleCall<T>, _, _>(handle, self)1243 }1244}1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617//! # Refungible Pallet EVM API for tokens18//!19//! Provides ERC-721 standart support implementation and EVM API for unique extensions for Refungible Pallet.20//! Method implementations are mostly doing parameter conversion and calling Refungible Pallet methods.2122extern crate alloc;2324use alloc::string::ToString;25use core::{26 char::{decode_utf16, REPLACEMENT_CHARACTER},27 convert::TryInto,28};2930use evm_coder::{abi::AbiType, generate_stubgen, solidity_interface, types::*, AbiCoder, ToLog};31use frame_support::{BoundedBTreeMap, BoundedVec};32use pallet_common::{33 erc::{static_property::key, CollectionCall, CommonEvmHandler},34 eth::{self, TokenUri},35 CollectionHandle, CollectionPropertyPermissions, CommonCollectionOperations, CommonWeightInfo,36 Error as CommonError,37};38use pallet_evm::{account::CrossAccountId, PrecompileHandle};39use pallet_evm_coder_substrate::{40 call, dispatch_to_evm,41 execution::{Error, PreDispatch, Result},42 frontier_contract, SubstrateRecorder,43};44use pallet_structure::{weights::WeightInfo as _, SelfWeightOf as StructureWeight};45use sp_core::{Get, H160, U256};46use sp_std::{collections::btree_map::BTreeMap, vec, vec::Vec};47use up_data_structs::{48 budget::Budget, mapping::TokenAddressMapping, CollectionId, CollectionPropertiesVec, Property,49 PropertyKey, PropertyKeyPermission, PropertyPermission, TokenId, TokenOwnerError,50};5152use crate::{53 common::CommonWeights, weights::WeightInfo, AccountBalance, Balance, Config, CreateItemData,54 Pallet, RefungibleHandle, SelfWeightOf, TokenProperties, TokensMinted, TotalSupply,55};5657frontier_contract! {58 macro_rules! RefungibleHandle_result {...}59 impl<T: Config> Contract for RefungibleHandle<T> {...}60}6162pub const ADDRESS_FOR_PARTIALLY_OWNED_TOKENS: H160 = H160::repeat_byte(0xff);6364/// Rft events.65#[derive(ToLog)]66pub enum ERC721TokenEvent {67 /// The token has been changed.68 TokenChanged {69 /// Token ID.70 #[indexed]71 token_id: U256,72 },73}7475/// Token minting parameters76#[derive(AbiCoder, Default, Debug)]77pub struct OwnerPieces {78 /// Minted token owner79 pub owner: eth::CrossAddress,80 /// Number of token pieces81 pub pieces: u128,82}8384/// Token minting parameters85#[derive(AbiCoder, Default, Debug)]86pub struct MintTokenData {87 /// Minted token owner and number of pieces88 pub owners: Vec<OwnerPieces>,89 /// Minted token properties90 pub properties: Vec<eth::Property>,91}9293pub fn nesting_budget<T: Config>(recorder: &SubstrateRecorder<T>) -> impl Budget + '_ {94 recorder.weight_calls_budget(<StructureWeight<T>>::find_parent())95}9697/// @title A contract that allows to set and delete token properties and change token property permissions.98#[solidity_interface(name = TokenProperties, events(ERC721TokenEvent), enum(derive(PreDispatch)), enum_attr(weight))]99impl<T: Config> RefungibleHandle<T> {100 /// @notice Set permissions for token property.101 /// @dev Throws error if `msg.sender` is not admin or owner of the collection.102 /// @param key Property key.103 /// @param isMutable Permission to mutate property.104 /// @param collectionAdmin Permission to mutate property by collection admin if property is mutable.105 /// @param tokenOwner Permission to mutate property by token owner if property is mutable.106 #[solidity(hide)]107 #[weight(<SelfWeightOf<T>>::set_token_property_permissions(1))]108 fn set_token_property_permission(109 &mut self,110 caller: Caller,111 key: String,112 is_mutable: bool,113 collection_admin: bool,114 token_owner: bool,115 ) -> Result<()> {116 let caller = T::CrossAccountId::from_eth(caller);117 <Pallet<T>>::set_token_property_permissions(118 self,119 &caller,120 vec![PropertyKeyPermission {121 key: <Vec<u8>>::from(key)122 .try_into()123 .map_err(|_| "too long key")?,124 permission: PropertyPermission {125 mutable: is_mutable,126 collection_admin,127 token_owner,128 },129 }],130 )131 .map_err(dispatch_to_evm::<T>)132 }133134 /// @notice Set permissions for token property.135 /// @dev Throws error if `msg.sender` is not admin or owner of the collection.136 /// @param permissions Permissions for keys.137 #[weight(<SelfWeightOf<T>>::set_token_property_permissions(permissions.len() as u32))]138 fn set_token_property_permissions(139 &mut self,140 caller: Caller,141 permissions: Vec<eth::TokenPropertyPermission>,142 ) -> Result<()> {143 let caller = T::CrossAccountId::from_eth(caller);144 let perms = eth::TokenPropertyPermission::into_property_key_permissions(permissions)?;145146 <Pallet<T>>::set_token_property_permissions(self, &caller, perms)147 .map_err(dispatch_to_evm::<T>)148 }149150 /// @notice Get permissions for token properties.151 fn token_property_permissions(&self) -> Result<Vec<eth::TokenPropertyPermission>> {152 let perms = <Pallet<T>>::token_property_permission(self.id);153 Ok(perms154 .into_iter()155 .map(eth::TokenPropertyPermission::from)156 .collect())157 }158159 /// @notice Set token property value.160 /// @dev Throws error if `msg.sender` has no permission to edit the property.161 /// @param tokenId ID of the token.162 /// @param key Property key.163 /// @param value Property value.164 #[solidity(hide)]165 #[weight(<CommonWeights<T>>::set_token_properties(1))]166 fn set_property(167 &mut self,168 caller: Caller,169 token_id: U256,170 key: String,171 value: Bytes,172 ) -> Result<()> {173 let caller = T::CrossAccountId::from_eth(caller);174 let token_id: u32 = token_id.try_into().map_err(|_| "token id overflow")?;175 let key = <Vec<u8>>::from(key)176 .try_into()177 .map_err(|_| "key too long")?;178 let value = value.0.try_into().map_err(|_| "value too long")?;179180 <Pallet<T>>::set_token_property(181 self,182 &caller,183 TokenId(token_id),184 Property { key, value },185 &nesting_budget(&self.recorder),186 )187 .map_err(dispatch_to_evm::<T>)188 }189190 /// @notice Set token properties value.191 /// @dev Throws error if `msg.sender` has no permission to edit the property.192 /// @param tokenId ID of the token.193 /// @param properties settable properties194 #[weight(<CommonWeights<T>>::set_token_properties(properties.len() as u32))]195 fn set_properties(196 &mut self,197 caller: Caller,198 token_id: U256,199 properties: Vec<eth::Property>,200 ) -> Result<()> {201 let caller = T::CrossAccountId::from_eth(caller);202 let token_id: u32 = token_id.try_into().map_err(|_| "token id overflow")?;203204 let properties = properties205 .into_iter()206 .map(eth::Property::try_into)207 .collect::<Result<Vec<_>>>()?;208209 <Pallet<T>>::set_token_properties(210 self,211 &caller,212 TokenId(token_id),213 properties.into_iter(),214 &nesting_budget(&self.recorder),215 )216 .map_err(dispatch_to_evm::<T>)217 }218219 /// @notice Delete token property value.220 /// @dev Throws error if `msg.sender` has no permission to edit the property.221 /// @param tokenId ID of the token.222 /// @param key Property key.223 #[solidity(hide)]224 #[weight(<CommonWeights<T>>::delete_token_properties(1))]225 fn delete_property(&mut self, token_id: U256, caller: Caller, key: String) -> Result<()> {226 let caller = T::CrossAccountId::from_eth(caller);227 let token_id: u32 = token_id.try_into().map_err(|_| "token id overflow")?;228 let key = <Vec<u8>>::from(key)229 .try_into()230 .map_err(|_| "key too long")?;231232 <Pallet<T>>::delete_token_property(233 self,234 &caller,235 TokenId(token_id),236 key,237 &nesting_budget(&self.recorder),238 )239 .map_err(dispatch_to_evm::<T>)240 }241242 /// @notice Delete token properties value.243 /// @dev Throws error if `msg.sender` has no permission to edit the property.244 /// @param tokenId ID of the token.245 /// @param keys Properties key.246 #[weight(<CommonWeights<T>>::delete_token_properties(keys.len() as u32))]247 fn delete_properties(248 &mut self,249 token_id: U256,250 caller: Caller,251 keys: Vec<String>,252 ) -> Result<()> {253 let caller = T::CrossAccountId::from_eth(caller);254 let token_id: u32 = token_id.try_into().map_err(|_| "token id overflow")?;255 let keys = keys256 .into_iter()257 .map(|k| Ok(<Vec<u8>>::from(k).try_into().map_err(|_| "key too long")?))258 .collect::<Result<Vec<_>>>()?;259260 <Pallet<T>>::delete_token_properties(261 self,262 &caller,263 TokenId(token_id),264 keys.into_iter(),265 &nesting_budget(&self.recorder),266 )267 .map_err(dispatch_to_evm::<T>)268 }269270 /// @notice Get token property value.271 /// @dev Throws error if key not found272 /// @param tokenId ID of the token.273 /// @param key Property key.274 /// @return Property value bytes275 fn property(&self, token_id: U256, key: String) -> Result<Bytes> {276 let token_id: u32 = token_id.try_into().map_err(|_| "token id overflow")?;277 let key = <Vec<u8>>::from(key)278 .try_into()279 .map_err(|_| "key too long")?;280281 let props =282 <TokenProperties<T>>::get((self.id, token_id)).ok_or("token properties not found")?;283 let prop = props.get(&key).ok_or("key not found")?;284285 Ok(prop.to_vec().into())286 }287}288289#[derive(ToLog)]290pub enum ERC721Events {291 /// @dev This event emits when NFTs are created (`from` == 0) and destroyed292 /// (`to` == 0). Exception: during contract creation, any number of RFTs293 /// may be created and assigned without emitting Transfer.294 Transfer {295 #[indexed]296 from: Address,297 #[indexed]298 to: Address,299 #[indexed]300 token_id: U256,301 },302 /// @dev Not supported303 Approval {304 #[indexed]305 owner: Address,306 #[indexed]307 approved: Address,308 #[indexed]309 token_id: U256,310 },311 /// @dev Not supported312 #[allow(dead_code)]313 ApprovalForAll {314 #[indexed]315 owner: Address,316 #[indexed]317 operator: Address,318 approved: bool,319 },320}321322/// @title ERC-721 Non-Fungible Token Standard, optional metadata extension323/// @dev See https://eips.ethereum.org/EIPS/eip-721324#[solidity_interface(name = ERC721Metadata, enum(derive(PreDispatch)), expect_selector = 0x5b5e139f)]325impl<T: Config> RefungibleHandle<T>326where327 T::AccountId: From<[u8; 32]> + AsRef<[u8; 32]>,328{329 /// @notice A descriptive name for a collection of NFTs in this contract330 /// @dev real implementation of this function lies in `ERC721UniqueExtensions`331 #[solidity(hide, rename_selector = "name")]332 fn name_proxy(&self) -> Result<String> {333 self.name()334 }335336 /// @notice An abbreviated name for NFTs in this contract337 /// @dev real implementation of this function lies in `ERC721UniqueExtensions`338 #[solidity(hide, rename_selector = "symbol")]339 fn symbol_proxy(&self) -> Result<String> {340 self.symbol()341 }342343 /// @notice A distinct Uniform Resource Identifier (URI) for a given asset.344 ///345 /// @dev If the token has a `url` property and it is not empty, it is returned.346 /// Else If the collection does not have a property with key `schemaName` or its value is not equal to `ERC721Metadata`, it return an error `tokenURI not set`.347 /// If the collection property `baseURI` is empty or absent, return "" (empty string)348 /// otherwise, if token property `suffix` present and is non-empty, return concatenation of baseURI and suffix349 /// otherwise, return concatenation of `baseURI` and stringified token id (decimal stringifying, without paddings).350 ///351 /// @return token's const_metadata352 #[solidity(rename_selector = "tokenURI")]353 fn token_uri(&self, token_id: U256) -> Result<String> {354 let token_id_u32: u32 = token_id.try_into().map_err(|_| "token id overflow")?;355356 match get_token_property(self, token_id_u32, &key::url()).as_deref() {357 Err(_) | Ok("") => (),358 Ok(url) => {359 return Ok(url.into());360 }361 };362363 let base_uri =364 pallet_common::Pallet::<T>::get_collection_property(self.id, &key::base_uri())365 .map(BoundedVec::into_inner)366 .map(String::from_utf8)367 .transpose()368 .map_err(|e| {369 Error::Revert(alloc::format!(370 "can not convert value \"baseURI\" to string with error \"{e}\""371 ))372 })?;373374 let base_uri = match base_uri.as_deref() {375 None | Some("") => {376 return Ok("".into());377 }378 Some(base_uri) => base_uri.into(),379 };380381 Ok(382 match get_token_property(self, token_id_u32, &key::suffix()).as_deref() {383 Err(_) | Ok("") => base_uri,384 Ok(suffix) => base_uri + suffix,385 },386 )387 }388}389390/// @title ERC-721 Non-Fungible Token Standard, optional enumeration extension391/// @dev See https://eips.ethereum.org/EIPS/eip-721392#[solidity_interface(name = ERC721Enumerable, enum(derive(PreDispatch)), expect_selector = 0x780e9d63)]393impl<T: Config> RefungibleHandle<T> {394 /// @notice Enumerate valid RFTs395 /// @param index A counter less than `totalSupply()`396 /// @return The token identifier for the `index`th NFT,397 /// (sort order not specified)398 fn token_by_index(&self, index: U256) -> U256 {399 index400 }401402 /// Not implemented403 fn token_of_owner_by_index(&self, _owner: Address, _index: U256) -> Result<U256> {404 // TODO: Not implemetable405 Err("not implemented".into())406 }407408 /// @notice Count RFTs tracked by this contract409 /// @return A count of valid RFTs tracked by this contract, where each one of410 /// them has an assigned and queryable owner not equal to the zero address411 fn total_supply(&self) -> Result<U256> {412 self.consume_store_reads(1)?;413 Ok(<Pallet<T>>::total_supply(self).into())414 }415}416417/// @title ERC-721 Non-Fungible Token Standard418/// @dev See https://github.com/ethereum/EIPs/blob/master/EIPS/eip-721.md419#[solidity_interface(name = ERC721, events(ERC721Events), enum(derive(PreDispatch)), enum_attr(weight), expect_selector = 0x80ac58cd)]420impl<T: Config> RefungibleHandle<T> {421 /// @notice Count all RFTs assigned to an owner422 /// @dev RFTs assigned to the zero address are considered invalid, and this423 /// function throws for queries about the zero address.424 /// @param owner An address for whom to query the balance425 /// @return The number of RFTs owned by `owner`, possibly zero426 fn balance_of(&self, owner: Address) -> Result<U256> {427 self.consume_store_reads(1)?;428 let owner = T::CrossAccountId::from_eth(owner);429 let balance = <AccountBalance<T>>::get((self.id, owner));430 Ok(balance.into())431 }432433 /// @notice Find the owner of an RFT434 /// @dev RFTs assigned to zero address are considered invalid, and queries435 /// about them do throw.436 /// Returns special 0xffffffffffffffffffffffffffffffffffffffff address for437 /// the tokens that are partially owned.438 /// @param tokenId The identifier for an RFT439 /// @return The address of the owner of the RFT440 fn owner_of(&self, token_id: U256) -> Result<Address> {441 self.consume_store_reads(2)?;442 let token = token_id.try_into()?;443 let owner = <Pallet<T>>::token_owner(self.id, token);444 owner445 .map(|address| *address.as_eth())446 .or_else(|err| match err {447 TokenOwnerError::NotFound => Err(Error::Revert("token not found".into())),448 TokenOwnerError::MultipleOwners => Ok(ADDRESS_FOR_PARTIALLY_OWNED_TOKENS),449 })450 }451452 /// @dev Not implemented453 #[solidity(rename_selector = "safeTransferFrom")]454 fn safe_transfer_from_with_data(455 &mut self,456 _from: Address,457 _to: Address,458 _token_id: U256,459 _data: Bytes,460 ) -> Result<()> {461 // TODO: Not implemetable462 Err("not implemented".into())463 }464465 /// @dev Not implemented466 #[solidity(rename_selector = "safeTransferFrom")]467 fn safe_transfer_from(&mut self, _from: Address, _to: Address, _token_id: U256) -> Result<()> {468 // TODO: Not implemetable469 Err("not implemented".into())470 }471472 /// @notice Transfer ownership of an RFT -- THE CALLER IS RESPONSIBLE473 /// TO CONFIRM THAT `to` IS CAPABLE OF RECEIVING NFTS OR ELSE474 /// THEY MAY BE PERMANENTLY LOST475 /// @dev Throws unless `msg.sender` is the current owner or an authorized476 /// operator for this RFT. Throws if `from` is not the current owner. Throws477 /// if `to` is the zero address. Throws if `tokenId` is not a valid RFT.478 /// Throws if RFT pieces have multiple owners.479 /// @param from The current owner of the NFT480 /// @param to The new owner481 /// @param tokenId The NFT to transfer482 #[weight(<SelfWeightOf<T>>::transfer_from_creating_removing())]483 fn transfer_from(484 &mut self,485 caller: Caller,486 from: Address,487 to: Address,488 token_id: U256,489 ) -> Result<()> {490 let caller = T::CrossAccountId::from_eth(caller);491 let from = T::CrossAccountId::from_eth(from);492 let to = T::CrossAccountId::from_eth(to);493 let token = token_id.try_into()?;494495 let balance = balance(self, token, &from)?;496 ensure_single_owner(self, token, balance)?;497498 <Pallet<T>>::transfer_from(499 self,500 &caller,501 &from,502 &to,503 token,504 balance,505 &nesting_budget(&self.recorder),506 )507 .map_err(dispatch_to_evm::<T>)?;508509 Ok(())510 }511512 /// @dev Not implemented513 fn approve(&mut self, _caller: Caller, _approved: Address, _token_id: U256) -> Result<()> {514 Err("not implemented".into())515 }516517 /// @notice Sets or unsets the approval of a given operator.518 /// The `operator` is allowed to transfer all token pieces of the `caller` on their behalf.519 /// @param operator Operator520 /// @param approved Should operator status be granted or revoked?521 #[weight(<SelfWeightOf<T>>::set_allowance_for_all())]522 fn set_approval_for_all(523 &mut self,524 caller: Caller,525 operator: Address,526 approved: bool,527 ) -> Result<()> {528 let caller = T::CrossAccountId::from_eth(caller);529 let operator = T::CrossAccountId::from_eth(operator);530531 <Pallet<T>>::set_allowance_for_all(self, &caller, &operator, approved)532 .map_err(dispatch_to_evm::<T>)?;533 Ok(())534 }535536 /// @dev Not implemented537 fn get_approved(&self, _token_id: U256) -> Result<Address> {538 // TODO: Not implemetable539 Err("not implemented".into())540 }541542 /// @notice Tells whether the given `owner` approves the `operator`.543 #[weight(<SelfWeightOf<T>>::allowance_for_all())]544 fn is_approved_for_all(&self, owner: Address, operator: Address) -> Result<bool> {545 let owner = T::CrossAccountId::from_eth(owner);546 let operator = T::CrossAccountId::from_eth(operator);547548 Ok(<Pallet<T>>::allowance_for_all(self, &owner, &operator))549 }550}551552/// Returns amount of pieces of `token` that `owner` have553pub fn balance<T: Config>(554 collection: &RefungibleHandle<T>,555 token: TokenId,556 owner: &T::CrossAccountId,557) -> Result<u128> {558 collection.consume_store_reads(1)?;559 let balance = <Balance<T>>::get((collection.id, token, &owner));560 Ok(balance)561}562563/// Throws if `owner_balance` is lower than total amount of `token` pieces564pub fn ensure_single_owner<T: Config>(565 collection: &RefungibleHandle<T>,566 token: TokenId,567 owner_balance: u128,568) -> Result<()> {569 collection.consume_store_reads(1)?;570 let total_supply = <TotalSupply<T>>::get((collection.id, token));571572 if owner_balance == 0 {573 return Err(dispatch_to_evm::<T>(574 <CommonError<T>>::MustBeTokenOwner.into(),575 ));576 }577578 if total_supply != owner_balance {579 return Err("token has multiple owners".into());580 }581 Ok(())582}583584/// @title ERC721 Token that can be irreversibly burned (destroyed).585#[solidity_interface(name = ERC721Burnable, enum(derive(PreDispatch)), enum_attr(weight))]586impl<T: Config> RefungibleHandle<T> {587 /// @notice Burns a specific ERC721 token.588 /// @dev Throws unless `msg.sender` is the current RFT owner, or an authorized589 /// operator of the current owner.590 /// @param tokenId The RFT to approve591 #[weight(<SelfWeightOf<T>>::burn_item_fully())]592 fn burn(&mut self, caller: Caller, token_id: U256) -> Result<()> {593 let caller = T::CrossAccountId::from_eth(caller);594 let token = token_id.try_into()?;595596 let balance = balance(self, token, &caller)?;597 ensure_single_owner(self, token, balance)?;598599 <Pallet<T>>::burn(self, &caller, token, balance).map_err(dispatch_to_evm::<T>)?;600 Ok(())601 }602}603604/// @title ERC721 minting logic.605#[solidity_interface(name = ERC721UniqueMintable, enum(derive(PreDispatch)), enum_attr(weight))]606impl<T: Config> RefungibleHandle<T> {607 /// @notice Function to mint a token.608 /// @param to The new owner609 /// @return uint256 The id of the newly minted token610 #[weight(<SelfWeightOf<T>>::create_item())]611 fn mint(&mut self, caller: Caller, to: Address) -> Result<U256> {612 let token_id: U256 = <TokensMinted<T>>::get(self.id)613 .checked_add(1)614 .ok_or("item id overflow")?615 .into();616 self.mint_check_id(caller, to, token_id)?;617 Ok(token_id)618 }619620 /// @notice Function to mint a token.621 /// @dev `tokenId` should be obtained with `nextTokenId` method,622 /// unlike standard, you can't specify it manually623 /// @param to The new owner624 /// @param tokenId ID of the minted RFT625 #[solidity(hide, rename_selector = "mint")]626 #[weight(<SelfWeightOf<T>>::create_item())]627 fn mint_check_id(&mut self, caller: Caller, to: Address, token_id: U256) -> Result<bool> {628 let caller = T::CrossAccountId::from_eth(caller);629 let to = T::CrossAccountId::from_eth(to);630 let token_id: u32 = token_id.try_into()?;631632 if <TokensMinted<T>>::get(self.id)633 .checked_add(1)634 .ok_or("item id overflow")?635 != token_id636 {637 return Err("item id should be next".into());638 }639640 let users = [(to, 1)]641 .into_iter()642 .collect::<BTreeMap<_, _>>()643 .try_into()644 .unwrap();645 <Pallet<T>>::create_item(646 self,647 &caller,648 CreateItemData::<T> {649 users,650 properties: CollectionPropertiesVec::default(),651 },652 &nesting_budget(&self.recorder),653 )654 .map_err(dispatch_to_evm::<T>)?;655656 Ok(true)657 }658659 /// @notice Function to mint token with the given tokenUri.660 /// @param to The new owner661 /// @param tokenUri Token URI that would be stored in the NFT properties662 /// @return uint256 The id of the newly minted token663 #[solidity(rename_selector = "mintWithTokenURI")]664 #[weight(<SelfWeightOf<T>>::create_item() + <SelfWeightOf<T>>::set_token_properties(1))]665 fn mint_with_token_uri(666 &mut self,667 caller: Caller,668 to: Address,669 token_uri: String,670 ) -> Result<U256> {671 let token_id: U256 = <TokensMinted<T>>::get(self.id)672 .checked_add(1)673 .ok_or("item id overflow")?674 .into();675 self.mint_with_token_uri_check_id(caller, to, token_id, token_uri)?;676 Ok(token_id)677 }678679 /// @notice Function to mint token with the given tokenUri.680 /// @dev `tokenId` should be obtained with `nextTokenId` method,681 /// unlike standard, you can't specify it manually682 /// @param to The new owner683 /// @param tokenId ID of the minted RFT684 /// @param tokenUri Token URI that would be stored in the RFT properties685 #[solidity(hide, rename_selector = "mintWithTokenURI")]686 #[weight(<SelfWeightOf<T>>::create_item() + <SelfWeightOf<T>>::set_token_properties(1))]687 fn mint_with_token_uri_check_id(688 &mut self,689 caller: Caller,690 to: Address,691 token_id: U256,692 token_uri: String,693 ) -> Result<bool> {694 let key = key::url();695 let permission = get_token_permission::<T>(self.id, &key)?;696 if !permission.collection_admin {697 return Err("operation is not allowed".into());698 }699700 let caller = T::CrossAccountId::from_eth(caller);701 let to = T::CrossAccountId::from_eth(to);702 let token_id: u32 = token_id.try_into().map_err(|_| "amount overflow")?;703704 if <TokensMinted<T>>::get(self.id)705 .checked_add(1)706 .ok_or("item id overflow")?707 != token_id708 {709 return Err("item id should be next".into());710 }711712 let mut properties = CollectionPropertiesVec::default();713 properties714 .try_push(Property {715 key,716 value: token_uri717 .into_bytes()718 .try_into()719 .map_err(|_| "token uri is too long")?,720 })721 .map_err(|e| Error::Revert(alloc::format!("can't add property: {e:?}")))?;722723 let users = [(to, 1)]724 .into_iter()725 .collect::<BTreeMap<_, _>>()726 .try_into()727 .unwrap();728 <Pallet<T>>::create_item(729 self,730 &caller,731 CreateItemData::<T> { users, properties },732 &nesting_budget(&self.recorder),733 )734 .map_err(dispatch_to_evm::<T>)?;735 Ok(true)736 }737}738739fn get_token_property<T: Config>(740 collection: &CollectionHandle<T>,741 token_id: u32,742 key: &up_data_structs::PropertyKey,743) -> Result<String> {744 collection.consume_store_reads(1)?;745 let properties = <TokenProperties<T>>::try_get((collection.id, token_id))746 .map_err(|_| Error::Revert("token properties not found".into()))?;747 if let Some(property) = properties.get(key) {748 return Ok(String::from_utf8_lossy(property).into());749 }750751 Err("property tokenURI not found".into())752}753754fn get_token_permission<T: Config>(755 collection_id: CollectionId,756 key: &PropertyKey,757) -> Result<PropertyPermission> {758 let token_property_permissions = CollectionPropertyPermissions::<T>::try_get(collection_id)759 .map_err(|_| Error::Revert("no permissions for collection".into()))?;760 let a = token_property_permissions761 .get(key)762 .map(Clone::clone)763 .ok_or_else(|| {764 let key = String::from_utf8(key.clone().into_inner()).unwrap_or_default();765 Error::Revert(alloc::format!("no permission for key {key}"))766 })?;767 Ok(a)768}769770/// @title Unique extensions for ERC721.771#[solidity_interface(name = ERC721UniqueExtensions, enum(derive(PreDispatch)), enum_attr(weight))]772impl<T: Config> RefungibleHandle<T>773where774 T::AccountId: From<[u8; 32]> + AsRef<[u8; 32]>,775{776 /// @notice A descriptive name for a collection of NFTs in this contract777 fn name(&self) -> Result<String> {778 Ok(decode_utf16(self.name.iter().copied())779 .map(|r| r.unwrap_or(REPLACEMENT_CHARACTER))780 .collect::<String>())781 }782783 /// @notice An abbreviated name for NFTs in this contract784 fn symbol(&self) -> Result<String> {785 Ok(String::from_utf8_lossy(&self.token_prefix).into())786 }787788 /// @notice A description for the collection.789 fn description(&self) -> Result<String> {790 Ok(decode_utf16(self.description.iter().copied())791 .map(|r| r.unwrap_or(REPLACEMENT_CHARACTER))792 .collect::<String>())793 }794795 /// Returns the owner (in cross format) of the token.796 ///797 /// @param tokenId Id for the token.798 #[solidity(hide)]799 fn cross_owner_of(&self, token_id: U256) -> Result<eth::CrossAddress> {800 Self::owner_of_cross(self, token_id)801 }802803 /// Returns the owner (in cross format) of the token.804 ///805 /// @param tokenId Id for the token.806 fn owner_of_cross(&self, token_id: U256) -> Result<eth::CrossAddress> {807 Self::token_owner(self, token_id.try_into()?)808 .map(|o| eth::CrossAddress::from_sub_cross_account::<T>(&o))809 .or_else(|err| match err {810 TokenOwnerError::NotFound => Err(Error::Revert("token not found".into())),811 TokenOwnerError::MultipleOwners => Ok(eth::CrossAddress::from_eth(812 ADDRESS_FOR_PARTIALLY_OWNED_TOKENS,813 )),814 })815 }816817 /// @notice Count all RFTs assigned to an owner818 /// @param owner An cross address for whom to query the balance819 /// @return The number of RFTs owned by `owner`, possibly zero820 fn balance_of_cross(&self, owner: eth::CrossAddress) -> Result<U256> {821 self.consume_store_reads(1)?;822 let balance = <AccountBalance<T>>::get((self.id, owner.into_sub_cross_account::<T>()?));823 Ok(balance.into())824 }825826 /// Returns the token properties.827 ///828 /// @param tokenId Id for the token.829 /// @param keys Properties keys. Empty keys for all propertyes.830 /// @return Vector of properties key/value pairs.831 fn properties(&self, token_id: U256, keys: Vec<String>) -> Result<Vec<eth::Property>> {832 let keys = keys833 .into_iter()834 .map(|key| {835 <Vec<u8>>::from(key)836 .try_into()837 .map_err(|_| Error::Revert("key too large".into()))838 })839 .collect::<Result<Vec<_>>>()?;840841 <Self as CommonCollectionOperations<T>>::token_properties(842 self,843 token_id.try_into()?,844 if keys.is_empty() { None } else { Some(keys) },845 )846 .into_iter()847 .map(eth::Property::try_from)848 .collect::<Result<Vec<_>>>()849 }850 /// @notice Transfer ownership of an RFT851 /// @dev Throws unless `msg.sender` is the current owner. Throws if `to`852 /// is the zero address. Throws if `tokenId` is not a valid RFT.853 /// Throws if RFT pieces have multiple owners.854 /// @param to The new owner855 /// @param tokenId The RFT to transfer856 #[weight(<SelfWeightOf<T>>::transfer_creating_removing())]857 fn transfer(&mut self, caller: Caller, to: Address, token_id: U256) -> Result<()> {858 let caller = T::CrossAccountId::from_eth(caller);859 let to = T::CrossAccountId::from_eth(to);860 let token = token_id.try_into()?;861862 let balance = balance(self, token, &caller)?;863 ensure_single_owner(self, token, balance)?;864865 <Pallet<T>>::transfer(866 self,867 &caller,868 &to,869 token,870 balance,871 &nesting_budget(&self.recorder),872 )873 .map_err(dispatch_to_evm::<T>)?;874 Ok(())875 }876877 /// @notice Transfer ownership of an RFT878 /// @dev Throws unless `msg.sender` is the current owner. Throws if `to`879 /// is the zero address. Throws if `tokenId` is not a valid RFT.880 /// Throws if RFT pieces have multiple owners.881 /// @param to The new owner882 /// @param tokenId The RFT to transfer883 #[weight(<SelfWeightOf<T>>::transfer_creating_removing())]884 fn transfer_cross(885 &mut self,886 caller: Caller,887 to: eth::CrossAddress,888 token_id: U256,889 ) -> Result<()> {890 let caller = T::CrossAccountId::from_eth(caller);891 let to = to.into_sub_cross_account::<T>()?;892 let token = token_id.try_into()?;893894 let balance = balance(self, token, &caller)?;895 ensure_single_owner(self, token, balance)?;896897 <Pallet<T>>::transfer(898 self,899 &caller,900 &to,901 token,902 balance,903 &nesting_budget(&self.recorder),904 )905 .map_err(dispatch_to_evm::<T>)?;906 Ok(())907 }908909 /// @notice Transfer ownership of an RFT910 /// @dev Throws unless `msg.sender` is the current owner. Throws if `to`911 /// is the zero address. Throws if `tokenId` is not a valid RFT.912 /// Throws if RFT pieces have multiple owners.913 /// @param to The new owner914 /// @param tokenId The RFT to transfer915 #[weight(<SelfWeightOf<T>>::transfer_creating_removing())]916 fn transfer_from_cross(917 &mut self,918 caller: Caller,919 from: eth::CrossAddress,920 to: eth::CrossAddress,921 token_id: U256,922 ) -> Result<()> {923 let caller = T::CrossAccountId::from_eth(caller);924 let from = from.into_sub_cross_account::<T>()?;925 let to = to.into_sub_cross_account::<T>()?;926 let token_id = token_id.try_into()?;927928 let balance = balance(self, token_id, &from)?;929 ensure_single_owner(self, token_id, balance)?;930931 Pallet::<T>::transfer_from(932 self,933 &caller,934 &from,935 &to,936 token_id,937 balance,938 &nesting_budget(&self.recorder),939 )940 .map_err(dispatch_to_evm::<T>)?;941 Ok(())942 }943944 /// @notice Burns a specific ERC721 token.945 /// @dev Throws unless `msg.sender` is the current owner or an authorized946 /// operator for this RFT. Throws if `from` is not the current owner. Throws947 /// if `to` is the zero address. Throws if `tokenId` is not a valid RFT.948 /// Throws if RFT pieces have multiple owners.949 /// @param from The current owner of the RFT950 /// @param tokenId The RFT to transfer951 #[solidity(hide)]952 #[weight(<SelfWeightOf<T>>::burn_from())]953 fn burn_from(&mut self, caller: Caller, from: Address, token_id: U256) -> Result<()> {954 let caller = T::CrossAccountId::from_eth(caller);955 let from = T::CrossAccountId::from_eth(from);956 let token = token_id.try_into()?;957958 let balance = balance(self, token, &from)?;959 ensure_single_owner(self, token, balance)?;960961 <Pallet<T>>::burn_from(962 self,963 &caller,964 &from,965 token,966 balance,967 &nesting_budget(&self.recorder),968 )969 .map_err(dispatch_to_evm::<T>)?;970 Ok(())971 }972973 /// @notice Burns a specific ERC721 token.974 /// @dev Throws unless `msg.sender` is the current owner or an authorized975 /// operator for this RFT. Throws if `from` is not the current owner. Throws976 /// if `to` is the zero address. Throws if `tokenId` is not a valid RFT.977 /// Throws if RFT pieces have multiple owners.978 /// @param from The current owner of the RFT979 /// @param tokenId The RFT to transfer980 #[weight(<SelfWeightOf<T>>::burn_from())]981 fn burn_from_cross(982 &mut self,983 caller: Caller,984 from: eth::CrossAddress,985 token_id: U256,986 ) -> Result<()> {987 let caller = T::CrossAccountId::from_eth(caller);988 let from = from.into_sub_cross_account::<T>()?;989 let token = token_id.try_into()?;990991 let balance = balance(self, token, &from)?;992 ensure_single_owner(self, token, balance)?;993994 <Pallet<T>>::burn_from(995 self,996 &caller,997 &from,998 token,999 balance,1000 &nesting_budget(&self.recorder),1001 )1002 .map_err(dispatch_to_evm::<T>)?;1003 Ok(())1004 }10051006 /// @notice Returns next free RFT ID.1007 fn next_token_id(&self) -> Result<U256> {1008 self.consume_store_reads(1)?;1009 Ok(<Pallet<T>>::next_token_id(self)1010 .map_err(dispatch_to_evm::<T>)?1011 .into())1012 }10131014 /// @notice Function to mint multiple tokens.1015 /// @dev `tokenIds` should be an array of consecutive numbers and first number1016 /// should be obtained with `nextTokenId` method1017 /// @param to The new owner1018 /// @param tokenIds IDs of the minted RFTs1019 #[solidity(hide)]1020 #[weight(<SelfWeightOf<T>>::create_multiple_items(token_ids.len() as u32))]1021 fn mint_bulk(&mut self, caller: Caller, to: Address, token_ids: Vec<U256>) -> Result<bool> {1022 let caller = T::CrossAccountId::from_eth(caller);1023 let to = T::CrossAccountId::from_eth(to);1024 let mut expected_index = <TokensMinted<T>>::get(self.id)1025 .checked_add(1)1026 .ok_or("item id overflow")?;10271028 let total_tokens = token_ids.len();1029 for id in token_ids.into_iter() {1030 let id: u32 = id.try_into().map_err(|_| "token id overflow")?;1031 if id != expected_index {1032 return Err("item id should be next".into());1033 }1034 expected_index = expected_index.checked_add(1).ok_or("item id overflow")?;1035 }1036 let users = [(to, 1)]1037 .into_iter()1038 .collect::<BTreeMap<_, _>>()1039 .try_into()1040 .unwrap();1041 let create_item_data = CreateItemData::<T> {1042 users,1043 properties: CollectionPropertiesVec::default(),1044 };1045 let data = (0..total_tokens)1046 .map(|_| create_item_data.clone())1047 .collect();10481049 <Pallet<T>>::create_multiple_items(self, &caller, data, &nesting_budget(&self.recorder))1050 .map_err(dispatch_to_evm::<T>)?;1051 Ok(true)1052 }10531054 /// @notice Function to mint a token.1055 /// @param tokenProperties Properties of minted token1056 #[weight(if token_properties.len() == 1 {1057 <SelfWeightOf<T>>::create_multiple_items_ex_multiple_owners(token_properties.iter().next().unwrap().owners.len() as u32)1058 } else {1059 <SelfWeightOf<T>>::create_multiple_items_ex_multiple_items(token_properties.len() as u32)1060 } + <SelfWeightOf<T>>::set_token_properties(token_properties.len() as u32))]1061 fn mint_bulk_cross(1062 &mut self,1063 caller: Caller,1064 token_properties: Vec<MintTokenData>,1065 ) -> Result<bool> {1066 let caller = T::CrossAccountId::from_eth(caller);1067 let has_multiple_tokens = token_properties.len() > 1;10681069 let mut create_rft_data = Vec::with_capacity(token_properties.len());1070 for MintTokenData { owners, properties } in token_properties {1071 let has_multiple_owners = owners.len() > 1;1072 if has_multiple_tokens & has_multiple_owners {1073 return Err(1074 "creation of multiple tokens supported only if they have single owner each"1075 .into(),1076 );1077 }1078 let users: BoundedBTreeMap<_, _, _> = owners1079 .into_iter()1080 .map(|data| Ok((data.owner.into_sub_cross_account::<T>()?, data.pieces)))1081 .collect::<Result<BTreeMap<_, _>>>()?1082 .try_into()1083 .map_err(|_| "too many users")?;1084 create_rft_data.push(CreateItemData::<T> {1085 properties: properties1086 .into_iter()1087 .map(|property| property.try_into())1088 .collect::<Result<Vec<_>>>()?1089 .try_into()1090 .map_err(|_| "too many properties")?,1091 users,1092 });1093 }10941095 <Pallet<T>>::create_multiple_items(1096 self,1097 &caller,1098 create_rft_data,1099 &nesting_budget(&self.recorder),1100 )1101 .map_err(dispatch_to_evm::<T>)?;1102 Ok(true)1103 }11041105 /// @notice Function to mint multiple tokens with the given tokenUris.1106 /// @dev `tokenIds` is array of pairs of token ID and token URI. Token IDs should be consecutive1107 /// numbers and first number should be obtained with `nextTokenId` method1108 /// @param to The new owner1109 /// @param tokens array of pairs of token ID and token URI for minted tokens1110 #[solidity(hide, rename_selector = "mintBulkWithTokenURI")]1111 #[weight(<SelfWeightOf<T>>::create_multiple_items(tokens.len() as u32) + <SelfWeightOf<T>>::set_token_properties(tokens.len() as u32))]1112 fn mint_bulk_with_token_uri(1113 &mut self,1114 caller: Caller,1115 to: Address,1116 tokens: Vec<TokenUri>,1117 ) -> Result<bool> {1118 let key = key::url();1119 let caller = T::CrossAccountId::from_eth(caller);1120 let to = T::CrossAccountId::from_eth(to);1121 let mut expected_index = <TokensMinted<T>>::get(self.id)1122 .checked_add(1)1123 .ok_or("item id overflow")?;11241125 let mut data = Vec::with_capacity(tokens.len());1126 let users: BoundedBTreeMap<_, _, _> = [(to, 1)]1127 .into_iter()1128 .collect::<BTreeMap<_, _>>()1129 .try_into()1130 .unwrap();1131 for TokenUri { id, uri } in tokens {1132 let id: u32 = id.try_into().map_err(|_| "token id overflow")?;1133 if id != expected_index {1134 return Err("item id should be next".into());1135 }1136 expected_index = expected_index.checked_add(1).ok_or("item id overflow")?;11371138 let mut properties = CollectionPropertiesVec::default();1139 properties1140 .try_push(Property {1141 key: key.clone(),1142 value: uri1143 .into_bytes()1144 .try_into()1145 .map_err(|_| "token uri is too long")?,1146 })1147 .map_err(|e| Error::Revert(alloc::format!("can't add property: {e:?}")))?;11481149 let create_item_data = CreateItemData::<T> {1150 users: users.clone(),1151 properties,1152 };1153 data.push(create_item_data);1154 }11551156 <Pallet<T>>::create_multiple_items(self, &caller, data, &nesting_budget(&self.recorder))1157 .map_err(dispatch_to_evm::<T>)?;1158 Ok(true)1159 }11601161 /// @notice Function to mint a token.1162 /// @param to The new owner crossAccountId1163 /// @param properties Properties of minted token1164 /// @return uint256 The id of the newly minted token1165 #[weight(<SelfWeightOf<T>>::create_item() + <SelfWeightOf<T>>::set_token_properties(properties.len() as u32))]1166 fn mint_cross(1167 &mut self,1168 caller: Caller,1169 to: eth::CrossAddress,1170 properties: Vec<eth::Property>,1171 ) -> Result<U256> {1172 let token_id = <TokensMinted<T>>::get(self.id)1173 .checked_add(1)1174 .ok_or("item id overflow")?;11751176 let to = to.into_sub_cross_account::<T>()?;11771178 let properties = properties1179 .into_iter()1180 .map(eth::Property::try_into)1181 .collect::<Result<Vec<_>>>()?1182 .try_into()1183 .map_err(|_| Error::Revert("too many properties".to_string()))?;11841185 let caller = T::CrossAccountId::from_eth(caller);11861187 let users = [(to, 1)]1188 .into_iter()1189 .collect::<BTreeMap<_, _>>()1190 .try_into()1191 .unwrap();1192 <Pallet<T>>::create_item(1193 self,1194 &caller,1195 CreateItemData::<T> { users, properties },1196 &nesting_budget(&self.recorder),1197 )1198 .map_err(dispatch_to_evm::<T>)?;11991200 Ok(token_id.into())1201 }12021203 /// Returns EVM address for refungible token1204 ///1205 /// @param token ID of the token1206 fn token_contract_address(&self, token: U256) -> Result<Address> {1207 Ok(T::EvmTokenAddressMapping::token_to_address(1208 self.id,1209 token.try_into().map_err(|_| "token id overflow")?,1210 ))1211 }12121213 /// @notice Returns collection helper contract address1214 fn collection_helper_address(&self) -> Result<Address> {1215 Ok(T::ContractAddress::get())1216 }1217}12181219#[solidity_interface(1220 name = UniqueRefungible,1221 is(1222 ERC721,1223 ERC721Enumerable,1224 ERC721UniqueExtensions,1225 ERC721UniqueMintable,1226 ERC721Burnable,1227 ERC721Metadata(if(this.flags.erc721metadata)),1228 Collection(via(common_mut returns CollectionHandle<T>)),1229 TokenProperties,1230 ),1231 enum(derive(PreDispatch)),1232)]1233impl<T: Config> RefungibleHandle<T> where T::AccountId: From<[u8; 32]> + AsRef<[u8; 32]> {}12341235// Not a tests, but code generators1236generate_stubgen!(gen_impl, UniqueRefungibleCall<()>, true);1237generate_stubgen!(gen_iface, UniqueRefungibleCall<()>, false);12381239impl<T: Config> CommonEvmHandler for RefungibleHandle<T>1240where1241 T::AccountId: From<[u8; 32]> + AsRef<[u8; 32]>,1242{1243 const CODE: &'static [u8] = include_bytes!("./stubs/UniqueRefungible.raw");1244 fn call(1245 self,1246 handle: &mut impl PrecompileHandle,1247 ) -> Option<pallet_common::erc::PrecompileResult> {1248 call::<T, UniqueRefungibleCall<T>, _, _>(handle, self)1249 }1250}pallets/refungible/src/erc_token.rsdiffbeforeafterboth--- a/pallets/refungible/src/erc_token.rs
+++ b/pallets/refungible/src/erc_token.rs
@@ -37,14 +37,13 @@
execution::{PreDispatch, Result},
frontier_contract, WithRecorder,
};
-use pallet_structure::{weights::WeightInfo as _, SelfWeightOf as StructureWeight};
use sp_core::U256;
use sp_std::vec::Vec;
use up_data_structs::TokenId;
use crate::{
- common::CommonWeights, weights::WeightInfo, Allowance, Balance, Config, Pallet,
- RefungibleHandle, SelfWeightOf, TotalSupply,
+ common::CommonWeights, erc::nesting_budget, weights::WeightInfo, Allowance, Balance, Config,
+ Pallet, RefungibleHandle, SelfWeightOf, TotalSupply,
};
/// Refungible token handle contains information about token's collection and id
@@ -140,12 +139,16 @@
let caller = T::CrossAccountId::from_eth(caller);
let to = T::CrossAccountId::from_eth(to);
let amount = amount.try_into().map_err(|_| "amount overflow")?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::transfer(self, &caller, &to, self.1, amount, &budget)
- .map_err(dispatch_to_evm::<T>)?;
+ <Pallet<T>>::transfer(
+ self,
+ &caller,
+ &to,
+ self.1,
+ amount,
+ &nesting_budget(&self.recorder),
+ )
+ .map_err(dispatch_to_evm::<T>)?;
Ok(true)
}
@@ -165,12 +168,17 @@
let from = T::CrossAccountId::from_eth(from);
let to = T::CrossAccountId::from_eth(to);
let amount = amount.try_into().map_err(|_| "amount overflow")?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::transfer_from(self, &caller, &from, &to, self.1, amount, &budget)
- .map_err(dispatch_to_evm::<T>)?;
+ <Pallet<T>>::transfer_from(
+ self,
+ &caller,
+ &from,
+ &to,
+ self.1,
+ amount,
+ &nesting_budget(&self.recorder),
+ )
+ .map_err(dispatch_to_evm::<T>)?;
Ok(true)
}
@@ -231,12 +239,16 @@
let caller = T::CrossAccountId::from_eth(caller);
let from = T::CrossAccountId::from_eth(from);
let amount = amount.try_into().map_err(|_| "amount overflow")?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::burn_from(self, &caller, &from, self.1, amount, &budget)
- .map_err(dispatch_to_evm::<T>)?;
+ <Pallet<T>>::burn_from(
+ self,
+ &caller,
+ &from,
+ self.1,
+ amount,
+ &nesting_budget(&self.recorder),
+ )
+ .map_err(dispatch_to_evm::<T>)?;
Ok(true)
}
@@ -254,12 +266,16 @@
let caller = T::CrossAccountId::from_eth(caller);
let from = from.into_sub_cross_account::<T>()?;
let amount = amount.try_into().map_err(|_| "amount overflow")?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::burn_from(self, &caller, &from, self.1, amount, &budget)
- .map_err(dispatch_to_evm::<T>)?;
+ <Pallet<T>>::burn_from(
+ self,
+ &caller,
+ &from,
+ self.1,
+ amount,
+ &nesting_budget(&self.recorder),
+ )
+ .map_err(dispatch_to_evm::<T>)?;
Ok(true)
}
@@ -315,12 +331,16 @@
let caller = T::CrossAccountId::from_eth(caller);
let to = to.into_sub_cross_account::<T>()?;
let amount = amount.try_into().map_err(|_| "amount overflow")?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::transfer(self, &caller, &to, self.1, amount, &budget)
- .map_err(dispatch_to_evm::<T>)?;
+ <Pallet<T>>::transfer(
+ self,
+ &caller,
+ &to,
+ self.1,
+ amount,
+ &nesting_budget(&self.recorder),
+ )
+ .map_err(dispatch_to_evm::<T>)?;
Ok(true)
}
@@ -340,12 +360,17 @@
let from = from.into_sub_cross_account::<T>()?;
let to = to.into_sub_cross_account::<T>()?;
let amount = amount.try_into().map_err(|_| "amount overflow")?;
- let budget = self
- .recorder
- .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::transfer_from(self, &caller, &from, &to, self.1, amount, &budget)
- .map_err(dispatch_to_evm::<T>)?;
+ <Pallet<T>>::transfer_from(
+ self,
+ &caller,
+ &from,
+ &to,
+ self.1,
+ amount,
+ &nesting_budget(&self.recorder),
+ )
+ .map_err(dispatch_to_evm::<T>)?;
Ok(true)
}
}
pallets/refungible/src/lib.rsdiffbeforeafterboth--- a/pallets/refungible/src/lib.rs
+++ b/pallets/refungible/src/lib.rs
@@ -507,7 +507,7 @@
nesting_budget: &dyn Budget,
) -> DispatchResult {
let mut property_writer =
- pallet_common::property_writer_for_existing_token(collection, sender);
+ pallet_common::ExistingTokenPropertyWriter::new(collection, sender);
property_writer.write_token_properties(
sender,
@@ -858,7 +858,7 @@
// =========
- let mut property_writer = pallet_common::property_writer_for_new_token(collection, sender);
+ let mut property_writer = pallet_common::NewTokenPropertyWriter::new(collection, sender);
with_transaction(|| {
for (i, data) in data.iter().enumerate() {
pallets/refungible/src/weights.rsdiffbeforeafterboth--- a/pallets/refungible/src/weights.rs
+++ b/pallets/refungible/src/weights.rs
@@ -3,9 +3,9 @@
//! Autogenerated weights for pallet_refungible
//!
//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev
-//! DATE: 2023-09-30, STEPS: `50`, REPEAT: `400`, LOW RANGE: `[]`, HIGH RANGE: `[]`
+//! DATE: 2023-10-05, STEPS: `50`, REPEAT: `80`, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! WORST CASE MAP SIZE: `1000000`
-//! HOSTNAME: `bench-host`, CPU: `Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz`
+//! HOSTNAME: `hearthstone`, CPU: `AMD Ryzen 9 7950X3D 16-Core Processor`
//! EXECUTION: None, WASM-EXECUTION: Compiled, CHAIN: None, DB CACHE: 1024
// Executed Command:
@@ -20,7 +20,7 @@
// *
// --template=.maintain/frame-weight-template.hbs
// --steps=50
-// --repeat=400
+// --repeat=80
// --heap-pages=4096
// --output=./pallets/refungible/src/weights.rs
@@ -52,7 +52,8 @@
fn burn_from() -> Weight;
fn set_token_property_permissions(b: u32, ) -> Weight;
fn set_token_properties(b: u32, ) -> Weight;
- fn init_token_properties(b: u32, ) -> Weight;
+ fn load_token_properties() -> Weight;
+ fn write_token_properties(b: u32, ) -> Weight;
fn delete_token_properties(b: u32, ) -> Weight;
fn repartition_item() -> Weight;
fn token_owner() -> Weight;
@@ -78,8 +79,8 @@
// Proof Size summary in bytes:
// Measured: `4`
// Estimated: `3530`
- // Minimum execution time: 11_341_000 picoseconds.
- Weight::from_parts(11_741_000, 3530)
+ // Minimum execution time: 5_710_000 picoseconds.
+ Weight::from_parts(5_980_000, 3530)
.saturating_add(T::DbWeight::get().reads(2_u64))
.saturating_add(T::DbWeight::get().writes(5_u64))
}
@@ -98,10 +99,10 @@
// Proof Size summary in bytes:
// Measured: `4`
// Estimated: `3530`
- // Minimum execution time: 2_665_000 picoseconds.
- Weight::from_parts(2_791_000, 3530)
- // Standard Error: 996
- .saturating_add(Weight::from_parts(4_343_736, 0).saturating_mul(b.into()))
+ // Minimum execution time: 1_300_000 picoseconds.
+ Weight::from_parts(1_360_000, 3530)
+ // Standard Error: 2_783
+ .saturating_add(Weight::from_parts(3_456_531, 0).saturating_mul(b.into()))
.saturating_add(T::DbWeight::get().reads(2_u64))
.saturating_add(T::DbWeight::get().writes(2_u64))
.saturating_add(T::DbWeight::get().writes((3_u64).saturating_mul(b.into())))
@@ -121,10 +122,10 @@
// Proof Size summary in bytes:
// Measured: `4`
// Estimated: `3481 + b * (2540 ±0)`
- // Minimum execution time: 2_616_000 picoseconds.
- Weight::from_parts(2_726_000, 3481)
- // Standard Error: 665
- .saturating_add(Weight::from_parts(5_554_066, 0).saturating_mul(b.into()))
+ // Minimum execution time: 1_290_000 picoseconds.
+ Weight::from_parts(1_370_000, 3481)
+ // Standard Error: 3_198
+ .saturating_add(Weight::from_parts(4_435_305, 0).saturating_mul(b.into()))
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().reads((1_u64).saturating_mul(b.into())))
.saturating_add(T::DbWeight::get().writes(1_u64))
@@ -146,10 +147,10 @@
// Proof Size summary in bytes:
// Measured: `4`
// Estimated: `3481 + b * (2540 ±0)`
- // Minimum execution time: 3_697_000 picoseconds.
- Weight::from_parts(2_136_481, 3481)
- // Standard Error: 567
- .saturating_add(Weight::from_parts(4_390_621, 0).saturating_mul(b.into()))
+ // Minimum execution time: 1_730_000 picoseconds.
+ Weight::from_parts(1_810_000, 3481)
+ // Standard Error: 1_923
+ .saturating_add(Weight::from_parts(3_500_817, 0).saturating_mul(b.into()))
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().reads((1_u64).saturating_mul(b.into())))
.saturating_add(T::DbWeight::get().writes(2_u64))
@@ -168,8 +169,8 @@
// Proof Size summary in bytes:
// Measured: `456`
// Estimated: `8682`
- // Minimum execution time: 22_859_000 picoseconds.
- Weight::from_parts(23_295_000, 8682)
+ // Minimum execution time: 14_010_000 picoseconds.
+ Weight::from_parts(16_300_000, 8682)
.saturating_add(T::DbWeight::get().reads(5_u64))
.saturating_add(T::DbWeight::get().writes(4_u64))
}
@@ -189,8 +190,8 @@
// Proof Size summary in bytes:
// Measured: `341`
// Estimated: `3554`
- // Minimum execution time: 21_477_000 picoseconds.
- Weight::from_parts(22_037_000, 3554)
+ // Minimum execution time: 13_700_000 picoseconds.
+ Weight::from_parts(14_180_000, 3554)
.saturating_add(T::DbWeight::get().reads(4_u64))
.saturating_add(T::DbWeight::get().writes(6_u64))
}
@@ -202,8 +203,8 @@
// Proof Size summary in bytes:
// Measured: `365`
// Estimated: `6118`
- // Minimum execution time: 13_714_000 picoseconds.
- Weight::from_parts(14_050_000, 6118)
+ // Minimum execution time: 8_990_000 picoseconds.
+ Weight::from_parts(9_400_000, 6118)
.saturating_add(T::DbWeight::get().reads(3_u64))
.saturating_add(T::DbWeight::get().writes(2_u64))
}
@@ -219,8 +220,8 @@
// Proof Size summary in bytes:
// Measured: `341`
// Estimated: `6118`
- // Minimum execution time: 15_879_000 picoseconds.
- Weight::from_parts(16_266_000, 6118)
+ // Minimum execution time: 10_240_000 picoseconds.
+ Weight::from_parts(10_610_000, 6118)
.saturating_add(T::DbWeight::get().reads(4_u64))
.saturating_add(T::DbWeight::get().writes(4_u64))
}
@@ -236,8 +237,8 @@
// Proof Size summary in bytes:
// Measured: `456`
// Estimated: `6118`
- // Minimum execution time: 18_186_000 picoseconds.
- Weight::from_parts(18_682_000, 6118)
+ // Minimum execution time: 12_040_000 picoseconds.
+ Weight::from_parts(12_390_000, 6118)
.saturating_add(T::DbWeight::get().reads(4_u64))
.saturating_add(T::DbWeight::get().writes(4_u64))
}
@@ -253,8 +254,8 @@
// Proof Size summary in bytes:
// Measured: `341`
// Estimated: `6118`
- // Minimum execution time: 17_943_000 picoseconds.
- Weight::from_parts(18_333_000, 6118)
+ // Minimum execution time: 11_940_000 picoseconds.
+ Weight::from_parts(12_240_000, 6118)
.saturating_add(T::DbWeight::get().reads(5_u64))
.saturating_add(T::DbWeight::get().writes(6_u64))
}
@@ -266,8 +267,8 @@
// Proof Size summary in bytes:
// Measured: `223`
// Estimated: `3554`
- // Minimum execution time: 8_391_000 picoseconds.
- Weight::from_parts(8_637_000, 3554)
+ // Minimum execution time: 5_150_000 picoseconds.
+ Weight::from_parts(5_440_000, 3554)
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -279,8 +280,8 @@
// Proof Size summary in bytes:
// Measured: `211`
// Estimated: `3554`
- // Minimum execution time: 8_519_000 picoseconds.
- Weight::from_parts(8_760_000, 3554)
+ // Minimum execution time: 5_170_000 picoseconds.
+ Weight::from_parts(5_400_000, 3554)
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -294,8 +295,8 @@
// Proof Size summary in bytes:
// Measured: `495`
// Estimated: `6118`
- // Minimum execution time: 19_554_000 picoseconds.
- Weight::from_parts(20_031_000, 6118)
+ // Minimum execution time: 13_150_000 picoseconds.
+ Weight::from_parts(13_600_000, 6118)
.saturating_add(T::DbWeight::get().reads(4_u64))
.saturating_add(T::DbWeight::get().writes(3_u64))
}
@@ -313,8 +314,8 @@
// Proof Size summary in bytes:
// Measured: `471`
// Estimated: `6118`
- // Minimum execution time: 21_338_000 picoseconds.
- Weight::from_parts(21_803_000, 6118)
+ // Minimum execution time: 14_280_000 picoseconds.
+ Weight::from_parts(14_680_000, 6118)
.saturating_add(T::DbWeight::get().reads(5_u64))
.saturating_add(T::DbWeight::get().writes(5_u64))
}
@@ -332,8 +333,8 @@
// Proof Size summary in bytes:
// Measured: `586`
// Estimated: `6118`
- // Minimum execution time: 24_179_000 picoseconds.
- Weight::from_parts(24_647_000, 6118)
+ // Minimum execution time: 16_110_000 picoseconds.
+ Weight::from_parts(16_710_000, 6118)
.saturating_add(T::DbWeight::get().reads(5_u64))
.saturating_add(T::DbWeight::get().writes(5_u64))
}
@@ -351,8 +352,8 @@
// Proof Size summary in bytes:
// Measured: `471`
// Estimated: `6118`
- // Minimum execution time: 24_008_000 picoseconds.
- Weight::from_parts(24_545_000, 6118)
+ // Minimum execution time: 16_130_000 picoseconds.
+ Weight::from_parts(16_680_000, 6118)
.saturating_add(T::DbWeight::get().reads(6_u64))
.saturating_add(T::DbWeight::get().writes(7_u64))
}
@@ -374,8 +375,8 @@
// Proof Size summary in bytes:
// Measured: `471`
// Estimated: `3570`
- // Minimum execution time: 27_907_000 picoseconds.
- Weight::from_parts(28_489_000, 3570)
+ // Minimum execution time: 18_380_000 picoseconds.
+ Weight::from_parts(18_870_000, 3570)
.saturating_add(T::DbWeight::get().reads(5_u64))
.saturating_add(T::DbWeight::get().writes(7_u64))
}
@@ -386,10 +387,10 @@
// Proof Size summary in bytes:
// Measured: `314`
// Estimated: `20191`
- // Minimum execution time: 1_460_000 picoseconds.
- Weight::from_parts(1_564_000, 20191)
- // Standard Error: 14_117
- .saturating_add(Weight::from_parts(8_196_214, 0).saturating_mul(b.into()))
+ // Minimum execution time: 580_000 picoseconds.
+ Weight::from_parts(660_000, 20191)
+ // Standard Error: 29_964
+ .saturating_add(Weight::from_parts(6_251_766, 0).saturating_mul(b.into()))
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -404,24 +405,34 @@
// Proof Size summary in bytes:
// Measured: `502 + b * (261 ±0)`
// Estimated: `36269`
- // Minimum execution time: 1_012_000 picoseconds.
- Weight::from_parts(1_081_000, 36269)
- // Standard Error: 6_838
- .saturating_add(Weight::from_parts(5_801_181, 0).saturating_mul(b.into()))
+ // Minimum execution time: 350_000 picoseconds.
+ Weight::from_parts(2_269_806, 36269)
+ // Standard Error: 7_751
+ .saturating_add(Weight::from_parts(3_068_126, 0).saturating_mul(b.into()))
.saturating_add(T::DbWeight::get().reads(3_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
+ /// Storage: Refungible TokenProperties (r:1 w:0)
+ /// Proof: Refungible TokenProperties (max_values: None, max_size: Some(32804), added: 35279, mode: MaxEncodedLen)
+ fn load_token_properties() -> Weight {
+ // Proof Size summary in bytes:
+ // Measured: `120`
+ // Estimated: `36269`
+ // Minimum execution time: 1_010_000 picoseconds.
+ Weight::from_parts(1_080_000, 36269)
+ .saturating_add(T::DbWeight::get().reads(1_u64))
+ }
/// Storage: Refungible TokenProperties (r:0 w:1)
/// Proof: Refungible TokenProperties (max_values: None, max_size: Some(32804), added: 35279, mode: MaxEncodedLen)
/// The range of component `b` is `[0, 64]`.
- fn init_token_properties(b: u32, ) -> Weight {
+ fn write_token_properties(b: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
- // Minimum execution time: 229_000 picoseconds.
- Weight::from_parts(253_000, 0)
- // Standard Error: 100_218
- .saturating_add(Weight::from_parts(12_632_221, 0).saturating_mul(b.into()))
+ // Minimum execution time: 70_000 picoseconds.
+ Weight::from_parts(1_363_449, 0)
+ // Standard Error: 8_964
+ .saturating_add(Weight::from_parts(2_665_759, 0).saturating_mul(b.into()))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
/// Storage: Common CollectionPropertyPermissions (r:1 w:0)
@@ -435,10 +446,10 @@
// Proof Size summary in bytes:
// Measured: `561 + b * (33291 ±0)`
// Estimated: `36269`
- // Minimum execution time: 1_014_000 picoseconds.
- Weight::from_parts(1_065_000, 36269)
- // Standard Error: 39_536
- .saturating_add(Weight::from_parts(24_125_838, 0).saturating_mul(b.into()))
+ // Minimum execution time: 320_000 picoseconds.
+ Weight::from_parts(370_000, 36269)
+ // Standard Error: 28_541
+ .saturating_add(Weight::from_parts(9_863_065, 0).saturating_mul(b.into()))
.saturating_add(T::DbWeight::get().reads(3_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -450,8 +461,8 @@
// Proof Size summary in bytes:
// Measured: `288`
// Estimated: `3554`
- // Minimum execution time: 10_315_000 picoseconds.
- Weight::from_parts(10_601_000, 3554)
+ // Minimum execution time: 6_320_000 picoseconds.
+ Weight::from_parts(6_640_000, 3554)
.saturating_add(T::DbWeight::get().reads(2_u64))
.saturating_add(T::DbWeight::get().writes(2_u64))
}
@@ -461,8 +472,8 @@
// Proof Size summary in bytes:
// Measured: `288`
// Estimated: `6118`
- // Minimum execution time: 4_898_000 picoseconds.
- Weight::from_parts(5_136_000, 6118)
+ // Minimum execution time: 2_520_000 picoseconds.
+ Weight::from_parts(2_680_000, 6118)
.saturating_add(T::DbWeight::get().reads(2_u64))
}
/// Storage: Refungible CollectionAllowance (r:0 w:1)
@@ -471,8 +482,8 @@
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
- // Minimum execution time: 4_146_000 picoseconds.
- Weight::from_parts(4_337_000, 0)
+ // Minimum execution time: 2_070_000 picoseconds.
+ Weight::from_parts(2_230_000, 0)
.saturating_add(T::DbWeight::get().writes(1_u64))
}
/// Storage: Refungible CollectionAllowance (r:1 w:0)
@@ -481,8 +492,8 @@
// Proof Size summary in bytes:
// Measured: `4`
// Estimated: `3576`
- // Minimum execution time: 2_170_000 picoseconds.
- Weight::from_parts(2_301_000, 3576)
+ // Minimum execution time: 1_270_000 picoseconds.
+ Weight::from_parts(1_420_000, 3576)
.saturating_add(T::DbWeight::get().reads(1_u64))
}
/// Storage: Refungible TokenProperties (r:1 w:1)
@@ -491,8 +502,8 @@
// Proof Size summary in bytes:
// Measured: `120`
// Estimated: `36269`
- // Minimum execution time: 2_098_000 picoseconds.
- Weight::from_parts(2_251_000, 36269)
+ // Minimum execution time: 1_010_000 picoseconds.
+ Weight::from_parts(1_160_000, 36269)
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -514,8 +525,8 @@
// Proof Size summary in bytes:
// Measured: `4`
// Estimated: `3530`
- // Minimum execution time: 11_341_000 picoseconds.
- Weight::from_parts(11_741_000, 3530)
+ // Minimum execution time: 5_710_000 picoseconds.
+ Weight::from_parts(5_980_000, 3530)
.saturating_add(RocksDbWeight::get().reads(2_u64))
.saturating_add(RocksDbWeight::get().writes(5_u64))
}
@@ -534,10 +545,10 @@
// Proof Size summary in bytes:
// Measured: `4`
// Estimated: `3530`
- // Minimum execution time: 2_665_000 picoseconds.
- Weight::from_parts(2_791_000, 3530)
- // Standard Error: 996
- .saturating_add(Weight::from_parts(4_343_736, 0).saturating_mul(b.into()))
+ // Minimum execution time: 1_300_000 picoseconds.
+ Weight::from_parts(1_360_000, 3530)
+ // Standard Error: 2_783
+ .saturating_add(Weight::from_parts(3_456_531, 0).saturating_mul(b.into()))
.saturating_add(RocksDbWeight::get().reads(2_u64))
.saturating_add(RocksDbWeight::get().writes(2_u64))
.saturating_add(RocksDbWeight::get().writes((3_u64).saturating_mul(b.into())))
@@ -557,10 +568,10 @@
// Proof Size summary in bytes:
// Measured: `4`
// Estimated: `3481 + b * (2540 ±0)`
- // Minimum execution time: 2_616_000 picoseconds.
- Weight::from_parts(2_726_000, 3481)
- // Standard Error: 665
- .saturating_add(Weight::from_parts(5_554_066, 0).saturating_mul(b.into()))
+ // Minimum execution time: 1_290_000 picoseconds.
+ Weight::from_parts(1_370_000, 3481)
+ // Standard Error: 3_198
+ .saturating_add(Weight::from_parts(4_435_305, 0).saturating_mul(b.into()))
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().reads((1_u64).saturating_mul(b.into())))
.saturating_add(RocksDbWeight::get().writes(1_u64))
@@ -582,10 +593,10 @@
// Proof Size summary in bytes:
// Measured: `4`
// Estimated: `3481 + b * (2540 ±0)`
- // Minimum execution time: 3_697_000 picoseconds.
- Weight::from_parts(2_136_481, 3481)
- // Standard Error: 567
- .saturating_add(Weight::from_parts(4_390_621, 0).saturating_mul(b.into()))
+ // Minimum execution time: 1_730_000 picoseconds.
+ Weight::from_parts(1_810_000, 3481)
+ // Standard Error: 1_923
+ .saturating_add(Weight::from_parts(3_500_817, 0).saturating_mul(b.into()))
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().reads((1_u64).saturating_mul(b.into())))
.saturating_add(RocksDbWeight::get().writes(2_u64))
@@ -604,8 +615,8 @@
// Proof Size summary in bytes:
// Measured: `456`
// Estimated: `8682`
- // Minimum execution time: 22_859_000 picoseconds.
- Weight::from_parts(23_295_000, 8682)
+ // Minimum execution time: 14_010_000 picoseconds.
+ Weight::from_parts(16_300_000, 8682)
.saturating_add(RocksDbWeight::get().reads(5_u64))
.saturating_add(RocksDbWeight::get().writes(4_u64))
}
@@ -625,8 +636,8 @@
// Proof Size summary in bytes:
// Measured: `341`
// Estimated: `3554`
- // Minimum execution time: 21_477_000 picoseconds.
- Weight::from_parts(22_037_000, 3554)
+ // Minimum execution time: 13_700_000 picoseconds.
+ Weight::from_parts(14_180_000, 3554)
.saturating_add(RocksDbWeight::get().reads(4_u64))
.saturating_add(RocksDbWeight::get().writes(6_u64))
}
@@ -638,8 +649,8 @@
// Proof Size summary in bytes:
// Measured: `365`
// Estimated: `6118`
- // Minimum execution time: 13_714_000 picoseconds.
- Weight::from_parts(14_050_000, 6118)
+ // Minimum execution time: 8_990_000 picoseconds.
+ Weight::from_parts(9_400_000, 6118)
.saturating_add(RocksDbWeight::get().reads(3_u64))
.saturating_add(RocksDbWeight::get().writes(2_u64))
}
@@ -655,8 +666,8 @@
// Proof Size summary in bytes:
// Measured: `341`
// Estimated: `6118`
- // Minimum execution time: 15_879_000 picoseconds.
- Weight::from_parts(16_266_000, 6118)
+ // Minimum execution time: 10_240_000 picoseconds.
+ Weight::from_parts(10_610_000, 6118)
.saturating_add(RocksDbWeight::get().reads(4_u64))
.saturating_add(RocksDbWeight::get().writes(4_u64))
}
@@ -672,8 +683,8 @@
// Proof Size summary in bytes:
// Measured: `456`
// Estimated: `6118`
- // Minimum execution time: 18_186_000 picoseconds.
- Weight::from_parts(18_682_000, 6118)
+ // Minimum execution time: 12_040_000 picoseconds.
+ Weight::from_parts(12_390_000, 6118)
.saturating_add(RocksDbWeight::get().reads(4_u64))
.saturating_add(RocksDbWeight::get().writes(4_u64))
}
@@ -689,8 +700,8 @@
// Proof Size summary in bytes:
// Measured: `341`
// Estimated: `6118`
- // Minimum execution time: 17_943_000 picoseconds.
- Weight::from_parts(18_333_000, 6118)
+ // Minimum execution time: 11_940_000 picoseconds.
+ Weight::from_parts(12_240_000, 6118)
.saturating_add(RocksDbWeight::get().reads(5_u64))
.saturating_add(RocksDbWeight::get().writes(6_u64))
}
@@ -702,8 +713,8 @@
// Proof Size summary in bytes:
// Measured: `223`
// Estimated: `3554`
- // Minimum execution time: 8_391_000 picoseconds.
- Weight::from_parts(8_637_000, 3554)
+ // Minimum execution time: 5_150_000 picoseconds.
+ Weight::from_parts(5_440_000, 3554)
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -715,8 +726,8 @@
// Proof Size summary in bytes:
// Measured: `211`
// Estimated: `3554`
- // Minimum execution time: 8_519_000 picoseconds.
- Weight::from_parts(8_760_000, 3554)
+ // Minimum execution time: 5_170_000 picoseconds.
+ Weight::from_parts(5_400_000, 3554)
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -730,8 +741,8 @@
// Proof Size summary in bytes:
// Measured: `495`
// Estimated: `6118`
- // Minimum execution time: 19_554_000 picoseconds.
- Weight::from_parts(20_031_000, 6118)
+ // Minimum execution time: 13_150_000 picoseconds.
+ Weight::from_parts(13_600_000, 6118)
.saturating_add(RocksDbWeight::get().reads(4_u64))
.saturating_add(RocksDbWeight::get().writes(3_u64))
}
@@ -749,8 +760,8 @@
// Proof Size summary in bytes:
// Measured: `471`
// Estimated: `6118`
- // Minimum execution time: 21_338_000 picoseconds.
- Weight::from_parts(21_803_000, 6118)
+ // Minimum execution time: 14_280_000 picoseconds.
+ Weight::from_parts(14_680_000, 6118)
.saturating_add(RocksDbWeight::get().reads(5_u64))
.saturating_add(RocksDbWeight::get().writes(5_u64))
}
@@ -768,8 +779,8 @@
// Proof Size summary in bytes:
// Measured: `586`
// Estimated: `6118`
- // Minimum execution time: 24_179_000 picoseconds.
- Weight::from_parts(24_647_000, 6118)
+ // Minimum execution time: 16_110_000 picoseconds.
+ Weight::from_parts(16_710_000, 6118)
.saturating_add(RocksDbWeight::get().reads(5_u64))
.saturating_add(RocksDbWeight::get().writes(5_u64))
}
@@ -787,8 +798,8 @@
// Proof Size summary in bytes:
// Measured: `471`
// Estimated: `6118`
- // Minimum execution time: 24_008_000 picoseconds.
- Weight::from_parts(24_545_000, 6118)
+ // Minimum execution time: 16_130_000 picoseconds.
+ Weight::from_parts(16_680_000, 6118)
.saturating_add(RocksDbWeight::get().reads(6_u64))
.saturating_add(RocksDbWeight::get().writes(7_u64))
}
@@ -810,8 +821,8 @@
// Proof Size summary in bytes:
// Measured: `471`
// Estimated: `3570`
- // Minimum execution time: 27_907_000 picoseconds.
- Weight::from_parts(28_489_000, 3570)
+ // Minimum execution time: 18_380_000 picoseconds.
+ Weight::from_parts(18_870_000, 3570)
.saturating_add(RocksDbWeight::get().reads(5_u64))
.saturating_add(RocksDbWeight::get().writes(7_u64))
}
@@ -822,10 +833,10 @@
// Proof Size summary in bytes:
// Measured: `314`
// Estimated: `20191`
- // Minimum execution time: 1_460_000 picoseconds.
- Weight::from_parts(1_564_000, 20191)
- // Standard Error: 14_117
- .saturating_add(Weight::from_parts(8_196_214, 0).saturating_mul(b.into()))
+ // Minimum execution time: 580_000 picoseconds.
+ Weight::from_parts(660_000, 20191)
+ // Standard Error: 29_964
+ .saturating_add(Weight::from_parts(6_251_766, 0).saturating_mul(b.into()))
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -840,24 +851,34 @@
// Proof Size summary in bytes:
// Measured: `502 + b * (261 ±0)`
// Estimated: `36269`
- // Minimum execution time: 1_012_000 picoseconds.
- Weight::from_parts(1_081_000, 36269)
- // Standard Error: 6_838
- .saturating_add(Weight::from_parts(5_801_181, 0).saturating_mul(b.into()))
+ // Minimum execution time: 350_000 picoseconds.
+ Weight::from_parts(2_269_806, 36269)
+ // Standard Error: 7_751
+ .saturating_add(Weight::from_parts(3_068_126, 0).saturating_mul(b.into()))
.saturating_add(RocksDbWeight::get().reads(3_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
+ /// Storage: Refungible TokenProperties (r:1 w:0)
+ /// Proof: Refungible TokenProperties (max_values: None, max_size: Some(32804), added: 35279, mode: MaxEncodedLen)
+ fn load_token_properties() -> Weight {
+ // Proof Size summary in bytes:
+ // Measured: `120`
+ // Estimated: `36269`
+ // Minimum execution time: 1_010_000 picoseconds.
+ Weight::from_parts(1_080_000, 36269)
+ .saturating_add(RocksDbWeight::get().reads(1_u64))
+ }
/// Storage: Refungible TokenProperties (r:0 w:1)
/// Proof: Refungible TokenProperties (max_values: None, max_size: Some(32804), added: 35279, mode: MaxEncodedLen)
/// The range of component `b` is `[0, 64]`.
- fn init_token_properties(b: u32, ) -> Weight {
+ fn write_token_properties(b: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
- // Minimum execution time: 229_000 picoseconds.
- Weight::from_parts(253_000, 0)
- // Standard Error: 100_218
- .saturating_add(Weight::from_parts(12_632_221, 0).saturating_mul(b.into()))
+ // Minimum execution time: 70_000 picoseconds.
+ Weight::from_parts(1_363_449, 0)
+ // Standard Error: 8_964
+ .saturating_add(Weight::from_parts(2_665_759, 0).saturating_mul(b.into()))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
/// Storage: Common CollectionPropertyPermissions (r:1 w:0)
@@ -871,10 +892,10 @@
// Proof Size summary in bytes:
// Measured: `561 + b * (33291 ±0)`
// Estimated: `36269`
- // Minimum execution time: 1_014_000 picoseconds.
- Weight::from_parts(1_065_000, 36269)
- // Standard Error: 39_536
- .saturating_add(Weight::from_parts(24_125_838, 0).saturating_mul(b.into()))
+ // Minimum execution time: 320_000 picoseconds.
+ Weight::from_parts(370_000, 36269)
+ // Standard Error: 28_541
+ .saturating_add(Weight::from_parts(9_863_065, 0).saturating_mul(b.into()))
.saturating_add(RocksDbWeight::get().reads(3_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -886,8 +907,8 @@
// Proof Size summary in bytes:
// Measured: `288`
// Estimated: `3554`
- // Minimum execution time: 10_315_000 picoseconds.
- Weight::from_parts(10_601_000, 3554)
+ // Minimum execution time: 6_320_000 picoseconds.
+ Weight::from_parts(6_640_000, 3554)
.saturating_add(RocksDbWeight::get().reads(2_u64))
.saturating_add(RocksDbWeight::get().writes(2_u64))
}
@@ -897,8 +918,8 @@
// Proof Size summary in bytes:
// Measured: `288`
// Estimated: `6118`
- // Minimum execution time: 4_898_000 picoseconds.
- Weight::from_parts(5_136_000, 6118)
+ // Minimum execution time: 2_520_000 picoseconds.
+ Weight::from_parts(2_680_000, 6118)
.saturating_add(RocksDbWeight::get().reads(2_u64))
}
/// Storage: Refungible CollectionAllowance (r:0 w:1)
@@ -907,8 +928,8 @@
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
- // Minimum execution time: 4_146_000 picoseconds.
- Weight::from_parts(4_337_000, 0)
+ // Minimum execution time: 2_070_000 picoseconds.
+ Weight::from_parts(2_230_000, 0)
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
/// Storage: Refungible CollectionAllowance (r:1 w:0)
@@ -917,8 +938,8 @@
// Proof Size summary in bytes:
// Measured: `4`
// Estimated: `3576`
- // Minimum execution time: 2_170_000 picoseconds.
- Weight::from_parts(2_301_000, 3576)
+ // Minimum execution time: 1_270_000 picoseconds.
+ Weight::from_parts(1_420_000, 3576)
.saturating_add(RocksDbWeight::get().reads(1_u64))
}
/// Storage: Refungible TokenProperties (r:1 w:1)
@@ -927,8 +948,8 @@
// Proof Size summary in bytes:
// Measured: `120`
// Estimated: `36269`
- // Minimum execution time: 2_098_000 picoseconds.
- Weight::from_parts(2_251_000, 36269)
+ // Minimum execution time: 1_010_000 picoseconds.
+ Weight::from_parts(1_160_000, 36269)
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
pallets/structure/src/lib.rsdiffbeforeafterboth--- a/pallets/structure/src/lib.rs
+++ b/pallets/structure/src/lib.rs
@@ -53,11 +53,7 @@
#![cfg_attr(not(feature = "std"), no_std)]
-use frame_support::{
- dispatch::{DispatchResult, DispatchResultWithPostInfo},
- fail,
- pallet_prelude::*,
-};
+use frame_support::{dispatch::DispatchResult, fail, pallet_prelude::*};
use pallet_common::{
dispatch::CollectionDispatch, erc::CrossAccountId, eth::is_collection,
CommonCollectionOperations,
@@ -267,22 +263,6 @@
}
Err(<Error<T>>::DepthLimit.into())
- }
-
- /// Burn token and all of it's nested tokens
- ///
- /// - `self_budget`: Limit for searching children in depth.
- /// - `breadth_budget`: Limit of breadth of searching children.
- pub fn burn_item_recursively(
- from: T::CrossAccountId,
- collection: CollectionId,
- token: TokenId,
- self_budget: &dyn Budget,
- breadth_budget: &dyn Budget,
- ) -> DispatchResultWithPostInfo {
- let dispatch = T::CollectionDispatch::dispatch(collection)?;
- let dispatch = dispatch.as_dyn();
- dispatch.burn_item_recursively(from, token, self_budget, breadth_budget)
}
/// Check if `token` indirectly owned by `user`
pallets/unique/Cargo.tomldiffbeforeafterboth--- a/pallets/unique/Cargo.toml
+++ b/pallets/unique/Cargo.toml
@@ -31,7 +31,9 @@
'parity-scale-codec/std',
'sp-runtime/std',
'sp-std/std',
+ 'up-common/std',
'up-data-structs/std',
+ 'pallet-structure/std',
]
stubgen = ["evm-coder/stubgen", "pallet-common/stubgen"]
try-runtime = ["frame-support/try-runtime"]
@@ -53,9 +55,11 @@
pallet-evm-coder-substrate = { workspace = true }
pallet-nonfungible = { workspace = true }
pallet-refungible = { workspace = true }
+pallet-structure = { workspace = true }
scale-info = { workspace = true }
sp-core = { workspace = true }
sp-io = { workspace = true }
sp-runtime = { workspace = true }
sp-std = { workspace = true }
+up-common = { workspace = true }
up-data-structs = { workspace = true }
pallets/unique/src/lib.rsdiffbeforeafterboth--- a/pallets/unique/src/lib.rs
+++ b/pallets/unique/src/lib.rs
@@ -84,13 +84,20 @@
#[frame_support::pallet]
pub mod pallet {
- use frame_support::{dispatch::DispatchResult, ensure, fail, storage::Key, BoundedVec};
+ use frame_support::{
+ dispatch::{DispatchErrorWithPostInfo, DispatchResult, PostDispatchInfo},
+ ensure, fail,
+ storage::Key,
+ BoundedVec,
+ };
use frame_system::{ensure_root, ensure_signed};
use pallet_common::{
dispatch::{dispatch_tx, CollectionDispatch},
- CollectionHandle, CommonWeightInfo, Pallet as PalletCommon, RefungibleExtensionsWeightInfo,
+ CollectionHandle, CommonCollectionOperations, CommonWeightInfo, Pallet as PalletCommon,
+ RefungibleExtensionsWeightInfo,
};
use pallet_evm::account::CrossAccountId;
+ use pallet_structure::weights::WeightInfo as StructureWeightInfo;
use scale_info::TypeInfo;
use sp_std::{vec, vec::Vec};
use up_data_structs::{
@@ -104,9 +111,6 @@
use weights::WeightInfo;
use super::*;
-
- /// A maximum number of levels of depth in the token nesting tree.
- pub const NESTING_BUDGET: u32 = 5;
/// Errors for the common Unique transactions.
#[pallet::error]
@@ -128,6 +132,8 @@
/// Weight information for common pallet operations.
type CommonWeightInfo: CommonWeightInfo<Self::CrossAccountId>;
+ type StructureWeightInfo: StructureWeightInfo;
+
/// Weight info information for extra refungible pallet operations.
type RefungibleExtensionsWeightInfo: RefungibleExtensionsWeightInfo;
}
@@ -264,7 +270,7 @@
impl<T: Config> Pallet<T> {
/// A maximum number of levels of depth in the token nesting tree.
fn nesting_budget() -> u32 {
- NESTING_BUDGET
+ 5
}
/// Maximal length of a collection name.
@@ -666,7 +672,7 @@
/// * `owner`: Address of the initial owner of the item.
/// * `data`: Token data describing the item to store on chain.
#[pallet::call_index(11)]
- #[pallet::weight(T::CommonWeightInfo::create_item(data))]
+ #[pallet::weight(T::CommonWeightInfo::create_item(data) + <Pallet<T>>::nesting_budget_predispatch_weight())]
pub fn create_item(
origin: OriginFor<T>,
collection_id: CollectionId,
@@ -674,9 +680,9 @@
data: CreateItemData,
) -> DispatchResultWithPostInfo {
let sender = T::CrossAccountId::from_sub(ensure_signed(origin)?);
- let budget = budget::Value::new(NESTING_BUDGET);
+ let budget = Self::structure_nesting_budget();
- dispatch_tx::<T, _>(collection_id, |d| {
+ Self::dispatch_tx_with_nesting_budget(collection_id, &budget, |d| {
d.create_item(sender, owner, data, &budget)
})
}
@@ -700,7 +706,7 @@
/// * `owner`: Address of the initial owner of the tokens.
/// * `items_data`: Vector of data describing each item to be created.
#[pallet::call_index(12)]
- #[pallet::weight(T::CommonWeightInfo::create_multiple_items(items_data))]
+ #[pallet::weight(T::CommonWeightInfo::create_multiple_items(items_data) + <Pallet<T>>::nesting_budget_predispatch_weight())]
pub fn create_multiple_items(
origin: OriginFor<T>,
collection_id: CollectionId,
@@ -709,9 +715,9 @@
) -> DispatchResultWithPostInfo {
ensure!(!items_data.is_empty(), Error::<T>::EmptyArgument);
let sender = T::CrossAccountId::from_sub(ensure_signed(origin)?);
- let budget = budget::Value::new(NESTING_BUDGET);
+ let budget = Self::structure_nesting_budget();
- dispatch_tx::<T, _>(collection_id, |d| {
+ Self::dispatch_tx_with_nesting_budget(collection_id, &budget, |d| {
d.create_multiple_items(sender, owner, items_data, &budget)
})
}
@@ -791,7 +797,7 @@
/// * `properties`: Vector of key-value pairs stored as the token's metadata.
/// Keys support Latin letters, `-`, `_`, and `.` as symbols.
#[pallet::call_index(15)]
- #[pallet::weight(T::CommonWeightInfo::set_token_properties(properties.len() as u32))]
+ #[pallet::weight(T::CommonWeightInfo::set_token_properties(properties.len() as u32) + <Pallet<T>>::nesting_budget_predispatch_weight())]
pub fn set_token_properties(
origin: OriginFor<T>,
collection_id: CollectionId,
@@ -801,9 +807,9 @@
ensure!(!properties.is_empty(), Error::<T>::EmptyArgument);
let sender = T::CrossAccountId::from_sub(ensure_signed(origin)?);
- let budget = budget::Value::new(NESTING_BUDGET);
+ let budget = Self::structure_nesting_budget();
- dispatch_tx::<T, _>(collection_id, |d| {
+ Self::dispatch_tx_with_nesting_budget(collection_id, &budget, |d| {
d.set_token_properties(sender, token_id, properties, &budget)
})
}
@@ -824,7 +830,7 @@
/// * `property_keys`: Vector of keys of the properties to be deleted.
/// Keys support Latin letters, `-`, `_`, and `.` as symbols.
#[pallet::call_index(16)]
- #[pallet::weight(T::CommonWeightInfo::delete_token_properties(property_keys.len() as u32))]
+ #[pallet::weight(T::CommonWeightInfo::delete_token_properties(property_keys.len() as u32) + <Pallet<T>>::nesting_budget_predispatch_weight())]
pub fn delete_token_properties(
origin: OriginFor<T>,
collection_id: CollectionId,
@@ -834,9 +840,9 @@
ensure!(!property_keys.is_empty(), Error::<T>::EmptyArgument);
let sender = T::CrossAccountId::from_sub(ensure_signed(origin)?);
- let budget = budget::Value::new(NESTING_BUDGET);
+ let budget = Self::structure_nesting_budget();
- dispatch_tx::<T, _>(collection_id, |d| {
+ Self::dispatch_tx_with_nesting_budget(collection_id, &budget, |d| {
d.delete_token_properties(sender, token_id, property_keys, &budget)
})
}
@@ -888,16 +894,16 @@
/// * `collection_id`: ID of the collection to which the tokens would belong.
/// * `data`: Explicit item creation data.
#[pallet::call_index(18)]
- #[pallet::weight(T::CommonWeightInfo::create_multiple_items_ex(data))]
+ #[pallet::weight(T::CommonWeightInfo::create_multiple_items_ex(data) + <Pallet<T>>::nesting_budget_predispatch_weight())]
pub fn create_multiple_items_ex(
origin: OriginFor<T>,
collection_id: CollectionId,
data: CreateItemExData<T::CrossAccountId>,
) -> DispatchResultWithPostInfo {
let sender = T::CrossAccountId::from_sub(ensure_signed(origin)?);
- let budget = budget::Value::new(NESTING_BUDGET);
+ let budget = Self::structure_nesting_budget();
- dispatch_tx::<T, _>(collection_id, |d| {
+ Self::dispatch_tx_with_nesting_budget(collection_id, &budget, |d| {
d.create_multiple_items_ex(sender, data, &budget)
})
}
@@ -995,7 +1001,7 @@
/// * Fungible Mode: The desired number of pieces to burn.
/// * Re-Fungible Mode: The desired number of pieces to burn.
#[pallet::call_index(21)]
- #[pallet::weight(T::CommonWeightInfo::burn_from())]
+ #[pallet::weight(T::CommonWeightInfo::burn_from() + <Pallet<T>>::nesting_budget_predispatch_weight())]
pub fn burn_from(
origin: OriginFor<T>,
collection_id: CollectionId,
@@ -1004,9 +1010,9 @@
value: u128,
) -> DispatchResultWithPostInfo {
let sender = T::CrossAccountId::from_sub(ensure_signed(origin)?);
- let budget = budget::Value::new(NESTING_BUDGET);
+ let budget = Self::structure_nesting_budget();
- dispatch_tx::<T, _>(collection_id, |d| {
+ Self::dispatch_tx_with_nesting_budget(collection_id, &budget, |d| {
d.burn_from(sender, from, item_id, value, &budget)
})
}
@@ -1033,7 +1039,7 @@
/// * Fungible Mode: The desired number of pieces to transfer.
/// * Re-Fungible Mode: The desired number of pieces to transfer.
#[pallet::call_index(22)]
- #[pallet::weight(T::CommonWeightInfo::transfer())]
+ #[pallet::weight(T::CommonWeightInfo::transfer() + <Pallet<T>>::nesting_budget_predispatch_weight())]
pub fn transfer(
origin: OriginFor<T>,
recipient: T::CrossAccountId,
@@ -1042,9 +1048,9 @@
value: u128,
) -> DispatchResultWithPostInfo {
let sender = T::CrossAccountId::from_sub(ensure_signed(origin)?);
- let budget = budget::Value::new(NESTING_BUDGET);
+ let budget = Self::structure_nesting_budget();
- dispatch_tx::<T, _>(collection_id, |d| {
+ Self::dispatch_tx_with_nesting_budget(collection_id, &budget, |d| {
d.transfer(sender, recipient, item_id, value, &budget)
})
}
@@ -1138,7 +1144,7 @@
/// * Fungible Mode: The desired number of pieces to transfer.
/// * Re-Fungible Mode: The desired number of pieces to transfer.
#[pallet::call_index(25)]
- #[pallet::weight(T::CommonWeightInfo::transfer_from())]
+ #[pallet::weight(T::CommonWeightInfo::transfer_from() + <Pallet<T>>::nesting_budget_predispatch_weight())]
pub fn transfer_from(
origin: OriginFor<T>,
from: T::CrossAccountId,
@@ -1148,9 +1154,9 @@
value: u128,
) -> DispatchResultWithPostInfo {
let sender = T::CrossAccountId::from_sub(ensure_signed(origin)?);
- let budget = budget::Value::new(NESTING_BUDGET);
+ let budget = Self::structure_nesting_budget();
- dispatch_tx::<T, _>(collection_id, |d| {
+ Self::dispatch_tx_with_nesting_budget(collection_id, &budget, |d| {
d.transfer_from(sender, from, recipient, item_id, value, &budget)
})
}
@@ -1348,5 +1354,44 @@
Ok(())
}
+
+ fn structure_nesting_budget() -> budget::Value {
+ budget::Value::new(Self::nesting_budget())
+ }
+
+ fn nesting_budget_weight(value: &budget::Value) -> Weight {
+ T::StructureWeightInfo::find_parent().saturating_mul(value.remaining() as u64)
+ }
+
+ fn nesting_budget_predispatch_weight() -> Weight {
+ Self::nesting_budget_weight(&Self::structure_nesting_budget())
+ }
+
+ pub fn dispatch_tx_with_nesting_budget<
+ C: FnOnce(&dyn CommonCollectionOperations<T>) -> DispatchResultWithPostInfo,
+ >(
+ collection: CollectionId,
+ budget: &budget::Value,
+ call: C,
+ ) -> DispatchResultWithPostInfo {
+ let mut result = dispatch_tx::<T, _>(collection, call);
+
+ match &mut result {
+ Ok(PostDispatchInfo {
+ actual_weight: Some(weight),
+ ..
+ })
+ | Err(DispatchErrorWithPostInfo {
+ post_info: PostDispatchInfo {
+ actual_weight: Some(weight),
+ ..
+ },
+ ..
+ }) => *weight += Self::nesting_budget_weight(budget),
+ _ => {}
+ }
+
+ result
+ }
}
}
primitives/common/src/constants.rsdiffbeforeafterboth--- a/primitives/common/src/constants.rs
+++ b/primitives/common/src/constants.rs
@@ -45,6 +45,7 @@
/// Minimum balance required to create or keep an account open.
pub const EXISTENTIAL_DEPOSIT: u128 = 0;
+
/// Amount of Balance reserved for candidate registration.
pub const GENESIS_LICENSE_BOND: u128 = 1_000_000_000_000 * UNIQUE;
/// Amount of maximum collators for Collator Selection.
primitives/data-structs/src/budget.rsdiffbeforeafterboth--- a/primitives/data-structs/src/budget.rs
+++ b/primitives/data-structs/src/budget.rs
@@ -1,4 +1,4 @@
-use core::cell::Cell;
+use sp_std::cell::Cell;
pub trait Budget {
/// Returns true while not exceeded
@@ -22,7 +22,7 @@
pub fn new(v: u32) -> Self {
Self(Cell::new(v))
}
- pub fn refund(self) -> u32 {
+ pub fn remaining(&self) -> u32 {
self.0.get()
}
}
runtime/common/config/pallets/mod.rsdiffbeforeafterboth--- a/runtime/common/config/pallets/mod.rs
+++ b/runtime/common/config/pallets/mod.rs
@@ -116,6 +116,7 @@
impl pallet_unique::Config for Runtime {
type WeightInfo = pallet_unique::weights::SubstrateWeight<Self>;
type CommonWeightInfo = CommonWeights<Self>;
+ type StructureWeightInfo = pallet_structure::weights::SubstrateWeight<Self>;
type RefungibleExtensionsWeightInfo = CommonWeights<Self>;
}
runtime/common/runtime_apis.rsdiffbeforeafterboth--- a/runtime/common/runtime_apis.rs
+++ b/runtime/common/runtime_apis.rs
@@ -84,7 +84,7 @@
}
fn topmost_token_owner(collection: CollectionId, token: TokenId) -> Result<Option<CrossAccountId>, DispatchError> {
- let budget = up_data_structs::budget::Value::new(10);
+ let budget = budget::Value::new(10);
<pallet_structure::Pallet<Runtime>>::find_topmost_owner(collection, token, &budget)
}
runtime/common/weights/mod.rsdiffbeforeafterboth--- a/runtime/common/weights/mod.rs
+++ b/runtime/common/weights/mod.rs
@@ -98,10 +98,6 @@
dispatch_weight::<T>() + max_weight_of!(set_token_properties(amount))
}
- fn delete_token_properties(amount: u32) -> Weight {
- dispatch_weight::<T>() + max_weight_of!(delete_token_properties(amount))
- }
-
fn set_token_property_permissions(amount: u32) -> Weight {
dispatch_weight::<T>() + max_weight_of!(set_token_property_permissions(amount))
}
@@ -124,26 +120,14 @@
fn burn_from() -> Weight {
dispatch_weight::<T>() + max_weight_of!(burn_from())
- }
-
- fn burn_recursively_self_raw() -> Weight {
- max_weight_of!(burn_recursively_self_raw())
- }
-
- fn burn_recursively_breadth_raw(amount: u32) -> Weight {
- max_weight_of!(burn_recursively_breadth_raw(amount))
- }
-
- fn token_owner() -> Weight {
- max_weight_of!(token_owner())
}
fn set_allowance_for_all() -> Weight {
- max_weight_of!(set_allowance_for_all())
+ dispatch_weight::<T>() + max_weight_of!(set_allowance_for_all())
}
fn force_repair_item() -> Weight {
- max_weight_of!(force_repair_item())
+ dispatch_weight::<T>() + max_weight_of!(force_repair_item())
}
}