difftreelog
feat(identity) force set subs
in: master
4 files changed
Makefilediffbeforeafterboth--- a/Makefile
+++ b/Makefile
@@ -146,5 +146,5 @@
make _bench PALLET=app-promotion PALLET_DIR=app-promotion
.PHONY: bench
-# Disabled: bench-scheduler, bench-collator-selection, bench-rmrk-core, bench-rmrk-equip
-bench: bench-evm-migration bench-unique bench-structure bench-fungible bench-refungible bench-nonfungible bench-configuration bench-foreign-assets bench-identity
+# Disabled: bench-scheduler, bench-collator-selection, bench-identity, bench-rmrk-core, bench-rmrk-equip
+bench: bench-evm-migration bench-unique bench-structure bench-fungible bench-refungible bench-nonfungible bench-configuration bench-foreign-assets
pallets/identity/src/benchmarking.rsdiffbeforeafterboth--- a/pallets/identity/src/benchmarking.rs
+++ b/pallets/identity/src/benchmarking.rs
@@ -417,7 +417,7 @@
let n in 0..600;
use frame_benchmarking::account;
let identities = (0..n).map(|i| (
- account("caller", i, 0),
+ account("caller", i, SEED),
Registration::<BalanceOf<T>, T::MaxRegistrars, T::MaxAdditionalFields> {
judgements: Default::default(),
deposit: Default::default(),
@@ -433,7 +433,7 @@
use frame_benchmarking::account;
let origin = T::ForceOrigin::successful_origin();
let identities = (0..n).map(|i| (
- account("caller", i, 0),
+ account("caller", i, SEED),
Registration::<BalanceOf<T>, T::MaxRegistrars, T::MaxAdditionalFields> {
judgements: Default::default(),
deposit: Default::default(),
@@ -446,6 +446,20 @@
let identities = identities.into_iter().map(|(acc, _)| acc).collect::<Vec<_>>();
}: _<T::RuntimeOrigin>(origin, identities)
+ force_set_subs {
+ let s in 0 .. T::MaxSubAccounts::get();
+ let n in 0..600;
+ use frame_benchmarking::account;
+ let identities = (0..n).map(|i| (
+ account("caller", i, SEED),
+ (
+ BalanceOf::<T>::max_value(),
+ create_sub_accounts::<T>(&caller, s)?.try_into().unwrap(),
+ ),
+ )).collect::<Vec<_>>();
+ let origin = T::ForceOrigin::successful_origin();
+ }: _<T::RuntimeOrigin>(origin, identities)
+
add_sub {
let s in 0 .. T::MaxSubAccounts::get() - 1;
pallets/identity/src/lib.rsdiffbeforeafterboth1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617// Original license:18// This file is part of Substrate.1920// Copyright (C) 2019-2022 Parity Technologies (UK) Ltd.21// SPDX-License-Identifier: Apache-2.02223// Licensed under the Apache License, Version 2.0 (the "License");24// you may not use this file except in compliance with the License.25// You may obtain a copy of the License at26//27// http://www.apache.org/licenses/LICENSE-2.028//29// Unless required by applicable law or agreed to in writing, software30// distributed under the License is distributed on an "AS IS" BASIS,31// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.32// See the License for the specific language governing permissions and33// limitations under the License.3435//! # Identity Pallet36//!37//! - [`Config`]38//! - [`Call`]39//!40//! ## Overview41//!42//! A federated naming system, allowing for multiple registrars to be added from a specified origin.43//! Registrars can set a fee to provide identity-verification service. Anyone can put forth a44//! proposed identity for a fixed deposit and ask for review by any number of registrars (paying45//! each of their fees). Registrar judgements are given as an `enum`, allowing for sophisticated,46//! multi-tier opinions.47//!48//! Some judgements are identified as *sticky*, which means they cannot be removed except by49//! complete removal of the identity, or by the registrar. Judgements are allowed to represent a50//! portion of funds that have been reserved for the registrar.51//!52//! A super-user can remove accounts and in doing so, slash the deposit.53//!54//! All accounts may also have a limited number of sub-accounts which may be specified by the owner;55//! by definition, these have equivalent ownership and each has an individual name.56//!57//! The number of registrars should be limited, and the deposit made sufficiently large, to ensure58//! no state-bloat attack is viable.59//!60//! ## Interface61//!62//! ### Dispatchable Functions63//!64//! #### For general users65//! * `set_identity` - Set the associated identity of an account; a small deposit is reserved if not66//! already taken.67//! * `clear_identity` - Remove an account's associated identity; the deposit is returned.68//! * `request_judgement` - Request a judgement from a registrar, paying a fee.69//! * `cancel_request` - Cancel the previous request for a judgement.70//!71//! #### For general users with sub-identities72//! * `set_subs` - Set the sub-accounts of an identity.73//! * `add_sub` - Add a sub-identity to an identity.74//! * `remove_sub` - Remove a sub-identity of an identity.75//! * `rename_sub` - Rename a sub-identity of an identity.76//! * `quit_sub` - Remove a sub-identity of an identity (called by the sub-identity).77//!78//! #### For registrars79//! * `set_fee` - Set the fee required to be paid for a judgement to be given by the registrar.80//! * `set_fields` - Set the fields that a registrar cares about in their judgements.81//! * `provide_judgement` - Provide a judgement to an identity.82//!83//! #### For super-users84//! * `add_registrar` - Add a new registrar to the system.85//! * `kill_identity` - Forcibly remove the associated identity; the deposit is lost.86//!87//! [`Call`]: ./enum.Call.html88//! [`Config`]: ./trait.Config.html8990#![cfg_attr(not(feature = "std"), no_std)]9192mod benchmarking;93#[cfg(test)]94mod tests;95mod types;96pub mod weights;9798use frame_support::traits::{BalanceStatus, Currency, OnUnbalanced, ReservableCurrency};99use sp_runtime::traits::{AppendZerosInput, Hash, Saturating, StaticLookup, Zero};100use sp_std::prelude::*;101pub use weights::WeightInfo;102103pub use pallet::*;104pub use types::{105 Data, IdentityField, IdentityFields, IdentityInfo, Judgement, RegistrarIndex, RegistrarInfo,106 Registration,107};108109pub type BalanceOf<T> =110 <<T as Config>::Currency as Currency<<T as frame_system::Config>::AccountId>>::Balance;111type NegativeImbalanceOf<T> = <<T as Config>::Currency as Currency<112 <T as frame_system::Config>::AccountId,113>>::NegativeImbalance;114type AccountIdLookupOf<T> = <<T as frame_system::Config>::Lookup as StaticLookup>::Source;115116#[frame_support::pallet]117pub mod pallet {118 use super::*;119 use frame_support::pallet_prelude::*;120 use frame_system::pallet_prelude::*;121122 #[pallet::config]123 pub trait Config: frame_system::Config {124 /// The overarching event type.125 type RuntimeEvent: From<Event<Self>> + IsType<<Self as frame_system::Config>::RuntimeEvent>;126127 /// The currency trait.128 type Currency: ReservableCurrency<Self::AccountId>;129130 /// The amount held on deposit for a registered identity131 #[pallet::constant]132 type BasicDeposit: Get<BalanceOf<Self>>;133134 /// The amount held on deposit per additional field for a registered identity.135 #[pallet::constant]136 type FieldDeposit: Get<BalanceOf<Self>>;137138 /// The amount held on deposit for a registered subaccount. This should account for the fact139 /// that one storage item's value will increase by the size of an account ID, and there will140 /// be another trie item whose value is the size of an account ID plus 32 bytes.141 #[pallet::constant]142 type SubAccountDeposit: Get<BalanceOf<Self>>;143144 /// The maximum number of sub-accounts allowed per identified account.145 #[pallet::constant]146 type MaxSubAccounts: Get<u32>;147148 /// Maximum number of additional fields that may be stored in an ID. Needed to bound the I/O149 /// required to access an identity, but can be pretty high.150 #[pallet::constant]151 type MaxAdditionalFields: Get<u32>;152153 /// Maxmimum number of registrars allowed in the system. Needed to bound the complexity154 /// of, e.g., updating judgements.155 #[pallet::constant]156 type MaxRegistrars: Get<u32>;157158 /// What to do with slashed funds.159 type Slashed: OnUnbalanced<NegativeImbalanceOf<Self>>;160161 /// The origin which may forcibly set or remove a name. Root can always do this.162 type ForceOrigin: EnsureOrigin<Self::RuntimeOrigin>;163164 /// The origin which may add or remove registrars. Root can always do this.165 type RegistrarOrigin: EnsureOrigin<Self::RuntimeOrigin>;166167 /// Weight information for extrinsics in this pallet.168 type WeightInfo: WeightInfo;169 }170171 #[pallet::pallet]172 #[pallet::generate_store(pub(super) trait Store)]173 pub struct Pallet<T>(_);174175 /// Information that is pertinent to identify the entity behind an account.176 ///177 /// TWOX-NOTE: OK ― `AccountId` is a secure hash.178 #[pallet::storage]179 #[pallet::getter(fn identity)]180 pub(super) type IdentityOf<T: Config> = StorageMap<181 _,182 Twox64Concat,183 T::AccountId,184 Registration<BalanceOf<T>, T::MaxRegistrars, T::MaxAdditionalFields>,185 OptionQuery,186 >;187188 /// The super-identity of an alternative "sub" identity together with its name, within that189 /// context. If the account is not some other account's sub-identity, then just `None`.190 #[pallet::storage]191 #[pallet::getter(fn super_of)]192 pub(super) type SuperOf<T: Config> =193 StorageMap<_, Blake2_128Concat, T::AccountId, (T::AccountId, Data), OptionQuery>;194195 /// Alternative "sub" identities of this account.196 ///197 /// The first item is the deposit, the second is a vector of the accounts.198 ///199 /// TWOX-NOTE: OK ― `AccountId` is a secure hash.200 #[pallet::storage]201 #[pallet::getter(fn subs_of)]202 pub(super) type SubsOf<T: Config> = StorageMap<203 _,204 Twox64Concat,205 T::AccountId,206 (BalanceOf<T>, BoundedVec<T::AccountId, T::MaxSubAccounts>),207 ValueQuery,208 >;209210 /// The set of registrars. Not expected to get very big as can only be added through a211 /// special origin (likely a council motion).212 ///213 /// The index into this can be cast to `RegistrarIndex` to get a valid value.214 #[pallet::storage]215 #[pallet::getter(fn registrars)]216 pub(super) type Registrars<T: Config> = StorageValue<217 _,218 BoundedVec<Option<RegistrarInfo<BalanceOf<T>, T::AccountId>>, T::MaxRegistrars>,219 ValueQuery,220 >;221222 #[pallet::error]223 pub enum Error<T> {224 /// Too many subs-accounts.225 TooManySubAccounts,226 /// Account isn't found.227 NotFound,228 /// Account isn't named.229 NotNamed,230 /// Empty index.231 EmptyIndex,232 /// Fee is changed.233 FeeChanged,234 /// No identity found.235 NoIdentity,236 /// Sticky judgement.237 StickyJudgement,238 /// Judgement given.239 JudgementGiven,240 /// Invalid judgement.241 InvalidJudgement,242 /// The index is invalid.243 InvalidIndex,244 /// The target is invalid.245 InvalidTarget,246 /// Too many additional fields.247 TooManyFields,248 /// Maximum amount of registrars reached. Cannot add any more.249 TooManyRegistrars,250 /// Account ID is already named.251 AlreadyClaimed,252 /// Sender is not a sub-account.253 NotSub,254 /// Sub-account isn't owned by sender.255 NotOwned,256 /// The provided judgement was for a different identity.257 JudgementForDifferentIdentity,258 /// Error that occurs when there is an issue paying for judgement.259 JudgementPaymentFailed,260 }261262 #[pallet::event]263 #[pallet::generate_deposit(pub(super) fn deposit_event)]264 pub enum Event<T: Config> {265 /// A name was set or reset (which will remove all judgements).266 IdentitySet { who: T::AccountId },267 /// A name was cleared, and the given balance returned.268 IdentityCleared {269 who: T::AccountId,270 deposit: BalanceOf<T>,271 },272 /// A name was removed and the given balance slashed.273 IdentityKilled {274 who: T::AccountId,275 deposit: BalanceOf<T>,276 },277 /// A number of identities and associated info were forcibly inserted.278 IdentitiesInserted { amount: u32 },279 /// A number of identities and all associated info were forcibly removed.280 IdentitiesRemoved { amount: u32 },281 /// A judgement was asked from a registrar.282 JudgementRequested {283 who: T::AccountId,284 registrar_index: RegistrarIndex,285 },286 /// A judgement request was retracted.287 JudgementUnrequested {288 who: T::AccountId,289 registrar_index: RegistrarIndex,290 },291 /// A judgement was given by a registrar.292 JudgementGiven {293 target: T::AccountId,294 registrar_index: RegistrarIndex,295 },296 /// A registrar was added.297 RegistrarAdded { registrar_index: RegistrarIndex },298 /// A sub-identity was added to an identity and the deposit paid.299 SubIdentityAdded {300 sub: T::AccountId,301 main: T::AccountId,302 deposit: BalanceOf<T>,303 },304 /// A sub-identity was removed from an identity and the deposit freed.305 SubIdentityRemoved {306 sub: T::AccountId,307 main: T::AccountId,308 deposit: BalanceOf<T>,309 },310 /// A sub-identity was cleared, and the given deposit repatriated from the311 /// main identity account to the sub-identity account.312 SubIdentityRevoked {313 sub: T::AccountId,314 main: T::AccountId,315 deposit: BalanceOf<T>,316 },317 }318319 #[pallet::call]320 /// Identity pallet declaration.321 impl<T: Config> Pallet<T> {322 /// Add a registrar to the system.323 ///324 /// The dispatch origin for this call must be `T::RegistrarOrigin`.325 ///326 /// - `account`: the account of the registrar.327 ///328 /// Emits `RegistrarAdded` if successful.329 ///330 /// # <weight>331 /// - `O(R)` where `R` registrar-count (governance-bounded and code-bounded).332 /// - One storage mutation (codec `O(R)`).333 /// - One event.334 /// # </weight>335 #[pallet::call_index(0)]336 #[pallet::weight(T::WeightInfo::add_registrar(T::MaxRegistrars::get()))]337 pub fn add_registrar(338 origin: OriginFor<T>,339 account: AccountIdLookupOf<T>,340 ) -> DispatchResultWithPostInfo {341 T::RegistrarOrigin::ensure_origin(origin)?;342 let account = T::Lookup::lookup(account)?;343344 let (i, registrar_count) = <Registrars<T>>::try_mutate(345 |registrars| -> Result<(RegistrarIndex, usize), DispatchError> {346 registrars347 .try_push(Some(RegistrarInfo {348 account,349 fee: Zero::zero(),350 fields: Default::default(),351 }))352 .map_err(|_| Error::<T>::TooManyRegistrars)?;353 Ok(((registrars.len() - 1) as RegistrarIndex, registrars.len()))354 },355 )?;356357 Self::deposit_event(Event::RegistrarAdded { registrar_index: i });358359 Ok(Some(T::WeightInfo::add_registrar(registrar_count as u32)).into())360 }361362 /// Set an account's identity information and reserve the appropriate deposit.363 ///364 /// If the account already has identity information, the deposit is taken as part payment365 /// for the new deposit.366 ///367 /// The dispatch origin for this call must be _Signed_.368 ///369 /// - `info`: The identity information.370 ///371 /// Emits `IdentitySet` if successful.372 ///373 /// # <weight>374 /// - `O(X + X' + R)`375 /// - where `X` additional-field-count (deposit-bounded and code-bounded)376 /// - where `R` judgements-count (registrar-count-bounded)377 /// - One balance reserve operation.378 /// - One storage mutation (codec-read `O(X' + R)`, codec-write `O(X + R)`).379 /// - One event.380 /// # </weight>381 #[pallet::call_index(1)]382 #[pallet::weight( T::WeightInfo::set_identity(383 T::MaxRegistrars::get(), // R384 T::MaxAdditionalFields::get(), // X385 ))]386 pub fn set_identity(387 origin: OriginFor<T>,388 info: Box<IdentityInfo<T::MaxAdditionalFields>>,389 ) -> DispatchResultWithPostInfo {390 let sender = ensure_signed(origin)?;391 let extra_fields = info.additional.len() as u32;392 ensure!(393 extra_fields <= T::MaxAdditionalFields::get(),394 Error::<T>::TooManyFields395 );396 let fd = <BalanceOf<T>>::from(extra_fields) * T::FieldDeposit::get();397398 let mut id = match <IdentityOf<T>>::get(&sender) {399 Some(mut id) => {400 // Only keep non-positive judgements.401 id.judgements.retain(|j| j.1.is_sticky());402 id.info = *info;403 id404 }405 None => Registration {406 info: *info,407 judgements: BoundedVec::default(),408 deposit: Zero::zero(),409 },410 };411412 let old_deposit = id.deposit;413 id.deposit = T::BasicDeposit::get() + fd;414 if id.deposit > old_deposit {415 T::Currency::reserve(&sender, id.deposit - old_deposit)?;416 }417 if old_deposit > id.deposit {418 let err_amount = T::Currency::unreserve(&sender, old_deposit - id.deposit);419 debug_assert!(err_amount.is_zero());420 }421422 let judgements = id.judgements.len();423 <IdentityOf<T>>::insert(&sender, id);424 Self::deposit_event(Event::IdentitySet { who: sender });425426 Ok(Some(T::WeightInfo::set_identity(427 judgements as u32, // R428 extra_fields, // X429 ))430 .into())431 }432433 /// Set the sub-accounts of the sender.434 ///435 /// Payment: Any aggregate balance reserved by previous `set_subs` calls will be returned436 /// and an amount `SubAccountDeposit` will be reserved for each item in `subs`.437 ///438 /// The dispatch origin for this call must be _Signed_ and the sender must have a registered439 /// identity.440 ///441 /// - `subs`: The identity's (new) sub-accounts.442 ///443 /// # <weight>444 /// - `O(P + S)`445 /// - where `P` old-subs-count (hard- and deposit-bounded).446 /// - where `S` subs-count (hard- and deposit-bounded).447 /// - At most one balance operations.448 /// - DB:449 /// - `P + S` storage mutations (codec complexity `O(1)`)450 /// - One storage read (codec complexity `O(P)`).451 /// - One storage write (codec complexity `O(S)`).452 /// - One storage-exists (`IdentityOf::contains_key`).453 /// # </weight>454 // TODO: This whole extrinsic screams "not optimized". For example we could455 // filter any overlap between new and old subs, and avoid reading/writing456 // to those values... We could also ideally avoid needing to write to457 // N storage items for N sub accounts. Right now the weight on this function458 // is a large overestimate due to the fact that it could potentially write459 // to 2 x T::MaxSubAccounts::get().460 #[pallet::call_index(2)]461 #[pallet::weight(T::WeightInfo::set_subs_old(T::MaxSubAccounts::get()) // P: Assume max sub accounts removed.462 .saturating_add(T::WeightInfo::set_subs_new(subs.len() as u32)) // S: Assume all subs are new.463 )]464 pub fn set_subs(465 origin: OriginFor<T>,466 subs: Vec<(T::AccountId, Data)>,467 ) -> DispatchResultWithPostInfo {468 let sender = ensure_signed(origin)?;469 ensure!(<IdentityOf<T>>::contains_key(&sender), Error::<T>::NotFound);470 ensure!(471 subs.len() <= T::MaxSubAccounts::get() as usize,472 Error::<T>::TooManySubAccounts473 );474475 let (old_deposit, old_ids) = <SubsOf<T>>::get(&sender);476 let new_deposit = T::SubAccountDeposit::get() * <BalanceOf<T>>::from(subs.len() as u32);477478 let not_other_sub = subs479 .iter()480 .filter_map(|i| SuperOf::<T>::get(&i.0))481 .all(|i| i.0 == sender);482 ensure!(not_other_sub, Error::<T>::AlreadyClaimed);483484 if old_deposit < new_deposit {485 T::Currency::reserve(&sender, new_deposit - old_deposit)?;486 } else if old_deposit > new_deposit {487 let err_amount = T::Currency::unreserve(&sender, old_deposit - new_deposit);488 debug_assert!(err_amount.is_zero());489 }490 // do nothing if they're equal.491492 for s in old_ids.iter() {493 <SuperOf<T>>::remove(s);494 }495 let mut ids = BoundedVec::<T::AccountId, T::MaxSubAccounts>::default();496 for (id, name) in subs {497 <SuperOf<T>>::insert(&id, (sender.clone(), name));498 ids.try_push(id)499 .expect("subs length is less than T::MaxSubAccounts; qed");500 }501 let new_subs = ids.len();502503 if ids.is_empty() {504 <SubsOf<T>>::remove(&sender);505 } else {506 <SubsOf<T>>::insert(&sender, (new_deposit, ids));507 }508509 Ok(Some(510 T::WeightInfo::set_subs_old(old_ids.len() as u32) // P: Real number of old accounts removed.511 // S: New subs added512 .saturating_add(T::WeightInfo::set_subs_new(new_subs as u32)),513 )514 .into())515 }516517 /// Clear an account's identity info and all sub-accounts and return all deposits.518 ///519 /// Payment: All reserved balances on the account are returned.520 ///521 /// The dispatch origin for this call must be _Signed_ and the sender must have a registered522 /// identity.523 ///524 /// Emits `IdentityCleared` if successful.525 ///526 /// # <weight>527 /// - `O(R + S + X)`528 /// - where `R` registrar-count (governance-bounded).529 /// - where `S` subs-count (hard- and deposit-bounded).530 /// - where `X` additional-field-count (deposit-bounded and code-bounded).531 /// - One balance-unreserve operation.532 /// - `2` storage reads and `S + 2` storage deletions.533 /// - One event.534 /// # </weight>535 #[pallet::call_index(3)]536 #[pallet::weight(T::WeightInfo::clear_identity(537 T::MaxRegistrars::get(), // R538 T::MaxSubAccounts::get(), // S539 T::MaxAdditionalFields::get(), // X540 ))]541 pub fn clear_identity(origin: OriginFor<T>) -> DispatchResultWithPostInfo {542 let sender = ensure_signed(origin)?;543544 let (subs_deposit, sub_ids) = <SubsOf<T>>::take(&sender);545 let id = <IdentityOf<T>>::take(&sender).ok_or(Error::<T>::NotNamed)?;546 let deposit = id.total_deposit() + subs_deposit;547 for sub in sub_ids.iter() {548 <SuperOf<T>>::remove(sub);549 }550551 let err_amount = T::Currency::unreserve(&sender, deposit);552 debug_assert!(err_amount.is_zero());553554 Self::deposit_event(Event::IdentityCleared {555 who: sender,556 deposit,557 });558559 Ok(Some(T::WeightInfo::clear_identity(560 id.judgements.len() as u32, // R561 sub_ids.len() as u32, // S562 id.info.additional.len() as u32, // X563 ))564 .into())565 }566567 /// Request a judgement from a registrar.568 ///569 /// Payment: At most `max_fee` will be reserved for payment to the registrar if judgement570 /// given.571 ///572 /// The dispatch origin for this call must be _Signed_ and the sender must have a573 /// registered identity.574 ///575 /// - `reg_index`: The index of the registrar whose judgement is requested.576 /// - `max_fee`: The maximum fee that may be paid. This should just be auto-populated as:577 ///578 /// ```nocompile579 /// Self::registrars().get(reg_index).unwrap().fee580 /// ```581 ///582 /// Emits `JudgementRequested` if successful.583 ///584 /// # <weight>585 /// - `O(R + X)`.586 /// - One balance-reserve operation.587 /// - Storage: 1 read `O(R)`, 1 mutate `O(X + R)`.588 /// - One event.589 /// # </weight>590 #[pallet::call_index(4)]591 #[pallet::weight(T::WeightInfo::request_judgement(592 T::MaxRegistrars::get(), // R593 T::MaxAdditionalFields::get(), // X594 ))]595 pub fn request_judgement(596 origin: OriginFor<T>,597 #[pallet::compact] reg_index: RegistrarIndex,598 #[pallet::compact] max_fee: BalanceOf<T>,599 ) -> DispatchResultWithPostInfo {600 let sender = ensure_signed(origin)?;601 let registrars = <Registrars<T>>::get();602 let registrar = registrars603 .get(reg_index as usize)604 .and_then(Option::as_ref)605 .ok_or(Error::<T>::EmptyIndex)?;606 ensure!(max_fee >= registrar.fee, Error::<T>::FeeChanged);607 let mut id = <IdentityOf<T>>::get(&sender).ok_or(Error::<T>::NoIdentity)?;608609 let item = (reg_index, Judgement::FeePaid(registrar.fee));610 match id.judgements.binary_search_by_key(®_index, |x| x.0) {611 Ok(i) => {612 if id.judgements[i].1.is_sticky() {613 return Err(Error::<T>::StickyJudgement.into());614 } else {615 id.judgements[i] = item616 }617 }618 Err(i) => id619 .judgements620 .try_insert(i, item)621 .map_err(|_| Error::<T>::TooManyRegistrars)?,622 }623624 T::Currency::reserve(&sender, registrar.fee)?;625626 let judgements = id.judgements.len();627 let extra_fields = id.info.additional.len();628 <IdentityOf<T>>::insert(&sender, id);629630 Self::deposit_event(Event::JudgementRequested {631 who: sender,632 registrar_index: reg_index,633 });634635 Ok(Some(T::WeightInfo::request_judgement(636 judgements as u32,637 extra_fields as u32,638 ))639 .into())640 }641642 /// Cancel a previous request.643 ///644 /// Payment: A previously reserved deposit is returned on success.645 ///646 /// The dispatch origin for this call must be _Signed_ and the sender must have a647 /// registered identity.648 ///649 /// - `reg_index`: The index of the registrar whose judgement is no longer requested.650 ///651 /// Emits `JudgementUnrequested` if successful.652 ///653 /// # <weight>654 /// - `O(R + X)`.655 /// - One balance-reserve operation.656 /// - One storage mutation `O(R + X)`.657 /// - One event658 /// # </weight>659 #[pallet::call_index(5)]660 #[pallet::weight(T::WeightInfo::cancel_request(661 T::MaxRegistrars::get(), // R662 T::MaxAdditionalFields::get(), // X663 ))]664 pub fn cancel_request(665 origin: OriginFor<T>,666 reg_index: RegistrarIndex,667 ) -> DispatchResultWithPostInfo {668 let sender = ensure_signed(origin)?;669 let mut id = <IdentityOf<T>>::get(&sender).ok_or(Error::<T>::NoIdentity)?;670671 let pos = id672 .judgements673 .binary_search_by_key(®_index, |x| x.0)674 .map_err(|_| Error::<T>::NotFound)?;675 let fee = if let Judgement::FeePaid(fee) = id.judgements.remove(pos).1 {676 fee677 } else {678 return Err(Error::<T>::JudgementGiven.into());679 };680681 let err_amount = T::Currency::unreserve(&sender, fee);682 debug_assert!(err_amount.is_zero());683 let judgements = id.judgements.len();684 let extra_fields = id.info.additional.len();685 <IdentityOf<T>>::insert(&sender, id);686687 Self::deposit_event(Event::JudgementUnrequested {688 who: sender,689 registrar_index: reg_index,690 });691692 Ok(Some(T::WeightInfo::cancel_request(693 judgements as u32,694 extra_fields as u32,695 ))696 .into())697 }698699 /// Set the fee required for a judgement to be requested from a registrar.700 ///701 /// The dispatch origin for this call must be _Signed_ and the sender must be the account702 /// of the registrar whose index is `index`.703 ///704 /// - `index`: the index of the registrar whose fee is to be set.705 /// - `fee`: the new fee.706 ///707 /// # <weight>708 /// - `O(R)`.709 /// - One storage mutation `O(R)`.710 /// - Benchmark: 7.315 + R * 0.329 µs (min squares analysis)711 /// # </weight>712 #[pallet::call_index(6)]713 #[pallet::weight(T::WeightInfo::set_fee(T::MaxRegistrars::get()))] // R714 pub fn set_fee(715 origin: OriginFor<T>,716 #[pallet::compact] index: RegistrarIndex,717 #[pallet::compact] fee: BalanceOf<T>,718 ) -> DispatchResultWithPostInfo {719 let who = ensure_signed(origin)?;720721 let registrars = <Registrars<T>>::mutate(|rs| -> Result<usize, DispatchError> {722 rs.get_mut(index as usize)723 .and_then(|x| x.as_mut())724 .and_then(|r| {725 if r.account == who {726 r.fee = fee;727 Some(())728 } else {729 None730 }731 })732 .ok_or_else(|| DispatchError::from(Error::<T>::InvalidIndex))?;733 Ok(rs.len())734 })?;735 Ok(Some(T::WeightInfo::set_fee(registrars as u32)).into()) // R736 }737738 /// Change the account associated with a registrar.739 ///740 /// The dispatch origin for this call must be _Signed_ and the sender must be the account741 /// of the registrar whose index is `index`.742 ///743 /// - `index`: the index of the registrar whose fee is to be set.744 /// - `new`: the new account ID.745 ///746 /// # <weight>747 /// - `O(R)`.748 /// - One storage mutation `O(R)`.749 /// - Benchmark: 8.823 + R * 0.32 µs (min squares analysis)750 /// # </weight>751 #[pallet::call_index(7)]752 #[pallet::weight(T::WeightInfo::set_account_id(T::MaxRegistrars::get()))] // R753 pub fn set_account_id(754 origin: OriginFor<T>,755 #[pallet::compact] index: RegistrarIndex,756 new: AccountIdLookupOf<T>,757 ) -> DispatchResultWithPostInfo {758 let who = ensure_signed(origin)?;759 let new = T::Lookup::lookup(new)?;760761 let registrars = <Registrars<T>>::mutate(|rs| -> Result<usize, DispatchError> {762 rs.get_mut(index as usize)763 .and_then(|x| x.as_mut())764 .and_then(|r| {765 if r.account == who {766 r.account = new;767 Some(())768 } else {769 None770 }771 })772 .ok_or_else(|| DispatchError::from(Error::<T>::InvalidIndex))?;773 Ok(rs.len())774 })?;775 Ok(Some(T::WeightInfo::set_account_id(registrars as u32)).into()) // R776 }777778 /// Set the field information for a registrar.779 ///780 /// The dispatch origin for this call must be _Signed_ and the sender must be the account781 /// of the registrar whose index is `index`.782 ///783 /// - `index`: the index of the registrar whose fee is to be set.784 /// - `fields`: the fields that the registrar concerns themselves with.785 ///786 /// # <weight>787 /// - `O(R)`.788 /// - One storage mutation `O(R)`.789 /// - Benchmark: 7.464 + R * 0.325 µs (min squares analysis)790 /// # </weight>791 #[pallet::call_index(8)]792 #[pallet::weight(T::WeightInfo::set_fields(T::MaxRegistrars::get()))] // R793 pub fn set_fields(794 origin: OriginFor<T>,795 #[pallet::compact] index: RegistrarIndex,796 fields: IdentityFields,797 ) -> DispatchResultWithPostInfo {798 let who = ensure_signed(origin)?;799800 let registrars = <Registrars<T>>::mutate(|rs| -> Result<usize, DispatchError> {801 rs.get_mut(index as usize)802 .and_then(|x| x.as_mut())803 .and_then(|r| {804 if r.account == who {805 r.fields = fields;806 Some(())807 } else {808 None809 }810 })811 .ok_or_else(|| DispatchError::from(Error::<T>::InvalidIndex))?;812 Ok(rs.len())813 })?;814 Ok(Some(T::WeightInfo::set_fields(815 registrars as u32, // R816 ))817 .into())818 }819820 /// Provide a judgement for an account's identity.821 ///822 /// The dispatch origin for this call must be _Signed_ and the sender must be the account823 /// of the registrar whose index is `reg_index`.824 ///825 /// - `reg_index`: the index of the registrar whose judgement is being made.826 /// - `target`: the account whose identity the judgement is upon. This must be an account827 /// with a registered identity.828 /// - `judgement`: the judgement of the registrar of index `reg_index` about `target`.829 /// - `identity`: The hash of the [`IdentityInfo`] for that the judgement is provided.830 ///831 /// Emits `JudgementGiven` if successful.832 ///833 /// # <weight>834 /// - `O(R + X)`.835 /// - One balance-transfer operation.836 /// - Up to one account-lookup operation.837 /// - Storage: 1 read `O(R)`, 1 mutate `O(R + X)`.838 /// - One event.839 /// # </weight>840 #[pallet::call_index(9)]841 #[pallet::weight(T::WeightInfo::provide_judgement(842 T::MaxRegistrars::get(), // R843 T::MaxAdditionalFields::get(), // X844 ))]845 pub fn provide_judgement(846 origin: OriginFor<T>,847 #[pallet::compact] reg_index: RegistrarIndex,848 target: AccountIdLookupOf<T>,849 judgement: Judgement<BalanceOf<T>>,850 identity: T::Hash,851 ) -> DispatchResultWithPostInfo {852 let sender = ensure_signed(origin)?;853 let target = T::Lookup::lookup(target)?;854 ensure!(!judgement.has_deposit(), Error::<T>::InvalidJudgement);855 <Registrars<T>>::get()856 .get(reg_index as usize)857 .and_then(Option::as_ref)858 .filter(|r| r.account == sender)859 .ok_or(Error::<T>::InvalidIndex)?;860 let mut id = <IdentityOf<T>>::get(&target).ok_or(Error::<T>::InvalidTarget)?;861862 if T::Hashing::hash_of(&id.info) != identity {863 return Err(Error::<T>::JudgementForDifferentIdentity.into());864 }865866 let item = (reg_index, judgement);867 match id.judgements.binary_search_by_key(®_index, |x| x.0) {868 Ok(position) => {869 if let Judgement::FeePaid(fee) = id.judgements[position].1 {870 T::Currency::repatriate_reserved(871 &target,872 &sender,873 fee,874 BalanceStatus::Free,875 )876 .map_err(|_| Error::<T>::JudgementPaymentFailed)?;877 }878 id.judgements[position] = item879 }880 Err(position) => id881 .judgements882 .try_insert(position, item)883 .map_err(|_| Error::<T>::TooManyRegistrars)?,884 }885886 let judgements = id.judgements.len();887 let extra_fields = id.info.additional.len();888 <IdentityOf<T>>::insert(&target, id);889 Self::deposit_event(Event::JudgementGiven {890 target,891 registrar_index: reg_index,892 });893894 Ok(Some(T::WeightInfo::provide_judgement(895 judgements as u32,896 extra_fields as u32,897 ))898 .into())899 }900901 /// Remove an account's identity and sub-account information and slash the deposits.902 ///903 /// Payment: Reserved balances from `set_subs` and `set_identity` are slashed and handled by904 /// `Slash`. Verification request deposits are not returned; they should be cancelled905 /// manually using `cancel_request`.906 ///907 /// The dispatch origin for this call must match `T::ForceOrigin`.908 ///909 /// - `target`: the account whose identity the judgement is upon. This must be an account910 /// with a registered identity.911 ///912 /// Emits `IdentityKilled` if successful.913 ///914 /// # <weight>915 /// - `O(R + S + X)`.916 /// - One balance-reserve operation.917 /// - `S + 2` storage mutations.918 /// - One event.919 /// # </weight>920 #[pallet::call_index(10)]921 #[pallet::weight(T::WeightInfo::kill_identity(922 T::MaxRegistrars::get(), // R923 T::MaxSubAccounts::get(), // S924 T::MaxAdditionalFields::get(), // X925 ))]926 pub fn kill_identity(927 origin: OriginFor<T>,928 target: AccountIdLookupOf<T>,929 ) -> DispatchResultWithPostInfo {930 T::ForceOrigin::ensure_origin(origin)?;931932 // Figure out who we're meant to be clearing.933 let target = T::Lookup::lookup(target)?;934 // Grab their deposit (and check that they have one).935 let (subs_deposit, sub_ids) = <SubsOf<T>>::take(&target);936 let id = <IdentityOf<T>>::take(&target).ok_or(Error::<T>::NotNamed)?;937 let deposit = id.total_deposit() + subs_deposit;938 for sub in sub_ids.iter() {939 <SuperOf<T>>::remove(sub);940 }941 // Slash their deposit from them.942 T::Slashed::on_unbalanced(T::Currency::slash_reserved(&target, deposit).0);943944 Self::deposit_event(Event::IdentityKilled {945 who: target,946 deposit,947 });948949 Ok(Some(T::WeightInfo::kill_identity(950 id.judgements.len() as u32, // R951 sub_ids.len() as u32, // S952 id.info.additional.len() as u32, // X953 ))954 .into())955 }956957 /// Add the given account to the sender's subs.958 ///959 /// Payment: Balance reserved by a previous `set_subs` call for one sub will be repatriated960 /// to the sender.961 ///962 /// The dispatch origin for this call must be _Signed_ and the sender must have a registered963 /// sub identity of `sub`.964 #[pallet::call_index(11)]965 #[pallet::weight(T::WeightInfo::add_sub(T::MaxSubAccounts::get()))]966 pub fn add_sub(967 origin: OriginFor<T>,968 sub: AccountIdLookupOf<T>,969 data: Data,970 ) -> DispatchResult {971 let sender = ensure_signed(origin)?;972 let sub = T::Lookup::lookup(sub)?;973 ensure!(974 IdentityOf::<T>::contains_key(&sender),975 Error::<T>::NoIdentity976 );977978 // Check if it's already claimed as sub-identity.979 ensure!(980 !SuperOf::<T>::contains_key(&sub),981 Error::<T>::AlreadyClaimed982 );983984 SubsOf::<T>::try_mutate(&sender, |(ref mut subs_deposit, ref mut sub_ids)| {985 // Ensure there is space and that the deposit is paid.986 ensure!(987 sub_ids.len() < T::MaxSubAccounts::get() as usize,988 Error::<T>::TooManySubAccounts989 );990 let deposit = T::SubAccountDeposit::get();991 T::Currency::reserve(&sender, deposit)?;992993 SuperOf::<T>::insert(&sub, (sender.clone(), data));994 sub_ids995 .try_push(sub.clone())996 .expect("sub ids length checked above; qed");997 *subs_deposit = subs_deposit.saturating_add(deposit);998999 Self::deposit_event(Event::SubIdentityAdded {1000 sub,1001 main: sender.clone(),1002 deposit,1003 });1004 Ok(())1005 })1006 }10071008 /// Alter the associated name of the given sub-account.1009 ///1010 /// The dispatch origin for this call must be _Signed_ and the sender must have a registered1011 /// sub identity of `sub`.1012 #[pallet::call_index(12)]1013 #[pallet::weight(T::WeightInfo::rename_sub(T::MaxSubAccounts::get()))]1014 pub fn rename_sub(1015 origin: OriginFor<T>,1016 sub: AccountIdLookupOf<T>,1017 data: Data,1018 ) -> DispatchResult {1019 let sender = ensure_signed(origin)?;1020 let sub = T::Lookup::lookup(sub)?;1021 ensure!(1022 IdentityOf::<T>::contains_key(&sender),1023 Error::<T>::NoIdentity1024 );1025 ensure!(1026 SuperOf::<T>::get(&sub).map_or(false, |x| x.0 == sender),1027 Error::<T>::NotOwned1028 );1029 SuperOf::<T>::insert(&sub, (sender, data));1030 Ok(())1031 }10321033 /// Remove the given account from the sender's subs.1034 ///1035 /// Payment: Balance reserved by a previous `set_subs` call for one sub will be repatriated1036 /// to the sender.1037 ///1038 /// The dispatch origin for this call must be _Signed_ and the sender must have a registered1039 /// sub identity of `sub`.1040 #[pallet::call_index(13)]1041 #[pallet::weight(T::WeightInfo::remove_sub(T::MaxSubAccounts::get()))]1042 pub fn remove_sub(origin: OriginFor<T>, sub: AccountIdLookupOf<T>) -> DispatchResult {1043 let sender = ensure_signed(origin)?;1044 ensure!(1045 IdentityOf::<T>::contains_key(&sender),1046 Error::<T>::NoIdentity1047 );1048 let sub = T::Lookup::lookup(sub)?;1049 let (sup, _) = SuperOf::<T>::get(&sub).ok_or(Error::<T>::NotSub)?;1050 ensure!(sup == sender, Error::<T>::NotOwned);1051 SuperOf::<T>::remove(&sub);1052 SubsOf::<T>::mutate(&sup, |(ref mut subs_deposit, ref mut sub_ids)| {1053 sub_ids.retain(|x| x != &sub);1054 let deposit = T::SubAccountDeposit::get().min(*subs_deposit);1055 *subs_deposit -= deposit;1056 let err_amount = T::Currency::unreserve(&sender, deposit);1057 debug_assert!(err_amount.is_zero());1058 Self::deposit_event(Event::SubIdentityRemoved {1059 sub,1060 main: sender,1061 deposit,1062 });1063 });1064 Ok(())1065 }10661067 /// Remove the sender as a sub-account.1068 ///1069 /// Payment: Balance reserved by a previous `set_subs` call for one sub will be repatriated1070 /// to the sender (*not* the original depositor).1071 ///1072 /// The dispatch origin for this call must be _Signed_ and the sender must have a registered1073 /// super-identity.1074 ///1075 /// NOTE: This should not normally be used, but is provided in the case that the non-1076 /// controller of an account is maliciously registered as a sub-account.1077 #[pallet::call_index(14)]1078 #[pallet::weight(T::WeightInfo::quit_sub(T::MaxSubAccounts::get()))]1079 pub fn quit_sub(origin: OriginFor<T>) -> DispatchResult {1080 let sender = ensure_signed(origin)?;1081 let (sup, _) = SuperOf::<T>::take(&sender).ok_or(Error::<T>::NotSub)?;1082 SubsOf::<T>::mutate(&sup, |(ref mut subs_deposit, ref mut sub_ids)| {1083 sub_ids.retain(|x| x != &sender);1084 let deposit = T::SubAccountDeposit::get().min(*subs_deposit);1085 *subs_deposit -= deposit;1086 let _ =1087 T::Currency::repatriate_reserved(&sup, &sender, deposit, BalanceStatus::Free);1088 Self::deposit_event(Event::SubIdentityRevoked {1089 sub: sender,1090 main: sup.clone(),1091 deposit,1092 });1093 });1094 Ok(())1095 }10961097 /// Set identities to be associated with the provided accounts as force origin.1098 ///1099 /// This is not meant to operate in tandem with the identity pallet as is,1100 /// and be instead used to keep identities made and verified externally,1101 /// forbidden from interacting with an ordinary user, since it ignores any safety mechanism.1102 #[pallet::call_index(15)]1103 #[pallet::weight(T::WeightInfo::force_insert_identities(1104 T::MaxAdditionalFields::get(), // X1105 identities.len() as u32, // N1106 ))]1107 pub fn force_insert_identities(1108 origin: OriginFor<T>,1109 identities: Vec<(1110 T::AccountId,1111 Registration<BalanceOf<T>, T::MaxRegistrars, T::MaxAdditionalFields>,1112 )>,1113 ) -> DispatchResult {1114 T::ForceOrigin::ensure_origin(origin)?;1115 for identity in identities.clone() {1116 IdentityOf::<T>::insert(identity.0, identity.1);1117 }1118 Self::deposit_event(Event::IdentitiesInserted {1119 amount: identities.len() as u32,1120 });1121 Ok(())1122 }11231124 /// Remove identities associated with the provided accounts as force origin.1125 ///1126 /// This is not meant to operate in tandem with the identity pallet as is,1127 /// and be instead used to keep identities made and verified externally,1128 /// forbidden from interacting with an ordinary user, since it ignores any safety mechanism.1129 #[pallet::call_index(16)]1130 #[pallet::weight(T::WeightInfo::force_remove_identities(1131 T::MaxAdditionalFields::get(), // X1132 identities.len() as u32, // N1133 ))]1134 pub fn force_remove_identities(1135 origin: OriginFor<T>,1136 identities: Vec<T::AccountId>,1137 ) -> DispatchResult {1138 T::ForceOrigin::ensure_origin(origin)?;1139 for identity in identities.clone() {1140 IdentityOf::<T>::set(identity, None);1141 }1142 Self::deposit_event(Event::IdentitiesRemoved {1143 amount: identities.len() as u32,1144 });1145 Ok(())1146 }1147 }1148}11491150impl<T: Config> Pallet<T> {1151 /// Get the subs of an account.1152 pub fn subs(who: &T::AccountId) -> Vec<(T::AccountId, Data)> {1153 SubsOf::<T>::get(who)1154 .11155 .into_iter()1156 .filter_map(|a| SuperOf::<T>::get(&a).map(|x| (a, x.1)))1157 .collect()1158 }11591160 /// Check if the account has corresponding identity information by the identity field.1161 pub fn has_identity(who: &T::AccountId, fields: u64) -> bool {1162 IdentityOf::<T>::get(who).map_or(false, |registration| {1163 (registration.info.fields().0.bits() & fields) == fields1164 })1165 }1166}pallets/identity/src/weights.rsdiffbeforeafterboth--- a/pallets/identity/src/weights.rs
+++ b/pallets/identity/src/weights.rs
@@ -78,6 +78,7 @@
fn kill_identity(r: u32, s: u32, x: u32, ) -> Weight;
fn force_insert_identities(x: u32, n: u32, ) -> Weight;
fn force_remove_identities(x: u32, n: u32, ) -> Weight;
+ fn force_set_subs(s: u32, n: u32, ) -> Weight;
fn add_sub(s: u32, ) -> Weight;
fn rename_sub(s: u32, ) -> Weight;
fn remove_sub(s: u32, ) -> Weight;
@@ -273,6 +274,20 @@
.saturating_add(T::DbWeight::get().reads(1 as u64))
.saturating_add(T::DbWeight::get().writes(1 as u64).saturating_mul(n as u64))
}
+ // Storage: Identity IdentityOf (r:1 w:1)
+ // todo:collator
+ /// The range of component `s` is `[0, 100]`.
+ /// The range of component `n` is `[0, 600]`.
+ fn force_set_subs(s: u32, n: u32) -> Weight {
+ // Minimum execution time: 41_872 nanoseconds.
+ Weight::from_ref_time(40_230_216 as u64)
+ // Standard Error: 2_342
+ .saturating_add(Weight::from_ref_time(145_168 as u64))
+ // Standard Error: 457
+ .saturating_add(Weight::from_ref_time(291_732 as u64).saturating_mul(s as u64))
+ .saturating_add(T::DbWeight::get().reads(1 as u64))
+ .saturating_add(T::DbWeight::get().writes(1 as u64).saturating_mul(n as u64))
+ }
// Storage: Identity IdentityOf (r:1 w:0)
// Storage: Identity SuperOf (r:1 w:1)
// Storage: Identity SubsOf (r:1 w:1)
@@ -509,6 +524,20 @@
.saturating_add(RocksDbWeight::get().reads(1 as u64))
.saturating_add(RocksDbWeight::get().writes(1 as u64).saturating_mul(n as u64))
}
+ // Storage: Identity IdentityOf (r:1 w:1)
+ // todo:collator
+ /// The range of component `xs is `[0, 100]`.
+ /// The range of component `n` is `[0, 600]`.
+ fn force_set_subs(s: u32, n: u32) -> Weight {
+ // Minimum execution time: 41_872 nanoseconds.
+ Weight::from_ref_time(40_230_216 as u64)
+ // Standard Error: 2_342
+ .saturating_add(Weight::from_ref_time(145_168 as u64))
+ // Standard Error: 457
+ .saturating_add(Weight::from_ref_time(291_732 as u64).saturating_mul(s as u64))
+ .saturating_add(RocksDbWeight::get().reads(1 as u64))
+ .saturating_add(RocksDbWeight::get().writes(1 as u64).saturating_mul(n as u64))
+ }
// Storage: Identity IdentityOf (r:1 w:0)
// Storage: Identity SuperOf (r:1 w:1)
// Storage: Identity SubsOf (r:1 w:1)