difftreelog
feat nest on create/transfer
in: master
12 files changed
pallets/common/src/lib.rsdiffbeforeafterboth--- a/pallets/common/src/lib.rs
+++ b/pallets/common/src/lib.rs
@@ -723,17 +723,20 @@
sender: T::CrossAccountId,
to: T::CrossAccountId,
data: CreateItemData,
+ nesting_budget: &dyn Budget,
) -> DispatchResultWithPostInfo;
fn create_multiple_items(
&self,
sender: T::CrossAccountId,
to: T::CrossAccountId,
data: Vec<CreateItemData>,
+ nesting_budget: &dyn Budget,
) -> DispatchResultWithPostInfo;
fn create_multiple_items_ex(
&self,
sender: T::CrossAccountId,
data: CreateItemExData<T::CrossAccountId>,
+ nesting_budget: &dyn Budget,
) -> DispatchResultWithPostInfo;
fn burn_item(
&self,
@@ -748,6 +751,7 @@
to: T::CrossAccountId,
token: TokenId,
amount: u128,
+ nesting_budget: &dyn Budget,
) -> DispatchResultWithPostInfo;
fn approve(
&self,
@@ -781,11 +785,12 @@
data: BoundedVec<u8, CustomDataLimit>,
) -> DispatchResultWithPostInfo;
- fn nest_token(
+ fn check_nesting(
&self,
sender: T::CrossAccountId,
- from: (CollectionId, TokenId),
+ from: CollectionId,
under: TokenId,
+ budget: &dyn Budget,
) -> DispatchResult;
fn account_tokens(&self, account: T::CrossAccountId) -> Vec<TokenId>;
pallets/evm-coder-substrate/src/lib.rsdiffbeforeafterboth--- a/pallets/evm-coder-substrate/src/lib.rs
+++ b/pallets/evm-coder-substrate/src/lib.rs
@@ -55,7 +55,6 @@
use frame_system::ensure_signed;
pub use frame_support::dispatch::DispatchResult;
- use frame_support::{pallet_prelude::*, traits::PalletInfo};
use frame_system::pallet_prelude::*;
/// DispatchError is opaque, but we need to somehow extract correct error in case of OutOfGas failure
pallets/fungible/src/common.rsdiffbeforeafterboth--- a/pallets/fungible/src/common.rs
+++ b/pallets/fungible/src/common.rs
@@ -17,7 +17,7 @@
use core::marker::PhantomData;
use frame_support::{dispatch::DispatchResultWithPostInfo, ensure, fail, weights::Weight, BoundedVec};
-use up_data_structs::{TokenId, CreateItemExData, budget::Budget};
+use up_data_structs::{TokenId, CollectionId, CreateItemExData, budget::Budget};
use pallet_common::{CommonCollectionOperations, CommonWeightInfo, with_weight};
use sp_runtime::ArithmeticError;
use sp_std::{vec::Vec, vec};
@@ -78,10 +78,11 @@
sender: T::CrossAccountId,
to: T::CrossAccountId,
data: up_data_structs::CreateItemData,
+ nesting_budget: &dyn Budget,
) -> DispatchResultWithPostInfo {
match data {
up_data_structs::CreateItemData::Fungible(data) => with_weight(
- <Pallet<T>>::create_item(self, &sender, (to, data.value)),
+ <Pallet<T>>::create_item(self, &sender, (to, data.value), nesting_budget),
<CommonWeights<T>>::create_item(),
),
_ => fail!(<Error<T>>::NotFungibleDataUsedToMintFungibleCollectionToken),
@@ -93,6 +94,7 @@
sender: T::CrossAccountId,
to: T::CrossAccountId,
data: Vec<up_data_structs::CreateItemData>,
+ nesting_budget: &dyn Budget,
) -> DispatchResultWithPostInfo {
let mut sum: u128 = 0;
for data in data {
@@ -107,7 +109,7 @@
}
with_weight(
- <Pallet<T>>::create_item(self, &sender, (to, sum)),
+ <Pallet<T>>::create_item(self, &sender, (to, sum), nesting_budget),
<CommonWeights<T>>::create_item(),
)
}
@@ -116,6 +118,7 @@
&self,
sender: <T>::CrossAccountId,
data: up_data_structs::CreateItemExData<<T>::CrossAccountId>,
+ nesting_budget: &dyn Budget,
) -> DispatchResultWithPostInfo {
let weight = <CommonWeights<T>>::create_multiple_items_ex(&data);
let data = match data {
@@ -124,7 +127,7 @@
};
with_weight(
- <Pallet<T>>::create_multiple_items(self, &sender, data.into_inner()),
+ <Pallet<T>>::create_multiple_items(self, &sender, data.into_inner(), nesting_budget),
weight,
)
}
@@ -152,6 +155,7 @@
to: T::CrossAccountId,
token: TokenId,
amount: u128,
+ nesting_budget: &dyn Budget,
) -> DispatchResultWithPostInfo {
ensure!(
token == TokenId::default(),
@@ -159,7 +163,7 @@
);
with_weight(
- <Pallet<T>>::transfer(self, &from, &to, amount),
+ <Pallet<T>>::transfer(self, &from, &to, amount, nesting_budget),
<CommonWeights<T>>::transfer(),
)
}
@@ -230,11 +234,12 @@
fail!(<Error<T>>::FungibleItemsDontHaveData)
}
- fn nest_token(
+ fn check_nesting(
&self,
_sender: <T>::CrossAccountId,
- _from: (up_data_structs::CollectionId, TokenId),
+ _from: CollectionId,
_under: TokenId,
+ _budget: &dyn Budget,
) -> sp_runtime::DispatchResult {
fail!(<Error<T>>::FungibleDisallowsNesting)
}
pallets/fungible/src/erc.rsdiffbeforeafterboth--- a/pallets/fungible/src/erc.rs
+++ b/pallets/fungible/src/erc.rs
@@ -81,8 +81,11 @@
let caller = T::CrossAccountId::from_eth(caller);
let to = T::CrossAccountId::from_eth(to);
let amount = amount.try_into().map_err(|_| "amount overflow")?;
+ let budget = self
+ .recorder
+ .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::transfer(self, &caller, &to, amount).map_err(|_| "transfer error")?;
+ <Pallet<T>>::transfer(self, &caller, &to, amount, &budget).map_err(|_| "transfer error")?;
Ok(true)
}
#[weight(<SelfWeightOf<T>>::transfer_from())]
pallets/fungible/src/lib.rsdiffbeforeafterboth--- a/pallets/fungible/src/lib.rs
+++ b/pallets/fungible/src/lib.rs
@@ -193,6 +193,7 @@
from: &T::CrossAccountId,
to: &T::CrossAccountId,
amount: u128,
+ nesting_budget: &dyn Budget,
) -> DispatchResult {
ensure!(
collection.limits.transfers_enabled(),
@@ -222,12 +223,12 @@
let handle = <CollectionHandle<T>>::try_get(target.0)?;
let dispatch = T::CollectionDispatch::dispatch(handle);
let dispatch = dispatch.as_dyn();
-
- // =========
- dispatch.nest_token(from.clone(), (collection.id, TokenId::default()), target.1)?;
+ dispatch.check_nesting(from.clone(), collection.id, target.1, nesting_budget)?;
}
+ // =========
+
if let Some(balance_to) = balance_to {
// from != to
if balance_from == 0 {
@@ -257,6 +258,7 @@
collection: &FungibleHandle<T>,
sender: &T::CrossAccountId,
data: BTreeMap<T::CrossAccountId, u128>,
+ nesting_budget: &dyn Budget,
) -> DispatchResult {
if !collection.is_owner_or_admin(sender) {
ensure!(
@@ -285,6 +287,16 @@
.ok_or(ArithmeticError::Overflow)?;
}
+ for (to, _) in balances.iter() {
+ if let Some(target) = T::CrossTokenAddressMapping::address_to_token(to) {
+ let handle = <CollectionHandle<T>>::try_get(target.0)?;
+ let dispatch = T::CollectionDispatch::dispatch(handle);
+ let dispatch = dispatch.as_dyn();
+
+ dispatch.check_nesting(sender.clone(), collection.id, target.1, nesting_budget)?;
+ }
+ }
+
// =========
<TotalSupply<T>>::insert(collection.id, total_supply);
@@ -407,7 +419,7 @@
// =========
- Self::transfer(collection, from, to, amount)?;
+ Self::transfer(collection, from, to, amount, nesting_budget)?;
if let Some(allowance) = allowance {
Self::set_allowance_unchecked(collection, from, spender, allowance);
}
@@ -437,7 +449,13 @@
collection: &FungibleHandle<T>,
sender: &T::CrossAccountId,
data: CreateItemData<T>,
+ nesting_budget: &dyn Budget,
) -> DispatchResult {
- Self::create_multiple_items(collection, sender, [(data.0, data.1)].into_iter().collect())
+ Self::create_multiple_items(
+ collection,
+ sender,
+ [(data.0, data.1)].into_iter().collect(),
+ nesting_budget,
+ )
}
}
pallets/nonfungible/src/common.rsdiffbeforeafterboth1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617use core::marker::PhantomData;1819use frame_support::{dispatch::DispatchResultWithPostInfo, ensure, fail, weights::Weight, BoundedVec};20use up_data_structs::{TokenId, CustomDataLimit, CreateItemExData, CollectionId, budget::Budget};21use pallet_common::{CommonCollectionOperations, CommonWeightInfo, with_weight};22use sp_runtime::DispatchError;23use sp_std::vec::Vec;2425use crate::{26 AccountBalance, Allowance, Config, CreateItemData, Error, NonfungibleHandle, Owned, Pallet,27 SelfWeightOf, TokenData, weights::WeightInfo, TokensMinted,28};2930pub struct CommonWeights<T: Config>(PhantomData<T>);31impl<T: Config> CommonWeightInfo<T::CrossAccountId> for CommonWeights<T> {32 fn create_item() -> Weight {33 <SelfWeightOf<T>>::create_item()34 }3536 fn create_multiple_items_ex(data: &CreateItemExData<T::CrossAccountId>) -> Weight {37 match data {38 CreateItemExData::NFT(t) => <SelfWeightOf<T>>::create_multiple_items_ex(t.len() as u32),39 _ => 0,40 }41 }4243 fn create_multiple_items(amount: u32) -> Weight {44 <SelfWeightOf<T>>::create_multiple_items(amount)45 }4647 fn burn_item() -> Weight {48 <SelfWeightOf<T>>::burn_item()49 }5051 fn transfer() -> Weight {52 <SelfWeightOf<T>>::transfer()53 }5455 fn approve() -> Weight {56 <SelfWeightOf<T>>::approve()57 }5859 fn transfer_from() -> Weight {60 <SelfWeightOf<T>>::transfer_from()61 }6263 fn burn_from() -> Weight {64 <SelfWeightOf<T>>::burn_from()65 }6667 fn set_variable_metadata(bytes: u32) -> Weight {68 <SelfWeightOf<T>>::set_variable_metadata(bytes)69 }70}7172fn map_create_data<T: Config>(73 data: up_data_structs::CreateItemData,74 to: &T::CrossAccountId,75) -> Result<CreateItemData<T>, DispatchError> {76 match data {77 up_data_structs::CreateItemData::NFT(data) => Ok(CreateItemData::<T> {78 const_data: data.const_data,79 variable_data: data.variable_data,80 owner: to.clone(),81 }),82 _ => fail!(<Error<T>>::NotNonfungibleDataUsedToMintFungibleCollectionToken),83 }84}8586impl<T: Config> CommonCollectionOperations<T> for NonfungibleHandle<T> {87 fn create_item(88 &self,89 sender: T::CrossAccountId,90 to: T::CrossAccountId,91 data: up_data_structs::CreateItemData,92 ) -> DispatchResultWithPostInfo {93 with_weight(94 <Pallet<T>>::create_item(self, &sender, map_create_data::<T>(data, &to)?),95 <CommonWeights<T>>::create_item(),96 )97 }9899 fn create_multiple_items(100 &self,101 sender: T::CrossAccountId,102 to: T::CrossAccountId,103 data: Vec<up_data_structs::CreateItemData>,104 ) -> DispatchResultWithPostInfo {105 let data = data106 .into_iter()107 .map(|d| map_create_data::<T>(d, &to))108 .collect::<Result<Vec<_>, DispatchError>>()?;109110 let amount = data.len();111 with_weight(112 <Pallet<T>>::create_multiple_items(self, &sender, data),113 <CommonWeights<T>>::create_multiple_items(amount as u32),114 )115 }116117 fn create_multiple_items_ex(118 &self,119 sender: <T>::CrossAccountId,120 data: up_data_structs::CreateItemExData<<T>::CrossAccountId>,121 ) -> DispatchResultWithPostInfo {122 let weight = <CommonWeights<T>>::create_multiple_items_ex(&data);123 let data = match data {124 up_data_structs::CreateItemExData::NFT(nft) => nft,125 _ => fail!(Error::<T>::NotNonfungibleDataUsedToMintFungibleCollectionToken),126 };127128 with_weight(129 <Pallet<T>>::create_multiple_items(self, &sender, data.into_inner()),130 weight,131 )132 }133134 fn burn_item(135 &self,136 sender: T::CrossAccountId,137 token: TokenId,138 amount: u128,139 ) -> DispatchResultWithPostInfo {140 ensure!(amount <= 1, <Error<T>>::NonfungibleItemsHaveNoAmount);141 if amount == 1 {142 with_weight(143 <Pallet<T>>::burn(self, &sender, token),144 <CommonWeights<T>>::burn_item(),145 )146 } else {147 Ok(().into())148 }149 }150151 fn transfer(152 &self,153 from: T::CrossAccountId,154 to: T::CrossAccountId,155 token: TokenId,156 amount: u128,157 ) -> DispatchResultWithPostInfo {158 ensure!(amount <= 1, <Error<T>>::NonfungibleItemsHaveNoAmount);159 if amount == 1 {160 with_weight(161 <Pallet<T>>::transfer(self, &from, &to, token),162 <CommonWeights<T>>::transfer(),163 )164 } else {165 Ok(().into())166 }167 }168169 fn approve(170 &self,171 sender: T::CrossAccountId,172 spender: T::CrossAccountId,173 token: TokenId,174 amount: u128,175 ) -> DispatchResultWithPostInfo {176 ensure!(amount <= 1, <Error<T>>::NonfungibleItemsHaveNoAmount);177178 with_weight(179 if amount == 1 {180 <Pallet<T>>::set_allowance(self, &sender, token, Some(&spender))181 } else {182 <Pallet<T>>::set_allowance(self, &sender, token, None)183 },184 <CommonWeights<T>>::approve(),185 )186 }187188 fn transfer_from(189 &self,190 sender: T::CrossAccountId,191 from: T::CrossAccountId,192 to: T::CrossAccountId,193 token: TokenId,194 amount: u128,195 nesting_budget: &dyn Budget,196 ) -> DispatchResultWithPostInfo {197 ensure!(amount <= 1, <Error<T>>::NonfungibleItemsHaveNoAmount);198199 if amount == 1 {200 with_weight(201 <Pallet<T>>::transfer_from(self, &sender, &from, &to, token, nesting_budget),202 <CommonWeights<T>>::transfer_from(),203 )204 } else {205 Ok(().into())206 }207 }208209 fn burn_from(210 &self,211 sender: T::CrossAccountId,212 from: T::CrossAccountId,213 token: TokenId,214 amount: u128,215 nesting_budget: &dyn Budget,216 ) -> DispatchResultWithPostInfo {217 ensure!(amount <= 1, <Error<T>>::NonfungibleItemsHaveNoAmount);218219 if amount == 1 {220 with_weight(221 <Pallet<T>>::burn_from(self, &sender, &from, token, nesting_budget),222 <CommonWeights<T>>::burn_from(),223 )224 } else {225 Ok(().into())226 }227 }228229 fn set_variable_metadata(230 &self,231 sender: T::CrossAccountId,232 token: TokenId,233 data: BoundedVec<u8, CustomDataLimit>,234 ) -> DispatchResultWithPostInfo {235 let len = data.len();236 with_weight(237 <Pallet<T>>::set_variable_metadata(self, &sender, token, data),238 <CommonWeights<T>>::set_variable_metadata(len as u32),239 )240 }241242 fn nest_token(243 &self,244 sender: T::CrossAccountId,245 (from, _): (CollectionId, TokenId),246 under: TokenId,247 ) -> sp_runtime::DispatchResult {248 <Pallet<T>>::nest_token(self, sender, from, under)249 }250251 fn account_tokens(&self, account: T::CrossAccountId) -> Vec<TokenId> {252 <Owned<T>>::iter_prefix((self.id, account))253 .map(|(id, _)| id)254 .collect()255 }256257 fn token_exists(&self, token: TokenId) -> bool {258 <Pallet<T>>::token_exists(self, token)259 }260261 fn last_token_id(&self) -> TokenId {262 TokenId(<TokensMinted<T>>::get(self.id))263 }264265 fn token_owner(&self, token: TokenId) -> Option<T::CrossAccountId> {266 <TokenData<T>>::get((self.id, token)).map(|t| t.owner)267 }268 fn const_metadata(&self, token: TokenId) -> Vec<u8> {269 <TokenData<T>>::get((self.id, token))270 .map(|t| t.const_data)271 .unwrap_or_default()272 .into_inner()273 }274 fn variable_metadata(&self, token: TokenId) -> Vec<u8> {275 <TokenData<T>>::get((self.id, token))276 .map(|t| t.variable_data)277 .unwrap_or_default()278 .into_inner()279 }280281 fn collection_tokens(&self) -> u32 {282 <Pallet<T>>::total_supply(self)283 }284285 fn account_balance(&self, account: T::CrossAccountId) -> u32 {286 <AccountBalance<T>>::get((self.id, account))287 }288289 fn balance(&self, account: T::CrossAccountId, token: TokenId) -> u128 {290 if <TokenData<T>>::get((self.id, token))291 .map(|a| a.owner == account)292 .unwrap_or(false)293 {294 1295 } else {296 0297 }298 }299300 fn allowance(301 &self,302 sender: T::CrossAccountId,303 spender: T::CrossAccountId,304 token: TokenId,305 ) -> u128 {306 if <TokenData<T>>::get((self.id, token))307 .map(|a| a.owner != sender)308 .unwrap_or(true)309 {310 0311 } else if <Allowance<T>>::get((self.id, token)) == Some(spender) {312 1313 } else {314 0315 }316 }317}1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617use core::marker::PhantomData;1819use frame_support::{dispatch::DispatchResultWithPostInfo, ensure, fail, weights::Weight, BoundedVec};20use up_data_structs::{TokenId, CustomDataLimit, CreateItemExData, CollectionId, budget::Budget};21use pallet_common::{CommonCollectionOperations, CommonWeightInfo, with_weight};22use sp_runtime::DispatchError;23use sp_std::vec::Vec;2425use crate::{26 AccountBalance, Allowance, Config, CreateItemData, Error, NonfungibleHandle, Owned, Pallet,27 SelfWeightOf, TokenData, weights::WeightInfo, TokensMinted,28};2930pub struct CommonWeights<T: Config>(PhantomData<T>);31impl<T: Config> CommonWeightInfo<T::CrossAccountId> for CommonWeights<T> {32 fn create_item() -> Weight {33 <SelfWeightOf<T>>::create_item()34 }3536 fn create_multiple_items_ex(data: &CreateItemExData<T::CrossAccountId>) -> Weight {37 match data {38 CreateItemExData::NFT(t) => <SelfWeightOf<T>>::create_multiple_items_ex(t.len() as u32),39 _ => 0,40 }41 }4243 fn create_multiple_items(amount: u32) -> Weight {44 <SelfWeightOf<T>>::create_multiple_items(amount)45 }4647 fn burn_item() -> Weight {48 <SelfWeightOf<T>>::burn_item()49 }5051 fn transfer() -> Weight {52 <SelfWeightOf<T>>::transfer()53 }5455 fn approve() -> Weight {56 <SelfWeightOf<T>>::approve()57 }5859 fn transfer_from() -> Weight {60 <SelfWeightOf<T>>::transfer_from()61 }6263 fn burn_from() -> Weight {64 <SelfWeightOf<T>>::burn_from()65 }6667 fn set_variable_metadata(bytes: u32) -> Weight {68 <SelfWeightOf<T>>::set_variable_metadata(bytes)69 }70}7172fn map_create_data<T: Config>(73 data: up_data_structs::CreateItemData,74 to: &T::CrossAccountId,75) -> Result<CreateItemData<T>, DispatchError> {76 match data {77 up_data_structs::CreateItemData::NFT(data) => Ok(CreateItemData::<T> {78 const_data: data.const_data,79 variable_data: data.variable_data,80 owner: to.clone(),81 }),82 _ => fail!(<Error<T>>::NotNonfungibleDataUsedToMintFungibleCollectionToken),83 }84}8586impl<T: Config> CommonCollectionOperations<T> for NonfungibleHandle<T> {87 fn create_item(88 &self,89 sender: T::CrossAccountId,90 to: T::CrossAccountId,91 data: up_data_structs::CreateItemData,92 nesting_budget: &dyn Budget,93 ) -> DispatchResultWithPostInfo {94 with_weight(95 <Pallet<T>>::create_item(96 self,97 &sender,98 map_create_data::<T>(data, &to)?,99 nesting_budget,100 ),101 <CommonWeights<T>>::create_item(),102 )103 }104105 fn create_multiple_items(106 &self,107 sender: T::CrossAccountId,108 to: T::CrossAccountId,109 data: Vec<up_data_structs::CreateItemData>,110 nesting_budget: &dyn Budget,111 ) -> DispatchResultWithPostInfo {112 let data = data113 .into_iter()114 .map(|d| map_create_data::<T>(d, &to))115 .collect::<Result<Vec<_>, DispatchError>>()?;116117 let amount = data.len();118 with_weight(119 <Pallet<T>>::create_multiple_items(self, &sender, data, nesting_budget),120 <CommonWeights<T>>::create_multiple_items(amount as u32),121 )122 }123124 fn create_multiple_items_ex(125 &self,126 sender: <T>::CrossAccountId,127 data: up_data_structs::CreateItemExData<<T>::CrossAccountId>,128 nesting_budget: &dyn Budget,129 ) -> DispatchResultWithPostInfo {130 let weight = <CommonWeights<T>>::create_multiple_items_ex(&data);131 let data = match data {132 up_data_structs::CreateItemExData::NFT(nft) => nft,133 _ => fail!(Error::<T>::NotNonfungibleDataUsedToMintFungibleCollectionToken),134 };135136 with_weight(137 <Pallet<T>>::create_multiple_items(self, &sender, data.into_inner(), nesting_budget),138 weight,139 )140 }141142 fn burn_item(143 &self,144 sender: T::CrossAccountId,145 token: TokenId,146 amount: u128,147 ) -> DispatchResultWithPostInfo {148 ensure!(amount <= 1, <Error<T>>::NonfungibleItemsHaveNoAmount);149 if amount == 1 {150 with_weight(151 <Pallet<T>>::burn(self, &sender, token),152 <CommonWeights<T>>::burn_item(),153 )154 } else {155 Ok(().into())156 }157 }158159 fn transfer(160 &self,161 from: T::CrossAccountId,162 to: T::CrossAccountId,163 token: TokenId,164 amount: u128,165 nesting_budget: &dyn Budget,166 ) -> DispatchResultWithPostInfo {167 ensure!(amount <= 1, <Error<T>>::NonfungibleItemsHaveNoAmount);168 if amount == 1 {169 with_weight(170 <Pallet<T>>::transfer(self, &from, &to, token, nesting_budget),171 <CommonWeights<T>>::transfer(),172 )173 } else {174 Ok(().into())175 }176 }177178 fn approve(179 &self,180 sender: T::CrossAccountId,181 spender: T::CrossAccountId,182 token: TokenId,183 amount: u128,184 ) -> DispatchResultWithPostInfo {185 ensure!(amount <= 1, <Error<T>>::NonfungibleItemsHaveNoAmount);186187 with_weight(188 if amount == 1 {189 <Pallet<T>>::set_allowance(self, &sender, token, Some(&spender))190 } else {191 <Pallet<T>>::set_allowance(self, &sender, token, None)192 },193 <CommonWeights<T>>::approve(),194 )195 }196197 fn transfer_from(198 &self,199 sender: T::CrossAccountId,200 from: T::CrossAccountId,201 to: T::CrossAccountId,202 token: TokenId,203 amount: u128,204 nesting_budget: &dyn Budget,205 ) -> DispatchResultWithPostInfo {206 ensure!(amount <= 1, <Error<T>>::NonfungibleItemsHaveNoAmount);207208 if amount == 1 {209 with_weight(210 <Pallet<T>>::transfer_from(self, &sender, &from, &to, token, nesting_budget),211 <CommonWeights<T>>::transfer_from(),212 )213 } else {214 Ok(().into())215 }216 }217218 fn burn_from(219 &self,220 sender: T::CrossAccountId,221 from: T::CrossAccountId,222 token: TokenId,223 amount: u128,224 nesting_budget: &dyn Budget,225 ) -> DispatchResultWithPostInfo {226 ensure!(amount <= 1, <Error<T>>::NonfungibleItemsHaveNoAmount);227228 if amount == 1 {229 with_weight(230 <Pallet<T>>::burn_from(self, &sender, &from, token, nesting_budget),231 <CommonWeights<T>>::burn_from(),232 )233 } else {234 Ok(().into())235 }236 }237238 fn set_variable_metadata(239 &self,240 sender: T::CrossAccountId,241 token: TokenId,242 data: BoundedVec<u8, CustomDataLimit>,243 ) -> DispatchResultWithPostInfo {244 let len = data.len();245 with_weight(246 <Pallet<T>>::set_variable_metadata(self, &sender, token, data),247 <CommonWeights<T>>::set_variable_metadata(len as u32),248 )249 }250251 fn check_nesting(252 &self,253 sender: T::CrossAccountId,254 from: CollectionId,255 under: TokenId,256 budget: &dyn Budget,257 ) -> sp_runtime::DispatchResult {258 <Pallet<T>>::check_nesting(self, sender, from, under, budget)259 }260261 fn account_tokens(&self, account: T::CrossAccountId) -> Vec<TokenId> {262 <Owned<T>>::iter_prefix((self.id, account))263 .map(|(id, _)| id)264 .collect()265 }266267 fn token_exists(&self, token: TokenId) -> bool {268 <Pallet<T>>::token_exists(self, token)269 }270271 fn last_token_id(&self) -> TokenId {272 TokenId(<TokensMinted<T>>::get(self.id))273 }274275 fn token_owner(&self, token: TokenId) -> Option<T::CrossAccountId> {276 <TokenData<T>>::get((self.id, token)).map(|t| t.owner)277 }278 fn const_metadata(&self, token: TokenId) -> Vec<u8> {279 <TokenData<T>>::get((self.id, token))280 .map(|t| t.const_data)281 .unwrap_or_default()282 .into_inner()283 }284 fn variable_metadata(&self, token: TokenId) -> Vec<u8> {285 <TokenData<T>>::get((self.id, token))286 .map(|t| t.variable_data)287 .unwrap_or_default()288 .into_inner()289 }290291 fn collection_tokens(&self) -> u32 {292 <Pallet<T>>::total_supply(self)293 }294295 fn account_balance(&self, account: T::CrossAccountId) -> u32 {296 <AccountBalance<T>>::get((self.id, account))297 }298299 fn balance(&self, account: T::CrossAccountId, token: TokenId) -> u128 {300 if <TokenData<T>>::get((self.id, token))301 .map(|a| a.owner == account)302 .unwrap_or(false)303 {304 1305 } else {306 0307 }308 }309310 fn allowance(311 &self,312 sender: T::CrossAccountId,313 spender: T::CrossAccountId,314 token: TokenId,315 ) -> u128 {316 if <TokenData<T>>::get((self.id, token))317 .map(|a| a.owner != sender)318 .unwrap_or(true)319 {320 0321 } else if <Allowance<T>>::get((self.id, token)) == Some(spender) {322 1323 } else {324 0325 }326 }327}pallets/nonfungible/src/erc.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/erc.rs
+++ b/pallets/nonfungible/src/erc.rs
@@ -256,6 +256,10 @@
let caller = T::CrossAccountId::from_eth(caller);
let to = T::CrossAccountId::from_eth(to);
let token_id: u32 = token_id.try_into()?;
+ let budget = self
+ .recorder
+ .weight_calls_budget(<StructureWeight<T>>::find_parent());
+
if <TokensMinted<T>>::get(self.id)
.checked_add(1)
.ok_or("item id overflow")?
@@ -272,6 +276,7 @@
variable_data: BoundedVec::default(),
owner: to,
},
+ &budget,
)
.map_err(dispatch_to_evm::<T>)?;
@@ -296,6 +301,10 @@
let caller = T::CrossAccountId::from_eth(caller);
let to = T::CrossAccountId::from_eth(to);
let token_id: u32 = token_id.try_into().map_err(|_| "amount overflow")?;
+ let budget = self
+ .recorder
+ .weight_calls_budget(<StructureWeight<T>>::find_parent());
+
if <TokensMinted<T>>::get(self.id)
.checked_add(1)
.ok_or("item id overflow")?
@@ -314,6 +323,7 @@
variable_data: BoundedVec::default(),
owner: to,
},
+ &budget,
)
.map_err(dispatch_to_evm::<T>)?;
Ok(true)
@@ -338,8 +348,11 @@
let caller = T::CrossAccountId::from_eth(caller);
let to = T::CrossAccountId::from_eth(to);
let token = token_id.try_into()?;
+ let budget = self
+ .recorder
+ .weight_calls_budget(<StructureWeight<T>>::find_parent());
- <Pallet<T>>::transfer(self, &caller, &to, token).map_err(dispatch_to_evm::<T>)?;
+ <Pallet<T>>::transfer(self, &caller, &to, token, &budget).map_err(dispatch_to_evm::<T>)?;
Ok(())
}
@@ -409,6 +422,9 @@
let mut expected_index = <TokensMinted<T>>::get(self.id)
.checked_add(1)
.ok_or("item id overflow")?;
+ let budget = self
+ .recorder
+ .weight_calls_budget(<StructureWeight<T>>::find_parent());
let total_tokens = token_ids.len();
for id in token_ids.into_iter() {
@@ -426,7 +442,8 @@
})
.collect();
- <Pallet<T>>::create_multiple_items(self, &caller, data).map_err(dispatch_to_evm::<T>)?;
+ <Pallet<T>>::create_multiple_items(self, &caller, data, &budget)
+ .map_err(dispatch_to_evm::<T>)?;
Ok(true)
}
@@ -447,6 +464,9 @@
let mut expected_index = <TokensMinted<T>>::get(self.id)
.checked_add(1)
.ok_or("item id overflow")?;
+ let budget = self
+ .recorder
+ .weight_calls_budget(<StructureWeight<T>>::find_parent());
let mut data = Vec::with_capacity(tokens.len());
for (id, token_uri) in tokens {
@@ -465,7 +485,8 @@
});
}
- <Pallet<T>>::create_multiple_items(self, &caller, data).map_err(dispatch_to_evm::<T>)?;
+ <Pallet<T>>::create_multiple_items(self, &caller, data, &budget)
+ .map_err(dispatch_to_evm::<T>)?;
Ok(true)
}
}
pallets/nonfungible/src/lib.rsdiffbeforeafterboth--- a/pallets/nonfungible/src/lib.rs
+++ b/pallets/nonfungible/src/lib.rs
@@ -251,6 +251,7 @@
from: &T::CrossAccountId,
to: &T::CrossAccountId,
token: TokenId,
+ nesting_budget: &dyn Budget,
) -> DispatchResult {
ensure!(
collection.limits.transfers_enabled(),
@@ -294,12 +295,12 @@
let handle = <CollectionHandle<T>>::try_get(target.0)?;
let dispatch = T::CollectionDispatch::dispatch(handle);
let dispatch = dispatch.as_dyn();
-
- // =========
- dispatch.nest_token(from.clone(), (collection.id, token), target.1)?;
+ dispatch.check_nesting(from.clone(), collection.id, target.1, nesting_budget)?;
}
+ // =========
+
<TokenData<T>>::insert(
(collection.id, token),
ItemData {
@@ -340,6 +341,7 @@
collection: &NonfungibleHandle<T>,
sender: &T::CrossAccountId,
data: Vec<CreateItemData<T>>,
+ nesting_budget: &dyn Budget,
) -> DispatchResult {
if !collection.is_owner_or_admin(sender) {
ensure!(
@@ -379,6 +381,16 @@
);
}
+ for (to, _) in balances.iter() {
+ if let Some(target) = T::CrossTokenAddressMapping::address_to_token(to) {
+ let handle = <CollectionHandle<T>>::try_get(target.0)?;
+ let dispatch = T::CollectionDispatch::dispatch(handle);
+ let dispatch = dispatch.as_dyn();
+
+ dispatch.check_nesting(sender.clone(), collection.id, target.1, nesting_budget)?;
+ }
+ }
+
// =========
<TokensMinted<T>>::insert(collection.id, tokens_minted);
@@ -556,7 +568,7 @@
// =========
// Allowance is reset in [`transfer`]
- Self::transfer(collection, from, to, token)
+ Self::transfer(collection, from, to, token, nesting_budget)
}
pub fn burn_from(
@@ -595,35 +607,34 @@
Ok(())
}
- pub fn nest_token(
+ pub fn check_nesting(
handle: &NonfungibleHandle<T>,
sender: T::CrossAccountId,
from: CollectionId,
under: TokenId,
+ nesting_budget: &dyn Budget,
) -> DispatchResult {
fn ensure_sender_allowed<T: Config>(
collection: CollectionId,
token: TokenId,
sender: T::CrossAccountId,
+ budget: &dyn Budget,
) -> DispatchResult {
ensure!(
- <TokenData<T>>::get((collection, token))
- .ok_or(<CommonError<T>>::TokenNotFound)?
- .owner
- .conv_eq(&sender),
+ <PalletStructure<T>>::indirectly_owned(sender, collection, token, budget)?,
<CommonError<T>>::OnlyOwnerAllowedToNest,
);
Ok(())
}
match handle.limits.nesting_rule() {
NestingRule::Disabled => fail!(<CommonError<T>>::NestingIsDisabled),
- NestingRule::Owner => ensure_sender_allowed::<T>(from, under, sender)?,
+ NestingRule::Owner => ensure_sender_allowed::<T>(from, under, sender, nesting_budget)?,
NestingRule::OwnerRestricted(whitelist) => {
ensure!(
whitelist.contains(&from),
<CommonError<T>>::SourceCollectionIsNotAllowedToNest
);
- ensure_sender_allowed::<T>(from, under, sender)?
+ ensure_sender_allowed::<T>(from, under, sender, nesting_budget)?
}
}
Ok(())
@@ -634,7 +645,8 @@
collection: &NonfungibleHandle<T>,
sender: &T::CrossAccountId,
data: CreateItemData<T>,
+ nesting_budget: &dyn Budget,
) -> DispatchResult {
- Self::create_multiple_items(collection, sender, vec![data])
+ Self::create_multiple_items(collection, sender, vec![data], nesting_budget)
}
}
pallets/refungible/src/common.rsdiffbeforeafterboth--- a/pallets/refungible/src/common.rs
+++ b/pallets/refungible/src/common.rs
@@ -19,7 +19,8 @@
use sp_std::collections::btree_map::BTreeMap;
use frame_support::{dispatch::DispatchResultWithPostInfo, fail, weights::Weight, BoundedVec};
use up_data_structs::{
- TokenId, CustomDataLimit, CreateItemExData, CreateRefungibleExData, budget::Budget,
+ CollectionId, TokenId, CustomDataLimit, CreateItemExData, CreateRefungibleExData,
+ budget::Budget,
};
use pallet_common::{CommonCollectionOperations, CommonWeightInfo, with_weight};
use sp_runtime::DispatchError;
@@ -120,9 +121,15 @@
sender: T::CrossAccountId,
to: T::CrossAccountId,
data: up_data_structs::CreateItemData,
+ nesting_budget: &dyn Budget,
) -> DispatchResultWithPostInfo {
with_weight(
- <Pallet<T>>::create_item(self, &sender, map_create_data::<T>(data, &to)?),
+ <Pallet<T>>::create_item(
+ self,
+ &sender,
+ map_create_data::<T>(data, &to)?,
+ nesting_budget,
+ ),
<CommonWeights<T>>::create_item(),
)
}
@@ -132,6 +139,7 @@
sender: T::CrossAccountId,
to: T::CrossAccountId,
data: Vec<up_data_structs::CreateItemData>,
+ nesting_budget: &dyn Budget,
) -> DispatchResultWithPostInfo {
let data = data
.into_iter()
@@ -140,7 +148,7 @@
let amount = data.len();
with_weight(
- <Pallet<T>>::create_multiple_items(self, &sender, data),
+ <Pallet<T>>::create_multiple_items(self, &sender, data, nesting_budget),
<CommonWeights<T>>::create_multiple_items(amount as u32),
)
}
@@ -149,6 +157,7 @@
&self,
sender: <T>::CrossAccountId,
data: CreateItemExData<T::CrossAccountId>,
+ nesting_budget: &dyn Budget,
) -> DispatchResultWithPostInfo {
let weight = <CommonWeights<T>>::create_multiple_items_ex(&data);
let data = match data {
@@ -162,7 +171,7 @@
};
with_weight(
- <Pallet<T>>::create_multiple_items(self, &sender, data),
+ <Pallet<T>>::create_multiple_items(self, &sender, data, nesting_budget),
weight,
)
}
@@ -185,9 +194,10 @@
to: T::CrossAccountId,
token: TokenId,
amount: u128,
+ nesting_budget: &dyn Budget,
) -> DispatchResultWithPostInfo {
with_weight(
- <Pallet<T>>::transfer(self, &from, &to, token, amount),
+ <Pallet<T>>::transfer(self, &from, &to, token, amount, nesting_budget),
<CommonWeights<T>>::transfer(),
)
}
@@ -247,11 +257,12 @@
)
}
- fn nest_token(
+ fn check_nesting(
&self,
_sender: <T>::CrossAccountId,
- _from: (up_data_structs::CollectionId, TokenId),
+ _from: CollectionId,
_under: TokenId,
+ _budget: &dyn Budget,
) -> sp_runtime::DispatchResult {
fail!(<Error<T>>::RefungibleDisallowsNesting)
}
pallets/refungible/src/lib.rsdiffbeforeafterboth--- a/pallets/refungible/src/lib.rs
+++ b/pallets/refungible/src/lib.rs
@@ -289,6 +289,7 @@
to: &T::CrossAccountId,
token: TokenId,
amount: u128,
+ nesting_budget: &dyn Budget,
) -> DispatchResult {
ensure!(
collection.limits.transfers_enabled(),
@@ -351,10 +352,10 @@
let dispatch = T::CollectionDispatch::dispatch(handle);
let dispatch = dispatch.as_dyn();
- // =========
+ dispatch.check_nesting(from.clone(), collection.id, target.1, nesting_budget)?;
+ }
- dispatch.nest_token(from.clone(), (collection.id, token), target.1)?;
- }
+ // =========
if let Some(balance_to) = balance_to {
// from != to
@@ -389,6 +390,7 @@
collection: &RefungibleHandle<T>,
sender: &T::CrossAccountId,
data: Vec<CreateRefungibleExData<T::CrossAccountId>>,
+ nesting_budget: &dyn Budget,
) -> DispatchResult {
if !collection.is_owner_or_admin(sender) {
ensure!(
@@ -453,6 +455,23 @@
}
}
+ for token in data.iter() {
+ for (to, _) in token.users.iter() {
+ if let Some(target) = T::CrossTokenAddressMapping::address_to_token(to) {
+ let handle = <CollectionHandle<T>>::try_get(target.0)?;
+ let dispatch = T::CollectionDispatch::dispatch(handle);
+ let dispatch = dispatch.as_dyn();
+
+ dispatch.check_nesting(
+ sender.clone(),
+ collection.id,
+ target.1,
+ nesting_budget,
+ )?;
+ }
+ }
+ }
+
// =========
<TokensMinted<T>>::insert(collection.id, tokens_minted);
@@ -591,7 +610,7 @@
// =========
- Self::transfer(collection, from, to, token, amount)?;
+ Self::transfer(collection, from, to, token, amount, nesting_budget)?;
if let Some(allowance) = allowance {
Self::set_allowance_unchecked(collection, from, spender, token, allowance);
}
@@ -648,7 +667,8 @@
collection: &RefungibleHandle<T>,
sender: &T::CrossAccountId,
data: CreateRefungibleExData<T::CrossAccountId>,
+ nesting_budget: &dyn Budget,
) -> DispatchResult {
- Self::create_multiple_items(collection, sender, vec![data])
+ Self::create_multiple_items(collection, sender, vec![data], nesting_budget)
}
}
pallets/structure/src/lib.rsdiffbeforeafterboth--- a/pallets/structure/src/lib.rs
+++ b/pallets/structure/src/lib.rs
@@ -19,7 +19,6 @@
use frame_support::Parameter;
use frame_support::dispatch::{GetDispatchInfo, UnfilteredDispatchable};
use frame_support::pallet_prelude::*;
- use frame_system::pallet_prelude::*;
use super::*;
pallets/unique/src/lib.rsdiffbeforeafterboth--- a/pallets/unique/src/lib.rs
+++ b/pallets/unique/src/lib.rs
@@ -693,8 +693,9 @@
#[transactional]
pub fn create_item(origin, collection_id: CollectionId, owner: T::CrossAccountId, data: CreateItemData) -> DispatchResultWithPostInfo {
let sender = T::CrossAccountId::from_sub(ensure_signed(origin)?);
+ let budget = budget::Value::new(2);
- dispatch_call::<T, _>(collection_id, |d| d.create_item(sender, owner, data))
+ dispatch_call::<T, _>(collection_id, |d| d.create_item(sender, owner, data, &budget))
}
/// This method creates multiple items in a collection created with CreateCollection method.
@@ -720,16 +721,18 @@
pub fn create_multiple_items(origin, collection_id: CollectionId, owner: T::CrossAccountId, items_data: Vec<CreateItemData>) -> DispatchResultWithPostInfo {
ensure!(!items_data.is_empty(), Error::<T>::EmptyArgument);
let sender = T::CrossAccountId::from_sub(ensure_signed(origin)?);
+ let budget = budget::Value::new(2);
- dispatch_call::<T, _>(collection_id, |d| d.create_multiple_items(sender, owner, items_data))
+ dispatch_call::<T, _>(collection_id, |d| d.create_multiple_items(sender, owner, items_data, &budget))
}
#[weight = <CommonWeights<T>>::create_multiple_items_ex(&data)]
#[transactional]
pub fn create_multiple_items_ex(origin, collection_id: CollectionId, data: CreateItemExData<T::CrossAccountId>) -> DispatchResultWithPostInfo {
let sender = T::CrossAccountId::from_sub(ensure_signed(origin)?);
+ let budget = budget::Value::new(2);
- dispatch_call::<T, _>(collection_id, |d| d.create_multiple_items_ex(sender, data))
+ dispatch_call::<T, _>(collection_id, |d| d.create_multiple_items_ex(sender, data, &budget))
}
// TODO! transaction weight
@@ -839,8 +842,9 @@
#[transactional]
pub fn transfer(origin, recipient: T::CrossAccountId, collection_id: CollectionId, item_id: TokenId, value: u128) -> DispatchResultWithPostInfo {
let sender = T::CrossAccountId::from_sub(ensure_signed(origin)?);
+ let budget = budget::Value::new(2);
- dispatch_call::<T, _>(collection_id, |d| d.transfer(sender, recipient, item_id, value))
+ dispatch_call::<T, _>(collection_id, |d| d.transfer(sender, recipient, item_id, value, &budget))
}
/// Set, change, or remove approved address to transfer the ownership of the NFT.